@songsid/agend 2.3.0-beta.22 → 2.3.0-beta.24

package/dist/web-api.js

@@ -1,3 +1,5 @@
+import { canvasWorkerEnabled, CANVAS_WORKER_EXPERIMENTAL_MESSAGE } from "./web-experimental.js";
+import { isCanvasWorkerHttpPath } from "./web-experimental-http.js";
 import { webHumanOrigin } from "./human-delivery-receipts.js";
 import { classifyWebPeer, confirmAfterBody, noAuthority } from "./authority/web-authority.js";
 import { guestChatRefusal, guestCommandText, guestDeliveries, guestFrameData, guestHistory, guestMessages, guestPollBody, guestPrefs, guestRequestOf, guestSeesMessage, guestStatus } from "./web-guest-access.js";
@@ -38,7 +40,7 @@ import { readStatuslineModel, resolveInstanceContext } from "./topic-commands.js
 import { z } from "zod";
 import { evaluateWebRequest, isPassiveWebRead, isSecureRequest, isWebRequestAuthorized, WEB_TOKEN_INVALID_MESSAGE } from "./web-auth.js";
 import { dashboardOriginFor } from "./web-preview.js";
-import { newWebMessageId, parseLastEventId, webChatReplyRef, webChatReplyText } from "./web-chat-history.js";
+import { WEB_CHAT_CARDS_OVERFLOW, newWebMessageId, parseLastEventId, webChatReplyRef, webChatReplyText } from "./web-chat-history.js";
 import { attachmentDelivery, createPartFile, displayName, fileTooLargeText, INLINE_MIME, isFileId, MEDIA_RANGE_MAX, publicAttachment, UPLOAD_LIMITS, UPLOAD_MAX_MS, UPLOAD_STALL_MS, UploadSniffer, uploadLimits, wellFormed } from "./web-upload.js";
 import { getAgendHome } from "./paths.js";
 import { OPERATOR, isOwnerEffectKey } from "./web-prefs.js";
@@ -123,11 +125,20 @@ const CardMoveSchema = z.object({
     version: z.number().int().optional(),
 }).strict();
 const CardReorderSchema = z.object({ after: CardRef.nullable().optional(), before: CardRef.nullable().optional() }).strict();
-const ProjectCreateSchema = z.object({ name: z.string().max(256), description: z.string().max(BOARD_TEXT).optional() }).strict();
+const ProjectCreateSchema = z.object({ name: z.string().max(256), description: z.string().max(BOARD_TEXT).optional(), leadInstance: z.string().max(256).nullable().optional() }).strict();
+/** #2352: a project's lead must be one of the fleet's instances now (the board keeps any name, as for an assignee). */
+function checkLeadIsInstance(ctx, lead) {
+    const name = lead?.trim();
+    if (name && !(ctx.fleetConfig?.instances && Object.hasOwn(ctx.fleetConfig.instances, name))) {
+        throw new TaskBoardError("invalid", `"${name.slice(0, 64)}" is not one of the fleet's instances`, "lead_not_instance");
+    }
+}
 const ProjectPatchSchema = z.object({
     name: z.string().max(256).optional(),
     description: z.string().max(BOARD_TEXT).optional(),
     archived: z.boolean().optional(),
+    /** #2352: the instance whose channel lists the project's waiting cards (null or "": General). */
+    leadInstance: z.string().max(256).nullable().optional(),
 }).strict();
 const TeamCreateSchema = z.object({
     name: z.string().min(1).max(128).regex(/^[A-Za-z0-9._-]+$/),
@@ -169,6 +180,68 @@ const safeInstanceSegment = (name) => /^[^\\/\x00]+$/.test(name) && name !== "."
  */
 /** #1920 phase 1b: the open streams that are a guest's, and whose — each event is projected for them (guestFrameData). */
 const streamGuests = new WeakMap();
+/**
+ * The task board's rule over the public link: an instance kept out of sight (cross_instance_visibility: hidden) is not
+ * shown, nor a card that names one as its assignee, creator or dispatcher. Off the link nothing is hidden. Read when
+ * asked: the fleet's config as it is now.
+ */
+function boardHiding(ctx, gateway) {
+    const fleet = ctx.fleetConfig;
+    const hiddenName = (n) => gateway && typeof n === "string" && !!n && !!ctx.fleetConfig?.instances?.[n] && crossInstanceVisibility(fleet, n) === "hidden";
+    const hidden = (c) => [c.assignee, c.createdBy, c.dispatcher?.name].some(hiddenName);
+    return { hiddenName, hidden };
+}
+/**
+ * Chat history as the public link may see it (#2341 review): a status line that names board cards (the daily summary)
+ * is withheld while one of them is hidden there now — or no longer on the board — read when asked, so a card hidden
+ * after the line was written is withheld too. Off the link, as is. The cards are read in one query per answer.
+ */
+function visibleMessages(ctx, gateway, messages) {
+    if (!gateway)
+        return messages;
+    // #2341 review r2: a line that named too many cards to keep them all is withheld whole.
+    messages = messages.filter((m) => !(m.cards ?? []).includes(WEB_CHAT_CARDS_OVERFLOW));
+    const named = [...new Set(messages.flatMap((m) => m.cards ?? []))];
+    if (!named.length)
+        return messages;
+    const board = ctx.scheduler?.db.board;
+    const { hidden } = boardHiding(ctx, true);
+    let found;
+    try {
+        found = new Map((board ? board.cardsByCode(named) : []).map((c) => [c.code, c]));
+    }
+    catch {
+        found = new Map();
+    }
+    const withheld = new Set(named.filter((code) => { const c = found.get(code); return !c || hidden(c); }));
+    return messages.filter((m) => !(m.cards ?? []).some((code) => withheld.has(code)));
+}
+/**
+ * Needs you as the public link may see it (#2306 review): a task item whose card the board hides there — or a card
+ * the board no longer has — is left out, with its title and question; everything else as listed. Off the link, as is.
+ * The link reads Needs you by /ui/poll only: its page has no stream (/ui/events answers it 404).
+ */
+function visibleNeeds(ctx, gateway, items) {
+    if (!gateway)
+        return items;
+    const board = ctx.scheduler?.db.board;
+    const { hidden } = boardHiding(ctx, true);
+    return items.filter((i) => {
+        const item = i;
+        if (item.type !== "task")
+            return true;
+        const code = item.card?.code;
+        if (!board || typeof code !== "string")
+            return false;
+        try {
+            const card = board.findCard(code);
+            return !!card && !hidden(card);
+        }
+        catch {
+            return false;
+        }
+    });
+}
 /**
  * #1920 §5.2: one event for the guests' streams only, each as projected for it — a message that has just become what
  * its channel saw (an admin's page already has it, unchanged).
@@ -254,6 +327,8 @@ function jsonText(res, status, body) {
  * board (the newest revision replaces the previous), so it holds one board's JSON at most.
  */
 const boardBodies = new WeakMap();
+/** #2316 review: the same for who works on what (GET /ui/tasks/work), per (revision, names asked for). */
+const workBodies = new WeakMap();
 /**
  * #1630 (#1635 review): an answer that waited on something (a list, a download) is sent only if the request is still
  * allowed — the session not revoked meanwhile, a public link's exposure still current. Otherwise 401, and nothing.
@@ -271,10 +346,14 @@ function stillAuthorized(req, res, url, ctx) {
  * 5 MiB) and DELETE (back to the bundled icon): a signed-in admin's session only — never the CLI's token, a read-only
  * session, a guest or the public link; checked again once the body has arrived.
  */
+/** An app icon refusal as the page reads it: its code, the English detail and, when named, the detail's key (#2390). */
+function appIconRefusal(r) {
+    return { error: r.error, ...(r.detail ? { detail: r.detail } : {}), ...(r.detail_key ? { detail_key: r.detail_key } : {}), ...(r.detail_args ? { detail_args: r.detail_args } : {}) };
+}
 function handleAppIcon(req, res, url, ctx, method) {
     const store = ctx.appIcon;
     if (!store) {
-        json(res, 404, { error: "The app icon is not kept on this fleet" });
+        json(res, 404, { error: "app_icon_not_kept", detail: "The app icon is not kept on this fleet" });
         return true;
     }
     const reading = method === "GET" || method === "HEAD";
@@ -310,7 +389,7 @@ function handleAppIcon(req, res, url, ctx, method) {
     if (method === "DELETE") {
         const reset = store.reset();
         if (!reset.ok) {
-            json(res, reset.status, { error: reset.error, ...(reset.detail ? { detail: reset.detail } : {}) });
+            json(res, reset.status, appIconRefusal(reset));
             return true;
         }
         json(res, 200, state());
@@ -335,7 +414,7 @@ function handleAppIcon(req, res, url, ctx, method) {
             bytes = await readBoundedWebBody(req, APP_ICON_MAX_BYTES);
         }
         catch {
-            json(res, 413, { error: "app_icon_too_large", detail: "at most 5 MiB" });
+            json(res, 413, { error: "app_icon_too_large", detail: "at most 5 MiB", detail_key: "max_size", detail_args: [5] });
             return;
         }
         if (!again())
@@ -343,7 +422,7 @@ function handleAppIcon(req, res, url, ctx, method) {
         // #2308 review: decoding and making the sizes is seconds of CPU at worst — a worker thread's, not the fleet loop's.
         const prepared = await store.prepare(bytes);
         if (!prepared.ok) {
-            json(res, prepared.status, { error: prepared.error, ...(prepared.detail ? { detail: prepared.detail } : {}) });
+            json(res, prepared.status, appIconRefusal(prepared));
             return;
         }
         const person = again();
@@ -351,14 +430,14 @@ function handleAppIcon(req, res, url, ctx, method) {
             return;
         const saved = store.commit(prepared.prepared, person);
         if (!saved.ok) {
-            json(res, saved.status, { error: saved.error, ...(saved.detail ? { detail: saved.detail } : {}) });
+            json(res, saved.status, appIconRefusal(saved));
             return;
         }
         json(res, 200, state());
     })().catch((err) => {
         ctx.logger.error({ err: err.message }, "App icon request failed");
         try {
-            json(res, 500, { error: "App icon request failed" });
+            json(res, 500, { error: "app_icon_failed", detail: "App icon request failed" });
         }
         catch { /* already answered */ }
     });
@@ -661,6 +740,10 @@ function handleEffectTrials(req, res, url, ctx, path, method) {
             json(res, now.status, { error: now.error });
             return;
         }
+        if (!canvasWorkerEnabled(ctx.fleetConfig?.web)) {
+            json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
+            return;
+        }
         if (now.record !== first.record || now.sessions !== first.sessions || now.actor.sessionHash !== first.actor.sessionHash
             || now.actor.person !== first.actor.person || now.actor.epoch !== first.actor.epoch) {
             json(res, 409, { error: "trials_person_changed" });
@@ -896,6 +979,10 @@ function handleEffects(req, res, url, ctx, path, method) {
             json(res, now.status, { error: now.error });
             return;
         }
+        if (!canvasWorkerEnabled(ctx.fleetConfig?.web)) {
+            json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
+            return;
+        }
         if (now.person !== first.person || now.epoch !== first.epoch) {
             json(res, 409, { error: "effects_person_changed" });
             return;
@@ -1017,6 +1104,10 @@ function handleMods(req, res, url, ctx, path, method) {
         // So the export ACL judges what the file carries, not what was installed: it downloads only when this person may
         // read every effect in it (their own claim on that content, or a shared one). A file without effects is any admin's.
         const fx = mods.bundleEffects(fileMatch[1]);
+        if (!canvasWorkerEnabled(ctx.fleetConfig?.web) && (fx === "unknown" || (fx?.length ?? 0) > 0)) {
+            json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
+            return true;
+        }
         if (fx === "unknown" || (fx ?? []).some(id => !ctx.modPlacedEffect?.(first.person, id))) {
             json(res, 403, { error: "mod_effects_not_yours", detail: "this mod's file carries effects that are not yours to share: export your own look instead" });
             return true;
@@ -1147,7 +1238,7 @@ export function exportMod(ctx, person, body) {
             // The effects the theme places travel with it, as the library keeps them (a person may export what is placed).
             // Only effects this person may carry away travel (Sol's ACL); the rest are counted, never packaged.
             // #2017: an older placement of an effect that doesn't play in chat stays out (a mod can't place it): counted.
-            const effects = rec.placements.effects.flatMap(p => { const e = ctx.modPlacedEffect?.(person, p.id); if (!e || !filesPlayInChat(e.files)) {
+            const effects = (canvasWorkerEnabled(ctx.fleetConfig?.web) ? rec.placements.effects : []).flatMap(p => { const e = ctx.modPlacedEffect?.(person, p.id); if (!e || !filesPlayInChat(e.files)) {
                 omitted++;
                 return [];
             } return [{ name: e.name, files: e.files, params: p.params ?? {} }]; });
@@ -1398,6 +1489,10 @@ function statusTick(ctx, t) {
 export function handleWebRequest(req, res, url, ctx) {
     const path = url.pathname;
     const method = req.method ?? "GET";
+    if (!canvasWorkerEnabled(ctx.fleetConfig?.web) && isCanvasWorkerHttpPath(path)) {
+        json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
+        return true;
+    }
     // Auth check for all /ui routes. Defence in depth behind the fleet-manager
     // gate: the same session cookie or header token, and an unset token closes
     // the panel instead of comparing null against a missing credential.
@@ -1545,7 +1640,8 @@ export function handleWebRequest(req, res, url, ctx) {
         }
         json(res, 200, {
             status: ctx.getUiStatus(),
-            messages: history ? (fresh ? history.after(0) : history.replayFor(parseLastEventId(after))) : [],
+            // #2341 review: over the public link, without a summary line that names a card hidden there.
+            messages: history ? visibleMessages(ctx, !!gatewayRequestContext(req), fresh ? history.after(0) : history.replayFor(parseLastEventId(after))) : [],
             // The ticks too, so polling never has to re-read a chat's history — that read would count as the person's
             // activity; this poll does not (isPassiveWebRead).
             deliveries: history ? history.deliveries() : [],
@@ -1555,8 +1651,9 @@ export function handleWebRequest(req, res, url, ctx) {
             reactions: history ? history.reactionStates() : [],
             // And the fleet prompts open on the dashboard (C4): prompt events are stream-only too.
             prompts: ctx.listWebPrompts?.() ?? [],
-            // #1386: "Needs you" rides the passive channels only — no endpoint of its own to poll.
-            needs: ctx.needsYouItems?.() ?? [],
+            // #1386: "Needs you" rides the passive channels only — no endpoint of its own to poll. Over the public link,
+            // without the task board's hidden cards (#2306 review).
+            needs: visibleNeeds(ctx, !!gatewayRequestContext(req), ctx.needsYouItems?.() ?? []),
             // #1577: the newest message this answer accounts for — after a restart, the last restored one until this process
             // records its own (`<boot>-0` would be after(0): the whole restored history again on every poll).
             cursor: history ? history.pollCursor() : null,
@@ -1672,7 +1769,8 @@ export function handleWebRequest(req, res, url, ctx) {
         }
         // #1920 §5.2: a guest gets what the channel showed of it, and its own messages (the gate checked the scope).
         const guest = guestRequestOf(req);
-        const messages = !ctx.webChatHistory ? [] : guest ? guestHistory(ctx.webChatHistory, instance, limit, guest, guest.scope()) : ctx.webChatHistory.list(instance, limit);
+        const messages = !ctx.webChatHistory ? [] : guest ? guestHistory(ctx.webChatHistory, instance, limit, guest, guest.scope())
+            : visibleMessages(ctx, !!gatewayRequestContext(req), ctx.webChatHistory.list(instance, limit));
         json(res, 200, { messages, boot: ctx.webChatHistory?.boot ?? null, lastId: ctx.webChatHistory?.lastId ?? 0 });
         return true;
     }
@@ -2166,6 +2264,10 @@ export function handleWebRequest(req, res, url, ctx) {
                 return;
             }
             const personal = [...parsed.patch.keys()].some(isOwnerEffectKey);
+            if (personal && !canvasWorkerEnabled(ctx.fleetConfig?.web)) {
+                json(res, 403, { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE });
+                return;
+            }
             if (personal && now.person === null) {
                 json(res, 403, { error: "prefs_need_a_signed_in_person" });
                 return;
@@ -2642,10 +2744,10 @@ export function handleWebRequest(req, res, url, ctx) {
     }
     // ── Task board (scheduler/task-board.ts) ──────────────
     // Reads are the session's; every write is the signed-in person's, through the same rules an instance's tools use.
-    if (path === "/ui/tasks/board" || path === "/ui/tasks/search" || path.startsWith("/ui/tasks/cards") || path.startsWith("/ui/tasks/projects")) {
+    if (path === "/ui/tasks/board" || path === "/ui/tasks/search" || path === "/ui/tasks/work" || path.startsWith("/ui/tasks/cards") || path.startsWith("/ui/tasks/projects")) {
         const board = ctx.scheduler?.db.board;
         if (!board) {
-            json(res, 503, { error: "The task board is not available" });
+            json(res, 503, { error: "The task board is not available", code: "unavailable", key: "unavailable" });
             return true;
         }
         // The temporary public link reads the board and changes nothing on it: confirming, sending back, cancelling and
@@ -2656,9 +2758,7 @@ export function handleWebRequest(req, res, url, ctx) {
             return true;
         }
         // …nor shows the cards of instances kept out of sight (cross_instance_visibility: hidden).
-        const fleet = ctx.fleetConfig;
-        const hiddenName = (n) => !!gateway && typeof n === "string" && !!n && !!ctx.fleetConfig?.instances?.[n] && crossInstanceVisibility(fleet, n) === "hidden";
-        const hidden = (c) => [c.assignee, c.createdBy, c.dispatcher?.name].some(hiddenName);
+        const { hiddenName, hidden } = boardHiding(ctx, !!gateway);
         // #2303 review: what a visible card shows of the cards around it follows the same rule — its children, its main
         // task (a search hit's too) — and so do the words and the history a hidden instance left on it.
         // …and a hidden instance's words on a visible card are not counted, named or found there (#2304 review).
@@ -2695,12 +2795,53 @@ export function handleWebRequest(req, res, url, ctx) {
                     return true;
                 }
                 const cards = board.boardCards(undefined, allDone).filter((c) => !hidden(c));
-                const body = JSON.stringify({ rev, cards: board.views(cards, scope), projects: board.listProjects(true), stats: board.projectStats() });
+                // #2352: over the public link a hidden lead is not named (the project reads as having none).
+                const projects = board.listProjects(true).map((p) => (p.leadInstance && hiddenName(p.leadInstance) ? { ...p, leadInstance: null } : p));
+                // #2355 review: the names a project's lead may be — the fleet's instances (a Classic-only room is not one); over the
+                // public link, not a hidden one.
+                const leads = Object.keys(ctx.fleetConfig?.instances ?? {}).filter((n) => !hiddenName(n)).sort();
+                const body = JSON.stringify({ rev, cards: board.views(cards, scope), projects, leads, stats: board.projectStats() });
                 if (key)
                     boardBodies.set(board, { key, body });
                 jsonText(res, 200, body);
                 return true;
             }
+            if (method === "GET" && path === "/ui/tasks/work") {
+                // #2246 step 3: each instance's work on the board — what its `task mine` reads (myWork) — for the board's
+                // Instance list and an instance's Details page (`?instance=`): the fleet's instances and anyone else a live
+                // card is assigned to. Over the public link, not those kept out of sight, nor a card that names one. Every
+                // name's work is one workOf() read and the cards one views() read, whatever the number of instances (#2316
+                // review); on the dashboard the answer is built once per board revision and the names asked for, and shared
+                // by every open drawer (the public link's is filtered per request, as the board's).
+                const only = url.searchParams.get("instance");
+                const names = (only ? [only] : [...new Set([...Object.keys(ctx.fleetConfig?.instances ?? {}), ...board.liveAssignees()])]).filter((n) => !hiddenName(n));
+                const key = gateway ? null : `${board.revision()}:${only === null ? "*" : `=${only}`}:${names.join("\u0000")}`;
+                const kept = key ? workBodies.get(board) : undefined;
+                if (kept && kept.key === key) {
+                    jsonText(res, 200, kept.body);
+                    return true;
+                }
+                const byName = board.workOf(names);
+                const works = names.map((name) => ({ name, w: byName.get(name) }));
+                const all = new Map();
+                for (const { w } of works)
+                    for (const c of [...w.doing, ...w.blocked, ...w.review, ...w.ready, ...w.waiting.map((x) => x.card), ...w.mains.map((x) => x.card)])
+                        if (!hidden(c))
+                            all.set(c.uuid, c);
+                const viewOf = new Map(board.views([...all.values()], scope).map((v) => [v.uuid, v]));
+                const drawn = (cards) => cards.flatMap((c) => (viewOf.has(c.uuid) ? [viewOf.get(c.uuid)] : []));
+                const codes = (cards) => cards.filter((x) => all.has(x.card.uuid)).map((x) => x.card.code);
+                const body = JSON.stringify({ instances: works.map(({ name, w }) => ({
+                        name,
+                        doing: drawn(w.doing), blocked: drawn(w.blocked), review: drawn(w.review), ready: drawn(w.ready),
+                        waiting: drawn(w.waiting.map((x) => x.card)), mains: drawn(w.mains.map((x) => x.card)),
+                        sentBack: codes(w.sentBack), newComments: codes(w.newComments),
+                    })) });
+                if (key)
+                    workBodies.set(board, { key, body });
+                jsonText(res, 200, body);
+                return true;
+            }
             if (method === "GET" && path === "/ui/tasks/search") {
                 const names = new Map(board.listProjects(true).map((p) => [p.id, p.name]));
                 const hits = board.search(url.searchParams.get("q") ?? "", Number(url.searchParams.get("limit")) || 20, scope).filter((h) => !hidden(h.card));
@@ -2749,11 +2890,11 @@ export function handleWebRequest(req, res, url, ctx) {
                 return true;
             }
             if (method === "POST" && path === "/ui/tasks/projects") {
-                boardWrite(req, res, url, ctx, board, ProjectCreateSchema, (input, person) => ({ project: board.createProject(person, input) }));
+                boardWrite(req, res, url, ctx, board, ProjectCreateSchema, (input, person) => { checkLeadIsInstance(ctx, input.leadInstance); return { project: board.createProject(person, input) }; });
                 return true;
             }
             if (method === "POST" && project) {
-                boardWrite(req, res, url, ctx, board, ProjectPatchSchema, (patch, person) => ({ project: board.updateProject(person, Number(project[1]), patch) }));
+                boardWrite(req, res, url, ctx, board, ProjectPatchSchema, (patch, person) => { checkLeadIsInstance(ctx, patch.leadInstance); return { project: board.updateProject(person, Number(project[1]), patch) }; });
                 return true;
             }
         }
@@ -3765,6 +3906,7 @@ function shellBodyTag(req, ctx, mode, viewer) {
         + ` data-usage-panel="${ctx.fleetConfig?.web?.usage_panel === false || viewer?.guest ? "0" : "1"}"`
         // #1218: whether the Log tab is on (web.log_tab; off by default): the tab says so and offers to turn it on.
         + ` data-log-tab="${ctx.fleetConfig?.web?.log_tab === true ? "1" : "0"}"`
+        + ` data-canvas-worker="${canvasWorkerEnabled(ctx.fleetConfig?.web) ? "1" : "0"}"`
         // #1937: the upload limits in force for this page (the config's; the public link's own cap on it) — what the chat
         // checks before sending a file, and the numbers its words say. The server checks again on every upload.
         + ` data-upload-limits="${attr(JSON.stringify(uploadLimits(ctx.fleetConfig?.web, { publicLink: gatewayRequestContext(req) !== undefined })))}"`