@songsid/agend 2.3.0-beta.22 → 2.3.0-beta.24

package/dist/fleet-manager.js

@@ -1,7 +1,7 @@
-import { PUBLIC_TUNNEL_TOKEN_ENV, validPublicTunnelToken } from "./public-tunnel-config.js";
+import { PUBLIC_TUNNEL_TOKEN_ENV, PUBLIC_TUNNEL_TOKEN_HINT, normalizePublicTunnelToken } from "./public-tunnel-config.js";
 import { humanOwnerObjectId, webHumanOrigin } from "./human-delivery-receipts.js";
 import { SettingsBaselines } from "./settings-baseline.js";
-import { SettingsConfirmationStore } from "./settings-confirmation.js";
+import { SettingsConfirmationStore, settingsSourceLabel } from "./settings-confirmation.js";
 import { SettingsHttpConfirmation } from "./settings-http-confirmation.js";
 import { SettingsControlServer } from "./settings-control.js";
 import { SettingsExecution, settingsRevision, noteSettingsWrite, settingsFileResource, assertSettingsLease, trySettingsLease, waitSettingsLease, settingsUndo, undoSettingsPaths } from "./settings-transaction.js";
@@ -77,10 +77,12 @@ import { routeToolCall } from "./channel/tool-router.js";
 import { Scheduler } from "./scheduler/index.js";
 import { boardActivity, boardCardLimit, boardToolAction } from "./task-board-tool.js";
 import { TaskBoardWaker } from "./task-board-waker.js";
+import { TaskBoardError, wrapUpGap } from "./scheduler/task-board.js";
 import { escapeTelegramHtml, scheduleClock, scheduleRetryLabel } from "./scheduler/retry-label.js";
 import { DEFAULT_SCHEDULER_CONFIG } from "./scheduler/index.js";
 import { TopicCommands, saveCommandForBackend, parseSaveFilename, parsePauseWakeCommand, parseCompactCommand, SAVE_FILENAME_RE, resolveInstanceContext, forgetInstanceContext, readStatuslineJson, statuslineModel } from "./topic-commands.js";
 import { DailySummary } from "./daily-summary.js";
+import { TaskBoardSummaryClock, buildSummary, isQuiet, renderSummary, summaryMarkFile, summaryTime } from "./task-board-summary.js";
 import { WebhookEmitter } from "./webhook-emitter.js";
 import { TmuxControlClient } from "./tmux-control.js";
 import { safeHandler } from "./safe-async.js";
@@ -234,7 +236,7 @@ import { agyLegacyAgentsFile, danglingSymlink, migrateAgyAgentsFile } from "./ba
 import { claudeConfigDirFor, claudeProjectKey } from "./backend/claude-code.js";
 import { sharedRolloutIndex } from "./rollout-index.js";
 import { mayUseTool, resolveToolSet, scheduleOpRefusal, toolForIpcType, toolRefusedMessage, } from "./tool-permissions.js";
-import { authorizeSession, decideWebGate, loadOrCreateWebToken, readWebToken } from "./web-auth.js";
+import { authorizeSession, decideWebGate, loadOrCreateWebToken, readWebToken, sessionCookieUpgrade } from "./web-auth.js";
 import { bypassesWebGate, handleAuthRequest, serveSigninPage } from "./auth-api.js";
 import { isWebPageNavigation } from "./web-shell-routes.js";
 import { guestSessionPolicy, localSessionPolicy, tokenEpoch, WebSessionStore } from "./web-session.js";
@@ -247,6 +249,9 @@ import { decisionListAnswer } from "./decision-list.js";
 import { CodeRequestLimiter, ReturningDevices } from "./web-returning-device.js";
 import { allowedHostNames, applyWebSecurityHeaders, hostnameOf, isHostAllowed, LOOPBACK_HOST_NAMES, WEB_HOST_REJECTED_MESSAGE } from "./web-host-guard.js";
 import { createPreviewListener, normalizeOrigin, previewAvailability, previewSettings } from "./web-preview.js";
+import { canvasWorkerEnabled, isCanvasWorkerTool, CANVAS_WORKER_EXPERIMENTAL_MESSAGE } from "./web-experimental.js";
+import { isCanvasWorkerHttpPath } from "./web-experimental-http.js";
+import { bundledSkillContents } from "./bundled-skills.js";
 import { createEffectBootstrap } from "./web-effect-bootstrap.js";
 import { fleetLevelDifferences, fleetLevelSignature, appendedConnections } from "./fleet-level-config.js";
 import { checkSelfRestartAllowance, recordSelfRestartAttempt } from "./self-restart-limit.js";
@@ -263,6 +268,7 @@ import { mergeBackendOptions, profileKey, profileName, profileOf } from "./class
 import { classifyInstanceChange, CLASSIC_HOT_CONFIG_KEYS, HOT_INSTANCE_CONFIG_KEYS, hotConfigUpdate, } from "./instance-config-impact.js";
 import { cleanupWatchVerdict, formatRestartProgressCompletion, RestartProgress, } from "./restart-progress.js";
 import { launchFullRestartHelper } from "./full-restart.js";
+import { fullReloadExitCode } from "./service-owner.js";
 import { SYSTEMD_RESTART_INDETERMINATE_EXIT_CODE } from "./service-restart-selection.js";
 import { collectRedundantInstanceDefaultPaths } from "./fleet-yaml-slim.js";
 import { StormWindow } from "./storm-window.js";
@@ -673,6 +679,8 @@ export class FleetManager {
     costGuard = null;
     statuslineWatcher;
     dailySummary = null;
+    /** #2246 step 3: the task board's daily summary for the person (task-board-summary.ts). */
+    taskBoardSummary = null;
     dailyTipScheduler = null;
     /** The task board's wakes (step 2): an instance hears when someone else changes a card it owns or handed out. */
     taskBoardWaker = null;
@@ -849,6 +857,7 @@ export class FleetManager {
     effectBootstrap = createEffectBootstrap();
     /** Fixed trusted document coherence, independent of the HTML preview listener; never a resource grant. */
     get effectBoot() { return this.effectBootstrap.boot; }
+    canvasWorkerEnabled() { return canvasWorkerEnabled(this.fleetConfig?.web); }
     healthServerDrain = null;
     /** #1306: the preview listener (health_port + 1 by default), and whether it is listening. */
     previewListener = null;
@@ -1095,6 +1104,7 @@ export class FleetManager {
     /** #1629 r4 §1: get_web_appearance / preview_web_appearance — the caller's own look, resolved as the page resolves it. */
     get appearanceTools() {
         return (this.appearanceToolsService ??= new AppearanceTools({
+            canvasWorkerEnabled: () => this.canvasWorkerEnabled(),
             frame: (name) => (this.getUiStatus().instances.find(i => i.name === name) ?? { name }),
             theme: (name) => {
                 const r = this.themeStore.get(name);
@@ -1139,6 +1149,7 @@ export class FleetManager {
             prefs: this.webPrefs,
             ownerCss: this.ownerCss,
             effects: this.effectLibrary,
+            canvasWorkerEnabled: () => this.canvasWorkerEnabled(),
             context: () => ({ agendVersion: agendVersion(), limits: this.themeStore.limits(), effects: cw1EffectChecker() }),
             isKnownInstance: (name) => this.isKnownInstance(name),
             prefsIdentity: OPERATOR,
@@ -1194,6 +1205,7 @@ export class FleetManager {
      */
     get webSettings() {
         return (this.webSettingsToolsService ??= new WebSettingsTools({
+            canvasWorkerEnabled: () => this.canvasWorkerEnabled(),
             prefs: this.webPrefs, ownerCss: this.ownerCss, mods: this.mods, effects: this.effectService,
             instances: () => [...Object.keys(this.fleetConfig?.instances ?? {}),
                 ...(this.classicChannels?.getAll() ?? []).map((ch) => ch.instanceName).filter((n) => !Object.hasOwn(this.fleetConfig?.instances ?? {}, n))],
@@ -1311,6 +1323,7 @@ export class FleetManager {
                     return null;
                 const record = auth.session, sessions = this.webSessions, exposure = gatewayRequestContext(req);
                 return { id: record.idHash, label: record.label, source: exposure ? "public_link" : "web_session",
+                    localAdmin: () => record.tier === "admin" && record.surface === "local" && !exposure,
                     current: () => current() && sessions === this.webSessions && !!this.webToken
                         && sessions.isCurrent(record, tokenEpoch(this.webToken)) && (!exposure || exposure.isCurrent()) };
             }, baseline: () => baselines.read(), snapshot: () => baselines.snapshot(),
@@ -1370,7 +1383,7 @@ export class FleetManager {
             return null;
         const name = this.webPerson({ adapterId: actor.adapter_id, userId: actor.user_id }).name;
         return {
-            label: `${name} (web-verified)`,
+            label: t("settings_confirm.web_verified_label", name),
             // admin() asks chat.current() too; a General a card could go to must still be there (else the host CLI's).
             current: () => !!verified() && chat.admin(actor.user_id) && this.settingsNoticeGenerals(affected, chat.platform).length > 0,
             done: view => this.settingsWebConfirmedNotice(view, affected, name, chat.platform),
@@ -1397,7 +1410,8 @@ export class FleetManager {
      */
     async settingsWebConfirmedNotice(view, affected, who, platform) {
         const outcome = view.outcome ? view.outcome.message : view.state;
-        const text = `✅ Settings change confirmed from the web by ${who} (web-verified)\nSource: ${view.source}\nRequester: ${view.requested_by}\n${view.summary.join("\n")}\nOutcome: ${outcome}`;
+        const text = [t("settings_confirm.web_confirmed", who), t("settings_confirm.source", settingsSourceLabel(view.source)),
+            t("settings_confirm.requester", view.requested_by), ...view.summary, t("settings_confirm.outcome", outcome)].join("\n");
         for (const { adapterId, adapter, chatId, topic } of this.settingsNoticeGenerals(affected, platform)) {
             try {
                 await adapter.sendText(chatId, text, { threadId: topic, allowedMentions: { parse: [] } });
@@ -1479,9 +1493,10 @@ export class FleetManager {
             try {
                 const posted = this.postNonceButtonPromptOrThrow({ prefix: "settings-confirm:", alertType: "clear_confirm",
                     instanceName: name, adapterId, adapter, chatId, threadId: topic,
-                    message: `🔒 Settings change awaiting fleet-admin confirmation\nSource: ${view.source}\nRequester: ${view.requested_by}\n${view.summary.join("\n")}`,
-                    choices: [{ action: "confirm", label: "Confirm" }, { action: "reject", label: "Reject" }],
-                    expiredText: "Settings confirmation is no longer pending.", timeoutMs: view.remaining_ms,
+                    message: [t("settings_confirm.prompt_title"), t("settings_confirm.source", settingsSourceLabel(view.source)),
+                        t("settings_confirm.requester", view.requested_by), ...view.summary].join("\n"),
+                    choices: [{ action: "confirm", label: t("settings_confirm.confirm_button") }, { action: "reject", label: t("settings_confirm.reject_button") }],
+                    expiredText: t("settings_confirm.no_longer_pending"), timeoutMs: view.remaining_ms,
                     extra: { pendingChangeId: view.id, confirmationCurrent: current, confirmationAdmin: userId => current() && authority.admin(userId) },
                 });
                 void posted.then(nonce => {
@@ -1492,7 +1507,7 @@ export class FleetManager {
                         return;
                     this.pendingNonceButtons.delete(nonce);
                     clearTimeout(entry.timer);
-                    void this.retireNonceButtons(entry, entry.messageId ?? "", "Settings confirmation delivery expired.");
+                    void this.retireNonceButtons(entry, entry.messageId ?? "", t("settings_confirm.delivery_expired"));
                 }, () => { });
                 const nonce = await withinBudget(posted, postingDeadline);
                 attached = true;
@@ -1502,7 +1517,7 @@ export class FleetManager {
                         return;
                     this.pendingNonceButtons.delete(nonce);
                     clearTimeout(entry.timer);
-                    void this.retireNonceButtons(entry, entry.messageId ?? "", "Settings confirmation is no longer pending.");
+                    void this.retireNonceButtons(entry, entry.messageId ?? "", t("settings_confirm.no_longer_pending"));
                 };
                 if (!current()) {
                     retire();
@@ -1528,14 +1543,14 @@ export class FleetManager {
         const { entry, action } = result;
         try {
             const view = await this.settingsGate().store.decide(entry.pendingChangeId, action, {
-                label: `fleet admin ${data.userId}`,
+                label: t("settings_confirm.admin_label", data.userId ?? ""),
                 current: () => entry.confirmationCurrent?.() === true && this.getAdapterForInstance(entry.instanceName) === entry.adapter
                     && !!data.userId && entry.confirmationAdmin?.(data.userId) === true,
             });
-            await this.retireNonceButtons(entry, entry.messageId ?? data.messageId, view.outcome?.message ?? "Settings change is applying.");
+            await this.retireNonceButtons(entry, entry.messageId ?? data.messageId, view.outcome?.message ?? t("settings_confirm.applying"));
         }
         catch {
-            await this.retireNonceButtons(entry, entry.messageId ?? data.messageId, "Settings confirmation rejected or expired.");
+            await this.retireNonceButtons(entry, entry.messageId ?? data.messageId, t("settings_confirm.rejected_or_expired"));
         }
         return true;
     }
@@ -2659,6 +2674,10 @@ export class FleetManager {
         this.savedFleetConfigSnapshot = structuredClone(this.fleetConfig);
         this.warnAboutRemovedLoginMode(loaded);
         this.enforceGuestSwitch();
+        // Child tool/guidance readers must follow this fleet's actual config, including --config.
+        // Scope the path to its owning data directory so another inherited home's override cannot enable CW.
+        process.env.AGEND_FLEET_DATA_DIR = resolvePath(this.dataDir);
+        process.env.AGEND_FLEET_CONFIG_PATH = resolvePath(configPath);
         return this.fleetConfig;
     }
     relayLoginModeWarned = false;
@@ -2838,8 +2857,17 @@ export class FleetManager {
         this.logger.info(`Received SIGUSR1, initiating full restart (process reload)... ${describeSignalSource(this.dataDir, "SIGUSR1")}`);
         this.gracefulShutdownForReload()
             .then(() => {
-            this.logger.info("Full restart: shutdown complete, exiting for reload");
-            process.exit(0);
+            // #2356: under an AgEnD systemd unit a clean exit is a stop (Restart=on-failure); exit so the unit comes back.
+            let ownCgroup = null;
+            try {
+                ownCgroup = readFileSync("/proc/self/cgroup", "utf-8");
+            }
+            catch { /* not Linux */ }
+            const code = fullReloadExitCode(ownCgroup);
+            this.logger.info(code === 0
+                ? "Full restart: shutdown complete, exiting for reload"
+                : `Full restart: shutdown complete, exiting ${code} so the systemd unit restarts the fleet (#2356)`);
+            process.exit(code);
         })
             .catch(err => {
             this.logger.error({ err }, "Full restart: graceful shutdown failed");
@@ -2858,7 +2886,7 @@ export class FleetManager {
             const chatId = String(this.getChannelConfig(adapterId)?.group_id ?? data.channelId);
             this.beginUpdateProgress(adapter, chatId, data.channelId, messageId);
         }
-        const { spawn } = await import("node:child_process");
+        const { spawn } = await import("./child-process.js");
         // Plain `agend update`: the CLI picks the channel from the version it is about to replace (a beta install
         // stays on beta). Deciding here, from the package.json next to THIS code, read a source checkout's 1.22.0 as
         // "not a beta" and sent a beta install to @latest. #1450 C5: the INSTALLED agend, verified, by absolute path.
@@ -4304,6 +4332,18 @@ export class FleetManager {
     async dispatchSlashCore(slash, adapterId, adapter) {
         // #1569: an alias (/web) is its command (/dashboard) from here on — the door, the table and the handler see one name.
         const data = { ...slash, command: canonicalCommand(slash.command) };
+        // #2359: /dashboard stays listed; prefix its reply with the deprecation notice, then run /web's handler.
+        const noteDeprecatedDashboard = () => {
+            if (slash.command !== "dashboard")
+                return;
+            const prefix = `${t("dashboard.deprecated")}\n\n`;
+            const respond = data.respond;
+            data.respond = async (text) => respond(prefix + text);
+            if (data.respondButtons) {
+                const respondButtons = data.respondButtons;
+                data.respondButtons = async (text, choices) => respondButtons(prefix + text, choices);
+            }
+        };
         const door = this.slashDoor(data, adapterId);
         if ("refusal" in door) {
             await data.respond(t(door.refusal)).catch(() => { });
@@ -4314,6 +4354,7 @@ export class FleetManager {
         // — before the table, which keeps /web for fleet admins. Per account: it touches no instance binding.
         // Decided synchronously, so an admin's /web still reaches the table with no await after the door (#1399).
         if (data.command === "dashboard" && this.isGuestWebAsk(adapterId, data.userId)) {
+            noteDeprecatedDashboard();
             await this.guestWebCommand({ adapterId, userId: data.userId, username: data.username,
                 arg: String(data.options?.action ?? "").trim().toLowerCase(), replyHere: text => data.respond(text), replyPrivately: text => data.respond(text) });
             return;
@@ -4342,6 +4383,7 @@ export class FleetManager {
             await data.respond(reply).catch(() => { });
             return;
         }
+        noteDeprecatedDashboard();
         if (data.command === "start") {
             await this.handleClassicStartSlash(data, adapterId);
         }
@@ -7158,6 +7200,17 @@ export class FleetManager {
             return DailySummary.generateText(this.eventLog, instances, costMap, this.costGuard?.getFleetTotalCents() ?? 0);
         });
         this.dailySummary.start();
+        // #2246 step 3: the task board's daily summary — its own time (defaults.task_board.summary_at, read at every look),
+        // in the fleet's zone; a summary missed while the fleet was down goes out when it is back.
+        this.taskBoardSummary = new TaskBoardSummaryClock({
+            at: () => summaryTime(this.fleetConfig?.defaults?.task_board?.summary_at) ?? null,
+            zone: () => this.usageZone(),
+            now: () => new Date(),
+            mark: summaryMarkFile(join(this.dataDir, "task-board-summary.json")),
+            send: (since, until) => this.postTaskBoardSummary(since, until),
+            failed: (err) => this.logger.warn({ err }, "The task board's daily summary failed; the next minute tries again"),
+        });
+        this.taskBoardSummary.start();
         // Rotate classic channel chat logs daily (piggyback on daily summary timer)
         this.classicChannels?.rotateLogs();
         this.rotateInboxes();
@@ -7552,7 +7605,8 @@ export class FleetManager {
         }, 60 * 60 * 1000);
         const onRestart = () => this.onGracefulRestartSignal(() => process.once("SIGUSR2", onRestart));
         process.once("SIGUSR2", onRestart);
-        // SIGUSR1: full process reload (graceful stop → exit → CLI restarts)
+        // SIGUSR1: full process reload (graceful stop → exit). Nothing in this AgEnD sends it any more (#2356); an older
+        // CLI or a hand-sent signal still may, and the exit code then lets the owning manager start the next fleet.
         process.once("SIGUSR1", () => this.onFullRestartSignal());
         // A SIGHUP may arrive after the PID/general is available but before the
         // rest of startup finishes. Replay one coalesced reload only after all
@@ -8443,7 +8497,7 @@ export class FleetManager {
                         // means we cannot verify the pane, which is treated as dead (the same
                         // conclusion the old code reached only by throwing).
                         try {
-                            const { execFile } = await import("node:child_process");
+                            const { execFile } = await import("./child-process.js");
                             const { promisify } = await import("node:util");
                             const { getTmuxSocketName } = await import("./paths.js");
                             // Honour socket isolation: without -L this queried the user's default
@@ -8993,6 +9047,22 @@ export class FleetManager {
             this.logger.debug({ adapterId: msg.adapterId, threadId: threadId ?? null, messageId: msg.messageId, reason: drop }, "Inbound message dropped before the dedup claim — key not consumed");
             return;
         }
+        // #2246 step 3 (#2341 review r2): a reply to a Needs you Send back / Answer prompt is the card's reason or answer, not
+        // input for an instance — judged by the PROMPT's world (its admins, its instance, its room as it is now; the hub's
+        // handleReply), before the room's generic access below: in a shared group the room may be another bot's, whose
+        // policy has no say over that world's prompt. Only that exact reply, by the admin who clicked, while the prompt
+        // stands. Taken once: another bot's copy of a taken reply is dropped here. All else flows on.
+        if (!msg.isBotMessage && msg.replyTo && this.needsYou) {
+            if (this.needsYou.wasTakenReply(msg.chatId, msg.messageId)) {
+                this.logger.debug({ adapterId: msg.adapterId, messageId: msg.messageId }, "Another bot's copy of a Needs you answer already taken — dropped");
+                return;
+            }
+            if (this.needsYou.handleReply({
+                adapterId: msg.adapterId, chatId: msg.chatId, ...(threadId !== undefined ? { threadId } : {}), replyTo: msg.replyTo,
+                messageId: msg.messageId, userId: msg.userId, ...(msg.username ? { username: msg.username } : {}), text: msg.text ?? "",
+            }))
+                return;
+        }
         // Access control — classic channels are open to all, others require an allowed
         // user. This runs before the dedup claim, and is judged by the adapter that
         // owns the topic rather than the one that happened to receive the message:
@@ -9103,6 +9173,10 @@ export class FleetManager {
                 // #1920 step 4b-3: /web typed in a ClassicBot room (a group: `/web@ThisBot`) by someone who is not a fleet admin,
                 // while guest sign-in is on: their guest code, privately — as anywhere else. An admin's goes on as before.
                 if (/^\/(?:web|dashboard)(?:\s|$)/i.test(text) && msgAdapter && this.isGuestWebAsk(msg.adapterId, msg.userId)) {
+                    // #2359: this door must not skip the deprecation notice TopicCommands shows on /dashboard.
+                    if (/^\/dashboard(?:\s|$)/i.test(text)) {
+                        await msgAdapter.sendText(chatId, t("dashboard.deprecated")).catch(() => { });
+                    }
                     await this.guestWebCommand({ adapterId: msg.adapterId, userId: msg.userId, username: msg.username,
                         arg: text.replace(/^\/(?:web|dashboard)/i, "").trim().toLowerCase(), replyHere: body => msgAdapter.sendText(chatId, body) });
                     return;
@@ -9653,6 +9727,8 @@ export class FleetManager {
         }
     }
     checkToolPermission(sink, instanceName, tool) {
+        if (isCanvasWorkerTool(tool) && !this.canvasWorkerEnabled())
+            return { allowed: false, message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE };
         const profile = resolveToolSet(this.fleetConfig?.instances[instanceName], instanceName);
         const allowed = mayUseTool(profile, tool);
         if (!allowed) {
@@ -10337,13 +10413,14 @@ export class FleetManager {
         if (!ipc || !fleetRequestId)
             return;
         const type = String(msg.type);
-        const responseType = type.startsWith("fleet_schedule_") ? "fleet_schedule_response"
-            : type.startsWith("fleet_decision_") ? "fleet_decision_response"
-                : type === "fleet_task" ? "fleet_task_response"
-                    : type === "fleet_set_display_name" ? "fleet_display_name_response"
-                        : type === "fleet_list_emojis" || type === "fleet_set_persona_emoji" || type === "fleet_preview_emojis"
-                            || type === "fleet_list_stickers" || type === "fleet_preview_stickers" ? "fleet_persona_emoji_response"
-                            : "fleet_description_response";
+        const responseType = isCanvasWorkerTool(type.replace(/^fleet_/, "")) ? "fleet_web_theme_response"
+            : type.startsWith("fleet_schedule_") ? "fleet_schedule_response"
+                : type.startsWith("fleet_decision_") ? "fleet_decision_response"
+                    : type === "fleet_task" ? "fleet_task_response"
+                        : type === "fleet_set_display_name" ? "fleet_display_name_response"
+                            : type === "fleet_list_emojis" || type === "fleet_set_persona_emoji" || type === "fleet_preview_emojis"
+                                || type === "fleet_list_stickers" || type === "fleet_preview_stickers" ? "fleet_persona_emoji_response"
+                                : "fleet_description_response";
         ipc.send({ type: responseType, fleetRequestId, error: message });
     }
     dispatchTypedIpc(name, msg) {
@@ -10836,6 +10913,8 @@ export class FleetManager {
     }
     /** #1629: `agend-agent theme …` — the same service as the tools; `instance` is the token's. */
     async handleWebThemeHttp(instance, tool, args) {
+        if (isCanvasWorkerTool(tool) && !this.canvasWorkerEnabled())
+            return { error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE };
         if (WEB_EFFECT_TOOLS.has(tool)) {
             if (!this.isKnownInstance(instance))
                 return { error: "unknown_instance" };
@@ -12728,7 +12807,7 @@ export class FleetManager {
         const stripAnsi = (s) => s.replace(/\x1b\[[0-9;]*[a-zA-Z]/g, "");
         const backend = this.fleetConfig?.defaults?.backend || "claude-code";
         try {
-            const { execFile } = await import("node:child_process");
+            const { execFile } = await import("./child-process.js");
             const { promisify } = await import("node:util");
             // execFile with an argv array — no shell, so the backend name cannot be
             // interpreted as a command even if config is malformed.
@@ -12954,6 +13033,51 @@ export class FleetManager {
         }
         return { chatId, opts: {} };
     }
+    /**
+     * #2246 step 3: the task board's daily summary of [since, until) (task-board-summary.ts). Each chat world's General
+     * gets its own instances' cards — a card that no world's instance holds (nobody's, a person's) goes to the primary
+     * one — and each of that world's Generals shows the same text in the web chat. A world with nothing to say gets
+     * nothing. A web-only fleet: everything, in the web chat.
+     */
+    postTaskBoardSummary(since, until) {
+        const board = this.scheduler?.db.board;
+        if (!board)
+            return;
+        const read = board.summaryRead(since.toISOString(), until.toISOString());
+        const projects = board.listProjects(true);
+        const stats = board.projectStats();
+        const names = new Map(projects.map((p) => [p.id, p.name]));
+        const configured = this.getPrimaryAdapterId();
+        const primary = configured !== undefined && this.worlds.has(configured) ? configured : this.worlds.keys().next().value;
+        const worldOf = (assignee) => {
+            const owner = assignee ? this.getInstanceAdapterId(assignee) : undefined;
+            return owner !== undefined && this.worlds.has(owner) ? owner : primary;
+        };
+        const zone = this.usageZone();
+        for (const world of this.worlds.size ? [...this.worlds.keys()] : [undefined]) {
+            const summary = buildSummary(read, since, until, { inChat: (assignee) => worldOf(assignee) === world, projects, stats });
+            if (isQuiet(summary))
+                continue;
+            const text = renderSummary(summary, { zone, t: (key, ...args) => t(key, ...args), projectOf: (c) => (c.projectId === null ? null : names.get(c.projectId) ?? null) });
+            const cards = [...new Set([...summary.review, ...summary.blocked, ...summary.done, ...summary.created].map((c) => c.code))];
+            if (world !== undefined) {
+                const adapter = this.worlds.get(world)?.adapter;
+                const target = this.fleetNoticeTarget(world);
+                if (adapter && target) {
+                    adapter.sendText(target.chatId, text, target.opts).catch(e => this.logger.warn({ err: e, world }, "Failed to send the task board's daily summary"));
+                }
+                else {
+                    this.logger.warn({ world }, "The task board's daily summary has no postable target — set a General topic or channel.options.general_channel_id");
+                }
+            }
+            for (const [name, cfg] of Object.entries(this.fleetConfig?.instances ?? {})) {
+                if (cfg.general_topic !== true || (world !== undefined && this.getInstanceAdapterId(name) !== world))
+                    continue;
+                // #2341 review: with the cards it names, so the public link withholds it while one of them is hidden there.
+                this.emitSseEvent("message", { instance: name, sender: name, role: "status", text, ts: new Date().toISOString(), cards });
+            }
+        }
+    }
     /**
      * Post the daily summary where fleet-wide notices go.
      *
@@ -13662,6 +13786,8 @@ export class FleetManager {
                     return String(topic);
                 return this.classicChannels?.getChannelIdByInstance(instance) ?? undefined;
             },
+            laneTarget: instance => this.instanceChannelTarget(instance),
+            taskRoute: code => this.needsYouRoute(code),
             isFleetAdmin: (userId, world) => this.isFleetAdmin(userId, world),
             fleetAdmins: world => (this.getChannelConfig(world)?.access?.allowed_users ?? []).map(String),
             emitSse: (event, data) => this.emitSseEvent(event, data),
@@ -13670,6 +13796,8 @@ export class FleetManager {
                     throw new Error("the delivery outbox is not open");
                 return this.deliveryOutbox.acknowledge(deliveryId, by);
             },
+            tasks: () => this.needsYouTasks(),
+            taskAction: action => this.taskActionFromChat(action),
             settings: () => ({
                 liveMessage: this.fleetConfig?.needs_you?.live_message !== false,
                 dm: this.fleetConfig?.needs_you?.dm === true,
@@ -13680,6 +13808,98 @@ export class FleetManager {
         });
         this.needsYou.start();
     }
+    /**
+     * #2352: where an instance's own notices go — its topic in its world's group, or its ClassicBot room — as a Needs you
+     * lane's place; null when it has neither (or its world has no group).
+     */
+    instanceChannelTarget(instance) {
+        const cfg = this.fleetConfig?.instances && Object.hasOwn(this.fleetConfig.instances, instance) ? this.fleetConfig.instances[instance] : undefined;
+        if (!cfg)
+            return null;
+        const groupId = this.getChannelConfig(this.getInstanceAdapterId(instance))?.group_id;
+        if (cfg.topic_id != null && groupId != null)
+            return { chatId: String(groupId), threadId: String(cfg.topic_id) };
+        const classic = this.classicChannels?.getChannelIdByInstance(instance);
+        return classic ? { chatId: classic } : null;
+    }
+    /**
+     * #2352: the instance whose own channel lists a waiting card — the instance that handed it out, else its project's
+     * lead — when that channel can be used now (a fleet instance of a live world, with a topic or room). undefined: its
+     * assignee's world's General, as before.
+     */
+    needsYouLane(card, leads) {
+        const usable = (name) => {
+            if (!name || !this.fleetConfig?.instances || !Object.hasOwn(this.fleetConfig.instances, name))
+                return false;
+            const world = this.getInstanceAdapterId(name);
+            return world !== undefined && this.worlds.has(world) && this.instanceChannelTarget(name) !== null;
+        };
+        const dispatcher = card.dispatcher?.kind === "instance" && card.dispatcher.name !== card.assignee ? card.dispatcher.name : null;
+        if (dispatcher)
+            return usable(dispatcher) ? dispatcher : undefined;
+        const lead = card.projectId != null ? leads.get(card.projectId) : null;
+        return usable(lead) ? lead : undefined;
+    }
+    /**
+     * #2355 review: where a card's Needs you buttons belong now — read from the board and the fleet at the moment of a click
+     * or a reply, never from the last render. null: it no longer waits for the person.
+     */
+    needsYouRoute(code) {
+        const board = this.scheduler?.db.board;
+        const card = board?.findCard(code);
+        if (!board || !card || !(card.status === "blocked" || (card.status === "review" && card.needsReview)))
+            return null;
+        const leads = new Map(board.listProjects(true).map((p) => [p.id, p.leadInstance]));
+        const lane = this.needsYouLane(card, leads);
+        return lane ? { lane } : {};
+    }
+    /**
+     * #2246 step 3: the task board's cards that wait for the person, for Needs you — under each card's assignee, listed in
+     * its lane's channel (#2352: the instance that handed it out, else the project's lead), else in General.
+     */
+    needsYouTasks() {
+        const board = this.scheduler?.db.board;
+        if (!board)
+            return [];
+        const leads = new Map(board.listProjects(true).map((p) => [p.id, p.leadInstance]));
+        return board.waitingForPerson().map(({ card, since }) => {
+            const gap = card.status === "review" ? wrapUpGap(card) : null;
+            const lane = this.needsYouLane(card, leads);
+            return {
+                uuid: card.uuid, code: card.code, title: card.title, status: card.status, version: card.version,
+                assignee: card.assignee, since: Date.parse(since) || 0, ...(gap ? { gap } : {}), ...(lane ? { lane } : {}),
+                note: card.status === "blocked" ? card.blockedReason : gap ? t("needs.task_gap", [
+                    gap.unchecked ? t("needs.task_gap_unchecked", gap.unchecked) : "", gap.noResult ? t("needs.task_gap_no_result") : "",
+                ].filter(Boolean).join(t("needs.task_gap_join"))) : "",
+            };
+        });
+    }
+    /**
+     * #2246 step 3: the person's move on a card from a chat's Needs you list — a fleet admin of that world (checked by the
+     * hub), acting as the person, through the board's rules, at the version the button showed.
+     */
+    taskActionFromChat(action) {
+        const board = this.scheduler?.db.board;
+        if (!board)
+            return { ok: false, message: t("needs.task_board_closed") };
+        const person = { kind: "person", name: action.by.username || `${action.by.platform}:${action.by.userId}` };
+        try {
+            if (action.verb === "confirm")
+                board.moveCard(person, action.code, "done", { version: action.version });
+            else if (action.verb === "back")
+                board.moveCard(person, action.code, "claimed", { version: action.version, reason: action.text });
+            else
+                board.moveCard(person, action.code, "claimed", { version: action.version, comment: action.text });
+            const done = { confirm: "needs.task_confirmed", back: "needs.task_sent_back", answer: "needs.task_answered" }[action.verb];
+            this.logger.info({ code: action.code, verb: action.verb, by: `${action.by.platform}:${action.by.userId}` }, "Task board: the person moved a card from the chat");
+            return { ok: true, message: t(done, action.code) };
+        }
+        catch (err) {
+            if (err instanceof TaskBoardError && err.code === "conflict")
+                return { ok: false, message: t("needs.task_changed", action.code) };
+            return { ok: false, message: t("needs.task_refused", action.code, err.message) };
+        }
+    }
     /** The prompts open on the dashboard right now (a page that loads after one was posted asks for them). */
     listWebPrompts() {
         const open = [];
@@ -16338,6 +16558,7 @@ export class FleetManager {
                 channel: m.channel,
                 from: m.from,
                 replyTo: m.replyTo,
+                cards: m.cards,
             });
             broadcastSseEvent(this.sseClients, event, recorded, onError, this.webChatHistory.cursorOf(recorded));
             this.searchIndex?.record(chatDoc(recorded));
@@ -16369,11 +16590,25 @@ export class FleetManager {
             isInstance: (name) => this.fleetConfig?.instances?.[name] != null,
             holds: (wake) => db.board.wakeHolds(wake),
             card: (uuid) => db.board.findCard(uuid),
+            // #2352: the card's Needs you buttons are in this instance's own channel (it is the card's lane).
+            buttonsHere: (instance, uuid) => {
+                // #2355 review: no live message, no buttons — the old words then.
+                if (this.fleetConfig?.needs_you?.live_message === false)
+                    return false;
+                const card = db.board.findCard(uuid);
+                if (!card)
+                    return false;
+                const leads = new Map(db.board.listProjects(true).map((p) => [p.id, p.leadInstance]));
+                return this.needsYouLane(card, leads) === instance;
+            },
             log: (level, message, extra) => this.logger[level](extra ?? {}, message),
         });
         db.board.onChange(({ rev, ids, projects, wakes }) => {
             this.emitSseEvent("tasks", { rev, ids, projects });
             waker.note(wakes);
+            // step 3: cards waiting for the person are Needs you items; #2355 review: a project's lead routes them too.
+            if (ids.length || projects)
+                this.needsYou?.poke();
         });
     }
     /** A task board notice, as AgEnD's own (not a person's words): through the delivery outbox, held until delivered. */
@@ -16587,6 +16822,27 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
         this.syncRoleSkills(workDir, backend, "general", knowledgeDir);
         this.logger.debug({ knowledgeDir, workDir, backend }, "Synced general knowledge files");
     }
+    /** Update only AgEnD-managed skill copies; no launch or restart is needed for an experimental switch. */
+    canvasWorkerSettingChanged() {
+        this.refreshExperimentalSkills();
+        this.emitSseEvent("status", this.getUiStatus());
+    }
+    refreshExperimentalSkills() {
+        for (const [name, daemon] of this.daemons) {
+            try {
+                const cfg = daemon.getConfigSnapshot();
+                const backend = cfg.backend ?? this.fleetConfig?.defaults?.backend ?? "claude-code";
+                const workDir = this.resolveKnowledgeWorkDir(cfg.working_directory, backend, name);
+                const classic = this.classicChannels?.getAll().some(ch => ch.instanceName === name) === true;
+                if (classic && !insideManagedWorkspaces(workDir))
+                    continue;
+                this.syncRoleSkills(workDir, backend, classic ? "classic" : cfg.general_topic ? "general" : "worker");
+            }
+            catch (err) {
+                this.logger.warn({ name, err }, "Could not refresh experimental skill visibility");
+            }
+        }
+    }
     /** Publish only the bundled skills eligible for an instance role. */
     syncRoleSkills(workDir, backend, role, knowledgeDir) {
         const skillSegments = FleetManager.SKILLS_DIR_SEGMENTS[backend];
@@ -16751,7 +17007,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
                 continue;
             }
             managed.push(name);
-            const newContent = readFileSync(join(srcSkills, name, "SKILL.md"), "utf-8");
+            const newContent = bundledSkillContents(join(srcSkills, name), this.canvasWorkerEnabled());
             if (refuse(dest))
                 continue;
             try {
@@ -19192,14 +19448,14 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
      */
     stopAll() {
         this.stopAllInFlight ??= this.doStopAll().finally(() => {
-            this.stopAllInFlight = null;
             // #1956: after the stop's own tmux work; anything later goes direct. A later startAll starts it again.
             if (this.tmuxExecHelperTimer) {
                 clearInterval(this.tmuxExecHelperTimer);
                 this.tmuxExecHelperTimer = null;
             }
-            tmuxExecHelper.stop();
-        });
+            // #2364: and the stop waits (bounded) for the helper to leave on its own, before the caller exits the process.
+            return tmuxExecHelper.stop();
+        }).finally(() => { this.stopAllInFlight = null; });
         return this.stopAllInFlight;
     }
     tmuxExecHelperTimer = null;
@@ -19274,6 +19530,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
         this.clearStatuslineWatchers();
         this.costGuard?.stop();
         this.dailySummary?.stop();
+        this.taskBoardSummary?.stop();
         this.dailyTipScheduler?.stop();
         this.dailyTipScheduler = null;
         if (this.updateCheckTimer) {
@@ -19610,6 +19867,9 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             // mark every row done and tell the user "changes applied".
             return { rejected: why };
         }
+        if (canvasWorkerEnabled(oldConfig?.web) !== this.canvasWorkerEnabled()) {
+            this.canvasWorkerSettingChanged();
+        }
         // Classic behavior settings share the fleet defaults but are not entries
         // in fleet.yaml. Snapshot the old effective chain before reloading the
         // Classic file so SIGHUP can hot-apply either source without waiting for
@@ -19859,6 +20119,20 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
         return false;
     }
     /** Non-null when startup found the running config and fleet.yaml disagreeing. */
+    /**
+     * #2346 (settings schema): whether a connection added now would start at once — what canHotAddConnections would decide
+     * for the current config with one more connection appended: another one is running, and nothing else this process took
+     * at startup has changed since (a pending locale or access change, say, needs AgEnD restarted anyway).
+     */
+    connectionsStartLive() {
+        if (!this.fleetConfig)
+            return false;
+        const current = this.fleetConfig.channels ?? (this.fleetConfig.channel ? [this.fleetConfig.channel] : []);
+        const probe = { id: "\u0000probe", type: "telegram", mode: "topic", bot_token_env: "\u0000PROBE" };
+        const next = { ...this.fleetConfig, channels: [...current, probe] };
+        delete next.channel;
+        return this.canHotAddConnections(next);
+    }
     fleetSignatureMismatchKeys() {
         return this.fleetSignatureMismatch;
     }
@@ -20113,9 +20387,10 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
         const tunnel = spec.kind === "tunnel_token";
         if (!tunnel && !spec.verifier)
             return { ok: false, status: "unsupported_verifier", error: "this provider has no supported verifier" };
-        if (input.clear && (!tunnel || input.secret !== "") || tunnel && !(input.clear === true && input.secret === "" || validPublicTunnelToken(input.secret))
-            || !input.clear && (!input.secret || input.secret.length > 4096 || /[\r\n\0]/.test(input.secret) || /[^\x20-\x7e]/.test(input.secret))) {
-            return { ok: false, status: "invalid", error: "secret is invalid" };
+        const secret = tunnel && !input.clear ? normalizePublicTunnelToken(input.secret) : input.secret;
+        if (input.clear && (!tunnel || input.secret !== "")
+            || !input.clear && (!secret || secret.length > 4096 || /[\r\n\0]/.test(secret) || /[^\x20-\x7e]/.test(secret))) {
+            return { ok: false, status: "invalid", error: tunnel ? PUBLIC_TUNNEL_TOKEN_HINT : "secret is invalid" };
         }
         const challengeKey = `${input.sessionBinding}:api_key:${spec.id}:${spec.envKey}:${input.idempotencyKey}`;
         const existingId = this.providerSecretChallengesByKey.get(challengeKey);
@@ -20143,7 +20418,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             operation: "provider-secret.apply",
             idempotencyKey: input.idempotencyKey,
             expiresAt, deadline: performance.now() + SECRET_CHALLENGE_TTL_MS,
-            secret: input.secret,
+            secret: secret,
         };
         this.providerSecretChallenges.set(challenge.id, challenge);
         this.providerSecretChallengesByKey.set(challengeKey, challenge.id);
@@ -21287,7 +21562,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             // up to 15s each, and on a beta build BOTH ran — 30s with no WATCHDOG ping,
             // past WatchdogSec's half-interval and enough for systemd to SIGABRT the fleet
             // for a background version check.
-            const { execFile } = await import("node:child_process");
+            const { execFile } = await import("./child-process.js");
             const { promisify } = await import("node:util");
             const execFileP = promisify(execFile);
             const npmVersion = async (spec) => {
@@ -21579,6 +21854,11 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
                 return;
             }
             const requestPath = new URL(req.url ?? "/", `http://localhost:${port}`).pathname;
+            if (!this.canvasWorkerEnabled() && isCanvasWorkerHttpPath(requestPath)) {
+                res.writeHead(403, { "Content-Type": "application/json", "Cache-Control": "no-store" });
+                res.end(JSON.stringify({ error: "canvas_worker_experimental", message: CANVAS_WORKER_EXPERIMENTAL_MESSAGE }));
+                return;
+            }
             if (this.effectBootstrap.handle(req, res))
                 return;
             // Branding is public, after Host admission: automatic favicon requests
@@ -21647,6 +21927,12 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
                         // #1920 §5.1: guests chat unless the host made them read-only (web.guests.chat: false).
                         chat: () => this.fleetConfig?.web?.guests?.chat !== false });
                 }
+                if (decision.via === "session" && this.webToken) {
+                    const upgrade = sessionCookieUpgrade(req, this.webToken, decision.session);
+                    // No cookie header is set before this gate; auth routes own their headers separately.
+                    if (upgrade)
+                        res.setHeader("Set-Cookie", upgrade);
+                }
             }
             if (req.method === "GET" && req.url === "/health") {
                 const health = this.getFleetHealth();
@@ -22028,6 +22314,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             return;
         }
         const listener = createPreviewListener({ settings, healthPort: boundPort, config: this.fleetConfig,
+            canvasWorkerEnabled: () => this.canvasWorkerEnabled(),
             // #1723: with a web.preview_origin, the open public link's dashboard frames this listener's preview too.
             extraOrigins: () => { const o = settings.origin ? this.publicWebLink?.openDashboardOrigin() : null; return o ? [o] : []; } });
         this.previewListener = listener;
@@ -22205,7 +22492,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
                     return {};
                 } })(),
                 // #2118: only this Chat's placement content; guest projection drops global revisions.
-                effect_chat_v: createHash("sha256").update(JSON.stringify(this.themeStore.get(name).placements.effects)).digest("hex").slice(0, 32),
+                effect_chat_v: this.canvasWorkerEnabled() ? createHash("sha256").update(JSON.stringify(this.themeStore.get(name).placements.effects)).digest("hex").slice(0, 32) : null,
                 // #1958: the identity colour's tiers (the page resolves them: the agent's only while it shows agents' themes).
                 color: { ...(colors.get(name)?.color ? { person: colors.get(name).color } : {}), ...(image.agentColor ? { agent: image.agentColor } : {}),
                     ...(image.roleColor ? { role: image.roleColor } : {}), auto: autoIdentityColor(name) },
@@ -22232,6 +22519,7 @@ Plus the operational skills (fleet-health, instance-lifecycle, scheduling, sessi
             };
         });
         return {
+            canvas_worker: this.canvasWorkerEnabled(),
             instances,
             publicLink: this.getPublicWebStatus(),
             uptime: Math.floor((Date.now() - this.startedAt) / 1000),