@smartledger/bsv 9.10.1 → 9.11.1

package/lib/transaction/sighash.js

@@ -102,8 +102,9 @@ var sighashPreimageForForkId = function (transaction, sighashType, inputNumber,
   writer.writeUInt32LE(input.outputIndex)
 
   // scriptCode of the input (serialized as scripts inside CTxOuts)
-  writer.writeVarintNum(subscript.toBuffer().length)
-  writer.write(subscript.toBuffer())
+  var scriptCode = subscript.toBuffer()
+  writer.writeVarintNum(scriptCode.length)
+  writer.write(scriptCode)
 
   // value of the output spent by this input (8-byte little endian)
   writer.writeUInt64LEBN(satoshisBN)
@@ -148,8 +149,13 @@ var sighashPreimage = function sighashPreimage (transaction, sighashType, inputN
   // Copy transaction
   var txcopy = Transaction.shallowCopy(transaction)
 
-  // Copy script
-  subscript = new Script(subscript)
+  // The BIP-143 path below only reads the script. The original algorithm
+  // modifies it, so it takes its own copy there; copying a large script up
+  // front cost more than the whole digest. Anything that is not a Script yet
+  // is converted, as the copy did.
+  if (!(subscript instanceof Script)) {
+    subscript = new Script(subscript)
+  }
 
   if (flags & Interpreter.SCRIPT_ENABLE_REPLAY_PROTECTION) {
     // Legacy chain's value for fork id must be of the form 0xffxxxx.
@@ -192,7 +198,8 @@ var sighashPreimage = function sighashPreimage (transaction, sighashType, inputN
     return sighashPreimageForForkId(txcopy, sighashType, inputNumber, subscript, satoshisBN)
   }
 
-  // For no ForkId sighash, separators need to be removed.
+  // For no ForkId sighash, separators need to be removed — from a copy.
+  subscript = new Script(subscript)
   subscript.removeCodeseparators()
 
   var i

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@smartledger/bsv",
-  "version": "9.10.1",
+  "version": "9.11.1",
   "description": "Bitcoin SV library with an interpreter-verified script engine: OP_PUSH_TX covenants, BIP-143 preimage tooling, and consensus flags that match what miners actually enforce. Also ships DID:web / W3C VC-JWT credentials and the Legal Token Protocol.",
   "author": "SmartLedger Technology <hello@smartledger.technology> (https://smartledger.technology)",
   "homepage": "https://github.com/codenlighten/smartledger-bsv#readme",

package/version.js

@@ -1,3 +1,3 @@
 'use strict'
 // GENERATED by scripts/sync-version.js on `npm version` — do not edit.
-module.exports = '9.10.1'
+module.exports = '9.11.1'