@smartledger/bsv 9.10.1 → 9.11.1

package/docs/AUDIT_SCOPE.md

@@ -34,12 +34,12 @@ module sounds. That is a deliberate revision: an earlier version of this documen
 scoped Tier 1 as "the cryptographic core" and would have excluded four of the six real
 defects this codebase has produced. See §2.1.
 
-### Tier 1 — 11,989 lines
+### Tier 1 — 12,013 lines
 
 | Module | Lines | Why it matters |
 | --- | ---: | --- |
-| `lib/transaction/` | 2,779 | Sighash construction and signing — both BIP-143 and the Original Transaction Digest Algorithm. |
-| `lib/script/interpreter.js` | 2,834 | **Scoped to the flag and era surface, not opcode execution.** Consensus-flag selection and defaults, era derivation (Genesis/Chronicle), the limits derived from them, and the semantics of the exported `verify()`. Opcode execution is excluded — see §2.2. |
+| `lib/transaction/` | 2,786 | Sighash construction and signing — both BIP-143 and the Original Transaction Digest Algorithm. |
+| `lib/script/interpreter.js` | 2,851 | **Scoped to the flag and era surface, not opcode execution.** Consensus-flag selection and defaults, era derivation (Genesis/Chronicle), the limits derived from them, and the semantics of the exported `verify()`. Opcode execution is excluded — see §2.2. |
 | `lib/crypto/` | 2,519 | ECDSA, nonce derivation, signature encoding, the script-number type. **Scope this for an architectural judgement as well as for bugs** — see §2.3. |
 | `lib/notaryhash/` | 2,028 | BRC-220 signing and verification. Publicly reachable and relied on downstream. |
 | `lib/privatekey.js`, `lib/publickey.js` | 843 | Key construction, serialisation, WIF. Recent defects here produced a *different* key without error. |
@@ -150,14 +150,14 @@ this repository.
 | `lib/address.js`, `lib/networks.js`, `lib/opcode.js`, `lib/hdprivatekey.js`, `lib/hdpublickey.js` (2,391 lines) | Cut to pay for §2.1 | Formatting, network constants and BIP-32 derivation. No defect has originated here, and `networks.js` in particular defines addressing constants — pubkey hashes, xpub prefixes, ports, DNS seeds — and contains **no consensus-flag logic at all**. |
 | The rest of the application layer — `lib/gdaf/`, `lib/ltp/`, `lib/ordinals/`, `lib/block/`, `lib/didweb/`, `lib/vcjwt/`, `lib/statuslist/`, most of `lib/smart_contract/`, plus assorted top-level files | Excluded | ~26,000 lines. Worth a separate engagement; including it here would blur the question in §1. Note the parts of it with a demonstrated defect history have been pulled *into* Tier 1 rather than left here — see §2.1. |
 
-Totals reconcile against `lib/`, which is 39,673 lines across 131 files:
+Totals reconcile against `lib/`, which is 39,779 lines across 131 files:
 
 ```
-tier 1      11,989
+tier 1      12,013
 tier 2       1,607
-excluded    26,077
+excluded    26,159
             ------
-total       39,673
+total       39,779
 ```
 
 Measured 2026-08-29 at `a954c27`. These figures drift as the library changes — an
@@ -228,7 +228,7 @@ seeking a quote for an independent security review.
 
 Scope, and we would like these priced separately:
 
-  Tier 1 — 11,989 lines. Sighash construction and signing; ECDSA, nonce
+  Tier 1 — 12,013 lines. Sighash construction and signing; ECDSA, nonce
   derivation and signature encoding; the consensus-flag and era-derivation
   surface of the script interpreter; BRC-220 signing and verification;
   key construction and serialisation; the covenant verification harness and

package/docs/MODULE_REFERENCE_COMPLETE.md

@@ -55,19 +55,19 @@ Three advanced modules totaling **~2.7MB** of functionality:
 - **Purpose**: Threshold cryptography for secure secret distribution
 - **Use Cases**: Backup keys, multi-party security, key recovery
 - **Features**: Split secrets into N shares, require M to reconstruct
-- **CDN**: `unpkg.com/@smartledger/bsv@9.10.1/bsv-shamir.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@9.11.1/bsv-shamir.min.js`
 
 #### **🌐 Global Digital Attestation Framework - GDAF (1184KB)**  
 - **Purpose**: W3C Verifiable Credentials and decentralized identity
 - **Use Cases**: Identity verification, attestations, zero-knowledge proofs
 - **Features**: DID creation, credential issuance, selective disclosure
-- **CDN**: `unpkg.com/@smartledger/bsv@9.10.1/bsv-gdaf.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@9.11.1/bsv-gdaf.min.js`
 
 #### **⚖️ Legal Token Protocol - LTP (1184KB)**
 - **Purpose**: Legal compliance framework for tokenized assets
 - **Use Cases**: Property rights, obligations, compliant tokenization  
 - **Features**: Legal primitives, compliance checking, attestation anchoring
-- **CDN**: `unpkg.com/@smartledger/bsv@9.10.1/bsv-ltp.min.js`
+- **CDN**: `unpkg.com/@smartledger/bsv@9.11.1/bsv-ltp.min.js`
 
 ### **2. Incorrect File Sizes in Documentation**
 
@@ -81,18 +81,18 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 | Module | Size | Use Case | CDN Link |
 |--------|------|----------|----------|
-| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js` |
-| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@9.10.1/bsv.bundle.js` |
-| **bsv-smartcontract.min.js** | 937KB | Covenant development | `unpkg.com/@smartledger/bsv@9.10.1/bsv-smartcontract.min.js` |
-| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@9.10.1/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@9.10.1/bsv-script-helper.min.js` |
-| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@9.10.1/bsv-security.min.js` |
-| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@9.10.1/bsv-ecies.min.js` |
-| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@9.10.1/bsv-message.min.js` |
-| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@9.10.1/bsv-mnemonic.min.js` |
-| **🆕 bsv-shamir.min.js** | 432KB | **Secret sharing** | `unpkg.com/@smartledger/bsv@9.10.1/bsv-shamir.min.js` |
-| **🆕 bsv-gdaf.min.js** | 1184KB | **Digital attestation** | `unpkg.com/@smartledger/bsv@9.10.1/bsv-gdaf.min.js` |
-| **🆕 bsv-ltp.min.js** | 1184KB | **Legal tokens** | `unpkg.com/@smartledger/bsv@9.10.1/bsv-ltp.min.js` |
+| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js` |
+| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@9.11.1/bsv.bundle.js` |
+| **bsv-smartcontract.min.js** | 937KB | Covenant development | `unpkg.com/@smartledger/bsv@9.11.1/bsv-smartcontract.min.js` |
+| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@9.11.1/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@9.11.1/bsv-script-helper.min.js` |
+| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@9.11.1/bsv-security.min.js` |
+| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@9.11.1/bsv-ecies.min.js` |
+| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@9.11.1/bsv-message.min.js` |
+| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@9.11.1/bsv-mnemonic.min.js` |
+| **🆕 bsv-shamir.min.js** | 432KB | **Secret sharing** | `unpkg.com/@smartledger/bsv@9.11.1/bsv-shamir.min.js` |
+| **🆕 bsv-gdaf.min.js** | 1184KB | **Digital attestation** | `unpkg.com/@smartledger/bsv@9.11.1/bsv-gdaf.min.js` |
+| **🆕 bsv-ltp.min.js** | 1184KB | **Legal tokens** | `unpkg.com/@smartledger/bsv@9.11.1/bsv-ltp.min.js` |
 
 ## 🎯 **Updated Usage Examples**
 
@@ -100,22 +100,22 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **1. Basic Development (~963KB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-script-helper.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-script-helper.min.js"></script>
 ```
 
 #### **2. Smart Contract Development (~2.7MB — each bundle re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-smartcontract.min.js"></script>
 ```
 
 #### **3. 🆕 Legal & Compliance Development (~3.2MB — each bundle re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const legalToken = bsv.createLegalToken({
@@ -132,9 +132,9 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **4. 🆕 Security & Cryptography (~1.4MB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-shamir.min.js"></script>
 <script>
   // Shamir Secret Sharing
   const shares = bsv.splitSecret('my_secret_key', 5, 3); // 5 shares, 3 needed
@@ -146,7 +146,7 @@ Three advanced modules totaling **~2.7MB** of functionality:
 
 #### **5. Everything Bundle (937KB)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.bundle.js"></script>
 <script>
   // Everything available immediately
   const shares = bsv.splitSecret('secret', 5, 3);

package/docs/advanced/UTXO_MANAGER_GUIDE.md

@@ -722,7 +722,7 @@ interface UTXO {
 <html>
 <head>
     <title>UTXO Manager Demo</title>
-    <script src="https://cdn.jsdelivr.net/npm/@smartledger/bsv@9.10.1/bsv.min.js"></script>
+    <script src="https://cdn.jsdelivr.net/npm/@smartledger/bsv@9.11.1/bsv.min.js"></script>
 </head>
 <body>
     <script>

package/docs/audit-rfq/cure53.txt

@@ -15,7 +15,7 @@ seeking a quote for an independent security review of its cryptographic core.
 
 Scope, and we would like these priced separately:
 
-  Tier 1 — 11,989 lines. Sighash construction and signing; ECDSA, nonce
+  Tier 1 — 12,013 lines. Sighash construction and signing; ECDSA, nonce
   derivation and signature encoding; the consensus-flag and era surface of the
   script interpreter; BRC-220 signing; the covenant verification harness; RFC
   8785 canonicalization; and the covenant-facing entrypoints of the smart
@@ -30,7 +30,7 @@ Explicitly out of scope: elliptic-curve and hash primitives, which are supplied
 by the Noble libraries and already audited; opcode EXECUTION in the script
 interpreter, which passes 1,483 of 1,483 of the reference node's own consensus
 vectors with zero false accepts and zero false rejects; and the remaining
-26,077-line application layer (credentials, tokens, ordinals), which we would
+26,159-line application layer (credentials, tokens, ordinals), which we would
 treat as a separate engagement.
 
 Note the shape of that first exclusion, because it is what we want priced. The

package/docs/audit-rfq/ncc-group.txt

@@ -15,7 +15,7 @@ seeking a quote for an independent security review of its cryptographic core.
 
 Scope, and we would like these priced separately:
 
-  Tier 1 — 11,989 lines. Sighash construction and signing; ECDSA, nonce
+  Tier 1 — 12,013 lines. Sighash construction and signing; ECDSA, nonce
   derivation and signature encoding; the consensus-flag and era surface of the
   script interpreter; BRC-220 signing; the covenant verification harness; RFC
   8785 canonicalization; and the covenant-facing entrypoints of the smart
@@ -30,7 +30,7 @@ Explicitly out of scope: elliptic-curve and hash primitives, which are supplied
 by the Noble libraries and already audited; opcode EXECUTION in the script
 interpreter, which passes 1,483 of 1,483 of the reference node's own consensus
 vectors with zero false accepts and zero false rejects; and the remaining
-26,077-line application layer (credentials, tokens, ordinals), which we would
+26,159-line application layer (credentials, tokens, ordinals), which we would
 treat as a separate engagement.
 
 Note the shape of that first exclusion, because it is what we want priced. The

package/docs/audit-rfq/trail-of-bits.txt

@@ -15,7 +15,7 @@ seeking a quote for an independent security review of its cryptographic core.
 
 Scope, and we would like these priced separately:
 
-  Tier 1 — 11,989 lines. Sighash construction and signing; ECDSA, nonce
+  Tier 1 — 12,013 lines. Sighash construction and signing; ECDSA, nonce
   derivation and signature encoding; the consensus-flag and era surface of the
   script interpreter; BRC-220 signing; the covenant verification harness; RFC
   8785 canonicalization; and the covenant-facing entrypoints of the smart
@@ -30,7 +30,7 @@ Explicitly out of scope: elliptic-curve and hash primitives, which are supplied
 by the Noble libraries and already audited; opcode EXECUTION in the script
 interpreter, which passes 1,483 of 1,483 of the reference node's own consensus
 vectors with zero false accepts and zero false rejects; and the remaining
-26,077-line application layer (credentials, tokens, ordinals), which we would
+26,159-line application layer (credentials, tokens, ordinals), which we would
 treat as a separate engagement.
 
 Note the shape of that first exclusion, because it is what we want priced. The

package/docs/getting-started/INSTALLATION.md

@@ -48,7 +48,7 @@ const tx: Transaction = new Transaction();
 #### **Core Library Only (937KB)**
 For basic Bitcoin SV operations:
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
 <script>
   const privateKey = new bsv.PrivateKey();
   const address = privateKey.toAddress();
@@ -58,7 +58,7 @@ For basic Bitcoin SV operations:
 #### **Complete Bundle (937KB)**  
 Everything in one file:
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.bundle.js"></script>
 <script>
   // All features available immediately
   const shares = bsv.splitSecret('secret', 5, 3);
@@ -71,9 +71,9 @@ Everything in one file:
 
 #### **Smart Contract Development (~2.7MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-covenant.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-covenant.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-smartcontract.min.js"></script>
 <script>
   const covenant = bsv.SmartContract.createCovenantBuilder()
     .extractField('amount').push(50000).greaterThanOrEqual().build();
@@ -82,9 +82,9 @@ Everything in one file:
 
 #### **Legal & Identity Development (~3.2MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-gdaf.min.js"></script>
 <script>
   // Legal Token Protocol
   const propertyToken = bsv.createPropertyToken({
@@ -98,9 +98,9 @@ Everything in one file:
 
 #### **Security & Cryptography (~1.4MB total — each bundle is self-contained and re-embeds core BSV)**
 ```html
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-security.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-shamir.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-security.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-shamir.min.js"></script>
 <script>
   // Threshold Cryptography
   const shares = bsv.splitSecret('my_secret_key', 5, 3);
@@ -114,18 +114,18 @@ Everything in one file:
 
 | Module | Size | Purpose | CDN Link |
 |--------|------|---------|----------|
-| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js` |
-| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@9.10.1/bsv.bundle.js` |
-| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@9.10.1/bsv-smartcontract.min.js` |
-| **bsv-ltp.min.js** | 1184KB | **Legal Token Protocol** | `unpkg.com/@smartledger/bsv@9.10.1/bsv-ltp.min.js` |
-| **bsv-gdaf.min.js** | 1184KB | **Digital Identity & Attestation** | `unpkg.com/@smartledger/bsv@9.10.1/bsv-gdaf.min.js` |
-| **bsv-shamir.min.js** | 432KB | **Threshold Cryptography** | `unpkg.com/@smartledger/bsv@9.10.1/bsv-shamir.min.js` |
-| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@9.10.1/bsv-security.min.js` |
-| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@9.10.1/bsv-mnemonic.min.js` |
-| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@9.10.1/bsv-ecies.min.js` |
-| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@9.10.1/bsv-covenant.min.js` |
-| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@9.10.1/bsv-script-helper.min.js` |
-| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@9.10.1/bsv-message.min.js` |
+| **bsv.min.js** | 937KB | Core BSV + SmartContract | `unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js` |
+| **bsv.bundle.js** | 937KB | Everything in one file | `unpkg.com/@smartledger/bsv@9.11.1/bsv.bundle.js` |
+| **bsv-smartcontract.min.js** | 937KB | Complete covenant framework | `unpkg.com/@smartledger/bsv@9.11.1/bsv-smartcontract.min.js` |
+| **bsv-ltp.min.js** | 1184KB | **Legal Token Protocol** | `unpkg.com/@smartledger/bsv@9.11.1/bsv-ltp.min.js` |
+| **bsv-gdaf.min.js** | 1184KB | **Digital Identity & Attestation** | `unpkg.com/@smartledger/bsv@9.11.1/bsv-gdaf.min.js` |
+| **bsv-shamir.min.js** | 432KB | **Threshold Cryptography** | `unpkg.com/@smartledger/bsv@9.11.1/bsv-shamir.min.js` |
+| **bsv-security.min.js** | 26KB | Security enhancements (opt-in helpers — see README › Security) | `unpkg.com/@smartledger/bsv@9.11.1/bsv-security.min.js` |
+| **bsv-mnemonic.min.js** | 681KB | HD wallets | `unpkg.com/@smartledger/bsv@9.11.1/bsv-mnemonic.min.js` |
+| **bsv-ecies.min.js** | 71KB | Encryption | `unpkg.com/@smartledger/bsv@9.11.1/bsv-ecies.min.js` |
+| **bsv-covenant.min.js** | 913KB | Covenant operations | `unpkg.com/@smartledger/bsv@9.11.1/bsv-covenant.min.js` |
+| **bsv-script-helper.min.js** | 26KB | Custom script tools | `unpkg.com/@smartledger/bsv@9.11.1/bsv-script-helper.min.js` |
+| **bsv-message.min.js** | 26KB | Message signing | `unpkg.com/@smartledger/bsv@9.11.1/bsv-message.min.js` |
 
 ## ⚙️ **Development Environment Setup**
 

package/docs/getting-started/QUICK_START.md

@@ -14,10 +14,10 @@ npm install @smartledger/bsv
 ### Browser CDN (Instant)
 ```html
 <!-- Core library (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
 
 <!-- Everything included (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.bundle.js"></script>
 ```
 
 ## 💰 **Your First Transaction (60 seconds)**
@@ -127,19 +127,19 @@ SmartLedger-BSV offers 12 different loading options - use only what you need:
 
 ```html
 <!-- Core BSV only (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
 
 <!-- Smart contracts (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-smartcontract.min.js"></script>
 
 <!-- Legal tokens (1.16MB) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-ltp.min.js"></script>
 
 <!-- Digital identity (1.16MB) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-gdaf.min.js"></script>
 
 <!-- Everything (937KB) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.bundle.js"></script>
 ```
 
 ## ⚡ **Key Advantages**

package/docs/migration/FROM_BSV_1_5_6.md

@@ -159,17 +159,17 @@ const recovered = bsv.reconstructSecret([shares[0], shares[2], shares[4]]);
 ### **New Modular Options** 
 ```html
 <!-- Core compatibility (same size as bsv@1.5.6) -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.min.js"></script>
 
 <!-- Add smart contracts when ready -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-smartcontract.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-smartcontract.min.js"></script>
 
 <!-- Add advanced features as needed -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-ltp.min.js"></script>
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv-gdaf.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-ltp.min.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv-gdaf.min.js"></script>
 
 <!-- Everything in one file -->
-<script src="https://unpkg.com/@smartledger/bsv@9.10.1/bsv.bundle.js"></script>
+<script src="https://unpkg.com/@smartledger/bsv@9.11.1/bsv.bundle.js"></script>
 ```
 
 ## 🔍 **Testing Your Migration**

package/lib/script/interpreter.js

@@ -896,6 +896,20 @@ Interpreter.prototype.checkSignatureEncoding = function (buf) {
   return true
 }
 
+/**
+ * The node's CleanupScriptCode: remove the signature from the scriptCode it
+ * signs, unless it is a FORKID signature and FORKID is enabled. An empty
+ * signature has hash type 0, so without FORKID it removes every OP_0, as the
+ * node's does.
+ */
+function cleanupScriptCode (subscript, bufSig, flags) {
+  var hashType = bufSig.length ? bufSig[bufSig.length - 1] : 0
+  if (!(flags & Interpreter.SCRIPT_ENABLE_SIGHASH_FORKID) || !(hashType & Signature.SIGHASH_FORKID)) {
+    subscript.findAndDelete(new Script().add(bufSig))
+  }
+  return subscript
+}
+
 /**
  * Translated from bitcoind's CheckPubKeyEncoding
  */
@@ -2425,9 +2439,12 @@ Interpreter.prototype.step = function () {
           chunks: this.script.chunks.slice(this.pbegincodehash)
         })
 
-        // Drop the signature, since there's no way for a signature to sign itself
-        var tmpScript = new Script().add(bufSig)
-        subscript.findAndDelete(tmpScript)
+        // Drop the signature, since there's no way for a signature to sign
+        // itself — but only where the node does: not for a FORKID signature
+        // when FORKID is enabled (CleanupScriptCode). Removing it there let a
+        // signature over the script minus a pushed copy of itself verify here
+        // and fail on the network.
+        cleanupScriptCode(subscript, bufSig, this.flags)
 
         try {
           sig = Signature.fromTxFormat(bufSig)
@@ -2525,7 +2542,7 @@ Interpreter.prototype.step = function () {
         // Drop the signatures, since there's no way for a signature to sign itself
         for (var k = 0; k < nSigsCount; k++) {
           bufSig = stacktop(-isig - k)
-          subscript.findAndDelete(new Script().add(bufSig))
+          cleanupScriptCode(subscript, bufSig, this.flags)
         }
 
         fSuccess = true

package/lib/script/script.js

@@ -1,8 +1,9 @@
 'use strict'
 
+var assert = require('assert')
+
 var Address = require('../address')
 var BufferReader = require('../encoding/bufferreader')
-var BufferWriter = require('../encoding/bufferwriter')
 var Hash = require('../crypto/hash')
 var Opcode = require('../opcode')
 var PublicKey = require('../publickey')
@@ -107,45 +108,100 @@ Script.fromBuffer = function (buffer) {
 }
 
 Script.prototype.toBuffer = function () {
-  var bw = new BufferWriter()
+  // Sized first and written into one allocation. A locking script can have
+  // hundreds of thousands of chunks, and this runs for every signature check
+  // over it; a writer that allocates per chunk made that the dominant cost.
+  // Writes go through Buffer's checked writers, so a malformed chunk throws
+  // exactly where the per-chunk writer threw.
+  var chunks = this.chunks
+  var size = 0
+  var i, chunk, opcodenum
+  for (i = 0; i < chunks.length; i++) {
+    chunk = chunks[i]
+    opcodenum = chunk.opcodenum
+    size += 1
+    if (chunk.buf) {
+      if (opcodenum < Opcode.OP_PUSHDATA1) {
+        size += bufLength(chunk.buf)
+      } else if (opcodenum === Opcode.OP_PUSHDATA1) {
+        size += 1 + bufLength(chunk.buf)
+      } else if (opcodenum === Opcode.OP_PUSHDATA2) {
+        size += 2 + bufLength(chunk.buf)
+      } else if (opcodenum === Opcode.OP_PUSHDATA4) {
+        size += 4 + bufLength(chunk.buf)
+      }
+    }
+  }
 
-  for (var i = 0; i < this.chunks.length; i++) {
-    var chunk = this.chunks[i]
-    var opcodenum = chunk.opcodenum
-    bw.writeUInt8(chunk.opcodenum)
+  var out = Buffer.alloc(size)
+  var o = 0
+  for (i = 0; i < chunks.length; i++) {
+    chunk = chunks[i]
+    opcodenum = chunk.opcodenum
+    o = out.writeUInt8(chunk.opcodenum, o)
     if (chunk.buf) {
       if (opcodenum < Opcode.OP_PUSHDATA1) {
-        bw.write(chunk.buf)
+        o += chunk.buf.copy(out, o)
       } else if (opcodenum === Opcode.OP_PUSHDATA1) {
-        bw.writeUInt8(chunk.len)
-        bw.write(chunk.buf)
+        o = out.writeUInt8(chunk.len, o)
+        o += chunk.buf.copy(out, o)
       } else if (opcodenum === Opcode.OP_PUSHDATA2) {
-        bw.writeUInt16LE(chunk.len)
-        bw.write(chunk.buf)
+        o = out.writeUInt16LE(chunk.len, o)
+        o += chunk.buf.copy(out, o)
       } else if (opcodenum === Opcode.OP_PUSHDATA4) {
-        bw.writeUInt32LE(chunk.len)
-        bw.write(chunk.buf)
+        o = out.writeUInt32LE(chunk.len, o)
+        o += chunk.buf.copy(out, o)
       }
     }
   }
+  return out
+}
+
+// A chunk's data must be a Buffer; BufferWriter#write asserted as much.
+function bufLength (buf) {
+  if (!Buffer.isBuffer(buf)) throw new assert.AssertionError({ message: 'chunk data must be a Buffer', actual: buf, expected: 'Buffer', operator: 'isBuffer' })
+  return buf.length
+}
 
-  return bw.concat()
+/**
+ * An opcode written as a single raw byte, `0xba`: how toASM and toString write an
+ * opcode that has no name, and how bitcoind's script test format writes raw bytes.
+ * Only a non-push byte qualifies. A push byte on its own is an incomplete push.
+ *
+ * @returns {number|undefined} the opcode, or undefined if the token is not one
+ */
+function rawOpcodeToken (token) {
+  if (!/^0x[0-9a-fA-F]{2}$/.test(token)) return undefined
+  var num = parseInt(token.slice(2), 16)
+  return num > Opcode.OP_PUSHDATA4 ? num : undefined
 }
 
 Script.fromASM = function (str) {
   var script = new Script()
   script.chunks = []
 
+  // toASM writes an empty script as ''. Splitting it would yield one empty token,
+  // which the data branch below reads as an empty push: OP_0, a different script.
+  if (str === '') {
+    return script
+  }
+
   var tokens = str.split(' ')
   var i = 0
   while (i < tokens.length) {
     var token = tokens[i]
     var opcode = Opcode(token)
     var opcodenum = opcode.toNumber()
+    var raw = rawOpcodeToken(token)
 
     // we start with two special cases, 0 and -1, which are handled specially in
     // toASM. see _chunkToString.
-    if (token === '0') {
+    if (raw !== undefined) {
+      script.chunks.push({
+        opcodenum: raw
+      })
+      i = i + 1
+    } else if (token === '0') {
       opcodenum = 0
       script.chunks.push({
         opcodenum: opcodenum
@@ -205,8 +261,15 @@ Script.fromString = function (str) {
     var token = tokens[i]
     var opcode = Opcode(token)
     var opcodenum = opcode.toNumber()
+    var raw = rawOpcodeToken(token)
 
-    if (_.isUndefined(opcodenum)) {
+    if (raw !== undefined) {
+      // An opcode with no name, as toString writes it.
+      script.chunks.push({
+        opcodenum: raw
+      })
+      i = i + 1
+    } else if (_.isUndefined(opcodenum)) {
       opcodenum = parseInt(token)
       if (opcodenum > 0 && opcodenum < Opcode.OP_PUSHDATA1) {
         script.chunks.push({
@@ -267,11 +330,10 @@ Script.prototype._chunkToString = function (chunk, type) {
       if (numstr.length % 2 !== 0) {
         numstr = '0' + numstr
       }
-      if (asm) {
-        str = str + ' ' + numstr
-      } else {
-        str = str + ' ' + '0x' + numstr
-      }
+      // An opcode with no name is written as its raw byte, 0xba, in both forms. ASM
+      // used to write it as bare hex, `ba`, which is also how ASM writes a one-byte
+      // data push, so fromASM read it back as a push: a different script.
+      str = str + ' ' + '0x' + numstr
     }
   } else {
     // data chunk
@@ -1081,20 +1143,40 @@ Script.prototype.toAddress = function (network) {
  */
 Script.prototype.findAndDelete = function (script) {
   var buf = script.toBuffer()
-  var hex = buf.toString('hex')
+  // A chunk serializes to bytes starting with its opcode, so only chunks whose
+  // opcode is the first byte of `buf` can match. Every other chunk is still
+  // serialized when its encoding would throw, so malformed input fails as it
+  // always did.
+  var first = buf.length ? buf[0] : -1
   for (var i = 0; i < this.chunks.length; i++) {
-    var script2 = Script({
-      chunks: [this.chunks[i]]
-    })
-    var buf2 = script2.toBuffer()
-    var hex2 = buf2.toString('hex')
-    if (hex === hex2) {
+    var chunk = this.chunks[i]
+    if (chunk.opcodenum !== first && serializesCleanly(chunk)) continue
+    var buf2 = Script({
+      chunks: [chunk]
+    }).toBuffer()
+    if (buf.equals(buf2)) {
+      // Look at the chunk that slid into this position too: CScript::FindAndDelete
+      // removes consecutive occurrences.
       this.chunks.splice(i, 1)
+      i--
     }
   }
   return this
 }
 
+function serializesCleanly (chunk) {
+  var op = chunk.opcodenum
+  if (typeof op !== 'number' || !Number.isInteger(op) || op < 0 || op > 255) return false
+  if (!chunk.buf) return true
+  if (op > Opcode.OP_PUSHDATA4) return true
+  if (!Buffer.isBuffer(chunk.buf)) return false
+  var len = chunk.len
+  if (op === Opcode.OP_PUSHDATA1) return Number.isInteger(len) && len >= 0 && len <= 0xff
+  if (op === Opcode.OP_PUSHDATA2) return Number.isInteger(len) && len >= 0 && len <= 0xffff
+  if (op === Opcode.OP_PUSHDATA4) return Number.isInteger(len) && len >= 0 && len <= 0xffffffff
+  return true
+}
+
 /**
  * Comes from bitcoind's script interpreter CheckMinimalPush function
  * @returns {boolean} if the chunk {i} is the smallest way to push that particular data.