@sleep2agi/commhub-server 0.9.0-preview.27 → 0.9.0-preview.270

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (444) hide show
  1. package/README.md +120 -3
  2. package/bin/commhub.ts +93 -9
  3. package/build-info.json +7 -0
  4. package/package.json +10 -8
  5. package/src/ack-create-request-transport.test.ts +182 -0
  6. package/src/ack-create-request.test.ts +52 -8
  7. package/src/admin-delete-network-http.test.ts +229 -0
  8. package/src/admin-networks-http.test.ts +88 -0
  9. package/src/adoption-candidates-http.test.ts +140 -0
  10. package/src/adoption-candidates.ts +158 -0
  11. package/src/agent-access-batch.test.ts +210 -0
  12. package/src/agent-access.ts +585 -0
  13. package/src/agent-acl-groups-http.test.ts +247 -0
  14. package/src/agent-acl-http.test.ts +691 -0
  15. package/src/agent-acl-slice3-http.test.ts +885 -0
  16. package/src/agent-department-grants.test.ts +129 -0
  17. package/src/agent-department-http.test.ts +215 -0
  18. package/src/agent-groups-perf.test.ts +223 -0
  19. package/src/agent-notice.ts +48 -0
  20. package/src/agent-team-whoami-http.test.ts +98 -0
  21. package/src/agent-teams-http.test.ts +330 -0
  22. package/src/agent-teams.ts +244 -0
  23. package/src/alias-baseline-2571.test.ts +162 -0
  24. package/src/alias-baseline.ts +113 -0
  25. package/src/alias-filter.test.ts +72 -0
  26. package/src/alias-filter.ts +42 -0
  27. package/src/api-host-supervisors-can-create-nodes.test.ts +350 -0
  28. package/src/api-host-supervisors-fallback.test.ts +6 -7
  29. package/src/api-host-supervisors-runtime-readiness.test.ts +195 -0
  30. package/src/api-nodes-shape.test.ts +131 -4
  31. package/src/auth-abuse-counters.test.ts +144 -0
  32. package/src/auth-abuse-counters.ts +122 -0
  33. package/src/auth-layer-shape.test.ts +105 -0
  34. package/src/auth-password-change-cli-tokens-http.test.ts +423 -0
  35. package/src/auth-sessions-http.test.ts +260 -0
  36. package/src/auth-validate.test.ts +5 -1
  37. package/src/auth-weak-password-login.test.ts +176 -0
  38. package/src/auth.ts +641 -68
  39. package/src/backfill-node-ids-2664.test.ts +128 -0
  40. package/src/binding-generation-http.test.ts +141 -0
  41. package/src/blocked-exit-on-reply.test.ts +122 -0
  42. package/src/broadcast-fanout-2721.test.ts +149 -0
  43. package/src/broadcast-fanout.ts +117 -0
  44. package/src/build-commit-report-http.test.ts +128 -0
  45. package/src/build-info.test.ts +60 -0
  46. package/src/build-info.ts +85 -0
  47. package/src/chain-attempt-dedup.test.ts +447 -0
  48. package/src/clip.test.ts +36 -0
  49. package/src/clip.ts +48 -0
  50. package/src/clone-node.test.ts +269 -0
  51. package/src/clone-node.ts +289 -0
  52. package/src/codex-config-flags.ts +77 -0
  53. package/src/codex-fork-contract.ts +23 -0
  54. package/src/codex-fork-migration.test.ts +38 -0
  55. package/src/commhub-bin-args.test.ts +85 -0
  56. package/src/config-apply-validate.test.ts +188 -1
  57. package/src/config-apply-validate.ts +222 -3
  58. package/src/cors-origins.test.ts +73 -0
  59. package/src/create-node-blocked-gate.test.ts +365 -0
  60. package/src/create-node-error-domain.test.ts +127 -0
  61. package/src/create-node-network-id.test.ts +91 -0
  62. package/src/create-node-tool-schema.test.ts +49 -0
  63. package/src/create-node-unicode-name.test.ts +126 -0
  64. package/src/create-node-validate.test.ts +199 -7
  65. package/src/create-node-validate.ts +232 -15
  66. package/src/create-node-workdir.test.ts +298 -0
  67. package/src/create-node.ts +88 -23
  68. package/src/daemon-provider-snapshots.test.ts +453 -0
  69. package/src/daemon-provider-snapshots.ts +327 -0
  70. package/src/daemon-token-owner-http.test.ts +346 -0
  71. package/src/dashboard-slash-routing-http.test.ts +109 -0
  72. package/src/db-adapter-guard.test.ts +148 -0
  73. package/src/db-adapter-translate.test.ts +128 -0
  74. package/src/db-adapter.ts +377 -91
  75. package/src/db-timestamp.test.ts +38 -0
  76. package/src/db-timestamp.ts +15 -0
  77. package/src/db.ts +1298 -153
  78. package/src/delivered-without-push.test.ts +140 -0
  79. package/src/department-groups-http.test.ts +209 -0
  80. package/src/department-groups-sync-http.test.ts +328 -0
  81. package/src/department-groups.ts +434 -0
  82. package/src/department-heads-http.test.ts +350 -0
  83. package/src/department-heads.ts +226 -0
  84. package/src/departments-agent-count.test.ts +139 -0
  85. package/src/departments-http.test.ts +185 -0
  86. package/src/departments-mcp-error-domain.test.ts +135 -0
  87. package/src/departments-mcp.test.ts +128 -0
  88. package/src/departments.ts +318 -0
  89. package/src/desktop-message-seam.test.ts +150 -0
  90. package/src/desktop-message.test.ts +368 -0
  91. package/src/dm-file-scope-http.test.ts +227 -0
  92. package/src/empty-node-sweeper.test.ts +104 -0
  93. package/src/empty-node-sweeper.ts +88 -0
  94. package/src/env-transport-gate-http.test.ts +240 -0
  95. package/src/env-transport-gate.ts +80 -0
  96. package/src/env-transport-policy.ts +56 -0
  97. package/src/etag-of.test.ts +57 -0
  98. package/src/event-loop-lag.test.ts +180 -0
  99. package/src/event-loop-lag.ts +201 -0
  100. package/src/expiry-counters.test.ts +187 -0
  101. package/src/expiry-counters.ts +227 -0
  102. package/src/expiry-evidence-db.test.ts +103 -0
  103. package/src/ext-token-shared.test.ts +60 -0
  104. package/src/ext-validation-regression.test.ts +10 -17
  105. package/src/external-schedule-edits-http.test.ts +321 -0
  106. package/src/external-schedule-edits-timestamps.test.ts +64 -0
  107. package/src/external-schedule-edits.ts +327 -0
  108. package/src/file-download-authz-dev-open.test.ts +1 -1
  109. package/src/file-download-authz.test.ts +25 -4
  110. package/src/file-download-date-bucket.test.ts +1 -1
  111. package/src/file-network-scope-dev-open.test.ts +1 -1
  112. package/src/file-network-scope.test.ts +7 -6
  113. package/src/group-membership-events-http.test.ts +264 -0
  114. package/src/group-messages-http.test.ts +483 -0
  115. package/src/group-messages.ts +297 -0
  116. package/src/health-anon-readers.ts +67 -0
  117. package/src/health-host-disk-2756.test.ts +71 -0
  118. package/src/health-identity-root.test.ts +98 -0
  119. package/src/health-redaction.test.ts +1599 -7
  120. package/src/health-status-reasons.test.ts +84 -0
  121. package/src/host-supervisor-identity-http.test.ts +152 -0
  122. package/src/host-supervisor-identity.ts +92 -0
  123. package/src/host-supervisors-daemon-version.test.ts +137 -0
  124. package/src/http-gzip.test.ts +94 -0
  125. package/src/http-gzip.ts +112 -0
  126. package/src/hub-catalog-read-http.test.ts +664 -0
  127. package/src/hub-provider-config.test.ts +166 -0
  128. package/src/hub-provider-config.ts +202 -0
  129. package/src/hub-timestamp.test.ts +38 -0
  130. package/src/hub-timestamp.ts +27 -0
  131. package/src/human-dm.ts +215 -0
  132. package/src/human-inbox.ts +42 -0
  133. package/src/inbox-caller.ts +49 -0
  134. package/src/inbox-count-sse.test.ts +318 -0
  135. package/src/inbox-count.ts +29 -0
  136. package/src/index.ts +6 -2
  137. package/src/license-state.test.ts +105 -0
  138. package/src/license-state.ts +48 -0
  139. package/src/lifecycle-error-domain.test.ts +149 -0
  140. package/src/list-ack-error-domain.test.ts +108 -0
  141. package/src/list-host-supervisors.test.ts +15 -4
  142. package/src/list-tasks-omit-default.test.ts +84 -0
  143. package/src/list-tasks-since-last.test.ts +100 -0
  144. package/src/list-tasks-since.test.ts +104 -0
  145. package/src/mcp-context-cost-http.test.ts +127 -0
  146. package/src/mcp-inflight.test.ts +92 -0
  147. package/src/mcp-inflight.ts +38 -0
  148. package/src/mcp-projects-events-http.test.ts +168 -0
  149. package/src/mcp-route-label-http.test.ts +120 -0
  150. package/src/mcp-write-network-resolution.test.ts +21 -0
  151. package/src/member-audit-network-id-http.test.ts +93 -0
  152. package/src/member-presence-http.test.ts +210 -0
  153. package/src/messages-ack-by-agent-http.test.ts +142 -0
  154. package/src/migrate-sqlite-to-pg.test.ts +47 -0
  155. package/src/migrate-sqlite-to-pg.ts +263 -0
  156. package/src/model-auth-notify-http.test.ts +181 -0
  157. package/src/model-auth-notify.ts +116 -0
  158. package/src/network-name-http.test.ts +75 -0
  159. package/src/network-quota-config.test.ts +100 -0
  160. package/src/network-rules-http.test.ts +169 -0
  161. package/src/network-rules.ts +129 -0
  162. package/src/network-scope.ts +222 -3
  163. package/src/network-token-membership-http.test.ts +186 -0
  164. package/src/node-alias-control.ts +12 -0
  165. package/src/node-attrs.test.ts +47 -2
  166. package/src/node-caller-identity-http.test.ts +1108 -0
  167. package/src/node-config-last-update.test.ts +126 -0
  168. package/src/node-config-last-update.ts +107 -0
  169. package/src/node-create-request-status-http.test.ts +105 -0
  170. package/src/node-daemon-bindings.test.ts +142 -0
  171. package/src/node-daemon-bindings.ts +135 -0
  172. package/src/node-failure-alert.test.ts +150 -0
  173. package/src/node-failure-alert.ts +177 -0
  174. package/src/node-files-transport.test.ts +350 -0
  175. package/src/node-health-codex-login.test.ts +120 -0
  176. package/src/node-health-dispatch-http.test.ts +373 -0
  177. package/src/node-health-guard-origin.test.ts +98 -0
  178. package/src/node-health-guard.ts +121 -0
  179. package/src/node-health-passthrough.test.ts +115 -0
  180. package/src/node-health-store.ts +101 -0
  181. package/src/node-id-alias.test.ts +190 -0
  182. package/src/node-identity-conflict-http.test.ts +269 -0
  183. package/src/node-identity-conflict.ts +142 -0
  184. package/src/node-identity-mismatch.test.ts +74 -0
  185. package/src/node-in-flight-tasks.ts +31 -0
  186. package/src/node-lifecycle-controllable.test.ts +64 -0
  187. package/src/node-lifecycle-controllable.ts +53 -0
  188. package/src/node-lifecycle-read-http.test.ts +257 -0
  189. package/src/node-lifecycle-read.ts +124 -0
  190. package/src/node-logs-transport.test.ts +266 -0
  191. package/src/node-peer-allowlist.test.ts +114 -0
  192. package/src/node-permissions-http.test.ts +901 -0
  193. package/src/node-permissions.ts +494 -0
  194. package/src/node-request-retention.test.ts +281 -0
  195. package/src/node-request-retention.ts +120 -0
  196. package/src/node-secret-rest-http.test.ts +190 -0
  197. package/src/node-secret-vault-inject.test.ts +132 -0
  198. package/src/node-security-write-gate.test.ts +72 -0
  199. package/src/node-serviceability.test.ts +86 -0
  200. package/src/node-serviceability.ts +124 -0
  201. package/src/node-session-control-http.test.ts +310 -0
  202. package/src/node-session-control.ts +258 -0
  203. package/src/node-skills-transport.test.ts +212 -0
  204. package/src/node-token-identity.ts +35 -0
  205. package/src/node-token-ownership.ts +51 -0
  206. package/src/node-token-privilege-http.test.ts +224 -0
  207. package/src/not-found-api-http.test.ts +67 -0
  208. package/src/observer-avatar-http.test.ts +103 -10
  209. package/src/observer-push.test.ts +76 -0
  210. package/src/opencode-catalog-report-http.test.ts +139 -0
  211. package/src/opencode-v2-catalog.test.ts +268 -0
  212. package/src/opencode-v2-catalog.ts +356 -0
  213. package/src/package-version-consistency.test.ts +25 -0
  214. package/src/parent-infer.test.ts +82 -0
  215. package/src/parent-infer.ts +110 -0
  216. package/src/parent-source-marker.test.ts +70 -0
  217. package/src/parent-source-orphan.test.ts +121 -0
  218. package/src/password-network-tokens.ts +25 -0
  219. package/src/peer-reply-atomic.test.ts +462 -0
  220. package/src/peer-reply-capability.test.ts +70 -0
  221. package/src/pg-worker.ts +87 -0
  222. package/src/poll-pacing.test.ts +74 -0
  223. package/src/poll-pacing.ts +123 -0
  224. package/src/probe-provider-error-domain.test.ts +145 -0
  225. package/src/project-dir-warn-clear-http.test.ts +132 -0
  226. package/src/project-viewer-can-http.test.ts +116 -0
  227. package/src/provider-skill-error-domain.test.ts +130 -0
  228. package/src/provider-tools-shape.test.ts +165 -0
  229. package/src/push.test.ts +20 -10
  230. package/src/push.ts +373 -9
  231. package/src/redact-tokens.test.ts +86 -0
  232. package/src/redact-tokens.ts +43 -0
  233. package/src/rejection-counters.test.ts +72 -0
  234. package/src/rejection-counters.ts +173 -0
  235. package/src/rename.ts +38 -10
  236. package/src/reply-target-derivation.test.ts +96 -0
  237. package/src/report-status-handover-capabilities-http.test.ts +124 -0
  238. package/src/report-status-host-schema.test.ts +235 -0
  239. package/src/report-status-resume-id-handover.test.ts +184 -0
  240. package/src/report-status-secret-keys.test.ts +140 -0
  241. package/src/require-explicit-test-db.ts +9 -0
  242. package/src/requirement-due-reminders-http.test.ts +620 -0
  243. package/src/requirement-due-reminders.ts +416 -0
  244. package/src/requirement-events-http.test.ts +318 -0
  245. package/src/requirement-events.test.ts +45 -0
  246. package/src/requirement-events.ts +144 -0
  247. package/src/requirement-notify.ts +165 -0
  248. package/src/requirement-participant-notify-http.test.ts +313 -0
  249. package/src/requirement-tag-ops-http.test.ts +454 -0
  250. package/src/requirement-tag-tree-http.test.ts +275 -0
  251. package/src/requirement-tag-tree.ts +127 -0
  252. package/src/requirement-tags.ts +102 -0
  253. package/src/requirements-abandoned-http.test.ts +236 -0
  254. package/src/requirements-assignee-drift.test.ts +154 -0
  255. package/src/requirements-comment-http.test.ts +174 -0
  256. package/src/requirements-completed-at-migration.test.ts +70 -0
  257. package/src/requirements-errors-mcp-http.test.ts +164 -0
  258. package/src/requirements-errors.ts +158 -0
  259. package/src/requirements-etag-http.test.ts +91 -0
  260. package/src/requirements-http.test.ts +709 -0
  261. package/src/requirements-last-event-http.test.ts +349 -0
  262. package/src/requirements-list-mcp-slim-http.test.ts +155 -0
  263. package/src/requirements-list-slim-http.test.ts +324 -0
  264. package/src/requirements-mcp.test.ts +180 -0
  265. package/src/requirements-migrate.ts +283 -0
  266. package/src/requirements-owner-strict-mcp-http.test.ts +145 -0
  267. package/src/requirements-people-http.test.ts +114 -0
  268. package/src/requirements-people-mcp-http.test.ts +231 -0
  269. package/src/requirements-people.ts +196 -0
  270. package/src/requirements-priority-lowest.test.ts +114 -0
  271. package/src/requirements-projects-network-echo.test.ts +57 -0
  272. package/src/requirements-projects-parent-http.test.ts +123 -0
  273. package/src/requirements-search-http.test.ts +182 -0
  274. package/src/requirements-search.test.ts +32 -0
  275. package/src/requirements-search.ts +145 -0
  276. package/src/requirements-seq-http.test.ts +193 -0
  277. package/src/requirements-seq-migration.test.ts +63 -0
  278. package/src/requirements-start-date.test.ts +125 -0
  279. package/src/requirements-stats-http.test.ts +357 -0
  280. package/src/requirements-stats.ts +195 -0
  281. package/src/requirements-status-participants-http.test.ts +222 -0
  282. package/src/requirements-upgrade-e2e.test.ts +126 -0
  283. package/src/requirements-upgrade-migration.test.ts +98 -0
  284. package/src/requirements.ts +2205 -0
  285. package/src/resolve-port.test.ts +57 -0
  286. package/src/resolve-port.ts +44 -0
  287. package/src/rest-alias-network-fallback-http.test.ts +123 -0
  288. package/src/rest-alias-network-fallback.test.ts +60 -0
  289. package/src/rest-alias-network-fallback.ts +65 -0
  290. package/src/rest-explicit-columns-http.test.ts +266 -0
  291. package/src/rest-identity.test.ts +130 -0
  292. package/src/rest-identity.ts +141 -0
  293. package/src/rest-projections.ts +72 -0
  294. package/src/rest-read-network-real-chain.test.ts +97 -0
  295. package/src/rest-write-network-resolution.test.ts +133 -0
  296. package/src/restart-readiness-http.test.ts +121 -0
  297. package/src/restricted-files.ts +76 -0
  298. package/src/retention-first-sweep-quiet.test.ts +31 -0
  299. package/src/retention.test.ts +100 -40
  300. package/src/retention.ts +423 -104
  301. package/src/route-callers-http.test.ts +120 -0
  302. package/src/route-timing.test.ts +218 -0
  303. package/src/route-timing.ts +262 -0
  304. package/src/rules-file-duplicate-alias.test.ts +234 -0
  305. package/src/rules-file-session-target.test.ts +207 -0
  306. package/src/rules-file-transport.test.ts +271 -0
  307. package/src/runtime-label.test.ts +22 -0
  308. package/src/runtime-label.ts +21 -0
  309. package/src/runtime-readiness.ts +90 -0
  310. package/src/schedule-agent-mcp-http.test.ts +486 -0
  311. package/src/schedule-agent.ts +252 -0
  312. package/src/schedule-starved.test.ts +92 -0
  313. package/src/schedule-starved.ts +114 -0
  314. package/src/scheduled-backoff-http.test.ts +203 -0
  315. package/src/scheduled-backoff.ts +64 -0
  316. package/src/scheduled-doorbell-nodeless-session.test.ts +134 -0
  317. package/src/scheduled-failure-backoff-2622.test.ts +145 -0
  318. package/src/scheduled-failure-code.test.ts +73 -0
  319. package/src/scheduled-failure-code.ts +105 -0
  320. package/src/scheduled-failures-http.test.ts +279 -0
  321. package/src/scheduled-failures.ts +425 -0
  322. package/src/scheduled-noprogress-backoff-2622.test.ts +163 -0
  323. package/src/scheduled-offline-backoff-probe.test.ts +56 -0
  324. package/src/scheduled-offline.test.ts +131 -0
  325. package/src/scheduled-offline.ts +66 -0
  326. package/src/scheduled-outcome-guidance-http.test.ts +139 -0
  327. package/src/scheduled-outcome-guidance.ts +9 -0
  328. package/src/scheduled-reply-unread-http.test.ts +212 -0
  329. package/src/scheduled-requirement-wake-http.test.ts +289 -0
  330. package/src/scheduled-requirement-wake.ts +125 -0
  331. package/src/scheduled-run-terminal.test.ts +290 -0
  332. package/src/scheduled-skip-blocking-task.test.ts +120 -0
  333. package/src/scheduled-skip-path-backoff-2622.test.ts +98 -0
  334. package/src/scheduled-stuck-http.test.ts +316 -0
  335. package/src/scheduled-stuck-notice-cap.test.ts +80 -0
  336. package/src/scheduled-stuck.ts +219 -0
  337. package/src/scheduled-tasks-http.test.ts +679 -0
  338. package/src/scheduled-tasks.ts +959 -0
  339. package/src/scheduled-work-outcome-http.test.ts +154 -0
  340. package/src/scheduled-work-outcome.ts +50 -0
  341. package/src/scoped-secrets.ts +167 -0
  342. package/src/secret-echo-negative-control.test.ts +118 -0
  343. package/src/send-dedup-request-id.test.ts +229 -0
  344. package/src/send-reply-agent-warning.test.ts +38 -38
  345. package/src/send-reply-alias-optional.test.ts +131 -0
  346. package/src/send-reply-attachments.test.ts +28 -7
  347. package/src/send_dedup.test.ts +54 -0
  348. package/src/send_dedup.ts +52 -6
  349. package/src/serve-error.test.ts +73 -0
  350. package/src/serve-error.ts +56 -0
  351. package/src/server.ts +4930 -377
  352. package/src/session-task-on-dispatch.ts +14 -0
  353. package/src/session-token-ownership-http.test.ts +122 -0
  354. package/src/shared/codex-inventory.ts +41 -0
  355. package/src/shared/daemon-provider-login.ts +31 -0
  356. package/src/shared/daemon-provider-snapshot.ts +52 -0
  357. package/src/shared/external-schedule-contract.ts +60 -0
  358. package/src/shared/node-name.test.ts +62 -0
  359. package/src/shared/node-name.ts +161 -0
  360. package/src/shared/probe-host-allowlist-drift.test.ts +45 -0
  361. package/src/shared/provider-application.ts +29 -0
  362. package/src/shared/provider-collection.ts +14 -0
  363. package/src/shared/provider-initialization.ts +8 -0
  364. package/src/shared/reserved-env-drift.test.ts +10 -0
  365. package/src/shared/scoped-secret-contract.ts +5 -0
  366. package/src/shared/task-content-limit-drift.test.ts +28 -0
  367. package/src/shared/task-content-limit.ts +25 -0
  368. package/src/side-thread-command-transport.test.ts +312 -0
  369. package/src/side-thread-command-transport.ts +318 -0
  370. package/src/side-thread-http-integration.test.ts +233 -0
  371. package/src/side-thread-http.ts +504 -0
  372. package/src/side-thread-production.test.ts +72 -0
  373. package/src/side-thread-production.ts +118 -0
  374. package/src/side-thread.test.ts +1067 -0
  375. package/src/side-thread.ts +2499 -0
  376. package/src/skillhub-http.test.ts +144 -0
  377. package/src/sqlite-close-checkpoint.test.ts +78 -0
  378. package/src/start-node.test.ts +265 -0
  379. package/src/start-request-error-domain.test.ts +182 -0
  380. package/src/start-skill-error-domain.test.ts +122 -0
  381. package/src/stats-versions-http.test.ts +65 -0
  382. package/src/status-alias-filter-http.test.ts +106 -0
  383. package/src/status-alias-resolver-http.test.ts +163 -0
  384. package/src/status-alias-resolver.ts +19 -0
  385. package/src/status-node-id-filter-http.test.ts +161 -0
  386. package/src/status-read-cache-http.test.ts +229 -0
  387. package/src/status-read-cache.ts +129 -0
  388. package/src/stop-delete-node.test.ts +567 -1
  389. package/src/task-access-http.test.ts +407 -0
  390. package/src/task-access.ts +420 -0
  391. package/src/task-activity.ts +60 -0
  392. package/src/task-auth-origin-http.test.ts +93 -0
  393. package/src/task-auth-origin.test.ts +24 -0
  394. package/src/task-auth-origin.ts +7 -0
  395. package/src/task-consumption.test.ts +508 -0
  396. package/src/task-diagnostic-http.test.ts +149 -0
  397. package/src/task-diagnostic.test.ts +115 -0
  398. package/src/task-diagnostic.ts +118 -0
  399. package/src/task-expiry-notice-http.test.ts +298 -0
  400. package/src/task-expiry-notice.ts +318 -0
  401. package/src/task-idempotency-mcp.test.ts +148 -0
  402. package/src/task-idempotency.test.ts +76 -0
  403. package/src/task-idempotency.ts +81 -0
  404. package/src/task-late-replies.ts +54 -0
  405. package/src/task-late-reply-http.test.ts +227 -0
  406. package/src/task-lifecycle-watcher-busy.test.ts +114 -0
  407. package/src/task-lifecycle-watcher.test.ts +209 -0
  408. package/src/task-lifecycle-watcher.ts +109 -0
  409. package/src/task-network-resolution-http.test.ts +140 -0
  410. package/src/task-not-found-error-domain.test.ts +114 -0
  411. package/src/task-offline-delivery-2668.test.ts +119 -0
  412. package/src/task-offline-delivery.ts +81 -0
  413. package/src/task-orphan-http.test.ts +287 -0
  414. package/src/task-orphan.ts +119 -0
  415. package/src/task-queue-ahead-http.test.ts +309 -0
  416. package/src/task-queue-ahead-scale.test.ts +236 -0
  417. package/src/task-queue-ahead.ts +186 -0
  418. package/src/task-rejection-log-http.test.ts +160 -0
  419. package/src/task-rejection-log.ts +61 -0
  420. package/src/task-sender-http.test.ts +143 -0
  421. package/src/task-stale-open-http.test.ts +292 -0
  422. package/src/task-stale-open.ts +103 -0
  423. package/src/tasks-pagination-http.test.ts +141 -0
  424. package/src/team-rules-status-http.test.ts +90 -0
  425. package/src/team-rules-status.test.ts +59 -0
  426. package/src/team-rules-status.ts +72 -0
  427. package/src/tmux-allowlist.test.ts +48 -0
  428. package/src/tool-audience-http.test.ts +248 -0
  429. package/src/tool-audience.ts +127 -0
  430. package/src/tools-list-json-schema.test.ts +94 -0
  431. package/src/tools.ts +4314 -392
  432. package/src/update-node-config-error-domain.test.ts +107 -0
  433. package/src/uploads-http.test.ts +6 -4
  434. package/src/uploads.ts +23 -4
  435. package/src/user-avatar-http.test.ts +74 -0
  436. package/src/user-avatar-image.ts +160 -0
  437. package/src/user-avatar-migration.test.ts +25 -0
  438. package/src/user-avatar-upload-http.test.ts +353 -0
  439. package/src/user-inbox-by-agent-http.test.ts +189 -0
  440. package/src/user-inbox-netid-notnull.test.ts +122 -0
  441. package/src/user-inbox-read-http.test.ts +223 -0
  442. package/src/user-inbox-schema.test.ts +54 -0
  443. package/src/version-stats.test.ts +66 -0
  444. package/src/version-stats.ts +109 -0
@@ -0,0 +1,281 @@
1
+ // node_rules_requests content retention — privacy purge of node file bytes.
2
+ //
3
+ // Real MCP in-process transport, same harness as rules-file-transport.test.ts.
4
+ // Covers:
5
+ // 1. read result is handed out on the first terminal read, still handed out to
6
+ // a second reader inside the grace window (the desktop app's
7
+ // request_in_flight → follow path), then purged: status + metadata stay,
8
+ // `content_purged: true` replaces content.
9
+ // 2. a caller outside the row's network can neither read nor stamp/purge it.
10
+ // 3. TTL sweep: >24h content cleared (stale pending flipped to timeout first),
11
+ // >30d rows deleted, fresh unread rows untouched.
12
+ // 4. write payload (`content` column) is cleared; skill_read name is kept.
13
+ //
14
+ // 跑法:cd server && COMMHUB_DB=/tmp/nrr.db bun test src/node-request-retention.test.ts
15
+ import { afterAll, beforeEach, describe, expect, test } from "bun:test";
16
+ import { Client } from "@modelcontextprotocol/sdk/client/index.js";
17
+ import { InMemoryTransport } from "@modelcontextprotocol/sdk/inMemory.js";
18
+ import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
19
+ import { db } from "./db.js";
20
+ import { registerTools } from "./tools.js";
21
+ import { CONTENT_GRACE_MS, CONTENT_TTL_MS, ROW_TTL_MS, sweepNodeRequestContent } from "./node-request-retention.js";
22
+ import { sweepRetention } from "./retention.js";
23
+
24
+ const NET = "net_nrr";
25
+ const OTHER_NET = "net_nrr_other";
26
+ const USER = "u_nrr_owner";
27
+ const NODE_ID = "node_nrr_claude";
28
+ const NODE_ALIAS = "nrr-claude";
29
+ const NODE_TOKEN = "tok_nrr_node";
30
+
31
+ function cleanup() {
32
+ for (const net of [NET, OTHER_NET]) {
33
+ try { db.run("DELETE FROM node_rules_requests WHERE network_id = ?1", [net]); } catch {}
34
+ try { db.run("DELETE FROM audit_log WHERE network_id = ?1", [net]); } catch {}
35
+ try { db.run("DELETE FROM nodes WHERE network_id = ?1", [net]); } catch {}
36
+ try { db.run("DELETE FROM api_tokens WHERE network_id = ?1", [net]); } catch {}
37
+ try { db.run("DELETE FROM network_members WHERE network_id = ?1", [net]); } catch {}
38
+ try { db.run("DELETE FROM networks WHERE network_id = ?1", [net]); } catch {}
39
+ }
40
+ try { db.run("DELETE FROM users WHERE user_id = ?1", [USER]); } catch {}
41
+ }
42
+
43
+ function seedWorld() {
44
+ db.run(`INSERT INTO users (user_id, username, password_hash, role, created_at) VALUES (?1, ?2, 'x', 'user', datetime('now'))`, [USER, USER]);
45
+ for (const net of [NET, OTHER_NET]) {
46
+ db.run(`INSERT INTO networks (network_id, network_name, owner_id, created_at) VALUES (?1, ?2, ?3, datetime('now'))`, [net, net, USER]);
47
+ db.run(`INSERT INTO network_members (user_id, network_id, role, joined_at) VALUES (?1, ?2, 'owner', datetime('now'))`, [USER, net]);
48
+ }
49
+ db.run(
50
+ `INSERT INTO nodes (node_id, node_name, alias, network_id, created_at, updated_at) VALUES (?1, ?2, ?3, ?4, datetime('now'), datetime('now'))`,
51
+ [NODE_ID, NODE_ALIAS, NODE_ALIAS, NET],
52
+ );
53
+ db.run(
54
+ `INSERT INTO api_tokens (token_id, user_id, network_id, scope, name, token_hash, expires_at, revoked_at) VALUES (?1, ?2, ?3, 'network', ?4, ?5, NULL, NULL)`,
55
+ [NODE_TOKEN, USER, NET, `node:${NODE_ALIAS}`, "hash_nrr_node"],
56
+ );
57
+ }
58
+
59
+ type Identity = { net: string; alias: string; isNetworkToken: boolean; tokenId: string };
60
+ const asUser: Identity = { net: NET, alias: USER, isNetworkToken: false, tokenId: "tok_nrr_user" };
61
+ // Same human, scoped to the OTHER network: passes canWrite there, but the row
62
+ // lives in NET — SEC-1 must answer request_not_found and touch nothing.
63
+ const asUserOtherScope: Identity = { net: OTHER_NET, alias: USER, isNetworkToken: false, tokenId: "tok_nrr_user_other" };
64
+ const asNode: Identity = { net: NET, alias: NODE_ALIAS, isNetworkToken: true, tokenId: NODE_TOKEN };
65
+ // Same user, same network, a different login token: #1999 makes project-file
66
+ // results readable only by the token that asked.
67
+ const asUserOtherLogin: Identity = { net: NET, alias: USER, isNetworkToken: false, tokenId: "tok_nrr_user_other_login" };
68
+
69
+ async function connect(id: Identity) {
70
+ const server = new McpServer({ name: "nrr-test", version: "1" });
71
+ registerTools(server, undefined, id.net, USER, id.alias, id.isNetworkToken, id.tokenId);
72
+ const client = new Client({ name: "nrr-client", version: "1" });
73
+ const [ct, st] = InMemoryTransport.createLinkedPair();
74
+ await server.connect(st);
75
+ await client.connect(ct);
76
+ const call = async (name: string, args: Record<string, unknown>) => {
77
+ const r: any = await client.callTool({ name, arguments: args });
78
+ const first = r.content?.[0];
79
+ if (!first || first.type !== "text") throw new Error(`no text result from ${name}`);
80
+ return JSON.parse(first.text);
81
+ };
82
+ const close = async () => { await client.close(); await server.close(); };
83
+ return { call, close };
84
+ }
85
+
86
+ type Row = { status: string; content: string | null; result_content: string | null; file_name: string | null; first_read_at: number | null; content_purged_at: number | null; op: string };
87
+ const rowOf = (id: string) => db.get<Row>(
88
+ "SELECT status, content, result_content, file_name, first_read_at, content_purged_at, op FROM node_rules_requests WHERE request_id = ?1", id,
89
+ );
90
+ const ageFirstRead = (id: string, ms: number) => db.run("UPDATE node_rules_requests SET first_read_at = first_read_at - ?1 WHERE request_id = ?2", [ms, id]);
91
+ const ageCreated = (id: string, ms: number) => db.run("UPDATE node_rules_requests SET created_at = created_at - ?1 WHERE request_id = ?2", [ms, id]);
92
+
93
+ async function readRoundTrip(u: Awaited<ReturnType<typeof connect>>, n: Awaited<ReturnType<typeof connect>>, body: string) {
94
+ const enq = await u.call("read_node_rules_file", { node_id: NODE_ID });
95
+ expect(enq.ok).toBe(true);
96
+ await n.call("get_rules_file_request", {});
97
+ await n.call("ack_rules_file_request", { request_id: enq.request_id, status: "done", file_name: "CLAUDE.md", exists: true, content: body });
98
+ return enq.request_id as string;
99
+ }
100
+
101
+ beforeEach(() => { cleanup(); seedWorld(); });
102
+ afterAll(cleanup);
103
+
104
+ describe("node_rules_requests — read once, purge after grace", () => {
105
+ test("content returned on first terminal read and to a follower inside the grace window, then purged", async () => {
106
+ const u = await connect(asUser);
107
+ const n = await connect(asNode);
108
+ try {
109
+ const body = "# secret rules\n";
110
+ const rid = await readRoundTrip(u, n, body);
111
+ expect(rowOf(rid)!.first_read_at).toBeNull();
112
+
113
+ const first = await u.call("get_rules_file_result", { request_id: rid });
114
+ expect(first).toMatchObject({ ok: true, status: "done", content: body, file_name: "CLAUDE.md", exists: true });
115
+ expect(first.content_purged).toBeUndefined();
116
+ const stamped = rowOf(rid)!.first_read_at;
117
+ expect(stamped).not.toBeNull();
118
+
119
+ // Second reader (app follow path) inside the grace window still gets it,
120
+ // and the stamp is NOT pushed forward (a poller can't keep it alive).
121
+ sweepNodeRequestContent();
122
+ const follower = await u.call("get_rules_file_result", { request_id: rid });
123
+ expect(follower.content).toBe(body);
124
+ expect(rowOf(rid)!.first_read_at).toBe(stamped);
125
+
126
+ ageFirstRead(rid, CONTENT_GRACE_MS + 1);
127
+ // Any enqueue runs the opportunistic sweep.
128
+ await u.call("list_node_skills", { node_id: NODE_ID });
129
+ const row = rowOf(rid)!;
130
+ expect(row.result_content).toBeNull();
131
+ expect(row.content_purged_at).not.toBeNull();
132
+ expect(row.status).toBe("done");
133
+ expect(row.file_name).toBe("CLAUDE.md");
134
+
135
+ const after = await u.call("get_rules_file_result", { request_id: rid });
136
+ expect(after).toMatchObject({ ok: true, status: "done", file_name: "CLAUDE.md", exists: true, content_purged: true });
137
+ expect("content" in after).toBe(false);
138
+ } finally { await u.close(); await n.close(); }
139
+ }, 20_000);
140
+
141
+ test("non-terminal polls do not stamp; a never-read result keeps its content until TTL", async () => {
142
+ const u = await connect(asUser);
143
+ const n = await connect(asNode);
144
+ try {
145
+ const enq = await u.call("read_node_rules_file", { node_id: NODE_ID });
146
+ expect((await u.call("get_rules_file_result", { request_id: enq.request_id })).status).toBe("pending");
147
+ expect(rowOf(enq.request_id)!.first_read_at).toBeNull();
148
+ await n.call("get_rules_file_request", {});
149
+ await n.call("ack_rules_file_request", { request_id: enq.request_id, status: "done", file_name: "CLAUDE.md", exists: true, content: "x" });
150
+ sweepNodeRequestContent(Date.now() + CONTENT_GRACE_MS * 10);
151
+ expect(rowOf(enq.request_id)!.result_content).toBe("x");
152
+ } finally { await u.close(); await n.close(); }
153
+ }, 20_000);
154
+ });
155
+
156
+ describe("node_rules_requests — authorization", () => {
157
+ test("a caller outside the row's network gets request_not_found and cannot stamp or purge it", async () => {
158
+ const u = await connect(asUser);
159
+ const n = await connect(asNode);
160
+ const o = await connect(asUserOtherScope);
161
+ try {
162
+ const rid = await readRoundTrip(u, n, "# mine\n");
163
+ for (let i = 0; i < 3; i++) {
164
+ expect(await o.call("get_rules_file_result", { request_id: rid })).toMatchObject({ ok: false, error: "request_not_found" });
165
+ }
166
+ // Also pass the owner's network_id explicitly — scope is the token's, not the arg's.
167
+ expect((await o.call("get_rules_file_result", { request_id: rid, network_id: NET })).content).toBeUndefined();
168
+ expect(rowOf(rid)!.first_read_at).toBeNull();
169
+ sweepNodeRequestContent(Date.now() + CONTENT_GRACE_MS * 10);
170
+ expect(rowOf(rid)!.result_content).toBe("# mine\n");
171
+ // The rightful requester still gets it.
172
+ expect((await u.call("get_rules_file_result", { request_id: rid })).content).toBe("# mine\n");
173
+ } finally { await u.close(); await n.close(); await o.close(); }
174
+ }, 20_000);
175
+ });
176
+
177
+ describe("node_rules_requests — project files (#1999)", () => {
178
+ test("another login token can't read or stamp a file_read row; the requester's read starts the grace clock; path is kept", async () => {
179
+ const u = await connect(asUser);
180
+ const n = await connect(asNode);
181
+ const other = await connect(asUserOtherLogin);
182
+ try {
183
+ const enq = await u.call("read_node_file", { node_id: NODE_ID, path: "docs/plan.md" });
184
+ expect(enq.ok).toBe(true);
185
+ await n.call("get_rules_file_request", {});
186
+ const body = JSON.stringify({ path: "docs/plan.md", kind: "text", content: "TOP SECRET PLAN" });
187
+ await n.call("ack_rules_file_request", { request_id: enq.request_id, status: "done", content: body });
188
+
189
+ expect(await other.call("get_rules_file_result", { request_id: enq.request_id })).toMatchObject({ ok: false, error: "request_not_found" });
190
+ expect(rowOf(enq.request_id)!.first_read_at).toBeNull();
191
+
192
+ expect((await u.call("get_rules_file_result", { request_id: enq.request_id })).content).toBe(body);
193
+ ageFirstRead(enq.request_id, CONTENT_GRACE_MS + 1);
194
+ sweepNodeRequestContent();
195
+ const row = rowOf(enq.request_id)!;
196
+ expect(row.result_content).toBeNull();
197
+ expect(row.content).toBe("docs/plan.md");
198
+ expect(await u.call("get_rules_file_result", { request_id: enq.request_id })).toMatchObject({ status: "done", content_purged: true });
199
+ } finally { await u.close(); await n.close(); await other.close(); }
200
+ }, 20_000);
201
+ });
202
+
203
+ describe("node_rules_requests — write payload", () => {
204
+ test("write body in `content` is cleared after the grace window; skill_read name is kept", async () => {
205
+ const u = await connect(asUser);
206
+ const n = await connect(asNode);
207
+ try {
208
+ const body = "# new rules with a secret\n";
209
+ const w = await u.call("write_node_rules_file", { node_id: NODE_ID, content: body });
210
+ await n.call("get_rules_file_request", {});
211
+ await n.call("ack_rules_file_request", { request_id: w.request_id, status: "done", file_name: "CLAUDE.md", exists: true });
212
+ expect(rowOf(w.request_id)!.content).toBe(body);
213
+
214
+ const s = await u.call("read_node_skill", { node_id: NODE_ID, name: "my-skill" });
215
+ await n.call("get_rules_file_request", {});
216
+ await n.call("ack_rules_file_request", { request_id: s.request_id, status: "done", content: JSON.stringify({ name: "my-skill", content: "SKILL BODY" }) });
217
+
218
+ const wr = await u.call("get_rules_file_result", { request_id: w.request_id });
219
+ expect(wr).toMatchObject({ status: "done", op: "write" });
220
+ expect(wr.content).toBeUndefined();
221
+ expect((await u.call("get_rules_file_result", { request_id: s.request_id })).content).toContain("SKILL BODY");
222
+
223
+ ageFirstRead(w.request_id, CONTENT_GRACE_MS + 1);
224
+ ageFirstRead(s.request_id, CONTENT_GRACE_MS + 1);
225
+ sweepNodeRequestContent();
226
+
227
+ const wRow = rowOf(w.request_id)!;
228
+ expect(wRow.content).toBeNull();
229
+ expect(wRow.content_purged_at).not.toBeNull();
230
+ expect(wRow.status).toBe("done");
231
+ const sRow = rowOf(s.request_id)!;
232
+ expect(sRow.result_content).toBeNull();
233
+ expect(sRow.content).toBe("my-skill");
234
+ expect(await u.call("get_rules_file_result", { request_id: w.request_id })).toMatchObject({ status: "done", op: "write", content_purged: true });
235
+ } finally { await u.close(); await n.close(); }
236
+ }, 20_000);
237
+ });
238
+
239
+ describe("node_rules_requests — TTL sweep", () => {
240
+ test(">24h content cleared (stale pending write expired first, so no node can pull an emptied write); >30d rows deleted; fresh rows kept", async () => {
241
+ const u = await connect(asUser);
242
+ const n = await connect(asNode);
243
+ try {
244
+ // Create everything first, age afterwards: every enqueue runs the sweep.
245
+ const oldRead = await readRoundTrip(u, n, "# old, never fetched\n");
246
+ const ancient = await readRoundTrip(u, n, "# ancient\n");
247
+ const fresh = await readRoundTrip(u, n, "# fresh, never fetched\n");
248
+ // A write the node never pulled (offline for a day). Enqueued last so
249
+ // single-flight doesn't refuse it.
250
+ const w = await u.call("write_node_rules_file", { node_id: NODE_ID, content: "# stale write body\n" });
251
+ expect(w.ok).toBe(true);
252
+ ageCreated(oldRead, CONTENT_TTL_MS + 60_000);
253
+ ageCreated(ancient, ROW_TTL_MS + 60_000);
254
+ ageCreated(w.request_id, CONTENT_TTL_MS + 60_000);
255
+
256
+ const r = await sweepRetention();
257
+ expect(r.nodeRequests.deleted).toBe(1);
258
+ expect(r.nodeRequests.timedOut).toBe(1);
259
+ expect(r.nodeRequests.purged).toBe(2);
260
+
261
+ expect(rowOf(ancient)).toBeNull();
262
+ const o = rowOf(oldRead)!;
263
+ expect(o.result_content).toBeNull();
264
+ expect(o.status).toBe("done");
265
+ expect(o.file_name).toBe("CLAUDE.md");
266
+ expect(rowOf(fresh)!.result_content).toBe("# fresh, never fetched\n");
267
+
268
+ const wr = rowOf(w.request_id)!;
269
+ expect(wr.status).toBe("timeout");
270
+ expect(wr.content).toBeNull();
271
+ // The node coming back must not receive the emptied write.
272
+ expect(await n.call("get_rules_file_request", {})).toEqual({ ok: true, request: null });
273
+
274
+ expect(await u.call("get_rules_file_result", { request_id: oldRead })).toMatchObject({ status: "done", content_purged: true });
275
+
276
+ // Idempotent.
277
+ const again = sweepNodeRequestContent();
278
+ expect(again).toEqual({ timedOut: 0, purged: 0, deleted: 0 });
279
+ } finally { await u.close(); await n.close(); }
280
+ }, 20_000);
281
+ });
@@ -0,0 +1,120 @@
1
+ // node_rules_requests content retention (privacy).
2
+ //
3
+ // The rules-file / skills (and project-folder) queue carries **node file
4
+ // contents** through the hub: `result_content` holds what the node sent back
5
+ // (CLAUDE.md / AGENTS.md, SKILL.md, directory listings, file bodies) and
6
+ // `content` holds write payloads (the full new rules file). Before this module
7
+ // nothing ever cleared or deleted those rows — every file anyone ever opened in
8
+ // the desktop app stayed in the hub DB forever.
9
+ //
10
+ // Policy (metadata — status, op, file_name, file_exists, error, timestamps,
11
+ // requester — is kept for audit; only file bytes are dropped):
12
+ //
13
+ // 1. Read-once + grace: the first time an authorized requester reads a
14
+ // TERMINAL result (done/failed/timeout) the row is stamped `first_read_at`.
15
+ // CONTENT_GRACE_MS later the content is purged. Not immediate, because the
16
+ // desktop app has a real second-reader path: when enqueue is rejected with
17
+ // `request_in_flight` the app FOLLOWS the existing request id
18
+ // (requestIdToFollow → waitForRulesFileResult, NodeRulesSection /
19
+ // NodeSkillsSection / NodeFilesSection). Two windows (or a remount) polling
20
+ // the same request reach terminal within one poll interval (≤ 3 s) of each
21
+ // other; an immediate purge would hand the second one `done` with no
22
+ // content and NodeRulesSection would load an EMPTY editor (`content ?? ''`)
23
+ // that a Save would then write back to the node. 60 s is 20× the slowest
24
+ // poll interval.
25
+ // 2. TTL: anything older than CONTENT_TTL_MS gets its content purged whether
26
+ // or not anyone ever read it (e.g. the app was closed mid-request). A
27
+ // still-pending/in_progress row that old is first flipped to `timeout`, so
28
+ // a node that comes back after a day can never pull a write whose payload
29
+ // was just nulled (it would otherwise receive `content: ""` and write an
30
+ // empty rules file).
31
+ // 3. Rows older than ROW_TTL_MS are deleted outright.
32
+ // 4. Run logs (op = logs_tail) are stricter: read-once with NO grace — the
33
+ // first authorized terminal read purges them in the same call
34
+ // (purgeLogsResultNow), because the app never follows another request's
35
+ // logs result (it simply asks again) and a process log is the most
36
+ // sensitive thing on this queue. Unread terminal results are purged after
37
+ // LOGS_CONTENT_TTL_MS (the requester closed the page). The filter JSON in
38
+ // `content` (it can hold a user-typed grep) goes with it.
39
+ //
40
+ // Every statement is bounded (LIMIT via `request_id IN (SELECT … LIMIT n)` —
41
+ // SQLite's UPDATE/DELETE … LIMIT needs a compile flag we don't control) and
42
+ // uses an index (idx_nrr_created / idx_nrr_first_read). It runs
43
+ // opportunistically on enqueue and on terminal reads, from a one-shot timer
44
+ // armed at the first terminal read, and from the hourly retention sweeper
45
+ // (retention.ts) — so the first sweep after deploy also clears every old row
46
+ // that predates this module.
47
+
48
+ import { db } from "./db.js";
49
+
50
+ export const CONTENT_GRACE_MS = 60_000;
51
+ export const CONTENT_TTL_MS = 24 * 60 * 60 * 1000;
52
+ export const ROW_TTL_MS = 30 * 24 * 60 * 60 * 1000;
53
+ export const SWEEP_BATCH = 500;
54
+ export const LOGS_CONTENT_TTL_MS = 5 * 60 * 1000;
55
+
56
+ export type NodeRequestSweepResult = { timedOut: number; purged: number; deleted: number };
57
+
58
+ // `content` is only a file body for op=write. For skill_read / file_read it is
59
+ // the skill name / relative path the requester asked for — audit metadata, kept.
60
+ // For logs_tail it is the filter JSON, which may carry a user-typed grep — purged.
61
+ const PURGE_SET =
62
+ "result_content = NULL, content = CASE WHEN op IN ('write', 'logs_tail') THEN NULL ELSE content END, content_purged_at = ?1";
63
+
64
+ function purgeWhere(where: string, params: (string | number)[], now: number): number {
65
+ const r = db.run(
66
+ `UPDATE node_rules_requests SET ${PURGE_SET} WHERE request_id IN (SELECT request_id FROM node_rules_requests WHERE content_purged_at IS NULL AND ${where} LIMIT ${SWEEP_BATCH})`,
67
+ [now, ...params],
68
+ );
69
+ return r.changes ?? 0;
70
+ }
71
+
72
+ export function sweepNodeRequestContent(now: number = Date.now()): NodeRequestSweepResult {
73
+ const out: NodeRequestSweepResult = { timedOut: 0, purged: 0, deleted: 0 };
74
+ try {
75
+ // Delete first so rows past the row TTL aren't pointlessly purged, then
76
+ // expire stale non-terminal rows, then purge.
77
+ out.deleted = db.run(
78
+ `DELETE FROM node_rules_requests WHERE request_id IN (SELECT request_id FROM node_rules_requests WHERE created_at < ?1 LIMIT ${SWEEP_BATCH})`,
79
+ [now - ROW_TTL_MS],
80
+ ).changes ?? 0;
81
+ const ttlCutoff = now - CONTENT_TTL_MS;
82
+ out.timedOut = db.run(
83
+ `UPDATE node_rules_requests SET status = 'timeout', acked_at = ?1, error = ?2 WHERE request_id IN (SELECT request_id FROM node_rules_requests WHERE created_at < ?3 AND status IN ('pending', 'in_progress') LIMIT ${SWEEP_BATCH})`,
84
+ [now, "expired by retention sweep (node never answered)", ttlCutoff],
85
+ ).changes ?? 0;
86
+ // ?1 = now (PURGE_SET), ?2… = where params.
87
+ out.purged += purgeWhere("first_read_at IS NOT NULL AND first_read_at <= ?2 AND status IN ('done', 'failed', 'timeout')", [now - CONTENT_GRACE_MS], now);
88
+ out.purged += purgeWhere("created_at < ?2 AND status IN ('done', 'failed', 'timeout')", [ttlCutoff], now);
89
+ out.purged += purgeWhere("op = 'logs_tail' AND created_at < ?2 AND status IN ('done', 'failed', 'timeout')", [now - LOGS_CONTENT_TTL_MS], now);
90
+ } catch (e: any) {
91
+ console.log(`[commhub retention] node_rules_requests sweep failed: ${e?.message ?? e}`);
92
+ }
93
+ return out;
94
+ }
95
+
96
+ /** Called by get_rules_file_result AFTER the requester passed every auth check
97
+ * and only for a terminal status. Stamps the first terminal read, arms a
98
+ * one-shot purge for after the grace window, and reports whether this row's
99
+ * content is already gone. */
100
+ export function noteTerminalResultRead(requestId: string, now: number = Date.now()): { purged: boolean } {
101
+ const r = db.run(
102
+ "UPDATE node_rules_requests SET first_read_at = ?1 WHERE request_id = ?2 AND first_read_at IS NULL",
103
+ [now, requestId],
104
+ );
105
+ if ((r.changes ?? 0) > 0) {
106
+ const t = setTimeout(() => { sweepNodeRequestContent(); }, CONTENT_GRACE_MS + 1_000);
107
+ (t as any).unref?.();
108
+ }
109
+ const row = db.get<{ content_purged_at: number | null }>(
110
+ "SELECT content_purged_at FROM node_rules_requests WHERE request_id = ?1",
111
+ requestId,
112
+ );
113
+ return { purged: row?.content_purged_at != null };
114
+ }
115
+
116
+ /** Run-log results are read-once: called by get_rules_file_result right after it
117
+ * handed a terminal logs_tail result to its (authorized) requester. */
118
+ export function purgeLogsResultNow(requestId: string, now: number = Date.now()): void {
119
+ db.run(`UPDATE node_rules_requests SET ${PURGE_SET} WHERE request_id = ?2 AND op = 'logs_tail' AND content_purged_at IS NULL`, [now, requestId]);
120
+ }
@@ -0,0 +1,190 @@
1
+ // #1491 E1 — the node-secret lane over REST.
2
+ //
3
+ // The lane itself is old (tools.ts `node_secret_*` → scoped-secrets.ts → node
4
+ // doorbell → agent-node `reconcileNodeSecrets`). What was missing is **any way
5
+ // for the client to drive it**: MCP-only, request/ack shaped. These two routes
6
+ // are deliberately thin — enqueue, then poll — and the authorization stays in
7
+ // the lane (owner/admin), not duplicated here.
8
+ //
9
+ // Load-bearing assertions:
10
+ // * a plain member of the network is refused (403), an owner gets through;
11
+ // * a node that does not advertise `node_secrets_capable` is a 409, not a
12
+ // silent queue entry that expires 120s later;
13
+ // * `put`/`delete` without a revision is a 400 (inventing 0 would clobber a
14
+ // file the operator edited in between);
15
+ // * the poll returns the node's snapshot once it acks — key NAMES and a
16
+ // revision only, never a value.
17
+ import { afterAll, beforeAll, beforeEach, describe, expect, test } from "bun:test";
18
+ import { mkdtempSync, rmSync } from "node:fs";
19
+ import { tmpdir } from "node:os";
20
+ import { join } from "node:path";
21
+
22
+ const PRIVATE_DB_DIR = mkdtempSync(join(tmpdir(), "anet-nodesecret-rest-"));
23
+ process.env.COMMHUB_DB ||= join(PRIVATE_DB_DIR, "hub.db");
24
+
25
+ let server: ReturnType<typeof Bun.serve>;
26
+ let base = "";
27
+ let ownerToken = "", memberToken = "";
28
+ let net = "", ownerId = "", memberId = "";
29
+ const CAPABLE = "n_capable";
30
+ const PLAIN = "n_plain";
31
+
32
+ const post = async (path: string, token: string, body: unknown) => {
33
+ const r = await fetch(`${base}${path}`, {
34
+ method: "POST",
35
+ headers: { Authorization: `Bearer ${token}`, "Content-Type": "application/json" },
36
+ body: JSON.stringify(body),
37
+ });
38
+ return { status: r.status, body: await r.json() as any };
39
+ };
40
+ const get = async (path: string, token: string) => {
41
+ const r = await fetch(`${base}${path}`, { headers: { Authorization: `Bearer ${token}` } });
42
+ return { status: r.status, body: await r.json() as any };
43
+ };
44
+
45
+ beforeAll(async () => {
46
+ const { db } = await import("./db.js");
47
+ const { register, addNetworkMember } = await import("./auth.js");
48
+ const stamp = Date.now();
49
+
50
+ const owner = register(`ns_owner_${stamp}`, "NsOwner-Strong-1!");
51
+ const member = register(`ns_member_${stamp}`, "NsMember-Strong-1!");
52
+ expect(owner.ok && member.ok).toBe(true);
53
+ ownerToken = owner.token!;
54
+ memberToken = member.token!;
55
+ net = owner.network_id!;
56
+ ownerId = db.get<{ user_id: string }>("SELECT user_id FROM users WHERE username = ?1", `ns_owner_${stamp}`)!.user_id;
57
+ memberId = db.get<{ user_id: string }>("SELECT user_id FROM users WHERE username = ?1", `ns_member_${stamp}`)!.user_id;
58
+ // A plain member of the same network: must still be refused by the lane.
59
+ expect(addNetworkMember(net, memberId, "member").ok).toBe(true);
60
+
61
+ const seedNode = (nodeId: string, capable: boolean) => db.run(
62
+ `INSERT INTO nodes (node_id, node_name, alias, network_id, lifecycle_state, config_snapshot)
63
+ VALUES (?1, ?1, ?1, ?2, 'active', ?3)`,
64
+ [nodeId, net, JSON.stringify(capable ? { node_secrets_capable: true } : {})],
65
+ );
66
+ seedNode(CAPABLE, true);
67
+ seedNode(PLAIN, false);
68
+
69
+ const mod = await import("./server.js");
70
+ server = mod.bootServer({ port: 0, hostname: "127.0.0.1" });
71
+ base = `http://127.0.0.1:${server.port}`;
72
+ });
73
+
74
+ afterAll(() => {
75
+ try { server?.stop(true); } catch {}
76
+ try { rmSync(PRIVATE_DB_DIR, { recursive: true, force: true }); } catch {}
77
+ });
78
+
79
+ /** The lane allows ONE pending request per node. Every test starts from a clean
80
+ * queue, otherwise ordering decides the outcome (the first version of this file
81
+ * went red exactly that way: a `list` from an earlier test left the node busy). */
82
+ async function drainPending() {
83
+ const { pullNodeSecrets, ackNodeSecrets } = await import("./scoped-secrets.js");
84
+ const daemon = { ok: true as const, networkId: net, daemonNodeId: CAPABLE, daemonAlias: CAPABLE };
85
+ const pulled = pullNodeSecrets(daemon);
86
+ const list = pulled && Array.isArray((pulled as any).requests) ? (pulled as any).requests : [];
87
+ for (const r of list) ackNodeSecrets(daemon, r.request_id, null, true);
88
+ }
89
+
90
+ beforeEach(async () => { await drainPending(); });
91
+
92
+ describe("POST /api/nodes/:id/secrets", () => {
93
+ test("owner can enqueue a list request", async () => {
94
+ const r = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, ownerToken, { action: "list" });
95
+ expect(r.status).toBe(200);
96
+ expect(r.body.ok).toBe(true);
97
+ expect(String(r.body.request_id)).toStartWith("nsk_");
98
+ });
99
+
100
+ test("a plain member of the same network is refused (403)", async () => {
101
+ const r = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, memberToken, { action: "list" });
102
+ expect(r.status).toBe(403);
103
+ expect(r.body.error).toBe("secret_admin_required");
104
+ });
105
+
106
+ test("a node without node_secrets_capable is a 409, not a queued request", async () => {
107
+ const r = await post(`/api/nodes/${PLAIN}/secrets?network_id=${net}`, ownerToken, { action: "list" });
108
+ expect(r.status).toBe(409);
109
+ expect(r.body.error).toBe("node_secrets_upgrade_required");
110
+ });
111
+
112
+ test("put without a revision is a 400", async () => {
113
+ const r = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, ownerToken, { action: "put", key: "A_KEY", value: "v" });
114
+ expect(r.status).toBe(400);
115
+ expect(r.body.error).toBe("revision_required");
116
+ });
117
+
118
+ test("an unknown action is a 400", async () => {
119
+ const r = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, ownerToken, { action: "wipe" });
120
+ expect(r.status).toBe(400);
121
+ expect(r.body.error).toBe("invalid_action");
122
+ });
123
+
124
+ test("a second pending request on the same node is a 409 (secret_store_busy)", async () => {
125
+ // The previous test cases left requests pending; the lane allows one at a
126
+ // time per node. Drain by acking through the lane's own API.
127
+ const { ackNodeSecrets } = await import("./scoped-secrets.js");
128
+ const { db } = await import("./db.js");
129
+ const pending = db.all<any>("SELECT 1"); // no-op, keeps the import honest
130
+ expect(Array.isArray(pending)).toBe(true);
131
+ const first = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, ownerToken, { action: "list" });
132
+ if (first.status === 200) {
133
+ const second = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, ownerToken, { action: "list" });
134
+ expect(second.status).toBe(409);
135
+ expect(second.body.error).toBe("secret_store_busy");
136
+ // Clean up so the poll test below starts from a known state.
137
+ ackNodeSecrets(
138
+ { ok: true, networkId: net, daemonNodeId: CAPABLE, daemonAlias: CAPABLE },
139
+ first.body.request_id, { network_id: net, daemon_node_id: null, node_id: CAPABLE, revision: 1, activation: "next_start", keys: [] }, true,
140
+ );
141
+ } else {
142
+ expect(first.status).toBe(409);
143
+ }
144
+ });
145
+ });
146
+
147
+ describe("GET /api/nodes/:id/secrets/:request_id", () => {
148
+ test("poll returns the node's ack snapshot (names + revision)", async () => {
149
+ const { ackNodeSecrets } = await import("./scoped-secrets.js");
150
+ const created = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, ownerToken, { action: "list" });
151
+ expect(created.status).toBe(200);
152
+ const rid = created.body.request_id as string;
153
+
154
+ // Before the node answers, the poll says pending.
155
+ const pending = await get(`/api/nodes/${CAPABLE}/secrets/${rid}?network_id=${net}`, ownerToken);
156
+ expect(pending.status).toBe(200);
157
+ expect(pending.body.status).toBe("pending");
158
+
159
+ // The node answers through its own lane call (same code path as the doorbell).
160
+ const acked = ackNodeSecrets(
161
+ { ok: true, networkId: net, daemonNodeId: CAPABLE, daemonAlias: CAPABLE },
162
+ rid,
163
+ { network_id: net, daemon_node_id: null, node_id: CAPABLE, revision: 2, activation: "next_start", keys: [{ key: "ALPHA_KEY", source: "node" }] },
164
+ );
165
+ expect(acked.ok).toBe(true);
166
+
167
+ const done = await get(`/api/nodes/${CAPABLE}/secrets/${rid}?network_id=${net}`, ownerToken);
168
+ expect(done.status).toBe(200);
169
+ expect(done.body.status).toBe("succeeded");
170
+ expect(done.body.snapshot.keys).toEqual([{ key: "ALPHA_KEY", source: "node" }]);
171
+ // Names only — no value field anywhere in the payload.
172
+ expect(JSON.stringify(done.body)).not.toContain("value");
173
+ });
174
+
175
+ test("a plain member cannot poll (403)", async () => {
176
+ const created = await post(`/api/nodes/${CAPABLE}/secrets?network_id=${net}`, ownerToken, { action: "list" });
177
+ const rid = created.status === 200 ? created.body.request_id : "nsk_missing";
178
+ if (created.status === 200) {
179
+ const { ackNodeSecrets } = await import("./scoped-secrets.js");
180
+ ackNodeSecrets({ ok: true, networkId: net, daemonNodeId: CAPABLE, daemonAlias: CAPABLE }, rid, null, true);
181
+ }
182
+ const r = await get(`/api/nodes/${CAPABLE}/secrets/${rid}?network_id=${net}`, memberToken);
183
+ expect(r.status).toBe(403);
184
+ });
185
+
186
+ test("an unknown request id is a 404", async () => {
187
+ const r = await get(`/api/nodes/${CAPABLE}/secrets/nsk_does_not_exist?network_id=${net}`, ownerToken);
188
+ expect(r.status).toBe(404);
189
+ });
190
+ });