@sleep2agi/commhub-server 0.9.0-preview.27 → 0.9.0-preview.270
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +120 -3
- package/bin/commhub.ts +93 -9
- package/build-info.json +7 -0
- package/package.json +10 -8
- package/src/ack-create-request-transport.test.ts +182 -0
- package/src/ack-create-request.test.ts +52 -8
- package/src/admin-delete-network-http.test.ts +229 -0
- package/src/admin-networks-http.test.ts +88 -0
- package/src/adoption-candidates-http.test.ts +140 -0
- package/src/adoption-candidates.ts +158 -0
- package/src/agent-access-batch.test.ts +210 -0
- package/src/agent-access.ts +585 -0
- package/src/agent-acl-groups-http.test.ts +247 -0
- package/src/agent-acl-http.test.ts +691 -0
- package/src/agent-acl-slice3-http.test.ts +885 -0
- package/src/agent-department-grants.test.ts +129 -0
- package/src/agent-department-http.test.ts +215 -0
- package/src/agent-groups-perf.test.ts +223 -0
- package/src/agent-notice.ts +48 -0
- package/src/agent-team-whoami-http.test.ts +98 -0
- package/src/agent-teams-http.test.ts +330 -0
- package/src/agent-teams.ts +244 -0
- package/src/alias-baseline-2571.test.ts +162 -0
- package/src/alias-baseline.ts +113 -0
- package/src/alias-filter.test.ts +72 -0
- package/src/alias-filter.ts +42 -0
- package/src/api-host-supervisors-can-create-nodes.test.ts +350 -0
- package/src/api-host-supervisors-fallback.test.ts +6 -7
- package/src/api-host-supervisors-runtime-readiness.test.ts +195 -0
- package/src/api-nodes-shape.test.ts +131 -4
- package/src/auth-abuse-counters.test.ts +144 -0
- package/src/auth-abuse-counters.ts +122 -0
- package/src/auth-layer-shape.test.ts +105 -0
- package/src/auth-password-change-cli-tokens-http.test.ts +423 -0
- package/src/auth-sessions-http.test.ts +260 -0
- package/src/auth-validate.test.ts +5 -1
- package/src/auth-weak-password-login.test.ts +176 -0
- package/src/auth.ts +641 -68
- package/src/backfill-node-ids-2664.test.ts +128 -0
- package/src/binding-generation-http.test.ts +141 -0
- package/src/blocked-exit-on-reply.test.ts +122 -0
- package/src/broadcast-fanout-2721.test.ts +149 -0
- package/src/broadcast-fanout.ts +117 -0
- package/src/build-commit-report-http.test.ts +128 -0
- package/src/build-info.test.ts +60 -0
- package/src/build-info.ts +85 -0
- package/src/chain-attempt-dedup.test.ts +447 -0
- package/src/clip.test.ts +36 -0
- package/src/clip.ts +48 -0
- package/src/clone-node.test.ts +269 -0
- package/src/clone-node.ts +289 -0
- package/src/codex-config-flags.ts +77 -0
- package/src/codex-fork-contract.ts +23 -0
- package/src/codex-fork-migration.test.ts +38 -0
- package/src/commhub-bin-args.test.ts +85 -0
- package/src/config-apply-validate.test.ts +188 -1
- package/src/config-apply-validate.ts +222 -3
- package/src/cors-origins.test.ts +73 -0
- package/src/create-node-blocked-gate.test.ts +365 -0
- package/src/create-node-error-domain.test.ts +127 -0
- package/src/create-node-network-id.test.ts +91 -0
- package/src/create-node-tool-schema.test.ts +49 -0
- package/src/create-node-unicode-name.test.ts +126 -0
- package/src/create-node-validate.test.ts +199 -7
- package/src/create-node-validate.ts +232 -15
- package/src/create-node-workdir.test.ts +298 -0
- package/src/create-node.ts +88 -23
- package/src/daemon-provider-snapshots.test.ts +453 -0
- package/src/daemon-provider-snapshots.ts +327 -0
- package/src/daemon-token-owner-http.test.ts +346 -0
- package/src/dashboard-slash-routing-http.test.ts +109 -0
- package/src/db-adapter-guard.test.ts +148 -0
- package/src/db-adapter-translate.test.ts +128 -0
- package/src/db-adapter.ts +377 -91
- package/src/db-timestamp.test.ts +38 -0
- package/src/db-timestamp.ts +15 -0
- package/src/db.ts +1298 -153
- package/src/delivered-without-push.test.ts +140 -0
- package/src/department-groups-http.test.ts +209 -0
- package/src/department-groups-sync-http.test.ts +328 -0
- package/src/department-groups.ts +434 -0
- package/src/department-heads-http.test.ts +350 -0
- package/src/department-heads.ts +226 -0
- package/src/departments-agent-count.test.ts +139 -0
- package/src/departments-http.test.ts +185 -0
- package/src/departments-mcp-error-domain.test.ts +135 -0
- package/src/departments-mcp.test.ts +128 -0
- package/src/departments.ts +318 -0
- package/src/desktop-message-seam.test.ts +150 -0
- package/src/desktop-message.test.ts +368 -0
- package/src/dm-file-scope-http.test.ts +227 -0
- package/src/empty-node-sweeper.test.ts +104 -0
- package/src/empty-node-sweeper.ts +88 -0
- package/src/env-transport-gate-http.test.ts +240 -0
- package/src/env-transport-gate.ts +80 -0
- package/src/env-transport-policy.ts +56 -0
- package/src/etag-of.test.ts +57 -0
- package/src/event-loop-lag.test.ts +180 -0
- package/src/event-loop-lag.ts +201 -0
- package/src/expiry-counters.test.ts +187 -0
- package/src/expiry-counters.ts +227 -0
- package/src/expiry-evidence-db.test.ts +103 -0
- package/src/ext-token-shared.test.ts +60 -0
- package/src/ext-validation-regression.test.ts +10 -17
- package/src/external-schedule-edits-http.test.ts +321 -0
- package/src/external-schedule-edits-timestamps.test.ts +64 -0
- package/src/external-schedule-edits.ts +327 -0
- package/src/file-download-authz-dev-open.test.ts +1 -1
- package/src/file-download-authz.test.ts +25 -4
- package/src/file-download-date-bucket.test.ts +1 -1
- package/src/file-network-scope-dev-open.test.ts +1 -1
- package/src/file-network-scope.test.ts +7 -6
- package/src/group-membership-events-http.test.ts +264 -0
- package/src/group-messages-http.test.ts +483 -0
- package/src/group-messages.ts +297 -0
- package/src/health-anon-readers.ts +67 -0
- package/src/health-host-disk-2756.test.ts +71 -0
- package/src/health-identity-root.test.ts +98 -0
- package/src/health-redaction.test.ts +1599 -7
- package/src/health-status-reasons.test.ts +84 -0
- package/src/host-supervisor-identity-http.test.ts +152 -0
- package/src/host-supervisor-identity.ts +92 -0
- package/src/host-supervisors-daemon-version.test.ts +137 -0
- package/src/http-gzip.test.ts +94 -0
- package/src/http-gzip.ts +112 -0
- package/src/hub-catalog-read-http.test.ts +664 -0
- package/src/hub-provider-config.test.ts +166 -0
- package/src/hub-provider-config.ts +202 -0
- package/src/hub-timestamp.test.ts +38 -0
- package/src/hub-timestamp.ts +27 -0
- package/src/human-dm.ts +215 -0
- package/src/human-inbox.ts +42 -0
- package/src/inbox-caller.ts +49 -0
- package/src/inbox-count-sse.test.ts +318 -0
- package/src/inbox-count.ts +29 -0
- package/src/index.ts +6 -2
- package/src/license-state.test.ts +105 -0
- package/src/license-state.ts +48 -0
- package/src/lifecycle-error-domain.test.ts +149 -0
- package/src/list-ack-error-domain.test.ts +108 -0
- package/src/list-host-supervisors.test.ts +15 -4
- package/src/list-tasks-omit-default.test.ts +84 -0
- package/src/list-tasks-since-last.test.ts +100 -0
- package/src/list-tasks-since.test.ts +104 -0
- package/src/mcp-context-cost-http.test.ts +127 -0
- package/src/mcp-inflight.test.ts +92 -0
- package/src/mcp-inflight.ts +38 -0
- package/src/mcp-projects-events-http.test.ts +168 -0
- package/src/mcp-route-label-http.test.ts +120 -0
- package/src/mcp-write-network-resolution.test.ts +21 -0
- package/src/member-audit-network-id-http.test.ts +93 -0
- package/src/member-presence-http.test.ts +210 -0
- package/src/messages-ack-by-agent-http.test.ts +142 -0
- package/src/migrate-sqlite-to-pg.test.ts +47 -0
- package/src/migrate-sqlite-to-pg.ts +263 -0
- package/src/model-auth-notify-http.test.ts +181 -0
- package/src/model-auth-notify.ts +116 -0
- package/src/network-name-http.test.ts +75 -0
- package/src/network-quota-config.test.ts +100 -0
- package/src/network-rules-http.test.ts +169 -0
- package/src/network-rules.ts +129 -0
- package/src/network-scope.ts +222 -3
- package/src/network-token-membership-http.test.ts +186 -0
- package/src/node-alias-control.ts +12 -0
- package/src/node-attrs.test.ts +47 -2
- package/src/node-caller-identity-http.test.ts +1108 -0
- package/src/node-config-last-update.test.ts +126 -0
- package/src/node-config-last-update.ts +107 -0
- package/src/node-create-request-status-http.test.ts +105 -0
- package/src/node-daemon-bindings.test.ts +142 -0
- package/src/node-daemon-bindings.ts +135 -0
- package/src/node-failure-alert.test.ts +150 -0
- package/src/node-failure-alert.ts +177 -0
- package/src/node-files-transport.test.ts +350 -0
- package/src/node-health-codex-login.test.ts +120 -0
- package/src/node-health-dispatch-http.test.ts +373 -0
- package/src/node-health-guard-origin.test.ts +98 -0
- package/src/node-health-guard.ts +121 -0
- package/src/node-health-passthrough.test.ts +115 -0
- package/src/node-health-store.ts +101 -0
- package/src/node-id-alias.test.ts +190 -0
- package/src/node-identity-conflict-http.test.ts +269 -0
- package/src/node-identity-conflict.ts +142 -0
- package/src/node-identity-mismatch.test.ts +74 -0
- package/src/node-in-flight-tasks.ts +31 -0
- package/src/node-lifecycle-controllable.test.ts +64 -0
- package/src/node-lifecycle-controllable.ts +53 -0
- package/src/node-lifecycle-read-http.test.ts +257 -0
- package/src/node-lifecycle-read.ts +124 -0
- package/src/node-logs-transport.test.ts +266 -0
- package/src/node-peer-allowlist.test.ts +114 -0
- package/src/node-permissions-http.test.ts +901 -0
- package/src/node-permissions.ts +494 -0
- package/src/node-request-retention.test.ts +281 -0
- package/src/node-request-retention.ts +120 -0
- package/src/node-secret-rest-http.test.ts +190 -0
- package/src/node-secret-vault-inject.test.ts +132 -0
- package/src/node-security-write-gate.test.ts +72 -0
- package/src/node-serviceability.test.ts +86 -0
- package/src/node-serviceability.ts +124 -0
- package/src/node-session-control-http.test.ts +310 -0
- package/src/node-session-control.ts +258 -0
- package/src/node-skills-transport.test.ts +212 -0
- package/src/node-token-identity.ts +35 -0
- package/src/node-token-ownership.ts +51 -0
- package/src/node-token-privilege-http.test.ts +224 -0
- package/src/not-found-api-http.test.ts +67 -0
- package/src/observer-avatar-http.test.ts +103 -10
- package/src/observer-push.test.ts +76 -0
- package/src/opencode-catalog-report-http.test.ts +139 -0
- package/src/opencode-v2-catalog.test.ts +268 -0
- package/src/opencode-v2-catalog.ts +356 -0
- package/src/package-version-consistency.test.ts +25 -0
- package/src/parent-infer.test.ts +82 -0
- package/src/parent-infer.ts +110 -0
- package/src/parent-source-marker.test.ts +70 -0
- package/src/parent-source-orphan.test.ts +121 -0
- package/src/password-network-tokens.ts +25 -0
- package/src/peer-reply-atomic.test.ts +462 -0
- package/src/peer-reply-capability.test.ts +70 -0
- package/src/pg-worker.ts +87 -0
- package/src/poll-pacing.test.ts +74 -0
- package/src/poll-pacing.ts +123 -0
- package/src/probe-provider-error-domain.test.ts +145 -0
- package/src/project-dir-warn-clear-http.test.ts +132 -0
- package/src/project-viewer-can-http.test.ts +116 -0
- package/src/provider-skill-error-domain.test.ts +130 -0
- package/src/provider-tools-shape.test.ts +165 -0
- package/src/push.test.ts +20 -10
- package/src/push.ts +373 -9
- package/src/redact-tokens.test.ts +86 -0
- package/src/redact-tokens.ts +43 -0
- package/src/rejection-counters.test.ts +72 -0
- package/src/rejection-counters.ts +173 -0
- package/src/rename.ts +38 -10
- package/src/reply-target-derivation.test.ts +96 -0
- package/src/report-status-handover-capabilities-http.test.ts +124 -0
- package/src/report-status-host-schema.test.ts +235 -0
- package/src/report-status-resume-id-handover.test.ts +184 -0
- package/src/report-status-secret-keys.test.ts +140 -0
- package/src/require-explicit-test-db.ts +9 -0
- package/src/requirement-due-reminders-http.test.ts +620 -0
- package/src/requirement-due-reminders.ts +416 -0
- package/src/requirement-events-http.test.ts +318 -0
- package/src/requirement-events.test.ts +45 -0
- package/src/requirement-events.ts +144 -0
- package/src/requirement-notify.ts +165 -0
- package/src/requirement-participant-notify-http.test.ts +313 -0
- package/src/requirement-tag-ops-http.test.ts +454 -0
- package/src/requirement-tag-tree-http.test.ts +275 -0
- package/src/requirement-tag-tree.ts +127 -0
- package/src/requirement-tags.ts +102 -0
- package/src/requirements-abandoned-http.test.ts +236 -0
- package/src/requirements-assignee-drift.test.ts +154 -0
- package/src/requirements-comment-http.test.ts +174 -0
- package/src/requirements-completed-at-migration.test.ts +70 -0
- package/src/requirements-errors-mcp-http.test.ts +164 -0
- package/src/requirements-errors.ts +158 -0
- package/src/requirements-etag-http.test.ts +91 -0
- package/src/requirements-http.test.ts +709 -0
- package/src/requirements-last-event-http.test.ts +349 -0
- package/src/requirements-list-mcp-slim-http.test.ts +155 -0
- package/src/requirements-list-slim-http.test.ts +324 -0
- package/src/requirements-mcp.test.ts +180 -0
- package/src/requirements-migrate.ts +283 -0
- package/src/requirements-owner-strict-mcp-http.test.ts +145 -0
- package/src/requirements-people-http.test.ts +114 -0
- package/src/requirements-people-mcp-http.test.ts +231 -0
- package/src/requirements-people.ts +196 -0
- package/src/requirements-priority-lowest.test.ts +114 -0
- package/src/requirements-projects-network-echo.test.ts +57 -0
- package/src/requirements-projects-parent-http.test.ts +123 -0
- package/src/requirements-search-http.test.ts +182 -0
- package/src/requirements-search.test.ts +32 -0
- package/src/requirements-search.ts +145 -0
- package/src/requirements-seq-http.test.ts +193 -0
- package/src/requirements-seq-migration.test.ts +63 -0
- package/src/requirements-start-date.test.ts +125 -0
- package/src/requirements-stats-http.test.ts +357 -0
- package/src/requirements-stats.ts +195 -0
- package/src/requirements-status-participants-http.test.ts +222 -0
- package/src/requirements-upgrade-e2e.test.ts +126 -0
- package/src/requirements-upgrade-migration.test.ts +98 -0
- package/src/requirements.ts +2205 -0
- package/src/resolve-port.test.ts +57 -0
- package/src/resolve-port.ts +44 -0
- package/src/rest-alias-network-fallback-http.test.ts +123 -0
- package/src/rest-alias-network-fallback.test.ts +60 -0
- package/src/rest-alias-network-fallback.ts +65 -0
- package/src/rest-explicit-columns-http.test.ts +266 -0
- package/src/rest-identity.test.ts +130 -0
- package/src/rest-identity.ts +141 -0
- package/src/rest-projections.ts +72 -0
- package/src/rest-read-network-real-chain.test.ts +97 -0
- package/src/rest-write-network-resolution.test.ts +133 -0
- package/src/restart-readiness-http.test.ts +121 -0
- package/src/restricted-files.ts +76 -0
- package/src/retention-first-sweep-quiet.test.ts +31 -0
- package/src/retention.test.ts +100 -40
- package/src/retention.ts +423 -104
- package/src/route-callers-http.test.ts +120 -0
- package/src/route-timing.test.ts +218 -0
- package/src/route-timing.ts +262 -0
- package/src/rules-file-duplicate-alias.test.ts +234 -0
- package/src/rules-file-session-target.test.ts +207 -0
- package/src/rules-file-transport.test.ts +271 -0
- package/src/runtime-label.test.ts +22 -0
- package/src/runtime-label.ts +21 -0
- package/src/runtime-readiness.ts +90 -0
- package/src/schedule-agent-mcp-http.test.ts +486 -0
- package/src/schedule-agent.ts +252 -0
- package/src/schedule-starved.test.ts +92 -0
- package/src/schedule-starved.ts +114 -0
- package/src/scheduled-backoff-http.test.ts +203 -0
- package/src/scheduled-backoff.ts +64 -0
- package/src/scheduled-doorbell-nodeless-session.test.ts +134 -0
- package/src/scheduled-failure-backoff-2622.test.ts +145 -0
- package/src/scheduled-failure-code.test.ts +73 -0
- package/src/scheduled-failure-code.ts +105 -0
- package/src/scheduled-failures-http.test.ts +279 -0
- package/src/scheduled-failures.ts +425 -0
- package/src/scheduled-noprogress-backoff-2622.test.ts +163 -0
- package/src/scheduled-offline-backoff-probe.test.ts +56 -0
- package/src/scheduled-offline.test.ts +131 -0
- package/src/scheduled-offline.ts +66 -0
- package/src/scheduled-outcome-guidance-http.test.ts +139 -0
- package/src/scheduled-outcome-guidance.ts +9 -0
- package/src/scheduled-reply-unread-http.test.ts +212 -0
- package/src/scheduled-requirement-wake-http.test.ts +289 -0
- package/src/scheduled-requirement-wake.ts +125 -0
- package/src/scheduled-run-terminal.test.ts +290 -0
- package/src/scheduled-skip-blocking-task.test.ts +120 -0
- package/src/scheduled-skip-path-backoff-2622.test.ts +98 -0
- package/src/scheduled-stuck-http.test.ts +316 -0
- package/src/scheduled-stuck-notice-cap.test.ts +80 -0
- package/src/scheduled-stuck.ts +219 -0
- package/src/scheduled-tasks-http.test.ts +679 -0
- package/src/scheduled-tasks.ts +959 -0
- package/src/scheduled-work-outcome-http.test.ts +154 -0
- package/src/scheduled-work-outcome.ts +50 -0
- package/src/scoped-secrets.ts +167 -0
- package/src/secret-echo-negative-control.test.ts +118 -0
- package/src/send-dedup-request-id.test.ts +229 -0
- package/src/send-reply-agent-warning.test.ts +38 -38
- package/src/send-reply-alias-optional.test.ts +131 -0
- package/src/send-reply-attachments.test.ts +28 -7
- package/src/send_dedup.test.ts +54 -0
- package/src/send_dedup.ts +52 -6
- package/src/serve-error.test.ts +73 -0
- package/src/serve-error.ts +56 -0
- package/src/server.ts +4930 -377
- package/src/session-task-on-dispatch.ts +14 -0
- package/src/session-token-ownership-http.test.ts +122 -0
- package/src/shared/codex-inventory.ts +41 -0
- package/src/shared/daemon-provider-login.ts +31 -0
- package/src/shared/daemon-provider-snapshot.ts +52 -0
- package/src/shared/external-schedule-contract.ts +60 -0
- package/src/shared/node-name.test.ts +62 -0
- package/src/shared/node-name.ts +161 -0
- package/src/shared/probe-host-allowlist-drift.test.ts +45 -0
- package/src/shared/provider-application.ts +29 -0
- package/src/shared/provider-collection.ts +14 -0
- package/src/shared/provider-initialization.ts +8 -0
- package/src/shared/reserved-env-drift.test.ts +10 -0
- package/src/shared/scoped-secret-contract.ts +5 -0
- package/src/shared/task-content-limit-drift.test.ts +28 -0
- package/src/shared/task-content-limit.ts +25 -0
- package/src/side-thread-command-transport.test.ts +312 -0
- package/src/side-thread-command-transport.ts +318 -0
- package/src/side-thread-http-integration.test.ts +233 -0
- package/src/side-thread-http.ts +504 -0
- package/src/side-thread-production.test.ts +72 -0
- package/src/side-thread-production.ts +118 -0
- package/src/side-thread.test.ts +1067 -0
- package/src/side-thread.ts +2499 -0
- package/src/skillhub-http.test.ts +144 -0
- package/src/sqlite-close-checkpoint.test.ts +78 -0
- package/src/start-node.test.ts +265 -0
- package/src/start-request-error-domain.test.ts +182 -0
- package/src/start-skill-error-domain.test.ts +122 -0
- package/src/stats-versions-http.test.ts +65 -0
- package/src/status-alias-filter-http.test.ts +106 -0
- package/src/status-alias-resolver-http.test.ts +163 -0
- package/src/status-alias-resolver.ts +19 -0
- package/src/status-node-id-filter-http.test.ts +161 -0
- package/src/status-read-cache-http.test.ts +229 -0
- package/src/status-read-cache.ts +129 -0
- package/src/stop-delete-node.test.ts +567 -1
- package/src/task-access-http.test.ts +407 -0
- package/src/task-access.ts +420 -0
- package/src/task-activity.ts +60 -0
- package/src/task-auth-origin-http.test.ts +93 -0
- package/src/task-auth-origin.test.ts +24 -0
- package/src/task-auth-origin.ts +7 -0
- package/src/task-consumption.test.ts +508 -0
- package/src/task-diagnostic-http.test.ts +149 -0
- package/src/task-diagnostic.test.ts +115 -0
- package/src/task-diagnostic.ts +118 -0
- package/src/task-expiry-notice-http.test.ts +298 -0
- package/src/task-expiry-notice.ts +318 -0
- package/src/task-idempotency-mcp.test.ts +148 -0
- package/src/task-idempotency.test.ts +76 -0
- package/src/task-idempotency.ts +81 -0
- package/src/task-late-replies.ts +54 -0
- package/src/task-late-reply-http.test.ts +227 -0
- package/src/task-lifecycle-watcher-busy.test.ts +114 -0
- package/src/task-lifecycle-watcher.test.ts +209 -0
- package/src/task-lifecycle-watcher.ts +109 -0
- package/src/task-network-resolution-http.test.ts +140 -0
- package/src/task-not-found-error-domain.test.ts +114 -0
- package/src/task-offline-delivery-2668.test.ts +119 -0
- package/src/task-offline-delivery.ts +81 -0
- package/src/task-orphan-http.test.ts +287 -0
- package/src/task-orphan.ts +119 -0
- package/src/task-queue-ahead-http.test.ts +309 -0
- package/src/task-queue-ahead-scale.test.ts +236 -0
- package/src/task-queue-ahead.ts +186 -0
- package/src/task-rejection-log-http.test.ts +160 -0
- package/src/task-rejection-log.ts +61 -0
- package/src/task-sender-http.test.ts +143 -0
- package/src/task-stale-open-http.test.ts +292 -0
- package/src/task-stale-open.ts +103 -0
- package/src/tasks-pagination-http.test.ts +141 -0
- package/src/team-rules-status-http.test.ts +90 -0
- package/src/team-rules-status.test.ts +59 -0
- package/src/team-rules-status.ts +72 -0
- package/src/tmux-allowlist.test.ts +48 -0
- package/src/tool-audience-http.test.ts +248 -0
- package/src/tool-audience.ts +127 -0
- package/src/tools-list-json-schema.test.ts +94 -0
- package/src/tools.ts +4314 -392
- package/src/update-node-config-error-domain.test.ts +107 -0
- package/src/uploads-http.test.ts +6 -4
- package/src/uploads.ts +23 -4
- package/src/user-avatar-http.test.ts +74 -0
- package/src/user-avatar-image.ts +160 -0
- package/src/user-avatar-migration.test.ts +25 -0
- package/src/user-avatar-upload-http.test.ts +353 -0
- package/src/user-inbox-by-agent-http.test.ts +189 -0
- package/src/user-inbox-netid-notnull.test.ts +122 -0
- package/src/user-inbox-read-http.test.ts +223 -0
- package/src/user-inbox-schema.test.ts +54 -0
- package/src/version-stats.test.ts +66 -0
- package/src/version-stats.ts +109 -0
|
@@ -0,0 +1,229 @@
|
|
|
1
|
+
// Handler-level regression for the #212 dedup window swallowing human chat
|
|
2
|
+
// messages (see send_dedup.ts header, "Key selection").
|
|
3
|
+
//
|
|
4
|
+
// Before the fix, POST /api/task keyed the dedup window on
|
|
5
|
+
// (from, to, sha256(content)) only and ignored meta.client_request_id, so a
|
|
6
|
+
// user sending the same short text twice within 5 minutes got 200/429/429 and
|
|
7
|
+
// ONE stored row — and the app maps that 429 to "delivered". The table below
|
|
8
|
+
// is the repro, run against both transports:
|
|
9
|
+
//
|
|
10
|
+
// case | before (REST) | after
|
|
11
|
+
// ----------------------------------+---------------+-------------------------
|
|
12
|
+
// same text, 3 different ids | 1 row | 3 rows, 3 x ok
|
|
13
|
+
// same text, same id (retry) | 1 row | 1 row, 2 x replay (same id)
|
|
14
|
+
// different text, same id | 3 rows | 1 row, 2 x idempotency_conflict
|
|
15
|
+
// same text, no id (#212 agents) | 1 row | 1 row, 2 x duplicate_send
|
|
16
|
+
import { afterAll, beforeAll, beforeEach, describe, expect, test } from "bun:test";
|
|
17
|
+
import { mkdtempSync, rmSync } from "fs";
|
|
18
|
+
import { join } from "path";
|
|
19
|
+
import { tmpdir } from "os";
|
|
20
|
+
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
|
|
21
|
+
import { register } from "./auth.js";
|
|
22
|
+
import { db } from "./db.js";
|
|
23
|
+
import { registerTools } from "./tools.js";
|
|
24
|
+
import { sharedSendDedup } from "./send_dedup.js";
|
|
25
|
+
|
|
26
|
+
const PRIVATE_DB_DIR = mkdtempSync(join(tmpdir(), "anet-send-dedup-rid-"));
|
|
27
|
+
const TARGET = `dedup-rid-target-${process.pid}`;
|
|
28
|
+
const TARGET_NODE_ID = `node_dedup_rid_${process.pid}`;
|
|
29
|
+
|
|
30
|
+
let server: any;
|
|
31
|
+
let base = "";
|
|
32
|
+
let userToken = "";
|
|
33
|
+
let restNet = "";
|
|
34
|
+
let restUser = "";
|
|
35
|
+
|
|
36
|
+
const MCP_NET = `net_dedup_rid_${process.pid}`;
|
|
37
|
+
const MCP_USER = `user_dedup_rid_${process.pid}`;
|
|
38
|
+
|
|
39
|
+
function rid(n: number): string {
|
|
40
|
+
// App shape: dreq_ + 32 lowercase hex.
|
|
41
|
+
return `dreq_${n.toString(16).padStart(32, "0")}`;
|
|
42
|
+
}
|
|
43
|
+
|
|
44
|
+
function seedTarget(networkId: string, suffix: string) {
|
|
45
|
+
db.run(
|
|
46
|
+
`INSERT INTO sessions (resume_id, alias, status, node_id, network_id, updated_at, last_seen_at)
|
|
47
|
+
VALUES (?1, ?2, 'idle', ?3, ?4, datetime('now'), datetime('now'))`,
|
|
48
|
+
[`resume_${TARGET_NODE_ID}_${suffix}`, TARGET, `${TARGET_NODE_ID}_${suffix}`, networkId],
|
|
49
|
+
);
|
|
50
|
+
db.run(
|
|
51
|
+
`INSERT INTO nodes (node_id, node_name, alias, network_id, created_at, updated_at, lifecycle_state)
|
|
52
|
+
VALUES (?1, ?2, ?2, ?3, datetime('now'), datetime('now'), 'active')`,
|
|
53
|
+
[`${TARGET_NODE_ID}_${suffix}`, TARGET, networkId],
|
|
54
|
+
);
|
|
55
|
+
}
|
|
56
|
+
|
|
57
|
+
beforeAll(async () => {
|
|
58
|
+
process.env.COMMHUB_DB = process.env.COMMHUB_DB || join(PRIVATE_DB_DIR, "hub.db");
|
|
59
|
+
restUser = `dedup_rid_${Date.now()}`;
|
|
60
|
+
const registered = register(restUser, "DedupRid123!", undefined, "seed");
|
|
61
|
+
expect(registered.ok).toBe(true);
|
|
62
|
+
userToken = registered.token!;
|
|
63
|
+
restNet = registered.network_id!;
|
|
64
|
+
seedTarget(restNet, "rest");
|
|
65
|
+
|
|
66
|
+
db.run("INSERT INTO users (user_id, username, password_hash, role, created_at) VALUES (?1, ?1, 'x', 'user', datetime('now'))", [MCP_USER]);
|
|
67
|
+
db.run("INSERT INTO networks (network_id, network_name, owner_id, created_at) VALUES (?1, ?1, ?2, datetime('now'))", [MCP_NET, MCP_USER]);
|
|
68
|
+
db.run("INSERT INTO network_members (user_id, network_id, role, joined_at) VALUES (?1, ?2, 'owner', datetime('now'))", [MCP_USER, MCP_NET]);
|
|
69
|
+
seedTarget(MCP_NET, "mcp");
|
|
70
|
+
|
|
71
|
+
const mod: any = await import("./server.js");
|
|
72
|
+
server = mod.bootServer({ port: 0, hostname: "127.0.0.1" });
|
|
73
|
+
base = `http://127.0.0.1:${server.port}`;
|
|
74
|
+
}, 30_000);
|
|
75
|
+
|
|
76
|
+
afterAll(() => {
|
|
77
|
+
try { server?.stop?.(true); } catch {}
|
|
78
|
+
try { rmSync(PRIVATE_DB_DIR, { recursive: true, force: true }); } catch {}
|
|
79
|
+
});
|
|
80
|
+
|
|
81
|
+
beforeEach(() => {
|
|
82
|
+
for (const net of [restNet, MCP_NET]) {
|
|
83
|
+
if (!net) continue;
|
|
84
|
+
for (const table of ["tasks", "inbox", "task_events"]) {
|
|
85
|
+
try { db.run(`DELETE FROM ${table} WHERE network_id = ?1`, [net]); } catch {}
|
|
86
|
+
}
|
|
87
|
+
}
|
|
88
|
+
sharedSendDedup.clear();
|
|
89
|
+
});
|
|
90
|
+
|
|
91
|
+
function rowCount(networkId: string): number {
|
|
92
|
+
return db.get<{ n: number }>("SELECT COUNT(*) AS n FROM tasks WHERE network_id = ?1", [networkId])!.n;
|
|
93
|
+
}
|
|
94
|
+
function inboxCount(networkId: string): number {
|
|
95
|
+
return db.get<{ n: number }>("SELECT COUNT(*) AS n FROM inbox WHERE network_id = ?1", [networkId])!.n;
|
|
96
|
+
}
|
|
97
|
+
|
|
98
|
+
// ── REST ────────────────────────────────────────────────────────────────
|
|
99
|
+
|
|
100
|
+
async function rest(task: string, requestId?: string): Promise<{ status: number; body: any }> {
|
|
101
|
+
const res = await fetch(`${base}/api/task`, {
|
|
102
|
+
method: "POST",
|
|
103
|
+
headers: { Authorization: `Bearer ${userToken}`, "Content-Type": "application/json" },
|
|
104
|
+
body: JSON.stringify({
|
|
105
|
+
alias: TARGET,
|
|
106
|
+
task,
|
|
107
|
+
priority: "normal",
|
|
108
|
+
network_id: restNet,
|
|
109
|
+
from: restUser,
|
|
110
|
+
meta: requestId
|
|
111
|
+
? { source: "dashboard-chat", client_request_id: requestId }
|
|
112
|
+
: { source: "dashboard-chat" },
|
|
113
|
+
}),
|
|
114
|
+
});
|
|
115
|
+
return { status: res.status, body: await res.json() };
|
|
116
|
+
}
|
|
117
|
+
|
|
118
|
+
describe("POST /api/task dedup key selection", () => {
|
|
119
|
+
test("same text with 3 different request ids -> 3 rows (the reported data loss)", async () => {
|
|
120
|
+
const results = [await rest("好", rid(1)), await rest("好", rid(2)), await rest("好", rid(3))];
|
|
121
|
+
expect(results.map((r) => r.status)).toEqual([200, 200, 200]);
|
|
122
|
+
const ids = results.map((r) => r.body.task_id);
|
|
123
|
+
expect(new Set(ids).size).toBe(3);
|
|
124
|
+
expect(rowCount(restNet)).toBe(3);
|
|
125
|
+
expect(inboxCount(restNet)).toBe(3);
|
|
126
|
+
});
|
|
127
|
+
|
|
128
|
+
test("same text with the same request id -> 1 row, retries replay the same task id", async () => {
|
|
129
|
+
const first = await rest("好", rid(7));
|
|
130
|
+
const second = await rest("好", rid(7));
|
|
131
|
+
const third = await rest("好", rid(7));
|
|
132
|
+
expect(first.status).toBe(200);
|
|
133
|
+
expect(second.status).toBe(200);
|
|
134
|
+
expect(third.status).toBe(200);
|
|
135
|
+
expect(second.body).toMatchObject({ ok: true, task_id: first.body.task_id, message_id: first.body.task_id, idempotent_replay: true });
|
|
136
|
+
expect(third.body.task_id).toBe(first.body.task_id);
|
|
137
|
+
expect(rowCount(restNet)).toBe(1);
|
|
138
|
+
expect(inboxCount(restNet)).toBe(1);
|
|
139
|
+
});
|
|
140
|
+
|
|
141
|
+
test("different text with the same request id -> 1 row, reuse fails closed (409)", async () => {
|
|
142
|
+
const first = await rest("第一条", rid(9));
|
|
143
|
+
const second = await rest("第二条", rid(9));
|
|
144
|
+
const third = await rest("第三条", rid(9));
|
|
145
|
+
expect(first.status).toBe(200);
|
|
146
|
+
expect(second.status).toBe(409);
|
|
147
|
+
expect(second.body.error).toBe("idempotency_conflict");
|
|
148
|
+
expect(third.status).toBe(409);
|
|
149
|
+
expect(rowCount(restNet)).toBe(1);
|
|
150
|
+
});
|
|
151
|
+
|
|
152
|
+
test("#212 guard: same text WITHOUT a request id is still deduped (429 duplicate_send)", async () => {
|
|
153
|
+
const results = [await rest("继续"), await rest("继续"), await rest("继续")];
|
|
154
|
+
expect(results.map((r) => r.status)).toEqual([200, 429, 429]);
|
|
155
|
+
expect(results[1].body.error).toBe("duplicate_send");
|
|
156
|
+
expect(rowCount(restNet)).toBe(1);
|
|
157
|
+
});
|
|
158
|
+
|
|
159
|
+
test("no request id, different text -> each goes through", async () => {
|
|
160
|
+
const results = [await rest("a"), await rest("b"), await rest("c")];
|
|
161
|
+
expect(results.map((r) => r.status)).toEqual([200, 200, 200]);
|
|
162
|
+
expect(rowCount(restNet)).toBe(3);
|
|
163
|
+
});
|
|
164
|
+
});
|
|
165
|
+
|
|
166
|
+
// ── MCP send_task ──────────────────────────────────────────────────────
|
|
167
|
+
|
|
168
|
+
type ToolHandler = (args: any) => Promise<{ content: Array<{ type: "text"; text: string }> }>;
|
|
169
|
+
|
|
170
|
+
function mcpSendTask(): ToolHandler {
|
|
171
|
+
const mcp = new McpServer({ name: "dedup-rid-test", version: "0" }) as any;
|
|
172
|
+
let handler: ToolHandler | undefined;
|
|
173
|
+
const original = mcp.tool.bind(mcp);
|
|
174
|
+
mcp.tool = (name: string, description: string, schema: any, candidate: ToolHandler) => {
|
|
175
|
+
if (name === "send_task") handler = candidate;
|
|
176
|
+
return original(name, description, schema, candidate);
|
|
177
|
+
};
|
|
178
|
+
registerTools(mcp, undefined, MCP_NET, MCP_USER, MCP_USER, false, null);
|
|
179
|
+
if (!handler) throw new Error("send_task handler missing");
|
|
180
|
+
return handler;
|
|
181
|
+
}
|
|
182
|
+
|
|
183
|
+
async function mcp(handler: ToolHandler, task: string, requestId?: string): Promise<any> {
|
|
184
|
+
const result = await handler({
|
|
185
|
+
alias: TARGET,
|
|
186
|
+
task,
|
|
187
|
+
priority: "normal",
|
|
188
|
+
...(requestId ? { meta: { source: "dashboard-chat", client_request_id: requestId } } : {}),
|
|
189
|
+
});
|
|
190
|
+
return JSON.parse(result.content[0].text);
|
|
191
|
+
}
|
|
192
|
+
|
|
193
|
+
describe("MCP send_task dedup key selection", () => {
|
|
194
|
+
test("same text with 3 different request ids -> 3 rows", async () => {
|
|
195
|
+
const h = mcpSendTask();
|
|
196
|
+
const results = [await mcp(h, "好", rid(11)), await mcp(h, "好", rid(12)), await mcp(h, "好", rid(13))];
|
|
197
|
+
expect(results.map((r) => r.ok)).toEqual([true, true, true]);
|
|
198
|
+
expect(new Set(results.map((r) => r.message_id)).size).toBe(3);
|
|
199
|
+
expect(rowCount(MCP_NET)).toBe(3);
|
|
200
|
+
});
|
|
201
|
+
|
|
202
|
+
test("same text with the same request id -> 1 row, replay returns the same task id", async () => {
|
|
203
|
+
const h = mcpSendTask();
|
|
204
|
+
const first = await mcp(h, "好", rid(17));
|
|
205
|
+
const second = await mcp(h, "好", rid(17));
|
|
206
|
+
const third = await mcp(h, "好", rid(17));
|
|
207
|
+
expect(first.ok).toBe(true);
|
|
208
|
+
expect(second).toMatchObject({ ok: true, task_id: first.message_id, idempotent_replay: true });
|
|
209
|
+
expect(third.task_id).toBe(first.message_id);
|
|
210
|
+
expect(rowCount(MCP_NET)).toBe(1);
|
|
211
|
+
});
|
|
212
|
+
|
|
213
|
+
test("different text with the same request id -> 1 row, idempotency_conflict", async () => {
|
|
214
|
+
const h = mcpSendTask();
|
|
215
|
+
expect((await mcp(h, "第一条", rid(19))).ok).toBe(true);
|
|
216
|
+
expect((await mcp(h, "第二条", rid(19))).error).toBe("idempotency_conflict");
|
|
217
|
+
expect((await mcp(h, "第三条", rid(19))).error).toBe("idempotency_conflict");
|
|
218
|
+
expect(rowCount(MCP_NET)).toBe(1);
|
|
219
|
+
});
|
|
220
|
+
|
|
221
|
+
test("#212 guard: same text WITHOUT a request id is still deduped", async () => {
|
|
222
|
+
const h = mcpSendTask();
|
|
223
|
+
const results = [await mcp(h, "继续"), await mcp(h, "继续"), await mcp(h, "继续")];
|
|
224
|
+
expect(results[0].ok).toBe(true);
|
|
225
|
+
expect(results[1].error).toBe("duplicate_send");
|
|
226
|
+
expect(results[2].error).toBe("duplicate_send");
|
|
227
|
+
expect(rowCount(MCP_NET)).toBe(1);
|
|
228
|
+
});
|
|
229
|
+
});
|
|
@@ -3,25 +3,17 @@ import { db } from "./db.js";
|
|
|
3
3
|
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
|
|
4
4
|
import { registerTools } from "./tools.js";
|
|
5
5
|
|
|
6
|
-
// #498
|
|
7
|
-
//
|
|
8
|
-
//
|
|
9
|
-
//
|
|
10
|
-
//
|
|
11
|
-
// Why this test exists (通信龙 2026-07-30 裁定): the warning is a pure
|
|
12
|
-
// hint — deleting it doesn't break any behavior, so it's exactly the
|
|
13
|
-
// kind of code a future refactor drops silently. This test is the
|
|
14
|
-
// tripwire: if the branch goes away, this test turns red.
|
|
15
|
-
//
|
|
16
|
-
// witnessed-red methodology (`feedback_witnessed_red_before_witnessed_green`):
|
|
17
|
-
// I confirmed both assertions fail cleanly when the `warning` branch is
|
|
18
|
-
// reverted (see docs/tests/p-498-reply-warning/witnessed-red.txt), so
|
|
19
|
-
// this suite genuinely catches regressions rather than green-when-empty.
|
|
6
|
+
// #498 compatibility warning remains load-bearing during the mixed-version
|
|
7
|
+
// rollout. Capability-negotiated agents use send_peer_reply; old send_reply
|
|
8
|
+
// callers targeting an agent get explicit migration guidance while Dashboard
|
|
9
|
+
// targets stay quiet.
|
|
20
10
|
|
|
21
11
|
const NET_ID = "net_498_warn";
|
|
22
12
|
const USER_ID = "u_498_warn";
|
|
23
13
|
const NODE_ID = "node_498_warn";
|
|
24
14
|
const AGENT_ALIAS = "peer-agent-498";
|
|
15
|
+
const DISPATCHER_NODE_ID = "node_498_dispatcher";
|
|
16
|
+
const DISPATCHER_ALIAS = "dispatcher";
|
|
25
17
|
const AGENT_TOK_ID = "tok_498_warn";
|
|
26
18
|
|
|
27
19
|
interface ToolHandler {
|
|
@@ -57,11 +49,21 @@ function seed() {
|
|
|
57
49
|
VALUES (?1, ?2, 'x', 'user', datetime('now'))`,
|
|
58
50
|
[USER_ID, USER_ID],
|
|
59
51
|
);
|
|
52
|
+
db.run(
|
|
53
|
+
`INSERT INTO nodes (node_id, node_name, alias, network_id, hostname, created_at, updated_at, lifecycle_state)
|
|
54
|
+
VALUES (?1, ?2, ?3, ?4, ?5, datetime('now'), datetime('now'), 'active')`,
|
|
55
|
+
[DISPATCHER_NODE_ID, DISPATCHER_ALIAS, DISPATCHER_ALIAS, NET_ID, `host-${DISPATCHER_ALIAS}`],
|
|
56
|
+
);
|
|
60
57
|
db.run(
|
|
61
58
|
`INSERT INTO networks (network_id, network_name, owner_id, created_at)
|
|
62
59
|
VALUES (?1, ?2, ?3, datetime('now'))`,
|
|
63
60
|
[NET_ID, NET_ID, USER_ID],
|
|
64
61
|
);
|
|
62
|
+
db.run(
|
|
63
|
+
`INSERT INTO sessions (resume_id, alias, status, node_id, network_id, updated_at, last_seen_at)
|
|
64
|
+
VALUES (?1, ?2, 'idle', ?3, ?4, datetime('now'), datetime('now'))`,
|
|
65
|
+
[`res_${DISPATCHER_ALIAS}`, DISPATCHER_ALIAS, DISPATCHER_NODE_ID, NET_ID],
|
|
66
|
+
);
|
|
65
67
|
db.run(
|
|
66
68
|
`INSERT INTO network_members (user_id, network_id, role, joined_at)
|
|
67
69
|
VALUES (?1, ?2, 'owner', datetime('now'))`,
|
|
@@ -84,12 +86,12 @@ function seed() {
|
|
|
84
86
|
);
|
|
85
87
|
}
|
|
86
88
|
|
|
87
|
-
function makeTask(
|
|
89
|
+
function makeTask(from: string): string {
|
|
88
90
|
const id = "t_" + Math.random().toString(36).slice(2, 14);
|
|
89
91
|
db.run(
|
|
90
|
-
`INSERT INTO tasks (task_id, from_name, to_name, priority, status, content, requires_response, created_at, network_id)
|
|
91
|
-
VALUES (?1, ?2, ?3, 'normal', 'delivered', 'test', 'reply', datetime('now'), ?
|
|
92
|
-
[id,
|
|
92
|
+
`INSERT INTO tasks (task_id, from_name, to_name, to_node_id, priority, status, content, requires_response, created_at, network_id)
|
|
93
|
+
VALUES (?1, ?2, ?3, ?4, 'normal', 'delivered', 'test', 'reply', datetime('now'), ?5)`,
|
|
94
|
+
[id, from, AGENT_ALIAS, NODE_ID, NET_ID],
|
|
93
95
|
);
|
|
94
96
|
return id;
|
|
95
97
|
}
|
|
@@ -127,38 +129,36 @@ async function call(handler: ToolHandler, args: any): Promise<Reply> {
|
|
|
127
129
|
return JSON.parse(r.content[0].text) as Reply;
|
|
128
130
|
}
|
|
129
131
|
|
|
130
|
-
describe("send_reply
|
|
131
|
-
test("
|
|
132
|
+
describe("send_reply legacy/Dashboard compatibility (#698)", () => {
|
|
133
|
+
test("legacy call still closes the original and enqueues one no-response result", async () => {
|
|
132
134
|
seed();
|
|
133
135
|
const tools = buildHandlers();
|
|
134
136
|
const sendReply = tools["send_reply"];
|
|
135
137
|
expect(sendReply).toBeDefined();
|
|
136
138
|
|
|
137
|
-
const taskId = makeTask(
|
|
139
|
+
const taskId = makeTask(DISPATCHER_ALIAS);
|
|
138
140
|
const reply = await call(sendReply, {
|
|
139
|
-
alias:
|
|
140
|
-
text: "peer reply (
|
|
141
|
+
alias: DISPATCHER_ALIAS,
|
|
142
|
+
text: "peer reply (atomic)",
|
|
141
143
|
in_reply_to: taskId,
|
|
142
144
|
status: "replied",
|
|
143
145
|
from_session: AGENT_ALIAS,
|
|
144
146
|
});
|
|
145
147
|
|
|
146
148
|
expect(reply.ok).toBe(true);
|
|
147
|
-
expect(reply.warning).
|
|
148
|
-
expect(
|
|
149
|
-
|
|
150
|
-
|
|
151
|
-
|
|
152
|
-
|
|
153
|
-
|
|
154
|
-
|
|
155
|
-
|
|
156
|
-
|
|
157
|
-
expect(
|
|
158
|
-
|
|
159
|
-
|
|
160
|
-
expect(w).toContain("RFC-030");
|
|
161
|
-
expect(w).toContain("全网规则");
|
|
149
|
+
expect(reply.warning).toContain("commhub_send_peer_reply");
|
|
150
|
+
expect(reply.warning).toContain("terminalized the original task");
|
|
151
|
+
expect(reply.warning).not.toContain("commhub_send_task");
|
|
152
|
+
expect(reply.warning).toContain("mixed-version");
|
|
153
|
+
expect(db.get<{ status: string; result: string }>(
|
|
154
|
+
"SELECT status, result FROM tasks WHERE task_id = ?1", taskId,
|
|
155
|
+
)).toEqual(expect.objectContaining({ status: "replied", result: "peer reply (atomic)" }));
|
|
156
|
+
expect(db.all<{ type: string; requires_response: string; session_name: string }>(
|
|
157
|
+
"SELECT type, requires_response, session_name FROM inbox WHERE in_reply_to = ?1", taskId,
|
|
158
|
+
)).toEqual([{ type: "reply", requires_response: "none", session_name: DISPATCHER_ALIAS }]);
|
|
159
|
+
expect(db.get<{ n: number }>(
|
|
160
|
+
"SELECT COUNT(*) AS n FROM tasks WHERE parent_task_id = ?1", taskId,
|
|
161
|
+
)?.n).toBe(0);
|
|
162
162
|
});
|
|
163
163
|
|
|
164
164
|
test("target alias is `hub` (Dashboard path) → NO warning field", async () => {
|
|
@@ -0,0 +1,131 @@
|
|
|
1
|
+
// #1085 — send_reply must not require `alias` when `in_reply_to` is set.
|
|
2
|
+
//
|
|
3
|
+
// Symptom (deployed SDK-runtime nodes): `mcp__commhub__send_reply(task_id,
|
|
4
|
+
// text)` → `-32602 Invalid input: expected string, received undefined at
|
|
5
|
+
// alias`. That is the HUB's Zod schema rejecting a required `alias` the
|
|
6
|
+
// client never sent — the request dies before the handler runs, so the
|
|
7
|
+
// original task is never terminalized and its inbox row stays unacked
|
|
8
|
+
// (pending inflation).
|
|
9
|
+
//
|
|
10
|
+
// Fix (two parts, both in tools.ts):
|
|
11
|
+
// 1. `replyToolSchema.alias` → optional (stops the MCP-layer Zod -32602).
|
|
12
|
+
// 2. `handleReply` derives the target from the in_reply_to task's
|
|
13
|
+
// `from_name` when alias is omitted — the target was always knowable
|
|
14
|
+
// from the task the hub already looks up, so the param was redundant.
|
|
15
|
+
//
|
|
16
|
+
// This suite drives the registered handler directly (MCP Zod layer is
|
|
17
|
+
// exercised separately by the framework), so it pins part (2): omit alias
|
|
18
|
+
// → derive → reply lands on the original sender; omit both → clean error.
|
|
19
|
+
//
|
|
20
|
+
// 改坏报红 gate: revert the derive block (require alias again) and
|
|
21
|
+
// "alias omitted → derives to original sender" flips to a resolve failure.
|
|
22
|
+
|
|
23
|
+
import { afterAll, beforeEach, describe, expect, test } from "bun:test";
|
|
24
|
+
import { db } from "./db.js";
|
|
25
|
+
import { McpServer } from "@modelcontextprotocol/sdk/server/mcp.js";
|
|
26
|
+
import { registerTools } from "./tools.js";
|
|
27
|
+
|
|
28
|
+
const NET_ID = "net_1085";
|
|
29
|
+
const USER_ID = "u_1085";
|
|
30
|
+
const NODE_ID = "node_1085";
|
|
31
|
+
const AGENT_ALIAS = "worker-1085";
|
|
32
|
+
const ORIGIN_ALIAS = "boss-1085"; // the task's from_name — the derive target
|
|
33
|
+
const AGENT_TOK_ID = "tok_1085";
|
|
34
|
+
|
|
35
|
+
interface ToolHandler {
|
|
36
|
+
(args: any, extra?: any): Promise<{ content: Array<{ type: "text"; text: string }> }>;
|
|
37
|
+
}
|
|
38
|
+
interface Reply { ok?: boolean; message_id?: string; error?: string; message?: string; [k: string]: unknown; }
|
|
39
|
+
|
|
40
|
+
function cleanup() {
|
|
41
|
+
for (const t of ["tasks", "inbox", "task_events", "sessions", "nodes", "api_tokens", "network_members", "networks"]) {
|
|
42
|
+
try { db.run(`DELETE FROM ${t} WHERE network_id = ?1`, [NET_ID]); } catch {}
|
|
43
|
+
}
|
|
44
|
+
try { db.run("DELETE FROM users WHERE user_id = ?1", [USER_ID]); } catch {}
|
|
45
|
+
}
|
|
46
|
+
beforeEach(cleanup);
|
|
47
|
+
afterAll(cleanup);
|
|
48
|
+
|
|
49
|
+
function seed(): { taskId: string } {
|
|
50
|
+
db.run(`INSERT INTO users (user_id, username, password_hash, role, created_at) VALUES (?1, ?2, 'x', 'user', datetime('now'))`, [USER_ID, USER_ID]);
|
|
51
|
+
db.run(`INSERT INTO networks (network_id, network_name, owner_id, created_at) VALUES (?1, ?2, ?3, datetime('now'))`, [NET_ID, NET_ID, USER_ID]);
|
|
52
|
+
db.run(`INSERT INTO network_members (user_id, network_id, role, joined_at) VALUES (?1, ?2, 'owner', datetime('now'))`, [USER_ID, NET_ID]);
|
|
53
|
+
db.run(`INSERT INTO nodes (node_id, node_name, alias, network_id, hostname, created_at, updated_at, lifecycle_state) VALUES (?1, ?2, ?3, ?4, ?5, datetime('now'), datetime('now'), 'active')`, [NODE_ID, AGENT_ALIAS, AGENT_ALIAS, NET_ID, `host-${AGENT_ALIAS}`]);
|
|
54
|
+
db.run(`INSERT INTO sessions (resume_id, alias, status, node_id, network_id, updated_at, last_seen_at) VALUES (?1, ?2, 'idle', ?3, ?4, datetime('now'), datetime('now'))`, [`res_${AGENT_ALIAS}`, AGENT_ALIAS, NODE_ID, NET_ID]);
|
|
55
|
+
// The reply TARGET session (the task originator). Its alias is what the
|
|
56
|
+
// handler must derive from the task's from_name.
|
|
57
|
+
db.run(`INSERT INTO sessions (resume_id, alias, status, network_id, updated_at, last_seen_at) VALUES (?1, ?2, 'idle', ?3, datetime('now'), datetime('now'))`, [`res_${ORIGIN_ALIAS}`, ORIGIN_ALIAS, NET_ID]);
|
|
58
|
+
// A task from ORIGIN_ALIAS → the worker. Replying to it should land on
|
|
59
|
+
// ORIGIN_ALIAS even when the caller omits alias.
|
|
60
|
+
const taskId = `task_1085_${Date.now()}${Math.floor(Math.random() * 1000)}`;
|
|
61
|
+
db.run(`INSERT INTO tasks (task_id, from_name, to_name, status, content, requires_response, created_at, delivered_at, expires_at, network_id, priority) VALUES (?1, ?2, ?3, 'delivered', 'do the thing', 'reply', datetime('now'), datetime('now'), datetime('now', '+1 hour'), ?4, 'normal')`, [taskId, ORIGIN_ALIAS, AGENT_ALIAS, NET_ID]);
|
|
62
|
+
return { taskId };
|
|
63
|
+
}
|
|
64
|
+
|
|
65
|
+
async function getHandler(): Promise<ToolHandler> {
|
|
66
|
+
const server = new McpServer({ name: "test", version: "0" });
|
|
67
|
+
const tools: Record<string, ToolHandler> = {};
|
|
68
|
+
const originalTool = (server as any).tool.bind(server);
|
|
69
|
+
(server as any).tool = (name: string, ...rest: any[]) => {
|
|
70
|
+
const handler = rest[rest.length - 1];
|
|
71
|
+
if (typeof handler === "function") tools[name] = handler;
|
|
72
|
+
return originalTool(name, ...rest);
|
|
73
|
+
};
|
|
74
|
+
registerTools(server, {
|
|
75
|
+
enforceNetworkId: NET_ID,
|
|
76
|
+
enforceUserId: USER_ID,
|
|
77
|
+
callerAlias: AGENT_ALIAS,
|
|
78
|
+
callerTokenIsNetwork: true,
|
|
79
|
+
callerTokenId: AGENT_TOK_ID,
|
|
80
|
+
} as any);
|
|
81
|
+
const handler = tools.send_reply;
|
|
82
|
+
if (!handler) throw new Error("send_reply handler not registered");
|
|
83
|
+
return handler;
|
|
84
|
+
}
|
|
85
|
+
|
|
86
|
+
async function call(h: ToolHandler, args: any): Promise<Reply> {
|
|
87
|
+
return JSON.parse((await h(args)).content[0].text) as Reply;
|
|
88
|
+
}
|
|
89
|
+
|
|
90
|
+
describe("#1085 send_reply — alias optional, derived from in_reply_to", () => {
|
|
91
|
+
test("alias OMITTED + in_reply_to set → derives target from task from_name, reply lands on originator", async () => {
|
|
92
|
+
const { taskId } = seed();
|
|
93
|
+
const h = await getHandler();
|
|
94
|
+
const r = await call(h, { in_reply_to: taskId, text: "done", status: "replied", from_session: AGENT_ALIAS });
|
|
95
|
+
expect(r.ok).toBe(true);
|
|
96
|
+
// The reply inbox row must be addressed to the derived originator.
|
|
97
|
+
const row = db.get<{ session_name: string; in_reply_to: string }>(
|
|
98
|
+
"SELECT session_name, in_reply_to FROM inbox WHERE id = ?1", [r.message_id],
|
|
99
|
+
);
|
|
100
|
+
expect(row?.session_name).toBe(ORIGIN_ALIAS);
|
|
101
|
+
expect(row?.in_reply_to).toBe(taskId);
|
|
102
|
+
// And the original task is terminalized (no longer pending).
|
|
103
|
+
const task = db.get<{ status: string }>("SELECT status FROM tasks WHERE task_id = ?1", [taskId]);
|
|
104
|
+
expect(task?.status).toBe("replied");
|
|
105
|
+
});
|
|
106
|
+
|
|
107
|
+
test("alias EXPLICIT still works (unchanged path)", async () => {
|
|
108
|
+
const { taskId } = seed();
|
|
109
|
+
const h = await getHandler();
|
|
110
|
+
const r = await call(h, { alias: ORIGIN_ALIAS, in_reply_to: taskId, text: "done", from_session: AGENT_ALIAS });
|
|
111
|
+
expect(r.ok).toBe(true);
|
|
112
|
+
const row = db.get<{ session_name: string }>("SELECT session_name FROM inbox WHERE id = ?1", [r.message_id]);
|
|
113
|
+
expect(row?.session_name).toBe(ORIGIN_ALIAS);
|
|
114
|
+
});
|
|
115
|
+
|
|
116
|
+
test("alias OMITTED + no in_reply_to → clean error, not a crash", async () => {
|
|
117
|
+
seed();
|
|
118
|
+
const h = await getHandler();
|
|
119
|
+
const r = await call(h, { text: "orphan reply", from_session: AGENT_ALIAS });
|
|
120
|
+
expect(r.ok).toBe(false);
|
|
121
|
+
expect(r.error).toBe("reply_target_required");
|
|
122
|
+
});
|
|
123
|
+
|
|
124
|
+
test("alias OMITTED + in_reply_to points at nonexistent task → resolve error", async () => {
|
|
125
|
+
seed();
|
|
126
|
+
const h = await getHandler();
|
|
127
|
+
const r = await call(h, { in_reply_to: "task_does_not_exist_1085", text: "x", from_session: AGENT_ALIAS });
|
|
128
|
+
expect(r.ok).toBe(false);
|
|
129
|
+
expect(r.error).toBe("reply_target_unresolved");
|
|
130
|
+
});
|
|
131
|
+
});
|
|
@@ -175,8 +175,10 @@ describe("#507 — send_reply attachments (positive)", () => {
|
|
|
175
175
|
|
|
176
176
|
// Verify persistence — the echo must come from what actually landed on disk.
|
|
177
177
|
const taskMeta = readTaskMeta(taskId);
|
|
178
|
-
|
|
179
|
-
expect(taskMeta
|
|
178
|
+
// #1823 —— 任务行上回复附件在 reply_attachments;attachments 键留给提问者自己带的附件
|
|
179
|
+
expect(taskMeta?.attachments).toBeUndefined();
|
|
180
|
+
expect(taskMeta?.reply_attachments?.length).toBe(2);
|
|
181
|
+
expect(taskMeta.reply_attachments.map((a: any) => a.file_id).sort()).toEqual([a1.file_id, a2.file_id].sort());
|
|
180
182
|
|
|
181
183
|
const inboxMeta = readInboxMeta(reply.message_id!);
|
|
182
184
|
expect(inboxMeta?.attachments?.length).toBe(2);
|
|
@@ -196,8 +198,10 @@ describe("#507 — send_reply attachments (positive)", () => {
|
|
|
196
198
|
expect(reply.ok).toBe(true);
|
|
197
199
|
expect(reply.attachments_saved!.length).toBe(1);
|
|
198
200
|
const persisted = readTaskMeta(taskId);
|
|
199
|
-
expect(persisted?.
|
|
200
|
-
expect(persisted?.
|
|
201
|
+
expect(persisted?.reply_attachments?.[0]?.file_id).toBe(a1.file_id);
|
|
202
|
+
expect(persisted?.attachments).toBeUndefined();
|
|
203
|
+
// #1823 —— 回复 meta 的兄弟字段属于回复(inbox 行),不写进提问者的任务行
|
|
204
|
+
expect(readInboxMeta(reply.message_id)?.other_field).toBe("preserved");
|
|
201
205
|
});
|
|
202
206
|
|
|
203
207
|
test("P3: top-level attachments WIN over meta.attachments when both supplied (parity with REST /api/task L2101)", async () => {
|
|
@@ -217,9 +221,26 @@ describe("#507 — send_reply attachments (positive)", () => {
|
|
|
217
221
|
expect(reply.attachments_saved!.length).toBe(1);
|
|
218
222
|
expect(reply.attachments_saved![0].file_id).toBe(topLevel.file_id);
|
|
219
223
|
const persisted = readTaskMeta(taskId);
|
|
220
|
-
expect(persisted?.
|
|
221
|
-
expect(persisted?.
|
|
222
|
-
expect(
|
|
224
|
+
expect(persisted?.reply_attachments?.length).toBe(1);
|
|
225
|
+
expect(persisted?.reply_attachments?.[0]?.file_id).toBe(topLevel.file_id);
|
|
226
|
+
expect(readInboxMeta(reply.message_id)?.other).toBe("kept");
|
|
227
|
+
});
|
|
228
|
+
|
|
229
|
+
// #1823 —— 提问者随任务带的附件必须留在 attachments;回复附件另放 reply_attachments。
|
|
230
|
+
// (Vincent 2026-09-06:回复的图被画进提问者气泡;以前整体 COALESCE 替换还会把提问者的附件覆盖掉)
|
|
231
|
+
test("P6 (#1823): asker's attachments survive a reply with attachments; reply goes to reply_attachments", async () => {
|
|
232
|
+
const { taskId } = seed();
|
|
233
|
+
const asked = att("11111111111111111111111111111111", { name: "asked.png" });
|
|
234
|
+
db.run("UPDATE tasks SET meta_json = ?1 WHERE task_id = ?2", [JSON.stringify({ attachments: [asked], origin: "dashboard" }), taskId]);
|
|
235
|
+
const handler = await getSendReplyHandler();
|
|
236
|
+
const answer = att("22222222222222222222222222222222", { name: "answer.md" });
|
|
237
|
+
const reply = await callReply(handler, { alias: AGENT_ALIAS, text: "here", in_reply_to: taskId, status: "replied" as const, attachments: [answer] });
|
|
238
|
+
expect(reply.ok).toBe(true);
|
|
239
|
+
const persisted = readTaskMeta(taskId);
|
|
240
|
+
expect(persisted?.attachments?.map((a: any) => a.file_id)).toEqual([asked.file_id]);
|
|
241
|
+
expect(persisted?.origin).toBe("dashboard");
|
|
242
|
+
expect(persisted?.reply_attachments?.map((a: any) => a.file_id)).toEqual([answer.file_id]);
|
|
243
|
+
expect(readInboxMeta(reply.message_id)?.attachments?.[0]?.file_id).toBe(answer.file_id);
|
|
223
244
|
});
|
|
224
245
|
});
|
|
225
246
|
|
package/src/send_dedup.test.ts
CHANGED
|
@@ -146,6 +146,60 @@ describe("SendDedup", () => {
|
|
|
146
146
|
});
|
|
147
147
|
});
|
|
148
148
|
|
|
149
|
+
describe("SendDedup key selection (client_request_id vs content)", () => {
|
|
150
|
+
const t0 = 1_700_000_000_000;
|
|
151
|
+
const A = "dreq_00000000000000000000000000000001";
|
|
152
|
+
const B = "dreq_00000000000000000000000000000002";
|
|
153
|
+
|
|
154
|
+
it("keyFor picks the request id when present, content hash otherwise", () => {
|
|
155
|
+
const withId = SendDedup.keyFor("alice", "bob", "好", { requestId: A, networkId: "net1" });
|
|
156
|
+
expect(withId.kind).toBe("request_id");
|
|
157
|
+
expect(withId.key).toBe(`rid|net1|alice|bob|${A}`);
|
|
158
|
+
const noId = SendDedup.keyFor("alice", "bob", "好", {});
|
|
159
|
+
expect(noId.kind).toBe("content");
|
|
160
|
+
expect(noId.key).toBe(SendDedup.key("alice", "bob", "好"));
|
|
161
|
+
// Empty / null ids fall back to the content key.
|
|
162
|
+
expect(SendDedup.keyFor("alice", "bob", "好", { requestId: "" }).kind).toBe("content");
|
|
163
|
+
expect(SendDedup.keyFor("alice", "bob", "好", { requestId: null }).kind).toBe("content");
|
|
164
|
+
});
|
|
165
|
+
|
|
166
|
+
it("same text with different request ids is never a duplicate", () => {
|
|
167
|
+
const d = new SendDedup({ windowMs: 300_000, maxKeys: 64 });
|
|
168
|
+
d.record("alice", "bob", "好", t0, { requestId: A });
|
|
169
|
+
expect(d.check("alice", "bob", "好", t0 + 1000, { requestId: B })).toEqual({ duplicate: false });
|
|
170
|
+
});
|
|
171
|
+
|
|
172
|
+
it("same request id is a duplicate even with different content (one id = one message)", () => {
|
|
173
|
+
const d = new SendDedup({ windowMs: 300_000, maxKeys: 64 });
|
|
174
|
+
d.record("alice", "bob", "first", t0, { requestId: A });
|
|
175
|
+
const again = d.check("alice", "bob", "second", t0 + 1000, { requestId: A });
|
|
176
|
+
expect(again.duplicate).toBe(true);
|
|
177
|
+
if (again.duplicate) expect(again.kind).toBe("request_id");
|
|
178
|
+
});
|
|
179
|
+
|
|
180
|
+
it("request-id keys are scoped by network, sender and target", () => {
|
|
181
|
+
const d = new SendDedup({ windowMs: 300_000, maxKeys: 64 });
|
|
182
|
+
d.record("alice", "bob", "x", t0, { requestId: A, networkId: "net1" });
|
|
183
|
+
expect(d.check("alice", "bob", "x", t0 + 1, { requestId: A, networkId: "net2" })).toEqual({ duplicate: false });
|
|
184
|
+
expect(d.check("carol", "bob", "x", t0 + 1, { requestId: A, networkId: "net1" })).toEqual({ duplicate: false });
|
|
185
|
+
expect(d.check("alice", "dave", "x", t0 + 1, { requestId: A, networkId: "net1" })).toEqual({ duplicate: false });
|
|
186
|
+
});
|
|
187
|
+
|
|
188
|
+
it("#212 regression guard: without an id, same content is still a duplicate and reports kind=content", () => {
|
|
189
|
+
const d = new SendDedup({ windowMs: 300_000, maxKeys: 64 });
|
|
190
|
+
d.record("agent", "peer", "same task", t0);
|
|
191
|
+
const again = d.check("agent", "peer", "same task", t0 + 1000);
|
|
192
|
+
expect(again.duplicate).toBe(true);
|
|
193
|
+
if (again.duplicate) expect(again.kind).toBe("content");
|
|
194
|
+
});
|
|
195
|
+
|
|
196
|
+
it("an id-bearing send does not shadow a later id-less send of the same text", () => {
|
|
197
|
+
const d = new SendDedup({ windowMs: 300_000, maxKeys: 64 });
|
|
198
|
+
d.record("alice", "bob", "好", t0, { requestId: A });
|
|
199
|
+
expect(d.check("alice", "bob", "好", t0 + 1000)).toEqual({ duplicate: false });
|
|
200
|
+
});
|
|
201
|
+
});
|
|
202
|
+
|
|
149
203
|
describe("buildDuplicateSendPayload", () => {
|
|
150
204
|
it("contains the Chinese LLM-facing hint with target alias and window minutes", () => {
|
|
151
205
|
const payload = buildDuplicateSendPayload({
|