@skyramp/mcp 0.3.2-rc.pom-3 → 0.3.2

package/build/prompts/testbot/testbot-prompts.test.d.ts

@@ -1 +0,0 @@
-export {};

package/build/prompts/testbot/testbot-prompts.test.js

@@ -1,451 +0,0 @@
-import { jest } from "@jest/globals";
-jest.unstable_mockModule("../../workspace/workspace.js", () => ({
-    WorkspaceConfigManager: jest.fn(),
-}));
-jest.unstable_mockModule("../../services/AnalyticsService.js", () => ({
-    AnalyticsService: { pushMCPToolEvent: jest.fn(() => Promise.resolve()) },
-}));
-jest.unstable_mockModule("../../playwright/traceRecordingPrompt.js", () => ({
-    getTraceRecordingPromptText: () => "",
-}));
-const { getTestbotPrompt, buildWorkspaceRecoveryPrefix, parseRelatedRepositories } = await import("./testbot-prompts.js");
-// Minimal args to invoke getTestbotPrompt — only services matter for these tests
-const baseArgs = {
-    prTitle: "Test PR",
-    prDescription: "desc",
-    summaryOutputFile: "/tmp/summary.json",
-    repositoryPath: "/repo",
-};
-function callWithServices(services) {
-    return getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath, undefined, // baseBranch
-    undefined, // maxRecommendations
-    undefined, // maxGenerate
-    undefined, // maxCritical
-    undefined, // prNumber
-    undefined, // userPrompt
-    services);
-}
-describe("buildServiceContext (via getTestbotPrompt)", () => {
-    it("renders full service with all fields", () => {
-        const prompt = callWithServices([
-            {
-                serviceName: "backend",
-                language: "python",
-                framework: "pytest",
-                testDirectory: "tests/python",
-                api: { baseUrl: "http://localhost:8000" },
-            },
-        ]);
-        expect(prompt).toContain('<service name="backend">');
-        expect(prompt).toContain("<language>python</language>");
-        expect(prompt).toContain("<framework>pytest</framework>");
-        expect(prompt).toContain("<base_url>http://localhost:8000</base_url>");
-        expect(prompt).toContain("<test_directory>tests/python</test_directory>");
-        expect(prompt).toContain("</service>");
-        expect(prompt).toContain("<services>");
-        expect(prompt).toContain("</services>");
-    });
-    it("omits optional fields when absent", () => {
-        const prompt = callWithServices([{ serviceName: "minimal" }]);
-        expect(prompt).toContain('<service name="minimal">');
-        expect(prompt).not.toContain("<language>");
-        expect(prompt).not.toContain("<framework>");
-        expect(prompt).not.toContain("<base_url>");
-        expect(prompt).not.toContain("<test_directory>");
-    });
-    it("renders multiple services", () => {
-        const prompt = callWithServices([
-            { serviceName: "api", language: "python" },
-            { serviceName: "frontend", language: "typescript" },
-        ]);
-        expect(prompt).toContain('<service name="api">');
-        expect(prompt).toContain('<service name="frontend">');
-    });
-    it("does not render services block when services array is empty", () => {
-        const prompt = callWithServices([]);
-        expect(prompt).not.toContain("<services>");
-        expect(prompt).not.toContain("<service");
-    });
-    it("does not render services block when services is undefined", () => {
-        const prompt = getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath);
-        expect(prompt).not.toContain("<services>");
-    });
-    it("escapes XML special characters in service name", () => {
-        const prompt = callWithServices([
-            { serviceName: 'my<service>&"name' },
-        ]);
-        expect(prompt).toContain('<service name="my&lt;service&gt;&amp;&quot;name">');
-        expect(prompt).not.toContain('my<service>&"name">');
-    });
-    it("escapes XML special characters in field values", () => {
-        const prompt = callWithServices([
-            {
-                serviceName: "svc",
-                testDirectory: "tests/a&b",
-                api: { baseUrl: "http://host?a=1&b=2" },
-            },
-        ]);
-        expect(prompt).toContain("<test_directory>tests/a&amp;b</test_directory>");
-        expect(prompt).toContain("<base_url>http://host?a=1&amp;b=2</base_url>");
-    });
-    it("places services block between REPOSITORY PATH and the Goal section", () => {
-        const prompt = callWithServices([{ serviceName: "svc" }]);
-        const repoIdx = prompt.indexOf("<REPOSITORY PATH>");
-        const servicesIdx = prompt.indexOf("<services>");
-        const goalIdx = prompt.indexOf("## Goal");
-        expect(repoIdx).toBeLessThan(servicesIdx);
-        expect(servicesIdx).toBeLessThan(goalIdx);
-    });
-    it("has no extra blank line when services are absent", () => {
-        const prompt = getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath);
-        // Should go directly from REPOSITORY PATH closing tag to the Goal section
-        expect(prompt).toContain("</REPOSITORY PATH>\n## Goal");
-    });
-});
-describe("uiCredentials in getTestbotPrompt", () => {
-    function callWithUiCredentials(uiCredentials) {
-        return getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath, undefined, // baseBranch
-        undefined, // maxRecommendations
-        undefined, // maxGenerate
-        undefined, // maxCritical
-        undefined, // prNumber
-        undefined, // userPrompt
-        undefined, // services
-        uiCredentials);
-    }
-    // The instructions text references `<ui-credentials>` in prose (backticked);
-    // the injected block puts the opening tag alone on its own line. Match on
-    // that to distinguish block from reference.
-    const UI_CREDS_BLOCK_RE = /^<ui-credentials>$/m;
-    it("does not render ui-credentials block when uiCredentials is undefined", () => {
-        const prompt = callWithUiCredentials(undefined);
-        expect(prompt).not.toMatch(UI_CREDS_BLOCK_RE);
-    });
-    it("does not render ui-credentials block when uiCredentials is empty string", () => {
-        const prompt = callWithUiCredentials("");
-        expect(prompt).not.toMatch(UI_CREDS_BLOCK_RE);
-    });
-    it("does not render ui-credentials block when uiCredentials is whitespace only", () => {
-        const prompt = callWithUiCredentials("   ");
-        expect(prompt).not.toMatch(UI_CREDS_BLOCK_RE);
-    });
-    it("renders ui-credentials block verbatim when credentials are provided", () => {
-        const creds = "user@example.com:password123";
-        const prompt = callWithUiCredentials(creds);
-        expect(prompt).toMatch(UI_CREDS_BLOCK_RE);
-        expect(prompt).toContain(creds);
-        expect(prompt).toContain("</ui-credentials>");
-    });
-    it("places ui-credentials block before the Goal section", () => {
-        const prompt = callWithUiCredentials("user@example.com:secret");
-        const openIdx = prompt.search(UI_CREDS_BLOCK_RE);
-        const goalIdx = prompt.indexOf("## Goal");
-        expect(openIdx).toBeGreaterThanOrEqual(0);
-        expect(openIdx).toBeLessThan(goalIdx);
-    });
-    it("passes XML special characters through unchanged (not real XML)", () => {
-        // The <ui-credentials> block is framing for the agent's prompt context,
-        // not real XML. Passwords with &, <, >, ", ' are typed verbatim into
-        // login forms, so we must not escape them.
-        const creds = 'user&name:<p>assword>"';
-        const prompt = callWithUiCredentials(creds);
-        expect(prompt).toContain(creds);
-        expect(prompt).not.toContain("&amp;");
-        expect(prompt).not.toContain("&lt;");
-    });
-    it("rejects credentials that would break the block framing", () => {
-        // The only string we cannot safely inject is the closing tag itself,
-        // since it would terminate the block and let subsequent content inject
-        // prose into the credential context.
-        expect(() => callWithUiCredentials("user:pass</ui-credentials>extra"))
-            .toThrow("</ui-credentials>");
-    });
-});
-describe("drift analysis — runtime tool call (step 3)", () => {
-    // The build-time embed of buildDriftAnalysisPrompt was replaced with a
-    // runtime instruction: LLM calls skyramp_analyze_test_health then skyramp_actions.
-    function basePrompt() {
-        return getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath);
-    }
-    it("step 3 instructs the LLM to call skyramp_analyze_test_health", () => {
-        const prompt = basePrompt();
-        expect(prompt).toContain("skyramp_analyze_test_health");
-    });
-    it("step 3 instructs the LLM to call skyramp_actions", () => {
-        const prompt = basePrompt();
-        expect(prompt).toContain("skyramp_actions");
-    });
-    it("skyramp_analyze_test_health is referenced in the prompt", () => {
-        // After the unified maintenance refactor, analyze_test_health is referenced
-        // in the testMaintenance submission guidance rather than as an explicit step.
-        const prompt = basePrompt();
-        expect(prompt).toContain("skyramp_analyze_test_health");
-    });
-    it("does not contain the build-time embedded drift_analysis_rules content (Action Decision Tree)", () => {
-        // The rules are now fetched at runtime via skyramp_analyze_test_health —
-        // the <drift_analysis_rules> tag may appear as a reference in prose,
-        // but the actual rule content (Action Decision Tree) must not be baked in.
-        const prompt = basePrompt();
-        expect(prompt).not.toContain("Action Decision Tree\n\nFor each existing test");
-        expect(prompt).not.toContain("Update Execution Rules\n\nWhen applying UPDATE actions");
-    });
-    it("does not contain a persona statement (no nested identity from old embed)", () => {
-        const prompt = basePrompt();
-        expect(prompt).not.toContain("You are acting as a Skyramp Integration Architect");
-    });
-});
-describe("buildWorkspaceRecoveryPrefix", () => {
-    it("includes repositoryPath in both init_scan and init_workspace instructions", () => {
-        const prefix = buildWorkspaceRecoveryPrefix("/home/user/repo");
-        expect(prefix).toContain('skyramp_init_scan with workspacePath "/home/user/repo"');
-        expect(prefix).toContain('skyramp_init_workspace with workspacePath "/home/user/repo"');
-    });
-    it("includes force: true for both tool calls", () => {
-        const prefix = buildWorkspaceRecoveryPrefix("/repo");
-        expect(prefix).toContain("force: true, then call skyramp_init_workspace");
-        expect(prefix).toContain("force: true to regenerate");
-    });
-    it("starts with IMPORTANT", () => {
-        const prefix = buildWorkspaceRecoveryPrefix("/repo");
-        expect(prefix).toMatch(/^IMPORTANT:/);
-    });
-});
-describe("testsRepoDir in getTestbotPrompt", () => {
-    function callWithTestsRepoDir(testsRepoDir) {
-        return getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath, undefined, // baseBranch
-        undefined, // maxRecommendations
-        undefined, // maxGenerate
-        undefined, // maxCritical
-        undefined, // prNumber
-        undefined, // userPrompt
-        undefined, // services
-        undefined, // uiCredentials
-        testsRepoDir);
-    }
-    function callFollowUpWithTestsRepoDir(testsRepoDir) {
-        return getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath, undefined, // baseBranch
-        undefined, // maxRecommendations
-        undefined, // maxGenerate
-        undefined, // maxCritical
-        undefined, // prNumber
-        "add more tests", // userPrompt — triggers follow-up path
-        undefined, // services
-        undefined, // uiCredentials
-        testsRepoDir);
-    }
-    it("includes testsRepoDir in skyramp_analyze_changes call for first-run prompt", () => {
-        const dir = "/home/runner/work/_temp/skyramp/test-repo";
-        const prompt = callWithTestsRepoDir(dir);
-        expect(prompt).toContain(`\`testsRepoDir\`: "${dir}"`);
-    });
-    it("includes testsRepoDir in skyramp_analyze_changes call for follow-up prompt", () => {
-        const dir = "/home/runner/work/_temp/skyramp/test-repo";
-        const prompt = callFollowUpWithTestsRepoDir(dir);
-        expect(prompt).toContain(`\`testsRepoDir\`: "${dir}"`);
-    });
-    it("omits testsRepoDir when not provided", () => {
-        const prompt = callWithTestsRepoDir(undefined);
-        expect(prompt).not.toContain("testsRepoDir");
-    });
-    it("omits testsRepoDir from follow-up prompt when not provided", () => {
-        const prompt = callFollowUpWithTestsRepoDir(undefined);
-        expect(prompt).not.toContain("testsRepoDir");
-    });
-});
-describe("testbot prompt blueprint-grounded recommendations (slice 4)", () => {
-    it("uses a single skyramp_analyze_changes call (no separate pre-flight tool, no blueprint threading)", () => {
-        const prompt = getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath);
-        // The standalone pre-flight tool is gone — its work folded into analyze_changes.
-        expect(prompt).not.toContain("skyramp_ui_analyze_changes");
-        expect(prompt).toContain("skyramp_analyze_changes");
-        // Captures stay in tool-result history — the old capturedBlueprints
-        // threading directive must be gone.
-        expect(prompt).not.toMatch(/capturedBlueprints/);
-    });
-    // Flutter support — both the generalised UI trigger wording and the
-    // canvas/empty-ARIA issuesFound rule should appear in the prompt.
-    it("UI test priority defers to the deterministic server signal (uiContext.changedFrontendFiles), not just hard-coded extensions", () => {
-        const prompt = getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath);
-        // The trigger must reference the server signal (changedFrontendFiles)
-        // — that's what makes it framework-agnostic. Hard-coded extension lists
-        // become illustrative, not gating.
-        expect(prompt).toMatch(/uiContext.*changedFrontendFiles|changedFrontendFiles.*uiContext/);
-        // .dart should appear in the supported-types example list
-        expect(prompt).toMatch(/\.dart/);
-    });
-    it("frontend-only PR exception lists .dart alongside other frontend extensions", () => {
-        const prompt = getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath);
-        // The frontend-only-PR exception block (Task 2 backend-fallback skip)
-        // must include .dart so a Flutter-only PR doesn't emit a backend
-        // contract test as a fallback.
-        const exceptionBlock = prompt.slice(prompt.indexOf("Exception — frontend-only PRs"), prompt.indexOf("Exception — frontend-only PRs") + 800);
-        expect(exceptionBlock).toContain(".dart");
-        expect(exceptionBlock).toContain(".tsx");
-        expect(exceptionBlock).toContain(".vue");
-    });
-});
-describe("relatedRepositories in getTestbotPrompt (multi-repo mode)", () => {
-    const PRIMARY_REPO = "letsramp/primary-app";
-    const related = [
-        { repo: "letsramp/backend", repositoryPath: "/tmp/skyramp/related-repo-0-backend", baseBranch: "main" },
-        { repo: "letsramp/shared", repositoryPath: "/tmp/skyramp/related-repo-1-shared", baseBranch: "master" },
-    ];
-    function callWithRelated(repos, opts) {
-        return getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath, undefined, // baseBranch
-        undefined, // maxRecommendations
-        undefined, // maxGenerate
-        undefined, // maxCritical
-        undefined, // prNumber
-        undefined, // userPrompt
-        undefined, // services
-        undefined, // uiCredentials
-        opts?.testsRepoDir, // testsRepoDir
-        repos, opts?.primaryRepo ?? PRIMARY_REPO);
-    }
-    it("emits a <related_repositories> XML block with repository + path + base_branch per repo", () => {
-        const prompt = callWithRelated(related);
-        expect(prompt).toContain("<related_repositories>");
-        expect(prompt).toContain("</related_repositories>");
-        expect(prompt).toContain('<repository repository="letsramp/backend" path="/tmp/skyramp/related-repo-0-backend" base_branch="main" />');
-        expect(prompt).toContain('<repository repository="letsramp/shared" path="/tmp/skyramp/related-repo-1-shared" base_branch="master" />');
-        // Pure XML — no free-form "repositoryPath:" / "baseBranch:" colon syntax.
-        expect(prompt).not.toContain("repositoryPath:");
-        expect(prompt).not.toMatch(/baseBranch:/);
-    });
-    it("emits the primary repo's owner/repo in a <REPOSITORY> block", () => {
-        const prompt = callWithRelated(related);
-        expect(prompt).toContain(`<REPOSITORY>${PRIMARY_REPO}</REPOSITORY>`);
-    });
-    it("always emits a base_branch attribute, even when no explicit baseBranch is provided", () => {
-        const prompt = callWithRelated([
-            { repo: "letsramp/backend", repositoryPath: "/tmp/skyramp/related-repo-0-backend" },
-        ]);
-        expect(prompt).toContain("<related_repositories>");
-        // Absent value → explicit auto-detect marker in the attribute.
-        expect(prompt).toContain('<repository repository="letsramp/backend" path="/tmp/skyramp/related-repo-0-backend" base_branch="auto-detect" />');
-    });
-    it("keeps the unified workspace in the PRIMARY repo even when testsRepoDir is set", () => {
-        const prompt = callWithRelated(related, { testsRepoDir: "/tmp/skyramp/test-repo" });
-        // workspace.yml is registered in the primary repo regardless of the test repo.
-        expect(prompt).toContain(`\`workspacePath\`: "${baseArgs.repositoryPath}"`);
-        expect(prompt).not.toContain('`workspacePath`: "/tmp/skyramp/test-repo"');
-        // And it makes the primary-vs-test-repo distinction explicit to the agent.
-        expect(prompt).toMatch(/NOT in the configured test repo/);
-    });
-    it("leaves the single-repo prompt unchanged when no related repos are provided", () => {
-        const prompt = callWithRelated(undefined);
-        expect(prompt).not.toContain("<related_repositories>");
-        expect(prompt).not.toContain("MULTI-REPO CONTEXT");
-        expect(prompt).not.toContain("MULTI-REPO attribution");
-        // The cross-repo round-robin / candidate-pooling language must not leak into
-        // single-repo runs (the as-is GENERATE mandate stays authoritative there).
-        expect(prompt).not.toMatch(/round-robin/i);
-        expect(prompt).not.toContain("Multi-repo exception");
-        expect(prompt).not.toMatch(/candidates, not a fixed selection/i);
-    });
-    it("treats an empty array as single-repo", () => {
-        const prompt = callWithRelated([]);
-        expect(prompt).not.toContain("<related_repositories>");
-    });
-});
-describe("parseRelatedRepositories", () => {
-    it("parses a valid JSON array", () => {
-        const parsed = parseRelatedRepositories(JSON.stringify([
-            { repo: "o/a", repositoryPath: "/a", baseBranch: "main" },
-            { repo: "o/b", repositoryPath: "/b" },
-        ]));
-        expect(parsed).toEqual([
-            { repo: "o/a", repositoryPath: "/a", baseBranch: "main" },
-            { repo: "o/b", repositoryPath: "/b", baseBranch: undefined },
-        ]);
-    });
-    it("returns undefined for missing input", () => {
-        expect(parseRelatedRepositories(undefined)).toBeUndefined();
-        expect(parseRelatedRepositories("")).toBeUndefined();
-    });
-    it("returns undefined for malformed JSON", () => {
-        expect(parseRelatedRepositories("{not json")).toBeUndefined();
-    });
-    it("returns undefined for an empty array", () => {
-        expect(parseRelatedRepositories("[]")).toBeUndefined();
-    });
-    it("drops entries missing a repositoryPath or repo", () => {
-        const parsed = parseRelatedRepositories(JSON.stringify([
-            { repo: "o/x", baseBranch: "main" }, // no repositoryPath
-            { repositoryPath: "/no-repo" }, // no repo
-            { repo: "o/ok", repositoryPath: "/ok" },
-        ]));
-        expect(parsed).toEqual([{ repo: "o/ok", repositoryPath: "/ok", baseBranch: undefined }]);
-    });
-});
-describe("plan-only eval mode (via getTestbotPrompt)", () => {
-    function callWithPlanOnly(planOnly) {
-        return getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath, undefined, // baseBranch
-        undefined, // maxRecommendations
-        undefined, // maxGenerate
-        undefined, // maxCritical
-        undefined, // prNumber
-        undefined, // userPrompt
-        undefined, // services
-        undefined, // uiCredentials
-        undefined, // testsRepoDir
-        undefined, // relatedRepositories
-        undefined, // primaryRepo
-        planOnly);
-    }
-    it("branches Task 2 to the plan-only variant when planOnly is true", () => {
-        const prompt = callWithPlanOnly(true);
-        expect(prompt).toContain("## Task 2: Commit the Test Plan (plan-only run)");
-        expect(prompt).not.toContain("## Task 2: Generate New Tests");
-        // The standard generation/execution mandates must be absent, not overridden.
-        expect(prompt).not.toContain("skyramp_integration_test_generation");
-        expect(prompt).not.toContain('phase: "before"');
-        // Task 3 declares the plan instead of counting generated files.
-        expect(prompt).toContain("DECLARES your final GENERATE selection");
-    });
-    it("renders the standard prompt untouched when planOnly is false or omitted", () => {
-        const prompt = callWithPlanOnly(false);
-        expect(prompt).toContain("## Task 2: Generate New Tests");
-        expect(prompt).not.toContain("plan-only");
-        expect(prompt).toBe(callWithServices([]));
-    });
-});
-describe("report language in getTestbotPrompt", () => {
-    const callWithLanguage = (language) => getTestbotPrompt(baseArgs.prTitle, baseArgs.prDescription, baseArgs.summaryOutputFile, baseArgs.repositoryPath, undefined, // baseBranch
-    undefined, // maxRecommendations
-    undefined, // maxGenerate
-    undefined, // maxCritical
-    undefined, // prNumber
-    undefined, // userPrompt
-    undefined, // services
-    undefined, // uiCredentials
-    undefined, // testsRepoDir
-    undefined, // relatedRepositories
-    undefined, // primaryRepo
-    false, // planOnly
-    language);
-    it("adds the report-language block for ja", () => {
-        expect(callWithLanguage("ja")).toContain("**Report language: Japanese.**");
-    });
-    it("omits the block for en", () => {
-        expect(callWithLanguage("en")).not.toContain("**Report language:");
-    });
-    it("omits the block when language is not set", () => {
-        expect(callWithLanguage(undefined)).not.toContain("**Report language:");
-    });
-    it("resolves the English display name for other language codes", () => {
-        expect(callWithLanguage("ko")).toContain("**Report language: Korean.**");
-    });
-});
-describe("UI code reuse wiring", () => {
-    it("instructs codeReuse: true for TS/JS Playwright UI generation", () => {
-        const p = callWithServices([]);
-        expect(p).toContain("codeReuse: true");
-    });
-    it("teaches both reuse outcomes and the raw.bak insurance rule", () => {
-        const p = callWithServices([]);
-        expect(p).toContain("No reusable POM layer detected");
-        expect(p).toContain("verification: passed");
-        expect(p).toContain(".raw.bak");
-    });
-});

package/build/recommendation/budgeters/diversityBalancedBudgeter.test.d.ts

@@ -1 +0,0 @@
-export {};

package/build/recommendation/budgeters/diversityBalancedBudgeter.test.js

@@ -1,138 +0,0 @@
-import { diversityBalancedBudgeter } from "./diversityBalancedBudgeter.js";
-import { PriorityTier } from "../../types/TestRecommendation.js";
-import { fixedNBudgeter } from "./fixedNBudgeter.js";
-import { mkCandidate } from "../testFixtures.js";
-function ctx(over = {}) {
-    return {
-        maxGenerate: 3,
-        maxTotal: 20,
-        isUIOnlyPR: false,
-        hasFrontendChanges: false,
-        externalCoverage: new Set(),
-        ...over,
-    };
-}
-const countType = (r, t) => r.generate.filter((c) => c.scenario.testType === t).length;
-const typesIn = (r) => new Set(r.generate.map((c) => c.scenario.testType));
-describe("diversityBalancedBudgeter", () => {
-    it("guarantees a contract slot where fixed-n starves it (the SKYR-3879 fix)", () => {
-        // Protected (CRITICAL) integration scenarios out-rank contract ones and, at N=3,
-        // fixed-n's protected-first fill consumes every slot with integration → 0 contract.
-        const ranked = [
-            mkCandidate("i1", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i2", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i3", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("c1", { testType: "contract" }),
-            mkCandidate("c2", { testType: "contract" }),
-        ];
-        const c = ctx({ maxGenerate: 3 });
-        // Baseline: fixed-n reproduces the skew.
-        expect(countType(fixedNBudgeter.select(ranked, c), "contract")).toBe(0);
-        // Fix: diversity-balanced reserves a per-type floor.
-        const div = diversityBalancedBudgeter.select(ranked, c);
-        expect(div.generate.length).toBe(3);
-        expect(countType(div, "contract")).toBeGreaterThanOrEqual(1);
-        expect(countType(div, "integration")).toBeGreaterThanOrEqual(1);
-    });
-    it("gives every present test type at least one slot before any type gets a second", () => {
-        const ranked = [
-            mkCandidate("i1", { testType: "integration" }),
-            mkCandidate("i2", { testType: "integration" }),
-            mkCandidate("i3", { testType: "integration" }),
-            mkCandidate("c1", { testType: "contract" }),
-            mkCandidate("c2", { testType: "contract" }),
-            mkCandidate("u1", { testType: "ui" }),
-        ];
-        const div = diversityBalancedBudgeter.select(ranked, ctx({ maxGenerate: 3 }));
-        expect(typesIn(div)).toEqual(new Set(["integration", "contract", "ui"]));
-    });
-    it("raising maxGenerate increases per-type coverage while keeping the floor", () => {
-        const ranked = [
-            mkCandidate("i1", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i2", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i3", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i4", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i5", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("c1", { testType: "contract" }),
-            mkCandidate("c2", { testType: "contract" }),
-            mkCandidate("u1", { testType: "ui" }),
-        ];
-        const atThree = diversityBalancedBudgeter.select(ranked, ctx({ maxGenerate: 3 }));
-        const atSix = diversityBalancedBudgeter.select(ranked, ctx({ maxGenerate: 6 }));
-        expect(countType(atThree, "contract")).toBeGreaterThanOrEqual(1);
-        expect(countType(atThree, "ui")).toBeGreaterThanOrEqual(1);
-        expect(countType(atSix, "contract")).toBeGreaterThanOrEqual(1);
-        expect(countType(atSix, "ui")).toBeGreaterThanOrEqual(1);
-        // more budget → more of the highest-ranked (integration) coverage
-        expect(countType(atSix, "integration")).toBeGreaterThan(countType(atThree, "integration"));
-        expect(atSix.generate.length).toBe(6);
-    });
-    it("returns everything (rank order) when maxGenerate >= candidate count", () => {
-        const ranked = [mkCandidate("i1", { testType: "integration" }), mkCandidate("c1", { testType: "contract" })];
-        const div = diversityBalancedBudgeter.select(ranked, ctx({ maxGenerate: 5 }));
-        expect(div.generate.map((c) => c.scenario.scenarioName)).toEqual(["i1", "c1"]);
-    });
-});
-// Regression: the backend pick leaves UI slots empty (backend count is 0 on a
-// UI-only PR, maxGenerate-1 on a mixed PR), and reservedUISlots — the count that
-// budgets for them — used to be dropped, so a UI-only PR rendered an empty
-// GENERATE list. runBudget now fills the reserved UI slots for BOTH budgeters.
-describe("runBudget reserved-UI-slot fill", () => {
-    it("fills GENERATE with UI candidates on a UI-only PR (was empty)", () => {
-        const ranked = [
-            mkCandidate("u1", { testType: "ui" }),
-            mkCandidate("u2", { testType: "ui" }),
-            mkCandidate("u3", { testType: "ui" }),
-        ];
-        const testCandidates = diversityBalancedBudgeter.select(ranked, ctx({ isUIOnlyPR: true, hasFrontendChanges: true, maxGenerate: 3 }));
-        expect(testCandidates.generate).toHaveLength(3);
-        expect(typesIn(testCandidates)).toEqual(new Set(["ui"]));
-        expect(testCandidates.additional).toHaveLength(0);
-    });
-    it("applies to fixedNBudgeter too (shared runBudget pipeline)", () => {
-        const ranked = [mkCandidate("u1", { testType: "ui" }), mkCandidate("u2", { testType: "ui" })];
-        const res = fixedNBudgeter.select(ranked, ctx({ isUIOnlyPR: true, hasFrontendChanges: true, maxGenerate: 3 }));
-        expect(res.generate).toHaveLength(2);
-        expect(countType(res, "ui")).toBe(2);
-    });
-    it("caps promoted UI slots at maxGenerate, leaving the rest in ADDITIONAL", () => {
-        const ranked = [
-            mkCandidate("u1", { testType: "ui" }),
-            mkCandidate("u2", { testType: "ui" }),
-            mkCandidate("u3", { testType: "ui" }),
-            mkCandidate("u4", { testType: "ui" }),
-        ];
-        const div = diversityBalancedBudgeter.select(ranked, ctx({ isUIOnlyPR: true, hasFrontendChanges: true, maxGenerate: 2 }));
-        expect(div.generate).toHaveLength(2);
-        expect(div.additional).toHaveLength(2);
-        expect(typesIn(div)).toEqual(new Set(["ui"]));
-    });
-    it("reserves one UI slot even when the pick would otherwise starve UI (mixed PR)", () => {
-        // backend = maxGenerate-1 = 2; fixed-n fills both with the protected
-        // integrations, starving UI — the reserved slot then pulls u1 into GENERATE.
-        const ranked = [
-            mkCandidate("i1", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i2", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i3", { testType: "integration", priority: PriorityTier.CRITICAL }),
-            mkCandidate("u1", { testType: "ui" }),
-        ];
-        const res = fixedNBudgeter.select(ranked, ctx({ hasFrontendChanges: true, maxGenerate: 3 }));
-        expect(res.generate).toHaveLength(3);
-        expect(countType(res, "ui")).toBe(1);
-    });
-    it("fills GENERATE when the top-ranked candidate is UI on a mixed PR", () => {
-        // Top-ranked (CRITICAL) candidate is UI. Without excluding UI from the backend
-        // pick it would be consumed there, the UI-promotion loop would find no UI left,
-        // and GENERATE would be short of maxGenerate. Backend must fill from non-UI.
-        const ranked = [
-            mkCandidate("u1", { testType: "ui", priority: PriorityTier.CRITICAL }),
-            mkCandidate("i1", { testType: "integration" }),
-            mkCandidate("i2", { testType: "integration" }),
-            mkCandidate("i3", { testType: "integration" }),
-        ];
-        const res = fixedNBudgeter.select(ranked, ctx({ hasFrontendChanges: true, maxGenerate: 3 }));
-        expect(res.generate).toHaveLength(3);
-        expect(countType(res, "ui")).toBe(1);
-        expect(countType(res, "integration")).toBe(2);
-    });
-});

package/build/recommendation/budgeters/fixedNBudgeter.test.d.ts

@@ -1 +0,0 @@
-export {};