@skyramp/mcp 0.3.2-rc.pom-3 → 0.3.2

package/build/prompts/test-recommendation/scopeAssessment.test.js

@@ -1,371 +0,0 @@
-import { jest } from "@jest/globals";
-jest.mock("@skyramp/skyramp", () => ({
-    WorkspaceConfigManager: { create: jest.fn() },
-}));
-import * as fs from "fs";
-import * as path from "path";
-import * as os from "os";
-import { hasFlutterSdkDep, isFrontendFile, isTestFile, buildScopeAssessmentSection } from "./scopeAssessment.js";
-// ---------------------------------------------------------------------------
-// isFrontendFile
-// ---------------------------------------------------------------------------
-describe("isFrontendFile", () => {
-    it("returns true for a TSX component in components/", () => {
-        expect(isFrontendFile("src/components/Button.tsx")).toBe(true);
-    });
-    it("returns true for a JSX file in pages/", () => {
-        expect(isFrontendFile("src/pages/Home.jsx")).toBe(true);
-    });
-    it("returns true for a Vue file in views/", () => {
-        expect(isFrontendFile("src/views/Dashboard.vue")).toBe(true);
-    });
-    it("returns false for a TS route handler (API directory)", () => {
-        expect(isFrontendFile("src/routes/items.ts")).toBe(false);
-    });
-    it("returns false for a TS file in a backend service directory", () => {
-        expect(isFrontendFile("src/services/AuthService.ts")).toBe(false);
-    });
-    it("returns true for a TS file in components/ (tsx? matches .ts)", () => {
-        // FRONTEND_FILE_PATTERN uses tsx? which matches both .ts and .tsx
-        expect(isFrontendFile("src/components/utils.ts")).toBe(true);
-    });
-    it("returns false for a backend TS file in api/ even with tsx extension", () => {
-        expect(isFrontendFile("src/api/handlers/UserHandler.tsx")).toBe(false);
-    });
-    // Regression cases from three-tier logic
-    it("returns true for SvelteKit page in routes/ (svelte is always frontend)", () => {
-        expect(isFrontendFile("src/routes/+page.svelte")).toBe(true);
-    });
-    it("returns false for Next.js API route (.tsx in pages/api/)", () => {
-        expect(isFrontendFile("pages/api/users.tsx")).toBe(false);
-    });
-    it("returns true for a standalone TSX component (no API dir)", () => {
-        expect(isFrontendFile("Button.tsx")).toBe(true);
-    });
-    it("returns true for an App.vue file", () => {
-        expect(isFrontendFile("App.vue")).toBe(true);
-    });
-    // .tsx/.jsx in non-standard dirs (lib/, shared/, helpers/) — tier 2 fires because
-    // JSX syntax is inherently frontend; no backend framework uses .tsx outside API dirs.
-    it("returns true for a TSX helper in lib/ (JSX implies frontend, no API dir)", () => {
-        expect(isFrontendFile("lib/FormHelpers.tsx")).toBe(true);
-    });
-    it("returns true for a JSX component in shared/", () => {
-        expect(isFrontendFile("shared/helpers.jsx")).toBe(true);
-    });
-    // .ts in a non-frontend dir stays false — plain TypeScript needs directory context.
-    it("returns false for a plain TS utility in lib/ (no frontend dir, tier 3 applies)", () => {
-        expect(isFrontendFile("lib/utils.ts")).toBe(false);
-    });
-    it("returns false for a plain TS API client in utils/ (no frontend dir)", () => {
-        expect(isFrontendFile("utils/apiClient.ts")).toBe(false);
-    });
-    // Flutter / Dart support — gated on hasFlutterSdkDep.
-    // Without the flag, .dart is unrecognised (legacy behaviour). With it,
-    // .dart is always-frontend (tier 2, before API_DIR_PATTERN).
-    describe(".dart files (Flutter)", () => {
-        it("returns false for .dart without hasFlutterSdkDep (default)", () => {
-            expect(isFrontendFile("lib/main.dart")).toBe(false);
-        });
-        it("returns false for .dart with hasFlutterSdkDep: false", () => {
-            expect(isFrontendFile("lib/main.dart", { hasFlutterSdkDep: false })).toBe(false);
-        });
-        it("returns true for .dart with hasFlutterSdkDep: true", () => {
-            expect(isFrontendFile("lib/main.dart", { hasFlutterSdkDep: true })).toBe(true);
-        });
-        it("returns true for nested .dart files in a Flutter project", () => {
-            expect(isFrontendFile("lib/widgets/game_board.dart", { hasFlutterSdkDep: true })).toBe(true);
-        });
-        it("returns true for .dart even in a directory that would otherwise look API-like (Flutter has no server-side Dart in scope)", () => {
-            // .dart sits in tier 2 (above API_DIR_PATTERN) so it's frontend even
-            // under api/ — there's no server-side Dart web framework that would
-            // make this ambiguous in the Flutter case.
-            expect(isFrontendFile("lib/api/client.dart", { hasFlutterSdkDep: true })).toBe(true);
-        });
-        it("returns true for game.dart at repo root in a Flutter project", () => {
-            expect(isFrontendFile("game.dart", { hasFlutterSdkDep: true })).toBe(true);
-        });
-    });
-});
-// ---------------------------------------------------------------------------
-// hasFlutterSdkDep
-// ---------------------------------------------------------------------------
-describe("hasFlutterSdkDep", () => {
-    let tmpDir;
-    beforeEach(() => {
-        tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), "flutter-pubspec-"));
-    });
-    afterEach(() => {
-        fs.rmSync(tmpDir, { recursive: true, force: true });
-    });
-    it("returns false when pubspec.yaml is absent", () => {
-        expect(hasFlutterSdkDep(tmpDir)).toBe(false);
-    });
-    it("returns true when pubspec.yaml has the canonical Flutter SDK dep", () => {
-        fs.writeFileSync(path.join(tmpDir, "pubspec.yaml"), `name: birdle
-description: A Flutter app.
-dependencies:
-  flutter:
-    sdk: flutter
-  cupertino_icons: ^1.0.6
-`);
-        expect(hasFlutterSdkDep(tmpDir)).toBe(true);
-    });
-    it("returns false for a pure Dart project (no flutter SDK dep)", () => {
-        // Pure Dart server (e.g. shelf, dart_frog) has pubspec.yaml but no flutter SDK
-        fs.writeFileSync(path.join(tmpDir, "pubspec.yaml"), `name: my_dart_server
-description: A Dart server using shelf.
-environment:
-  sdk: ">=3.0.0 <4.0.0"
-dependencies:
-  shelf: ^1.4.0
-  shelf_router: ^1.1.4
-`);
-        expect(hasFlutterSdkDep(tmpDir)).toBe(false);
-    });
-    it("returns false for a Dart CLI tool (no flutter SDK dep)", () => {
-        fs.writeFileSync(path.join(tmpDir, "pubspec.yaml"), `name: my_cli
-description: A Dart CLI.
-environment:
-  sdk: ^3.5.0
-dependencies:
-  args: ^2.5.0
-`);
-        expect(hasFlutterSdkDep(tmpDir)).toBe(false);
-    });
-    it("returns false on a malformed pubspec.yaml (graceful failure)", () => {
-        fs.writeFileSync(path.join(tmpDir, "pubspec.yaml"), "::: not yaml ::: \x00");
-        // Our regex-based check still works on string content; this is more of
-        // a "doesn't throw" test. Returns false because the malformed content
-        // doesn't match the sdk: flutter pattern.
-        expect(hasFlutterSdkDep(tmpDir)).toBe(false);
-    });
-    it("returns true even with extra whitespace and comments in pubspec.yaml", () => {
-        fs.writeFileSync(path.join(tmpDir, "pubspec.yaml"), `name: birdle
-# This is the SDK dep
-dependencies:
-  flutter:
-    sdk:    flutter
-`);
-        expect(hasFlutterSdkDep(tmpDir)).toBe(true);
-    });
-    // Subdir search — common shapes in real Flutter repos.
-    it("returns true when pubspec.yaml lives in app/", () => {
-        fs.mkdirSync(path.join(tmpDir, "app"));
-        fs.writeFileSync(path.join(tmpDir, "app", "pubspec.yaml"), "name: app\ndependencies:\n  flutter:\n    sdk: flutter\n");
-        expect(hasFlutterSdkDep(tmpDir)).toBe(true);
-    });
-    it("returns true when pubspec.yaml lives in mobile/", () => {
-        fs.mkdirSync(path.join(tmpDir, "mobile"));
-        fs.writeFileSync(path.join(tmpDir, "mobile", "pubspec.yaml"), "name: app\ndependencies:\n  flutter:\n    sdk: flutter\n");
-        expect(hasFlutterSdkDep(tmpDir)).toBe(true);
-    });
-    it("returns true for monorepo with apps/<name>/pubspec.yaml", () => {
-        fs.mkdirSync(path.join(tmpDir, "apps", "customer-app"), { recursive: true });
-        fs.writeFileSync(path.join(tmpDir, "apps", "customer-app", "pubspec.yaml"), "name: customer_app\ndependencies:\n  flutter:\n    sdk: flutter\n");
-        expect(hasFlutterSdkDep(tmpDir)).toBe(true);
-    });
-    it("returns true for monorepo with packages/<name>/pubspec.yaml", () => {
-        fs.mkdirSync(path.join(tmpDir, "packages", "ui"), { recursive: true });
-        fs.writeFileSync(path.join(tmpDir, "packages", "ui", "pubspec.yaml"), "name: ui\ndependencies:\n  flutter:\n    sdk: flutter\n");
-        expect(hasFlutterSdkDep(tmpDir)).toBe(true);
-    });
-    it("returns false when monorepo subdirs only contain pure-Dart packages", () => {
-        // Mixed monorepo: a Dart CLI in packages/cli/, no Flutter app anywhere.
-        fs.mkdirSync(path.join(tmpDir, "packages", "cli"), { recursive: true });
-        fs.writeFileSync(path.join(tmpDir, "packages", "cli", "pubspec.yaml"), "name: cli\ndependencies:\n  args: ^2.5.0\n");
-        expect(hasFlutterSdkDep(tmpDir)).toBe(false);
-    });
-    it("does not walk arbitrary subdirs (e.g. node_modules-style nested deps)", () => {
-        // A pubspec deep under an unsupported subdir should NOT be picked up.
-        // Without this guard, a transitive dependency's pubspec could falsely
-        // flag a non-Flutter repo as Flutter.
-        fs.mkdirSync(path.join(tmpDir, "vendor", "nested", "lib"), { recursive: true });
-        fs.writeFileSync(path.join(tmpDir, "vendor", "nested", "lib", "pubspec.yaml"), "name: nested\ndependencies:\n  flutter:\n    sdk: flutter\n");
-        expect(hasFlutterSdkDep(tmpDir)).toBe(false);
-    });
-});
-// ---------------------------------------------------------------------------
-// isTestFile
-// ---------------------------------------------------------------------------
-describe("isTestFile", () => {
-    it("matches Skyramp-generated test suffix patterns", () => {
-        expect(isTestFile("backend/tests/orders_integration_test.py")).toBe(true);
-        expect(isTestFile("frontend/tests/cart_ui_test.ts")).toBe(true);
-        expect(isTestFile("backend/tests/users_contract_test.py")).toBe(true);
-        expect(isTestFile("backend/tests/load_test.py")).toBe(true);
-    });
-    it("matches Skyramp scenario JSON files", () => {
-        expect(isTestFile("tests/scenario_orders.json")).toBe(true);
-        expect(isTestFile("scenario_checkout.json")).toBe(true);
-    });
-    it("matches conventional Vitest/Jest/Playwright spec naming", () => {
-        expect(isTestFile("frontend/tests/cart_labels_baseline.spec.ts")).toBe(true);
-        expect(isTestFile("src/components/Button.test.tsx")).toBe(true);
-        expect(isTestFile("e2e/login.spec.js")).toBe(true);
-        expect(isTestFile("packages/foo/Bar.test.jsx")).toBe(true);
-        // `.e2e.` dot form (Playwright/Cypress) — discovery's UI_TEST_EXT treats it as a UI test.
-        expect(isTestFile("e2e/login.e2e.ts")).toBe(true);
-        expect(isTestFile("packages/foo/Members.e2e.tsx")).toBe(true);
-    });
-    it("matches files under __tests__/ directories", () => {
-        expect(isTestFile("src/__tests__/utils.ts")).toBe(true);
-        expect(isTestFile("packages/foo/__tests__/Bar.tsx")).toBe(true);
-    });
-    it("returns false for ordinary source files", () => {
-        expect(isTestFile("frontend/src/pages/Cart.tsx")).toBe(false);
-        expect(isTestFile("frontend/src/components/Button.tsx")).toBe(false);
-        expect(isTestFile("backend/src/handlers/orders.py")).toBe(false);
-    });
-    it("returns false for non-spec .ts files in tests/ directories that aren't Skyramp-generated", () => {
-        // Tests/ directory alone doesn't trigger isTestFile — only the suffix matters.
-        expect(isTestFile("frontend/tests/helpers/setup.ts")).toBe(false);
-    });
-});
-// ---------------------------------------------------------------------------
-// buildScopeAssessmentSection
-// ---------------------------------------------------------------------------
-describe("buildScopeAssessmentSection", () => {
-    it("produces a valid range in Step C for normal inputs (topN > maxGenerate)", () => {
-        const section = buildScopeAssessmentSection(10, 3);
-        // minTotal = min(3+1, 10) = 4; range should be "4–10"
-        expect(section).toContain("4–10");
-        expect(section).toContain("3 (generate) + 1 (min additional) = 4");
-    });
-    it("clamps minTotal to maxTotal when maxTotal === maxGenerate (regression: no inverted range)", () => {
-        // Edge case from review: topN=4, maxGenerate=4 → minTotal must not exceed maxTotal
-        const section = buildScopeAssessmentSection(4, 4);
-        // minTotal = min(4+1, 4) = 4; range should be "4–4", NOT "5–4"
-        expect(section).toContain("4–4");
-        // minAdditional = 4 - 4 = 0; baseline should say "0 (min additional)"
-        expect(section).toContain("4 (generate) + 0 (min additional) = 4");
-        // Must NOT contain an inverted range
-        expect(section).not.toMatch(/\b5–4\b/);
-    });
-    it("clamps minTotal to maxTotal when maxTotal < maxGenerate", () => {
-        // Defensive: maxGenerate clamped to topN upstream, but guard applies here too
-        const section = buildScopeAssessmentSection(3, 5);
-        // effectiveGenerate = min(5, 3) = 3; minTotal = min(3+1, 3) = 3; range "3–3"
-        expect(section).toContain("3–3");
-        expect(section).not.toMatch(/\b[6-9]–3\b/);
-        // Must not show original maxGenerate (5) in the formula
-        expect(section).toContain("3 (generate)");
-        expect(section).not.toContain("5 (generate)");
-    });
-    it("embeds UI/E2E confirmation step when isUIOnly=true", () => {
-        const section = buildScopeAssessmentSection(10, 3, true);
-        expect(section).toContain("frontend-only PR");
-        expect(section).toContain("100% UI/E2E");
-        expect(section).not.toContain("Step D — Determine UI vs backend split");
-    });
-    it("embeds UI vs backend split step when isUIOnly=false", () => {
-        const section = buildScopeAssessmentSection(10, 3, false);
-        expect(section).toContain("Step D — Determine UI vs backend split");
-        expect(section).not.toContain("UI/E2E confirmation");
-    });
-    it("uses defaults matching MAX_RECOMMENDATIONS and MAX_TESTS_TO_GENERATE", () => {
-        // Should not throw and should produce a non-empty string
-        const section = buildScopeAssessmentSection();
-        expect(section.length).toBeGreaterThan(0);
-        expect(section).toContain("Budget Plan");
-    });
-    // ---------------------------------------------------------------------------
-    // New branches added in PR 453 (4a) — precomputedUIPct / hasFrontendChanges
-    // ---------------------------------------------------------------------------
-    it("emits a single Budget Plan line for backend-only PR (precomputedUIPct=0)", () => {
-        // isUIOnlyPR=false, hasFrontendChanges=false → precomputedUIPct=0
-        const section = buildScopeAssessmentSection(10, 3, false, 0, false);
-        expect(section).toContain("Budget Plan: 10 total (3 generate + 7 additional), 0% UI/E2E");
-        expect(section).toContain("Use these exact numbers throughout the rest of the prompt.");
-        // Must NOT include the step-based assessment
-        expect(section).not.toContain("Step A");
-        expect(section).not.toContain("Step B");
-        expect(section).not.toContain("Step C");
-        expect(section).not.toContain("Step D");
-    });
-    // ---------------------------------------------------------------------------
-    // SKYR-3820 — zero-classified backend diff: budget defaults to 0
-    // ---------------------------------------------------------------------------
-    it("defaults the Budget Plan to 0 total when precomputedUIPct=0 and hasClassifiedApiChanges=false (SKYR-3820)", () => {
-        const section = buildScopeAssessmentSection(20, 3, false, 0, false, false);
-        expect(section).toContain("Budget Plan: 0 total");
-        // The fixed budget mandate must NOT be asserted
-        expect(section).not.toContain("Budget Plan: 20 total (3 generate + 17 additional)");
-        expect(section).not.toContain("Use these exact numbers throughout the rest of the prompt.");
-        // The conditional ceiling names the numbers the agent may claim after code review
-        expect(section).toContain("up to 20 total (3 generate + 17 additional)");
-    });
-    it("keeps the fixed budget line when hasClassifiedApiChanges is omitted (back-compat default true)", () => {
-        const withDefault = buildScopeAssessmentSection(10, 3, false, 0, false);
-        const explicitTrue = buildScopeAssessmentSection(10, 3, false, 0, false, true);
-        expect(withDefault).toBe(explicitTrue);
-        expect(withDefault).toContain("Budget Plan: 10 total (3 generate + 7 additional), 0% UI/E2E");
-        expect(withDefault).not.toContain("Budget Plan: 0 total");
-    });
-    it("does not apply the zero-classified override to UI-only PRs (precomputedUIPct=100)", () => {
-        // UI-only PRs have hasApiChanges=false by construction — the override must be
-        // gated on the backend branch (precomputedUIPct === 0) only.
-        const section = buildScopeAssessmentSection(10, 3, true, 100, false, false);
-        expect(section).toContain("Budget Plan: 10 total (3 generate + 7 additional), 100% UI/E2E");
-        expect(section).not.toContain("Budget Plan: 0 total");
-    });
-    it("does not apply the zero-classified override to the mixed-PR branch", () => {
-        const section = buildScopeAssessmentSection(10, 3, false, undefined, true, false);
-        expect(section).toContain("Budget Plan (total already determined)");
-        expect(section).toContain("Cosmetic-only override");
-        expect(section).not.toContain("Budget Plan: 0 total");
-    });
-    it("emits a single Budget Plan line for UI-only PR (precomputedUIPct=100)", () => {
-        const section = buildScopeAssessmentSection(10, 3, true, 100, false);
-        expect(section).toContain("Budget Plan: 10 total (3 generate + 7 additional), 100% UI/E2E");
-        expect(section).not.toContain("Step A");
-        expect(section).not.toContain("Step D");
-    });
-    it("emits Step D only for mixed PR (hasFrontendChanges=true, precomputedUIPct=undefined)", () => {
-        const section = buildScopeAssessmentSection(10, 3, false, undefined, true);
-        // Total is pre-determined — shows in the Budget Plan header
-        expect(section).toContain("Budget Plan (total already determined)");
-        expect(section).toContain("10 total (3 generate + 7 additional)");
-        // Step D is kept for UI/E2E split judgment
-        expect(section).toContain("Step D");
-        // The "Append your UI%" instruction must appear (comment #3222061560)
-        expect(section).toContain("Append your UI%");
-        // Steps A–C are skipped
-        expect(section).not.toContain("Step A");
-        expect(section).not.toContain("Step B");
-        expect(section).not.toContain("Step C");
-    });
-    it("offers a cosmetic-only abstention override in the mixed-PR branch", () => {
-        // Regression: a CSS-only diff classifies as frontend (hasFrontendChanges=true),
-        // which previously handed the agent a fixed total with no path to zero tests,
-        // tanking d1 coverage to 0 (eval 14-cart-css-cleanup).
-        const section = buildScopeAssessmentSection(10, 3, false, undefined, true);
-        expect(section).toContain("Cosmetic-only override");
-        expect(section).toContain("0 total");
-        // The override is self-contained: it must NOT depend on a "Task 3" that
-        // doesn't exist in standalone (non-testbot) render contexts, and it must
-        // tell the agent to skip the now-irrelevant UI% step.
-        expect(section).not.toContain("Task 3");
-        expect(section).toContain("skip Step D");
-    });
-    it("clamps additional to 0 when maxGenerate equals maxTotal (precomputed path)", () => {
-        // maxGenerate=5, maxTotal=5 → additional must be 0, not negative
-        const section = buildScopeAssessmentSection(5, 5, false, 0, false);
-        expect(section).toContain("5 generate + 0 additional");
-        expect(section).not.toMatch(/\d+ generate \+ -\d+ additional/);
-    });
-    it("clamps additional to 0 when maxGenerate exceeds maxTotal (defensive, precomputed path)", () => {
-        // Should never happen in normal usage but guard must hold
-        const section = buildScopeAssessmentSection(3, 5, false, 0, false);
-        expect(section).toContain("3 generate + 0 additional");
-        expect(section).not.toMatch(/\+ -\d+ additional/);
-        // Must not show unclamped maxGenerate
-        expect(section).not.toContain("5 generate");
-    });
-    it("clamps generate in mixed PR path when maxGenerate exceeds maxTotal", () => {
-        const section = buildScopeAssessmentSection(3, 5, false, undefined, true);
-        expect(section).toContain("3 generate + 0 additional");
-        expect(section).not.toContain("5 generate");
-        expect(section).not.toMatch(/\+ -\d+ additional/);
-    });
-});

package/build/prompts/test-recommendation/test-recommendation-prompt.test.d.ts

@@ -1 +0,0 @@
-export {};