@skyhook-io/radar-app 1.17.0 → 1.17.1

package/src/utils/viewMemory.test.ts

@@ -0,0 +1,78 @@
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { createViewMemory } from './viewMemory'
+
+afterEach(() => vi.stubGlobal('sessionStorage', undefined))
+
+describe('createViewMemory', () => {
+  it('remembers the last resource kind list for the Resources section', () => {
+    const memory = createViewMemory('/api|ctx')
+    memory.record('resources', '/resources/pods', '?filters=namespace:a&namespaces=x')
+    memory.record('resources', '/resources/services', '?search=web')
+
+    expect(memory.sectionPath('resources')).toBe('/resources/services?search=web')
+  })
+
+  it('never remembers the global namespace pick, the investigation focus or an open drawer', () => {
+    const memory = createViewMemory('/api|ctx')
+    memory.record('resources', '/resources/pods', '?namespaces=a,b&ai-run=r1&resource=a/web&tab=yaml&full=1&problems=failed')
+
+    expect(memory.sectionPath('resources')).toBe('/resources/pods?problems=failed')
+  })
+
+  it('returns to the list, not to a detail view opened on top of it', () => {
+    const memory = createViewMemory('/api|ctx')
+    memory.record('helm', '/helm', '?release=default/web&releaseStorage=secret')
+    memory.record('applications', '/applications', '?health=degraded&app=default/web&view=cost&workload=apps/Deployment/a/web&tab=logs&run=r1')
+    memory.record('cnpg', '/cnpg', '?drawer=cluster:a/db&cat=backups')
+    memory.record('timeline', '/timeline', '?event=e1&activity=warnings')
+
+    expect(memory.sectionPath('helm')).toBe('/helm')
+    expect(memory.sectionPath('applications')).toBe('/applications?health=degraded')
+    expect(memory.sectionPath('cnpg')).toBe('/cnpg?cat=backups')
+    expect(memory.sectionPath('timeline')).toBe('/timeline?activity=warnings')
+  })
+
+  it("keeps only the params that shape that section's list", () => {
+    const memory = createViewMemory('/api|ctx')
+    memory.record('timeline', '/timeline', '?app=default/Deployment/web&scopeNamespaces=default&time=all&whats-new=1')
+    memory.record('topology', '/topology', '?mode=traffic&group=namespace&unknown=x')
+    memory.record('traffic', '/traffic', '?q=web')
+
+    expect(memory.sectionPath('timeline')).toBe('/timeline?app=default%2FDeployment%2Fweb&scopeNamespaces=default&time=all')
+    expect(memory.sectionPath('topology')).toBe('/topology?mode=traffic&group=namespace')
+    expect(memory.sectionPath('traffic')).toBe('/traffic')
+  })
+
+  it('remembers section list routes but not their detail pages', () => {
+    const memory = createViewMemory('/api|ctx')
+    memory.record('gitops', '/gitops', '?health=degraded')
+    memory.record('gitops', '/gitops/argo/argocd/app', '?tab=tree')
+    memory.record('home', '/', '')
+
+    expect(memory.sectionPath('gitops')).toBe('/gitops?health=degraded')
+    expect(memory.sectionPath('home')).toBe('/')
+  })
+
+  it('records a cleared list as no filters, so Clear filters also clears the memory', () => {
+    const memory = createViewMemory('/api|ctx')
+    memory.record('resources', '/resources/pods', '?filters=namespace:a')
+    memory.record('resources', '/resources/pods', '?namespaces=x')
+
+    expect(memory.sectionPath('resources')).toBe('/resources/pods')
+  })
+
+  it('survives a reload of the tab, per cluster, and never reaches a new tab', () => {
+    const items = new Map<string, string>()
+    vi.stubGlobal('sessionStorage', {
+      getItem: (k: string) => items.get(k) ?? null,
+      setItem: (k: string, v: string) => void items.set(k, v),
+    })
+    createViewMemory('/api|ctx').record('timeline', '/timeline', '?activity=warnings')
+
+    expect(createViewMemory('/api|ctx').sectionPath('timeline')).toBe('/timeline?activity=warnings')
+    expect(createViewMemory('/api|other').sectionPath('timeline')).toBeUndefined()
+
+    items.clear()
+    expect(createViewMemory('/api|ctx').sectionPath('timeline')).toBeUndefined()
+  })
+})

package/src/utils/viewMemory.ts

@@ -0,0 +1,54 @@
+import { RESOURCE_LIST_FILTER_PARAMS } from '../components/resources/resource-utils'
+import { RESOURCE_LIST_PATH } from './navigation'
+import { createTabStorage } from './tabStorage'
+
+// The params that shape each section's list. Anything else (the global
+// picker's params, a drawer, a detail opened on top of the list, a one-off
+// modal) belongs to one visit, so a param a view adds later is forgotten until
+// it is listed here. A section that isn't listed returns to its bare path.
+const REMEMBERED: Record<string, readonly string[]> = {
+  resources: ['apiGroup', ...RESOURCE_LIST_FILTER_PARAMS],
+  topology: ['mode', 'group'],
+  timeline: ['view', 'window', 'from', 'to', 'activity', 'kinds', 'deleted', 'routine', 'pinnedOnly', 'q', 'grouping', 'sort', 'app', 'scopeNamespaces', 'time'],
+  gitops: ['q', 'sync', 'health', 'project', 'automation', 'labels', 'lifecycle', 'kind'],
+  applications: ['q', 'health', 'class', 'type', 'env', 'source', 'system'],
+  checks: ['q', 'severity', 'category', 'framework'],
+  cnpg: ['q', 'cat', 'filter'],
+}
+
+function listSearch(view: string, search: string): string {
+  const remembered = REMEMBERED[view] ?? []
+  const params = new URLSearchParams(search)
+  for (const key of [...params.keys()]) {
+    if (!remembered.includes(key)) params.delete(key)
+  }
+  const query = params.toString()
+  return query ? `?${query}` : ''
+}
+
+/**
+ * The tab's last list URL per section, per cluster. The URL stays the source
+ * of truth: entries are recorded from it and restored by navigating back to
+ * them. Kept per tab (see createTabStorage), never shared with other tabs.
+ */
+export function createViewMemory(cluster: string) {
+  const sections = createTabStorage()
+  const sectionKey = (view: string) => `radar-section:${cluster}:${view}`
+
+  return {
+    /** Records a location. Only list routes are remembered, not detail pages. */
+    record(view: string, pathname: string, search: string) {
+      const path = pathname.replace(/\/+$/, '') || '/'
+      const query = listSearch(view, search)
+      const resourceList = view === 'resources' && RESOURCE_LIST_PATH.test(path)
+      if (!resourceList && path !== (view === 'home' ? '/' : `/${view}`)) return
+      sections.set(sectionKey(view), path + query)
+    },
+    /** The section's last list URL, without cross-view params. */
+    sectionPath(view: string): string | undefined {
+      return sections.get(sectionKey(view))
+    },
+  }
+}
+
+export type ViewMemory = ReturnType<typeof createViewMemory>