@skyhook-io/radar-app 1.17.0 → 1.17.1

package/src/components/helm/HelmCompareRoute.tsx

@@ -75,7 +75,8 @@ export function HelmCompareRoute() {
   const right = revisions.find((r) => r.revision === revision2)
 
   const manifestDiff = useHelmManifestDiff(helmNamespace, releaseName, revision1, revision2, pairReady)
-  const valuesDiff = useHelmValuesDiff(helmNamespace, releaseName, revision1, revision2, false, pairReady)
+  const overridesDiff = useHelmValuesDiff(helmNamespace, releaseName, revision1, revision2, false, pairReady)
+  const effectiveValuesDiff = useHelmValuesDiff(helmNamespace, releaseName, revision1, revision2, true, pairReady)
   const notesDiff = useHelmNotesDiff(helmNamespace, releaseName, revision1, revision2, pairReady)
   const hooksDiff = useHelmHooksDiff(helmNamespace, releaseName, revision1, revision2, pairReady)
   const resourceDiff = useHelmResourceDiff(helmNamespace, releaseName, revision1, revision2, pairReady)
@@ -219,7 +220,8 @@ export function HelmCompareRoute() {
                   ['summary', 'Summary'],
                   ['manifest', 'Manifest'],
                   ['resources', 'Resources'],
-                  ['values', 'Values'],
+                  ['effective-values', 'Effective Values'],
+                  ['overrides', 'User Overrides'],
                   ['hooks', 'Hooks'],
                   ['notes', 'Notes'],
                 ].map(([id, label]) => (
@@ -256,9 +258,12 @@ export function HelmCompareRoute() {
                     manifestDiff={manifestDiff.data?.diff}
                     manifestLoading={manifestDiff.isLoading}
                     manifestError={manifestDiff.error}
-                    valuesDiff={valuesDiff.data?.diff}
-                    valuesLoading={valuesDiff.isLoading}
-                    valuesError={valuesDiff.error}
+                    overridesDiff={overridesDiff.data?.diff}
+                    overridesLoading={overridesDiff.isLoading}
+                    overridesError={overridesDiff.error}
+                    effectiveValuesDiff={effectiveValuesDiff.data?.diff}
+                    effectiveValuesLoading={effectiveValuesDiff.isLoading}
+                    effectiveValuesError={effectiveValuesDiff.error}
                     notesDiff={notesDiff.data?.diff}
                     notesLoading={notesDiff.isLoading}
                     notesError={notesDiff.error}
@@ -293,14 +298,25 @@ export function HelmCompareRoute() {
                 />
 
                 <DiffSection
-                  id="values"
+                  id="effective-values"
                   icon={Settings}
-                  title="User-supplied values diff"
-                  description="Only values explicitly supplied to the release are compared here; computed chart defaults can still affect the rendered manifest."
-                  diff={valuesDiff.data?.diff || ''}
-                  isLoading={valuesDiff.isLoading}
-                  error={valuesDiff.error}
-                  emptyLabel="No user-supplied value changes found."
+                  title="Effective values diff"
+                  description="Computed values for each revision are compared here, including that revision's chart defaults and user overrides."
+                  diff={effectiveValuesDiff.data?.diff || ''}
+                  isLoading={effectiveValuesDiff.isLoading}
+                  error={effectiveValuesDiff.error}
+                  emptyLabel="No effective value changes found."
+                />
+
+                <DiffSection
+                  id="overrides"
+                  icon={Settings}
+                  title="User overrides diff"
+                  description="Only values explicitly supplied to each release revision are compared here."
+                  diff={overridesDiff.data?.diff || ''}
+                  isLoading={overridesDiff.isLoading}
+                  error={overridesDiff.error}
+                  emptyLabel="No user override changes found."
                 />
 
                 <HooksDiffSection diff={hooksDiff.data} isLoading={hooksDiff.isLoading} error={hooksDiff.error} />
@@ -485,7 +501,7 @@ function formatRevisionOption(revision: HelmRevision): string {
   return `rev ${revision.revision} - ${revision.status} - ${revision.chart}`
 }
 
-function CompareSummary({
+export function CompareSummary({
   left,
   right,
   revision1,
@@ -493,9 +509,12 @@ function CompareSummary({
   manifestDiff,
   manifestLoading,
   manifestError,
-  valuesDiff,
-  valuesLoading,
-  valuesError,
+  overridesDiff,
+  overridesLoading,
+  overridesError,
+  effectiveValuesDiff,
+  effectiveValuesLoading,
+  effectiveValuesError,
   notesDiff,
   notesLoading,
   notesError,
@@ -513,9 +532,12 @@ function CompareSummary({
   manifestDiff?: string
   manifestLoading: boolean
   manifestError: unknown
-  valuesDiff?: string
-  valuesLoading: boolean
-  valuesError: unknown
+  overridesDiff?: string
+  overridesLoading: boolean
+  overridesError: unknown
+  effectiveValuesDiff?: string
+  effectiveValuesLoading: boolean
+  effectiveValuesError: unknown
   notesDiff?: string
   notesLoading: boolean
   notesError: unknown
@@ -527,7 +549,8 @@ function CompareSummary({
   resourceError: unknown
 }) {
   const manifestStats = diffStats(manifestDiff || '')
-  const valuesStats = diffStats(valuesDiff || '')
+  const overridesStats = diffStats(overridesDiff || '')
+  const effectiveValuesStats = diffStats(effectiveValuesDiff || '')
   const notesStats = diffStats(notesDiff || '')
   const hookChanged = hooksDiff ? hooksDiff.added.length + hooksDiff.removed.length + hooksDiff.modified.length : 0
   const resourceChanged = resourceDiff ? resourceDiff.added.length + resourceDiff.removed.length + resourceDiff.modified.length : 0
@@ -566,12 +589,20 @@ function CompareSummary({
           sectionId="resources"
         />
         <SignalPill
-          label="Values"
-          loading={valuesLoading}
-          error={valuesError}
-          tone={valuesStats.changed ? 'info' : 'neutral'}
-          value={valuesStats.changed ? `${valuesStats.additions} add / ${valuesStats.removals} remove` : 'same'}
-          sectionId="values"
+          label="Effective values"
+          loading={effectiveValuesLoading}
+          error={effectiveValuesError}
+          tone={effectiveValuesStats.changed ? 'info' : 'neutral'}
+          value={effectiveValuesStats.changed ? `${effectiveValuesStats.additions} add / ${effectiveValuesStats.removals} remove` : 'same'}
+          sectionId="effective-values"
+        />
+        <SignalPill
+          label="Overrides"
+          loading={overridesLoading}
+          error={overridesError}
+          tone={overridesStats.changed ? 'info' : 'neutral'}
+          value={overridesStats.changed ? `${overridesStats.additions} add / ${overridesStats.removals} remove` : 'same'}
+          sectionId="overrides"
         />
         <SignalPill
           label="Hooks"

package/src/components/helm/HelmReleaseDrawer.test.ts

@@ -1,9 +1,17 @@
 import { describe, expect, it } from 'vitest'
-import { isUpgradeSourceIssueActionable } from './HelmReleaseDrawer'
+import { DEFAULT_SHOW_EFFECTIVE_VALUES, effectiveHelmStorageNamespace, isUpgradeSourceIssueActionable, upgradePickerVersions } from './HelmReleaseDrawer'
+
+describe('Helm values view', () => {
+  it('opens on user overrides', () => {
+    expect(DEFAULT_SHOW_EFFECTIVE_VALUES).toBe(false)
+  })
+})
 
 describe('isUpgradeSourceIssueActionable', () => {
-  it('keeps classic repository ambiguity informational', () => {
-    expect(isUpgradeSourceIssueActionable('ambiguous_repository')).toBe(false)
+  it('allows explicit association for ambiguous and unavailable sources', () => {
+    expect(isUpgradeSourceIssueActionable('ambiguous_repository')).toBe(true)
+    expect(isUpgradeSourceIssueActionable('ambiguous_source')).toBe(true)
+    expect(isUpgradeSourceIssueActionable('source_unavailable')).toBe(true)
   })
 
   it('lets OCI registration help untracked and repo-index states', () => {
@@ -15,3 +23,47 @@ describe('isUpgradeSourceIssueActionable', () => {
     expect(isUpgradeSourceIssueActionable(undefined)).toBe(false)
   })
 })
+
+describe('effectiveHelmStorageNamespace', () => {
+  it('falls back to the release namespace when storageNamespace is empty', () => {
+    expect(effectiveHelmStorageNamespace({ namespace: 'production', name: 'release', storageNamespace: '' })).toBe('production')
+  })
+
+  it('uses an explicit storage namespace', () => {
+    expect(effectiveHelmStorageNamespace({ namespace: 'production', name: 'release', storageNamespace: 'helm-storage' })).toBe('helm-storage')
+  })
+})
+
+describe('upgradePickerVersions', () => {
+  it('lists the repository versions when the installed one is still published', () => {
+    expect(upgradePickerVersions(['1.5.0', '1.4.0'], '1.4.0')).toEqual([
+      { version: '1.5.0', selectable: true },
+      { version: '1.4.0', selectable: true },
+    ])
+  })
+
+  it('shows a dropped installed version in order but not selectable', () => {
+    expect(upgradePickerVersions(['1.6.0', '1.5.0', '1.3.0'], '1.4.0')).toEqual([
+      { version: '1.6.0', selectable: true },
+      { version: '1.5.0', selectable: true },
+      { version: '1.4.0', selectable: false },
+      { version: '1.3.0', selectable: true },
+    ])
+  })
+
+  it('offers a picker even when only one newer version is left', () => {
+    expect(upgradePickerVersions(['1.5.0'], '1.4.0')).toEqual([
+      { version: '1.5.0', selectable: true },
+      { version: '1.4.0', selectable: false },
+    ])
+  })
+
+  it('puts a dropped version older than every listed one at the end', () => {
+    expect(upgradePickerVersions(['2.1.0', '2.0.0'], '1.0.0')?.at(-1)).toEqual({ version: '1.0.0', selectable: false })
+  })
+
+  it('has nothing to pick with a single published version that is the installed one', () => {
+    expect(upgradePickerVersions(['1.5.0'], '1.5.0')).toBeNull()
+    expect(upgradePickerVersions(undefined, '1.5.0')).toBeNull()
+  })
+})

package/src/components/helm/HelmReleaseDrawer.tsx

@@ -37,6 +37,10 @@ interface HelmReleaseDrawerProps {
   rightInset?: number
 }
 
+export function effectiveHelmStorageNamespace(release: SelectedHelmRelease): string {
+  return release.storageNamespace || release.namespace
+}
+
 type TabId = 'overview' | 'history' | 'manifest' | 'values' | 'resources' | 'hooks'
 
 interface UpgradePreviewRequest {
@@ -51,7 +55,7 @@ interface ParsedUpgradeValues {
 }
 
 type UpgradeSourceIssue = NonNullable<UpgradeInfo['sourceIssue']>
-type ActionableUpgradeSourceIssue = Exclude<UpgradeSourceIssue, 'ambiguous_repository'>
+type ActionableUpgradeSourceIssue = UpgradeSourceIssue
 
 function getUpgradeSourceIssue(upgradeInfo: UpgradeInfo): UpgradeSourceIssue | undefined {
   return upgradeInfo.sourceIssue
@@ -63,6 +67,10 @@ function getUpgradeSourceIssueLabel(issue: UpgradeSourceIssue) {
       return 'upgrade source blocked'
     case 'ambiguous_repository':
       return 'upgrade source ambiguous'
+    case 'ambiguous_source':
+      return 'upgrade source ambiguous'
+    case 'source_unavailable':
+      return 'recorded source unavailable'
     case 'untracked':
       return 'upgrade source not tracked'
   }
@@ -77,6 +85,10 @@ function getUpgradeSourceIssueTooltip(issue: UpgradeSourceIssue, error: string |
       return 'A configured Helm repo index failed. Fix or refresh that repo, or register an OCI prefix if this chart came from OCI.'
     case 'ambiguous_repository':
       return 'Multiple configured Helm repos match this chart. Fix the repo list or source metadata so Radar can identify one source.'
+    case 'ambiguous_source':
+      return 'Multiple configured sources match this chart. Select the original source explicitly.'
+    case 'source_unavailable':
+      return 'The recorded source is not configured or cannot verify the installed chart version on this Radar installation.'
     case 'untracked':
       return "Radar can't tell where this chart was installed from. Register an OCI chart source to track upgrades."
   }
@@ -96,12 +108,34 @@ function parseUpgradeValuesYaml(raw: string): ParsedUpgradeValues {
 }
 
 export function isUpgradeSourceIssueActionable(issue: UpgradeInfo['sourceIssue']): issue is ActionableUpgradeSourceIssue {
-  return Boolean(issue && issue !== 'ambiguous_repository')
+  return Boolean(issue)
+}
+
+export interface UpgradePickerVersion {
+  version: string
+  // False for the installed version once the repository no longer publishes it:
+  // it is shown for orientation but can't be picked.
+  selectable: boolean
+}
+
+// Versions for the upgrade picker, newest first as the server returns them.
+// When the repository dropped the installed version, it is slotted in by
+// version order as a non-selectable entry so the user still sees where they are.
+// Returns null when there is nothing to choose between.
+export function upgradePickerVersions(available: string[] | undefined, current: string | undefined): UpgradePickerVersion[] | null {
+  if (!available) return null
+  const entries: UpgradePickerVersion[] = available.map(version => ({ version, selectable: true }))
+  if (current && !available.includes(current)) {
+    const olderIndex = available.findIndex(v => compareVersions(v, current) === -1)
+    entries.splice(olderIndex === -1 ? entries.length : olderIndex, 0, { version: current, selectable: false })
+  }
+  return entries.length > 1 ? entries : null
 }
 
 const MIN_WIDTH = 500
 const MAX_WIDTH_PERCENT = 0.8
 const DEFAULT_WIDTH = 1000
+export const DEFAULT_SHOW_EFFECTIVE_VALUES = false
 
 export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOpen = true, rightInset = 0 }: HelmReleaseDrawerProps) {
   const navigate = useNavigate()
@@ -111,7 +145,7 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
   const [viewportWidth, setViewportWidth] = useState(() => (typeof window === 'undefined' ? DEFAULT_WIDTH : window.innerWidth))
   const [isResizing, setIsResizing] = useState(false)
   const [selectedRevision, setSelectedRevision] = useState<number | undefined>(undefined)
-  const [showAllValues, setShowAllValues] = useState(false)
+  const [showEffectiveValues, setShowEffectiveValues] = useState(DEFAULT_SHOW_EFFECTIVE_VALUES)
   const [rollbackRevision, setRollbackRevision] = useState<number | null>(null)
   const [showUninstallConfirm, setShowUninstallConfirm] = useState(false)
   const [showUpgradeConfirm, setShowUpgradeConfirm] = useState(false)
@@ -128,7 +162,7 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
   const resizeStartWidth = useRef(DEFAULT_WIDTH)
   const targetVersionRef = useRef('')
   const editedUpgradeYamlRef = useRef('')
-  const helmNamespace = release.storageNamespace || release.namespace
+  const helmNamespace = effectiveHelmStorageNamespace(release)
   const { allowed: canHelmWrite, reason: helmActReason } = useCanHelmAct(helmNamespace)
 
   const { data: releaseDetail, isLoading, error: releaseError, refetch: refetchRelease } = useHelmRelease(
@@ -145,10 +179,10 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
   )
 
   // Fetch values
-  const { data: values, isLoading: valuesLoading } = useHelmValues(
+  const { data: values, isLoading: valuesLoading, error: valuesError, refetch: refetchValues } = useHelmValues(
     helmNamespace,
     release.name,
-    showAllValues,
+    true,
     true,
     selectedRevision,
   )
@@ -179,7 +213,7 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
     error: availableVersionsError,
   } = useHelmReleaseVersions(helmNamespace, release.name, showUpgradeConfirm)
   const targetVersion = selectedVersion ?? upgradeInfo?.latestVersion ?? ''
-  const selectableVersions = availableVersions && availableVersions.length > 1 ? availableVersions : null
+  const selectableVersions = upgradePickerVersions(availableVersions, upgradeInfo?.currentVersion)
   // Semver compare, not list-position: the installed version may be older than
   // the newest-N versions the picker shows, so it isn't always in the list.
   const isDowngrade = Boolean(
@@ -735,8 +769,9 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
               <ValuesViewer
                 values={values}
                 isLoading={valuesLoading}
-                showAllValues={showAllValues}
-                onToggleAllValues={setShowAllValues}
+                error={valuesError}
+                showEffectiveValues={showEffectiveValues}
+                onToggleEffectiveValues={setShowEffectiveValues}
                 onCopy={(text) => copyToClipboard(text, 'values')}
                 copied={copied === 'values'}
                 namespace={helmNamespace}
@@ -744,6 +779,7 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
                 revision={selectedRevision}
                 currentRevision={releaseDetail.revision}
                 onApplySuccess={() => refetch()}
+                onRetry={() => void refetchValues()}
               />
             )}
             {activeTab === 'resources' && (
@@ -853,11 +889,11 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
                 disabled={isUpgrading || isPreviewingUpgrade}
                 className="w-full px-3 py-2 bg-theme-elevated border border-theme-border-light rounded-lg text-sm text-theme-text-primary focus:outline-none focus:ring-2 focus:ring-accent disabled:opacity-50"
               >
-                {selectableVersions.map((v) => (
-                  <option key={v} value={v}>
+                {selectableVersions.map(({ version: v, selectable }) => (
+                  <option key={v} value={v} disabled={!selectable}>
                     {v}
                     {v === upgradeInfo?.latestVersion ? ' (latest)' : ''}
-                    {v === upgradeInfo?.currentVersion ? ' (current)' : ''}
+                    {v === upgradeInfo?.currentVersion ? (selectable ? ' (current)' : ' (current, no longer in the repository)') : ''}
                   </option>
                 ))}
               </select>
@@ -986,6 +1022,8 @@ export function HelmReleaseDrawer({ release, onClose, onNavigateToResource, isOp
         open={showTrackSource}
         onClose={() => setShowTrackSource(false)}
         chartName={releaseDetail?.chart}
+        namespace={helmNamespace}
+        releaseName={release.name}
         sourceIssue={upgradeSourceIssue}
         sourceError={upgradeInfo?.error}
       />

package/src/components/helm/TrackChartSourceDialog.render.test.tsx

@@ -0,0 +1,120 @@
+// @vitest-environment jsdom
+import { act, type InputHTMLAttributes, type ReactNode } from 'react'
+import { createRoot, type Root } from 'react-dom/client'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import type { ChartSourceStatus, HelmRepository } from '../../types'
+import { TrackChartSourceDialog } from './TrackChartSourceDialog'
+
+const state = vi.hoisted(() => ({
+  status: undefined as ChartSourceStatus | undefined,
+  repositories: [] as HelmRepository[],
+  isOwner: true,
+  addRepository: vi.fn(),
+}))
+
+vi.mock('@skyhook-io/k8s-ui/components/ui/DialogPortal', () => ({
+  DialogPortal: ({ open, children }: { open: boolean; children: ReactNode }) => (open ? <div>{children}</div> : null),
+}))
+vi.mock('@skyhook-io/k8s-ui', () => ({
+  Input: (props: InputHTMLAttributes<HTMLInputElement>) => <input {...props} />,
+}))
+vi.mock('../settings/OperatorManagedNotice', () => ({ OperatorManagedNotice: () => null }))
+vi.mock('../../api/client', () => {
+  const idle = { mutate: vi.fn(), mutateAsync: vi.fn(), isPending: false }
+  return {
+    useHelmSourceStatus: () => ({ data: state.status, error: null, refetch: vi.fn() }),
+    useHelmRepositories: () => ({ data: state.repositories, isLoading: false }),
+    useHelmOCISources: () => ({ data: [] }),
+    useClusterInfo: () => ({ data: { inCluster: false } }),
+    useCapabilities: () => ({ data: { configManagement: 'local' } }),
+    useCloudRole: () => ({ canAtLeast: () => state.isOwner }),
+    useAddHelmRepository: () => ({ mutate: state.addRepository, isPending: false }),
+    useAddOCISource: () => idle,
+    useRemoveOCISource: () => idle,
+    useSetHelmSource: () => idle,
+  }
+})
+
+Object.assign(globalThis, { IS_REACT_ACT_ENVIRONMENT: true })
+
+const recordedURL = 'https://stefanprodan.github.io/podinfo'
+const movedMachine: ChartSourceStatus = {
+  recorded: { type: 'repository', reference: 'podinfo', url: recordedURL },
+  configured: false,
+  available: false,
+}
+
+let root: Root
+
+beforeEach(() => {
+  state.status = movedMachine
+  state.repositories = []
+  state.isOwner = true
+  state.addRepository.mockReset()
+  const element = document.createElement('div')
+  document.body.appendChild(element)
+  root = createRoot(element)
+})
+
+afterEach(async () => {
+  await act(async () => root.unmount())
+  document.body.replaceChildren()
+})
+
+async function renderDialog() {
+  await act(async () => root.render(<TrackChartSourceDialog open onClose={() => undefined} chartName="podinfo" namespace="web" releaseName="storefront" />))
+}
+
+function addRecordedButton() {
+  return Array.from(document.querySelectorAll('button')).find(button => button.textContent?.includes('and use it'))
+}
+
+describe('TrackChartSourceDialog one-click add of the recorded repository', () => {
+  it('adds the recorded URL under the recorded name when that name is free', async () => {
+    await renderDialog()
+    const button = addRecordedButton()
+    expect(button?.textContent).toBe('Add stefanprodan.github.io/podinfo and use it')
+    expect(button?.disabled).toBe(false)
+    expect(document.body.textContent).toContain('Saved in Helm as podinfo, the name it was recorded under.')
+
+    await act(async () => button?.click())
+    expect(state.addRepository).toHaveBeenCalledWith(
+      { name: 'podinfo', url: recordedURL, namespace: 'web', releaseName: 'storefront' },
+      expect.anything(),
+    )
+  })
+
+  it('never reuses a recorded name that points at a different repository here', async () => {
+    state.repositories = [
+      { name: 'podinfo', url: 'https://impostor.example.test/charts' },
+      { name: 'podinfo-2', url: 'https://other.example.test' },
+    ]
+    await renderDialog()
+    expect(document.body.textContent).toContain('Saved in Helm as podinfo-3. The name podinfo already points to a different repository here.')
+
+    await act(async () => addRecordedButton()?.click())
+    expect(state.addRepository).toHaveBeenCalledWith(
+      { name: 'podinfo-3', url: recordedURL, namespace: 'web', releaseName: 'storefront' },
+      expect.anything(),
+    )
+  })
+
+  it('is disabled for a non-owner, who is told who can add sources', async () => {
+    state.isOwner = false
+    await renderDialog()
+    expect(addRecordedButton()?.disabled).toBe(true)
+    expect(document.body.textContent).toContain('Only organization owners can add or remove chart sources.')
+  })
+
+  it('is not offered when the recorded source is configured, OCI, or not recorded', async () => {
+    for (const status of [
+      { ...movedMachine, configured: true },
+      { recorded: { type: 'oci' as const, reference: 'oci://ghcr.io/example/charts' }, configured: false, available: false },
+      { configured: false, available: false },
+    ]) {
+      state.status = status
+      await renderDialog()
+      expect(addRecordedButton()).toBeUndefined()
+    }
+  })
+})

package/src/components/helm/TrackChartSourceDialog.test.ts

@@ -0,0 +1,50 @@
+import { describe, expect, it } from 'vitest'
+import { getSourceIssueCopy, isValidHelmRepositoryURL, normalizedRepositoryName, recordedRepositoryName, repositoryDisplayURL, sourceStateLabel, sourceStatusLine } from './TrackChartSourceDialog'
+
+describe('chart source recovery presentation', () => {
+  it('keeps recorded, configured, and available states distinct', () => {
+    expect(sourceStateLabel(false, false, false)).toBe('Not recorded')
+    expect(sourceStateLabel(true, false, false)).toBe('Recorded · not configured here')
+    expect(sourceStateLabel(true, true, false)).toBe('Recorded and configured · unavailable or version missing')
+    expect(sourceStateLabel(true, true, true)).toBe('Recorded · configured · available')
+  })
+
+  it('claims nothing about the recorded source until it has been read', () => {
+    expect(sourceStatusLine(undefined, undefined)).toBe('Checking the recorded source...')
+    expect(sourceStatusLine(undefined, new Error('failed to load repo file'))).toBe("Could not read this release's source: failed to load repo file")
+    expect(sourceStatusLine({ configured: false, available: false }, new Error('refetch failed'))).toBe('Not recorded')
+    expect(sourceStatusLine({ recorded: { type: 'repository', reference: 'repo', url: 'https://charts.example.test' }, configured: false, available: false }, undefined)).toBe('Recorded · not configured here')
+  })
+
+  it('makes ambiguity explicit rather than selecting a source', () => {
+    expect(getSourceIssueCopy('ambiguous_source')?.body).toContain('will not guess')
+  })
+
+  it('accepts only HTTP repository URLs', () => {
+    expect(isValidHelmRepositoryURL('https://charts.example.test')).toBe(true)
+    expect(isValidHelmRepositoryURL('oci://registry.example.test/charts')).toBe(false)
+  })
+
+  it('picks a free local name for the recorded repository', () => {
+    expect(recordedRepositoryName('podinfo', [])).toBe('podinfo')
+    expect(recordedRepositoryName('podinfo', [{ name: 'Podinfo', url: 'https://impostor.example.test' }])).toBe('podinfo-2')
+    expect(recordedRepositoryName('podinfo', [{ name: 'podinfo', url: 'a' }, { name: 'podinfo-2', url: 'b' }])).toBe('podinfo-3')
+  })
+
+  it('checks names the way the server stores them', () => {
+    expect(normalizedRepositoryName(' My Charts! ')).toBe('my-charts')
+    const alias40 = 'a'.repeat(40)
+    expect(recordedRepositoryName(alias40, [{ name: alias40, url: 'a' }])).toBe(`${'a'.repeat(38)}-2`)
+    // A longer alias is stored cut to 40 characters, so that is the name that collides.
+    const alias45 = `${'b'.repeat(40)}extra`
+    expect(recordedRepositoryName(alias45, [])).toBe('b'.repeat(40))
+    expect(recordedRepositoryName(alias45, [{ name: 'b'.repeat(40), url: 'a' }])).toBe(`${'b'.repeat(38)}-2`)
+    expect(recordedRepositoryName('My_Repo', [{ name: 'my_repo', url: 'a' }])).toBe('my_repo-2')
+    expect(recordedRepositoryName('___', [])).toBe('')
+  })
+
+  it('shortens repository URLs for labels', () => {
+    expect(repositoryDisplayURL('https://stefanprodan.github.io/podinfo/')).toBe('stefanprodan.github.io/podinfo')
+    expect(repositoryDisplayURL('https://charts.example.test')).toBe('charts.example.test')
+  })
+})