@skillsmith/core 0.9.0 → 0.10.0

package/dist/src/install/agent-pack-installer.js

@@ -0,0 +1,221 @@
+/**
+ * `sklx agent install` core orchestration (SMI-5456 Wave 1 Step 5).
+ *
+ * Generates the pack via `generateAgentPack({ toolProfile: AGENT_TOOL_PROFILE_NAMES })`
+ * (QD-2: byte-identical to the committed `packages/mcp-server/src/assets/agent-pack/`
+ * tree by determinism, never read from the mcp-server package) and writes:
+ *   - SKILL.md to the mandatory dual path (claude-code + agents) plus any
+ *     detected Tier-2/3 harness with its own native skill directory
+ *     (opencode, hermes, windsurf).
+ *   - Named-agent shims for every detected harness with a shim target
+ *     (claude-code always; copilot, opencode when detected; codex via its
+ *     own TOML-merge "shim").
+ *   - SessionStart/SessionEnd hooks (+x) for claude-code (always), cursor
+ *     and codex when detected — hook CONFIG wiring ships for claude-code/
+ *     cursor (JSON arrays) and codex (SessionStart ONLY, as a
+ *     marker-delimited `[[hooks.SessionStart]]` TOML block; Codex has no
+ *     SessionEnd event and its Stop event is per-turn — see
+ *     `installCodexHooks` in `agent-pack-installer.harness.ts`).
+ *   - The `skillsmith` MCP server registration (`SKILLSMITH_TOOL_PROFILE=agent`)
+ *     for every detected MCP-capable harness (all 7), backup-first,
+ *     idempotent, preserve-and-prompt on a foreign entry.
+ *
+ * Every write funnels through `writeOwnedArtifactFile` (owned files) or the
+ * `agent-config-merge.*` helpers (shared config files), both of which record
+ * a manifest entry — `uninstallAgentPack` (SMI-5456) reverses exactly what
+ * this function wrote by replaying that manifest, never by re-deriving
+ * "what the current generator would produce".
+ *
+ * @module @skillsmith/core/install/agent-pack-installer
+ */
+import { existsSync } from 'node:fs';
+import { homedir } from 'node:os';
+import { join } from 'node:path';
+import { AGENT_PACK_SKILL_NAME, generateAgentPack } from '../services/agent-pack/index.js';
+import { AGENT_TOOL_PROFILE_NAMES } from '../services/agent-tool-profile.js';
+import { CLIENT_NATIVE_PATHS } from './paths.js';
+import { relocateUnderHome } from './agent-home-relocate.js';
+import { writeOwnedArtifactFile } from './agent-pack-installer.fs-helpers.js';
+import { getAgentInstallBackupsDir, getAgentManifestPath, loadAgentManifest, saveAgentManifest, } from './agent-manifest.js';
+import { installCodexAgentsShim, installCodexHooks, installJsonHooks, installMcpConfig, installShim, } from './agent-pack-installer.harness.js';
+import { HARNESS_SUPPORT_TIER, } from './agent-pack-installer.types.js';
+/** Harnesses considered for the SKILL.md pack copy beyond the mandatory dual path. */
+const OPTIONAL_SKILL_PACK_HARNESSES = ['windsurf', 'opencode', 'hermes'];
+function isPresent(nativePath, homeDir) {
+    return existsSync(relocateUnderHome(nativePath, homeDir));
+}
+function isCodexPresent(homeDir) {
+    return existsSync(relocateUnderHome(join(homedir(), '.codex'), homeDir));
+}
+/** Write the SKILL.md pack to one client's native skill directory (`<dir>/skillsmith-agent/SKILL.md`). */
+function writeSkillPackFor(clientNativePath, content, ctx, harness) {
+    const path = join(relocateUnderHome(clientNativePath, ctx.homeDir), AGENT_PACK_SKILL_NAME, 'SKILL.md');
+    const result = writeOwnedArtifactFile({
+        path,
+        content,
+        executable: false,
+        backupDir: ctx.backupDir,
+    });
+    ctx.entries.push({
+        path,
+        kind: 'skill',
+        harness,
+        backupPath: result.backupPath,
+        executable: false,
+    });
+}
+function newReport(harness) {
+    return {
+        harness,
+        tier: HARNESS_SUPPORT_TIER[harness] ?? 3,
+        detected: false,
+        skillPackWritten: false,
+        shimWritten: false,
+        hooksInstalled: false,
+        mcpConfig: null,
+        hookConfig: [],
+        notes: [],
+    };
+}
+/**
+ * Carry forward pre-install backup references from a PRIOR install so a
+ * re-install cannot silently strand them.
+ *
+ * A re-install takes NO fresh backup for a path whose owned-file content
+ * already matches, nor for a shared-config merge that is a no-op — so this
+ * run's freshly-built `entries` record `backupPath: null` for those paths.
+ * Persisting that as-is would overwrite the prior manifest's genuine
+ * pre-install backup ref with null, and `uninstallAgentPack` would then treat
+ * a MODIFIED pre-existing file (e.g. a `~/.claude/settings.json` the user
+ * already had) as "created fresh" and DELETE it instead of restoring it —
+ * silent user-data loss on the `install → install → uninstall` sequence
+ * (SMI-5456 adversarial-review fix, verified by the double-install reversal
+ * test).
+ *
+ * The prior manifest's `backupPath` is the authoritative restore target for a
+ * path (the true pre-FIRST-install content), so it WINS over any fresh backup
+ * this run may have taken — a mid-lifecycle backup captured on a version-bump
+ * re-install would itself contain our own already-merged blocks. `uninstall`
+ * clears the manifest to `entries: []`, so an install-AFTER-uninstall carries
+ * nothing forward (this run's fresh backups win); only a re-install WITHOUT an
+ * intervening uninstall reaches this path. A prior ref whose backup file no
+ * longer exists is ignored (nothing to restore from).
+ */
+function carryForwardPriorBackups(entries) {
+    const priorBackupByPath = new Map();
+    for (const prior of loadAgentManifest().entries) {
+        if (prior.backupPath && existsSync(prior.backupPath)) {
+            priorBackupByPath.set(prior.path, prior.backupPath);
+        }
+    }
+    if (priorBackupByPath.size === 0)
+        return entries;
+    return entries.map((entry) => {
+        const carried = priorBackupByPath.get(entry.path);
+        return carried ? { ...entry, backupPath: carried } : entry;
+    });
+}
+/**
+ * Detect + install the portable Skillsmith Agent pack across every
+ * supported harness. See module header for the full per-harness matrix.
+ */
+export function installAgentPack(opts = {}) {
+    const homeDir = opts.homeDir;
+    const force = opts.force ?? false;
+    // Manifest/backups dir isolation for tests is via SKILLSMITH_AGENT_INSTALL_DIR
+    // (agent-manifest.ts), not `homeDir` — kept separate from harness-target
+    // relocation so a test can isolate manifest state without needing a full
+    // fake HOME tree.
+    const backupDir = getAgentInstallBackupsDir();
+    const entries = [];
+    const ctx = {
+        homeDir,
+        force,
+        backupDir,
+        entries,
+        backedUpPaths: new Set(),
+    };
+    const artifacts = generateAgentPack({ toolProfile: AGENT_TOOL_PROFILE_NAMES });
+    const skillArtifact = artifacts.find((a) => a.kind === 'skill');
+    const shimByHarness = new Map(artifacts.filter((a) => a.kind === 'shim').map((a) => [a.harness, a]));
+    const hookStartByHarness = new Map(artifacts
+        .filter((a) => a.kind === 'hook' && a.path.endsWith('session-start.sh'))
+        .map((a) => [a.harness, a]));
+    const hookEndByHarness = new Map(artifacts
+        .filter((a) => a.kind === 'hook' && a.path.endsWith('session-end.sh'))
+        .map((a) => [a.harness, a]));
+    const detected = {
+        'claude-code': true, // canonical client — always on, mirrors CANONICAL_CLIENT in paths.ts
+        cursor: isPresent(CLIENT_NATIVE_PATHS.cursor, homeDir),
+        copilot: isPresent(CLIENT_NATIVE_PATHS.copilot, homeDir),
+        windsurf: isPresent(CLIENT_NATIVE_PATHS.windsurf, homeDir),
+        opencode: isPresent(CLIENT_NATIVE_PATHS.opencode, homeDir),
+        hermes: isPresent(CLIENT_NATIVE_PATHS.hermes, homeDir),
+        codex: isCodexPresent(homeDir),
+    };
+    const reports = [];
+    const harnessIds = [
+        'claude-code',
+        'cursor',
+        'codex',
+        'copilot',
+        'opencode',
+        'hermes',
+        'windsurf',
+    ];
+    for (const harness of harnessIds) {
+        const report = newReport(harness);
+        report.detected = detected[harness];
+        const active = report.detected;
+        // Skill pack: mandatory dual path regardless of "detected"; optional
+        // harnesses only when detected.
+        if (harness === 'claude-code' && skillArtifact) {
+            writeSkillPackFor(CLIENT_NATIVE_PATHS['claude-code'], skillArtifact.content, ctx, harness);
+            report.skillPackWritten = true;
+        }
+        if (active &&
+            OPTIONAL_SKILL_PACK_HARNESSES.includes(harness) &&
+            skillArtifact) {
+            const nativePath = CLIENT_NATIVE_PATHS[harness];
+            writeSkillPackFor(nativePath, skillArtifact.content, ctx, harness);
+            report.skillPackWritten = true;
+        }
+        if (harness === 'claude-code' || active) {
+            if (harness === 'claude-code' || harness === 'copilot' || harness === 'opencode') {
+                installShim(harness, shimByHarness.get(harness), ctx, report);
+            }
+            if (harness === 'claude-code' || harness === 'cursor') {
+                installJsonHooks(harness, hookStartByHarness.get(harness), hookEndByHarness.get(harness), ctx, report);
+            }
+            if (harness === 'codex') {
+                installCodexHooks(hookStartByHarness.get('codex'), hookEndByHarness.get('codex'), ctx, report);
+                installCodexAgentsShim(shimByHarness.get('codex'), ctx, report);
+            }
+            // `harnessIds` is exactly the 7-member McpHarnessId union (all harnesses
+            // considered here support MCP registration) — safe direct cast.
+            installMcpConfig(harness, ctx, report);
+        }
+        reports.push(report);
+    }
+    // Mandatory dual path for the second (agents) leg — reported alongside
+    // claude-code's entry rather than as an 8th standalone harness row, since
+    // ~/.agents/skills is a shared open-standard convention, not a harness of
+    // its own (Codex's OWN report row covers its config/hook/shim surface).
+    if (skillArtifact) {
+        writeSkillPackFor(CLIENT_NATIVE_PATHS.agents, skillArtifact.content, ctx, 'agents');
+    }
+    saveAgentManifest({
+        schemaVersion: 1,
+        installedAt: new Date().toISOString(),
+        packSchemaVersion: 1,
+        entries: carryForwardPriorBackups(entries),
+    });
+    return {
+        installedAt: new Date().toISOString(),
+        manifestPath: getAgentManifestPath(),
+        harnessReports: reports,
+    };
+}
+// Re-export so callers (CLI) don't need a second import for manifest inspection.
+export { loadAgentManifest };
+//# sourceMappingURL=agent-pack-installer.js.map

package/dist/src/install/agent-pack-installer.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-pack-installer.js","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA6BG;AAEH,OAAO,EAAE,UAAU,EAAE,MAAM,SAAS,CAAA;AACpC,OAAO,EAAE,OAAO,EAAE,MAAM,SAAS,CAAA;AACjC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAA;AAEhC,OAAO,EAAE,qBAAqB,EAAE,iBAAiB,EAAE,MAAM,iCAAiC,CAAA;AAC1F,OAAO,EAAE,wBAAwB,EAAE,MAAM,mCAAmC,CAAA;AAC5E,OAAO,EAAE,mBAAmB,EAAE,MAAM,YAAY,CAAA;AAChD,OAAO,EAAE,iBAAiB,EAAE,MAAM,0BAA0B,CAAA;AAC5D,OAAO,EAAE,sBAAsB,EAAE,MAAM,sCAAsC,CAAA;AAC7E,OAAO,EACL,yBAAyB,EACzB,oBAAoB,EACpB,iBAAiB,EACjB,iBAAiB,GAElB,MAAM,qBAAqB,CAAA;AAC5B,OAAO,EACL,sBAAsB,EACtB,iBAAiB,EACjB,gBAAgB,EAChB,gBAAgB,EAChB,WAAW,GAEZ,MAAM,mCAAmC,CAAA;AAC1C,OAAO,EACL,oBAAoB,GAIrB,MAAM,iCAAiC,CAAA;AAExC,sFAAsF;AACtF,MAAM,6BAA6B,GAAG,CAAC,UAAU,EAAE,UAAU,EAAE,QAAQ,CAAU,CAAA;AAEjF,SAAS,SAAS,CAAC,UAAkB,EAAE,OAA2B;IAChE,OAAO,UAAU,CAAC,iBAAiB,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,CAAA;AAC3D,CAAC;AAED,SAAS,cAAc,CAAC,OAA2B;IACjD,OAAO,UAAU,CAAC,iBAAiB,CAAC,IAAI,CAAC,OAAO,EAAE,EAAE,QAAQ,CAAC,EAAE,OAAO,CAAC,CAAC,CAAA;AAC1E,CAAC;AAED,0GAA0G;AAC1G,SAAS,iBAAiB,CACxB,gBAAwB,EACxB,OAAe,EACf,GAAsB,EACtB,OAAe;IAEf,MAAM,IAAI,GAAG,IAAI,CACf,iBAAiB,CAAC,gBAAgB,EAAE,GAAG,CAAC,OAAO,CAAC,EAChD,qBAAqB,EACrB,UAAU,CACX,CAAA;IACD,MAAM,MAAM,GAAG,sBAAsB,CAAC;QACpC,IAAI;QACJ,OAAO;QACP,UAAU,EAAE,KAAK;QACjB,SAAS,EAAE,GAAG,CAAC,SAAS;KACzB,CAAC,CAAA;IACF,GAAG,CAAC,OAAO,CAAC,IAAI,CAAC;QACf,IAAI;QACJ,IAAI,EAAE,OAAO;QACb,OAAO;QACP,UAAU,EAAE,MAAM,CAAC,UAAU;QAC7B,UAAU,EAAE,KAAK;KAClB,CAAC,CAAA;AACJ,CAAC;AAED,SAAS,SAAS,CAAC,OAAe;IAChC,OAAO;QACL,OAAO;QACP,IAAI,EAAE,oBAAoB,CAAC,OAAO,CAAC,IAAI,CAAC;QACxC,QAAQ,EAAE,KAAK;QACf,gBAAgB,EAAE,KAAK;QACvB,WAAW,EAAE,KAAK;QAClB,cAAc,EAAE,KAAK;QACrB,SAAS,EAAE,IAAI;QACf,UAAU,EAAE,EAAE;QACd,KAAK,EAAE,EAAE;KACV,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,SAAS,wBAAwB,CAAC,OAA6B;IAC7D,MAAM,iBAAiB,GAAG,IAAI,GAAG,EAAkB,CAAA;IACnD,KAAK,MAAM,KAAK,IAAI,iBAAiB,EAAE,CAAC,OAAO,EAAE,CAAC;QAChD,IAAI,KAAK,CAAC,UAAU,IAAI,UAAU,CAAC,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC;YACrD,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,EAAE,KAAK,CAAC,UAAU,CAAC,CAAA;QACrD,CAAC;IACH,CAAC;IACD,IAAI,iBAAiB,CAAC,IAAI,KAAK,CAAC;QAAE,OAAO,OAAO,CAAA;IAChD,OAAO,OAAO,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE;QAC3B,MAAM,OAAO,GAAG,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAA;QACjD,OAAO,OAAO,CAAC,CAAC,CAAC,EAAE,GAAG,KAAK,EAAE,UAAU,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC,KAAK,CAAA;IAC5D,CAAC,CAAC,CAAA;AACJ,CAAC;AAED;;;GAGG;AACH,MAAM,UAAU,gBAAgB,CAAC,OAA4B,EAAE;IAC7D,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAA;IAC5B,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,IAAI,KAAK,CAAA;IACjC,+EAA+E;IAC/E,yEAAyE;IACzE,yEAAyE;IACzE,kBAAkB;IAClB,MAAM,SAAS,GAAG,yBAAyB,EAAE,CAAA;IAC7C,MAAM,OAAO,GAAyB,EAAE,CAAA;IACxC,MAAM,GAAG,GAAsB;QAC7B,OAAO;QACP,KAAK;QACL,SAAS;QACT,OAAO;QACP,aAAa,EAAE,IAAI,GAAG,EAAU;KACjC,CAAA;IAED,MAAM,SAAS,GAAG,iBAAiB,CAAC,EAAE,WAAW,EAAE,wBAAwB,EAAE,CAAC,CAAA;IAC9E,MAAM,aAAa,GAAG,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,OAAO,CAAC,CAAA;IAC/D,MAAM,aAAa,GAAG,IAAI,GAAG,CAC3B,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CACtE,CAAA;IACD,MAAM,kBAAkB,GAAG,IAAI,GAAG,CAChC,SAAS;SACN,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,MAAM,IAAI,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,kBAAkB,CAAC,CAAC;SACvE,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAC9B,CAAA;IACD,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAC9B,SAAS;SACN,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,MAAM,IAAI,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,gBAAgB,CAAC,CAAC;SACrE,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,CAC9B,CAAA;IAED,MAAM,QAAQ,GAAG;QACf,aAAa,EAAE,IAAI,EAAE,qEAAqE;QAC1F,MAAM,EAAE,SAAS,CAAC,mBAAmB,CAAC,MAAM,EAAE,OAAO,CAAC;QACtD,OAAO,EAAE,SAAS,CAAC,mBAAmB,CAAC,OAAO,EAAE,OAAO,CAAC;QACxD,QAAQ,EAAE,SAAS,CAAC,mBAAmB,CAAC,QAAQ,EAAE,OAAO,CAAC;QAC1D,QAAQ,EAAE,SAAS,CAAC,mBAAmB,CAAC,QAAQ,EAAE,OAAO,CAAC;QAC1D,MAAM,EAAE,SAAS,CAAC,mBAAmB,CAAC,MAAM,EAAE,OAAO,CAAC;QACtD,KAAK,EAAE,cAAc,CAAC,OAAO,CAAC;KAC/B,CAAA;IAED,MAAM,OAAO,GAA2B,EAAE,CAAA;IAC1C,MAAM,UAAU,GAAG;QACjB,aAAa;QACb,QAAQ;QACR,OAAO;QACP,SAAS;QACT,UAAU;QACV,QAAQ;QACR,UAAU;KACF,CAAA;IAEV,KAAK,MAAM,OAAO,IAAI,UAAU,EAAE,CAAC;QACjC,MAAM,MAAM,GAAG,SAAS,CAAC,OAAO,CAAC,CAAA;QACjC,MAAM,CAAC,QAAQ,GAAG,QAAQ,CAAC,OAAO,CAAC,CAAA;QACnC,MAAM,MAAM,GAAG,MAAM,CAAC,QAAQ,CAAA;QAE9B,qEAAqE;QACrE,gCAAgC;QAChC,IAAI,OAAO,KAAK,aAAa,IAAI,aAAa,EAAE,CAAC;YAC/C,iBAAiB,CAAC,mBAAmB,CAAC,aAAa,CAAC,EAAE,aAAa,CAAC,OAAO,EAAE,GAAG,EAAE,OAAO,CAAC,CAAA;YAC1F,MAAM,CAAC,gBAAgB,GAAG,IAAI,CAAA;QAChC,CAAC;QACD,IACE,MAAM;YACL,6BAAmD,CAAC,QAAQ,CAAC,OAAO,CAAC;YACtE,aAAa,EACb,CAAC;YACD,MAAM,UAAU,GAAG,mBAAmB,CAAC,OAA6C,CAAC,CAAA;YACrF,iBAAiB,CAAC,UAAU,EAAE,aAAa,CAAC,OAAO,EAAE,GAAG,EAAE,OAAO,CAAC,CAAA;YAClE,MAAM,CAAC,gBAAgB,GAAG,IAAI,CAAA;QAChC,CAAC;QAED,IAAI,OAAO,KAAK,aAAa,IAAI,MAAM,EAAE,CAAC;YACxC,IAAI,OAAO,KAAK,aAAa,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,KAAK,UAAU,EAAE,CAAC;gBACjF,WAAW,CAAC,OAAO,EAAE,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,GAAG,EAAE,MAAM,CAAC,CAAA;YAC/D,CAAC;YACD,IAAI,OAAO,KAAK,aAAa,IAAI,OAAO,KAAK,QAAQ,EAAE,CAAC;gBACtD,gBAAgB,CACd,OAAO,EACP,kBAAkB,CAAC,GAAG,CAAC,OAAO,CAAC,EAC/B,gBAAgB,CAAC,GAAG,CAAC,OAAO,CAAC,EAC7B,GAAG,EACH,MAAM,CACP,CAAA;YACH,CAAC;YACD,IAAI,OAAO,KAAK,OAAO,EAAE,CAAC;gBACxB,iBAAiB,CACf,kBAAkB,CAAC,GAAG,CAAC,OAAO,CAAC,EAC/B,gBAAgB,CAAC,GAAG,CAAC,OAAO,CAAC,EAC7B,GAAG,EACH,MAAM,CACP,CAAA;gBACD,sBAAsB,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,EAAE,GAAG,EAAE,MAAM,CAAC,CAAA;YACjE,CAAC;YACD,yEAAyE;YACzE,gEAAgE;YAChE,gBAAgB,CAAC,OAAO,EAAE,GAAG,EAAE,MAAM,CAAC,CAAA;QACxC,CAAC;QAED,OAAO,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;IACtB,CAAC;IAED,uEAAuE;IACvE,0EAA0E;IAC1E,0EAA0E;IAC1E,wEAAwE;IACxE,IAAI,aAAa,EAAE,CAAC;QAClB,iBAAiB,CAAC,mBAAmB,CAAC,MAAM,EAAE,aAAa,CAAC,OAAO,EAAE,GAAG,EAAE,QAAQ,CAAC,CAAA;IACrF,CAAC;IAED,iBAAiB,CAAC;QAChB,aAAa,EAAE,CAAC;QAChB,WAAW,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;QACrC,iBAAiB,EAAE,CAAC;QACpB,OAAO,EAAE,wBAAwB,CAAC,OAAO,CAAC;KAC3C,CAAC,CAAA;IAEF,OAAO;QACL,WAAW,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;QACrC,YAAY,EAAE,oBAAoB,EAAE;QACpC,cAAc,EAAE,OAAO;KACxB,CAAA;AACH,CAAC;AAED,iFAAiF;AACjF,OAAO,EAAE,iBAAiB,EAAE,CAAA"}

package/dist/src/install/agent-pack-installer.preserve.test.d.ts

@@ -0,0 +1,11 @@
+/**
+ * installAgentPack preserve-existing semantics (SMI-5456).
+ *
+ * Split from agent-pack-installer.test.ts at the 500-line gate; shares its
+ * temp-HOME + manifest-env fixture shape. Covers the non-interactive conflict
+ * refusal for a foreign pre-existing `skillsmith` MCP entry and the
+ * `force: true` overwrite path (including the manifest-records-a-real-backup
+ * invariant that uninstall replay depends on).
+ */
+export {};
+//# sourceMappingURL=agent-pack-installer.preserve.test.d.ts.map

package/dist/src/install/agent-pack-installer.preserve.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-pack-installer.preserve.test.d.ts","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.preserve.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG"}

package/dist/src/install/agent-pack-installer.preserve.test.js

@@ -0,0 +1,72 @@
+/**
+ * installAgentPack preserve-existing semantics (SMI-5456).
+ *
+ * Split from agent-pack-installer.test.ts at the 500-line gate; shares its
+ * temp-HOME + manifest-env fixture shape. Covers the non-interactive conflict
+ * refusal for a foreign pre-existing `skillsmith` MCP entry and the
+ * `force: true` overwrite path (including the manifest-records-a-real-backup
+ * invariant that uninstall replay depends on).
+ */
+import { mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { afterEach, beforeEach, describe, expect, it } from 'vitest';
+import { installAgentPack } from './agent-pack-installer.js';
+import { AGENT_INSTALL_DIR_ENV_VAR, getAgentManifestPath } from './agent-manifest.js';
+let homeDir;
+let manifestDir;
+let prevInstallDirEnv;
+beforeEach(() => {
+    homeDir = mkdtempSync(join(tmpdir(), 'skillsmith-agent-install-home-'));
+    manifestDir = mkdtempSync(join(tmpdir(), 'skillsmith-agent-install-manifest-'));
+    prevInstallDirEnv = process.env[AGENT_INSTALL_DIR_ENV_VAR];
+    process.env[AGENT_INSTALL_DIR_ENV_VAR] = manifestDir;
+});
+afterEach(() => {
+    rmSync(homeDir, { recursive: true, force: true });
+    rmSync(manifestDir, { recursive: true, force: true });
+    if (prevInstallDirEnv !== undefined)
+        process.env[AGENT_INSTALL_DIR_ENV_VAR] = prevInstallDirEnv;
+    else
+        delete process.env[AGENT_INSTALL_DIR_ENV_VAR];
+});
+describe('installAgentPack — preserve-existing (non-interactive refusal)', () => {
+    it('does not clobber a foreign pre-existing skillsmith MCP entry, and reports a conflict', () => {
+        mkdirSync(join(homeDir, '.claude'), { recursive: true });
+        const settingsPath = join(homeDir, '.claude', 'settings.json');
+        const foreign = {
+            mcpServers: {
+                skillsmith: { command: 'node', args: ['/some/other/local/path/index.js'] },
+            },
+        };
+        writeFileSync(settingsPath, JSON.stringify(foreign, null, 2));
+        const result = installAgentPack({ homeDir });
+        const doc = JSON.parse(readFileSync(settingsPath, 'utf-8'));
+        expect(doc.mcpServers.skillsmith).toEqual(foreign.mcpServers.skillsmith);
+        const report = result.harnessReports.find((r) => r.harness === 'claude-code');
+        expect(report?.mcpConfig?.status).toBe('conflict');
+        expect(report?.notes.some((n) => n.includes('--force'))).toBe(true);
+    });
+    it('force: true overwrites the foreign entry and the manifest records a real backup for the file', () => {
+        mkdirSync(join(homeDir, '.claude'), { recursive: true });
+        const settingsPath = join(homeDir, '.claude', 'settings.json');
+        const foreign = { mcpServers: { skillsmith: { command: 'node', args: ['/other'] } } };
+        writeFileSync(settingsPath, JSON.stringify(foreign, null, 2));
+        const result = installAgentPack({ homeDir, force: true });
+        const doc = JSON.parse(readFileSync(settingsPath, 'utf-8'));
+        expect(doc.mcpServers.skillsmith.env.SKILLSMITH_TOOL_PROFILE).toBe('agent');
+        const report = result.harnessReports.find((r) => r.harness === 'claude-code');
+        expect(report?.mcpConfig?.status).toBe('updated');
+        // The MCP merge's OWN `mcpConfig.backupPath` can legitimately be null
+        // here: claude-code's hook-config merge runs FIRST this install run and
+        // is the one that takes the single real backup of settings.json
+        // (`alreadyBackedUpPaths` — one backup per file per run, see
+        // agent-config-merge.types.ts). What matters for correctness is that the
+        // MANIFEST — which uninstall actually replays — records a real backup
+        // for settingsPath, regardless of which merge call happened to claim it.
+        const manifest = JSON.parse(readFileSync(getAgentManifestPath(), 'utf-8'));
+        const settingsEntry = manifest.entries.find((e) => e.path === settingsPath);
+        expect(settingsEntry?.backupPath).not.toBeNull();
+    });
+});
+//# sourceMappingURL=agent-pack-installer.preserve.test.js.map

package/dist/src/install/agent-pack-installer.preserve.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-pack-installer.preserve.test.js","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.preserve.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,EAAE,SAAS,EAAE,WAAW,EAAE,YAAY,EAAE,MAAM,EAAE,aAAa,EAAE,MAAM,SAAS,CAAA;AACrF,OAAO,EAAE,MAAM,EAAE,MAAM,SAAS,CAAA;AAChC,OAAO,EAAE,IAAI,EAAE,MAAM,WAAW,CAAA;AAChC,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AAEpE,OAAO,EAAE,gBAAgB,EAAE,MAAM,2BAA2B,CAAA;AAC5D,OAAO,EAAE,yBAAyB,EAAE,oBAAoB,EAAE,MAAM,qBAAqB,CAAA;AAErF,IAAI,OAAe,CAAA;AACnB,IAAI,WAAmB,CAAA;AACvB,IAAI,iBAAqC,CAAA;AAEzC,UAAU,CAAC,GAAG,EAAE;IACd,OAAO,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,gCAAgC,CAAC,CAAC,CAAA;IACvE,WAAW,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,oCAAoC,CAAC,CAAC,CAAA;IAC/E,iBAAiB,GAAG,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,CAAA;IAC1D,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,GAAG,WAAW,CAAA;AACtD,CAAC,CAAC,CAAA;AAEF,SAAS,CAAC,GAAG,EAAE;IACb,MAAM,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;IACjD,MAAM,CAAC,WAAW,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;IACrD,IAAI,iBAAiB,KAAK,SAAS;QAAE,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,GAAG,iBAAiB,CAAA;;QAC1F,OAAO,OAAO,CAAC,GAAG,CAAC,yBAAyB,CAAC,CAAA;AACpD,CAAC,CAAC,CAAA;AAEF,QAAQ,CAAC,gEAAgE,EAAE,GAAG,EAAE;IAC9E,EAAE,CAAC,sFAAsF,EAAE,GAAG,EAAE;QAC9F,SAAS,CAAC,IAAI,CAAC,OAAO,EAAE,SAAS,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;QACxD,MAAM,YAAY,GAAG,IAAI,CAAC,OAAO,EAAE,SAAS,EAAE,eAAe,CAAC,CAAA;QAC9D,MAAM,OAAO,GAAG;YACd,UAAU,EAAE;gBACV,UAAU,EAAE,EAAE,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,iCAAiC,CAAC,EAAE;aAC3E;SACF,CAAA;QACD,aAAa,CAAC,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAA;QAE7D,MAAM,MAAM,GAAG,gBAAgB,CAAC,EAAE,OAAO,EAAE,CAAC,CAAA;QAC5C,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,YAAY,EAAE,OAAO,CAAC,CAAmB,CAAA;QAC7E,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,CAAC,OAAO,CAAC,OAAO,CAAC,UAAU,CAAC,UAAU,CAAC,CAAA;QAExE,MAAM,MAAM,GAAG,MAAM,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,aAAa,CAAC,CAAA;QAC7E,MAAM,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,CAAA;QAClD,MAAM,CAAC,MAAM,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IACrE,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,8FAA8F,EAAE,GAAG,EAAE;QACtG,SAAS,CAAC,IAAI,CAAC,OAAO,EAAE,SAAS,CAAC,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;QACxD,MAAM,YAAY,GAAG,IAAI,CAAC,OAAO,EAAE,SAAS,EAAE,eAAe,CAAC,CAAA;QAC9D,MAAM,OAAO,GAAG,EAAE,UAAU,EAAE,EAAE,UAAU,EAAE,EAAE,OAAO,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,QAAQ,CAAC,EAAE,EAAE,EAAE,CAAA;QACrF,aAAa,CAAC,YAAY,EAAE,IAAI,CAAC,SAAS,CAAC,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAA;QAE7D,MAAM,MAAM,GAAG,gBAAgB,CAAC,EAAE,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAA;QACzD,MAAM,GAAG,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,YAAY,EAAE,OAAO,CAAC,CAEzD,CAAA;QACD,MAAM,CAAC,GAAG,CAAC,UAAU,CAAC,UAAU,CAAC,GAAG,CAAC,uBAAuB,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;QAC3E,MAAM,MAAM,GAAG,MAAM,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,KAAK,aAAa,CAAC,CAAA;QAC7E,MAAM,CAAC,MAAM,EAAE,SAAS,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAA;QAEjD,sEAAsE;QACtE,wEAAwE;QACxE,gEAAgE;QAChE,6DAA6D;QAC7D,yEAAyE;QACzE,sEAAsE;QACtE,yEAAyE;QACzE,MAAM,QAAQ,GAAG,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,oBAAoB,EAAE,EAAE,OAAO,CAAC,CAExE,CAAA;QACD,MAAM,aAAa,GAAG,QAAQ,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,YAAY,CAAC,CAAA;QAC3E,MAAM,CAAC,aAAa,EAAE,UAAU,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAA;IAClD,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/src/install/agent-pack-installer.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=agent-pack-installer.test.d.ts.map

package/dist/src/install/agent-pack-installer.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-pack-installer.test.d.ts","sourceRoot":"","sources":["../../../src/install/agent-pack-installer.test.ts"],"names":[],"mappings":""}