@skillsmith/core 0.9.0 → 0.10.0

package/dist/src/services/agent-pack/skill-md.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-md.js","sourceRoot":"","sources":["../../../../src/services/agent-pack/skill-md.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,EACL,gBAAgB,EAChB,IAAI,EACJ,oBAAoB,EACpB,gBAAgB,EAChB,kBAAkB,EAClB,gBAAgB,EAChB,aAAa,EACb,eAAe,EACf,QAAQ,GACT,MAAM,oBAAoB,CAAA;AAC3B,OAAO,EACL,wBAAwB,EACxB,uBAAuB,EACvB,qBAAqB,EACrB,qBAAqB,EACrB,kBAAkB,GACnB,MAAM,YAAY,CAAA;AAEnB,oDAAoD;AACpD,SAAS,eAAe,CAAC,UAA6B;IACpD,OAAO,UAAU,CAAC,IAAI,CAAC,MAAM,CAAC,CAAA;AAChC,CAAC;AAED,4BAA4B;AAC5B,SAAS,OAAO,CAAC,KAAwB;IACvC,OAAO,KAAK,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;AACpD,CAAC;AAED;;;;GAIG;AACH,MAAM,UAAU,oBAAoB;IAClC,MAAM,QAAQ,GAAa,EAAE,CAAA;IAE7B,QAAQ,CAAC,IAAI,CAAC,KAAK,uBAAuB,EAAE,CAAC,CAAA;IAC7C,QAAQ,CAAC,IAAI,CAAC,eAAe,CAAC,gBAAgB,CAAC,CAAC,CAAA;IAEhD,QAAQ,CAAC,IAAI,CAAC,eAAe,CAAC,CAAA;IAC9B,QAAQ,CAAC,IAAI,CAAC,eAAe,CAAC,oBAAoB,CAAC,CAAC,CAAA;IAEpD,QAAQ,CAAC,IAAI,CAAC,sCAAsC,CAAC,CAAA;IACrD,QAAQ,CAAC,IAAI,CACX,yGAAyG,CAC1G,CAAA;IACD,KAAK,MAAM,MAAM,IAAI,aAAa,EAAE,CAAC;QACnC,QAAQ,CAAC,IAAI,CAAC,OAAO,MAAM,CAAC,KAAK,EAAE,CAAC,CAAA;QACpC,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAC,CAAA;IAC5B,CAAC;IAED,QAAQ,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAA;IACjC,KAAK,MAAM,GAAG,IAAI,IAAI,EAAE,CAAC;QACvB,QAAQ,CAAC,IAAI,CAAC,OAAO,GAAG,CAAC,KAAK,EAAE,CAAC,CAAA;QACjC,QAAQ,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;QACvB,IAAI,GAAG,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YACzB,QAAQ,CAAC,IAAI,CAAC,UAAU,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,CAAA;QAClD,CAAC;IACH,CAAC;IAED,QAAQ,CAAC,IAAI,CAAC,kDAAkD,CAAC,CAAA;IACjE,QAAQ,CAAC,IAAI,CAAC,eAAe,CAAC,kBAAkB,CAAC,CAAC,CAAA;IAClD,KAAK,MAAM,OAAO,IAAI,gBAAgB,EAAE,CAAC;QACvC,QAAQ,CAAC,IAAI,CAAC,OAAO,OAAO,CAAC,KAAK,EAAE,CAAC,CAAA;QACrC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,CAAA;IAC7B,CAAC;IAED,QAAQ,CAAC,IAAI,CAAC,sBAAsB,CAAC,CAAA;IACrC,QAAQ,CAAC,IAAI,CAAC,eAAe,CAAC,eAAe,CAAC,CAAC,CAAA;IAE/C,QAAQ,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAA;IACtC,QAAQ,CAAC,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAA;IAEhC,2EAA2E;IAC3E,OAAO,GAAG,QAAQ,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI,CAAA;AACrC,CAAC;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH,MAAM,UAAU,kBAAkB;IAChC,MAAM,aAAa,GAAG,wBAAwB,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IAC7F,MAAM,WAAW,GAAG;QAClB,KAAK;QACL,SAAS,qBAAqB,EAAE;QAChC,gBAAgB,IAAI,CAAC,SAAS,CAAC,gBAAgB,CAAC,EAAE;QAClD,YAAY,IAAI,CAAC,SAAS,CAAC,kBAAkB,CAAC,EAAE;QAChD,eAAe,IAAI,CAAC,SAAS,CAAC,qBAAqB,CAAC,EAAE;QACtD,mBAAmB,aAAa,GAAG;QACnC,KAAK;KACN,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IAEZ,OAAO,GAAG,WAAW,OAAO,oBAAoB,EAAE,EAAE,CAAA;AACtD,CAAC"}

package/dist/src/services/agent-pack/types.d.ts

@@ -0,0 +1,118 @@
+/**
+ * Skillsmith Agent pack — shared types + constants (SMI-5456 Wave 1 Step 4).
+ *
+ * The portable agent pack IS the Skillsmith Agent product: one prompt source
+ * (the SKILL.md brain), thin per-harness shims that carry invocation sugar and
+ * zero logic, and SessionStart/SessionEnd hook artifacts that feed the
+ * mediation marker channel. Everything is generated from this one source at
+ * build time and versioned with the `@skillsmith/mcp-server` release — the
+ * mitigation for definition rot across harness targets (PRD §5.2 risk f).
+ *
+ * This module is intentionally free of any `@skillsmith/mcp-server` import: the
+ * curated tool profile is passed in as {@link AgentPackInput.toolProfile} so the
+ * dependency direction stays core → (consumed by) mcp-server, never circular.
+ *
+ * @see docs/internal/product/prd-skillsmith-agent.md
+ * @see docs/internal/architecture/skillsmith-agent-architecture.md (artifacts A1-A6)
+ */
+/** Skill directory + agentskills.io `name` slug for the generated pack. */
+export declare const AGENT_PACK_SKILL_NAME = "skillsmith-agent";
+/** Human-facing display name used in prose and shim descriptions. */
+export declare const AGENT_PACK_DISPLAY_NAME = "Skillsmith Agent";
+/**
+ * On-disk pack schema version. Bump on any breaking change to artifact SHAPE
+ * (paths, frontmatter fields, hook contract) so the installer can detect an
+ * incompatible pack. NOT the npm version — keeping it a fixed code constant is
+ * what makes generation deterministic (no release-number churn in artifacts).
+ */
+export declare const AGENT_PACK_SCHEMA_VERSION = 1;
+/**
+ * SKILL.md frontmatter `version` (semver string — the repo's own
+ * `skill_validate` requires it). Static for Wave 1; bump when the pack's
+ * CONTENT changes materially. Independent of {@link AGENT_PACK_SCHEMA_VERSION}
+ * (artifact shape) and of the npm release number (determinism: artifacts must
+ * not churn with every release).
+ */
+export declare const AGENT_PACK_VERSION = "1.0.0";
+/** SKILL.md frontmatter `repository` (source transparency for a published skill). */
+export declare const AGENT_PACK_REPOSITORY = "https://github.com/smith-horn/skillsmith";
+/**
+ * SKILL.md frontmatter `compatibility`, constrained to the validator's SMI-2760
+ * vocabulary (`KNOWN_IDES`/`KNOWN_LLMS` in mcp-server `utils/validation.ts`) so
+ * the pack validates with ZERO warnings. In Tier order; `vscode` is that
+ * vocabulary's designated slug for the Copilot/VS Code surface. `codex`,
+ * `opencode`, and `hermes` are supported harnesses but have no slug in the
+ * vocabulary yet — add them here when the SMI-2760 enum gains them.
+ */
+export declare const AGENT_PACK_COMPATIBILITY: readonly string[];
+/** Harness identifiers the pack targets. */
+export type HarnessId = 'claude-code' | 'cursor' | 'codex' | 'copilot' | 'opencode';
+/**
+ * Harnesses that get a generated SessionStart/SessionEnd hook (PRD §3.1,
+ * spike report §(e)). Hermes has no session-start equivalent (spike verified
+ * absent) and Windsurf has no hook system — both excluded. Copilot/OpenCode
+ * hooks (preview / JS-plugin format) are out of Wave-1 hook scope by decision;
+ * they still get shims.
+ */
+export declare const HOOK_HARNESSES: readonly HarnessId[];
+/** Artifact class. */
+export type AgentArtifactKind = 'skill' | 'shim' | 'hook';
+/**
+ * A single generated artifact. `path` is POSIX-relative to the agent-pack root;
+ * `content` is deterministic (no timestamps / randomness — snapshot tests depend
+ * on it). The installer (Step 5) consumes this typed shape directly rather than
+ * re-deriving intent from the path.
+ */
+export interface AgentPackArtifact {
+    /** Path relative to the agent-pack root (POSIX separators). */
+    path: string;
+    /** File contents. Byte-identical across runs for identical input. */
+    content: string;
+    /** What kind of artifact this is. */
+    kind: AgentArtifactKind;
+    /** Harness this artifact targets, or `null` for the harness-neutral skill pack. */
+    harness: HarnessId | null;
+    /** True when the installer must mark the file executable (hook scripts). */
+    executable: boolean;
+}
+/** Input to {@link generateAgentPack}. */
+export interface AgentPackInput {
+    /**
+     * The curated MCP tool profile — the single source of truth is
+     * `@skillsmith/mcp-server`'s `AGENT_TOOL_PROFILE_NAMES`, passed in here by
+     * the generation script and by tests. Every tool the prompt source references
+     * must be a member, or {@link generateAgentPack} throws (build-time fail-fast).
+     */
+    toolProfile: readonly string[];
+}
+/**
+ * A delegable job the pack teaches. Jobs 1-3 are full MVP orchestrations; jobs
+ * 4/8/9 are routing-only (find/recommend, author-away, team-share).
+ */
+export interface JobDefinition {
+    /** Stable id for assembly tests. */
+    id: string;
+    /** Section heading (no leading `###`). */
+    title: string;
+    /** Prose body — plain-language operating instructions for this job. */
+    body: string;
+    /**
+     * Tools this job orchestrates, by MCP name. Empty for routing-only jobs that
+     * hand off to another skill/tier rather than calling tools. Every entry is
+     * validated against {@link AgentPackInput.toolProfile}.
+     */
+    tools: readonly string[];
+}
+/** A trust/safety clause rendered verbatim-in-spirit from PRD §7. */
+export interface TrustClause {
+    id: string;
+    title: string;
+    body: string;
+}
+/** A paywall trigger's wording + when-to-mention rule (PRD §8.1). */
+export interface PaywallTrigger {
+    id: string;
+    title: string;
+    body: string;
+}
+//# sourceMappingURL=types.d.ts.map

package/dist/src/services/agent-pack/types.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"types.d.ts","sourceRoot":"","sources":["../../../../src/services/agent-pack/types.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,2EAA2E;AAC3E,eAAO,MAAM,qBAAqB,qBAAqB,CAAA;AAEvD,qEAAqE;AACrE,eAAO,MAAM,uBAAuB,qBAAqB,CAAA;AAEzD;;;;;GAKG;AACH,eAAO,MAAM,yBAAyB,IAAI,CAAA;AAE1C;;;;;;GAMG;AACH,eAAO,MAAM,kBAAkB,UAAU,CAAA;AAEzC,qFAAqF;AACrF,eAAO,MAAM,qBAAqB,6CAA6C,CAAA;AAE/E;;;;;;;GAOG;AACH,eAAO,MAAM,wBAAwB,EAAE,SAAS,MAAM,EAKrD,CAAA;AAED,4CAA4C;AAC5C,MAAM,MAAM,SAAS,GAAG,aAAa,GAAG,QAAQ,GAAG,OAAO,GAAG,SAAS,GAAG,UAAU,CAAA;AAEnF;;;;;;GAMG;AACH,eAAO,MAAM,cAAc,EAAE,SAAS,SAAS,EAAuC,CAAA;AAEtF,sBAAsB;AACtB,MAAM,MAAM,iBAAiB,GAAG,OAAO,GAAG,MAAM,GAAG,MAAM,CAAA;AAEzD;;;;;GAKG;AACH,MAAM,WAAW,iBAAiB;IAChC,+DAA+D;IAC/D,IAAI,EAAE,MAAM,CAAA;IACZ,qEAAqE;IACrE,OAAO,EAAE,MAAM,CAAA;IACf,qCAAqC;IACrC,IAAI,EAAE,iBAAiB,CAAA;IACvB,mFAAmF;IACnF,OAAO,EAAE,SAAS,GAAG,IAAI,CAAA;IACzB,4EAA4E;IAC5E,UAAU,EAAE,OAAO,CAAA;CACpB;AAED,0CAA0C;AAC1C,MAAM,WAAW,cAAc;IAC7B;;;;;OAKG;IACH,WAAW,EAAE,SAAS,MAAM,EAAE,CAAA;CAC/B;AAED;;;GAGG;AACH,MAAM,WAAW,aAAa;IAC5B,oCAAoC;IACpC,EAAE,EAAE,MAAM,CAAA;IACV,0CAA0C;IAC1C,KAAK,EAAE,MAAM,CAAA;IACb,uEAAuE;IACvE,IAAI,EAAE,MAAM,CAAA;IACZ;;;;OAIG;IACH,KAAK,EAAE,SAAS,MAAM,EAAE,CAAA;CACzB;AAED,qEAAqE;AACrE,MAAM,WAAW,WAAW;IAC1B,EAAE,EAAE,MAAM,CAAA;IACV,KAAK,EAAE,MAAM,CAAA;IACb,IAAI,EAAE,MAAM,CAAA;CACb;AAED,qEAAqE;AACrE,MAAM,WAAW,cAAc;IAC7B,EAAE,EAAE,MAAM,CAAA;IACV,KAAK,EAAE,MAAM,CAAA;IACb,IAAI,EAAE,MAAM,CAAA;CACb"}

package/dist/src/services/agent-pack/types.js

@@ -0,0 +1,61 @@
+/**
+ * Skillsmith Agent pack — shared types + constants (SMI-5456 Wave 1 Step 4).
+ *
+ * The portable agent pack IS the Skillsmith Agent product: one prompt source
+ * (the SKILL.md brain), thin per-harness shims that carry invocation sugar and
+ * zero logic, and SessionStart/SessionEnd hook artifacts that feed the
+ * mediation marker channel. Everything is generated from this one source at
+ * build time and versioned with the `@skillsmith/mcp-server` release — the
+ * mitigation for definition rot across harness targets (PRD §5.2 risk f).
+ *
+ * This module is intentionally free of any `@skillsmith/mcp-server` import: the
+ * curated tool profile is passed in as {@link AgentPackInput.toolProfile} so the
+ * dependency direction stays core → (consumed by) mcp-server, never circular.
+ *
+ * @see docs/internal/product/prd-skillsmith-agent.md
+ * @see docs/internal/architecture/skillsmith-agent-architecture.md (artifacts A1-A6)
+ */
+/** Skill directory + agentskills.io `name` slug for the generated pack. */
+export const AGENT_PACK_SKILL_NAME = 'skillsmith-agent';
+/** Human-facing display name used in prose and shim descriptions. */
+export const AGENT_PACK_DISPLAY_NAME = 'Skillsmith Agent';
+/**
+ * On-disk pack schema version. Bump on any breaking change to artifact SHAPE
+ * (paths, frontmatter fields, hook contract) so the installer can detect an
+ * incompatible pack. NOT the npm version — keeping it a fixed code constant is
+ * what makes generation deterministic (no release-number churn in artifacts).
+ */
+export const AGENT_PACK_SCHEMA_VERSION = 1;
+/**
+ * SKILL.md frontmatter `version` (semver string — the repo's own
+ * `skill_validate` requires it). Static for Wave 1; bump when the pack's
+ * CONTENT changes materially. Independent of {@link AGENT_PACK_SCHEMA_VERSION}
+ * (artifact shape) and of the npm release number (determinism: artifacts must
+ * not churn with every release).
+ */
+export const AGENT_PACK_VERSION = '1.0.0';
+/** SKILL.md frontmatter `repository` (source transparency for a published skill). */
+export const AGENT_PACK_REPOSITORY = 'https://github.com/smith-horn/skillsmith';
+/**
+ * SKILL.md frontmatter `compatibility`, constrained to the validator's SMI-2760
+ * vocabulary (`KNOWN_IDES`/`KNOWN_LLMS` in mcp-server `utils/validation.ts`) so
+ * the pack validates with ZERO warnings. In Tier order; `vscode` is that
+ * vocabulary's designated slug for the Copilot/VS Code surface. `codex`,
+ * `opencode`, and `hermes` are supported harnesses but have no slug in the
+ * vocabulary yet — add them here when the SMI-2760 enum gains them.
+ */
+export const AGENT_PACK_COMPATIBILITY = [
+    'claude-code',
+    'cursor',
+    'vscode',
+    'windsurf',
+];
+/**
+ * Harnesses that get a generated SessionStart/SessionEnd hook (PRD §3.1,
+ * spike report §(e)). Hermes has no session-start equivalent (spike verified
+ * absent) and Windsurf has no hook system — both excluded. Copilot/OpenCode
+ * hooks (preview / JS-plugin format) are out of Wave-1 hook scope by decision;
+ * they still get shims.
+ */
+export const HOOK_HARNESSES = ['claude-code', 'cursor', 'codex'];
+//# sourceMappingURL=types.js.map

package/dist/src/services/agent-pack/types.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"types.js","sourceRoot":"","sources":["../../../../src/services/agent-pack/types.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAEH,2EAA2E;AAC3E,MAAM,CAAC,MAAM,qBAAqB,GAAG,kBAAkB,CAAA;AAEvD,qEAAqE;AACrE,MAAM,CAAC,MAAM,uBAAuB,GAAG,kBAAkB,CAAA;AAEzD;;;;;GAKG;AACH,MAAM,CAAC,MAAM,yBAAyB,GAAG,CAAC,CAAA;AAE1C;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,kBAAkB,GAAG,OAAO,CAAA;AAEzC,qFAAqF;AACrF,MAAM,CAAC,MAAM,qBAAqB,GAAG,0CAA0C,CAAA;AAE/E;;;;;;;GAOG;AACH,MAAM,CAAC,MAAM,wBAAwB,GAAsB;IACzD,aAAa;IACb,QAAQ;IACR,QAAQ;IACR,UAAU;CACX,CAAA;AAKD;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,cAAc,GAAyB,CAAC,aAAa,EAAE,QAAQ,EAAE,OAAO,CAAC,CAAA"}

package/dist/src/services/agent-tool-profile.d.ts

@@ -0,0 +1,59 @@
+/**
+ * Curated agent tool profile — canonical home (SMI-5456 Wave 1 Step 5, QD-1).
+ *
+ * These three constants were originally defined in
+ * `@skillsmith/mcp-server`'s `middleware/toolProfile.ts` (Step 2). Step 5's
+ * `sklx agent install` needs to call `generateAgentPack({ toolProfile })`
+ * with the SAME list the mcp-server's generation script uses, so the
+ * installer produces byte-identical artifacts to the committed pack
+ * (determinism is the drift guard — see `agent-pack.assets.test.ts`).
+ * Relocating here lets `@skillsmith/cli` depend on `@skillsmith/core` only
+ * (already a runtime-shaped dependency) instead of pulling in
+ * `@skillsmith/mcp-server` (a devDependency that bundles the full MCP SDK +
+ * server bootstrap) just to read a string array.
+ *
+ * `packages/mcp-server/src/middleware/toolProfile.ts` now imports + re-exports
+ * these three constants so every existing import path (including the
+ * generation script and `agent-pack.assets.test.ts`) keeps working unchanged.
+ * `isAgentToolProfileActive` / `filterToolsForAgentProfile` stay in
+ * mcp-server — they operate on `ListTools` output + `process.env`, which is
+ * mcp-server-specific runtime behavior, not shared constant data.
+ *
+ * DEVIATION FROM THE QD-1 SPEC: the plan's queen decision named the target
+ * location as `packages/core/src/services/agent-pack/` (e.g. `types.ts` or a
+ * small `constants.ts`). That directory was locked for a concurrent
+ * governance audit for the duration of this Step-5 implementation (worker
+ * S4), so this module lives as a SIBLING file instead
+ * (`services/agent-tool-profile.ts`, not `services/agent-pack/*.ts`) to avoid
+ * touching the locked path. Functionally this is identical to the spec'd
+ * location — same package, same import surface via `@skillsmith/core`. A
+ * follow-up should fold this file into `services/agent-pack/` proper once the
+ * lock lifts, purely as a file-move (no behavior change).
+ *
+ * @module @skillsmith/core/services/agent-tool-profile
+ * @see docs/internal/implementation/smi-5456-skillsmith-agent-wave1.md
+ */
+/** Env var that activates the curated agent profile (mcp-server ListTools filter). */
+export declare const AGENT_TOOL_PROFILE_ENV_VAR = "SKILLSMITH_TOOL_PROFILE";
+/** The only value of {@link AGENT_TOOL_PROFILE_ENV_VAR} that activates the profile. */
+export declare const AGENT_TOOL_PROFILE_VALUE = "agent";
+/**
+ * Membership list for the curated agent profile.
+ *
+ * The first 15 names were verified against actual `tools/*.ts`
+ * registrations on 2026-07-01 via:
+ *
+ *   grep -rhoE "name: '[a-z_]+'" packages/mcp-server/src/tools/ \
+ *     --include='*.ts' | grep -v test | sort -u
+ *
+ * `undo_apply` shipped in SMI-5470 (Wave 1 Step 3, the change-journal + undo
+ * tool). This list is the single source of truth consumed by BOTH
+ * `generateAgentPack` call sites: the mcp-server build-time generation script
+ * (`packages/mcp-server/scripts/generate-agent-pack.ts`, via the re-export in
+ * `middleware/toolProfile.ts`) and the CLI installer
+ * (`packages/cli/src/commands/agent.action.ts`, via this module directly).
+ * Determinism of `generateAgentPack` is what guarantees both call sites
+ * produce byte-identical output from the same input.
+ */
+export declare const AGENT_TOOL_PROFILE_NAMES: readonly string[];
+//# sourceMappingURL=agent-tool-profile.d.ts.map

package/dist/src/services/agent-tool-profile.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-tool-profile.d.ts","sourceRoot":"","sources":["../../../src/services/agent-tool-profile.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAkCG;AAEH,sFAAsF;AACtF,eAAO,MAAM,0BAA0B,4BAA4B,CAAA;AAEnE,uFAAuF;AACvF,eAAO,MAAM,wBAAwB,UAAU,CAAA;AAE/C;;;;;;;;;;;;;;;;;GAiBG;AACH,eAAO,MAAM,wBAAwB,EAAE,SAAS,MAAM,EAiBrD,CAAA"}

package/dist/src/services/agent-tool-profile.js

@@ -0,0 +1,76 @@
+/**
+ * Curated agent tool profile — canonical home (SMI-5456 Wave 1 Step 5, QD-1).
+ *
+ * These three constants were originally defined in
+ * `@skillsmith/mcp-server`'s `middleware/toolProfile.ts` (Step 2). Step 5's
+ * `sklx agent install` needs to call `generateAgentPack({ toolProfile })`
+ * with the SAME list the mcp-server's generation script uses, so the
+ * installer produces byte-identical artifacts to the committed pack
+ * (determinism is the drift guard — see `agent-pack.assets.test.ts`).
+ * Relocating here lets `@skillsmith/cli` depend on `@skillsmith/core` only
+ * (already a runtime-shaped dependency) instead of pulling in
+ * `@skillsmith/mcp-server` (a devDependency that bundles the full MCP SDK +
+ * server bootstrap) just to read a string array.
+ *
+ * `packages/mcp-server/src/middleware/toolProfile.ts` now imports + re-exports
+ * these three constants so every existing import path (including the
+ * generation script and `agent-pack.assets.test.ts`) keeps working unchanged.
+ * `isAgentToolProfileActive` / `filterToolsForAgentProfile` stay in
+ * mcp-server — they operate on `ListTools` output + `process.env`, which is
+ * mcp-server-specific runtime behavior, not shared constant data.
+ *
+ * DEVIATION FROM THE QD-1 SPEC: the plan's queen decision named the target
+ * location as `packages/core/src/services/agent-pack/` (e.g. `types.ts` or a
+ * small `constants.ts`). That directory was locked for a concurrent
+ * governance audit for the duration of this Step-5 implementation (worker
+ * S4), so this module lives as a SIBLING file instead
+ * (`services/agent-tool-profile.ts`, not `services/agent-pack/*.ts`) to avoid
+ * touching the locked path. Functionally this is identical to the spec'd
+ * location — same package, same import surface via `@skillsmith/core`. A
+ * follow-up should fold this file into `services/agent-pack/` proper once the
+ * lock lifts, purely as a file-move (no behavior change).
+ *
+ * @module @skillsmith/core/services/agent-tool-profile
+ * @see docs/internal/implementation/smi-5456-skillsmith-agent-wave1.md
+ */
+/** Env var that activates the curated agent profile (mcp-server ListTools filter). */
+export const AGENT_TOOL_PROFILE_ENV_VAR = 'SKILLSMITH_TOOL_PROFILE';
+/** The only value of {@link AGENT_TOOL_PROFILE_ENV_VAR} that activates the profile. */
+export const AGENT_TOOL_PROFILE_VALUE = 'agent';
+/**
+ * Membership list for the curated agent profile.
+ *
+ * The first 15 names were verified against actual `tools/*.ts`
+ * registrations on 2026-07-01 via:
+ *
+ *   grep -rhoE "name: '[a-z_]+'" packages/mcp-server/src/tools/ \
+ *     --include='*.ts' | grep -v test | sort -u
+ *
+ * `undo_apply` shipped in SMI-5470 (Wave 1 Step 3, the change-journal + undo
+ * tool). This list is the single source of truth consumed by BOTH
+ * `generateAgentPack` call sites: the mcp-server build-time generation script
+ * (`packages/mcp-server/scripts/generate-agent-pack.ts`, via the re-export in
+ * `middleware/toolProfile.ts`) and the CLI installer
+ * (`packages/cli/src/commands/agent.action.ts`, via this module directly).
+ * Determinism of `generateAgentPack` is what guarantees both call sites
+ * produce byte-identical output from the same input.
+ */
+export const AGENT_TOOL_PROFILE_NAMES = [
+    'search',
+    'get_skill',
+    'install_skill',
+    'uninstall_skill',
+    'skill_recommend',
+    'skill_validate',
+    'skill_compare',
+    'skill_outdated',
+    'skill_updates',
+    'skill_diff',
+    'skill_pack_audit',
+    'skill_inventory_audit',
+    'apply_namespace_rename',
+    'apply_recommended_edit',
+    'skill_audit',
+    'undo_apply',
+];
+//# sourceMappingURL=agent-tool-profile.js.map

package/dist/src/services/agent-tool-profile.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-tool-profile.js","sourceRoot":"","sources":["../../../src/services/agent-tool-profile.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAkCG;AAEH,sFAAsF;AACtF,MAAM,CAAC,MAAM,0BAA0B,GAAG,yBAAyB,CAAA;AAEnE,uFAAuF;AACvF,MAAM,CAAC,MAAM,wBAAwB,GAAG,OAAO,CAAA;AAE/C;;;;;;;;;;;;;;;;;GAiBG;AACH,MAAM,CAAC,MAAM,wBAAwB,GAAsB;IACzD,QAAQ;IACR,WAAW;IACX,eAAe;IACf,iBAAiB;IACjB,iBAAiB;IACjB,gBAAgB;IAChB,eAAe;IACf,gBAAgB;IAChB,eAAe;IACf,YAAY;IACZ,kBAAkB;IAClB,uBAAuB;IACvB,wBAAwB;IACxB,wBAAwB;IACxB,aAAa;IACb,YAAY;CACb,CAAA"}

package/dist/src/services/agent-tool-profile.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=agent-tool-profile.test.d.ts.map

package/dist/src/services/agent-tool-profile.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-tool-profile.test.d.ts","sourceRoot":"","sources":["../../../src/services/agent-tool-profile.test.ts"],"names":[],"mappings":""}

package/dist/src/services/agent-tool-profile.test.js

@@ -0,0 +1,28 @@
+/**
+ * @fileoverview Tests for the relocated curated-agent-tool-profile constants
+ *               (SMI-5456 Wave 1 Step 5, QD-1).
+ * @module @skillsmith/core/services/agent-tool-profile.test
+ */
+import { describe, expect, it } from 'vitest';
+import { AGENT_TOOL_PROFILE_ENV_VAR, AGENT_TOOL_PROFILE_NAMES, AGENT_TOOL_PROFILE_VALUE, } from './agent-tool-profile.js';
+describe('AGENT_TOOL_PROFILE_NAMES (core, QD-1 relocation)', () => {
+    it('has 16 entries', () => {
+        expect(AGENT_TOOL_PROFILE_NAMES).toHaveLength(16);
+    });
+    it('contains undo_apply', () => {
+        expect(AGENT_TOOL_PROFILE_NAMES).toContain('undo_apply');
+    });
+    it('every entry is a non-empty snake_case tool name', () => {
+        for (const name of AGENT_TOOL_PROFILE_NAMES) {
+            expect(name).toMatch(/^[a-z][a-z_]*[a-z]$/);
+        }
+    });
+    it('has no duplicate entries', () => {
+        expect(new Set(AGENT_TOOL_PROFILE_NAMES).size).toBe(AGENT_TOOL_PROFILE_NAMES.length);
+    });
+    it('env var name + value match the mcp-server ListTools filter contract', () => {
+        expect(AGENT_TOOL_PROFILE_ENV_VAR).toBe('SKILLSMITH_TOOL_PROFILE');
+        expect(AGENT_TOOL_PROFILE_VALUE).toBe('agent');
+    });
+});
+//# sourceMappingURL=agent-tool-profile.test.js.map

package/dist/src/services/agent-tool-profile.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"agent-tool-profile.test.js","sourceRoot":"","sources":["../../../src/services/agent-tool-profile.test.ts"],"names":[],"mappings":"AAAA;;;;GAIG;AACH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AAE7C,OAAO,EACL,0BAA0B,EAC1B,wBAAwB,EACxB,wBAAwB,GACzB,MAAM,yBAAyB,CAAA;AAEhC,QAAQ,CAAC,kDAAkD,EAAE,GAAG,EAAE;IAChE,EAAE,CAAC,gBAAgB,EAAE,GAAG,EAAE;QACxB,MAAM,CAAC,wBAAwB,CAAC,CAAC,YAAY,CAAC,EAAE,CAAC,CAAA;IACnD,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qBAAqB,EAAE,GAAG,EAAE;QAC7B,MAAM,CAAC,wBAAwB,CAAC,CAAC,SAAS,CAAC,YAAY,CAAC,CAAA;IAC1D,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,iDAAiD,EAAE,GAAG,EAAE;QACzD,KAAK,MAAM,IAAI,IAAI,wBAAwB,EAAE,CAAC;YAC5C,MAAM,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,qBAAqB,CAAC,CAAA;QAC7C,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,0BAA0B,EAAE,GAAG,EAAE;QAClC,MAAM,CAAC,IAAI,GAAG,CAAC,wBAAwB,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,wBAAwB,CAAC,MAAM,CAAC,CAAA;IACtF,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,qEAAqE,EAAE,GAAG,EAAE;QAC7E,MAAM,CAAC,0BAA0B,CAAC,CAAC,IAAI,CAAC,yBAAyB,CAAC,CAAA;QAClE,MAAM,CAAC,wBAAwB,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAA;IAChD,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/dist/src/services/bundled-sibling-scan.d.ts

@@ -0,0 +1,111 @@
+/**
+ * @fileoverview Bundled-sibling security scan for the local rescan path (SMI-5422 Phase 2).
+ * @module @skillsmith/core/services/bundled-sibling-scan
+ *
+ * Walks an installed skill's bundle directory and scans its sibling bundled
+ * files (`.mcp.json`, `.claude/settings*.json`, `package.json` lifecycle hooks,
+ * `config.json`, `scripts/*.sh` + top-level `*.sh`) so `skill_rescan` can
+ * quarantine a skill whose MALICIOUS sibling — not its `SKILL.md` — carries the
+ * threat (CVE-2025-59536 hook execution, `curl|bash` postinstall, a
+ * remote-fetch-execute install script).
+ *
+ * This is the local-FS rescan analogue of the Phase-1 install/validate helpers —
+ * NOT a duplicate. The three callers intentionally differ:
+ *   - install:  `skill-installation.io.ts` `fetchAndScanOptionalFiles` (fetch-by-path, no glob)
+ *   - validate: mcp-server `validate-bundled-scan.ts` `scanBundledSiblings` (returns ValidationError[])
+ *   - rescan (this): directory walk + symlink-safe reads + structured result.
+ *
+ * DELIBERATE FP-SAFE DIVERGENCE (Phase 2 review B1, verified empirically):
+ * install/validate reject via `isRejectableScan` (= `!report.passed` OR a
+ * `code_execution`/`obfuscated_directive` finding). The `!report.passed` clause
+ * fires on ANY high/critical finding, and sibling files are non-markdown so they
+ * get NO documentation-context downgrade — so routine, benign script idioms fire
+ * at full severity and would quarantine a working skill:
+ *   `chmod 755 ./bin/cli`     => privilege_escalation:critical => !passed
+ *   `cp .env.example .env`    => sensitive_path:high           => !passed
+ *   `source .env` / `export X=$1` / `cat ~/.ssh/...` => sensitive_path:high
+ * For an ALREADY-INSTALLED skill that false positive hides a working skill from
+ * local search. So this module drives the quarantine decision SOLELY from
+ * `code_execution`/`obfuscated_directive` presence (still catches `curl|bash`).
+ * The root cause — privilege_escalation/sensitive_path over-firing in
+ * non-markdown execution contexts (which is the SAME latent FP on the install
+ * path) — is tracked in SMI-5424; once those patterns are narrowed at the
+ * source, all three callers can safely share the broader criterion.
+ *
+ * INHERITED DETECTION GAPS (FN, tracked SMI-5424): bare-interpreter hook
+ * payloads (`node evil.js`, `python evil.py`, `bun`/`deno`), `&&`/`;`-chained
+ * fetch-then-exec, `npx`, and JSON `\uXXXX`-escaped commands inside raw-scanned
+ * structured files are NOT detected. `.js`/`.py`/`.mjs`/`.ts` payload files and
+ * nested/non-`scripts/` `.sh` are a Phase-3 follow-up (recursive bundle walk).
+ * COUNT-CAP DECOY-PADDING (FN): the fixed bundled files are cap-exempt, but the
+ * `.sh` glob is capped — an author can name the malicious script to sort last
+ * and pad `scripts/` with cap-many benign decoys so it lands in `droppedForCount`
+ * and is never scanned. This is surfaced (never a silent drop) but not blocked;
+ * a cumulative-resource bound is a Phase-3 follow-up.
+ *
+ * config.json IS scanned here (only doc-class siblings are skipped), whereas the
+ * Phase-1 validate helper (validate-bundled-scan.ts) also skips `config` — rescan
+ * is the deliberately stricter superset because it is a quarantine path.
+ */
+import type { SecurityFinding } from '../security/scanner/types.js';
+import type { SecurityScanner } from '../security/index.js';
+/** Max `.sh` glob files scanned per skill (fixed bundled files are exempt). */
+export declare const MAX_SIBLING_SH_FILES = 50;
+/** Per-file byte ceiling; larger siblings are skipped (recorded, never silent). */
+export declare const MAX_SIBLING_FILE_BYTES: number;
+/** Tunable caps for {@link scanLocalBundleSiblings}. */
+export interface BundledSiblingScanOptions {
+    /** Override {@link MAX_SIBLING_SH_FILES}. */
+    maxShFiles?: number;
+    /** Override {@link MAX_SIBLING_FILE_BYTES}. */
+    maxBytesPerFile?: number;
+}
+/**
+ * Result of scanning a skill bundle's sibling files. All path fields are
+ * relative to the skill directory. `findings` is the full (display) set;
+ * `rejectableFindings`/`rejectableFiles` are the quarantine-driving subset.
+ */
+export interface BundledSiblingScanResult {
+    /** All non-doc sibling findings, each tagged with `location = relPath`. */
+    findings: SecurityFinding[];
+    /** True when any sibling carries a `code_execution`/`obfuscated_directive`. */
+    rejectable: boolean;
+    /** The execution-threat findings that drive quarantine. */
+    rejectableFindings: SecurityFinding[];
+    /** Relative paths that drove rejection. */
+    rejectableFiles: string[];
+    /** Relative paths actually scanned. */
+    scannedFiles: string[];
+    /**
+     * Max riskScore across REJECTING sibling reports only (display only; rejection
+     * is type-driven so this can be below the threshold). Non-rejecting siblings
+     * (e.g. a benign `chmod` that scores high) are excluded so they cannot
+     * mis-attribute a quarantine's surfaced score.
+     */
+    maxSiblingRiskScore: number;
+    /** `.sh` files beyond the count cap — surfaced, never silently dropped. */
+    droppedForCount: string[];
+    /** Files skipped for exceeding the byte cap. */
+    skippedOversize: string[];
+    /** Symlink siblings resolving outside the skill dir (SMI-4287 guard). */
+    skippedSymlinkEscape: string[];
+}
+/**
+ * Scan a skill bundle's sibling files and return the structured result.
+ *
+ * Fixed {@link BUNDLED_SCAN_FILES} are always scanned (exempt from the count
+ * cap, so a decoy-padding attack on `scripts/` cannot push the primary hook /
+ * postinstall surface out of the scan window). The `.sh` glob is capped and
+ * any overflow is reported in `droppedForCount`.
+ *
+ * Doc-class siblings (`README.md`, `examples.md`) are intentionally NOT scanned:
+ * prose routinely quotes attack strings, so they can never drive a quarantine
+ * (Phase-1 H6 control). Every read is symlink-safe via `resolveSafeRealpath`
+ * (containment to `skillDir`, SMI-4287) and reads the resolved realpath.
+ *
+ * @param skillDir absolute path to the installed skill's bundle directory
+ * @param scanner  a constructed SecurityScanner (injected to keep this module DB-free)
+ * @param opts     optional caps
+ */
+export declare function scanLocalBundleSiblings(skillDir: string, scanner: SecurityScanner, opts?: BundledSiblingScanOptions): Promise<BundledSiblingScanResult>;
+//# sourceMappingURL=bundled-sibling-scan.d.ts.map

package/dist/src/services/bundled-sibling-scan.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"bundled-sibling-scan.d.ts","sourceRoot":"","sources":["../../../src/services/bundled-sibling-scan.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAgDG;AAGH,OAAO,KAAK,EAAE,eAAe,EAAc,MAAM,8BAA8B,CAAA;AAI/E,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAA;AAQ3D,+EAA+E;AAC/E,eAAO,MAAM,oBAAoB,KAAK,CAAA;AACtC,mFAAmF;AACnF,eAAO,MAAM,sBAAsB,QAAa,CAAA;AAEhD,wDAAwD;AACxD,MAAM,WAAW,yBAAyB;IACxC,6CAA6C;IAC7C,UAAU,CAAC,EAAE,MAAM,CAAA;IACnB,+CAA+C;IAC/C,eAAe,CAAC,EAAE,MAAM,CAAA;CACzB;AAED;;;;GAIG;AACH,MAAM,WAAW,wBAAwB;IACvC,2EAA2E;IAC3E,QAAQ,EAAE,eAAe,EAAE,CAAA;IAC3B,+EAA+E;IAC/E,UAAU,EAAE,OAAO,CAAA;IACnB,2DAA2D;IAC3D,kBAAkB,EAAE,eAAe,EAAE,CAAA;IACrC,2CAA2C;IAC3C,eAAe,EAAE,MAAM,EAAE,CAAA;IACzB,uCAAuC;IACvC,YAAY,EAAE,MAAM,EAAE,CAAA;IACtB;;;;;OAKG;IACH,mBAAmB,EAAE,MAAM,CAAA;IAC3B,2EAA2E;IAC3E,eAAe,EAAE,MAAM,EAAE,CAAA;IACzB,gDAAgD;IAChD,eAAe,EAAE,MAAM,EAAE,CAAA;IACzB,yEAAyE;IACzE,oBAAoB,EAAE,MAAM,EAAE,CAAA;CAC/B;AAgCD;;;;;;;;;;;;;;;;GAgBG;AACH,wBAAsB,uBAAuB,CAC3C,QAAQ,EAAE,MAAM,EAChB,OAAO,EAAE,eAAe,EACxB,IAAI,GAAE,yBAA8B,GACnC,OAAO,CAAC,wBAAwB,CAAC,CAuEnC"}