@simplysm/sd-claude 13.0.78 → 13.0.81

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (68) hide show
  1. package/claude/rules/sd-claude-rules.md +4 -63
  2. package/claude/rules/sd-simplysm-usage.md +7 -0
  3. package/claude/sd-session-start.sh +10 -0
  4. package/claude/sd-statusline.py +249 -0
  5. package/claude/skills/sd-api-review/SKILL.md +89 -0
  6. package/claude/skills/sd-check/SKILL.md +55 -57
  7. package/claude/skills/sd-commit/SKILL.md +37 -42
  8. package/claude/skills/sd-debug/SKILL.md +75 -265
  9. package/claude/skills/sd-document/SKILL.md +63 -53
  10. package/claude/skills/sd-document/_common.py +94 -0
  11. package/claude/skills/sd-document/extract_docx.py +19 -48
  12. package/claude/skills/sd-document/extract_pdf.py +22 -50
  13. package/claude/skills/sd-document/extract_pptx.py +17 -40
  14. package/claude/skills/sd-document/extract_xlsx.py +19 -40
  15. package/claude/skills/sd-email-analyze/SKILL.md +23 -31
  16. package/claude/skills/sd-email-analyze/email-analyzer.py +79 -65
  17. package/claude/skills/sd-init/SKILL.md +133 -0
  18. package/claude/skills/sd-plan/SKILL.md +69 -120
  19. package/claude/skills/sd-readme/SKILL.md +106 -131
  20. package/claude/skills/sd-review/SKILL.md +38 -155
  21. package/claude/skills/sd-simplify/SKILL.md +59 -0
  22. package/dist/commands/install.js +20 -6
  23. package/dist/commands/install.js.map +1 -1
  24. package/package.json +3 -2
  25. package/src/commands/install.ts +29 -7
  26. package/README.md +0 -297
  27. package/claude/refs/sd-angular.md +0 -127
  28. package/claude/refs/sd-code-conventions.md +0 -155
  29. package/claude/refs/sd-directories.md +0 -7
  30. package/claude/refs/sd-library-issue.md +0 -7
  31. package/claude/refs/sd-migration.md +0 -7
  32. package/claude/refs/sd-orm-v12.md +0 -81
  33. package/claude/refs/sd-orm.md +0 -23
  34. package/claude/refs/sd-service.md +0 -5
  35. package/claude/refs/sd-simplysm-docs.md +0 -52
  36. package/claude/refs/sd-solid.md +0 -68
  37. package/claude/refs/sd-workflow.md +0 -25
  38. package/claude/rules/sd-refs-linker.md +0 -52
  39. package/claude/sd-statusline.js +0 -296
  40. package/claude/skills/sd-api-name-review/SKILL.md +0 -154
  41. package/claude/skills/sd-brainstorm/SKILL.md +0 -215
  42. package/claude/skills/sd-debug/condition-based-waiting-example.ts +0 -158
  43. package/claude/skills/sd-debug/condition-based-waiting.md +0 -114
  44. package/claude/skills/sd-debug/defense-in-depth.md +0 -128
  45. package/claude/skills/sd-debug/find-polluter.sh +0 -64
  46. package/claude/skills/sd-debug/root-cause-tracing.md +0 -168
  47. package/claude/skills/sd-discuss/SKILL.md +0 -91
  48. package/claude/skills/sd-explore/SKILL.md +0 -118
  49. package/claude/skills/sd-plan-dev/SKILL.md +0 -294
  50. package/claude/skills/sd-plan-dev/code-quality-reviewer-prompt.md +0 -49
  51. package/claude/skills/sd-plan-dev/final-review-prompt.md +0 -50
  52. package/claude/skills/sd-plan-dev/implementer-prompt.md +0 -60
  53. package/claude/skills/sd-plan-dev/spec-reviewer-prompt.md +0 -45
  54. package/claude/skills/sd-review/api-reviewer-prompt.md +0 -75
  55. package/claude/skills/sd-review/code-reviewer-prompt.md +0 -82
  56. package/claude/skills/sd-review/convention-checker-prompt.md +0 -61
  57. package/claude/skills/sd-review/refactoring-analyzer-prompt.md +0 -92
  58. package/claude/skills/sd-skill/SKILL.md +0 -417
  59. package/claude/skills/sd-skill/anthropic-best-practices.md +0 -156
  60. package/claude/skills/sd-skill/cso-guide.md +0 -161
  61. package/claude/skills/sd-skill/examples/CLAUDE_MD_TESTING.md +0 -200
  62. package/claude/skills/sd-skill/persuasion-principles.md +0 -220
  63. package/claude/skills/sd-skill/testing-skills-with-subagents.md +0 -408
  64. package/claude/skills/sd-skill/writing-guide.md +0 -159
  65. package/claude/skills/sd-tdd/SKILL.md +0 -385
  66. package/claude/skills/sd-tdd/testing-anti-patterns.md +0 -317
  67. package/claude/skills/sd-use/SKILL.md +0 -67
  68. package/claude/skills/sd-worktree/SKILL.md +0 -78
@@ -1,294 +0,0 @@
1
- ---
2
- name: sd-plan-dev
3
- description: "Parallel execution of plan tasks (explicit invocation only)"
4
- ---
5
-
6
- # Parallel Plan Execution
7
-
8
- Execute plan tasks via parallel implementers with dependency-aware scheduling.
9
-
10
- **Core principle:** Dependency analysis + parallel implementers + orchestrator-managed reviews = maximum throughput
11
-
12
- ## When to Use
13
-
14
- ```mermaid
15
- flowchart TD
16
- A{Have implementation plan?}
17
- A -->|yes| B[sd-plan-dev]
18
- A -->|no| C[Manual execution or brainstorm first]
19
- ```
20
-
21
- ## Execution Method
22
-
23
- All execution uses `Task(general-purpose)` for parallel execution.
24
-
25
- - **implementer**: `Task(general-purpose, model: min(sonnet, current))` — implements one task, commits, reports
26
- - **spec reviewer**: `Task(general-purpose)` — dispatched by orchestrator after implementer completes (read-only)
27
- - **quality reviewer**: `Task(general-purpose)` — dispatched by orchestrator in parallel with spec reviewer (read-only)
28
- - **final reviewer**: `Task(general-purpose)` — dispatched by orchestrator after all batches complete (read-only)
29
-
30
- **Model selection:**
31
- - **implementer**: use `min(sonnet, current model)`. If the user's current model is haiku, use haiku. Otherwise use sonnet.
32
- - **All other agents**: inherit current model (no explicit `model` parameter).
33
-
34
- Independent tasks run as **parallel Task calls in a single message**. After implementers complete, spec and quality reviews run as **parallel Task calls**.
35
-
36
- **CRITICAL: Always launch parallel tasks as multiple Task calls in a single message (foreground parallel).** Never set `run_in_background: true` — it causes Stop hooks to fire prematurely. This rule applies regardless of permission mode (yolo, plan, etc.).
37
-
38
- ## The Process
39
-
40
- ```mermaid
41
- flowchart TD
42
- A["Read plan, extract tasks, create TaskCreate"] --> B["Dependency analysis: identify files per task, build graph, group into batches"]
43
-
44
- subgraph BATCH["Per Batch (independent tasks)"]
45
- subgraph PAR_IMPL["Parallel implementer Task calls (single message)"]
46
- subgraph IMPL["Each Implementer"]
47
- C["Implement the task"] --> D{"Questions?"}
48
- D -->|yes| E["Return questions to orchestrator"]
49
- E --> F["Re-launch with answers"]
50
- F --> C
51
- D -->|no| G["Commit and report"]
52
- end
53
- end
54
-
55
- subgraph REVIEW["Orchestrator review loop (per implementer)"]
56
- subgraph PAR_REV["Parallel reviewer Task calls (single message)"]
57
- H["Task: spec reviewer"]
58
- I["Task: quality reviewer"]
59
- end
60
- J{"Any issues?"}
61
- K["Task: implementer fix"]
62
- L["Re-review (parallel Task calls)"]
63
- end
64
- end
65
-
66
- B --> C
67
- G --> H
68
- G --> I
69
- H --> J
70
- I --> J
71
- J -->|yes| K
72
- K --> L
73
- L --> J
74
- J -->|no| M["Batch integration check (typecheck + lint)"]
75
- M --> N{"More batches?"}
76
- N -->|"yes, next batch"| C
77
- N -->|no| O["Task: final review for entire implementation"]
78
- O --> P["Run /simplify on all changed code"]
79
- P --> Q{"Changes made?"}
80
- Q -->|yes| R["Typecheck + lint affected packages"]
81
- R --> S(["Done"])
82
- Q -->|no| S
83
- ```
84
-
85
- ## Dependency Analysis
86
-
87
- Before launching tasks, analyze the plan to build a dependency graph:
88
-
89
- 1. **For each task**: identify which files/modules it will create or modify
90
- 2. **Find overlaps**: tasks touching the same files depend on each other
91
- 3. **Respect logical dependencies**: if task B uses what task A creates, B depends on A
92
- 4. **Group into batches**: tasks with no dependencies between them form one batch
93
-
94
- ```
95
- Example: 5 tasks
96
- Task 1: creates utils/validator.ts
97
- Task 2: creates hooks/useAuth.ts
98
- Task 3: creates components/Login.tsx (uses hooks/useAuth.ts)
99
- Task 4: modifies utils/validator.ts
100
- Task 5: creates api/endpoints.ts
101
-
102
- Batch 1: [Task 1, Task 2, Task 5] — independent, parallel
103
- Batch 2: [Task 3] — depends on Task 2
104
- Batch 3: [Task 4] — depends on Task 1
105
- ```
106
-
107
- ## Implementer Prompt
108
-
109
- Each implementer receives a prompt based on `./implementer-prompt.md`. Fill in all `[bracketed]` sections before dispatching.
110
-
111
- ## Reviewer Dispatch
112
-
113
- After an implementer completes and reports, the orchestrator dispatches reviewers:
114
-
115
- 1. Record the implementer's commit SHA and files changed from its report
116
- 2. Dispatch TWO parallel Task calls (single message):
117
- - spec reviewer — fill `./spec-reviewer-prompt.md` with task requirements + implementer report
118
- - quality reviewer — fill `./code-quality-reviewer-prompt.md` with implementer report + BASE_SHA/HEAD_SHA
119
- 3. If either reviewer returns CHANGES_NEEDED:
120
- - Re-dispatch implementer with fix instructions (all issues from both reviewers combined)
121
- - After fix, re-dispatch only the failed reviewers (parallel Task calls)
122
- - Repeat until both approve
123
- 4. Proceed to next task or batch
124
-
125
- ## Prompt Templates
126
-
127
- - `./implementer-prompt.md` — implementer instructions
128
- - `./spec-reviewer-prompt.md` — spec compliance review prompt
129
- - `./code-quality-reviewer-prompt.md` — code quality review prompt
130
- - `./final-review-prompt.md` — final integration review prompt
131
-
132
- ## Example Workflow
133
-
134
- ```
135
- You: Using sd-plan-dev to execute this plan.
136
-
137
- [Read plan file: docs/plans/feature-plan.md]
138
- [Extract all 5 tasks with full text + create TaskCreate]
139
-
140
- [Dependency analysis]
141
- Task 1 (validator): no deps
142
- Task 2 (auth hook): no deps
143
- Task 3 (login component): depends on Task 2
144
- Task 4 (validator update): depends on Task 1
145
- Task 5 (api endpoints): no deps
146
-
147
- Batch 1: [Task 1, Task 2, Task 5]
148
- Batch 2: [Task 3, Task 4]
149
-
150
- --- Batch 1: parallel implementers ---
151
-
152
- [3 parallel implementer Task calls in single message]
153
-
154
- Implementer 1: Implemented validator, tests 5/5 pass → committed
155
- Implementer 2: "Should auth use JWT or session?" (question returned)
156
- Implementer 5: Implemented endpoints, tests 3/3 pass → committed
157
-
158
- [Answer Implementer 2 question: "JWT"]
159
- [Re-launch Implementer 2 with answer]
160
- Implementer 2: Implemented auth hook with JWT, tests 4/4 pass → committed
161
-
162
- [Orchestrator dispatches reviewers for each completed implementer]
163
-
164
- Task 1 reviews: [parallel] spec ✅, quality ✅ → Done
165
- Task 2 reviews: [parallel] spec ✅, quality ✅ → Done
166
- Task 5 reviews: [parallel] spec ✅, quality ❌ (magic number)
167
- → Re-dispatch Implementer 5 to fix → committed
168
- → Re-review quality ✅ → Done
169
-
170
- [Batch 1 complete → integration check]
171
-
172
- --- Batch 2: parallel implementers ---
173
-
174
- [2 parallel implementer Task calls in single message]
175
-
176
- Implementer 3: Implemented login component → committed
177
- Implementer 4: Updated validator → committed
178
-
179
- [Orchestrator dispatches reviewers]
180
-
181
- Task 3 reviews: [parallel] spec ❌ (missing error state), quality ✅
182
- → Re-dispatch Implementer 3 to fix → committed
183
- → Re-review spec ✅ → Done
184
- Task 4 reviews: [parallel] spec ✅, quality ✅ → Done
185
-
186
- [Batch 2 complete → integration check]
187
-
188
- --- Final ---
189
-
190
- [Task: final review for entire implementation]
191
- Final reviewer: All requirements met, ready to merge
192
-
193
- [Run /simplify on all changed code]
194
- Simplify: extracted shared validation helper, removed 2 duplicate imports
195
- [typecheck + lint → pass]
196
- [Commit: refactor: simplify changed code]
197
-
198
- Done!
199
- ```
200
-
201
- ## Verification-Only Tasks
202
-
203
- If a task is purely verification (no code changes — just running tests, typecheck, or manual checks), merge its checks into the batch integration check or final review rather than dispatching an implementer. These tasks exist in the plan for documentation purposes but don't need the full implementer → reviewer cycle.
204
-
205
- ## Batch Integration Check
206
-
207
- Between batches, run targeted verification on affected packages before starting the next batch.
208
-
209
- Detect the package manager first (`pnpm-lock.yaml` → pnpm, `yarn.lock` → yarn, otherwise → npm):
210
-
211
- ```bash
212
- $PM run typecheck [affected packages]
213
- $PM run lint [affected packages]
214
- ```
215
-
216
- This catches cross-task integration issues early — especially when the next batch depends on the current batch's output. Do NOT skip this even if individual task reviews passed.
217
-
218
- If typecheck or lint fails, treat the errors as review issues: re-dispatch the implementer(s) whose changes caused the failure with the error output. After fix, re-run the integration check. Do NOT start the next batch until integration passes.
219
-
220
- ## Final Review Dispatch
221
-
222
- After all batches complete and pass integration checks, dispatch the final reviewer:
223
-
224
- 1. Locate the original design document from `docs/plans/` — it shares the same date and topic as the plan file (e.g., plan `2026-03-04-dialog-confirm.md` → design `2026-03-04-dialog-confirm-design.md`)
225
- 2. Fill `./final-review-prompt.md` with:
226
- - The full text of the original design document
227
- - The full text of the implementation plan
228
- - Summaries of all completed tasks (commit SHAs, files changed, test results)
229
- 3. Dispatch as `Task(general-purpose)`
230
- 4. If the final reviewer returns **APPROVED** → done
231
- 5. If the final reviewer returns **ISSUES**:
232
- - For cross-task integration issues: create a fix task targeting specific files, run through implementer → review cycle
233
- - For missing design requirements: create new implementation tasks and run through the full batch cycle
234
- - Re-run final review after all fixes
235
-
236
- ## Simplify
237
-
238
- After the final review passes, run `/simplify` to review all changed code for reuse, quality, and efficiency. This catches cross-task cleanup opportunities that individual reviewers miss.
239
-
240
- 1. Orchestrator runs `/simplify` via the Skill tool
241
- 2. If simplify made changes:
242
- - Run typecheck/lint on affected packages
243
- - If typecheck/lint fails → fix the issues and re-run typecheck/lint until it passes
244
- - Commit simplify changes as a separate commit (`refactor: simplify changed code`)
245
- 3. If simplify made no changes → skip to completion
246
-
247
- ## Completion
248
-
249
- After simplify completes (or is skipped), report to the user: number of tasks completed, total files changed, and final review outcome.
250
-
251
- ## Red Flags
252
-
253
- **Never:**
254
-
255
- - Start implementation on main/master without explicit user consent
256
- - Skip reviews (spec compliance OR code quality)
257
- - Proceed with unfixed issues
258
- - Put tasks with file overlap in the same parallel batch
259
- - Skip dependency analysis
260
- - Make implementer read plan file directly (provide full text instead)
261
- - Skip scene-setting context
262
- - Accept "close enough" on spec compliance
263
- - Skip review loops (issue found → fix → re-review)
264
- - Skip batch integration checks between batches
265
- - Skip `/simplify` after final review
266
- - Use `run_in_background: true` on Task calls (use foreground parallel instead)
267
-
268
- **If implementer returns questions:**
269
-
270
- - Answer clearly and completely
271
- - Re-launch that implementer with answers included
272
- - Other parallel implementers continue unaffected
273
-
274
- **If reviewers find issues:**
275
-
276
- - Orchestrator re-dispatches implementer with all issues from both reviewers combined
277
- - After fix, re-dispatch only the failed reviewers (parallel Task calls)
278
- - Repeat until both approved
279
-
280
- **If implementer fails or times out:**
281
-
282
- - Do NOT silently proceed — the affected files may be in an indeterminate state
283
- - Check if other tasks in the same batch depend on the failed task's output
284
- - Independent tasks' results still stand
285
- - Escalate to user with specific error details before proceeding
286
- - Do NOT re-launch on potentially partially-modified files without inspection
287
-
288
- ## Integration
289
-
290
- **Related skills:**
291
-
292
- - **sd-plan** — creates the plan this skill executes
293
- - **sd-tdd** — implementers follow TDD
294
- - **sd-worktree** — branch isolation for worktree-based workflows
@@ -1,49 +0,0 @@
1
- # Code Quality Reviewer Prompt
2
-
3
- Template for `Task(general-purpose)`.
4
- Runs in parallel with spec reviewer. Fill in all `[bracketed]` sections.
5
-
6
- ```
7
- You are reviewing code quality for a completed implementation.
8
-
9
- ## Implementer Report
10
-
11
- [Paste the implementer's report: files changed, what they built]
12
-
13
- ## Review Scope
14
-
15
- Use git diff to review only what changed:
16
-
17
- git diff [BASE_SHA]..[HEAD_SHA]
18
-
19
- BASE_SHA: [commit before task started]
20
- HEAD_SHA: [implementer's commit SHA from report]
21
-
22
- Focus your review on the diff output. Read surrounding code for context only when needed.
23
-
24
- ## Your Job
25
-
26
- Read the actual code. Report only issues you're confident about — skip style nitpicks.
27
-
28
- ### Review Focus
29
-
30
- 1. **Bugs & Logic Errors**: Off-by-one, null handling, race conditions, incorrect logic
31
- 2. **Security**: Injection, XSS, unsafe input at system boundaries
32
- 3. **Code Quality**: Unnecessary complexity, duplication, dead code, unclear naming
33
- 4. **Error Handling**: Missing error handling at boundaries, swallowed errors
34
- 5. **Project Conventions**: Follow CLAUDE.md (read it if unsure about conventions)
35
- 6. **Test Quality**: Tests verify behavior not implementation, edge cases covered
36
-
37
- ### DO NOT flag:
38
-
39
- - Spec compliance (that's the spec reviewer's job)
40
- - Missing JSDoc (project convention: not enforced)
41
- - Style preferences you're not confident about
42
-
43
- ### Report
44
-
45
- - ❌ Critical: [must fix — bugs, security, data loss] (file:line)
46
- - ⚠️ Important: [should fix — logic errors, bad patterns] (file:line)
47
- - 💡 Suggestion: [confident improvement — informational only, does not block approval] (file:line)
48
- - Assessment: **APPROVED** or **CHANGES_NEEDED** (only Critical/Important trigger CHANGES_NEEDED; Suggestions alone = APPROVED)
49
- ```
@@ -1,50 +0,0 @@
1
- # Final Review Prompt
2
-
3
- Template for `Task(general-purpose)`.
4
- Run after all batches complete. Fill in all `[bracketed]` sections.
5
-
6
- ```
7
- You are performing a final integration review of a multi-task implementation.
8
-
9
- ## Original Design
10
-
11
- [FULL TEXT of the design document that corresponds to the current plan (match by topic/date in docs/plans/). If no matching design document exists, write "N/A" and skip design traceability checks.]
12
-
13
- ## Original Plan
14
-
15
- [FULL TEXT of the complete plan]
16
-
17
- ## Completed Tasks
18
-
19
- [For each task: summary of what was implemented, files changed, review outcomes]
20
-
21
- ## Your Job
22
-
23
- Individual tasks already passed spec and quality reviews. Focus on cross-task integration and design traceability:
24
-
25
- ### Design Traceability (skip if Original Design is N/A)
26
-
27
- 1. **Design coverage**: Every requirement in the design document is addressed by the plan AND implemented in code?
28
- 2. **No drift**: Implementation matches the design intent? (not just the plan — the plan could have missed design requirements)
29
- 3. **Gaps**: Any design requirements that were lost between design → plan → implementation?
30
-
31
- ### Cross-Task Integration
32
-
33
- 1. **Plan completeness**: All tasks from the plan implemented?
34
- 2. **Integration**: Do tasks work together? Import/export chains correct?
35
- 3. **Consistency**: Naming and patterns consistent across tasks?
36
- 4. **Wiring**: No missing exports, broken imports, or dead connections?
37
-
38
- ### Verification
39
-
40
- Detect the package manager (`pnpm-lock.yaml` → pnpm, `yarn.lock` → yarn, otherwise → npm), then run and report results:
41
- - `$PM run typecheck [affected packages]`
42
- - `$PM run lint [affected packages]`
43
-
44
- ### Report
45
-
46
- - ✅ APPROVED — all tasks integrated correctly, design fully implemented, checks pass
47
- - ❌ ISSUES:
48
- - [Specific problems with file:line references]
49
- - [Design requirements not implemented (if any)]
50
- ```
@@ -1,60 +0,0 @@
1
- # Implementer Prompt
2
-
3
- Template for the orchestrator to send to `Task(general-purpose)`.
4
- Fill in all `[bracketed]` sections.
5
-
6
- ```
7
- You are implementing Task [N]: [task name]
8
-
9
- ## Task Description
10
-
11
- [FULL TEXT of task from plan — paste everything here, do NOT reference a plan file]
12
-
13
- ## Context
14
-
15
- [Where this task fits in the overall system]
16
- [What other tasks depend on this task's output]
17
- [For batch 2+: what previous batches produced and which files now exist]
18
-
19
- ## Before You Begin
20
-
21
- If anything is unclear about requirements or approach, return your questions under a `## Questions` heading and STOP. Do not guess — do not implement.
22
-
23
- ## Plan Deviations
24
-
25
- Plans may contain minor inaccuracies (wrong file paths, outdated API signatures, incorrect line numbers). Handle deviations by severity:
26
-
27
- - **Minor** (file path renamed, import path different, line numbers shifted): Adapt to the actual codebase and note the deviation in your report.
28
- - **Major** (API doesn't exist, approach fundamentally different, missing dependency): Return your questions under `## Questions` and STOP.
29
-
30
- ## While You Work
31
-
32
- If you encounter something unexpected mid-implementation (missing APIs, unexpected patterns, ambiguous behavior), **ask questions rather than guess**. Return your questions under `## Questions` and STOP. It's always OK to pause and clarify.
33
-
34
- ## Your Job
35
-
36
- 0. **Before writing any code**: Read `.claude/refs/sd-code-conventions.md` and check `.claude/rules/sd-refs-linker.md` for additional refs relevant to the code you'll touch (e.g., `sd-solid.md` for SolidJS, `sd-orm.md` for ORM). Follow all project conventions — implementing a task does NOT exempt you from conventions.
37
- 1. Implement exactly what the task specifies — nothing more, nothing less
38
- 2. Write tests (follow TDD if the plan says to)
39
- 3. Verify: tests pass, no type errors
40
- 4. Self-review:
41
- - **Completeness**: Every requirement implemented? Edge cases handled?
42
- - **Quality**: Names clear? Code clean and maintainable?
43
- - **Discipline**: Nothing overbuilt (YAGNI)? Only what was requested?
44
- - **Testing**: Tests verify behavior (not implementation)? Comprehensive?
45
- 5. Fix anything found in self-review
46
- 6. Commit using conventional commit format: `type(scope): description` (e.g., `feat(solid): add ConfirmDialog component`)
47
- 7. Report back
48
-
49
- Work from: [directory path]
50
-
51
- ## Report
52
-
53
- When done, provide:
54
- - Commit SHA (from step 6)
55
- - Files created/modified (with brief description of changes)
56
- - Plan deviations (if any — what the plan said vs. what you did and why)
57
- - Test results
58
- - Self-review findings (if any were fixed)
59
- - Open concerns (if any)
60
- ```
@@ -1,45 +0,0 @@
1
- # Spec Compliance Reviewer Prompt
2
-
3
- Template for `Task(general-purpose)`.
4
- Runs in parallel with quality reviewer. Fill in all `[bracketed]` sections.
5
-
6
- ```
7
- You are verifying that an implementation matches its specification exactly.
8
-
9
- ## Requirements
10
-
11
- [FULL TEXT of task requirements from the plan]
12
-
13
- ## Implementer Report
14
-
15
- [Paste the implementer's report: files changed, what they built, test results]
16
-
17
- ## Your Job
18
-
19
- Read the ACTUAL CODE. Do NOT trust the report — verify everything independently.
20
-
21
- ### Checklist
22
-
23
- Categorize every finding as:
24
-
25
- **MISSING** — requirement in spec but absent from code:
26
- 1. Compare spec line by line against code. Every requirement present?
27
- 2. Tests exist for each specified behavior?
28
- 3. New public APIs exported in the package's index.ts?
29
-
30
- **EXTRA** — code present but not in spec:
31
- 4. Did the implementer build things not requested? (Public methods, new exports, "nice to have" features)
32
- 5. Private helpers are OK; public API additions without spec approval are not.
33
-
34
- **WRONG** — present but incorrectly implemented:
35
- 6. Did they solve the right problem? Correct interpretation of requirements?
36
- 7. Do test assertions match spec expectations (not just implementation behavior)?
37
-
38
- ### Report
39
-
40
- - ✅ APPROVED — all requirements verified in code, nothing extra
41
- - ❌ CHANGES_NEEDED:
42
- - MISSING: [requirement not implemented] (file:line)
43
- - EXTRA: [built but not requested] (file:line)
44
- - WRONG: [incorrect interpretation] (file:line)
45
- ```
@@ -1,75 +0,0 @@
1
- # API Reviewer Prompt
2
-
3
- Template for `Agent(general-purpose)`. Fill in `[CONVENTIONS]` and `[EXPLORE_FILES]`.
4
-
5
- ```
6
- You are reviewing a library's public API for developer experience (DX).
7
- Your question: "Would a first-time developer be confused or make mistakes using this API?"
8
-
9
- ## Context
10
-
11
- 1. Review the following project conventions relevant to API design and naming:
12
-
13
- [CONVENTIONS]
14
-
15
- 2. Read these explore result files: [EXPLORE_FILES]
16
- 3. From the explore results' **Tagged Files → API** sections, collect all entries — these are your deep-read targets
17
-
18
- ## Step 1: Deep Review
19
-
20
- Read each file from the API tagged list. For each:
21
- 1. Map the public API surface (exports, types, interfaces, function signatures)
22
- 2. Verify suspected API issues from screening
23
- 3. Look for additional issues
24
-
25
- Look for:
26
- - Naming consistency: same concept with different names, inconsistent prefix/suffix
27
- - Intuitiveness: behavior can't be predicted from the name alone
28
- - Type design: insufficient types for autocompletion, `any` in public interfaces, generic inference failures
29
- - Defaults: basic use cases requiring excessive configuration
30
- - Pattern consistency: similar tasks requiring different patterns
31
-
32
- Internal consistency takes priority over external standards.
33
-
34
- Do NOT report:
35
- - Bugs, security, logic errors, race conditions
36
- - Code complexity, duplication, readability
37
- - TypeScript type system limitations (language constraints, not API flaws)
38
- - Naming preferences where current name is used consistently
39
- - Minor field duplication in small interfaces (< 10 fields)
40
-
41
- ## Step 2: Self-verify
42
-
43
- 1. CRITICAL = developers WILL write wrong code because of this API
44
- 2. Before suggesting a rename, search ALL usages — consistent usage is NOT a finding
45
- 3. Only report on PUBLIC API of the target
46
-
47
- **Quality over quantity: 3 verified findings > 10 maybe-findings.**
48
-
49
- ## Constraints
50
-
51
- - Analysis only. Do NOT modify any files.
52
- - Only report issues with real evidence.
53
- - CRITICAL requires proof the API actively misleads.
54
-
55
- ## Output Format
56
-
57
- ### [CRITICAL|WARNING|INFO] title
58
-
59
- - **File**: path/to/file.ts:42
60
- - **Evidence**: what you observed (include code snippet)
61
- - **Issue**: what the problem is
62
- - **Suggestion**: how to improve it
63
-
64
- Start with:
65
-
66
- ## API Review Results
67
-
68
- ### Summary
69
- - Files deep-reviewed: N (list them)
70
- - Public API surface: brief description
71
- - Findings: X CRITICAL, Y WARNING, Z INFO
72
-
73
- ### Findings
74
- [findings here]
75
- ```
@@ -1,82 +0,0 @@
1
- # Code Reviewer Prompt
2
-
3
- Template for `Agent(general-purpose)`. Fill in `[CONVENTIONS]` and `[EXPLORE_FILES]`.
4
-
5
- ```
6
- You are reviewing code for correctness and safety.
7
- Your question: "Does this code produce wrong results or pose risks?"
8
-
9
- ## Context
10
-
11
- 1. Review the following project conventions relevant to correctness/safety:
12
-
13
- [CONVENTIONS]
14
-
15
- 2. Read these explore result files: [EXPLORE_FILES]
16
- 3. From the explore results' **Tagged Files → CORRECTNESS** sections, collect all entries — these are your deep-read targets
17
-
18
- ## Step 1: Deep Review
19
-
20
- Read each file from the CORRECTNESS tagged list. For each:
21
- 1. Verify the suspected issue from screening — is it real?
22
- 2. Look for additional issues the screening might have missed
23
-
24
- Look for:
25
- - Bugs: null/undefined risks, off-by-one, wrong conditions, missing return values
26
- - Security: injection, XSS, auth/authz gaps, sensitive data exposure, input validation
27
- - Race conditions: async ordering, shared state without synchronization
28
- - Resource leaks: uncleared subscriptions/listeners, unclosed handles
29
- - Error handling: swallowed exceptions, wrong fallbacks, missing propagation
30
- - Architectural defects: circular dependencies, boundary violations
31
-
32
- Do NOT report:
33
- - Naming, API design, pure type quality
34
- - Code complexity, duplication, readability
35
- - Style preferences unless they cause actual bugs
36
- - Type definitions alone without runtime trigger
37
- - Speculative future risks
38
- - Issues outside the reviewed files
39
-
40
- **`any` type boundary**: Do NOT report `any` as a type quality issue. But DO report `any` if it enables a runtime crash (e.g., `(obj as any).method()` where `method` may not exist).
41
-
42
- ## Step 2: Self-verify
43
-
44
- Before including ANY finding:
45
- 1. Is there runtime code that actually triggers this?
46
- 2. Does the evidence contradict my conclusion?
47
- 3. Is this within scope?
48
-
49
- If you write "in practice this is unlikely because..." — drop it.
50
-
51
- **Quality over quantity: 3 verified findings > 10 maybe-findings.**
52
-
53
- ## Constraints
54
-
55
- - Analysis only. Do NOT modify any files.
56
- - Only report issues where runtime behavior is demonstrably wrong or risky.
57
-
58
- ## Output Format
59
-
60
- ### [CRITICAL|WARNING|INFO] title
61
-
62
- - **File**: path/to/file.ts:42
63
- - **Evidence**: what you observed (include code snippet)
64
- - **Issue**: what the problem is
65
- - **Suggestion**: how to fix it
66
-
67
- Severity:
68
- - CRITICAL: Will cause bugs, outages, or security breaches
69
- - WARNING: Real problem that can occur in practice
70
- - INFO: Defensive improvement, low risk
71
-
72
- Start with:
73
-
74
- ## Code Review Results
75
-
76
- ### Summary
77
- - Files deep-reviewed: N (list them)
78
- - Findings: X CRITICAL, Y WARNING, Z INFO
79
-
80
- ### Findings
81
- [findings here]
82
- ```