@shivaedev/quality 0.66.0 → 0.67.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +19 -0
- package/README.md +10 -8
- package/biome/declarations.json +7 -1
- package/biome/preset.json +7 -1
- package/dist/adapters/asymmetricMatcher.d.ts +3 -0
- package/dist/adapters/asymmetricMatcher.d.ts.map +1 -0
- package/dist/adapters/asymmetricMatcher.js +27 -0
- package/dist/adapters/asymmetricMatcher.js.map +1 -0
- package/dist/adapters/buildEntryPaths.d.ts +3 -0
- package/dist/adapters/buildEntryPaths.d.ts.map +1 -0
- package/dist/adapters/buildEntryPaths.js +48 -0
- package/dist/adapters/buildEntryPaths.js.map +1 -0
- package/dist/adapters/buildEntryValue.d.ts +4 -0
- package/dist/adapters/buildEntryValue.d.ts.map +1 -0
- package/dist/adapters/buildEntryValue.js +47 -0
- package/dist/adapters/buildEntryValue.js.map +1 -0
- package/dist/adapters/bundlerEntries.d.ts +3 -0
- package/dist/adapters/bundlerEntries.d.ts.map +1 -0
- package/dist/adapters/bundlerEntries.js +49 -0
- package/dist/adapters/bundlerEntries.js.map +1 -0
- package/dist/adapters/callbackEscapes.d.ts +3 -0
- package/dist/adapters/callbackEscapes.d.ts.map +1 -0
- package/dist/adapters/callbackEscapes.js +24 -0
- package/dist/adapters/callbackEscapes.js.map +1 -0
- package/dist/adapters/composedContext.d.ts +3 -0
- package/dist/adapters/composedContext.d.ts.map +1 -0
- package/dist/adapters/composedContext.js +42 -0
- package/dist/adapters/composedContext.js.map +1 -0
- package/dist/adapters/containerDependency.d.ts +4 -0
- package/dist/adapters/containerDependency.d.ts.map +1 -0
- package/dist/adapters/containerDependency.js +28 -0
- package/dist/adapters/containerDependency.js.map +1 -0
- package/dist/adapters/contextCaptureFindings.d.ts.map +1 -1
- package/dist/adapters/contextCaptureFindings.js +3 -1
- package/dist/adapters/contextCaptureFindings.js.map +1 -1
- package/dist/adapters/foreignResources.d.ts +3 -0
- package/dist/adapters/foreignResources.d.ts.map +1 -0
- package/dist/adapters/foreignResources.js +80 -0
- package/dist/adapters/foreignResources.js.map +1 -0
- package/dist/adapters/frameworkCallback.d.ts +4 -0
- package/dist/adapters/frameworkCallback.d.ts.map +1 -0
- package/dist/adapters/frameworkCallback.js +92 -0
- package/dist/adapters/frameworkCallback.js.map +1 -0
- package/dist/adapters/frameworkOwner.d.ts +3 -0
- package/dist/adapters/frameworkOwner.d.ts.map +1 -0
- package/dist/adapters/frameworkOwner.js +35 -0
- package/dist/adapters/frameworkOwner.js.map +1 -0
- package/dist/adapters/importedCall.d.ts +6 -0
- package/dist/adapters/importedCall.d.ts.map +1 -0
- package/dist/adapters/importedCall.js +26 -0
- package/dist/adapters/importedCall.js.map +1 -0
- package/dist/adapters/isToolConfig.d.ts +2 -0
- package/dist/adapters/isToolConfig.d.ts.map +1 -0
- package/dist/adapters/isToolConfig.js +7 -0
- package/dist/adapters/isToolConfig.js.map +1 -0
- package/dist/adapters/knip/configuration.d.ts +1 -1
- package/dist/adapters/knip/configuration.d.ts.map +1 -1
- package/dist/adapters/knip/configuration.js +5 -3
- package/dist/adapters/knip/configuration.js.map +1 -1
- package/dist/adapters/knip/run.d.ts.map +1 -1
- package/dist/adapters/knip/run.js +3 -1
- package/dist/adapters/knip/run.js.map +1 -1
- package/dist/adapters/localFunctions.d.ts +3 -0
- package/dist/adapters/localFunctions.d.ts.map +1 -0
- package/dist/adapters/localFunctions.js +20 -0
- package/dist/adapters/localFunctions.js.map +1 -0
- package/dist/adapters/pureReader.d.ts +3 -0
- package/dist/adapters/pureReader.d.ts.map +1 -0
- package/dist/adapters/pureReader.js +52 -0
- package/dist/adapters/pureReader.js.map +1 -0
- package/dist/adapters/reachableBuildEntries.d.ts +5 -0
- package/dist/adapters/reachableBuildEntries.d.ts.map +1 -0
- package/dist/adapters/reachableBuildEntries.js +52 -0
- package/dist/adapters/reachableBuildEntries.js.map +1 -0
- package/dist/adapters/readConfig.js +1 -1
- package/dist/adapters/readConfig.js.map +1 -1
- package/dist/adapters/scriptPaths.d.ts +2 -0
- package/dist/adapters/scriptPaths.d.ts.map +1 -0
- package/dist/adapters/scriptPaths.js +5 -0
- package/dist/adapters/scriptPaths.js.map +1 -0
- package/dist/adapters/serviceStateProblems.d.ts.map +1 -1
- package/dist/adapters/serviceStateProblems.js +26 -14
- package/dist/adapters/serviceStateProblems.js.map +1 -1
- package/dist/adapters/specReaderSources.d.ts +7 -0
- package/dist/adapters/specReaderSources.d.ts.map +1 -0
- package/dist/adapters/specReaderSources.js +73 -0
- package/dist/adapters/specReaderSources.js.map +1 -0
- package/dist/cli/args.js +2 -2
- package/dist/cli/args.js.map +1 -1
- package/dist/cli/fix.d.ts +0 -1
- package/dist/cli/fix.d.ts.map +1 -1
- package/dist/cli/fix.js +1 -1
- package/dist/cli/fix.js.map +1 -1
- package/dist/cli/limits.d.ts +2 -0
- package/dist/cli/limits.d.ts.map +1 -0
- package/dist/cli/limits.js +2 -0
- package/dist/cli/limits.js.map +1 -0
- package/dist/cli/{options.d.ts → misplaced.d.ts} +1 -1
- package/dist/cli/misplaced.d.ts.map +1 -0
- package/dist/cli/{options.js → misplaced.js} +1 -1
- package/dist/cli/misplaced.js.map +1 -0
- package/dist/cli/program.js +1 -1
- package/dist/cli/program.js.map +1 -1
- package/dist/cli/subcommands.d.ts +2 -0
- package/dist/cli/subcommands.d.ts.map +1 -0
- package/dist/cli/subcommands.js +6 -0
- package/dist/cli/subcommands.js.map +1 -0
- package/dist/cli/{messages.d.ts → usage.d.ts} +1 -2
- package/dist/cli/usage.d.ts.map +1 -0
- package/{src/cli/messages.ts → dist/cli/usage.js} +1 -6
- package/dist/cli/usage.js.map +1 -0
- package/dist/config/defaultExtensions.d.ts +2 -0
- package/dist/config/defaultExtensions.d.ts.map +1 -0
- package/{src/config/constants.ts → dist/config/defaultExtensions.js} +1 -2
- package/dist/config/defaultExtensions.js.map +1 -0
- package/dist/config/file.d.ts +2 -0
- package/dist/config/file.d.ts.map +1 -0
- package/dist/config/file.js +2 -0
- package/dist/config/file.js.map +1 -0
- package/dist/config/load.js +1 -1
- package/dist/config/load.js.map +1 -1
- package/dist/hooks/install.js +1 -1
- package/dist/hooks/install.js.map +1 -1
- package/dist/imports/testComposition.d.ts +4 -0
- package/dist/imports/testComposition.d.ts.map +1 -0
- package/dist/imports/testComposition.js +38 -0
- package/dist/imports/testComposition.js.map +1 -0
- package/dist/inventory/programmaticEntries.d.ts +4 -0
- package/dist/inventory/programmaticEntries.d.ts.map +1 -0
- package/dist/inventory/programmaticEntries.js +9 -0
- package/dist/inventory/programmaticEntries.js.map +1 -0
- package/dist/naming/adapters/plainData.d.ts +5 -0
- package/dist/naming/adapters/plainData.d.ts.map +1 -0
- package/dist/naming/adapters/plainData.js +77 -0
- package/dist/naming/adapters/plainData.js.map +1 -0
- package/dist/naming/constantModule.d.ts +3 -0
- package/dist/naming/constantModule.d.ts.map +1 -0
- package/dist/naming/constantModule.js +25 -0
- package/dist/naming/constantModule.js.map +1 -0
- package/dist/naming/{migrationFile.d.ts → isMigrationFile.d.ts} +1 -1
- package/dist/naming/isMigrationFile.d.ts.map +1 -0
- package/dist/naming/{migrationFile.js → isMigrationFile.js} +1 -1
- package/dist/naming/isMigrationFile.js.map +1 -0
- package/dist/naming/ownExports.d.ts +0 -1
- package/dist/naming/ownExports.d.ts.map +1 -1
- package/dist/naming/ownExports.js +11 -25
- package/dist/naming/ownExports.js.map +1 -1
- package/dist/naming/packageTests.d.ts +7 -0
- package/dist/naming/packageTests.d.ts.map +1 -0
- package/dist/naming/packageTests.js +21 -0
- package/dist/naming/packageTests.js.map +1 -0
- package/dist/naming/testCode.d.ts +4 -0
- package/dist/naming/testCode.d.ts.map +1 -0
- package/dist/naming/testCode.js +46 -0
- package/dist/naming/testCode.js.map +1 -0
- package/dist/rules/comments/kinds.js +1 -1
- package/dist/rules/comments/kinds.js.map +1 -1
- package/dist/rules/effect/contextCapture.js +1 -1
- package/dist/rules/effect/contextCapture.js.map +1 -1
- package/dist/rules/effect/program.d.ts +1 -0
- package/dist/rules/effect/program.d.ts.map +1 -1
- package/dist/rules/effect/program.js +17 -1
- package/dist/rules/effect/program.js.map +1 -1
- package/dist/rules/effect/serviceCatalog.d.ts.map +1 -1
- package/dist/rules/effect/serviceCatalog.js +10 -2
- package/dist/rules/effect/serviceCatalog.js.map +1 -1
- package/dist/rules/effect/serviceFindings.d.ts.map +1 -1
- package/dist/rules/effect/serviceFindings.js +33 -7
- package/dist/rules/effect/serviceFindings.js.map +1 -1
- package/dist/rules/effect/serviceOrigin.d.ts.map +1 -1
- package/dist/rules/effect/serviceOrigin.js +13 -1
- package/dist/rules/effect/serviceOrigin.js.map +1 -1
- package/dist/rules/effect/serviceParameters.d.ts.map +1 -1
- package/dist/rules/effect/serviceParameters.js +12 -12
- package/dist/rules/effect/serviceParameters.js.map +1 -1
- package/dist/rules/effect/serviceTypes.d.ts.map +1 -1
- package/dist/rules/effect/serviceTypes.js +5 -1
- package/dist/rules/effect/serviceTypes.js.map +1 -1
- package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
- package/dist/rules/files/namedAfterExport.js +36 -23
- package/dist/rules/files/namedAfterExport.js.map +1 -1
- package/dist/rules/imports/manifest.d.ts.map +1 -1
- package/dist/rules/imports/manifest.js +9 -11
- package/dist/rules/imports/manifest.js.map +1 -1
- package/dist/rules/imports/noTestCode.d.ts.map +1 -1
- package/dist/rules/imports/noTestCode.js +13 -9
- package/dist/rules/imports/noTestCode.js.map +1 -1
- package/dist/rules/maxLines.d.ts.map +1 -1
- package/dist/rules/maxLines.js +7 -2
- package/dist/rules/maxLines.js.map +1 -1
- package/dist/rules/stories/specHelpers.d.ts.map +1 -1
- package/dist/rules/stories/specHelpers.js +8 -4
- package/dist/rules/stories/specHelpers.js.map +1 -1
- package/dist/rules/suppressions/{directives.d.ts → in.d.ts} +1 -1
- package/dist/rules/suppressions/in.d.ts.map +1 -0
- package/dist/rules/suppressions/{directives.js → in.js} +1 -1
- package/dist/rules/suppressions/in.js.map +1 -0
- package/dist/rules/suppressions/noInline.js +1 -1
- package/dist/rules/suppressions/noInline.js.map +1 -1
- package/dist/rules/test-names/colocated.d.ts.map +1 -1
- package/dist/rules/test-names/colocated.js +7 -4
- package/dist/rules/test-names/colocated.js.map +1 -1
- package/dist/rules/test-names/follow.d.ts.map +1 -1
- package/dist/rules/test-names/follow.js +13 -6
- package/dist/rules/test-names/follow.js.map +1 -1
- package/package.json +4 -3
- package/src/adapters/asymmetricMatcher.ts +33 -0
- package/src/adapters/buildEntryPaths.ts +52 -0
- package/src/adapters/buildEntryValue.ts +52 -0
- package/src/adapters/bundlerEntries.ts +53 -0
- package/src/adapters/callbackEscapes.ts +32 -0
- package/src/adapters/composedContext.ts +48 -0
- package/src/adapters/containerDependency.ts +40 -0
- package/src/adapters/contextCaptureFindings.ts +3 -1
- package/src/adapters/foreignResources.ts +83 -0
- package/src/adapters/frameworkCallback.ts +106 -0
- package/src/adapters/frameworkOwner.ts +41 -0
- package/src/adapters/importedCall.ts +27 -0
- package/src/adapters/isToolConfig.ts +10 -0
- package/src/adapters/knip/configuration.ts +5 -7
- package/src/adapters/knip/run.ts +3 -1
- package/src/adapters/localFunctions.ts +22 -0
- package/src/adapters/pureReader.ts +56 -0
- package/src/adapters/reachableBuildEntries.ts +58 -0
- package/src/adapters/readConfig.ts +1 -1
- package/src/adapters/scriptPaths.ts +5 -0
- package/src/adapters/serviceStateProblems.ts +42 -17
- package/src/adapters/specReaderSources.ts +77 -0
- package/src/cli/args.ts +2 -2
- package/src/cli/fix.ts +1 -2
- package/src/cli/limits.ts +1 -0
- package/src/cli/program.ts +1 -1
- package/src/cli/subcommands.ts +5 -0
- package/{dist/cli/messages.js → src/cli/usage.ts} +0 -6
- package/{dist/config/constants.js → src/config/defaultExtensions.ts} +0 -2
- package/src/config/file.ts +1 -0
- package/src/config/load.ts +1 -1
- package/src/hooks/install.ts +1 -1
- package/src/imports/testComposition.ts +47 -0
- package/src/inventory/programmaticEntries.ts +10 -0
- package/src/naming/adapters/plainData.ts +88 -0
- package/src/naming/constantModule.ts +28 -0
- package/src/naming/ownExports.ts +11 -28
- package/src/naming/packageTests.ts +24 -0
- package/src/naming/testCode.ts +62 -0
- package/src/rules/comments/kinds.ts +1 -1
- package/src/rules/effect/contextCapture.ts +1 -1
- package/src/rules/effect/program.ts +19 -1
- package/src/rules/effect/serviceCatalog.ts +12 -2
- package/src/rules/effect/serviceFindings.ts +38 -7
- package/src/rules/effect/serviceOrigin.ts +14 -1
- package/src/rules/effect/serviceParameters.ts +13 -14
- package/src/rules/effect/serviceTypes.ts +11 -1
- package/src/rules/files/namedAfterExport.ts +46 -23
- package/src/rules/imports/manifest.ts +18 -10
- package/src/rules/imports/noTestCode.ts +13 -12
- package/src/rules/maxLines.ts +7 -3
- package/src/rules/stories/specHelpers.ts +14 -4
- package/src/rules/suppressions/noInline.ts +1 -1
- package/src/rules/test-names/colocated.ts +7 -4
- package/src/rules/test-names/follow.ts +13 -6
- package/dist/adapters/initializerDependency.d.ts +0 -3
- package/dist/adapters/initializerDependency.d.ts.map +0 -1
- package/dist/adapters/initializerDependency.js +0 -53
- package/dist/adapters/initializerDependency.js.map +0 -1
- package/dist/cli/messages.d.ts.map +0 -1
- package/dist/cli/messages.js.map +0 -1
- package/dist/cli/options.d.ts.map +0 -1
- package/dist/cli/options.js.map +0 -1
- package/dist/config/constants.d.ts +0 -3
- package/dist/config/constants.d.ts.map +0 -1
- package/dist/config/constants.js.map +0 -1
- package/dist/naming/migrationFile.d.ts.map +0 -1
- package/dist/naming/migrationFile.js.map +0 -1
- package/dist/rules/suppressions/directives.d.ts.map +0 -1
- package/dist/rules/suppressions/directives.js.map +0 -1
- package/src/adapters/initializerDependency.ts +0 -57
- /package/src/cli/{options.ts → misplaced.ts} +0 -0
- /package/src/naming/{migrationFile.ts → isMigrationFile.ts} +0 -0
- /package/src/rules/suppressions/{directives.ts → in.ts} +0 -0
|
@@ -0,0 +1,83 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { serviceProperty } from "#adapters/serviceAssemblySyntax.ts";
|
|
3
|
+
import { effectApi, resolvedValue } from "#adapters/serviceModelSyntax.ts";
|
|
4
|
+
import { returnValues } from "#rules/stories/returnValues.ts";
|
|
5
|
+
|
|
6
|
+
function foreign(node: ts.Declaration): boolean {
|
|
7
|
+
const file = node.getSourceFile().fileName.replaceAll("\\", "/");
|
|
8
|
+
return file.includes("/node_modules/") && !/\/(?:effect|@effect|@shivaedev)\//u.test(file);
|
|
9
|
+
}
|
|
10
|
+
|
|
11
|
+
function constructed(checker: ts.TypeChecker, node: ts.Node, seen = new Set<ts.Node>()): boolean {
|
|
12
|
+
if (seen.has(node)) {
|
|
13
|
+
return false;
|
|
14
|
+
}
|
|
15
|
+
seen.add(node);
|
|
16
|
+
if (ts.isExpression(node)) {
|
|
17
|
+
const value = resolvedValue(checker, node);
|
|
18
|
+
if (value !== node) {
|
|
19
|
+
return constructed(checker, value, seen);
|
|
20
|
+
}
|
|
21
|
+
}
|
|
22
|
+
if (ts.isCallExpression(node) || ts.isNewExpression(node)) {
|
|
23
|
+
return acquisition(checker, node, seen);
|
|
24
|
+
}
|
|
25
|
+
if (ts.isYieldExpression(node)) {
|
|
26
|
+
return node.expression === undefined ? false : constructed(checker, node.expression, seen);
|
|
27
|
+
}
|
|
28
|
+
return ts.isFunctionLike(node) && returnValues(node).some((value) => value !== undefined && constructed(checker, value, seen));
|
|
29
|
+
}
|
|
30
|
+
|
|
31
|
+
function acquisition(checker: ts.TypeChecker, node: ts.CallExpression | ts.NewExpression, seen: Set<ts.Node>): boolean {
|
|
32
|
+
const signature = checker.getResolvedSignature(node);
|
|
33
|
+
if (signature?.declaration !== undefined && foreign(signature.declaration)) {
|
|
34
|
+
return true;
|
|
35
|
+
}
|
|
36
|
+
if (!(ts.isCallExpression(node) && ["promise", "tryPromise", "sync", "acquireRelease"].some((name) => effectApi(checker, node.expression, name)))) {
|
|
37
|
+
return false;
|
|
38
|
+
}
|
|
39
|
+
const value = node.arguments[0];
|
|
40
|
+
const callback = value !== undefined && ts.isObjectLiteralExpression(value) ? serviceProperty(value, "try") : value;
|
|
41
|
+
return callback !== undefined && constructed(checker, callback, seen);
|
|
42
|
+
}
|
|
43
|
+
|
|
44
|
+
export function foreignResources(checker: ts.TypeChecker, sources: readonly ts.SourceFile[]) {
|
|
45
|
+
let calls: Map<ts.ParameterDeclaration, ts.Expression[]> | undefined;
|
|
46
|
+
function argumentsIn() {
|
|
47
|
+
if (calls !== undefined) {
|
|
48
|
+
return calls;
|
|
49
|
+
}
|
|
50
|
+
const arguments_ = new Map<ts.ParameterDeclaration, ts.Expression[]>();
|
|
51
|
+
function visit(node: ts.Node): void {
|
|
52
|
+
if (ts.isCallExpression(node)) {
|
|
53
|
+
const declaration = checker.getResolvedSignature(node)?.declaration;
|
|
54
|
+
for (const [index, parameter] of (declaration?.parameters ?? []).entries()) {
|
|
55
|
+
const argument = node.arguments[index];
|
|
56
|
+
if (argument !== undefined && ts.isParameter(parameter)) {
|
|
57
|
+
const values = arguments_.get(parameter) ?? [];
|
|
58
|
+
values.push(argument);
|
|
59
|
+
arguments_.set(parameter, values);
|
|
60
|
+
}
|
|
61
|
+
}
|
|
62
|
+
}
|
|
63
|
+
ts.forEachChild(node, visit);
|
|
64
|
+
}
|
|
65
|
+
for (const source of sources) {
|
|
66
|
+
visit(source);
|
|
67
|
+
}
|
|
68
|
+
calls = arguments_;
|
|
69
|
+
return arguments_;
|
|
70
|
+
}
|
|
71
|
+
return (parameter: ts.ParameterDeclaration): boolean => {
|
|
72
|
+
const source = parameter.getSourceFile();
|
|
73
|
+
if (!/(?:^|\/)adapters\//u.test(source.fileName)) {
|
|
74
|
+
return false;
|
|
75
|
+
}
|
|
76
|
+
const type = checker.getTypeAtLocation(parameter);
|
|
77
|
+
if (!(type.getSymbol()?.declarations ?? []).some(foreign) || type.getProperty("~effect/Context/Service") !== undefined) {
|
|
78
|
+
return false;
|
|
79
|
+
}
|
|
80
|
+
const values = argumentsIn().get(parameter) ?? [];
|
|
81
|
+
return values.length > 0 && values.every((value) => constructed(checker, value));
|
|
82
|
+
};
|
|
83
|
+
}
|
|
@@ -0,0 +1,106 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { callbackEscapes } from "#adapters/callbackEscapes.ts";
|
|
3
|
+
import { frameworkOwner } from "#adapters/frameworkOwner.ts";
|
|
4
|
+
import { effectApi, resolvedValue } from "#adapters/serviceModelSyntax.ts";
|
|
5
|
+
|
|
6
|
+
function supplied(signature: ts.Signature, local: ReadonlySet<ts.SourceFile>): boolean {
|
|
7
|
+
return signature.declaration !== undefined && !local.has(signature.declaration.getSourceFile());
|
|
8
|
+
}
|
|
9
|
+
|
|
10
|
+
function wrapsEffectFunction(checker: ts.TypeChecker, expression: ts.Expression): boolean {
|
|
11
|
+
let callee = expression;
|
|
12
|
+
let value: ts.Node = ts.isIdentifier(callee) ? resolvedValue(checker, callee) : callee;
|
|
13
|
+
while (ts.isCallExpression(value)) {
|
|
14
|
+
if (value.arguments.some((argument) => checker.getTypeAtLocation(argument).getCallSignatures().length > 0)) {
|
|
15
|
+
return false;
|
|
16
|
+
}
|
|
17
|
+
callee = value.expression;
|
|
18
|
+
value = ts.isIdentifier(callee) ? resolvedValue(checker, callee) : callee;
|
|
19
|
+
}
|
|
20
|
+
return effectApi(checker, callee, "fn") || effectApi(checker, callee, "fnUntraced");
|
|
21
|
+
}
|
|
22
|
+
|
|
23
|
+
export function frameworkCallback(checker: ts.TypeChecker, node: ts.Node, local: ReadonlySet<ts.SourceFile>, seen = new Set<ts.Node>()): boolean {
|
|
24
|
+
if (seen.has(node)) {
|
|
25
|
+
return false;
|
|
26
|
+
}
|
|
27
|
+
seen.add(node);
|
|
28
|
+
if (!(ts.isArrowFunction(node) || ts.isFunctionExpression(node))) {
|
|
29
|
+
return false;
|
|
30
|
+
}
|
|
31
|
+
if (ts.isCallExpression(node.parent)) {
|
|
32
|
+
if (wrapsEffectFunction(checker, node.parent.expression)) {
|
|
33
|
+
return false;
|
|
34
|
+
}
|
|
35
|
+
if (frameworkOwner(checker, node.parent.expression, local, (owner) => frameworkCallback(checker, owner, local, seen))) {
|
|
36
|
+
const parent = node.parent.parent;
|
|
37
|
+
return !(
|
|
38
|
+
(ts.isVariableDeclaration(parent)
|
|
39
|
+
|| ts.isReturnStatement(parent)
|
|
40
|
+
|| ts.isPropertyAssignment(parent)
|
|
41
|
+
|| (ts.isCallExpression(parent) && parent.expression === node.parent))
|
|
42
|
+
&& callbackEscapes(checker, node.parent, node)
|
|
43
|
+
);
|
|
44
|
+
}
|
|
45
|
+
return !callbackEscapes(checker, node.parent, node);
|
|
46
|
+
}
|
|
47
|
+
const contextual = checker.getContextualType(node);
|
|
48
|
+
if ((contextual === undefined ? [] : checker.getNonNullableType(contextual).getCallSignatures()).some((signature) => supplied(signature, local))) {
|
|
49
|
+
return true;
|
|
50
|
+
}
|
|
51
|
+
const property = node.parent;
|
|
52
|
+
const object = property.parent;
|
|
53
|
+
const call = object.parent;
|
|
54
|
+
return (
|
|
55
|
+
ts.isPropertyAssignment(property)
|
|
56
|
+
&& ts.isObjectLiteralExpression(object)
|
|
57
|
+
&& ts.isCallExpression(call)
|
|
58
|
+
&& checker
|
|
59
|
+
.getTypeAtLocation(call.expression)
|
|
60
|
+
.getCallSignatures()
|
|
61
|
+
.some((signature) => supplied(signature, local))
|
|
62
|
+
);
|
|
63
|
+
}
|
|
64
|
+
|
|
65
|
+
function overloadedParameter(checker: ts.TypeChecker, parameter: ts.ParameterDeclaration): ts.ParameterDeclaration | undefined {
|
|
66
|
+
const fn = parameter.parent;
|
|
67
|
+
if ((ts.isFunctionDeclaration(fn) || ts.isMethodDeclaration(fn)) && fn.name !== undefined) {
|
|
68
|
+
const symbol = checker.getSymbolAtLocation(fn.name);
|
|
69
|
+
const signature = symbol?.declarations?.find(
|
|
70
|
+
(declaration) => (ts.isFunctionDeclaration(declaration) || ts.isMethodDeclaration(declaration)) && declaration.body === undefined,
|
|
71
|
+
);
|
|
72
|
+
if (signature !== undefined && (ts.isFunctionDeclaration(signature) || ts.isMethodDeclaration(signature))) {
|
|
73
|
+
return signature.parameters[fn.parameters.indexOf(parameter)];
|
|
74
|
+
}
|
|
75
|
+
}
|
|
76
|
+
return undefined;
|
|
77
|
+
}
|
|
78
|
+
|
|
79
|
+
export function parameterSite(
|
|
80
|
+
checker: ts.TypeChecker,
|
|
81
|
+
parameter: ts.ParameterDeclaration,
|
|
82
|
+
local: ReadonlySet<ts.SourceFile>,
|
|
83
|
+
): ts.ParameterDeclaration {
|
|
84
|
+
const fn = parameter.parent;
|
|
85
|
+
const overload = overloadedParameter(checker, parameter);
|
|
86
|
+
if (overload !== undefined) {
|
|
87
|
+
return overload;
|
|
88
|
+
}
|
|
89
|
+
if (!(ts.isArrowFunction(fn) || ts.isFunctionExpression(fn))) {
|
|
90
|
+
return parameter;
|
|
91
|
+
}
|
|
92
|
+
const contextual = checker.getContextualType(fn);
|
|
93
|
+
const signature = contextual === undefined ? undefined : checker.getNonNullableType(contextual).getCallSignatures()[0];
|
|
94
|
+
const declared = signature?.declaration;
|
|
95
|
+
if (declared !== undefined && declared !== fn && local.has(declared.getSourceFile())) {
|
|
96
|
+
const site = declared.parameters[fn.parameters.indexOf(parameter)];
|
|
97
|
+
if (site !== undefined && ts.isParameter(site)) {
|
|
98
|
+
return site;
|
|
99
|
+
}
|
|
100
|
+
}
|
|
101
|
+
const variable = fn.parent;
|
|
102
|
+
if (!(ts.isVariableDeclaration(variable) && variable.type !== undefined && ts.isFunctionTypeNode(variable.type))) {
|
|
103
|
+
return parameter;
|
|
104
|
+
}
|
|
105
|
+
return variable.type.parameters[fn.parameters.indexOf(parameter)] ?? parameter;
|
|
106
|
+
}
|
|
@@ -0,0 +1,41 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
|
|
3
|
+
export function frameworkOwner(
|
|
4
|
+
checker: ts.TypeChecker,
|
|
5
|
+
node: ts.Node,
|
|
6
|
+
local: ReadonlySet<ts.SourceFile>,
|
|
7
|
+
callback: (node: ts.Node) => boolean,
|
|
8
|
+
seen = new Set<ts.Node>(),
|
|
9
|
+
): boolean {
|
|
10
|
+
if (seen.has(node)) {
|
|
11
|
+
return false;
|
|
12
|
+
}
|
|
13
|
+
seen.add(node);
|
|
14
|
+
if (ts.isArrayLiteralExpression(node)) {
|
|
15
|
+
return true;
|
|
16
|
+
}
|
|
17
|
+
if (ts.isYieldExpression(node)) {
|
|
18
|
+
return node.expression !== undefined && frameworkOwner(checker, node.expression, local, callback, seen);
|
|
19
|
+
}
|
|
20
|
+
if (ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node) || ts.isCallExpression(node) || ts.isParenthesizedExpression(node)) {
|
|
21
|
+
return frameworkOwner(checker, node.expression, local, callback, seen);
|
|
22
|
+
}
|
|
23
|
+
if (!ts.isIdentifier(node)) {
|
|
24
|
+
return false;
|
|
25
|
+
}
|
|
26
|
+
const symbol = checker.getSymbolAtLocation(node);
|
|
27
|
+
const target = symbol !== undefined && symbol.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(symbol) : symbol;
|
|
28
|
+
return (target?.declarations ?? []).some((declaration) => {
|
|
29
|
+
if (!local.has(declaration.getSourceFile())) {
|
|
30
|
+
return true;
|
|
31
|
+
}
|
|
32
|
+
if (ts.isVariableDeclaration(declaration) && declaration.initializer !== undefined) {
|
|
33
|
+
return frameworkOwner(checker, declaration.initializer, local, callback, seen);
|
|
34
|
+
}
|
|
35
|
+
let parameter: ts.Node = declaration;
|
|
36
|
+
while (ts.isBindingElement(parameter) || ts.isObjectBindingPattern(parameter) || ts.isArrayBindingPattern(parameter)) {
|
|
37
|
+
parameter = parameter.parent;
|
|
38
|
+
}
|
|
39
|
+
return ts.isParameter(parameter) && callback(parameter.parent);
|
|
40
|
+
});
|
|
41
|
+
}
|
|
@@ -0,0 +1,27 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
|
|
3
|
+
function calledName(expression: ts.LeftHandSideExpression, clause: ts.ImportClause): string | undefined {
|
|
4
|
+
const bindings = clause.namedBindings;
|
|
5
|
+
if (ts.isIdentifier(expression) && bindings !== undefined && ts.isNamedImports(bindings)) {
|
|
6
|
+
const imported = bindings.elements.find((element) => element.name.text === expression.text);
|
|
7
|
+
return imported === undefined ? undefined : (imported.propertyName ?? imported.name).text;
|
|
8
|
+
}
|
|
9
|
+
if (!(ts.isPropertyAccessExpression(expression) && ts.isIdentifier(expression.expression))) {
|
|
10
|
+
return undefined;
|
|
11
|
+
}
|
|
12
|
+
const namespace = bindings !== undefined && ts.isNamespaceImport(bindings) ? bindings.name.text : clause.name?.text;
|
|
13
|
+
return namespace === expression.expression.text ? expression.name.text : undefined;
|
|
14
|
+
}
|
|
15
|
+
|
|
16
|
+
export function importedCall(call: ts.CallExpression): { readonly module: string; readonly name: string } | undefined {
|
|
17
|
+
for (const statement of call.getSourceFile().statements) {
|
|
18
|
+
if (!(ts.isImportDeclaration(statement) && ts.isStringLiteral(statement.moduleSpecifier)) || statement.importClause === undefined) {
|
|
19
|
+
continue;
|
|
20
|
+
}
|
|
21
|
+
const name = calledName(call.expression, statement.importClause);
|
|
22
|
+
if (name !== undefined) {
|
|
23
|
+
return { module: statement.moduleSpecifier.text, name };
|
|
24
|
+
}
|
|
25
|
+
}
|
|
26
|
+
return undefined;
|
|
27
|
+
}
|
|
@@ -0,0 +1,10 @@
|
|
|
1
|
+
import { posix } from "node:path";
|
|
2
|
+
import preset from "#biome-preset" with { type: "json" };
|
|
3
|
+
|
|
4
|
+
const PATTERNS = preset.overrides.flatMap((override) =>
|
|
5
|
+
override.includes.includes("**/*.config.*") && override.linter?.rules?.style?.noDefaultExport === "off" ? override.includes : [],
|
|
6
|
+
);
|
|
7
|
+
|
|
8
|
+
export function isToolConfig(path: string): boolean {
|
|
9
|
+
return PATTERNS.some((pattern) => posix.matchesGlob(path, pattern));
|
|
10
|
+
}
|
|
@@ -1,5 +1,6 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
2
|
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
3
|
+
import { scriptPaths } from "#adapters/scriptPaths.ts";
|
|
3
4
|
import { exportedModule, exportTargets } from "#imports/packageExports.ts";
|
|
4
5
|
import { packageOf, workspacePackages } from "#imports/workspace.ts";
|
|
5
6
|
import { SHADCN_FILE_GLOB } from "#inventory/shadcnFiles.ts";
|
|
@@ -25,7 +26,7 @@ function importPaths(imports: Readonly<Record<string, unknown>>) {
|
|
|
25
26
|
);
|
|
26
27
|
}
|
|
27
28
|
|
|
28
|
-
export async function knipConfiguration(inputs: RuleInputs, toolOwned: readonly string[] = []) {
|
|
29
|
+
export async function knipConfiguration(inputs: RuleInputs, toolOwned: readonly string[] = [], programmatic: ReadonlySet<string> = new Set()) {
|
|
29
30
|
const packages = await workspacePackages(inputs);
|
|
30
31
|
const manifests = await Promise.all(
|
|
31
32
|
[".", ...packages.map(({ directory }) => directory)].map(async (directory) => {
|
|
@@ -33,16 +34,13 @@ export async function knipConfiguration(inputs: RuleInputs, toolOwned: readonly
|
|
|
33
34
|
return { directory, manifest };
|
|
34
35
|
}),
|
|
35
36
|
);
|
|
36
|
-
const scripted = new Set(
|
|
37
|
-
manifests.flatMap(({ directory, manifest }) =>
|
|
38
|
-
Object.values(manifest.scripts ?? {}).flatMap((script) => script.split(/[\s'"`;|&()]+/u).map((word) => posix.join(directory, word))),
|
|
39
|
-
),
|
|
40
|
-
);
|
|
37
|
+
const scripted = new Set(manifests.flatMap(({ directory, manifest }) => scriptPaths(directory, manifest.scripts ?? {})));
|
|
41
38
|
const workspaces = manifests.map(({ directory, manifest }) => {
|
|
42
39
|
const sources = inputs.sources
|
|
43
40
|
.filter(({ path }) => (packageOf(packages, path)?.directory ?? ".") === directory)
|
|
44
41
|
.map(({ path }) => posix.relative(directory, path));
|
|
45
42
|
const scriptEntries = sources.filter((path) => scripted.has(posix.join(directory, path)));
|
|
43
|
+
const bundled = sources.filter((path) => programmatic.has(posix.join(directory, path)));
|
|
46
44
|
const bins = exportTargets(manifest.bin).map((target) => target.replace(/^\.\//u, ""));
|
|
47
45
|
const binaries = sources.filter(
|
|
48
46
|
(path) => bins.includes(path) || bins.includes(path.replace(/^src\//u, "dist/").replace(/\.(?<mode>[cm]?)tsx?$/u, ".$<mode>js")),
|
|
@@ -59,7 +57,7 @@ export async function knipConfiguration(inputs: RuleInputs, toolOwned: readonly
|
|
|
59
57
|
return [
|
|
60
58
|
directory,
|
|
61
59
|
{
|
|
62
|
-
entry: [...ENTRIES, ...publicFiles, ...migrations, ...bins, ...binaries, ...scriptEntries, ...ui, ...styles],
|
|
60
|
+
entry: [...ENTRIES, ...publicFiles, ...migrations, ...bins, ...binaries, ...scriptEntries, ...bundled, ...ui, ...styles],
|
|
63
61
|
paths: importPaths(manifest.imports ?? {}),
|
|
64
62
|
project: [...sources, ...ui, ...styles],
|
|
65
63
|
vitest: { config: ["vitest*.config.{ts,mts,cts,js,mjs,cjs}", "vitest.{workspace,projects}.{ts,mts,cts,js,mjs,cjs,json}"] },
|
package/src/adapters/knip/run.ts
CHANGED
|
@@ -5,6 +5,7 @@ import { pathToFileURL } from "node:url";
|
|
|
5
5
|
import { Effect, FileSystem, Stream } from "effect";
|
|
6
6
|
import { ChildProcess, ChildProcessSpawner } from "effect/process";
|
|
7
7
|
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
8
|
+
import { programmaticEntries } from "#inventory/programmaticEntries.ts";
|
|
8
9
|
import { shadcnFolders } from "#inventory/shadcnFolders.ts";
|
|
9
10
|
import type { RuleInputs } from "#rule.ts";
|
|
10
11
|
import { knipConfiguration } from "./configuration.ts";
|
|
@@ -26,7 +27,8 @@ export const runKnip = Effect.fn("Knip.runKnip")(function* (inputs: RuleInputs)
|
|
|
26
27
|
return [];
|
|
27
28
|
}
|
|
28
29
|
const folders = yield* shadcnFolders(inputs.root);
|
|
29
|
-
const
|
|
30
|
+
const entries = yield* programmaticEntries(inputs);
|
|
31
|
+
const configuration = yield* Effect.promise(() => knipConfiguration(inputs, folders, entries));
|
|
30
32
|
const checked = new Set([...inputs.files, ...Object.keys(configuration.workspaces).map((directory) => posix.join(directory, "package.json"))]);
|
|
31
33
|
const findings = yield* Effect.scoped(
|
|
32
34
|
Effect.gen(function* () {
|
|
@@ -0,0 +1,22 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { frameworkCallback } from "#adapters/frameworkCallback.ts";
|
|
3
|
+
|
|
4
|
+
export function localFunctions(sources: readonly ts.SourceFile[], checker: ts.TypeChecker, parameters: (signature: ts.Signature) => void): void {
|
|
5
|
+
const local = new Set(sources);
|
|
6
|
+
function visit(node: ts.Node): void {
|
|
7
|
+
if (
|
|
8
|
+
(ts.isFunctionDeclaration(node) || ts.isFunctionExpression(node) || ts.isArrowFunction(node) || ts.isMethodDeclaration(node))
|
|
9
|
+
&& node.parameters.length > 0
|
|
10
|
+
&& !frameworkCallback(checker, node, local)
|
|
11
|
+
) {
|
|
12
|
+
const signature = checker.getSignatureFromDeclaration(node);
|
|
13
|
+
if (signature !== undefined) {
|
|
14
|
+
parameters(signature);
|
|
15
|
+
}
|
|
16
|
+
}
|
|
17
|
+
ts.forEachChild(node, visit);
|
|
18
|
+
}
|
|
19
|
+
for (const source of sources) {
|
|
20
|
+
visit(source);
|
|
21
|
+
}
|
|
22
|
+
}
|
|
@@ -0,0 +1,56 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { unwrapped } from "#rules/stories/syntax.ts";
|
|
3
|
+
|
|
4
|
+
function functionOf(name: ts.Node): ts.FunctionDeclaration | ts.ArrowFunction | ts.FunctionExpression | undefined {
|
|
5
|
+
const declaration = name.parent;
|
|
6
|
+
if (ts.isFunctionDeclaration(declaration)) {
|
|
7
|
+
return declaration;
|
|
8
|
+
}
|
|
9
|
+
const value = ts.isVariableDeclaration(declaration) ? declaration.initializer : undefined;
|
|
10
|
+
const node = value === undefined ? undefined : unwrapped(value);
|
|
11
|
+
return node !== undefined && (ts.isArrowFunction(node) || ts.isFunctionExpression(node)) ? node : undefined;
|
|
12
|
+
}
|
|
13
|
+
|
|
14
|
+
function action(node: ts.Node, readCall: (call: ts.CallExpression) => boolean): boolean {
|
|
15
|
+
if (
|
|
16
|
+
((ts.isArrowFunction(node) || ts.isFunctionExpression(node) || ts.isFunctionDeclaration(node))
|
|
17
|
+
&& (node.asteriskToken !== undefined || node.modifiers?.some((modifier) => modifier.kind === ts.SyntaxKind.AsyncKeyword)))
|
|
18
|
+
|| ts.isJsxElement(node)
|
|
19
|
+
|| ts.isJsxSelfClosingElement(node)
|
|
20
|
+
|| ts.isJsxFragment(node)
|
|
21
|
+
|| ts.isAwaitExpression(node)
|
|
22
|
+
|| ts.isYieldExpression(node)
|
|
23
|
+
|| ts.isNewExpression(node)
|
|
24
|
+
|| ts.isThrowStatement(node)
|
|
25
|
+
|| ts.isDeleteExpression(node)
|
|
26
|
+
|| ts.isPostfixUnaryExpression(node)
|
|
27
|
+
|| (ts.isPrefixUnaryExpression(node) && [ts.SyntaxKind.PlusPlusToken, ts.SyntaxKind.MinusMinusToken].includes(node.operator))
|
|
28
|
+
|| (ts.isBinaryExpression(node)
|
|
29
|
+
&& node.operatorToken.kind >= ts.SyntaxKind.FirstAssignment
|
|
30
|
+
&& node.operatorToken.kind <= ts.SyntaxKind.LastAssignment)
|
|
31
|
+
) {
|
|
32
|
+
return true;
|
|
33
|
+
}
|
|
34
|
+
return ts.isCallExpression(node) && !readCall(node);
|
|
35
|
+
}
|
|
36
|
+
|
|
37
|
+
export function pureReader(name: ts.Node, readCall: (call: ts.CallExpression) => boolean): boolean {
|
|
38
|
+
const fn = functionOf(name);
|
|
39
|
+
if (fn?.body === undefined || fn.asteriskToken !== undefined || fn.modifiers?.some((modifier) => modifier.kind === ts.SyntaxKind.AsyncKeyword)) {
|
|
40
|
+
return false;
|
|
41
|
+
}
|
|
42
|
+
let returns = !ts.isBlock(fn.body);
|
|
43
|
+
let acts = false;
|
|
44
|
+
let reads = false;
|
|
45
|
+
function visit(node: ts.Node): void {
|
|
46
|
+
returns ||= ts.isReturnStatement(node) && node.expression !== undefined;
|
|
47
|
+
acts ||= action(node, readCall);
|
|
48
|
+
reads ||= ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node) || ts.isBinaryExpression(node);
|
|
49
|
+
ts.forEachChild(node, visit);
|
|
50
|
+
}
|
|
51
|
+
for (const parameter of fn.parameters) {
|
|
52
|
+
visit(parameter);
|
|
53
|
+
}
|
|
54
|
+
visit(fn.body);
|
|
55
|
+
return returns && reads && !acts;
|
|
56
|
+
}
|
|
@@ -0,0 +1,58 @@
|
|
|
1
|
+
import type { ImportGraph } from "#imports/graph.ts";
|
|
2
|
+
import type { PackageLayout } from "#naming/packageLayout.ts";
|
|
3
|
+
import type { RuleInputs } from "#rule.ts";
|
|
4
|
+
import { bundlerEntries } from "./bundlerEntries.ts";
|
|
5
|
+
|
|
6
|
+
function scriptsByPackage(layout: PackageLayout): ReadonlyMap<string, readonly string[]> {
|
|
7
|
+
const scripts = new Map<string, string[]>();
|
|
8
|
+
for (const script of layout.scripts) {
|
|
9
|
+
const roots = [...layout.names.keys()].filter((folder) => folder === "" || script.startsWith(`${folder}/`));
|
|
10
|
+
const directory = roots.toSorted((left, right) => right.length - left.length)[0] ?? "";
|
|
11
|
+
scripts.set(directory, [...(scripts.get(directory) ?? []), script]);
|
|
12
|
+
}
|
|
13
|
+
return scripts;
|
|
14
|
+
}
|
|
15
|
+
|
|
16
|
+
function reachable(roots: readonly string[], imports: ReadonlyMap<string, readonly string[]>): ReadonlySet<string> {
|
|
17
|
+
const visited = new Set<string>();
|
|
18
|
+
const pending = [...roots];
|
|
19
|
+
while (pending.length > 0) {
|
|
20
|
+
const path = pending.pop();
|
|
21
|
+
if (path === undefined || visited.has(path)) {
|
|
22
|
+
continue;
|
|
23
|
+
}
|
|
24
|
+
visited.add(path);
|
|
25
|
+
pending.push(...(imports.get(path) ?? []));
|
|
26
|
+
}
|
|
27
|
+
return visited;
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
function importsOf(graph: ImportGraph): ReadonlyMap<string, readonly string[]> {
|
|
31
|
+
const imports = new Map<string, string[]>();
|
|
32
|
+
for (const edge of graph.edges) {
|
|
33
|
+
if (!edge.type && edge.to.kind === "file") {
|
|
34
|
+
imports.set(edge.from, [...(imports.get(edge.from) ?? []), edge.to.path]);
|
|
35
|
+
}
|
|
36
|
+
}
|
|
37
|
+
return imports;
|
|
38
|
+
}
|
|
39
|
+
|
|
40
|
+
export function reachableBuildEntries(inputs: RuleInputs, graph: ImportGraph, layout: PackageLayout): ReadonlySet<string> {
|
|
41
|
+
const imports = importsOf(graph);
|
|
42
|
+
const sources = new Map(inputs.sources.map((source) => [source.path, source]));
|
|
43
|
+
const entries = new Set<string>();
|
|
44
|
+
for (const [directory, scripts] of scriptsByPackage(layout)) {
|
|
45
|
+
for (const path of reachable(scripts, imports)) {
|
|
46
|
+
const source = sources.get(path);
|
|
47
|
+
if (source === undefined) {
|
|
48
|
+
continue;
|
|
49
|
+
}
|
|
50
|
+
for (const entry of bundlerEntries(source, inputs.root, directory)) {
|
|
51
|
+
if (sources.has(entry)) {
|
|
52
|
+
entries.add(entry);
|
|
53
|
+
}
|
|
54
|
+
}
|
|
55
|
+
}
|
|
56
|
+
}
|
|
57
|
+
return entries;
|
|
58
|
+
}
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
import { basename, dirname, resolve } from "node:path";
|
|
2
2
|
import { pathToFileURL } from "node:url";
|
|
3
3
|
import { Effect, FileSystem } from "effect";
|
|
4
|
-
import { CONFIG_FILE } from "#config/
|
|
4
|
+
import { CONFIG_FILE } from "#config/file.ts";
|
|
5
5
|
import { SetupFailure } from "#failure.ts";
|
|
6
6
|
|
|
7
7
|
function messageOf(cause: unknown): string {
|
|
@@ -0,0 +1,5 @@
|
|
|
1
|
+
import { posix } from "node:path";
|
|
2
|
+
|
|
3
|
+
export function scriptPaths(directory: string, scripts: Readonly<Record<string, string>>): readonly string[] {
|
|
4
|
+
return Object.values(scripts).flatMap((script) => script.split(/[\s'"`;|&()]+/u).map((word) => posix.join(directory, word)));
|
|
5
|
+
}
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
import ts from "typescript";
|
|
2
|
-
import {
|
|
2
|
+
import { containerDependency } from "#adapters/containerDependency.ts";
|
|
3
3
|
import { serviceProperty } from "#adapters/serviceAssemblySyntax.ts";
|
|
4
|
-
import { effectSuccess, resolvedValue } from "#adapters/serviceModelSyntax.ts";
|
|
4
|
+
import { effectApi, effectSuccess, resolvedValue } from "#adapters/serviceModelSyntax.ts";
|
|
5
5
|
import type { serviceTypes } from "#rules/effect/serviceTypes.ts";
|
|
6
6
|
import { returnValues } from "#rules/stories/returnValues.ts";
|
|
7
7
|
|
|
@@ -12,7 +12,7 @@ function capturesDependency(
|
|
|
12
12
|
seen = new Set<ts.Node>(),
|
|
13
13
|
closing = false,
|
|
14
14
|
): boolean {
|
|
15
|
-
if (seen.has(value)) {
|
|
15
|
+
if (seen.has(value) || ts.isTypeNode(value)) {
|
|
16
16
|
return false;
|
|
17
17
|
}
|
|
18
18
|
seen.add(value);
|
|
@@ -27,24 +27,46 @@ function capturesDependency(
|
|
|
27
27
|
return false;
|
|
28
28
|
}
|
|
29
29
|
if (ts.isCallExpression(value)) {
|
|
30
|
-
|
|
31
|
-
return (
|
|
32
|
-
(owner !== undefined && services.implementation(checker.getTypeAtLocation(owner)))
|
|
33
|
-
|| value.arguments.some((argument) => capturesDependency(checker, argument, services, seen, closing))
|
|
34
|
-
);
|
|
30
|
+
return callDependency(checker, value, services, seen, closing);
|
|
35
31
|
}
|
|
36
32
|
if (ts.isIdentifier(value)) {
|
|
37
|
-
|
|
38
|
-
return true;
|
|
39
|
-
}
|
|
40
|
-
const resolved = resolvedValue(checker, value);
|
|
41
|
-
return resolved !== value && capturesDependency(checker, resolved, services, seen, closing);
|
|
33
|
+
return identifierDependency(checker, value, services, seen, closing);
|
|
42
34
|
}
|
|
43
35
|
return (
|
|
44
36
|
ts.forEachChild(value, (child) => capturesDependency(checker, child, services, seen, closing || ts.isFunctionLike(value)) || undefined) ?? false
|
|
45
37
|
);
|
|
46
38
|
}
|
|
47
39
|
|
|
40
|
+
function identifierDependency(
|
|
41
|
+
checker: ts.TypeChecker,
|
|
42
|
+
value: ts.Identifier,
|
|
43
|
+
services: ReturnType<typeof serviceTypes>,
|
|
44
|
+
seen: Set<ts.Node>,
|
|
45
|
+
closing: boolean,
|
|
46
|
+
): boolean {
|
|
47
|
+
const symbol = checker.getSymbolAtLocation(value);
|
|
48
|
+
const target = symbol !== undefined && symbol.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(symbol) : symbol;
|
|
49
|
+
if (target !== undefined && target.flags & ts.SymbolFlags.ValueModule) {
|
|
50
|
+
return false;
|
|
51
|
+
}
|
|
52
|
+
const resolved = resolvedValue(checker, value);
|
|
53
|
+
return resolved === value ? services.carries(checker.getTypeAtLocation(value)) : capturesDependency(checker, resolved, services, seen, closing);
|
|
54
|
+
}
|
|
55
|
+
|
|
56
|
+
function callDependency(
|
|
57
|
+
checker: ts.TypeChecker,
|
|
58
|
+
value: ts.CallExpression,
|
|
59
|
+
services: ReturnType<typeof serviceTypes>,
|
|
60
|
+
seen: Set<ts.Node>,
|
|
61
|
+
closing: boolean,
|
|
62
|
+
): boolean {
|
|
63
|
+
const owner = ts.isPropertyAccessExpression(value.expression) ? value.expression.expression : undefined;
|
|
64
|
+
return (
|
|
65
|
+
(owner !== undefined && services.implementation(checker.getTypeAtLocation(owner)) && capturesDependency(checker, owner, services, seen, closing))
|
|
66
|
+
|| value.arguments.some((argument) => capturesDependency(checker, argument, services, seen, closing))
|
|
67
|
+
);
|
|
68
|
+
}
|
|
69
|
+
|
|
48
70
|
export function serviceStateProblems(
|
|
49
71
|
checker: ts.TypeChecker,
|
|
50
72
|
config: ts.ObjectLiteralExpression,
|
|
@@ -54,13 +76,16 @@ export function serviceStateProblems(
|
|
|
54
76
|
if (initialize === undefined) {
|
|
55
77
|
return [];
|
|
56
78
|
}
|
|
57
|
-
const
|
|
58
|
-
|
|
59
|
-
|
|
60
|
-
|| (state !== undefined && (services.carries(state) || initializerDependency(checker, state)));
|
|
79
|
+
const type = checker.getTypeAtLocation(initialize);
|
|
80
|
+
const state = effectSuccess(checker, type);
|
|
81
|
+
let dependency = services.carries(type) || (state !== undefined && (services.carries(state) || containerDependency(checker, state, services)));
|
|
61
82
|
const initializer = resolvedValue(checker, initialize);
|
|
62
83
|
// A function in state can hide a service even when its public type does not carry it.
|
|
63
84
|
function inspect(node: ts.Node): void {
|
|
85
|
+
if (ts.isCallExpression(node) && ["succeed", "as"].some((name) => effectApi(checker, node.expression, name))) {
|
|
86
|
+
const retained = node.arguments.at(-1);
|
|
87
|
+
dependency ||= retained !== undefined && capturesDependency(checker, retained, services);
|
|
88
|
+
}
|
|
64
89
|
if (ts.isFunctionLike(node)) {
|
|
65
90
|
for (const value of returnValues(node)) {
|
|
66
91
|
if (value !== undefined && capturesDependency(checker, value, services)) {
|
|
@@ -0,0 +1,77 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import type { SourceFile } from "#rule.ts";
|
|
3
|
+
import { parse } from "#rules/parse.ts";
|
|
4
|
+
import { topLevelHelpers, unwrapped } from "#rules/stories/syntax.ts";
|
|
5
|
+
import { asymmetricMatcher } from "./asymmetricMatcher.ts";
|
|
6
|
+
|
|
7
|
+
const READ_METHODS = new Set([
|
|
8
|
+
"at",
|
|
9
|
+
"concat",
|
|
10
|
+
"endsWith",
|
|
11
|
+
"entries",
|
|
12
|
+
"every",
|
|
13
|
+
"filter",
|
|
14
|
+
"find",
|
|
15
|
+
"findIndex",
|
|
16
|
+
"flat",
|
|
17
|
+
"flatMap",
|
|
18
|
+
"get",
|
|
19
|
+
"has",
|
|
20
|
+
"includes",
|
|
21
|
+
"indexOf",
|
|
22
|
+
"join",
|
|
23
|
+
"keys",
|
|
24
|
+
"lastIndexOf",
|
|
25
|
+
"map",
|
|
26
|
+
"match",
|
|
27
|
+
"reduce",
|
|
28
|
+
"replace",
|
|
29
|
+
"slice",
|
|
30
|
+
"some",
|
|
31
|
+
"split",
|
|
32
|
+
"startsWith",
|
|
33
|
+
"substring",
|
|
34
|
+
"toLowerCase",
|
|
35
|
+
"toUpperCase",
|
|
36
|
+
"trim",
|
|
37
|
+
"values",
|
|
38
|
+
]);
|
|
39
|
+
|
|
40
|
+
export function specReaderSources(files: readonly SourceFile[]) {
|
|
41
|
+
const sources = files.flatMap((file) => {
|
|
42
|
+
const source = parse(file);
|
|
43
|
+
return source === undefined || topLevelHelpers(source).length === 0 ? [] : [source];
|
|
44
|
+
});
|
|
45
|
+
if (sources.length === 0) {
|
|
46
|
+
return [];
|
|
47
|
+
}
|
|
48
|
+
const options: ts.CompilerOptions = { allowJs: true, noResolve: true, target: ts.ScriptTarget.ESNext, types: [] };
|
|
49
|
+
const host = ts.createCompilerHost(options);
|
|
50
|
+
const getSourceFile = host.getSourceFile;
|
|
51
|
+
const parsed = new Map(sources.map((source) => [source.fileName, source]));
|
|
52
|
+
host.getSourceFile = (path, ...args) => parsed.get(path) ?? getSourceFile(path, ...args);
|
|
53
|
+
const program = ts.createProgram([...parsed.keys()], options, host);
|
|
54
|
+
const checker = program.getTypeChecker();
|
|
55
|
+
function readCall(call: ts.CallExpression): boolean {
|
|
56
|
+
if (asymmetricMatcher(call, checker)) {
|
|
57
|
+
return true;
|
|
58
|
+
}
|
|
59
|
+
const target = unwrapped(call.expression);
|
|
60
|
+
if (!(ts.isPropertyAccessExpression(target) && READ_METHODS.has(target.name.text))) {
|
|
61
|
+
return false;
|
|
62
|
+
}
|
|
63
|
+
const declaration = checker.getResolvedSignature(call)?.declaration;
|
|
64
|
+
return (
|
|
65
|
+
declaration !== undefined
|
|
66
|
+
&& program.isSourceFileDefaultLibrary(declaration.getSourceFile())
|
|
67
|
+
&& call.arguments.every((argument) => {
|
|
68
|
+
if (ts.isArrowFunction(argument) || ts.isFunctionExpression(argument)) {
|
|
69
|
+
return true;
|
|
70
|
+
}
|
|
71
|
+
const type = checker.getTypeAtLocation(argument);
|
|
72
|
+
return (type.flags & (ts.TypeFlags.Any | ts.TypeFlags.Unknown)) === 0 && type.getCallSignatures().length === 0;
|
|
73
|
+
})
|
|
74
|
+
);
|
|
75
|
+
}
|
|
76
|
+
return sources.map((source) => ({ readCall, source }));
|
|
77
|
+
}
|