@shivaedev/quality 0.66.0 → 0.67.1
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +19 -0
- package/README.md +10 -8
- package/biome/declarations.json +7 -1
- package/biome/preset.json +7 -1
- package/dist/adapters/asymmetricMatcher.d.ts +3 -0
- package/dist/adapters/asymmetricMatcher.d.ts.map +1 -0
- package/dist/adapters/asymmetricMatcher.js +27 -0
- package/dist/adapters/asymmetricMatcher.js.map +1 -0
- package/dist/adapters/buildEntryPaths.d.ts +3 -0
- package/dist/adapters/buildEntryPaths.d.ts.map +1 -0
- package/dist/adapters/buildEntryPaths.js +48 -0
- package/dist/adapters/buildEntryPaths.js.map +1 -0
- package/dist/adapters/buildEntryValue.d.ts +4 -0
- package/dist/adapters/buildEntryValue.d.ts.map +1 -0
- package/dist/adapters/buildEntryValue.js +47 -0
- package/dist/adapters/buildEntryValue.js.map +1 -0
- package/dist/adapters/bundlerEntries.d.ts +3 -0
- package/dist/adapters/bundlerEntries.d.ts.map +1 -0
- package/dist/adapters/bundlerEntries.js +49 -0
- package/dist/adapters/bundlerEntries.js.map +1 -0
- package/dist/adapters/callbackEscapes.d.ts +3 -0
- package/dist/adapters/callbackEscapes.d.ts.map +1 -0
- package/dist/adapters/callbackEscapes.js +24 -0
- package/dist/adapters/callbackEscapes.js.map +1 -0
- package/dist/adapters/composedContext.d.ts +3 -0
- package/dist/adapters/composedContext.d.ts.map +1 -0
- package/dist/adapters/composedContext.js +42 -0
- package/dist/adapters/composedContext.js.map +1 -0
- package/dist/adapters/containerDependency.d.ts +4 -0
- package/dist/adapters/containerDependency.d.ts.map +1 -0
- package/dist/adapters/containerDependency.js +28 -0
- package/dist/adapters/containerDependency.js.map +1 -0
- package/dist/adapters/contextCaptureFindings.d.ts.map +1 -1
- package/dist/adapters/contextCaptureFindings.js +3 -1
- package/dist/adapters/contextCaptureFindings.js.map +1 -1
- package/dist/adapters/foreignResources.d.ts +3 -0
- package/dist/adapters/foreignResources.d.ts.map +1 -0
- package/dist/adapters/foreignResources.js +80 -0
- package/dist/adapters/foreignResources.js.map +1 -0
- package/dist/adapters/frameworkCallback.d.ts +4 -0
- package/dist/adapters/frameworkCallback.d.ts.map +1 -0
- package/dist/adapters/frameworkCallback.js +92 -0
- package/dist/adapters/frameworkCallback.js.map +1 -0
- package/dist/adapters/frameworkOwner.d.ts +3 -0
- package/dist/adapters/frameworkOwner.d.ts.map +1 -0
- package/dist/adapters/frameworkOwner.js +35 -0
- package/dist/adapters/frameworkOwner.js.map +1 -0
- package/dist/adapters/importedCall.d.ts +6 -0
- package/dist/adapters/importedCall.d.ts.map +1 -0
- package/dist/adapters/importedCall.js +26 -0
- package/dist/adapters/importedCall.js.map +1 -0
- package/dist/adapters/isToolConfig.d.ts +2 -0
- package/dist/adapters/isToolConfig.d.ts.map +1 -0
- package/dist/adapters/isToolConfig.js +7 -0
- package/dist/adapters/isToolConfig.js.map +1 -0
- package/dist/adapters/knip/configuration.d.ts +1 -1
- package/dist/adapters/knip/configuration.d.ts.map +1 -1
- package/dist/adapters/knip/configuration.js +5 -3
- package/dist/adapters/knip/configuration.js.map +1 -1
- package/dist/adapters/knip/run.d.ts.map +1 -1
- package/dist/adapters/knip/run.js +3 -1
- package/dist/adapters/knip/run.js.map +1 -1
- package/dist/adapters/localFunctions.d.ts +3 -0
- package/dist/adapters/localFunctions.d.ts.map +1 -0
- package/dist/adapters/localFunctions.js +20 -0
- package/dist/adapters/localFunctions.js.map +1 -0
- package/dist/adapters/pureReader.d.ts +3 -0
- package/dist/adapters/pureReader.d.ts.map +1 -0
- package/dist/adapters/pureReader.js +52 -0
- package/dist/adapters/pureReader.js.map +1 -0
- package/dist/adapters/reachableBuildEntries.d.ts +5 -0
- package/dist/adapters/reachableBuildEntries.d.ts.map +1 -0
- package/dist/adapters/reachableBuildEntries.js +52 -0
- package/dist/adapters/reachableBuildEntries.js.map +1 -0
- package/dist/adapters/readConfig.js +1 -1
- package/dist/adapters/readConfig.js.map +1 -1
- package/dist/adapters/scriptPaths.d.ts +2 -0
- package/dist/adapters/scriptPaths.d.ts.map +1 -0
- package/dist/adapters/scriptPaths.js +5 -0
- package/dist/adapters/scriptPaths.js.map +1 -0
- package/dist/adapters/serviceStateProblems.d.ts.map +1 -1
- package/dist/adapters/serviceStateProblems.js +26 -14
- package/dist/adapters/serviceStateProblems.js.map +1 -1
- package/dist/adapters/specReaderSources.d.ts +7 -0
- package/dist/adapters/specReaderSources.d.ts.map +1 -0
- package/dist/adapters/specReaderSources.js +73 -0
- package/dist/adapters/specReaderSources.js.map +1 -0
- package/dist/cli/args.js +2 -2
- package/dist/cli/args.js.map +1 -1
- package/dist/cli/fix.d.ts +0 -1
- package/dist/cli/fix.d.ts.map +1 -1
- package/dist/cli/fix.js +1 -1
- package/dist/cli/fix.js.map +1 -1
- package/dist/cli/limits.d.ts +2 -0
- package/dist/cli/limits.d.ts.map +1 -0
- package/dist/cli/limits.js +2 -0
- package/dist/cli/limits.js.map +1 -0
- package/dist/cli/{options.d.ts → misplaced.d.ts} +1 -1
- package/dist/cli/misplaced.d.ts.map +1 -0
- package/dist/cli/{options.js → misplaced.js} +1 -1
- package/dist/cli/misplaced.js.map +1 -0
- package/dist/cli/program.js +1 -1
- package/dist/cli/program.js.map +1 -1
- package/dist/cli/subcommands.d.ts +2 -0
- package/dist/cli/subcommands.d.ts.map +1 -0
- package/dist/cli/subcommands.js +6 -0
- package/dist/cli/subcommands.js.map +1 -0
- package/dist/cli/{messages.d.ts → usage.d.ts} +1 -2
- package/dist/cli/usage.d.ts.map +1 -0
- package/{src/cli/messages.ts → dist/cli/usage.js} +1 -6
- package/dist/cli/usage.js.map +1 -0
- package/dist/config/defaultExtensions.d.ts +2 -0
- package/dist/config/defaultExtensions.d.ts.map +1 -0
- package/{src/config/constants.ts → dist/config/defaultExtensions.js} +1 -2
- package/dist/config/defaultExtensions.js.map +1 -0
- package/dist/config/file.d.ts +2 -0
- package/dist/config/file.d.ts.map +1 -0
- package/dist/config/file.js +2 -0
- package/dist/config/file.js.map +1 -0
- package/dist/config/load.js +1 -1
- package/dist/config/load.js.map +1 -1
- package/dist/hooks/install.js +1 -1
- package/dist/hooks/install.js.map +1 -1
- package/dist/imports/testComposition.d.ts +4 -0
- package/dist/imports/testComposition.d.ts.map +1 -0
- package/dist/imports/testComposition.js +38 -0
- package/dist/imports/testComposition.js.map +1 -0
- package/dist/inventory/programmaticEntries.d.ts +4 -0
- package/dist/inventory/programmaticEntries.d.ts.map +1 -0
- package/dist/inventory/programmaticEntries.js +9 -0
- package/dist/inventory/programmaticEntries.js.map +1 -0
- package/dist/naming/adapters/plainData.d.ts +5 -0
- package/dist/naming/adapters/plainData.d.ts.map +1 -0
- package/dist/naming/adapters/plainData.js +77 -0
- package/dist/naming/adapters/plainData.js.map +1 -0
- package/dist/naming/constantModule.d.ts +3 -0
- package/dist/naming/constantModule.d.ts.map +1 -0
- package/dist/naming/constantModule.js +25 -0
- package/dist/naming/constantModule.js.map +1 -0
- package/dist/naming/{migrationFile.d.ts → isMigrationFile.d.ts} +1 -1
- package/dist/naming/isMigrationFile.d.ts.map +1 -0
- package/dist/naming/{migrationFile.js → isMigrationFile.js} +1 -1
- package/dist/naming/isMigrationFile.js.map +1 -0
- package/dist/naming/ownExports.d.ts +0 -1
- package/dist/naming/ownExports.d.ts.map +1 -1
- package/dist/naming/ownExports.js +11 -25
- package/dist/naming/ownExports.js.map +1 -1
- package/dist/naming/packageTests.d.ts +7 -0
- package/dist/naming/packageTests.d.ts.map +1 -0
- package/dist/naming/packageTests.js +21 -0
- package/dist/naming/packageTests.js.map +1 -0
- package/dist/naming/testCode.d.ts +4 -0
- package/dist/naming/testCode.d.ts.map +1 -0
- package/dist/naming/testCode.js +46 -0
- package/dist/naming/testCode.js.map +1 -0
- package/dist/rules/comments/kinds.js +1 -1
- package/dist/rules/comments/kinds.js.map +1 -1
- package/dist/rules/effect/contextCapture.js +1 -1
- package/dist/rules/effect/contextCapture.js.map +1 -1
- package/dist/rules/effect/program.d.ts +1 -0
- package/dist/rules/effect/program.d.ts.map +1 -1
- package/dist/rules/effect/program.js +17 -1
- package/dist/rules/effect/program.js.map +1 -1
- package/dist/rules/effect/serviceCatalog.d.ts.map +1 -1
- package/dist/rules/effect/serviceCatalog.js +10 -2
- package/dist/rules/effect/serviceCatalog.js.map +1 -1
- package/dist/rules/effect/serviceFindings.d.ts.map +1 -1
- package/dist/rules/effect/serviceFindings.js +33 -7
- package/dist/rules/effect/serviceFindings.js.map +1 -1
- package/dist/rules/effect/serviceOrigin.d.ts.map +1 -1
- package/dist/rules/effect/serviceOrigin.js +13 -1
- package/dist/rules/effect/serviceOrigin.js.map +1 -1
- package/dist/rules/effect/serviceParameters.d.ts.map +1 -1
- package/dist/rules/effect/serviceParameters.js +12 -12
- package/dist/rules/effect/serviceParameters.js.map +1 -1
- package/dist/rules/effect/serviceTypes.d.ts.map +1 -1
- package/dist/rules/effect/serviceTypes.js +5 -1
- package/dist/rules/effect/serviceTypes.js.map +1 -1
- package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
- package/dist/rules/files/namedAfterExport.js +36 -23
- package/dist/rules/files/namedAfterExport.js.map +1 -1
- package/dist/rules/imports/manifest.d.ts.map +1 -1
- package/dist/rules/imports/manifest.js +9 -11
- package/dist/rules/imports/manifest.js.map +1 -1
- package/dist/rules/imports/noTestCode.d.ts.map +1 -1
- package/dist/rules/imports/noTestCode.js +13 -9
- package/dist/rules/imports/noTestCode.js.map +1 -1
- package/dist/rules/maxLines.d.ts.map +1 -1
- package/dist/rules/maxLines.js +7 -2
- package/dist/rules/maxLines.js.map +1 -1
- package/dist/rules/stories/specHelpers.d.ts.map +1 -1
- package/dist/rules/stories/specHelpers.js +8 -4
- package/dist/rules/stories/specHelpers.js.map +1 -1
- package/dist/rules/suppressions/{directives.d.ts → in.d.ts} +1 -1
- package/dist/rules/suppressions/in.d.ts.map +1 -0
- package/dist/rules/suppressions/{directives.js → in.js} +1 -1
- package/dist/rules/suppressions/in.js.map +1 -0
- package/dist/rules/suppressions/noInline.js +1 -1
- package/dist/rules/suppressions/noInline.js.map +1 -1
- package/dist/rules/test-names/colocated.d.ts.map +1 -1
- package/dist/rules/test-names/colocated.js +7 -4
- package/dist/rules/test-names/colocated.js.map +1 -1
- package/dist/rules/test-names/follow.d.ts.map +1 -1
- package/dist/rules/test-names/follow.js +13 -6
- package/dist/rules/test-names/follow.js.map +1 -1
- package/package.json +4 -3
- package/src/adapters/asymmetricMatcher.ts +33 -0
- package/src/adapters/buildEntryPaths.ts +52 -0
- package/src/adapters/buildEntryValue.ts +52 -0
- package/src/adapters/bundlerEntries.ts +53 -0
- package/src/adapters/callbackEscapes.ts +32 -0
- package/src/adapters/composedContext.ts +48 -0
- package/src/adapters/containerDependency.ts +40 -0
- package/src/adapters/contextCaptureFindings.ts +3 -1
- package/src/adapters/foreignResources.ts +83 -0
- package/src/adapters/frameworkCallback.ts +106 -0
- package/src/adapters/frameworkOwner.ts +41 -0
- package/src/adapters/importedCall.ts +27 -0
- package/src/adapters/isToolConfig.ts +10 -0
- package/src/adapters/knip/configuration.ts +5 -7
- package/src/adapters/knip/run.ts +3 -1
- package/src/adapters/localFunctions.ts +22 -0
- package/src/adapters/pureReader.ts +56 -0
- package/src/adapters/reachableBuildEntries.ts +58 -0
- package/src/adapters/readConfig.ts +1 -1
- package/src/adapters/scriptPaths.ts +5 -0
- package/src/adapters/serviceStateProblems.ts +42 -17
- package/src/adapters/specReaderSources.ts +77 -0
- package/src/cli/args.ts +2 -2
- package/src/cli/fix.ts +1 -2
- package/src/cli/limits.ts +1 -0
- package/src/cli/program.ts +1 -1
- package/src/cli/subcommands.ts +5 -0
- package/{dist/cli/messages.js → src/cli/usage.ts} +0 -6
- package/{dist/config/constants.js → src/config/defaultExtensions.ts} +0 -2
- package/src/config/file.ts +1 -0
- package/src/config/load.ts +1 -1
- package/src/hooks/install.ts +1 -1
- package/src/imports/testComposition.ts +47 -0
- package/src/inventory/programmaticEntries.ts +10 -0
- package/src/naming/adapters/plainData.ts +88 -0
- package/src/naming/constantModule.ts +28 -0
- package/src/naming/ownExports.ts +11 -28
- package/src/naming/packageTests.ts +24 -0
- package/src/naming/testCode.ts +62 -0
- package/src/rules/comments/kinds.ts +1 -1
- package/src/rules/effect/contextCapture.ts +1 -1
- package/src/rules/effect/program.ts +19 -1
- package/src/rules/effect/serviceCatalog.ts +12 -2
- package/src/rules/effect/serviceFindings.ts +38 -7
- package/src/rules/effect/serviceOrigin.ts +14 -1
- package/src/rules/effect/serviceParameters.ts +13 -14
- package/src/rules/effect/serviceTypes.ts +11 -1
- package/src/rules/files/namedAfterExport.ts +46 -23
- package/src/rules/imports/manifest.ts +18 -10
- package/src/rules/imports/noTestCode.ts +13 -12
- package/src/rules/maxLines.ts +7 -3
- package/src/rules/stories/specHelpers.ts +14 -4
- package/src/rules/suppressions/noInline.ts +1 -1
- package/src/rules/test-names/colocated.ts +7 -4
- package/src/rules/test-names/follow.ts +13 -6
- package/dist/adapters/initializerDependency.d.ts +0 -3
- package/dist/adapters/initializerDependency.d.ts.map +0 -1
- package/dist/adapters/initializerDependency.js +0 -53
- package/dist/adapters/initializerDependency.js.map +0 -1
- package/dist/cli/messages.d.ts.map +0 -1
- package/dist/cli/messages.js.map +0 -1
- package/dist/cli/options.d.ts.map +0 -1
- package/dist/cli/options.js.map +0 -1
- package/dist/config/constants.d.ts +0 -3
- package/dist/config/constants.d.ts.map +0 -1
- package/dist/config/constants.js.map +0 -1
- package/dist/naming/migrationFile.d.ts.map +0 -1
- package/dist/naming/migrationFile.js.map +0 -1
- package/dist/rules/suppressions/directives.d.ts.map +0 -1
- package/dist/rules/suppressions/directives.js.map +0 -1
- package/src/adapters/initializerDependency.ts +0 -57
- /package/src/cli/{options.ts → misplaced.ts} +0 -0
- /package/src/naming/{migrationFile.ts → isMigrationFile.ts} +0 -0
- /package/src/rules/suppressions/{directives.ts → in.ts} +0 -0
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"maxLines.d.ts","sourceRoot":"","sources":["../../src/rules/maxLines.ts"],"names":[],"mappings":"AA0BA,eAAO,MAAM,QAAQ;;;
|
|
1
|
+
{"version":3,"file":"maxLines.d.ts","sourceRoot":"","sources":["../../src/rules/maxLines.ts"],"names":[],"mappings":"AA0BA,eAAO,MAAM,QAAQ;;;SAUnB,CAAC"}
|
package/dist/rules/maxLines.js
CHANGED
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
import { Effect, Schema } from "effect";
|
|
2
|
-
import {
|
|
2
|
+
import { testCode } from "#naming/testCode.ts";
|
|
3
3
|
import { defineRule } from "#rule.ts";
|
|
4
4
|
const DECLARATION = /\.d\.[cm]?ts$/u;
|
|
5
5
|
const Limit = Schema.Int.check(Schema.isGreaterThan(0));
|
|
@@ -20,7 +20,12 @@ function oversized(file, limit) {
|
|
|
20
20
|
];
|
|
21
21
|
}
|
|
22
22
|
export const maxLines = defineRule({
|
|
23
|
-
check:
|
|
23
|
+
check: Effect.fn("Structure.check")(function* (inputs) {
|
|
24
|
+
const isTestCode = yield* testCode(inputs);
|
|
25
|
+
return inputs.sources
|
|
26
|
+
.filter((file) => !DECLARATION.test(file.path))
|
|
27
|
+
.flatMap((file) => oversized(file, isTestCode(file.path) ? inputs.options.test : inputs.options.source));
|
|
28
|
+
}),
|
|
24
29
|
description: "Keep each module to one job. Split a long file along its responsibilities; never golf it under the limit.",
|
|
25
30
|
id: "structure/max-lines",
|
|
26
31
|
options: Schema.toStandardSchemaV1(MaxLinesOptions, { parseOptions: { errors: "all", onExcessProperty: "error" } }),
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"maxLines.js","sourceRoot":"","sources":["../../src/rules/maxLines.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,
|
|
1
|
+
{"version":3,"file":"maxLines.js","sourceRoot":"","sources":["../../src/rules/maxLines.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AAC/C,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AAErE,MAAM,WAAW,GAAG,gBAAgB,CAAC;AAErC,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC,CAAC;AAExD,MAAM,eAAe,GAAG,MAAM,CAAC,MAAM,CAAC;IACrC,MAAM,EAAE,KAAK,CAAC,KAAK,CAAC,MAAM,CAAC,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,sBAAsB,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC;IAC7G,IAAI,EAAE,KAAK,CAAC,KAAK,CAAC,MAAM,CAAC,mBAAmB,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,sBAAsB,CAAC,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC;CAC3G,CAAC,CAAC;AAEH,SAAS,SAAS,CAAC,IAAgB,EAAE,KAAa;IACjD,OAAO,IAAI,CAAC,KAAK,CAAC,MAAM,IAAI,KAAK;QAChC,CAAC,CAAC,EAAE;QACJ,CAAC,CAAC;YACA;gBACC,KAAK,EAAE,IAAI,CAAC,KAAK,CAAC,MAAM,GAAG,KAAK;gBAChC,IAAI,EAAE,IAAI,CAAC,IAAI;gBACf,OAAO,EAAE,GAAG,IAAI,CAAC,KAAK,CAAC,MAAM,sBAAsB,KAAK,cAAc;gBACtE,SAAS,EAAE,KAAK;aAChB;SACD,CAAC;AACL,CAAC;AAED,MAAM,CAAC,MAAM,QAAQ,GAAG,UAAU,CAAC;IAClC,KAAK,EAAE,MAAM,CAAC,EAAE,CAAC,iBAAiB,CAAC,CAAC,QAAQ,CAAC,EAAE,MAAM;QACpD,MAAM,UAAU,GAAG,KAAK,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC;QAC3C,OAAO,MAAM,CAAC,OAAO;aACnB,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,WAAW,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;aAC9C,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,SAAS,CAAC,IAAI,EAAE,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC;IAC3G,CAAC,CAAC;IACF,WAAW,EAAE,2GAA2G;IACxH,EAAE,EAAE,qBAAqB;IACzB,OAAO,EAAE,MAAM,CAAC,kBAAkB,CAAC,eAAe,EAAE,EAAE,YAAY,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,gBAAgB,EAAE,OAAO,EAAE,EAAE,CAAC;CACnH,CAAC,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"specHelpers.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/specHelpers.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"specHelpers.d.ts","sourceRoot":"","sources":["../../../src/rules/stories/specHelpers.ts"],"names":[],"mappings":"AAUA,eAAO,MAAM,WAAW,iEAWtB,CAAC"}
|
|
@@ -1,11 +1,15 @@
|
|
|
1
1
|
import { Effect } from "effect";
|
|
2
|
+
import { pureReader } from "#adapters/pureReader.ts";
|
|
3
|
+
import { specReaderSources } from "#adapters/specReaderSources.ts";
|
|
2
4
|
import { defineRule } from "#rule.ts";
|
|
3
5
|
import { storySources } from "./sources.js";
|
|
4
|
-
import {
|
|
5
|
-
const MESSAGE = "Declares a
|
|
6
|
+
import { findingAt, topLevelHelpers } from "./syntax.js";
|
|
7
|
+
const MESSAGE = "Declares a setup or action helper in a spec. Move the action into the story kit's verbs or the setup into its traits in test-support/.";
|
|
6
8
|
export const specHelpers = defineRule({
|
|
7
|
-
check: (inputs) => Effect.map(storySources(inputs), (stories) => stories.flatMap((
|
|
8
|
-
|
|
9
|
+
check: (inputs) => Effect.map(storySources(inputs), (stories) => specReaderSources(stories).flatMap(({ source, readCall }) => topLevelHelpers(source)
|
|
10
|
+
.filter((node) => !pureReader(node, readCall))
|
|
11
|
+
.map((node) => findingAt(source, node, MESSAGE)))),
|
|
12
|
+
description: "Specs state expectations and may keep pure matchers and readers; story-kit traits and verbs in test-support own setup and actions.",
|
|
9
13
|
id: "tests/spec-helpers",
|
|
10
14
|
});
|
|
11
15
|
//# sourceMappingURL=specHelpers.js.map
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"specHelpers.js","sourceRoot":"","sources":["../../../src/rules/stories/specHelpers.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,
|
|
1
|
+
{"version":3,"file":"specHelpers.js","sourceRoot":"","sources":["../../../src/rules/stories/specHelpers.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AAChC,OAAO,EAAE,UAAU,EAAE,MAAM,yBAAyB,CAAC;AACrD,OAAO,EAAE,iBAAiB,EAAE,MAAM,gCAAgC,CAAC;AACnE,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAC;AACtC,OAAO,EAAE,YAAY,EAAE,MAAM,cAAc,CAAC;AAC5C,OAAO,EAAE,SAAS,EAAE,eAAe,EAAE,MAAM,aAAa,CAAC;AAEzD,MAAM,OAAO,GACZ,wIAAwI,CAAC;AAE1I,MAAM,CAAC,MAAM,WAAW,GAAG,UAAU,CAAC;IACrC,KAAK,EAAE,CAAC,MAAM,EAAE,EAAE,CACjB,MAAM,CAAC,GAAG,CAAC,YAAY,CAAC,MAAM,CAAC,EAAE,CAAC,OAAO,EAAE,EAAE,CAC5C,iBAAiB,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,EAAE,EAAE,CAC3D,eAAe,CAAC,MAAM,CAAC;SACrB,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,UAAU,CAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;SAC7C,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,SAAS,CAAC,MAAM,EAAE,IAAI,EAAE,OAAO,CAAC,CAAC,CACjD,CACD;IACF,WAAW,EAAE,oIAAoI;IACjJ,EAAE,EAAE,oBAAoB;CACxB,CAAC,CAAC"}
|
|
@@ -1,4 +1,4 @@
|
|
|
1
1
|
import type { SourceComment } from "#rules/comments/scan.ts";
|
|
2
2
|
export declare const SUPPRESSIONS: readonly RegExp[];
|
|
3
3
|
export declare function suppressionIn(comment: SourceComment): string | undefined;
|
|
4
|
-
//# sourceMappingURL=
|
|
4
|
+
//# sourceMappingURL=in.d.ts.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"in.d.ts","sourceRoot":"","sources":["../../../src/rules/suppressions/in.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,yBAAyB,CAAC;AAE7D,eAAO,MAAM,YAAY,EAAE,SAAS,MAAM,EASzC,CAAC;AAYF,wBAAgB,aAAa,CAAC,OAAO,EAAE,aAAa,GAAG,MAAM,GAAG,SAAS,CAExE"}
|
|
@@ -18,4 +18,4 @@ function directiveOn(comment, line) {
|
|
|
18
18
|
export function suppressionIn(comment) {
|
|
19
19
|
return comment.body.map((line) => directiveOn(comment, line)).find((directive) => directive !== undefined);
|
|
20
20
|
}
|
|
21
|
-
//# sourceMappingURL=
|
|
21
|
+
//# sourceMappingURL=in.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"in.js","sourceRoot":"","sources":["../../../src/rules/suppressions/in.ts"],"names":[],"mappings":"AAEA,MAAM,CAAC,MAAM,YAAY,GAAsB;IAC9C,yCAAyC;IACzC,gDAAgD;IAChD,qEAAqE;IACrE,uCAAuC;IACvC,kBAAkB;IAClB,4BAA4B;IAC5B,oDAAoD;IACpD,iBAAiB;CACjB,CAAC;AAEF,MAAM,oBAAoB,GAAG,mCAAmC,CAAC;AAEjE,MAAM,MAAM,GAAG,WAAW,CAAC;AAE3B,SAAS,WAAW,CAAC,OAAsB,EAAE,IAAY;IACxD,MAAM,OAAO,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC;IACzC,MAAM,QAAQ,GAAG,OAAO,CAAC,IAAI,KAAK,OAAO,CAAC,CAAC,CAAC,CAAC,GAAG,YAAY,EAAE,oBAAoB,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC;IACnG,OAAO,QAAQ,CAAC,GAAG,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,KAAK,SAAS,CAAC,CAAC;AACzH,CAAC;AAED,MAAM,UAAU,aAAa,CAAC,OAAsB;IACnD,OAAO,OAAO,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,WAAW,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,EAAE,CAAC,SAAS,KAAK,SAAS,CAAC,CAAC;AAC5G,CAAC"}
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
import { defineRule } from "#rule.ts";
|
|
2
2
|
import { scanComments } from "#rules/comments/scan.ts";
|
|
3
|
-
import { suppressionIn } from "./
|
|
3
|
+
import { suppressionIn } from "./in.js";
|
|
4
4
|
import { STYLESHEET, stylesheetComments } from "./stylesheetComments.js";
|
|
5
5
|
const TYPE_TEST = /(?:(?:^|\/)typecheck\.test|\.typecheck\.(?:test|spec))\.[cm]?[jt]sx?$/u;
|
|
6
6
|
const TYPE_TEST_DIRECTIVE = "@ts-expect-error";
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"noInline.js","sourceRoot":"","sources":["../../../src/rules/suppressions/noInline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAsB,YAAY,EAAE,MAAM,yBAAyB,CAAC;AAC3E,OAAO,EAAE,aAAa,EAAE,MAAM,
|
|
1
|
+
{"version":3,"file":"noInline.js","sourceRoot":"","sources":["../../../src/rules/suppressions/noInline.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAsB,YAAY,EAAE,MAAM,yBAAyB,CAAC;AAC3E,OAAO,EAAE,aAAa,EAAE,MAAM,SAAS,CAAC;AACxC,OAAO,EAAE,UAAU,EAAE,kBAAkB,EAAE,MAAM,yBAAyB,CAAC;AAEzE,MAAM,SAAS,GAAG,wEAAwE,CAAC;AAE3F,MAAM,mBAAmB,GAAG,kBAAkB,CAAC;AAM/C,SAAS,OAAO,CAAC,IAAY,EAAE,QAAkC;IAChE,OAAO,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE;QACnC,MAAM,SAAS,GAAG,aAAa,CAAC,OAAO,CAAC,CAAC;QACzC,OAAO,SAAS,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,OAAO,CAAC,IAAI,EAAE,OAAO,EAAE,wBAAwB,SAAS,IAAI,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,CAAC;IAC1I,CAAC,CAAC,CAAC;AACJ,CAAC;AAED,KAAK,UAAU,eAAe,CAAC,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAc;IACtE,MAAM,IAAI,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;IAC3D,MAAM,KAAK,GAAG,MAAM,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,EAAE,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI,CAAC,EAAE,IAAI,IAAI,CAAC,MAAM,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC;IAC1I,OAAO,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,KAAK,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,EAAE,kBAAkB,CAAC,IAAI,EAAE,KAAK,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;AACnG,CAAC;AAED,SAAS,OAAO,CAAC,IAAU;IAC1B,OAAO,IAAI,CAAC,OAAO,KAAK,mBAAmB,IAAI,SAAS,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1E,CAAC;AAED,MAAM,CAAC,MAAM,QAAQ,GAAG,UAAU,CAAC;IAClC,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,EAAE,CACvB,CAAC,GAAG,MAAM,CAAC,OAAO,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,EAAE,YAAY,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,GAAG,CAAC,MAAM,eAAe,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CACvH,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,OAAO,CAAC,IAAI,CAAC,CACxB;IACF,WAAW,EACV,0PAA0P;IAC3P,EAAE,EAAE,wBAAwB;IAC5B,WAAW,EAAE,KAAK;CAClB,CAAC,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"colocated.d.ts","sourceRoot":"","sources":["../../../src/rules/test-names/colocated.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"colocated.d.ts","sourceRoot":"","sources":["../../../src/rules/test-names/colocated.ts"],"names":[],"mappings":"AAiCA,eAAO,MAAM,cAAc;;;;;SAazB,CAAC"}
|
|
@@ -1,7 +1,8 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
-
import { Schema } from "effect";
|
|
2
|
+
import { Effect, Schema } from "effect";
|
|
3
3
|
import { ignorePatterns } from "#adapters/ignore.ts";
|
|
4
4
|
import { GlobDeclarations, globPatterns, validateGlobs } from "#config/globs.ts";
|
|
5
|
+
import { packageTests } from "#naming/packageTests.ts";
|
|
5
6
|
import { isTestCode, testName } from "#naming/testName.ts";
|
|
6
7
|
import { defineRule } from "#rule.ts";
|
|
7
8
|
const MIRROR_FOLDERS = new Set(["__tests__", "spec", "test", "tests"]);
|
|
@@ -25,11 +26,13 @@ function findingOf(path, sourceFolders) {
|
|
|
25
26
|
];
|
|
26
27
|
}
|
|
27
28
|
export const testsColocated = defineRule({
|
|
28
|
-
check: (
|
|
29
|
+
check: Effect.fn("Tests.check")(function* (inputs) {
|
|
30
|
+
const { files, options } = inputs;
|
|
31
|
+
const trees = yield* packageTests(inputs);
|
|
29
32
|
const suites = ignorePatterns([...globPatterns(options.suites)]);
|
|
30
33
|
const sourceFolders = new Set(files.filter((path) => !isTestCode(path)).map((path) => posix.dirname(path)));
|
|
31
|
-
return files.filter((path) => !suites.ignores(path)).flatMap((path) => findingOf(path, sourceFolders));
|
|
32
|
-
},
|
|
34
|
+
return files.filter((path) => !suites.ignores(path) && trees.sourcePath(path) === undefined).flatMap((path) => findingOf(path, sourceFolders));
|
|
35
|
+
}),
|
|
33
36
|
description: "A test sits beside the code it covers, at its module root or directly beside its module folder. Outside declared suites, __tests__ is always a test folder; test, tests and spec are test folders only when their directly contained checked files are all tests or test support. Shared test support belongs in test-support/.",
|
|
34
37
|
id: "tests/colocated",
|
|
35
38
|
options: Schema.toStandardSchemaV1(TestsColocatedOptions, { parseOptions: { errors: "all", onExcessProperty: "error" } }),
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"colocated.js","sourceRoot":"","sources":["../../../src/rules/test-names/colocated.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;
|
|
1
|
+
{"version":3,"file":"colocated.js","sourceRoot":"","sources":["../../../src/rules/test-names/colocated.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,EAAE,gBAAgB,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjF,OAAO,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AACvD,OAAO,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AAC3D,OAAO,EAAE,UAAU,EAAgB,MAAM,UAAU,CAAC;AAEpD,MAAM,cAAc,GAAwB,IAAI,GAAG,CAAC,CAAC,WAAW,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,CAAC,CAAC,CAAC;AAE5F,MAAM,qBAAqB,GAAG,MAAM,CAAC,MAAM,CAAC;IAC3C,MAAM,EAAE,gBAAgB;CACxB,CAAC,CAAC;AAEH,SAAS,SAAS,CAAC,IAAY,EAAE,aAAkC;IAClE,MAAM,IAAI,GAAG,QAAQ,CAAC,IAAI,CAAC,CAAC;IAC5B,MAAM,MAAM,GAAG,IAAI,EAAE,MAAM;SACzB,KAAK,CAAC,GAAG,CAAC;SACV,IAAI,CACJ,CAAC,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,EAAE,CAAC,cAAc,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,MAAM,KAAK,WAAW,IAAI,CAAC,aAAa,CAAC,GAAG,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,EAAE,KAAK,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAC/I,CAAC;IACH,IAAI,IAAI,KAAK,SAAS,IAAI,MAAM,KAAK,SAAS,EAAE,CAAC;QAChD,OAAO,EAAE,CAAC;IACX,CAAC;IACD,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC,GAAG,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,IAAI,QAAQ,EAAE,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC5E,OAAO;QACN;YACC,IAAI,EAAE,IAAI;YACV,OAAO,EAAE,4BAA4B,MAAM,uMAAuM,IAAI,CAAC,IAAI,GAAG,SAAS,QAAQ,IAAI,CAAC,SAAS,WAAW,IAAI,CAAC,IAAI,2BAA2B,SAAS,QAAQ,IAAI,CAAC,SAAS,0LAA0L;SACriB;KACD,CAAC;AACH,CAAC;AAED,MAAM,CAAC,MAAM,cAAc,GAAG,UAAU,CAAC;IACxC,KAAK,EAAE,MAAM,CAAC,EAAE,CAAC,aAAa,CAAC,CAAC,QAAQ,CAAC,EAAE,MAAM;QAChD,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,GAAG,MAAM,CAAC;QAClC,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,MAAM,GAAG,cAAc,CAAC,CAAC,GAAG,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QACjE,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAC5G,OAAO,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,KAAK,CAAC,UAAU,CAAC,IAAI,CAAC,KAAK,SAAS,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,SAAS,CAAC,IAAI,EAAE,aAAa,CAAC,CAAC,CAAC;IAChJ,CAAC,CAAC;IACF,WAAW,EACV,iUAAiU;IAClU,EAAE,EAAE,iBAAiB;IACrB,OAAO,EAAE,MAAM,CAAC,kBAAkB,CAAC,qBAAqB,EAAE,EAAE,YAAY,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,gBAAgB,EAAE,OAAO,EAAE,EAAE,CAAC;IACzH,QAAQ,EAAE,aAAa;CACvB,CAAC,CAAC"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"follow.d.ts","sourceRoot":"","sources":["../../../src/rules/test-names/follow.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"follow.d.ts","sourceRoot":"","sources":["../../../src/rules/test-names/follow.ts"],"names":[],"mappings":"AAoFA,eAAO,MAAM,WAAW;;;;;SAatB,CAAC"}
|
|
@@ -1,7 +1,8 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
-
import { Schema } from "effect";
|
|
2
|
+
import { Effect, Schema } from "effect";
|
|
3
3
|
import { ignorePatterns } from "#adapters/ignore.ts";
|
|
4
4
|
import { GlobDeclarations, globPatterns, validateGlobs } from "#config/globs.ts";
|
|
5
|
+
import { packageTests } from "#naming/packageTests.ts";
|
|
5
6
|
import { ENVIRONMENTS, testName } from "#naming/testName.ts";
|
|
6
7
|
import { CAMEL } from "#naming/words.ts";
|
|
7
8
|
import { defineRule } from "#rule.ts";
|
|
@@ -55,21 +56,27 @@ function environmentMessage(file, name, source) {
|
|
|
55
56
|
const unit = name.modifiers.includes("unit") ? ", not a unit test, and drives the DOM through the package's story kit" : "";
|
|
56
57
|
return `"${file}" uses the DOM, so it is ${name.stem}.dom.${name.kind}${name.extension}${unit} and runs in the dom project.`;
|
|
57
58
|
}
|
|
58
|
-
function findingsOf(source, siblings) {
|
|
59
|
+
function findingsOf(source, siblings, sourcePath) {
|
|
59
60
|
const name = testName(source.path);
|
|
60
61
|
if (name === undefined) {
|
|
61
62
|
return [];
|
|
62
63
|
}
|
|
63
64
|
const file = posix.basename(source.path);
|
|
64
|
-
const messages = [
|
|
65
|
+
const messages = [
|
|
66
|
+
suffixMessage(file, name),
|
|
67
|
+
placeMessage(file, { ...name, folder: posix.dirname(sourcePath(source.path) ?? source.path) }, siblings),
|
|
68
|
+
environmentMessage(file, name, source),
|
|
69
|
+
];
|
|
65
70
|
return messages.flatMap((message) => (message === undefined ? [] : [{ file: source.path, message }]));
|
|
66
71
|
}
|
|
67
72
|
export const testsFollow = defineRule({
|
|
68
|
-
check: (
|
|
73
|
+
check: Effect.fn("Tests.check")(function* (inputs) {
|
|
74
|
+
const { files, options, sources } = inputs;
|
|
75
|
+
const trees = yield* packageTests(inputs);
|
|
69
76
|
const suites = ignorePatterns([...globPatterns(options.suites)]);
|
|
70
77
|
const siblings = siblingsIn(files);
|
|
71
|
-
return sources.filter((source) => !suites.ignores(source.path)).flatMap((source) => findingsOf(source, siblings));
|
|
72
|
-
},
|
|
78
|
+
return sources.filter((source) => !suites.ignores(source.path)).flatMap((source) => findingsOf(source, siblings, trees.sourcePath));
|
|
79
|
+
}),
|
|
73
80
|
description: "A .test file follows the file beside it, a .spec names a behaviour of its folder, the only suffix is one modifier of dom, heavy, slow, typecheck and unit, and a test that uses the DOM is a .dom test.",
|
|
74
81
|
id: "tests/follow",
|
|
75
82
|
options: Schema.toStandardSchemaV1(TestsFollowOptions, { parseOptions: { errors: "all", onExcessProperty: "error" } }),
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"follow.js","sourceRoot":"","sources":["../../../src/rules/test-names/follow.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;
|
|
1
|
+
{"version":3,"file":"follow.js","sourceRoot":"","sources":["../../../src/rules/test-names/follow.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,KAAK,EAAE,MAAM,WAAW,CAAC;AAClC,OAAO,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,QAAQ,CAAC;AACxC,OAAO,EAAE,cAAc,EAAE,MAAM,qBAAqB,CAAC;AACrD,OAAO,EAAE,gBAAgB,EAAE,YAAY,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjF,OAAO,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AACvD,OAAO,EAAE,YAAY,EAAiB,QAAQ,EAAE,MAAM,qBAAqB,CAAC;AAC5E,OAAO,EAAE,KAAK,EAAE,MAAM,kBAAkB,CAAC;AACzC,OAAO,EAAE,UAAU,EAAiC,MAAM,UAAU,CAAC;AACrE,OAAO,EAAE,OAAO,EAAE,MAAM,8BAA8B,CAAC;AAEvD,MAAM,iBAAiB,GAAwB,IAAI,GAAG,CAAC,YAAY,CAAC,CAAC;AAErE,MAAM,gBAAgB,GAAwB,IAAI,GAAG,CAAC,CAAC,aAAa,EAAE,UAAU,CAAC,CAAC,CAAC;AAEnF,MAAM,IAAI,GAAG,kBAAkB,CAAC;AAEhC,MAAM,OAAO,GACZ,4LAA4L,CAAC;AAE9L,MAAM,kBAAkB,GAAG,MAAM,CAAC,MAAM,CAAC;IACxC,MAAM,EAAE,gBAAgB;CACxB,CAAC,CAAC;AAEH,SAAS,UAAU,CAAC,KAAwB;IAC3C,OAAO,IAAI,GAAG,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,QAAQ,CAAC,IAAI,CAAC,KAAK,SAAS,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC;AAC/H,CAAC;AAED,SAAS,aAAa,CAAC,IAAY,EAAE,IAAc;IAClD,MAAM,CAAC,KAAK,EAAE,GAAG,IAAI,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;IACxC,IAAI,KAAK,KAAK,SAAS,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,IAAI,iBAAiB,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;QAChF,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,IAAI,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,KAAK,CAAC,EAAE,CAAC;QACvE,OAAO,IAAI,IAAI,2HAA2H,IAAI,CAAC,IAAI,QAAQ,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC,SAAS,+BAA+B,IAAI,CAAC,IAAI,SAAS,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC,SAAS,GAAG,CAAC;IACrQ,CAAC;IACD,MAAM,OAAO,GAAG,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,gBAAgB,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC;IAClF,IAAI,OAAO,KAAK,SAAS,EAAE,CAAC;QAC3B,OAAO,KAAK,OAAO,qJAAqJ,OAAO,EAAE,CAAC;IACnL,CAAC;IACD,OAAO,IAAI,IAAI,wBAAwB,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,GAAG,CAAC,MAAM,OAAO,8EAA8E,CAAC;AAC5J,CAAC;AAED,SAAS,QAAQ,CAAC,IAAc;IAC/B,MAAM,CAAC,IAAI,EAAE,GAAG,IAAI,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;IACvC,OAAO,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC,IAAI,iBAAiB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,IAAI,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC;AACjG,CAAC;AAED,SAAS,YAAY,CAAC,IAAY,EAAE,IAAc,EAAE,QAA6B;IAChF,MAAM,OAAO,GAAG,QAAQ,CAAC,GAAG,CAAC,GAAG,IAAI,CAAC,MAAM,IAAI,IAAI,CAAC,IAAI,EAAE,CAAC,CAAC;IAC5D,MAAM,IAAI,GAAG,GAAG,QAAQ,CAAC,IAAI,CAAC,QAAQ,IAAI,CAAC,SAAS,EAAE,CAAC;IACvD,MAAM,IAAI,GAAG,eAAe,QAAQ,CAAC,IAAI,CAAC,QAAQ,IAAI,CAAC,SAAS,EAAE,CAAC;IACnE,IAAI,IAAI,CAAC,IAAI,KAAK,MAAM,EAAE,CAAC;QAC1B,OAAO,OAAO;YACb,CAAC,CAAC,SAAS;YACX,CAAC,CAAC,IAAI,IAAI,sBAAsB,IAAI,CAAC,IAAI,GAAG,IAAI,gBAAgB,IAAI,CAAC,IAAI,yFAAyF,IAAI,CAAC,SAAS,aAAa,IAAI,GAAG,CAAC;IACvM,CAAC;IACD,IAAI,OAAO,EAAE,CAAC;QACb,OAAO,IAAI,IAAI,0BAA0B,IAAI,CAAC,IAAI,yDAAyD,IAAI,eAAe,IAAI,CAAC,IAAI,UAAU,IAAI,CAAC,IAAI,GAAG,IAAI,GAAG,CAAC;IACtK,CAAC;IACD,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,IAAI,+CAA+C,IAAI,GAAG,CAAC;AAC3G,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAY,EAAE,IAAc,EAAE,MAAkB;IAC3E,IAAI,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,WAAW,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,EAAE,CAAC;QAChG,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,IAAI,GAAG,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,uEAAuE,CAAC,CAAC,CAAC,EAAE,CAAC;IAC5H,OAAO,IAAI,IAAI,4BAA4B,IAAI,CAAC,IAAI,QAAQ,IAAI,CAAC,IAAI,GAAG,IAAI,CAAC,SAAS,GAAG,IAAI,+BAA+B,CAAC;AAC9H,CAAC;AAED,SAAS,UAAU,CAAC,MAAkB,EAAE,QAA6B,EAAE,UAAgD;IACtH,MAAM,IAAI,GAAG,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IACnC,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,OAAO,EAAE,CAAC;IACX,CAAC;IACD,MAAM,IAAI,GAAG,KAAK,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC;IACzC,MAAM,QAAQ,GAAG;QAChB,aAAa,CAAC,IAAI,EAAE,IAAI,CAAC;QACzB,YAAY,CAAC,IAAI,EAAE,EAAE,GAAG,IAAI,EAAE,MAAM,EAAE,KAAK,CAAC,OAAO,CAAC,UAAU,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,MAAM,CAAC,IAAI,CAAC,EAAE,EAAE,QAAQ,CAAC;QACxG,kBAAkB,CAAC,IAAI,EAAE,IAAI,EAAE,MAAM,CAAC;KACtC,CAAC;IACF,OAAO,QAAQ,CAAC,OAAO,CAAC,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC,OAAO,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,CAAC,IAAI,EAAE,OAAO,EAAE,CAAC,CAAC,CAAC,CAAC;AACvG,CAAC;AAED,MAAM,CAAC,MAAM,WAAW,GAAG,UAAU,CAAC;IACrC,KAAK,EAAE,MAAM,CAAC,EAAE,CAAC,aAAa,CAAC,CAAC,QAAQ,CAAC,EAAE,MAAM;QAChD,MAAM,EAAE,KAAK,EAAE,OAAO,EAAE,OAAO,EAAE,GAAG,MAAM,CAAC;QAC3C,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,YAAY,CAAC,MAAM,CAAC,CAAC;QAC1C,MAAM,MAAM,GAAG,cAAc,CAAC,CAAC,GAAG,YAAY,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC;QACjE,MAAM,QAAQ,GAAG,UAAU,CAAC,KAAK,CAAC,CAAC;QACnC,OAAO,OAAO,CAAC,MAAM,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,CAAC,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,MAAM,EAAE,EAAE,CAAC,UAAU,CAAC,MAAM,EAAE,QAAQ,EAAE,KAAK,CAAC,UAAU,CAAC,CAAC,CAAC;IACrI,CAAC,CAAC;IACF,WAAW,EACV,yMAAyM;IAC1M,EAAE,EAAE,cAAc;IAClB,OAAO,EAAE,MAAM,CAAC,kBAAkB,CAAC,kBAAkB,EAAE,EAAE,YAAY,EAAE,EAAE,MAAM,EAAE,KAAK,EAAE,gBAAgB,EAAE,OAAO,EAAE,EAAE,CAAC;IACtH,QAAQ,EAAE,aAAa;CACvB,CAAC,CAAC"}
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@shivaedev/quality",
|
|
3
|
-
"version": "0.
|
|
3
|
+
"version": "0.67.1",
|
|
4
4
|
"description": "Repository quality gate with typed rules, a baseline of existing debt and a registry of reasoned exceptions",
|
|
5
5
|
"homepage": "https://github.com/ShivaeDev/platform/tree/main/packages/quality#readme",
|
|
6
6
|
"bugs": {
|
|
@@ -15,6 +15,7 @@
|
|
|
15
15
|
"sideEffects": false,
|
|
16
16
|
"type": "module",
|
|
17
17
|
"imports": {
|
|
18
|
+
"#biome-preset": "./biome/preset.json",
|
|
18
19
|
"#test/*": "./src/test-support/*",
|
|
19
20
|
"#*.ts": {
|
|
20
21
|
"@shivaedev/source": "./src/*.ts",
|
|
@@ -65,7 +66,7 @@
|
|
|
65
66
|
"@effect/platform-node": "4.1.0",
|
|
66
67
|
"@effect/platform-node-shared": "4.1.0",
|
|
67
68
|
"@effect/vitest": "4.1.0",
|
|
68
|
-
"@shivaedev/test-story": "0.
|
|
69
|
+
"@shivaedev/test-story": "0.43.0",
|
|
69
70
|
"@types/node": "24.19.2",
|
|
70
71
|
"@typescript/native": "npm:typescript@7.0.2",
|
|
71
72
|
"effect": "4.1.0",
|
|
@@ -74,7 +75,7 @@
|
|
|
74
75
|
"peerDependencies": {
|
|
75
76
|
"@effect/platform-node": "4.1.0",
|
|
76
77
|
"@effect/platform-node-shared": "4.1.0",
|
|
77
|
-
"@shivaedev/test-story": "0.
|
|
78
|
+
"@shivaedev/test-story": "0.43.0",
|
|
78
79
|
"effect": "4.1.0",
|
|
79
80
|
"vitest": "5.0.5"
|
|
80
81
|
},
|
|
@@ -0,0 +1,33 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { importFrom } from "#rules/stories/importOrigin.ts";
|
|
3
|
+
import { unwrapped } from "#rules/stories/syntax.ts";
|
|
4
|
+
|
|
5
|
+
const MATCHERS = new Set(["any", "anything", "arrayContaining", "objectContaining", "stringContaining", "stringMatching"]);
|
|
6
|
+
|
|
7
|
+
function importedExpect(node: ts.Expression, checker: ts.TypeChecker): boolean {
|
|
8
|
+
const value = unwrapped(node);
|
|
9
|
+
if (ts.isPropertyAccessExpression(value) && value.name.text === "not") {
|
|
10
|
+
return importedExpect(value.expression, checker);
|
|
11
|
+
}
|
|
12
|
+
const namespace = ts.isPropertyAccessExpression(value) && value.name.text === "expect";
|
|
13
|
+
const receiver = namespace ? value.expression : value;
|
|
14
|
+
if (!ts.isIdentifier(receiver)) {
|
|
15
|
+
return false;
|
|
16
|
+
}
|
|
17
|
+
return (
|
|
18
|
+
checker.getSymbolAtLocation(receiver)?.declarations?.some((declaration) => {
|
|
19
|
+
const from = importFrom(declaration);
|
|
20
|
+
return (
|
|
21
|
+
(from === "vitest" || from === "@effect/vitest")
|
|
22
|
+
&& (namespace
|
|
23
|
+
? ts.isNamespaceImport(declaration)
|
|
24
|
+
: ts.isImportSpecifier(declaration) && (declaration.propertyName ?? declaration.name).text === "expect")
|
|
25
|
+
);
|
|
26
|
+
}) === true
|
|
27
|
+
);
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
export function asymmetricMatcher(call: ts.CallExpression, checker: ts.TypeChecker): boolean {
|
|
31
|
+
const target = unwrapped(call.expression);
|
|
32
|
+
return ts.isPropertyAccessExpression(target) && MATCHERS.has(target.name.text) && importedExpect(target.expression, checker);
|
|
33
|
+
}
|
|
@@ -0,0 +1,52 @@
|
|
|
1
|
+
import { posix } from "node:path";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import { buildEntryValue, buildOption } from "./buildEntryValue.ts";
|
|
4
|
+
import { importedCall } from "./importedCall.ts";
|
|
5
|
+
|
|
6
|
+
function pathFromCall(node: ts.CallExpression, cwd: string, paths: (expression: ts.Expression) => readonly string[]): readonly string[] {
|
|
7
|
+
if (node.expression.getText() === "process.cwd" && node.arguments.length === 0) {
|
|
8
|
+
return [cwd];
|
|
9
|
+
}
|
|
10
|
+
const imported = importedCall(node);
|
|
11
|
+
if (imported === undefined || !/^(?:node:)?path$/u.test(imported.module) || (imported.name !== "join" && imported.name !== "resolve")) {
|
|
12
|
+
return [];
|
|
13
|
+
}
|
|
14
|
+
const parts = node.arguments.map(paths);
|
|
15
|
+
if (parts.some((part) => part.length !== 1)) {
|
|
16
|
+
return [];
|
|
17
|
+
}
|
|
18
|
+
const values = parts.flat();
|
|
19
|
+
return [imported.name === "resolve" ? posix.resolve(cwd, ...values) : posix.join(...values)];
|
|
20
|
+
}
|
|
21
|
+
|
|
22
|
+
function valuesOf(node: ts.Expression): readonly ts.Expression[] {
|
|
23
|
+
if (ts.isArrayLiteralExpression(node)) {
|
|
24
|
+
return node.elements;
|
|
25
|
+
}
|
|
26
|
+
if (!ts.isObjectLiteralExpression(node)) {
|
|
27
|
+
return [];
|
|
28
|
+
}
|
|
29
|
+
const input = buildOption(node, "in");
|
|
30
|
+
return input === undefined ? node.properties.flatMap((property) => (ts.isPropertyAssignment(property) ? [property.initializer] : [])) : [input];
|
|
31
|
+
}
|
|
32
|
+
|
|
33
|
+
export function buildEntryPaths(expression: ts.Expression, cwd: string, file: string, active: ReadonlySet<ts.Node> = new Set()): readonly string[] {
|
|
34
|
+
const node = buildEntryValue(expression);
|
|
35
|
+
if (active.has(node)) {
|
|
36
|
+
return [];
|
|
37
|
+
}
|
|
38
|
+
const visited = new Set([...active, node]);
|
|
39
|
+
function paths(value: ts.Expression) {
|
|
40
|
+
return buildEntryPaths(value, cwd, file, visited);
|
|
41
|
+
}
|
|
42
|
+
if (ts.isStringLiteralLike(node)) {
|
|
43
|
+
return [node.text];
|
|
44
|
+
}
|
|
45
|
+
if (
|
|
46
|
+
(ts.isIdentifier(node) && node.text === "__dirname")
|
|
47
|
+
|| (ts.isPropertyAccessExpression(node) && node.expression.kind === ts.SyntaxKind.MetaProperty && node.name.text === "dirname")
|
|
48
|
+
) {
|
|
49
|
+
return [posix.dirname(file)];
|
|
50
|
+
}
|
|
51
|
+
return ts.isCallExpression(node) ? pathFromCall(node, cwd, paths) : valuesOf(node).flatMap(paths);
|
|
52
|
+
}
|
|
@@ -0,0 +1,52 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
|
|
3
|
+
function declaredValue(statements: readonly ts.Statement[], name: string): ts.Expression | undefined {
|
|
4
|
+
for (const statement of statements) {
|
|
5
|
+
if (!(ts.isVariableStatement(statement) && statement.declarationList.flags & ts.NodeFlags.Const)) {
|
|
6
|
+
continue;
|
|
7
|
+
}
|
|
8
|
+
const declaration = statement.declarationList.declarations.find((entry) => ts.isIdentifier(entry.name) && entry.name.text === name);
|
|
9
|
+
if (declaration !== undefined) {
|
|
10
|
+
return declaration.initializer;
|
|
11
|
+
}
|
|
12
|
+
}
|
|
13
|
+
return undefined;
|
|
14
|
+
}
|
|
15
|
+
|
|
16
|
+
function initializer(node: ts.Identifier): ts.Expression | undefined {
|
|
17
|
+
let scope: ts.Node | undefined = node.parent;
|
|
18
|
+
while (scope !== undefined) {
|
|
19
|
+
const value = ts.isSourceFile(scope) || ts.isBlock(scope) ? declaredValue(scope.statements, node.text) : undefined;
|
|
20
|
+
if (value !== undefined) {
|
|
21
|
+
return value;
|
|
22
|
+
}
|
|
23
|
+
scope = scope.parent;
|
|
24
|
+
}
|
|
25
|
+
return undefined;
|
|
26
|
+
}
|
|
27
|
+
|
|
28
|
+
export function buildEntryValue(node: ts.Expression, active: ReadonlySet<ts.Node> = new Set()): ts.Expression {
|
|
29
|
+
if (active.has(node)) {
|
|
30
|
+
return node;
|
|
31
|
+
}
|
|
32
|
+
const visited = new Set([...active, node]);
|
|
33
|
+
if (ts.isIdentifier(node)) {
|
|
34
|
+
const value = initializer(node);
|
|
35
|
+
return value === undefined ? node : buildEntryValue(value, visited);
|
|
36
|
+
}
|
|
37
|
+
return ts.isAsExpression(node) || ts.isSatisfiesExpression(node) || ts.isParenthesizedExpression(node)
|
|
38
|
+
? buildEntryValue(node.expression, visited)
|
|
39
|
+
: node;
|
|
40
|
+
}
|
|
41
|
+
|
|
42
|
+
export function buildOption(options: ts.ObjectLiteralExpression, name: string): ts.Expression | undefined {
|
|
43
|
+
for (const property of options.properties) {
|
|
44
|
+
if (
|
|
45
|
+
(ts.isPropertyAssignment(property) || ts.isShorthandPropertyAssignment(property))
|
|
46
|
+
&& property.name.getText().replace(/^["']|["']$/gu, "") === name
|
|
47
|
+
) {
|
|
48
|
+
return ts.isPropertyAssignment(property) ? property.initializer : property.name;
|
|
49
|
+
}
|
|
50
|
+
}
|
|
51
|
+
return undefined;
|
|
52
|
+
}
|
|
@@ -0,0 +1,53 @@
|
|
|
1
|
+
import { posix } from "node:path";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import type { SourceFile } from "#rule.ts";
|
|
4
|
+
import { parse } from "#rules/parse.ts";
|
|
5
|
+
import { buildEntryPaths } from "./buildEntryPaths.ts";
|
|
6
|
+
import { buildEntryValue, buildOption } from "./buildEntryValue.ts";
|
|
7
|
+
import { importedCall } from "./importedCall.ts";
|
|
8
|
+
|
|
9
|
+
const ESBUILD = new Set(["build", "buildSync", "context"]);
|
|
10
|
+
|
|
11
|
+
function entryOption(call: ts.CallExpression): string | undefined {
|
|
12
|
+
const expression = call.expression;
|
|
13
|
+
if (ts.isPropertyAccessExpression(expression) && expression.expression.getText() === "Bun" && expression.name.text === "build") {
|
|
14
|
+
return "entrypoints";
|
|
15
|
+
}
|
|
16
|
+
const imported = importedCall(call);
|
|
17
|
+
return imported?.module === "esbuild" && ESBUILD.has(imported.name) ? "entryPoints" : undefined;
|
|
18
|
+
}
|
|
19
|
+
|
|
20
|
+
function entriesOf(call: ts.CallExpression, file: string, cwd: string): readonly string[] {
|
|
21
|
+
const option = entryOption(call);
|
|
22
|
+
const [argument] = call.arguments;
|
|
23
|
+
const options = argument === undefined ? undefined : buildEntryValue(argument);
|
|
24
|
+
if (option === undefined || options === undefined || !ts.isObjectLiteralExpression(options)) {
|
|
25
|
+
return [];
|
|
26
|
+
}
|
|
27
|
+
const directory = buildOption(options, "absWorkingDir");
|
|
28
|
+
const working = directory === undefined ? cwd : buildEntryPaths(directory, cwd, file)[0];
|
|
29
|
+
if (working === undefined) {
|
|
30
|
+
return [];
|
|
31
|
+
}
|
|
32
|
+
const entries = buildOption(options, option);
|
|
33
|
+
return entries === undefined ? [] : buildEntryPaths(entries, cwd, file).map((path) => posix.resolve(cwd, working, path));
|
|
34
|
+
}
|
|
35
|
+
|
|
36
|
+
export function bundlerEntries(file: SourceFile, root: string, directory: string): readonly string[] {
|
|
37
|
+
if (!(file.text.includes("esbuild") || file.text.includes("Bun"))) {
|
|
38
|
+
return [];
|
|
39
|
+
}
|
|
40
|
+
const source = parse(file);
|
|
41
|
+
if (source === undefined) {
|
|
42
|
+
return [];
|
|
43
|
+
}
|
|
44
|
+
const entries: string[] = [];
|
|
45
|
+
function visit(node: ts.Node): void {
|
|
46
|
+
if (ts.isCallExpression(node)) {
|
|
47
|
+
entries.push(...entriesOf(node, posix.join(root, file.path), posix.join(root, directory)).map((path) => posix.relative(root, path)));
|
|
48
|
+
}
|
|
49
|
+
ts.forEachChild(node, visit);
|
|
50
|
+
}
|
|
51
|
+
visit(source);
|
|
52
|
+
return entries;
|
|
53
|
+
}
|
|
@@ -0,0 +1,32 @@
|
|
|
1
|
+
import type ts from "typescript";
|
|
2
|
+
|
|
3
|
+
export function callbackEscapes(checker: ts.TypeChecker, call: ts.CallExpression, callback: ts.Node): boolean {
|
|
4
|
+
const seen = new Set<ts.Type>();
|
|
5
|
+
function exposed(type: ts.Type): boolean {
|
|
6
|
+
if (seen.has(type) || ["~effect/Effect", "~effect/Stream", "~effect/Layer"].some((brand) => type.getProperty(brand) !== undefined)) {
|
|
7
|
+
return false;
|
|
8
|
+
}
|
|
9
|
+
seen.add(type);
|
|
10
|
+
if (type.isUnionOrIntersection()) {
|
|
11
|
+
return type.types.some(exposed);
|
|
12
|
+
}
|
|
13
|
+
if (
|
|
14
|
+
type
|
|
15
|
+
.getCallSignatures()
|
|
16
|
+
.some((signature) => signature.parameters.some((parameter) => parameter.declarations?.some((declaration) => declaration.parent === callback)))
|
|
17
|
+
) {
|
|
18
|
+
return true;
|
|
19
|
+
}
|
|
20
|
+
return (
|
|
21
|
+
checker.getIndexInfosOfType(type).some((index) => exposed(index.type))
|
|
22
|
+
|| type
|
|
23
|
+
.getProperties()
|
|
24
|
+
.some(
|
|
25
|
+
(property) =>
|
|
26
|
+
(property.declarations ?? []).some((declaration) => declaration.getSourceFile() === callback.getSourceFile())
|
|
27
|
+
&& exposed(checker.getTypeOfSymbol(property)),
|
|
28
|
+
)
|
|
29
|
+
);
|
|
30
|
+
}
|
|
31
|
+
return exposed(checker.getTypeAtLocation(call));
|
|
32
|
+
}
|
|
@@ -0,0 +1,48 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { effectApi, resolvedValue } from "#adapters/serviceModelSyntax.ts";
|
|
3
|
+
import { boundaryReference } from "#rules/effect/boundaryReference.ts";
|
|
4
|
+
|
|
5
|
+
function closedEffect(checker: ts.TypeChecker, node: ts.Node): boolean {
|
|
6
|
+
const brand = checker.getTypeAtLocation(node).getProperty("~effect/Effect");
|
|
7
|
+
const requirement = brand === undefined ? undefined : checker.getTypeOfSymbol(brand).getProperty("_R");
|
|
8
|
+
const type = requirement === undefined ? undefined : checker.getTypeOfSymbol(requirement).getCallSignatures()[0]?.getReturnType();
|
|
9
|
+
return type !== undefined && (type.flags & ts.TypeFlags.Never) !== 0;
|
|
10
|
+
}
|
|
11
|
+
|
|
12
|
+
function layerProvision(checker: ts.TypeChecker, node: ts.Node): boolean {
|
|
13
|
+
return (
|
|
14
|
+
ts.isCallExpression(node)
|
|
15
|
+
&& effectApi(checker, node.expression, "provide")
|
|
16
|
+
&& node.arguments.some((argument) => checker.getTypeAtLocation(argument).getProperty("~effect/Layer") !== undefined)
|
|
17
|
+
);
|
|
18
|
+
}
|
|
19
|
+
|
|
20
|
+
export function composedContext(checker: ts.TypeChecker, environment: ts.Expression): boolean {
|
|
21
|
+
const value = resolvedValue(checker, environment);
|
|
22
|
+
if (!(ts.isYieldExpression(value) && value.expression !== undefined && ts.isCallExpression(value.expression))) {
|
|
23
|
+
return false;
|
|
24
|
+
}
|
|
25
|
+
const acquisition = value.expression;
|
|
26
|
+
const reference = boundaryReference(checker, acquisition.expression);
|
|
27
|
+
if (
|
|
28
|
+
reference === "effect.Layer.build"
|
|
29
|
+
|| reference === "effect/Layer.build"
|
|
30
|
+
|| reference === "effect.Layer.buildWithScope"
|
|
31
|
+
|| reference === "effect/Layer.buildWithScope"
|
|
32
|
+
) {
|
|
33
|
+
return true;
|
|
34
|
+
}
|
|
35
|
+
if (!effectApi(checker, acquisition.expression, "context")) {
|
|
36
|
+
return false;
|
|
37
|
+
}
|
|
38
|
+
let provided = false;
|
|
39
|
+
for (let ancestor: ts.Node | undefined = value.parent; ancestor !== undefined; ancestor = ancestor.parent) {
|
|
40
|
+
if (ts.isCallExpression(ancestor)) {
|
|
41
|
+
provided ||= layerProvision(checker, ancestor) || ancestor.arguments.some((argument) => layerProvision(checker, argument));
|
|
42
|
+
if (provided && closedEffect(checker, ancestor)) {
|
|
43
|
+
return true;
|
|
44
|
+
}
|
|
45
|
+
}
|
|
46
|
+
}
|
|
47
|
+
return false;
|
|
48
|
+
}
|
|
@@ -0,0 +1,40 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import type { serviceTypes } from "#rules/effect/serviceTypes.ts";
|
|
3
|
+
|
|
4
|
+
const NATIVE =
|
|
5
|
+
/\/effect\/(?:src|dist(?:\/dts)?)\/(?:Ref|SynchronizedRef|ScopedRef|Cache|ScopedCache|Deferred|Queue|PubSub|HashMap|HashSet)\.(?:d\.)?ts$/u;
|
|
6
|
+
const COLLECTIONS = new Set(["Map", "ReadonlyMap", "Set", "ReadonlySet", "Array", "ReadonlyArray"]);
|
|
7
|
+
|
|
8
|
+
function reference(type: ts.Type): type is ts.TypeReference {
|
|
9
|
+
return "objectFlags" in type && typeof type.objectFlags === "number" && (type.objectFlags & ts.ObjectFlags.Reference) !== 0;
|
|
10
|
+
}
|
|
11
|
+
|
|
12
|
+
function container(type: ts.Type): boolean {
|
|
13
|
+
const symbol = type.getSymbol();
|
|
14
|
+
return (symbol?.declarations ?? []).some((declaration) => {
|
|
15
|
+
const file = declaration.getSourceFile().fileName.replaceAll("\\", "/");
|
|
16
|
+
return NATIVE.test(file) || (COLLECTIONS.has(symbol?.name ?? "") && /\/lib\.[^/]+\.d\.ts$/u.test(file));
|
|
17
|
+
});
|
|
18
|
+
}
|
|
19
|
+
|
|
20
|
+
export function containerDependency(
|
|
21
|
+
checker: ts.TypeChecker,
|
|
22
|
+
type: ts.Type,
|
|
23
|
+
services: ReturnType<typeof serviceTypes>,
|
|
24
|
+
seen = new Set<ts.Type>(),
|
|
25
|
+
): boolean {
|
|
26
|
+
if (seen.has(type) || !(type.flags & (ts.TypeFlags.Object | ts.TypeFlags.Union | ts.TypeFlags.Intersection)) || services.computation(type)) {
|
|
27
|
+
return false;
|
|
28
|
+
}
|
|
29
|
+
seen.add(type);
|
|
30
|
+
if (type.isUnionOrIntersection()) {
|
|
31
|
+
return type.types.some((part) => containerDependency(checker, part, services, seen));
|
|
32
|
+
}
|
|
33
|
+
if (container(type) && reference(type)) {
|
|
34
|
+
return checker.getTypeArguments(type).some((argument) => services.carries(argument) || containerDependency(checker, argument, services, seen));
|
|
35
|
+
}
|
|
36
|
+
return (
|
|
37
|
+
type.getCallSignatures().length === 0
|
|
38
|
+
&& type.getProperties().some((property) => containerDependency(checker, checker.getTypeOfSymbol(property), services, seen))
|
|
39
|
+
);
|
|
40
|
+
}
|
|
@@ -1,6 +1,7 @@
|
|
|
1
1
|
import { join } from "node:path";
|
|
2
2
|
import { Effect } from "effect";
|
|
3
3
|
import ts from "typescript";
|
|
4
|
+
import { composedContext } from "#adapters/composedContext.ts";
|
|
4
5
|
import { effectApi } from "#adapters/serviceModelSyntax.ts";
|
|
5
6
|
import type { Finding, RuleInputs } from "#rule.ts";
|
|
6
7
|
import { effectProgram } from "#rules/effect/program.ts";
|
|
@@ -41,7 +42,8 @@ export const contextCaptureFindings = Effect.fn("ContextCapture.contextCaptureFi
|
|
|
41
42
|
const syntax = source;
|
|
42
43
|
const findings: Finding[] = [];
|
|
43
44
|
function visit(node: ts.Node): void {
|
|
44
|
-
|
|
45
|
+
const environment = ts.isCallExpression(node) ? node.arguments.at(-1) : undefined;
|
|
46
|
+
if (ts.isCallExpression(node) && reprovides(checker, node) && !(environment !== undefined && composedContext(checker, environment))) {
|
|
45
47
|
findings.push({
|
|
46
48
|
file: file.path,
|
|
47
49
|
line: syntax.getLineAndCharacterOfPosition(node.getStart(syntax)).line + 1,
|