@shivaedev/quality 0.56.0 → 0.57.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +34 -0
- package/README.md +63 -4
- package/biome/plugins/effect-test-bodies.grit +1 -1
- package/dist/{rules/suppressions → adapters}/biome/configs.d.ts +2 -2
- package/dist/adapters/biome/configs.d.ts.map +1 -0
- package/dist/{rules/suppressions → adapters}/biome/configs.js +2 -2
- package/dist/adapters/biome/configs.js.map +1 -0
- package/dist/adapters/biome/presetConfig.d.ts +21 -0
- package/dist/adapters/biome/presetConfig.d.ts.map +1 -0
- package/dist/adapters/biome/presetConfig.js +32 -0
- package/dist/adapters/biome/presetConfig.js.map +1 -0
- package/dist/adapters/biome/relocateConfig.d.ts.map +1 -0
- package/dist/adapters/biome/relocateConfig.js.map +1 -0
- package/dist/adapters/biome/resolvePackage.d.ts.map +1 -0
- package/dist/adapters/biome/resolvePackage.js.map +1 -0
- package/dist/adapters/biome/rootConfig.d.ts +9 -0
- package/dist/adapters/biome/rootConfig.d.ts.map +1 -0
- package/dist/adapters/biome/rootConfig.js +11 -0
- package/dist/adapters/biome/rootConfig.js.map +1 -0
- package/dist/adapters/biome/run.js +1 -1
- package/dist/adapters/biome/run.js.map +1 -1
- package/dist/adapters/biome/syntaxOf.d.ts +3 -0
- package/dist/adapters/biome/syntaxOf.d.ts.map +1 -0
- package/dist/adapters/biome/syntaxOf.js +11 -0
- package/dist/adapters/biome/syntaxOf.js.map +1 -0
- package/dist/adapters/biome/withExceptionConfig.d.ts +8 -0
- package/dist/adapters/biome/withExceptionConfig.d.ts.map +1 -0
- package/dist/adapters/biome/withExceptionConfig.js +38 -0
- package/dist/adapters/biome/withExceptionConfig.js.map +1 -0
- package/dist/adapters/changeKeyApi.d.ts +4 -0
- package/dist/adapters/changeKeyApi.d.ts.map +1 -0
- package/dist/adapters/changeKeyApi.js +58 -0
- package/dist/adapters/changeKeyApi.js.map +1 -0
- package/dist/adapters/changeKeyFindings.d.ts +4 -0
- package/dist/adapters/changeKeyFindings.d.ts.map +1 -0
- package/dist/adapters/changeKeyFindings.js +87 -0
- package/dist/adapters/changeKeyFindings.js.map +1 -0
- package/dist/adapters/changeKeyLiterals.d.ts +3 -0
- package/dist/adapters/changeKeyLiterals.d.ts.map +1 -0
- package/dist/adapters/changeKeyLiterals.js +56 -0
- package/dist/adapters/changeKeyLiterals.js.map +1 -0
- package/dist/adapters/ignore.d.ts +10 -0
- package/dist/adapters/ignore.d.ts.map +1 -0
- package/dist/adapters/ignore.js +10 -0
- package/dist/adapters/ignore.js.map +1 -0
- package/dist/adapters/imports/fakeReferences.d.ts +14 -0
- package/dist/adapters/imports/fakeReferences.d.ts.map +1 -0
- package/dist/adapters/imports/fakeReferences.js +103 -0
- package/dist/adapters/imports/fakeReferences.js.map +1 -0
- package/dist/adapters/imports/fakeTargets.d.ts +13 -0
- package/dist/adapters/imports/fakeTargets.d.ts.map +1 -0
- package/dist/adapters/imports/fakeTargets.js +14 -0
- package/dist/adapters/imports/fakeTargets.js.map +1 -0
- package/dist/adapters/outsideImportFindings.d.ts +5 -0
- package/dist/adapters/outsideImportFindings.d.ts.map +1 -0
- package/dist/adapters/outsideImportFindings.js +78 -0
- package/dist/adapters/outsideImportFindings.js.map +1 -0
- package/dist/adapters/queueReadoutFindings.d.ts +8 -0
- package/dist/adapters/queueReadoutFindings.d.ts.map +1 -0
- package/dist/adapters/queueReadoutFindings.js +30 -0
- package/dist/adapters/queueReadoutFindings.js.map +1 -0
- package/dist/adapters/queueTestingOrigin.d.ts +5 -0
- package/dist/adapters/queueTestingOrigin.d.ts.map +1 -0
- package/dist/adapters/queueTestingOrigin.js +95 -0
- package/dist/adapters/queueTestingOrigin.js.map +1 -0
- package/dist/adapters/readConfig.d.ts +7 -0
- package/dist/adapters/readConfig.d.ts.map +1 -0
- package/dist/adapters/readConfig.js +40 -0
- package/dist/adapters/readConfig.js.map +1 -0
- package/dist/adapters/serviceIdFindings.d.ts +4 -0
- package/dist/adapters/serviceIdFindings.d.ts.map +1 -0
- package/dist/adapters/serviceIdFindings.js +65 -0
- package/dist/adapters/serviceIdFindings.js.map +1 -0
- package/dist/adapters/sharedErrorFindings.d.ts +4 -0
- package/dist/adapters/sharedErrorFindings.d.ts.map +1 -0
- package/dist/adapters/sharedErrorFindings.js +71 -0
- package/dist/adapters/sharedErrorFindings.js.map +1 -0
- package/dist/adapters/sharedErrorModules.d.ts +7 -0
- package/dist/adapters/sharedErrorModules.d.ts.map +1 -0
- package/dist/adapters/sharedErrorModules.js +66 -0
- package/dist/adapters/sharedErrorModules.js.map +1 -0
- package/dist/adapters/testProjects.d.ts.map +1 -1
- package/dist/adapters/testProjects.js +18 -2
- package/dist/adapters/testProjects.js.map +1 -1
- package/dist/appTestConfig.d.ts +1 -1
- package/dist/appTestConfig.d.ts.map +1 -1
- package/dist/appTestConfig.js.map +1 -1
- package/dist/biome/exceptionConfig.d.ts +0 -7
- package/dist/biome/exceptionConfig.d.ts.map +1 -1
- package/dist/biome/exceptionConfig.js +0 -36
- package/dist/biome/exceptionConfig.js.map +1 -1
- package/dist/biome/recognizeDiagnostics.d.ts.map +1 -1
- package/dist/biome/recognizeDiagnostics.js +2 -1
- package/dist/biome/recognizeDiagnostics.js.map +1 -1
- package/dist/biome/syntax.d.ts +0 -1
- package/dist/biome/syntax.d.ts.map +1 -1
- package/dist/biome/syntax.js +0 -9
- package/dist/biome/syntax.js.map +1 -1
- package/dist/biome/withoutEntryPointImports.d.ts +32 -2
- package/dist/biome/withoutEntryPointImports.d.ts.map +1 -1
- package/dist/biome/withoutEntryPointImports.js +12 -10
- package/dist/biome/withoutEntryPointImports.js.map +1 -1
- package/dist/cli/fixRule.js +1 -1
- package/dist/cli/fixRule.js.map +1 -1
- package/dist/config/globs.d.ts.map +1 -1
- package/dist/config/globs.js +1 -5
- package/dist/config/globs.js.map +1 -1
- package/dist/config/load.d.ts +2 -2
- package/dist/config/load.d.ts.map +1 -1
- package/dist/config/load.js +5 -36
- package/dist/config/load.js.map +1 -1
- package/dist/domEnvironment.config.js +1 -1
- package/dist/domEnvironment.config.js.map +1 -1
- package/dist/exceptions/biomeFindings.d.ts +1 -1
- package/dist/exceptions/biomeFindings.d.ts.map +1 -1
- package/dist/exceptions/biomeFindings.js +10 -6
- package/dist/exceptions/biomeFindings.js.map +1 -1
- package/dist/inventory/collect.js +2 -2
- package/dist/inventory/collect.js.map +1 -1
- package/dist/inventory/ignoreScope.d.ts +2 -2
- package/dist/inventory/ignoreScope.d.ts.map +1 -1
- package/dist/inventory/ignoreScope.js +2 -2
- package/dist/inventory/ignoreScope.js.map +1 -1
- package/dist/naming/packageLayout.d.ts +2 -1
- package/dist/naming/packageLayout.d.ts.map +1 -1
- package/dist/naming/packageLayout.js +4 -6
- package/dist/naming/packageLayout.js.map +1 -1
- package/dist/naming/testName.d.ts +1 -1
- package/dist/naming/testName.d.ts.map +1 -1
- package/dist/naming/testName.js +1 -1
- package/dist/naming/testName.js.map +1 -1
- package/dist/rules/biome.d.ts +1 -8
- package/dist/rules/biome.d.ts.map +1 -1
- package/dist/rules/biome.js +6 -15
- package/dist/rules/biome.js.map +1 -1
- package/dist/rules/builtIn.d.ts +2 -2
- package/dist/rules/builtIn.d.ts.map +1 -1
- package/dist/rules/builtIn.js +12 -0
- package/dist/rules/builtIn.js.map +1 -1
- package/dist/rules/effect/adapterImports.d.ts +2 -0
- package/dist/rules/effect/adapterImports.d.ts.map +1 -0
- package/dist/rules/effect/adapterImports.js +9 -0
- package/dist/rules/effect/adapterImports.js.map +1 -0
- package/dist/rules/effect/program.d.ts +1 -1
- package/dist/rules/effect/program.d.ts.map +1 -1
- package/dist/rules/effect/program.js +2 -2
- package/dist/rules/effect/program.js.map +1 -1
- package/dist/rules/effect/serviceIds.d.ts +2 -0
- package/dist/rules/effect/serviceIds.d.ts.map +1 -0
- package/dist/rules/effect/serviceIds.js +9 -0
- package/dist/rules/effect/serviceIds.js.map +1 -0
- package/dist/rules/effect/sharedErrorClasses.d.ts +2 -0
- package/dist/rules/effect/sharedErrorClasses.d.ts.map +1 -0
- package/dist/rules/effect/sharedErrorClasses.js +9 -0
- package/dist/rules/effect/sharedErrorClasses.js.map +1 -0
- package/dist/rules/files/folderNames.d.ts.map +1 -1
- package/dist/rules/files/folderNames.js +7 -7
- package/dist/rules/files/folderNames.js.map +1 -1
- package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
- package/dist/rules/files/namedAfterExport.js +6 -6
- package/dist/rules/files/namedAfterExport.js.map +1 -1
- package/dist/rules/files/otherNames.d.ts.map +1 -1
- package/dist/rules/files/otherNames.js +7 -7
- package/dist/rules/files/otherNames.js.map +1 -1
- package/dist/rules/files/packageImports.d.ts +2 -1
- package/dist/rules/files/packageImports.d.ts.map +1 -1
- package/dist/rules/files/packageImports.js +4 -3
- package/dist/rules/files/packageImports.js.map +1 -1
- package/dist/rules/files/stylesheetImporters.d.ts +2 -1
- package/dist/rules/files/stylesheetImporters.d.ts.map +1 -1
- package/dist/rules/files/stylesheetImporters.js +5 -4
- package/dist/rules/files/stylesheetImporters.js.map +1 -1
- package/dist/rules/manifestsApplication.d.ts.map +1 -1
- package/dist/rules/manifestsApplication.js +22 -22
- package/dist/rules/manifestsApplication.js.map +1 -1
- package/dist/rules/manifestsExportsShape.d.ts.map +1 -1
- package/dist/rules/manifestsExportsShape.js +32 -8
- package/dist/rules/manifestsExportsShape.js.map +1 -1
- package/dist/rules/manifestsSorted.d.ts.map +1 -1
- package/dist/rules/manifestsSorted.js +6 -5
- package/dist/rules/manifestsSorted.js.map +1 -1
- package/dist/rules/manifestsSourceFirst.d.ts.map +1 -1
- package/dist/rules/manifestsSourceFirst.js +6 -5
- package/dist/rules/manifestsSourceFirst.js.map +1 -1
- package/dist/rules/stories/adapterOnlyFakes.d.ts +2 -0
- package/dist/rules/stories/adapterOnlyFakes.d.ts.map +1 -0
- package/dist/rules/stories/adapterOnlyFakes.js +63 -0
- package/dist/rules/stories/adapterOnlyFakes.js.map +1 -0
- package/dist/rules/stories/fakeImplementation.d.ts +4 -0
- package/dist/rules/stories/fakeImplementation.d.ts.map +1 -0
- package/dist/rules/stories/fakeImplementation.js +22 -0
- package/dist/rules/stories/fakeImplementation.js.map +1 -0
- package/dist/rules/stories/fakeReplacements.d.ts +4 -0
- package/dist/rules/stories/fakeReplacements.d.ts.map +1 -0
- package/dist/rules/stories/fakeReplacements.js +71 -0
- package/dist/rules/stories/fakeReplacements.js.map +1 -0
- package/dist/rules/stories/importOrigin.js +2 -2
- package/dist/rules/stories/importOrigin.js.map +1 -1
- package/dist/rules/stories/importedChangeKeys.d.ts +2 -0
- package/dist/rules/stories/importedChangeKeys.d.ts.map +1 -0
- package/dist/rules/stories/importedChangeKeys.js +9 -0
- package/dist/rules/stories/importedChangeKeys.js.map +1 -0
- package/dist/rules/stories/pureNetImport.d.ts +4 -0
- package/dist/rules/stories/pureNetImport.d.ts.map +1 -0
- package/dist/rules/stories/pureNetImport.js +23 -0
- package/dist/rules/stories/pureNetImport.js.map +1 -0
- package/dist/rules/stories/queueReadouts.d.ts +2 -0
- package/dist/rules/stories/queueReadouts.d.ts.map +1 -0
- package/dist/rules/stories/queueReadouts.js +9 -0
- package/dist/rules/stories/queueReadouts.js.map +1 -0
- package/dist/rules/stories/unitTests.d.ts.map +1 -1
- package/dist/rules/stories/unitTests.js +4 -3
- package/dist/rules/stories/unitTests.js.map +1 -1
- package/dist/rules/suppressions/biome/weakenings.d.ts +1 -1
- package/dist/rules/suppressions/biome/weakenings.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeOverrides.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeOverrides.js +5 -5
- package/dist/rules/suppressions/biomeOverrides.js.map +1 -1
- package/dist/rules/suppressions/biomeRecommended.d.ts +1 -1
- package/dist/rules/suppressions/biomeRecommended.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeRecommended.js +12 -30
- package/dist/rules/suppressions/biomeRecommended.js.map +1 -1
- package/dist/rules/test-names/colocated.js +2 -2
- package/dist/rules/test-names/colocated.js.map +1 -1
- package/dist/rules/test-names/follow.js +4 -4
- package/dist/rules/test-names/follow.js.map +1 -1
- package/dist/testing/adapters/cli.d.ts +21 -0
- package/dist/testing/adapters/cli.d.ts.map +1 -0
- package/dist/testing/adapters/cli.js +85 -0
- package/dist/testing/adapters/cli.js.map +1 -0
- package/dist/testing/adapters/git.d.ts +14 -0
- package/dist/testing/adapters/git.d.ts.map +1 -0
- package/dist/testing/adapters/git.js +52 -0
- package/dist/testing/adapters/git.js.map +1 -0
- package/dist/testing/adapters/hookPath.d.ts +2 -0
- package/dist/testing/adapters/hookPath.d.ts.map +1 -0
- package/dist/testing/adapters/hookPath.js +6 -0
- package/dist/testing/adapters/hookPath.js.map +1 -0
- package/dist/testing/adapters/hookRepository.d.ts +25 -0
- package/dist/testing/adapters/hookRepository.d.ts.map +1 -0
- package/dist/testing/adapters/hookRepository.js +96 -0
- package/dist/testing/adapters/hookRepository.js.map +1 -0
- package/dist/testing/adapters/imports.d.ts +5 -0
- package/dist/testing/adapters/imports.d.ts.map +1 -0
- package/dist/testing/adapters/imports.js +29 -0
- package/dist/testing/adapters/imports.js.map +1 -0
- package/dist/testing/adapters/packageExports.d.ts +15 -0
- package/dist/testing/adapters/packageExports.d.ts.map +1 -0
- package/dist/testing/adapters/packageExports.js +29 -0
- package/dist/testing/adapters/packageExports.js.map +1 -0
- package/dist/testing/adapters/qualityTree.d.ts +4 -0
- package/dist/testing/adapters/qualityTree.d.ts.map +1 -0
- package/dist/testing/adapters/qualityTree.js +21 -0
- package/dist/testing/adapters/qualityTree.js.map +1 -0
- package/dist/testing/adapters/run.d.ts +4 -0
- package/dist/testing/adapters/run.d.ts.map +1 -0
- package/dist/testing/adapters/run.js +6 -0
- package/dist/testing/adapters/run.js.map +1 -0
- package/dist/testing/adapters/storySpecFiles.d.ts +7 -0
- package/dist/testing/adapters/storySpecFiles.d.ts.map +1 -0
- package/dist/testing/adapters/storySpecFiles.js +48 -0
- package/dist/testing/adapters/storySpecFiles.js.map +1 -0
- package/dist/testing/adapters/tree.d.ts +13 -0
- package/dist/testing/adapters/tree.d.ts.map +1 -0
- package/dist/testing/adapters/tree.js +42 -0
- package/dist/testing/adapters/tree.js.map +1 -0
- package/dist/testing/adapters/writePackageExports.d.ts +2 -0
- package/dist/testing/adapters/writePackageExports.d.ts.map +1 -0
- package/dist/testing/adapters/writePackageExports.js +9 -0
- package/dist/testing/adapters/writePackageExports.js.map +1 -0
- package/dist/testing/ruleStory.d.ts +28 -0
- package/dist/testing/ruleStory.d.ts.map +1 -0
- package/dist/testing/ruleStory.js +115 -0
- package/dist/testing/ruleStory.js.map +1 -0
- package/dist/unitIoGuard.config.js +1 -1
- package/dist/unitIoGuard.config.js.map +1 -1
- package/package.json +7 -2
- package/src/{rules/suppressions → adapters}/biome/configs.ts +2 -2
- package/src/adapters/biome/presetConfig.ts +34 -0
- package/src/adapters/biome/rootConfig.ts +19 -0
- package/src/adapters/biome/run.ts +1 -1
- package/src/adapters/biome/syntaxOf.ts +12 -0
- package/src/adapters/biome/withExceptionConfig.ts +45 -0
- package/src/adapters/changeKeyApi.ts +62 -0
- package/src/adapters/changeKeyFindings.ts +96 -0
- package/src/adapters/changeKeyLiterals.ts +60 -0
- package/src/adapters/ignore.ts +16 -0
- package/src/adapters/imports/fakeReferences.ts +115 -0
- package/src/adapters/imports/fakeTargets.ts +21 -0
- package/src/adapters/outsideImportFindings.ts +98 -0
- package/src/adapters/queueReadoutFindings.ts +37 -0
- package/src/adapters/queueTestingOrigin.ts +113 -0
- package/src/adapters/readConfig.ts +42 -0
- package/src/adapters/serviceIdFindings.ts +80 -0
- package/src/adapters/sharedErrorFindings.ts +84 -0
- package/src/adapters/sharedErrorModules.ts +81 -0
- package/src/adapters/testProjects.ts +18 -2
- package/src/appTestConfig.ts +1 -1
- package/src/biome/exceptionConfig.ts +0 -43
- package/src/biome/recognizeDiagnostics.ts +2 -1
- package/src/biome/syntax.ts +0 -10
- package/src/biome/withoutEntryPointImports.ts +15 -10
- package/src/cli/fixRule.ts +1 -1
- package/src/config/globs.ts +1 -6
- package/src/config/load.ts +6 -38
- package/src/domEnvironment.config.ts +1 -1
- package/src/exceptions/biomeFindings.ts +11 -10
- package/src/inventory/collect.ts +2 -2
- package/src/inventory/ignoreScope.ts +3 -3
- package/src/naming/packageLayout.ts +14 -7
- package/src/naming/testName.ts +1 -1
- package/src/rules/biome.ts +6 -23
- package/src/rules/builtIn.ts +12 -0
- package/src/rules/effect/adapterImports.ts +10 -0
- package/src/rules/effect/program.ts +2 -2
- package/src/rules/effect/serviceIds.ts +10 -0
- package/src/rules/effect/sharedErrorClasses.ts +10 -0
- package/src/rules/files/folderNames.ts +19 -18
- package/src/rules/files/namedAfterExport.ts +10 -9
- package/src/rules/files/otherNames.ts +17 -16
- package/src/rules/files/packageImports.ts +14 -4
- package/src/rules/files/stylesheetImporters.ts +13 -6
- package/src/rules/manifestsApplication.ts +44 -33
- package/src/rules/manifestsExportsShape.ts +45 -15
- package/src/rules/manifestsSorted.ts +16 -11
- package/src/rules/manifestsSourceFirst.ts +22 -17
- package/src/rules/stories/adapterOnlyFakes.ts +66 -0
- package/src/rules/stories/fakeImplementation.ts +23 -0
- package/src/rules/stories/fakeReplacements.ts +74 -0
- package/src/rules/stories/importOrigin.ts +2 -2
- package/src/rules/stories/importedChangeKeys.ts +10 -0
- package/src/rules/stories/pureNetImport.ts +29 -0
- package/src/rules/stories/queueReadouts.ts +9 -0
- package/src/rules/stories/unitTests.ts +6 -3
- package/src/rules/suppressions/biome/weakenings.ts +1 -1
- package/src/rules/suppressions/biomeOverrides.ts +17 -16
- package/src/rules/suppressions/biomeRecommended.ts +13 -32
- package/src/rules/test-names/colocated.ts +2 -2
- package/src/rules/test-names/follow.ts +4 -4
- package/src/testing/adapters/cli.ts +105 -0
- package/src/testing/adapters/git.ts +62 -0
- package/src/testing/adapters/hookPath.ts +6 -0
- package/src/testing/adapters/hookRepository.ts +134 -0
- package/src/testing/adapters/imports.ts +35 -0
- package/src/testing/adapters/packageExports.ts +37 -0
- package/src/testing/adapters/qualityTree.ts +26 -0
- package/src/testing/adapters/run.ts +7 -0
- package/src/testing/adapters/storySpecFiles.ts +54 -0
- package/src/testing/adapters/tree.ts +55 -0
- package/src/testing/adapters/writePackageExports.ts +9 -0
- package/src/testing/ruleStory.ts +139 -0
- package/src/unitIoGuard.config.ts +1 -1
- package/dist/biome/relocateConfig.d.ts.map +0 -1
- package/dist/biome/relocateConfig.js.map +0 -1
- package/dist/rules/suppressions/biome/configs.d.ts.map +0 -1
- package/dist/rules/suppressions/biome/configs.js.map +0 -1
- package/dist/rules/suppressions/biome/resolvePackage.d.ts.map +0 -1
- package/dist/rules/suppressions/biome/resolvePackage.js.map +0 -1
- /package/dist/{biome → adapters/biome}/relocateConfig.d.ts +0 -0
- /package/dist/{biome → adapters/biome}/relocateConfig.js +0 -0
- /package/dist/{rules/suppressions → adapters}/biome/resolvePackage.d.ts +0 -0
- /package/dist/{rules/suppressions → adapters}/biome/resolvePackage.js +0 -0
- /package/src/{biome → adapters/biome}/relocateConfig.ts +0 -0
- /package/src/{rules/suppressions → adapters}/biome/resolvePackage.ts +0 -0
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
2
3
|
import ts from "typescript";
|
|
3
4
|
import type { RuleInputs, SourceFile } from "#rule.ts";
|
|
4
5
|
import { parse } from "#rules/parse.ts";
|
|
@@ -41,13 +42,19 @@ function resolver(aliases: PackageImports, present: ReadonlySet<string>, fromSty
|
|
|
41
42
|
};
|
|
42
43
|
}
|
|
43
44
|
|
|
44
|
-
export
|
|
45
|
+
export const stylesheetImporters = Effect.fn("Files.stylesheetImporters")(function* (
|
|
45
46
|
inputs: Pick<RuleInputs, "files" | "readText" | "sources">,
|
|
46
|
-
):
|
|
47
|
+
): Effect.fn.Return<ReadonlyMap<string, readonly string[]>> {
|
|
47
48
|
const present = new Set(inputs.files);
|
|
48
|
-
const aliases =
|
|
49
|
-
const stylesheets =
|
|
50
|
-
inputs.files.filter((path) => STYLESHEET.test(path))
|
|
49
|
+
const aliases = yield* packageImports(inputs);
|
|
50
|
+
const stylesheets = yield* Effect.forEach(
|
|
51
|
+
inputs.files.filter((path) => STYLESHEET.test(path)),
|
|
52
|
+
(path) =>
|
|
53
|
+
Effect.map(
|
|
54
|
+
Effect.promise(() => inputs.readText(path)),
|
|
55
|
+
(text) => ({ path, text: text ?? "" }),
|
|
56
|
+
),
|
|
57
|
+
{ concurrency: "unbounded" },
|
|
51
58
|
);
|
|
52
59
|
const fromModule = resolver(aliases, present, false);
|
|
53
60
|
const fromStylesheet = resolver(aliases, present, true);
|
|
@@ -62,4 +69,4 @@ export async function stylesheetImporters(
|
|
|
62
69
|
}
|
|
63
70
|
}
|
|
64
71
|
return found;
|
|
65
|
-
}
|
|
72
|
+
});
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { dirname, posix, relative, resolve, sep } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
2
3
|
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
3
4
|
import { pnpmWorkspaceList } from "#imports/pnpmWorkspacePatterns.ts";
|
|
4
5
|
import { workspacePackages } from "#imports/workspace.ts";
|
|
@@ -24,30 +25,34 @@ function ancestors(root: string, directory: string): readonly string[] {
|
|
|
24
25
|
return parent === start ? [start] : [start, ...ancestors(root, relative(root, parent))];
|
|
25
26
|
}
|
|
26
27
|
|
|
27
|
-
|
|
28
|
+
const nearestWorkspace = Effect.fn("Manifests.nearestWorkspace")(function* (inputs: Pick<RuleInputs, "readText" | "root">, directory: string) {
|
|
28
29
|
for (const candidate of ancestors(inputs.root, directory)) {
|
|
29
30
|
const path = posix.join(relative(inputs.root, candidate).split(sep).join("/") || ".", "pnpm-workspace.yaml");
|
|
30
|
-
const text =
|
|
31
|
+
const text = yield* Effect.promise(() => inputs.readText(path));
|
|
31
32
|
if (text !== undefined) {
|
|
32
33
|
return { path, text };
|
|
33
34
|
}
|
|
34
35
|
}
|
|
35
36
|
return undefined;
|
|
36
|
-
}
|
|
37
|
+
});
|
|
37
38
|
|
|
38
|
-
|
|
39
|
-
|
|
39
|
+
const hoistFindings = Effect.fn("Manifests.hoistFindings")(function* (
|
|
40
|
+
inputs: Pick<RuleInputs, "readText" | "root">,
|
|
41
|
+
manifestPath: string,
|
|
42
|
+
directory: string,
|
|
43
|
+
): Effect.fn.Return<readonly Finding[]> {
|
|
44
|
+
const workspace = yield* nearestWorkspace(inputs, directory);
|
|
40
45
|
const target = workspace?.path ?? posix.join(directory, "pnpm-workspace.yaml");
|
|
41
46
|
const repair = `Add \`${HOIST_LINE}\` to ${target} so the pieces platform brings resolve by their own names.`;
|
|
42
47
|
if (workspace === undefined) {
|
|
43
48
|
return [{ file: manifestPath, message: `Depends on "${PLATFORM}" without a pnpm-workspace.yaml. ${repair}`, subject: HOIST_KEY }];
|
|
44
49
|
}
|
|
45
|
-
|
|
46
|
-
|
|
47
|
-
|
|
48
|
-
} catch (cause) {
|
|
50
|
+
const parsed = yield* Effect.try({ catch: (cause) => cause, try: () => pnpmWorkspaceList(workspace.text, HOIST_KEY) }).pipe(Effect.result);
|
|
51
|
+
if (parsed._tag === "Failure") {
|
|
52
|
+
const cause = parsed.failure;
|
|
49
53
|
return [{ file: workspace.path, message: `${cause instanceof Error ? cause.message : String(cause)}. Write ${HOIST_LINE}.`, subject: HOIST_KEY }];
|
|
50
54
|
}
|
|
55
|
+
const patterns = parsed.success;
|
|
51
56
|
const included = patterns.some((pattern) => !pattern.startsWith("!") && hoists(pattern));
|
|
52
57
|
const excluded = patterns.some((pattern) => pattern.startsWith("!") && hoists(pattern.slice(1)));
|
|
53
58
|
if (included && !excluded) {
|
|
@@ -56,16 +61,18 @@ async function hoistFindings(inputs: Pick<RuleInputs, "readText" | "root">, mani
|
|
|
56
61
|
return [
|
|
57
62
|
{ file: manifestPath, message: `Depends on "${PLATFORM}", but ${workspace.path} does not hoist ${HOISTED}. ${repair}`, subject: HOIST_KEY },
|
|
58
63
|
];
|
|
59
|
-
}
|
|
64
|
+
});
|
|
60
65
|
|
|
61
|
-
|
|
66
|
+
const duplicateFindings = Effect.fn("Manifests.duplicateFindings")(function* (
|
|
62
67
|
inputs: Pick<RuleInputs, "readText">,
|
|
63
68
|
manifestPath: string,
|
|
64
69
|
directory: string,
|
|
65
70
|
manifest: unknown,
|
|
66
71
|
workspace: ReadonlyMap<string, string>,
|
|
67
|
-
):
|
|
68
|
-
const entryPoints = (
|
|
72
|
+
): Effect.fn.Return<readonly Finding[]> {
|
|
73
|
+
const entryPoints = (yield* Effect.promise(() => entryPointsOf(inputs, directory, manifest, workspace))).filter(
|
|
74
|
+
(entry) => entry.declared !== undefined,
|
|
75
|
+
);
|
|
69
76
|
return DEPENDENCY_FIELDS.flatMap((field) =>
|
|
70
77
|
dependencyNames(manifest, field).flatMap((name) => {
|
|
71
78
|
const entry = entryPoints.find((candidate) => candidate.provides.has(name));
|
|
@@ -80,28 +87,32 @@ async function duplicateFindings(
|
|
|
80
87
|
];
|
|
81
88
|
}),
|
|
82
89
|
);
|
|
83
|
-
}
|
|
90
|
+
});
|
|
84
91
|
|
|
85
92
|
export const manifestsApplication = defineRule({
|
|
86
|
-
check:
|
|
87
|
-
|
|
88
|
-
|
|
89
|
-
|
|
90
|
-
|
|
91
|
-
|
|
92
|
-
|
|
93
|
-
|
|
94
|
-
|
|
95
|
-
|
|
96
|
-
|
|
97
|
-
|
|
98
|
-
|
|
99
|
-
|
|
100
|
-
|
|
101
|
-
|
|
102
|
-
|
|
103
|
-
|
|
104
|
-
|
|
93
|
+
check: (inputs) =>
|
|
94
|
+
Effect.gen(function* () {
|
|
95
|
+
const packages = yield* Effect.promise(() => workspacePackages(inputs));
|
|
96
|
+
const workspace = new Map(packages.map((owner) => [owner.name, owner.directory]));
|
|
97
|
+
const directories = [".", ...packages.map((owner) => owner.directory)];
|
|
98
|
+
const findings = yield* Effect.forEach(
|
|
99
|
+
directories,
|
|
100
|
+
(directory) =>
|
|
101
|
+
Effect.gen(function* () {
|
|
102
|
+
const manifestPath = posix.join(directory, "package.json");
|
|
103
|
+
const manifest = yield* Effect.promise(() => readPackageManifest(inputs.readText, manifestPath));
|
|
104
|
+
if (!isApplication(manifest)) {
|
|
105
|
+
return [];
|
|
106
|
+
}
|
|
107
|
+
return [
|
|
108
|
+
...(yield* hoistFindings(inputs, manifestPath, directory)),
|
|
109
|
+
...(yield* duplicateFindings(inputs, manifestPath, directory, manifest, workspace)),
|
|
110
|
+
];
|
|
111
|
+
}),
|
|
112
|
+
{ concurrency: "unbounded" },
|
|
113
|
+
);
|
|
114
|
+
return findings.flat();
|
|
115
|
+
}),
|
|
105
116
|
description: `An application, a package that depends on ${PLATFORM}, hoists ${HOISTED} in its nearest pnpm-workspace.yaml and lists no package beside the entry point that already brings it.`,
|
|
106
117
|
id: "manifests/application",
|
|
107
118
|
});
|
|
@@ -1,4 +1,5 @@
|
|
|
1
1
|
import { posix } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
2
3
|
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
3
4
|
import { workspacePackages } from "#imports/workspace.ts";
|
|
4
5
|
import { defineRule, type Finding } from "#rule.ts";
|
|
@@ -64,23 +65,52 @@ function findingsIn(file: string, exports: unknown): readonly Finding[] {
|
|
|
64
65
|
];
|
|
65
66
|
}
|
|
66
67
|
|
|
68
|
+
function importFindings(file: string, imports: Readonly<Record<string, unknown>> = {}): readonly Finding[] {
|
|
69
|
+
return Object.entries(imports).flatMap(([key, value]) => {
|
|
70
|
+
if (key === "#*.ts" && value !== "./src/*.ts" && !standardPattern(PATTERN, value)) {
|
|
71
|
+
return [
|
|
72
|
+
{
|
|
73
|
+
file,
|
|
74
|
+
message:
|
|
75
|
+
'Import "#*.ts" must preserve the path from the source root. Map it to "./src/*.ts", or to source "./src/*.ts", types "./dist/*.d.ts" and default "./dist/*.js". Include subfolders in import specifiers, for example "#server/module.ts".',
|
|
76
|
+
subject: key,
|
|
77
|
+
},
|
|
78
|
+
];
|
|
79
|
+
}
|
|
80
|
+
if (key === "#test/*" && value !== "./src/test-support/*") {
|
|
81
|
+
return [
|
|
82
|
+
{
|
|
83
|
+
file,
|
|
84
|
+
message: 'Import "#test/*" must map to "./src/test-support/*". Keep test helpers under the source root’s test-support folder.',
|
|
85
|
+
subject: key,
|
|
86
|
+
},
|
|
87
|
+
];
|
|
88
|
+
}
|
|
89
|
+
return [];
|
|
90
|
+
});
|
|
91
|
+
}
|
|
92
|
+
|
|
67
93
|
export const manifestsExportsShape = defineRule({
|
|
68
|
-
check:
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
|
|
80
|
-
|
|
81
|
-
|
|
94
|
+
check: (inputs) =>
|
|
95
|
+
Effect.gen(function* () {
|
|
96
|
+
const packages = yield* Effect.promise(() => workspacePackages(inputs));
|
|
97
|
+
const files = ["package.json", ...packages.map((owner) => posix.join(owner.directory, "package.json"))];
|
|
98
|
+
const findings = yield* Effect.forEach(
|
|
99
|
+
files,
|
|
100
|
+
(file) =>
|
|
101
|
+
Effect.gen(function* () {
|
|
102
|
+
const manifest = yield* Effect.promise(() => readPackageManifest(inputs.readText, file));
|
|
103
|
+
if (file === "package.json" && manifest === undefined) {
|
|
104
|
+
return [];
|
|
105
|
+
}
|
|
106
|
+
return [...findingsIn(file, manifest?.exports), ...importFindings(file, manifest?.imports)];
|
|
107
|
+
}),
|
|
108
|
+
{ concurrency: "unbounded" },
|
|
109
|
+
);
|
|
110
|
+
return findings.flat();
|
|
111
|
+
}),
|
|
82
112
|
description:
|
|
83
|
-
"
|
|
113
|
+
"Packages export modules through one file-preserving wildcard without null blocks; declared #*.ts and #test/* imports preserve the source and test-support roots.",
|
|
84
114
|
id: "manifests/exports-shape",
|
|
85
115
|
registrable: false,
|
|
86
116
|
});
|
|
@@ -1,19 +1,24 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
1
2
|
import { manifestFiles, manifestText } from "#adapters/manifestInventory.ts";
|
|
2
3
|
import { sortingOf } from "#manifests/sorted.ts";
|
|
3
4
|
import { defineRule } from "#rule.ts";
|
|
4
5
|
|
|
5
6
|
export const manifestsSorted = defineRule({
|
|
6
|
-
check:
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
|
|
16
|
-
|
|
7
|
+
check: (inputs) =>
|
|
8
|
+
Effect.gen(function* () {
|
|
9
|
+
const findings = yield* Effect.forEach(
|
|
10
|
+
manifestFiles(inputs),
|
|
11
|
+
(file) =>
|
|
12
|
+
Effect.gen(function* () {
|
|
13
|
+
const text = yield* Effect.promise(() => manifestText(inputs.readText, file));
|
|
14
|
+
return text === undefined || sortingOf(text)._tag === "Sorted"
|
|
15
|
+
? []
|
|
16
|
+
: [{ file, message: "Keys are not in sort-package-json order. Run `quality fix`." }];
|
|
17
|
+
}),
|
|
18
|
+
{ concurrency: "unbounded" },
|
|
19
|
+
);
|
|
20
|
+
return findings.flat();
|
|
21
|
+
}),
|
|
17
22
|
description: "Every package.json in the repository keeps its keys in sort-package-json order. `quality fix` sorts them.",
|
|
18
23
|
id: "manifests/sorted",
|
|
19
24
|
registrable: false,
|
|
@@ -1,3 +1,4 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
1
2
|
import { manifestEntry, manifestFiles } from "#adapters/manifestInventory.ts";
|
|
2
3
|
import { defineRule, type Finding } from "#rule.ts";
|
|
3
4
|
import { itemsOf, type Json, member, parseJsonc } from "#rules/suppressions/biome/json.ts";
|
|
@@ -24,23 +25,27 @@ function misplaced(path: string, field: string, value: unknown, node: Json | und
|
|
|
24
25
|
}
|
|
25
26
|
|
|
26
27
|
export const manifestsSourceFirst = defineRule({
|
|
27
|
-
check:
|
|
28
|
-
|
|
29
|
-
|
|
30
|
-
|
|
31
|
-
|
|
32
|
-
|
|
33
|
-
|
|
34
|
-
|
|
35
|
-
|
|
36
|
-
|
|
37
|
-
|
|
38
|
-
|
|
39
|
-
|
|
40
|
-
|
|
41
|
-
|
|
42
|
-
|
|
43
|
-
|
|
28
|
+
check: (inputs) =>
|
|
29
|
+
Effect.gen(function* () {
|
|
30
|
+
const findings = yield* Effect.forEach(
|
|
31
|
+
manifestFiles(inputs),
|
|
32
|
+
(path) =>
|
|
33
|
+
Effect.gen(function* () {
|
|
34
|
+
const entry = yield* Effect.promise(() => manifestEntry(inputs.readText, path));
|
|
35
|
+
if (entry === undefined) {
|
|
36
|
+
return [];
|
|
37
|
+
}
|
|
38
|
+
const { manifest, text } = entry;
|
|
39
|
+
const parsed = parseJsonc(path, text);
|
|
40
|
+
const location = parsed._tag === "Parsed" ? parsed.json : undefined;
|
|
41
|
+
return ["exports", "imports"].flatMap((field) =>
|
|
42
|
+
misplaced(path, field, field === "exports" ? manifest.exports : manifest.imports, member(location, field)),
|
|
43
|
+
);
|
|
44
|
+
}),
|
|
45
|
+
{ concurrency: "unbounded" },
|
|
46
|
+
);
|
|
47
|
+
return findings.flat();
|
|
48
|
+
}),
|
|
44
49
|
description:
|
|
45
50
|
'Every package.json condition block that names the "source" condition lists it first in exports and imports, so TypeScript reads the sources whether or not built output exists.',
|
|
46
51
|
id: "manifests/source-first",
|
|
@@ -0,0 +1,66 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import { fakeApi, fakeReferences } from "#adapters/imports/fakeReferences.ts";
|
|
4
|
+
import { type FakeModule, fakeTargets } from "#adapters/imports/fakeTargets.ts";
|
|
5
|
+
import { importGraph } from "#imports/graph.ts";
|
|
6
|
+
import { isTestCode } from "#naming/testName.ts";
|
|
7
|
+
import { defineRule, type Finding } from "#rule.ts";
|
|
8
|
+
import { fakeReplacements } from "./fakeReplacements.ts";
|
|
9
|
+
import { storyProgram } from "./program.ts";
|
|
10
|
+
|
|
11
|
+
function internal(path: string): boolean {
|
|
12
|
+
return !path.split("/").includes("adapters");
|
|
13
|
+
}
|
|
14
|
+
|
|
15
|
+
function message(target: string): string {
|
|
16
|
+
return `Replaces owned code in ${target} outside adapters/. Exercise the real module or service; fake only adapters/ or outside libraries and platform globals. Delete a test whose failure can only be shown by faking internals.`;
|
|
17
|
+
}
|
|
18
|
+
|
|
19
|
+
export const adapterOnlyFakes = defineRule({
|
|
20
|
+
check: Effect.fn("Stories.check")(function* (inputs) {
|
|
21
|
+
const graph = yield* importGraph(inputs);
|
|
22
|
+
const program = storyProgram(inputs, graph);
|
|
23
|
+
const references = fakeReferences(program, inputs.root);
|
|
24
|
+
const modules: FakeModule[] = [];
|
|
25
|
+
const findings: Finding[] = [];
|
|
26
|
+
for (const file of inputs.sources.filter((candidate) => isTestCode(candidate.path))) {
|
|
27
|
+
const source = references.source(file.path);
|
|
28
|
+
if (source === undefined) {
|
|
29
|
+
continue;
|
|
30
|
+
}
|
|
31
|
+
const syntax = source;
|
|
32
|
+
function line(node: ts.Node): number {
|
|
33
|
+
return syntax.getLineAndCharacterOfPosition(node.getStart(syntax)).line + 1;
|
|
34
|
+
}
|
|
35
|
+
function visit(node: ts.Node): void {
|
|
36
|
+
if (ts.isCallExpression(node) && ["vi.mock", "vi.doMock"].includes(fakeApi(references.reference(node.expression)) ?? "")) {
|
|
37
|
+
const argument = node.arguments[0];
|
|
38
|
+
const name =
|
|
39
|
+
argument !== undefined && ts.isCallExpression(argument) && argument.expression.kind === ts.SyntaxKind.ImportKeyword
|
|
40
|
+
? argument.arguments[0]
|
|
41
|
+
: argument;
|
|
42
|
+
if (name !== undefined && ts.isStringLiteralLike(name)) {
|
|
43
|
+
modules.push({ file: file.path, line: line(node), specifier: name.text });
|
|
44
|
+
}
|
|
45
|
+
}
|
|
46
|
+
ts.forEachChild(node, visit);
|
|
47
|
+
}
|
|
48
|
+
visit(source);
|
|
49
|
+
for (const node of fakeReplacements(source, references)) {
|
|
50
|
+
const target = references.owner(node, true);
|
|
51
|
+
if (target !== undefined && internal(target)) {
|
|
52
|
+
findings.push({ file: file.path, line: line(node), message: message(target) });
|
|
53
|
+
}
|
|
54
|
+
}
|
|
55
|
+
}
|
|
56
|
+
return [
|
|
57
|
+
...findings,
|
|
58
|
+
...fakeTargets(inputs, modules)
|
|
59
|
+
.filter(({ target }) => internal(target))
|
|
60
|
+
.map(({ file, line, target }) => ({ file, line, message: message(target) })),
|
|
61
|
+
];
|
|
62
|
+
}),
|
|
63
|
+
description: "Tests fake only adapters, outside libraries and platform globals; owned modules and services run for real.",
|
|
64
|
+
id: "tests/adapter-only-fakes",
|
|
65
|
+
registrable: false,
|
|
66
|
+
});
|
|
@@ -0,0 +1,23 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import type { fakeReferences } from "#adapters/imports/fakeReferences.ts";
|
|
3
|
+
import { memberName, unwrapped } from "./syntax.ts";
|
|
4
|
+
|
|
5
|
+
export function fakeImplementation(expression: ts.Expression, references: ReturnType<typeof fakeReferences>, seen = new Set<ts.Node>()): boolean {
|
|
6
|
+
const node = unwrapped(expression);
|
|
7
|
+
if (seen.has(node) || references.owner(node) !== undefined) {
|
|
8
|
+
return false;
|
|
9
|
+
}
|
|
10
|
+
seen.add(node);
|
|
11
|
+
if (ts.isObjectLiteralExpression(node) || ts.isArrowFunction(node) || ts.isFunctionExpression(node)) {
|
|
12
|
+
return true;
|
|
13
|
+
}
|
|
14
|
+
if (ts.isCallExpression(node)) {
|
|
15
|
+
const name = memberName(node.expression);
|
|
16
|
+
if (name === "of" || name === "succeed" || name === "sync" || name === "map" || name === "gen") {
|
|
17
|
+
return node.arguments.some((argument) => fakeImplementation(argument, references, seen));
|
|
18
|
+
}
|
|
19
|
+
return name === "fail" || name === "die" || name === "fn";
|
|
20
|
+
}
|
|
21
|
+
const value = references.initializer(node);
|
|
22
|
+
return value !== undefined && fakeImplementation(value, references, seen);
|
|
23
|
+
}
|
|
@@ -0,0 +1,74 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { fakeApi, type fakeReferences } from "#adapters/imports/fakeReferences.ts";
|
|
3
|
+
import { fakeImplementation } from "./fakeImplementation.ts";
|
|
4
|
+
import { memberName, unwrapped } from "./syntax.ts";
|
|
5
|
+
|
|
6
|
+
const REPLACEMENTS = new Set([
|
|
7
|
+
"mockImplementation",
|
|
8
|
+
"mockImplementationOnce",
|
|
9
|
+
"mockReturnValue",
|
|
10
|
+
"mockReturnValueOnce",
|
|
11
|
+
"mockResolvedValue",
|
|
12
|
+
"mockResolvedValueOnce",
|
|
13
|
+
"mockRejectedValue",
|
|
14
|
+
"mockRejectedValueOnce",
|
|
15
|
+
"mockReturnThis",
|
|
16
|
+
"withImplementation",
|
|
17
|
+
]);
|
|
18
|
+
|
|
19
|
+
const SERVICES = new Set(["Layer.succeed", "Layer.sync", "Layer.effect", "Layer.mock", "Effect.provideService", "Effect.provideServiceEffect"]);
|
|
20
|
+
|
|
21
|
+
export function fakeReplacements(source: ts.SourceFile, references: ReturnType<typeof fakeReferences>): readonly ts.Expression[] {
|
|
22
|
+
const replaced: ts.Expression[] = [];
|
|
23
|
+
function spy(expression: ts.Expression, seen = new Set<ts.Node>()): ts.CallExpression | undefined {
|
|
24
|
+
const node = unwrapped(expression);
|
|
25
|
+
if (seen.has(node)) {
|
|
26
|
+
return undefined;
|
|
27
|
+
}
|
|
28
|
+
seen.add(node);
|
|
29
|
+
if (ts.isCallExpression(node)) {
|
|
30
|
+
if (fakeApi(references.reference(node.expression)) === "vi.spyOn") {
|
|
31
|
+
return node;
|
|
32
|
+
}
|
|
33
|
+
return ts.isPropertyAccessExpression(node.expression) ? spy(node.expression.expression, seen) : undefined;
|
|
34
|
+
}
|
|
35
|
+
if (ts.isIdentifier(node)) {
|
|
36
|
+
const declaration = references.initializer(node);
|
|
37
|
+
return declaration === undefined ? undefined : spy(declaration, seen);
|
|
38
|
+
}
|
|
39
|
+
return undefined;
|
|
40
|
+
}
|
|
41
|
+
function service(node: ts.CallExpression): ts.Expression | undefined {
|
|
42
|
+
const curried = ts.isCallExpression(node.expression) ? node.expression : undefined;
|
|
43
|
+
const construction = curried ?? node;
|
|
44
|
+
const api = fakeApi(references.reference(construction.expression));
|
|
45
|
+
if (api === undefined || !SERVICES.has(api)) {
|
|
46
|
+
return undefined;
|
|
47
|
+
}
|
|
48
|
+
const index = api.startsWith("Effect.") && construction.arguments.length === 3 ? 1 : 0;
|
|
49
|
+
const argument = construction.arguments[index];
|
|
50
|
+
const value = curried === undefined ? node.arguments[index + 1] : node.arguments[0];
|
|
51
|
+
return argument !== undefined && value !== undefined && references.concreteService(argument) && fakeImplementation(value, references)
|
|
52
|
+
? argument
|
|
53
|
+
: undefined;
|
|
54
|
+
}
|
|
55
|
+
function replacementSpy(node: ts.CallExpression): ts.Expression | undefined {
|
|
56
|
+
return REPLACEMENTS.has(memberName(node.expression) ?? "")
|
|
57
|
+
&& (ts.isPropertyAccessExpression(node.expression) || ts.isElementAccessExpression(node.expression))
|
|
58
|
+
? spy(node.expression.expression)?.arguments[0]
|
|
59
|
+
: undefined;
|
|
60
|
+
}
|
|
61
|
+
function visit(node: ts.Node): void {
|
|
62
|
+
if (ts.isCallExpression(node)) {
|
|
63
|
+
for (const target of [service(node), replacementSpy(node)]) {
|
|
64
|
+
if (target !== undefined) {
|
|
65
|
+
replaced.push(target);
|
|
66
|
+
}
|
|
67
|
+
}
|
|
68
|
+
}
|
|
69
|
+
ts.forEachChild(node, visit);
|
|
70
|
+
}
|
|
71
|
+
|
|
72
|
+
visit(source);
|
|
73
|
+
return replaced;
|
|
74
|
+
}
|
|
@@ -17,10 +17,10 @@ function moduleOrigin(from: string | undefined) {
|
|
|
17
17
|
}
|
|
18
18
|
|
|
19
19
|
export function importOrigin(from: string | undefined, name?: string) {
|
|
20
|
-
if (from === "@shivaedev/test/makeEffectIt.ts" && name === "makeEffectIt") {
|
|
20
|
+
if (from === "@shivaedev/test/adapters/makeEffectIt.ts" && name === "makeEffectIt") {
|
|
21
21
|
return "effectFactory";
|
|
22
22
|
}
|
|
23
|
-
if (from === "@shivaedev/test/it.ts" && name === "it") {
|
|
23
|
+
if (from === "@shivaedev/test/adapters/it.ts" && name === "it") {
|
|
24
24
|
return "plain";
|
|
25
25
|
}
|
|
26
26
|
const namespace = moduleOrigin(from);
|
|
@@ -0,0 +1,10 @@
|
|
|
1
|
+
import { changeKeyFindings } from "#adapters/changeKeyFindings.ts";
|
|
2
|
+
import { defineRule } from "#rule.ts";
|
|
3
|
+
|
|
4
|
+
export const importedChangeKeys = defineRule({
|
|
5
|
+
check: changeKeyFindings,
|
|
6
|
+
description:
|
|
7
|
+
"Change collection and bucket names in Reactivity invalidation and mutation, SQL invalidateOnCommit and changes key encoders come from their owner's imported declaration. Replace literal array keys, record keys and typed key collection/field names; IDs and bucket values remain application data.",
|
|
8
|
+
id: "boundaries/imported-change-keys",
|
|
9
|
+
registrable: false,
|
|
10
|
+
});
|
|
@@ -0,0 +1,29 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import type { ImportEdge } from "#imports/graph.ts";
|
|
3
|
+
import type { SourceFile } from "#rule.ts";
|
|
4
|
+
import { parse } from "#rules/parse.ts";
|
|
5
|
+
|
|
6
|
+
export function pureNetImport(edge: ImportEdge, source: SourceFile | undefined): boolean {
|
|
7
|
+
if (edge.specifier !== "node:net" || source === undefined) {
|
|
8
|
+
return false;
|
|
9
|
+
}
|
|
10
|
+
const syntax = parse(source);
|
|
11
|
+
return (
|
|
12
|
+
syntax?.statements.some((statement) => {
|
|
13
|
+
if (!(ts.isImportDeclaration(statement) && ts.isStringLiteral(statement.moduleSpecifier)) || statement.moduleSpecifier.text !== "node:net") {
|
|
14
|
+
return false;
|
|
15
|
+
}
|
|
16
|
+
if (syntax.getLineAndCharacterOfPosition(statement.moduleSpecifier.getStart(syntax)).line + 1 !== edge.line) {
|
|
17
|
+
return false;
|
|
18
|
+
}
|
|
19
|
+
const clause = statement.importClause;
|
|
20
|
+
const bindings = clause?.namedBindings;
|
|
21
|
+
return (
|
|
22
|
+
clause?.name === undefined
|
|
23
|
+
&& bindings !== undefined
|
|
24
|
+
&& ts.isNamedImports(bindings)
|
|
25
|
+
&& bindings.elements.every((binding) => binding.isTypeOnly || ["BlockList", "isIP"].includes((binding.propertyName ?? binding.name).text))
|
|
26
|
+
);
|
|
27
|
+
}) ?? false
|
|
28
|
+
);
|
|
29
|
+
}
|
|
@@ -0,0 +1,9 @@
|
|
|
1
|
+
import { queueReadoutFindings } from "#adapters/queueReadoutFindings.ts";
|
|
2
|
+
import { defineRule } from "#rule.ts";
|
|
3
|
+
|
|
4
|
+
export const queueReadouts = defineRule({
|
|
5
|
+
check: queueReadoutFindings,
|
|
6
|
+
description: "Application tests assert job results, never jobs-testing queue storage; only the jobs package tests its readouts.",
|
|
7
|
+
id: "tests/queue-readouts",
|
|
8
|
+
registrable: false,
|
|
9
|
+
});
|
|
@@ -6,17 +6,20 @@ import type { Finding, SourceFile } from "#rule.ts";
|
|
|
6
6
|
import { parse } from "#rules/parse.ts";
|
|
7
7
|
import { usesDom } from "#rules/test-names/usesDom.ts";
|
|
8
8
|
import { engineOf } from "./engineOf.ts";
|
|
9
|
+
import { pureNetImport } from "./pureNetImport.ts";
|
|
9
10
|
import { type Stand, standIns } from "./unitSyntax.ts";
|
|
10
11
|
|
|
11
12
|
const RELATIVE = /^[./#]/u;
|
|
12
13
|
|
|
13
14
|
const KIT = "Drive the engine through the package's story kit in a story, or, if the code under test is pure,";
|
|
14
15
|
|
|
15
|
-
function runtimeEdges(graph: ImportGraph): ReadonlyMap<string, readonly ImportEdge[]> {
|
|
16
|
+
function runtimeEdges(graph: ImportGraph, sources: ReadonlyMap<string, SourceFile>): ReadonlyMap<string, readonly ImportEdge[]> {
|
|
16
17
|
const packages = graph.unresolved
|
|
17
18
|
.filter((request) => request.missing === undefined && !RELATIVE.test(request.specifier))
|
|
18
19
|
.map((request) => ({ ...request, to: { kind: "external" as const, package: packageNameOf(request.specifier), specifier: request.specifier } }));
|
|
19
|
-
return outgoing(
|
|
20
|
+
return outgoing(
|
|
21
|
+
[...graph.edges, ...packages].filter((edge) => edge.kind === "import" && !edge.type && !pureNetImport(edge, sources.get(edge.from))),
|
|
22
|
+
);
|
|
20
23
|
}
|
|
21
24
|
|
|
22
25
|
function repair(path: readonly string[]): string {
|
|
@@ -73,8 +76,8 @@ function syntaxFindings(file: string, module: string, trail: Trail, source: Sour
|
|
|
73
76
|
}
|
|
74
77
|
|
|
75
78
|
export function unitTests(graph: ImportGraph, sources: readonly SourceFile[]): (file: string) => readonly Finding[] {
|
|
76
|
-
const edgesFrom = runtimeEdges(graph);
|
|
77
79
|
const byPath = new Map(sources.map((source) => [source.path, source]));
|
|
80
|
+
const edgesFrom = runtimeEdges(graph, byPath);
|
|
78
81
|
return (file) => {
|
|
79
82
|
const walked = walkFrom(file, edgesFrom, engineOf);
|
|
80
83
|
const checked = [...walked.visited].filter(([module]) => module === file || isTestSupport(module));
|
|
@@ -1,8 +1,8 @@
|
|
|
1
1
|
import { Effect, Schema } from "effect";
|
|
2
|
+
import { biomeConfigs, type Chain } from "#adapters/biome/configs.ts";
|
|
2
3
|
import { biomeExceptionHint, missingBiomeFiles } from "#exceptions/biomeFindings.ts";
|
|
3
4
|
import { defineRule, type Finding } from "#rule.ts";
|
|
4
5
|
import { ConsumerDeclaration } from "#rules/suppressions/biome/ConsumerDeclaration.ts";
|
|
5
|
-
import { biomeConfigs, type Chain } from "#rules/suppressions/biome/configs.ts";
|
|
6
6
|
import { matches, type Scoped, scoped, scopeText } from "#rules/suppressions/biome/declarations.ts";
|
|
7
7
|
import { type Weakening, weakeningsOf } from "#rules/suppressions/biome/weakenings.ts";
|
|
8
8
|
|
|
@@ -65,21 +65,22 @@ function staleOrRepeated(file: string, weakenings: readonly Weakening[], shipped
|
|
|
65
65
|
}
|
|
66
66
|
|
|
67
67
|
export const biomeOverrides = defineRule({
|
|
68
|
-
check:
|
|
69
|
-
|
|
70
|
-
|
|
71
|
-
|
|
72
|
-
|
|
73
|
-
|
|
74
|
-
|
|
75
|
-
|
|
76
|
-
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
|
|
80
|
-
|
|
81
|
-
|
|
82
|
-
|
|
68
|
+
check: (inputs) =>
|
|
69
|
+
Effect.gen(function* () {
|
|
70
|
+
const { chains, problems, root } = yield* Effect.promise(() => biomeConfigs(inputs));
|
|
71
|
+
const { declared } = inputs.options;
|
|
72
|
+
const weakenings = chains.flatMap(weakeningsOf);
|
|
73
|
+
const shipped = chains.flatMap(shippedBy);
|
|
74
|
+
function covered(weakening: Weakening): boolean {
|
|
75
|
+
return [...declared, ...shipped].some((declaration) => matches(declaration, weakening));
|
|
76
|
+
}
|
|
77
|
+
return [
|
|
78
|
+
...problems,
|
|
79
|
+
...(yield* missingBiomeFiles(inputs)),
|
|
80
|
+
...weakenings.filter((weakening) => !covered(weakening)).map((weakening) => undeclared(weakening, inputs.configFile ?? "quality.config.ts")),
|
|
81
|
+
...declared.flatMap(staleOrRepeated(root, weakenings, shipped)),
|
|
82
|
+
];
|
|
83
|
+
}),
|
|
83
84
|
description:
|
|
84
85
|
"A Biome setting that turns a check off or down, or keeps files out of it, hides findings for every file it covers. Repair the code and remove the weakening setting.",
|
|
85
86
|
id: "suppressions/biome-overrides",
|