@shivaedev/quality 0.56.0 → 0.57.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +34 -0
- package/README.md +63 -4
- package/biome/plugins/effect-test-bodies.grit +1 -1
- package/dist/{rules/suppressions → adapters}/biome/configs.d.ts +2 -2
- package/dist/adapters/biome/configs.d.ts.map +1 -0
- package/dist/{rules/suppressions → adapters}/biome/configs.js +2 -2
- package/dist/adapters/biome/configs.js.map +1 -0
- package/dist/adapters/biome/presetConfig.d.ts +21 -0
- package/dist/adapters/biome/presetConfig.d.ts.map +1 -0
- package/dist/adapters/biome/presetConfig.js +32 -0
- package/dist/adapters/biome/presetConfig.js.map +1 -0
- package/dist/adapters/biome/relocateConfig.d.ts.map +1 -0
- package/dist/adapters/biome/relocateConfig.js.map +1 -0
- package/dist/adapters/biome/resolvePackage.d.ts.map +1 -0
- package/dist/adapters/biome/resolvePackage.js.map +1 -0
- package/dist/adapters/biome/rootConfig.d.ts +9 -0
- package/dist/adapters/biome/rootConfig.d.ts.map +1 -0
- package/dist/adapters/biome/rootConfig.js +11 -0
- package/dist/adapters/biome/rootConfig.js.map +1 -0
- package/dist/adapters/biome/run.js +1 -1
- package/dist/adapters/biome/run.js.map +1 -1
- package/dist/adapters/biome/syntaxOf.d.ts +3 -0
- package/dist/adapters/biome/syntaxOf.d.ts.map +1 -0
- package/dist/adapters/biome/syntaxOf.js +11 -0
- package/dist/adapters/biome/syntaxOf.js.map +1 -0
- package/dist/adapters/biome/withExceptionConfig.d.ts +8 -0
- package/dist/adapters/biome/withExceptionConfig.d.ts.map +1 -0
- package/dist/adapters/biome/withExceptionConfig.js +38 -0
- package/dist/adapters/biome/withExceptionConfig.js.map +1 -0
- package/dist/adapters/changeKeyApi.d.ts +4 -0
- package/dist/adapters/changeKeyApi.d.ts.map +1 -0
- package/dist/adapters/changeKeyApi.js +58 -0
- package/dist/adapters/changeKeyApi.js.map +1 -0
- package/dist/adapters/changeKeyFindings.d.ts +4 -0
- package/dist/adapters/changeKeyFindings.d.ts.map +1 -0
- package/dist/adapters/changeKeyFindings.js +87 -0
- package/dist/adapters/changeKeyFindings.js.map +1 -0
- package/dist/adapters/changeKeyLiterals.d.ts +3 -0
- package/dist/adapters/changeKeyLiterals.d.ts.map +1 -0
- package/dist/adapters/changeKeyLiterals.js +56 -0
- package/dist/adapters/changeKeyLiterals.js.map +1 -0
- package/dist/adapters/ignore.d.ts +10 -0
- package/dist/adapters/ignore.d.ts.map +1 -0
- package/dist/adapters/ignore.js +10 -0
- package/dist/adapters/ignore.js.map +1 -0
- package/dist/adapters/imports/fakeReferences.d.ts +14 -0
- package/dist/adapters/imports/fakeReferences.d.ts.map +1 -0
- package/dist/adapters/imports/fakeReferences.js +103 -0
- package/dist/adapters/imports/fakeReferences.js.map +1 -0
- package/dist/adapters/imports/fakeTargets.d.ts +13 -0
- package/dist/adapters/imports/fakeTargets.d.ts.map +1 -0
- package/dist/adapters/imports/fakeTargets.js +14 -0
- package/dist/adapters/imports/fakeTargets.js.map +1 -0
- package/dist/adapters/outsideImportFindings.d.ts +5 -0
- package/dist/adapters/outsideImportFindings.d.ts.map +1 -0
- package/dist/adapters/outsideImportFindings.js +78 -0
- package/dist/adapters/outsideImportFindings.js.map +1 -0
- package/dist/adapters/queueReadoutFindings.d.ts +8 -0
- package/dist/adapters/queueReadoutFindings.d.ts.map +1 -0
- package/dist/adapters/queueReadoutFindings.js +30 -0
- package/dist/adapters/queueReadoutFindings.js.map +1 -0
- package/dist/adapters/queueTestingOrigin.d.ts +5 -0
- package/dist/adapters/queueTestingOrigin.d.ts.map +1 -0
- package/dist/adapters/queueTestingOrigin.js +95 -0
- package/dist/adapters/queueTestingOrigin.js.map +1 -0
- package/dist/adapters/readConfig.d.ts +7 -0
- package/dist/adapters/readConfig.d.ts.map +1 -0
- package/dist/adapters/readConfig.js +40 -0
- package/dist/adapters/readConfig.js.map +1 -0
- package/dist/adapters/serviceIdFindings.d.ts +4 -0
- package/dist/adapters/serviceIdFindings.d.ts.map +1 -0
- package/dist/adapters/serviceIdFindings.js +65 -0
- package/dist/adapters/serviceIdFindings.js.map +1 -0
- package/dist/adapters/sharedErrorFindings.d.ts +4 -0
- package/dist/adapters/sharedErrorFindings.d.ts.map +1 -0
- package/dist/adapters/sharedErrorFindings.js +71 -0
- package/dist/adapters/sharedErrorFindings.js.map +1 -0
- package/dist/adapters/sharedErrorModules.d.ts +7 -0
- package/dist/adapters/sharedErrorModules.d.ts.map +1 -0
- package/dist/adapters/sharedErrorModules.js +66 -0
- package/dist/adapters/sharedErrorModules.js.map +1 -0
- package/dist/adapters/testProjects.d.ts.map +1 -1
- package/dist/adapters/testProjects.js +18 -2
- package/dist/adapters/testProjects.js.map +1 -1
- package/dist/appTestConfig.d.ts +1 -1
- package/dist/appTestConfig.d.ts.map +1 -1
- package/dist/appTestConfig.js.map +1 -1
- package/dist/biome/exceptionConfig.d.ts +0 -7
- package/dist/biome/exceptionConfig.d.ts.map +1 -1
- package/dist/biome/exceptionConfig.js +0 -36
- package/dist/biome/exceptionConfig.js.map +1 -1
- package/dist/biome/recognizeDiagnostics.d.ts.map +1 -1
- package/dist/biome/recognizeDiagnostics.js +2 -1
- package/dist/biome/recognizeDiagnostics.js.map +1 -1
- package/dist/biome/syntax.d.ts +0 -1
- package/dist/biome/syntax.d.ts.map +1 -1
- package/dist/biome/syntax.js +0 -9
- package/dist/biome/syntax.js.map +1 -1
- package/dist/biome/withoutEntryPointImports.d.ts +32 -2
- package/dist/biome/withoutEntryPointImports.d.ts.map +1 -1
- package/dist/biome/withoutEntryPointImports.js +12 -10
- package/dist/biome/withoutEntryPointImports.js.map +1 -1
- package/dist/cli/fixRule.js +1 -1
- package/dist/cli/fixRule.js.map +1 -1
- package/dist/config/globs.d.ts.map +1 -1
- package/dist/config/globs.js +1 -5
- package/dist/config/globs.js.map +1 -1
- package/dist/config/load.d.ts +2 -2
- package/dist/config/load.d.ts.map +1 -1
- package/dist/config/load.js +5 -36
- package/dist/config/load.js.map +1 -1
- package/dist/domEnvironment.config.js +1 -1
- package/dist/domEnvironment.config.js.map +1 -1
- package/dist/exceptions/biomeFindings.d.ts +1 -1
- package/dist/exceptions/biomeFindings.d.ts.map +1 -1
- package/dist/exceptions/biomeFindings.js +10 -6
- package/dist/exceptions/biomeFindings.js.map +1 -1
- package/dist/inventory/collect.js +2 -2
- package/dist/inventory/collect.js.map +1 -1
- package/dist/inventory/ignoreScope.d.ts +2 -2
- package/dist/inventory/ignoreScope.d.ts.map +1 -1
- package/dist/inventory/ignoreScope.js +2 -2
- package/dist/inventory/ignoreScope.js.map +1 -1
- package/dist/naming/packageLayout.d.ts +2 -1
- package/dist/naming/packageLayout.d.ts.map +1 -1
- package/dist/naming/packageLayout.js +4 -6
- package/dist/naming/packageLayout.js.map +1 -1
- package/dist/naming/testName.d.ts +1 -1
- package/dist/naming/testName.d.ts.map +1 -1
- package/dist/naming/testName.js +1 -1
- package/dist/naming/testName.js.map +1 -1
- package/dist/rules/biome.d.ts +1 -8
- package/dist/rules/biome.d.ts.map +1 -1
- package/dist/rules/biome.js +6 -15
- package/dist/rules/biome.js.map +1 -1
- package/dist/rules/builtIn.d.ts +2 -2
- package/dist/rules/builtIn.d.ts.map +1 -1
- package/dist/rules/builtIn.js +12 -0
- package/dist/rules/builtIn.js.map +1 -1
- package/dist/rules/effect/adapterImports.d.ts +2 -0
- package/dist/rules/effect/adapterImports.d.ts.map +1 -0
- package/dist/rules/effect/adapterImports.js +9 -0
- package/dist/rules/effect/adapterImports.js.map +1 -0
- package/dist/rules/effect/program.d.ts +1 -1
- package/dist/rules/effect/program.d.ts.map +1 -1
- package/dist/rules/effect/program.js +2 -2
- package/dist/rules/effect/program.js.map +1 -1
- package/dist/rules/effect/serviceIds.d.ts +2 -0
- package/dist/rules/effect/serviceIds.d.ts.map +1 -0
- package/dist/rules/effect/serviceIds.js +9 -0
- package/dist/rules/effect/serviceIds.js.map +1 -0
- package/dist/rules/effect/sharedErrorClasses.d.ts +2 -0
- package/dist/rules/effect/sharedErrorClasses.d.ts.map +1 -0
- package/dist/rules/effect/sharedErrorClasses.js +9 -0
- package/dist/rules/effect/sharedErrorClasses.js.map +1 -0
- package/dist/rules/files/folderNames.d.ts.map +1 -1
- package/dist/rules/files/folderNames.js +7 -7
- package/dist/rules/files/folderNames.js.map +1 -1
- package/dist/rules/files/namedAfterExport.d.ts.map +1 -1
- package/dist/rules/files/namedAfterExport.js +6 -6
- package/dist/rules/files/namedAfterExport.js.map +1 -1
- package/dist/rules/files/otherNames.d.ts.map +1 -1
- package/dist/rules/files/otherNames.js +7 -7
- package/dist/rules/files/otherNames.js.map +1 -1
- package/dist/rules/files/packageImports.d.ts +2 -1
- package/dist/rules/files/packageImports.d.ts.map +1 -1
- package/dist/rules/files/packageImports.js +4 -3
- package/dist/rules/files/packageImports.js.map +1 -1
- package/dist/rules/files/stylesheetImporters.d.ts +2 -1
- package/dist/rules/files/stylesheetImporters.d.ts.map +1 -1
- package/dist/rules/files/stylesheetImporters.js +5 -4
- package/dist/rules/files/stylesheetImporters.js.map +1 -1
- package/dist/rules/manifestsApplication.d.ts.map +1 -1
- package/dist/rules/manifestsApplication.js +22 -22
- package/dist/rules/manifestsApplication.js.map +1 -1
- package/dist/rules/manifestsExportsShape.d.ts.map +1 -1
- package/dist/rules/manifestsExportsShape.js +32 -8
- package/dist/rules/manifestsExportsShape.js.map +1 -1
- package/dist/rules/manifestsSorted.d.ts.map +1 -1
- package/dist/rules/manifestsSorted.js +6 -5
- package/dist/rules/manifestsSorted.js.map +1 -1
- package/dist/rules/manifestsSourceFirst.d.ts.map +1 -1
- package/dist/rules/manifestsSourceFirst.js +6 -5
- package/dist/rules/manifestsSourceFirst.js.map +1 -1
- package/dist/rules/stories/adapterOnlyFakes.d.ts +2 -0
- package/dist/rules/stories/adapterOnlyFakes.d.ts.map +1 -0
- package/dist/rules/stories/adapterOnlyFakes.js +63 -0
- package/dist/rules/stories/adapterOnlyFakes.js.map +1 -0
- package/dist/rules/stories/fakeImplementation.d.ts +4 -0
- package/dist/rules/stories/fakeImplementation.d.ts.map +1 -0
- package/dist/rules/stories/fakeImplementation.js +22 -0
- package/dist/rules/stories/fakeImplementation.js.map +1 -0
- package/dist/rules/stories/fakeReplacements.d.ts +4 -0
- package/dist/rules/stories/fakeReplacements.d.ts.map +1 -0
- package/dist/rules/stories/fakeReplacements.js +71 -0
- package/dist/rules/stories/fakeReplacements.js.map +1 -0
- package/dist/rules/stories/importOrigin.js +2 -2
- package/dist/rules/stories/importOrigin.js.map +1 -1
- package/dist/rules/stories/importedChangeKeys.d.ts +2 -0
- package/dist/rules/stories/importedChangeKeys.d.ts.map +1 -0
- package/dist/rules/stories/importedChangeKeys.js +9 -0
- package/dist/rules/stories/importedChangeKeys.js.map +1 -0
- package/dist/rules/stories/pureNetImport.d.ts +4 -0
- package/dist/rules/stories/pureNetImport.d.ts.map +1 -0
- package/dist/rules/stories/pureNetImport.js +23 -0
- package/dist/rules/stories/pureNetImport.js.map +1 -0
- package/dist/rules/stories/queueReadouts.d.ts +2 -0
- package/dist/rules/stories/queueReadouts.d.ts.map +1 -0
- package/dist/rules/stories/queueReadouts.js +9 -0
- package/dist/rules/stories/queueReadouts.js.map +1 -0
- package/dist/rules/stories/unitTests.d.ts.map +1 -1
- package/dist/rules/stories/unitTests.js +4 -3
- package/dist/rules/stories/unitTests.js.map +1 -1
- package/dist/rules/suppressions/biome/weakenings.d.ts +1 -1
- package/dist/rules/suppressions/biome/weakenings.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeOverrides.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeOverrides.js +5 -5
- package/dist/rules/suppressions/biomeOverrides.js.map +1 -1
- package/dist/rules/suppressions/biomeRecommended.d.ts +1 -1
- package/dist/rules/suppressions/biomeRecommended.d.ts.map +1 -1
- package/dist/rules/suppressions/biomeRecommended.js +12 -30
- package/dist/rules/suppressions/biomeRecommended.js.map +1 -1
- package/dist/rules/test-names/colocated.js +2 -2
- package/dist/rules/test-names/colocated.js.map +1 -1
- package/dist/rules/test-names/follow.js +4 -4
- package/dist/rules/test-names/follow.js.map +1 -1
- package/dist/testing/adapters/cli.d.ts +21 -0
- package/dist/testing/adapters/cli.d.ts.map +1 -0
- package/dist/testing/adapters/cli.js +85 -0
- package/dist/testing/adapters/cli.js.map +1 -0
- package/dist/testing/adapters/git.d.ts +14 -0
- package/dist/testing/adapters/git.d.ts.map +1 -0
- package/dist/testing/adapters/git.js +52 -0
- package/dist/testing/adapters/git.js.map +1 -0
- package/dist/testing/adapters/hookPath.d.ts +2 -0
- package/dist/testing/adapters/hookPath.d.ts.map +1 -0
- package/dist/testing/adapters/hookPath.js +6 -0
- package/dist/testing/adapters/hookPath.js.map +1 -0
- package/dist/testing/adapters/hookRepository.d.ts +25 -0
- package/dist/testing/adapters/hookRepository.d.ts.map +1 -0
- package/dist/testing/adapters/hookRepository.js +96 -0
- package/dist/testing/adapters/hookRepository.js.map +1 -0
- package/dist/testing/adapters/imports.d.ts +5 -0
- package/dist/testing/adapters/imports.d.ts.map +1 -0
- package/dist/testing/adapters/imports.js +29 -0
- package/dist/testing/adapters/imports.js.map +1 -0
- package/dist/testing/adapters/packageExports.d.ts +15 -0
- package/dist/testing/adapters/packageExports.d.ts.map +1 -0
- package/dist/testing/adapters/packageExports.js +29 -0
- package/dist/testing/adapters/packageExports.js.map +1 -0
- package/dist/testing/adapters/qualityTree.d.ts +4 -0
- package/dist/testing/adapters/qualityTree.d.ts.map +1 -0
- package/dist/testing/adapters/qualityTree.js +21 -0
- package/dist/testing/adapters/qualityTree.js.map +1 -0
- package/dist/testing/adapters/run.d.ts +4 -0
- package/dist/testing/adapters/run.d.ts.map +1 -0
- package/dist/testing/adapters/run.js +6 -0
- package/dist/testing/adapters/run.js.map +1 -0
- package/dist/testing/adapters/storySpecFiles.d.ts +7 -0
- package/dist/testing/adapters/storySpecFiles.d.ts.map +1 -0
- package/dist/testing/adapters/storySpecFiles.js +48 -0
- package/dist/testing/adapters/storySpecFiles.js.map +1 -0
- package/dist/testing/adapters/tree.d.ts +13 -0
- package/dist/testing/adapters/tree.d.ts.map +1 -0
- package/dist/testing/adapters/tree.js +42 -0
- package/dist/testing/adapters/tree.js.map +1 -0
- package/dist/testing/adapters/writePackageExports.d.ts +2 -0
- package/dist/testing/adapters/writePackageExports.d.ts.map +1 -0
- package/dist/testing/adapters/writePackageExports.js +9 -0
- package/dist/testing/adapters/writePackageExports.js.map +1 -0
- package/dist/testing/ruleStory.d.ts +28 -0
- package/dist/testing/ruleStory.d.ts.map +1 -0
- package/dist/testing/ruleStory.js +115 -0
- package/dist/testing/ruleStory.js.map +1 -0
- package/dist/unitIoGuard.config.js +1 -1
- package/dist/unitIoGuard.config.js.map +1 -1
- package/package.json +7 -2
- package/src/{rules/suppressions → adapters}/biome/configs.ts +2 -2
- package/src/adapters/biome/presetConfig.ts +34 -0
- package/src/adapters/biome/rootConfig.ts +19 -0
- package/src/adapters/biome/run.ts +1 -1
- package/src/adapters/biome/syntaxOf.ts +12 -0
- package/src/adapters/biome/withExceptionConfig.ts +45 -0
- package/src/adapters/changeKeyApi.ts +62 -0
- package/src/adapters/changeKeyFindings.ts +96 -0
- package/src/adapters/changeKeyLiterals.ts +60 -0
- package/src/adapters/ignore.ts +16 -0
- package/src/adapters/imports/fakeReferences.ts +115 -0
- package/src/adapters/imports/fakeTargets.ts +21 -0
- package/src/adapters/outsideImportFindings.ts +98 -0
- package/src/adapters/queueReadoutFindings.ts +37 -0
- package/src/adapters/queueTestingOrigin.ts +113 -0
- package/src/adapters/readConfig.ts +42 -0
- package/src/adapters/serviceIdFindings.ts +80 -0
- package/src/adapters/sharedErrorFindings.ts +84 -0
- package/src/adapters/sharedErrorModules.ts +81 -0
- package/src/adapters/testProjects.ts +18 -2
- package/src/appTestConfig.ts +1 -1
- package/src/biome/exceptionConfig.ts +0 -43
- package/src/biome/recognizeDiagnostics.ts +2 -1
- package/src/biome/syntax.ts +0 -10
- package/src/biome/withoutEntryPointImports.ts +15 -10
- package/src/cli/fixRule.ts +1 -1
- package/src/config/globs.ts +1 -6
- package/src/config/load.ts +6 -38
- package/src/domEnvironment.config.ts +1 -1
- package/src/exceptions/biomeFindings.ts +11 -10
- package/src/inventory/collect.ts +2 -2
- package/src/inventory/ignoreScope.ts +3 -3
- package/src/naming/packageLayout.ts +14 -7
- package/src/naming/testName.ts +1 -1
- package/src/rules/biome.ts +6 -23
- package/src/rules/builtIn.ts +12 -0
- package/src/rules/effect/adapterImports.ts +10 -0
- package/src/rules/effect/program.ts +2 -2
- package/src/rules/effect/serviceIds.ts +10 -0
- package/src/rules/effect/sharedErrorClasses.ts +10 -0
- package/src/rules/files/folderNames.ts +19 -18
- package/src/rules/files/namedAfterExport.ts +10 -9
- package/src/rules/files/otherNames.ts +17 -16
- package/src/rules/files/packageImports.ts +14 -4
- package/src/rules/files/stylesheetImporters.ts +13 -6
- package/src/rules/manifestsApplication.ts +44 -33
- package/src/rules/manifestsExportsShape.ts +45 -15
- package/src/rules/manifestsSorted.ts +16 -11
- package/src/rules/manifestsSourceFirst.ts +22 -17
- package/src/rules/stories/adapterOnlyFakes.ts +66 -0
- package/src/rules/stories/fakeImplementation.ts +23 -0
- package/src/rules/stories/fakeReplacements.ts +74 -0
- package/src/rules/stories/importOrigin.ts +2 -2
- package/src/rules/stories/importedChangeKeys.ts +10 -0
- package/src/rules/stories/pureNetImport.ts +29 -0
- package/src/rules/stories/queueReadouts.ts +9 -0
- package/src/rules/stories/unitTests.ts +6 -3
- package/src/rules/suppressions/biome/weakenings.ts +1 -1
- package/src/rules/suppressions/biomeOverrides.ts +17 -16
- package/src/rules/suppressions/biomeRecommended.ts +13 -32
- package/src/rules/test-names/colocated.ts +2 -2
- package/src/rules/test-names/follow.ts +4 -4
- package/src/testing/adapters/cli.ts +105 -0
- package/src/testing/adapters/git.ts +62 -0
- package/src/testing/adapters/hookPath.ts +6 -0
- package/src/testing/adapters/hookRepository.ts +134 -0
- package/src/testing/adapters/imports.ts +35 -0
- package/src/testing/adapters/packageExports.ts +37 -0
- package/src/testing/adapters/qualityTree.ts +26 -0
- package/src/testing/adapters/run.ts +7 -0
- package/src/testing/adapters/storySpecFiles.ts +54 -0
- package/src/testing/adapters/tree.ts +55 -0
- package/src/testing/adapters/writePackageExports.ts +9 -0
- package/src/testing/ruleStory.ts +139 -0
- package/src/unitIoGuard.config.ts +1 -1
- package/dist/biome/relocateConfig.d.ts.map +0 -1
- package/dist/biome/relocateConfig.js.map +0 -1
- package/dist/rules/suppressions/biome/configs.d.ts.map +0 -1
- package/dist/rules/suppressions/biome/configs.js.map +0 -1
- package/dist/rules/suppressions/biome/resolvePackage.d.ts.map +0 -1
- package/dist/rules/suppressions/biome/resolvePackage.js.map +0 -1
- /package/dist/{biome → adapters/biome}/relocateConfig.d.ts +0 -0
- /package/dist/{biome → adapters/biome}/relocateConfig.js +0 -0
- /package/dist/{rules/suppressions → adapters}/biome/resolvePackage.d.ts +0 -0
- /package/dist/{rules/suppressions → adapters}/biome/resolvePackage.js +0 -0
- /package/src/{biome → adapters/biome}/relocateConfig.ts +0 -0
- /package/src/{rules/suppressions → adapters}/biome/resolvePackage.ts +0 -0
|
@@ -0,0 +1,98 @@
|
|
|
1
|
+
import { Effect } from "effect";
|
|
2
|
+
import ts from "typescript";
|
|
3
|
+
import type { ImportAnalysisFailure } from "#adapters/ImportCompiler.ts";
|
|
4
|
+
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
5
|
+
import { importGraph } from "#imports/graph.ts";
|
|
6
|
+
import { packageNameOf } from "#imports/packageName.ts";
|
|
7
|
+
import { packageOf } from "#imports/workspace.ts";
|
|
8
|
+
import type { Finding, RuleInputs } from "#rule.ts";
|
|
9
|
+
import { parse } from "#rules/parse.ts";
|
|
10
|
+
|
|
11
|
+
function onlyInlineTypes(statement: ts.Statement): boolean {
|
|
12
|
+
if (ts.isImportDeclaration(statement)) {
|
|
13
|
+
const clause = statement.importClause;
|
|
14
|
+
const bindings = clause?.namedBindings;
|
|
15
|
+
return (
|
|
16
|
+
clause?.name === undefined
|
|
17
|
+
&& bindings !== undefined
|
|
18
|
+
&& ts.isNamedImports(bindings)
|
|
19
|
+
&& bindings.elements.length > 0
|
|
20
|
+
&& bindings.elements.every((item) => item.isTypeOnly)
|
|
21
|
+
);
|
|
22
|
+
}
|
|
23
|
+
const exports = ts.isExportDeclaration(statement) ? statement.exportClause : undefined;
|
|
24
|
+
return exports !== undefined && ts.isNamedExports(exports) && exports.elements.length > 0 && exports.elements.every((item) => item.isTypeOnly);
|
|
25
|
+
}
|
|
26
|
+
|
|
27
|
+
function inlineTypes(inputs: RuleInputs): ReadonlySet<string> {
|
|
28
|
+
const sites = new Set<string>();
|
|
29
|
+
for (const file of inputs.sources) {
|
|
30
|
+
const source = parse(file);
|
|
31
|
+
if (source === undefined) {
|
|
32
|
+
continue;
|
|
33
|
+
}
|
|
34
|
+
for (const statement of source.statements.filter(onlyInlineTypes)) {
|
|
35
|
+
sites.add(`${file.path}:${source.getLineAndCharacterOfPosition(statement.getStart(source)).line + 1}`);
|
|
36
|
+
}
|
|
37
|
+
}
|
|
38
|
+
return sites;
|
|
39
|
+
}
|
|
40
|
+
|
|
41
|
+
function exempt(path: string, name: string): boolean {
|
|
42
|
+
return (
|
|
43
|
+
/(?:^|\/)(?:adapters|test-support)\//u.test(path)
|
|
44
|
+
|| name === "effect"
|
|
45
|
+
|| name.startsWith("@effect/")
|
|
46
|
+
|| name.startsWith("@shivaedev/")
|
|
47
|
+
|| ((name === "react" || name === "react-dom") && /(?:^|\/)client\//u.test(path))
|
|
48
|
+
);
|
|
49
|
+
}
|
|
50
|
+
|
|
51
|
+
export const outsideImportFindings = Effect.fn("Imports.outsideImportFindings")(function* (
|
|
52
|
+
inputs: RuleInputs,
|
|
53
|
+
): Effect.fn.Return<readonly Finding[], ImportAnalysisFailure> {
|
|
54
|
+
const graph = yield* importGraph(inputs);
|
|
55
|
+
const owners = [...graph.packages.map((owner) => owner.directory), "."];
|
|
56
|
+
const runtime = new Map(
|
|
57
|
+
yield* Effect.forEach(
|
|
58
|
+
owners,
|
|
59
|
+
(directory) =>
|
|
60
|
+
Effect.gen(function* () {
|
|
61
|
+
const manifest = yield* Effect.promise(() => readPackageManifest(inputs.readText, `${directory}/package.json`));
|
|
62
|
+
return [
|
|
63
|
+
directory,
|
|
64
|
+
new Set(Object.keys({ ...manifest?.dependencies, ...manifest?.peerDependencies, ...manifest?.optionalDependencies })),
|
|
65
|
+
] as const;
|
|
66
|
+
}),
|
|
67
|
+
{ concurrency: "unbounded" },
|
|
68
|
+
),
|
|
69
|
+
);
|
|
70
|
+
const types = inlineTypes(inputs);
|
|
71
|
+
const workspace = new Set(graph.packages.map((owner) => owner.name));
|
|
72
|
+
const sites = [
|
|
73
|
+
...graph.edges.flatMap((edge) => (edge.to.kind === "external" ? [{ ...edge, name: edge.to.package }] : [])),
|
|
74
|
+
...graph.unresolved
|
|
75
|
+
.filter((edge) => edge.missing === undefined && !/^[.#/]/u.test(edge.specifier))
|
|
76
|
+
.map((edge) => ({ ...edge, name: packageNameOf(edge.specifier) })),
|
|
77
|
+
];
|
|
78
|
+
return sites.flatMap((site) => {
|
|
79
|
+
const directory = packageOf(graph.packages, site.from)?.directory ?? ".";
|
|
80
|
+
if (
|
|
81
|
+
workspace.has(site.name)
|
|
82
|
+
|| site.type
|
|
83
|
+
|| site.kind !== "import"
|
|
84
|
+
|| types.has(`${site.from}:${site.line}`)
|
|
85
|
+
|| exempt(site.from, site.name)
|
|
86
|
+
|| !(site.name.startsWith("node:") || runtime.get(directory)?.has(site.name))
|
|
87
|
+
) {
|
|
88
|
+
return [];
|
|
89
|
+
}
|
|
90
|
+
return [
|
|
91
|
+
{
|
|
92
|
+
file: site.from,
|
|
93
|
+
line: site.line,
|
|
94
|
+
message: `Imports outside library "${site.specifier}" as a value. Move the integration into an adapters/ folder and expose Effect values; use import type for types.`,
|
|
95
|
+
},
|
|
96
|
+
];
|
|
97
|
+
});
|
|
98
|
+
});
|
|
@@ -0,0 +1,37 @@
|
|
|
1
|
+
import { join } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
3
|
+
import ts from "typescript";
|
|
4
|
+
import { importGraph } from "#imports/graph.ts";
|
|
5
|
+
import { packageOf } from "#imports/workspace.ts";
|
|
6
|
+
import { isTestCode } from "#naming/testName.ts";
|
|
7
|
+
import type { RuleInputs } from "#rule.ts";
|
|
8
|
+
import { storyProgram } from "#rules/stories/program.ts";
|
|
9
|
+
import { nodesWhere } from "#rules/stories/syntax.ts";
|
|
10
|
+
import { readPackageManifest } from "./manifestInventory.ts";
|
|
11
|
+
import { queueTestingOrigin } from "./queueTestingOrigin.ts";
|
|
12
|
+
|
|
13
|
+
const MESSAGE =
|
|
14
|
+
"Reads jobs-testing queue storage. An enqueued job or its state does not prove the work ran. Assert the application's visible result instead; use jobs-testing only to control and settle workers.";
|
|
15
|
+
|
|
16
|
+
export const queueReadoutFindings = Effect.fn("Stories.queueReadoutFindings")(function* (inputs: RuleInputs) {
|
|
17
|
+
const graph = yield* importGraph(inputs);
|
|
18
|
+
const root = yield* Effect.promise(() => readPackageManifest(inputs.readText, "package.json"));
|
|
19
|
+
const program = storyProgram(inputs, graph);
|
|
20
|
+
const origin = queueTestingOrigin(program.getTypeChecker());
|
|
21
|
+
return inputs.sources.flatMap((file) => {
|
|
22
|
+
const owner = packageOf(graph.packages, file.path)?.name ?? root?.name;
|
|
23
|
+
if (!isTestCode(file.path) || owner === "@shivaedev/jobs") {
|
|
24
|
+
return [];
|
|
25
|
+
}
|
|
26
|
+
const source = program.getSourceFile(join(inputs.root, file.path));
|
|
27
|
+
if (source === undefined) {
|
|
28
|
+
return [];
|
|
29
|
+
}
|
|
30
|
+
return nodesWhere(
|
|
31
|
+
source,
|
|
32
|
+
(node) =>
|
|
33
|
+
((ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) && origin(node) === "readout")
|
|
34
|
+
|| (ts.isBindingElement(node) && origin(node) === "readout"),
|
|
35
|
+
).map((node) => ({ file: file.path, line: source.getLineAndCharacterOfPosition(node.getStart(source)).line + 1, message: MESSAGE }));
|
|
36
|
+
});
|
|
37
|
+
});
|
|
@@ -0,0 +1,113 @@
|
|
|
1
|
+
import ts from "typescript";
|
|
2
|
+
import { importFrom } from "#rules/stories/importOrigin.ts";
|
|
3
|
+
import { memberName, unwrapped } from "#rules/stories/syntax.ts";
|
|
4
|
+
|
|
5
|
+
type Origin = "module" | "factory" | "controller" | "readout" | undefined;
|
|
6
|
+
|
|
7
|
+
const TESTING_MODULE = "@shivaedev/jobs/server/testing.ts";
|
|
8
|
+
|
|
9
|
+
function importedOrigin(node: ts.Node): Origin {
|
|
10
|
+
if (importFrom(node) !== TESTING_MODULE) {
|
|
11
|
+
return undefined;
|
|
12
|
+
}
|
|
13
|
+
if (ts.isImportSpecifier(node)) {
|
|
14
|
+
return (node.propertyName ?? node.name).text === "makePgBossTesting" ? "factory" : undefined;
|
|
15
|
+
}
|
|
16
|
+
return ts.isNamespaceImport(node) ? "module" : undefined;
|
|
17
|
+
}
|
|
18
|
+
|
|
19
|
+
export function queueTestingOrigin(checker: ts.TypeChecker) {
|
|
20
|
+
const visiting = new Set<ts.Node>();
|
|
21
|
+
const known = new Map<ts.Node, Origin>();
|
|
22
|
+
|
|
23
|
+
function member(receiver: Origin, name: string): Origin {
|
|
24
|
+
if (receiver === "module") {
|
|
25
|
+
return name === "makePgBossTesting" ? "factory" : undefined;
|
|
26
|
+
}
|
|
27
|
+
return receiver === "controller" && (name === "jobs" || name === "snapshot") ? "readout" : undefined;
|
|
28
|
+
}
|
|
29
|
+
|
|
30
|
+
function symbol(value: ts.Symbol | undefined): Origin {
|
|
31
|
+
const direct = value?.declarations?.map(visit).find((result) => result !== undefined);
|
|
32
|
+
return direct ?? (value !== undefined && value.flags & ts.SymbolFlags.Alias ? symbol(checker.getAliasedSymbol(value)) : undefined);
|
|
33
|
+
}
|
|
34
|
+
|
|
35
|
+
function typed(node: ts.Node): Origin {
|
|
36
|
+
if (!(ts.isParameter(node) || ts.isVariableDeclaration(node) || ts.isPropertySignature(node))) {
|
|
37
|
+
return undefined;
|
|
38
|
+
}
|
|
39
|
+
const type = node.type;
|
|
40
|
+
if (type !== undefined && ts.isTypeReferenceNode(type)) {
|
|
41
|
+
const value = checker.getSymbolAtLocation(type.typeName);
|
|
42
|
+
if (
|
|
43
|
+
value?.declarations?.some(
|
|
44
|
+
(declaration) =>
|
|
45
|
+
ts.isImportSpecifier(declaration)
|
|
46
|
+
&& importFrom(declaration) === TESTING_MODULE
|
|
47
|
+
&& (declaration.propertyName ?? declaration.name).text === "PgBossTesting",
|
|
48
|
+
)
|
|
49
|
+
) {
|
|
50
|
+
return "controller";
|
|
51
|
+
}
|
|
52
|
+
}
|
|
53
|
+
return undefined;
|
|
54
|
+
}
|
|
55
|
+
|
|
56
|
+
function binding(node: ts.BindingElement): Origin {
|
|
57
|
+
const declaration = node.parent.parent;
|
|
58
|
+
const name = node.propertyName ?? node.name;
|
|
59
|
+
if ((ts.isIdentifier(name) || ts.isStringLiteral(name)) && name.text === "jobsTesting") {
|
|
60
|
+
return "controller";
|
|
61
|
+
}
|
|
62
|
+
return ts.isVariableDeclaration(declaration) && ts.isObjectBindingPattern(node.parent) && (ts.isIdentifier(name) || ts.isStringLiteral(name))
|
|
63
|
+
? member(visit(declaration), name.text)
|
|
64
|
+
: undefined;
|
|
65
|
+
}
|
|
66
|
+
|
|
67
|
+
function declaredOrigin(node: ts.Node): Origin {
|
|
68
|
+
if (ts.isVariableDeclaration(node) || ts.isPropertyAssignment(node)) {
|
|
69
|
+
return typed(node) ?? (node.initializer === undefined ? undefined : visit(node.initializer));
|
|
70
|
+
}
|
|
71
|
+
if (ts.isShorthandPropertyAssignment(node)) {
|
|
72
|
+
return symbol(checker.getShorthandAssignmentValueSymbol(node));
|
|
73
|
+
}
|
|
74
|
+
if (ts.isBindingElement(node)) {
|
|
75
|
+
return binding(node);
|
|
76
|
+
}
|
|
77
|
+
return typed(node) ?? importedOrigin(node);
|
|
78
|
+
}
|
|
79
|
+
|
|
80
|
+
function reference(node: ts.Node): Origin {
|
|
81
|
+
if (ts.isPropertyAccessExpression(node) || ts.isElementAccessExpression(node)) {
|
|
82
|
+
const name = memberName(node);
|
|
83
|
+
return name === "jobsTesting" ? "controller" : (member(visit(node.expression), name ?? "") ?? symbol(checker.getSymbolAtLocation(node)));
|
|
84
|
+
}
|
|
85
|
+
if (ts.isIdentifier(node)) {
|
|
86
|
+
return node.text === "jobsTesting" ? "controller" : symbol(checker.getSymbolAtLocation(node));
|
|
87
|
+
}
|
|
88
|
+
return declaredOrigin(node);
|
|
89
|
+
}
|
|
90
|
+
|
|
91
|
+
function origin(node: ts.Node): Origin {
|
|
92
|
+
if (ts.isCallExpression(node)) {
|
|
93
|
+
return visit(node.expression) === "factory" ? "controller" : undefined;
|
|
94
|
+
}
|
|
95
|
+
if (ts.isExpression(node) && unwrapped(node) !== node) {
|
|
96
|
+
return visit(unwrapped(node));
|
|
97
|
+
}
|
|
98
|
+
return reference(node);
|
|
99
|
+
}
|
|
100
|
+
|
|
101
|
+
function visit(node: ts.Node): Origin {
|
|
102
|
+
if (visiting.has(node) || known.has(node)) {
|
|
103
|
+
return known.get(node);
|
|
104
|
+
}
|
|
105
|
+
visiting.add(node);
|
|
106
|
+
const result = origin(node);
|
|
107
|
+
visiting.delete(node);
|
|
108
|
+
known.set(node, result);
|
|
109
|
+
return result;
|
|
110
|
+
}
|
|
111
|
+
|
|
112
|
+
return visit;
|
|
113
|
+
}
|
|
@@ -0,0 +1,42 @@
|
|
|
1
|
+
import { basename, dirname, resolve } from "node:path";
|
|
2
|
+
import { pathToFileURL } from "node:url";
|
|
3
|
+
import { Effect, FileSystem } from "effect";
|
|
4
|
+
import { CONFIG_FILE } from "#config/constants.ts";
|
|
5
|
+
import { SetupFailure } from "#failure.ts";
|
|
6
|
+
|
|
7
|
+
function messageOf(cause: unknown): string {
|
|
8
|
+
return cause instanceof Error ? cause.message : String(cause);
|
|
9
|
+
}
|
|
10
|
+
|
|
11
|
+
function importDefault(file: string): Effect.Effect<unknown, SetupFailure> {
|
|
12
|
+
return Effect.flatMap(
|
|
13
|
+
Effect.tryPromise({
|
|
14
|
+
catch: (cause) => new SetupFailure({ cause, message: `cannot load ${file}: ${messageOf(cause)}` }),
|
|
15
|
+
try: async (): Promise<unknown> => import(pathToFileURL(file).href),
|
|
16
|
+
}),
|
|
17
|
+
(loaded) =>
|
|
18
|
+
typeof loaded === "object" && loaded !== null && "default" in loaded
|
|
19
|
+
? Effect.succeed(loaded.default)
|
|
20
|
+
: Effect.fail(new SetupFailure({ message: `${file} has no default export. Export defineConfig({ ... }) as the default.` })),
|
|
21
|
+
);
|
|
22
|
+
}
|
|
23
|
+
|
|
24
|
+
export const readConfig = Effect.fn("Config.readConfig")(function* (cwd: string, path: string | undefined) {
|
|
25
|
+
const fs = yield* FileSystem.FileSystem;
|
|
26
|
+
const file = resolve(cwd, path ?? CONFIG_FILE);
|
|
27
|
+
const entries = yield* fs
|
|
28
|
+
.readDirectory(dirname(file))
|
|
29
|
+
.pipe(
|
|
30
|
+
Effect.catchTag("PlatformError", (error) =>
|
|
31
|
+
error.reason._tag === "NotFound"
|
|
32
|
+
? Effect.succeed<string[]>([])
|
|
33
|
+
: Effect.fail(new SetupFailure({ cause: error, message: `cannot inspect ${file}: ${error.message}` })),
|
|
34
|
+
),
|
|
35
|
+
);
|
|
36
|
+
const present = entries.includes(basename(file));
|
|
37
|
+
if (!present && path !== undefined) {
|
|
38
|
+
return yield* new SetupFailure({ message: `no config at ${file}. Check the --config path.` });
|
|
39
|
+
}
|
|
40
|
+
const loaded = present ? yield* importDefault(file) : {};
|
|
41
|
+
return { file, loaded };
|
|
42
|
+
});
|
|
@@ -0,0 +1,80 @@
|
|
|
1
|
+
import { join } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
3
|
+
import ts from "typescript";
|
|
4
|
+
import type { Finding, RuleInputs } from "#rule.ts";
|
|
5
|
+
import { boundaryReference } from "#rules/effect/boundaryReference.ts";
|
|
6
|
+
|
|
7
|
+
function definitionId(node: ts.Expression | undefined): ts.Expression | undefined {
|
|
8
|
+
if (node === undefined || !ts.isObjectLiteralExpression(node)) {
|
|
9
|
+
return undefined;
|
|
10
|
+
}
|
|
11
|
+
const property = node.properties.find(
|
|
12
|
+
(member) => ts.isPropertyAssignment(member) && (ts.isIdentifier(member.name) || ts.isStringLiteralLike(member.name)) && member.name.text === "id",
|
|
13
|
+
);
|
|
14
|
+
return property !== undefined && ts.isPropertyAssignment(property) ? property.initializer : undefined;
|
|
15
|
+
}
|
|
16
|
+
|
|
17
|
+
function literalId(checker: ts.TypeChecker, call: ts.CallExpression, ownPackage: boolean): ts.StringLiteralLike | undefined {
|
|
18
|
+
const callee = ts.isCallExpression(call.expression) && call.expression.arguments.length === 0 ? call.expression.expression : call.expression;
|
|
19
|
+
const reference = boundaryReference(checker, callee) ?? "";
|
|
20
|
+
let id = call.arguments[0];
|
|
21
|
+
if (
|
|
22
|
+
(ownPackage && reference === "#defineService.ts.defineService")
|
|
23
|
+
|| /^@shivaedev\/service\/defineService(?:\.ts)?\.defineService$/u.test(reference)
|
|
24
|
+
) {
|
|
25
|
+
id = definitionId(id);
|
|
26
|
+
} else if (
|
|
27
|
+
!(
|
|
28
|
+
/^effect(?:\.Context|\/Context)\.(?:Service|Reference)$/u.test(reference)
|
|
29
|
+
|| /^(?:effect\/(?:unstable\/)?rpc(?:\.RpcMiddleware|\/RpcMiddleware)|@effect\/rpc(?:\.RpcMiddleware|\/RpcMiddleware))\.(?:Service|Tag)$/u.test(
|
|
30
|
+
reference,
|
|
31
|
+
)
|
|
32
|
+
)
|
|
33
|
+
) {
|
|
34
|
+
return undefined;
|
|
35
|
+
}
|
|
36
|
+
return id !== undefined && ts.isStringLiteralLike(id) ? id : undefined;
|
|
37
|
+
}
|
|
38
|
+
|
|
39
|
+
function checkPackage(inputs: RuleInputs, prefix: string): readonly Finding[] {
|
|
40
|
+
const texts = new Map(inputs.sources.map((file) => [join(inputs.root, file.path), file.text]));
|
|
41
|
+
const options: ts.CompilerOptions = { allowJs: true, noLib: true, noResolve: true, target: ts.ScriptTarget.Latest };
|
|
42
|
+
const host = ts.createCompilerHost(options);
|
|
43
|
+
host.readFile = (path) => texts.get(path);
|
|
44
|
+
const program = ts.createProgram([...texts.keys()], options, host);
|
|
45
|
+
const checker = program.getTypeChecker();
|
|
46
|
+
return inputs.sources.flatMap((file) => {
|
|
47
|
+
const source = program.getSourceFile(join(inputs.root, file.path));
|
|
48
|
+
const findings: Finding[] = [];
|
|
49
|
+
function visit(node: ts.Node): void {
|
|
50
|
+
const id = ts.isCallExpression(node) ? literalId(checker, node, prefix === "@shivaedev/service/") : undefined;
|
|
51
|
+
if (id !== undefined && !id.text.startsWith(prefix) && source !== undefined) {
|
|
52
|
+
findings.push({
|
|
53
|
+
file: file.path,
|
|
54
|
+
line: source.getLineAndCharacterOfPosition(id.getStart(source)).line + 1,
|
|
55
|
+
message: `Service id ${JSON.stringify(id.text)} must start with ${JSON.stringify(prefix)}. Prefix the id with its package name and update references to that id.`,
|
|
56
|
+
});
|
|
57
|
+
}
|
|
58
|
+
ts.forEachChild(node, visit);
|
|
59
|
+
}
|
|
60
|
+
if (source !== undefined) {
|
|
61
|
+
visit(source);
|
|
62
|
+
}
|
|
63
|
+
return findings;
|
|
64
|
+
});
|
|
65
|
+
}
|
|
66
|
+
|
|
67
|
+
export const serviceIdFindings = Effect.fn("ServiceIds.serviceIdFindings")((inputs: RuleInputs) =>
|
|
68
|
+
Effect.sync(() => {
|
|
69
|
+
const groups = new Map<string, RuleInputs["sources"][number][]>();
|
|
70
|
+
for (const source of inputs.sources) {
|
|
71
|
+
const name = /^packages\/(?<name>[^/]+)\/.+\.[cm]?[jt]sx?$/u.exec(source.path)?.groups?.name;
|
|
72
|
+
if (name !== undefined) {
|
|
73
|
+
const files = groups.get(name) ?? [];
|
|
74
|
+
files.push(source);
|
|
75
|
+
groups.set(name, files);
|
|
76
|
+
}
|
|
77
|
+
}
|
|
78
|
+
return [...groups].flatMap(([name, sources]) => checkPackage({ ...inputs, sources }, `@shivaedev/${name}/`));
|
|
79
|
+
}),
|
|
80
|
+
);
|
|
@@ -0,0 +1,84 @@
|
|
|
1
|
+
import { join } from "node:path";
|
|
2
|
+
import { Effect } from "effect";
|
|
3
|
+
import ts from "typescript";
|
|
4
|
+
import { type SharedErrorModule, sharedErrorModules } from "#adapters/sharedErrorModules.ts";
|
|
5
|
+
import type { Finding, RuleInputs } from "#rule.ts";
|
|
6
|
+
import { effectProgram } from "#rules/effect/program.ts";
|
|
7
|
+
|
|
8
|
+
interface SharedError {
|
|
9
|
+
readonly repair: string;
|
|
10
|
+
readonly symbol: ts.Symbol;
|
|
11
|
+
}
|
|
12
|
+
|
|
13
|
+
function errorTag(checker: ts.TypeChecker, symbol: ts.Symbol): string | undefined {
|
|
14
|
+
if (!(symbol.flags & ts.SymbolFlags.Class)) {
|
|
15
|
+
return undefined;
|
|
16
|
+
}
|
|
17
|
+
const type = checker.getDeclaredTypeOfSymbol(symbol);
|
|
18
|
+
const tag = type.getProperty("_tag");
|
|
19
|
+
const declaration = symbol.valueDeclaration;
|
|
20
|
+
if (tag === undefined || declaration === undefined || type.getProperty("message") === undefined || type.getProperty("name") === undefined) {
|
|
21
|
+
return undefined;
|
|
22
|
+
}
|
|
23
|
+
const literal = checker.getTypeOfSymbolAtLocation(tag, declaration);
|
|
24
|
+
return literal.isStringLiteral() ? literal.value : undefined;
|
|
25
|
+
}
|
|
26
|
+
|
|
27
|
+
function sharedCatalog(program: ts.Program, checker: ts.TypeChecker, modules: readonly SharedErrorModule[]): ReadonlyMap<string, SharedError> {
|
|
28
|
+
const catalog = new Map<string, SharedError>();
|
|
29
|
+
for (const { file, specifier } of modules) {
|
|
30
|
+
const source = program.getSourceFile(file);
|
|
31
|
+
const module = source === undefined ? undefined : checker.getSymbolAtLocation(source);
|
|
32
|
+
for (const exported of module === undefined ? [] : checker.getExportsOfModule(module)) {
|
|
33
|
+
const symbol = exported.flags & ts.SymbolFlags.Alias ? checker.getAliasedSymbol(exported) : exported;
|
|
34
|
+
const tag = errorTag(checker, symbol);
|
|
35
|
+
if (tag !== undefined) {
|
|
36
|
+
catalog.set(tag, { repair: `Import ${exported.name} from "${specifier}" and use that class instead.`, symbol });
|
|
37
|
+
}
|
|
38
|
+
}
|
|
39
|
+
}
|
|
40
|
+
return catalog;
|
|
41
|
+
}
|
|
42
|
+
|
|
43
|
+
function classFindings(source: ts.SourceFile, file: string, checker: ts.TypeChecker, catalog: ReadonlyMap<string, SharedError>): readonly Finding[] {
|
|
44
|
+
const findings: Finding[] = [];
|
|
45
|
+
function visit(node: ts.Node): void {
|
|
46
|
+
if (ts.isClassDeclaration(node) || ts.isClassExpression(node)) {
|
|
47
|
+
const symbol = checker.getTypeAtLocation(node).symbol;
|
|
48
|
+
const tag = symbol === undefined ? undefined : errorTag(checker, symbol);
|
|
49
|
+
const shared = tag === undefined ? undefined : catalog.get(tag);
|
|
50
|
+
if (shared !== undefined && symbol !== shared.symbol) {
|
|
51
|
+
findings.push({
|
|
52
|
+
file,
|
|
53
|
+
line: source.getLineAndCharacterOfPosition(node.getStart()).line + 1,
|
|
54
|
+
message: `Tagged error ${node.name?.text ?? "anonymous class"} reuses the shared tag "${tag}". ${shared.repair}`,
|
|
55
|
+
});
|
|
56
|
+
}
|
|
57
|
+
}
|
|
58
|
+
ts.forEachChild(node, visit);
|
|
59
|
+
}
|
|
60
|
+
visit(source);
|
|
61
|
+
return findings;
|
|
62
|
+
}
|
|
63
|
+
|
|
64
|
+
export const sharedErrorFindings = Effect.fn("SharedErrorClasses.sharedErrorFindings")(function* (inputs: RuleInputs) {
|
|
65
|
+
const sources = inputs.sources.filter((source) => /\.[cm]?[jt]sx?$/u.test(source.path) && /\bclass\b/u.test(source.text));
|
|
66
|
+
if (sources.length === 0) {
|
|
67
|
+
return [];
|
|
68
|
+
}
|
|
69
|
+
const modules = yield* Effect.promise(() => sharedErrorModules({ ...inputs, sources }));
|
|
70
|
+
if (modules.length === 0) {
|
|
71
|
+
return [];
|
|
72
|
+
}
|
|
73
|
+
const program = effectProgram(
|
|
74
|
+
{ ...inputs, sources },
|
|
75
|
+
true,
|
|
76
|
+
modules.map(({ file }) => file),
|
|
77
|
+
);
|
|
78
|
+
const checker = program.getTypeChecker();
|
|
79
|
+
const catalog = sharedCatalog(program, checker, modules);
|
|
80
|
+
return sources.flatMap((file) => {
|
|
81
|
+
const source = program.getSourceFile(join(inputs.root, file.path));
|
|
82
|
+
return source === undefined ? [] : classFindings(source, file.path, checker, catalog);
|
|
83
|
+
});
|
|
84
|
+
});
|
|
@@ -0,0 +1,81 @@
|
|
|
1
|
+
import { createRequire } from "node:module";
|
|
2
|
+
import { dirname, join, relative } from "node:path";
|
|
3
|
+
import { fileURLToPath } from "node:url";
|
|
4
|
+
import ts from "typescript";
|
|
5
|
+
import errorsPackage from "@shivaedev/errors/package.json" with { type: "json" };
|
|
6
|
+
import { type Project, projectsFor } from "#adapters/imports/projects.ts";
|
|
7
|
+
import { readPackageManifest } from "#adapters/manifestInventory.ts";
|
|
8
|
+
import { exportTargets } from "#imports/packageExports.ts";
|
|
9
|
+
import type { RuleInputs } from "#rule.ts";
|
|
10
|
+
|
|
11
|
+
export interface SharedErrorModule {
|
|
12
|
+
readonly file: string;
|
|
13
|
+
readonly specifier: string;
|
|
14
|
+
}
|
|
15
|
+
|
|
16
|
+
function targetFiles(directory: string, target: string): readonly string[] {
|
|
17
|
+
const [prefix = "", suffix] = target.split("*");
|
|
18
|
+
if (suffix === undefined) {
|
|
19
|
+
return [join(directory, target)];
|
|
20
|
+
}
|
|
21
|
+
return ts.sys.readDirectory(directory, [".ts", ".js", ".mts", ".cts"], ["node_modules"], ["**/*"]).filter((path) => {
|
|
22
|
+
const local = `./${relative(directory, path).replaceAll("\\", "/")}`;
|
|
23
|
+
return local.startsWith(prefix) && local.endsWith(suffix);
|
|
24
|
+
});
|
|
25
|
+
}
|
|
26
|
+
|
|
27
|
+
function moduleSpecifiers(directory: string, exports: object): readonly string[] {
|
|
28
|
+
const specifiers = new Set<string>();
|
|
29
|
+
for (const [key, value] of Object.entries(exports)) {
|
|
30
|
+
for (const target of exportTargets(value)) {
|
|
31
|
+
const [prefix = "", suffix] = target.split("*");
|
|
32
|
+
for (const path of targetFiles(directory, target)) {
|
|
33
|
+
const local = `./${relative(directory, path).replaceAll("\\", "/")}`;
|
|
34
|
+
const subpath = suffix === undefined ? key : key.replace("*", local.slice(prefix.length, local.length - suffix.length));
|
|
35
|
+
specifiers.add(`${errorsPackage.name}${subpath === "." ? "" : subpath.slice(1)}`);
|
|
36
|
+
}
|
|
37
|
+
}
|
|
38
|
+
}
|
|
39
|
+
return [...specifiers];
|
|
40
|
+
}
|
|
41
|
+
|
|
42
|
+
function resolveModules(specifiers: readonly string[], from: string, project: Project): readonly SharedErrorModule[] {
|
|
43
|
+
return specifiers.flatMap((specifier) => {
|
|
44
|
+
const resolved = ts.resolveModuleName(specifier, from, project.typesOptions, ts.sys, project.typesCache).resolvedModule;
|
|
45
|
+
return resolved !== undefined && /\.[cm]?tsx?$/u.test(resolved.resolvedFileName) ? [{ file: resolved.resolvedFileName, specifier }] : [];
|
|
46
|
+
});
|
|
47
|
+
}
|
|
48
|
+
|
|
49
|
+
export async function sharedErrorModules(inputs: RuleInputs): Promise<readonly SharedErrorModule[]> {
|
|
50
|
+
const projectOf = projectsFor(inputs.root);
|
|
51
|
+
const manifests = new Map<string, string>();
|
|
52
|
+
for (const source of inputs.sources) {
|
|
53
|
+
const from = join(inputs.root, source.path);
|
|
54
|
+
const project = projectOf(from);
|
|
55
|
+
const resolved = ts.resolveModuleName(
|
|
56
|
+
`${errorsPackage.name}/package.json`,
|
|
57
|
+
from,
|
|
58
|
+
project.typesOptions,
|
|
59
|
+
ts.sys,
|
|
60
|
+
project.typesCache,
|
|
61
|
+
).resolvedModule;
|
|
62
|
+
if (resolved !== undefined) {
|
|
63
|
+
manifests.set(resolved.resolvedFileName, from);
|
|
64
|
+
}
|
|
65
|
+
}
|
|
66
|
+
if (manifests.size === 0) {
|
|
67
|
+
manifests.set(createRequire(import.meta.url).resolve(`${errorsPackage.name}/package.json`), fileURLToPath(import.meta.url));
|
|
68
|
+
}
|
|
69
|
+
const modules = new Map<string, SharedErrorModule>();
|
|
70
|
+
for (const [manifestPath, from] of manifests) {
|
|
71
|
+
const manifest = await readPackageManifest(inputs.readText, relative(inputs.root, manifestPath));
|
|
72
|
+
const exports = manifest?.exports;
|
|
73
|
+
if (typeof exports !== "object" || exports === null || Array.isArray(exports)) {
|
|
74
|
+
continue;
|
|
75
|
+
}
|
|
76
|
+
for (const module of resolveModules(moduleSpecifiers(dirname(manifestPath), exports), from, projectOf(from))) {
|
|
77
|
+
modules.set(module.file, module);
|
|
78
|
+
}
|
|
79
|
+
}
|
|
80
|
+
return [...modules.values()];
|
|
81
|
+
}
|
|
@@ -57,11 +57,16 @@ export function testProjects(options: TestProjectsOptions = {}): TestUserConfig
|
|
|
57
57
|
...(coverage === true ? {} : coverage),
|
|
58
58
|
},
|
|
59
59
|
}),
|
|
60
|
-
project: ["unit", "pure", "dom"],
|
|
60
|
+
project: ["unit", "pure", "dom", "heavy"],
|
|
61
61
|
projects: [
|
|
62
62
|
{
|
|
63
63
|
extends: true,
|
|
64
|
-
test: {
|
|
64
|
+
test: {
|
|
65
|
+
environment: "node",
|
|
66
|
+
exclude: excluding(named("dom"), named("slow"), named("unit"), named("heavy")),
|
|
67
|
+
include: [named()],
|
|
68
|
+
name: "unit",
|
|
69
|
+
},
|
|
65
70
|
},
|
|
66
71
|
{
|
|
67
72
|
extends: true,
|
|
@@ -82,6 +87,17 @@ export function testProjects(options: TestProjectsOptions = {}): TestUserConfig
|
|
|
82
87
|
name: "dom",
|
|
83
88
|
},
|
|
84
89
|
},
|
|
90
|
+
{
|
|
91
|
+
extends: true,
|
|
92
|
+
test: {
|
|
93
|
+
environment: "node",
|
|
94
|
+
exclude: excluding(),
|
|
95
|
+
include: [named("heavy")],
|
|
96
|
+
maxWorkers: 1,
|
|
97
|
+
name: "heavy",
|
|
98
|
+
sequence: { groupOrder: 1 },
|
|
99
|
+
},
|
|
100
|
+
},
|
|
85
101
|
{ extends: true, test: { environment: "node", exclude: excluding(), include: [named("slow")], name: "slow" } },
|
|
86
102
|
],
|
|
87
103
|
...output,
|
package/src/appTestConfig.ts
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
import { defineConfig } from "vitest/config";
|
|
2
2
|
import { type TestProjectsOptions, testProjects } from "#adapters/testProjects.ts";
|
|
3
3
|
|
|
4
|
-
export function appTestConfig(conditions: string[] = [], options:
|
|
4
|
+
export function appTestConfig(conditions: string[] = [], options: TestProjectsOptions = {}) {
|
|
5
5
|
return defineConfig({
|
|
6
6
|
resolve: { conditions: [...conditions, "module", "browser", "development|production"] },
|
|
7
7
|
ssr: { resolve: { conditions: [...conditions, "node", "development|production"] } },
|
|
@@ -1,8 +1,4 @@
|
|
|
1
|
-
import { join } from "node:path";
|
|
2
|
-
import { Effect, Schema } from "effect";
|
|
3
1
|
import type { ExceptionDeclaration } from "#exceptions/declaration.ts";
|
|
4
|
-
import { readOptionalText } from "#inventory/filesystem.ts";
|
|
5
|
-
import { parseConfig, relocateConfig } from "./relocateConfig.ts";
|
|
6
2
|
|
|
7
3
|
function nativeOverride(files: readonly string[], rule: string): unknown {
|
|
8
4
|
const [, tool, group = "", name = ""] = rule.split("/");
|
|
@@ -23,42 +19,3 @@ export function exceptionConfig(declarations: readonly ExceptionDeclaration[]):
|
|
|
23
19
|
),
|
|
24
20
|
};
|
|
25
21
|
}
|
|
26
|
-
|
|
27
|
-
export const withExceptionConfig = Effect.fn("Biome.withExceptionConfig")(function* <TValue, TError, TRequirements>(
|
|
28
|
-
root: string,
|
|
29
|
-
declarations: readonly ExceptionDeclaration[],
|
|
30
|
-
run: (args: readonly string[]) => Effect.Effect<TValue, TError, TRequirements>,
|
|
31
|
-
) {
|
|
32
|
-
const { includes, overrides } = exceptionConfig(declarations);
|
|
33
|
-
if (includes.length === 0 && overrides.length === 0) {
|
|
34
|
-
return yield* run([]);
|
|
35
|
-
}
|
|
36
|
-
const { config, text } = yield* Effect.gen(function* () {
|
|
37
|
-
for (const candidate of ["biome.json", "biome.jsonc"]) {
|
|
38
|
-
const content = yield* readOptionalText(join(root, candidate));
|
|
39
|
-
if (content !== undefined) {
|
|
40
|
-
return { config: candidate, text: content };
|
|
41
|
-
}
|
|
42
|
-
}
|
|
43
|
-
return { config: "biome.json", text: "{}" };
|
|
44
|
-
});
|
|
45
|
-
const own = yield* parseConfig(config, text);
|
|
46
|
-
const files = Schema.is(Schema.Record(Schema.String, Schema.Unknown))(own.files) ? own.files : {};
|
|
47
|
-
if (
|
|
48
|
-
(own.files !== undefined && !Schema.is(Schema.Record(Schema.String, Schema.Unknown))(own.files))
|
|
49
|
-
|| (files.includes !== undefined && !Array.isArray(files.includes))
|
|
50
|
-
|| (own.overrides !== undefined && !Array.isArray(own.overrides))
|
|
51
|
-
) {
|
|
52
|
-
return yield* Effect.die(new Error(`Cannot merge exceptions into invalid ${config}: files, includes or overrides has the wrong shape.`));
|
|
53
|
-
}
|
|
54
|
-
const previousIncludes = Array.isArray(files.includes) ? files.includes : ["**"];
|
|
55
|
-
const previousOverrides = Array.isArray(own.overrides) ? own.overrides : [];
|
|
56
|
-
// Biome also matches a wildcard-led glob such as `!**/.worktrees` against the folders above the root, which ignores a whole linked worktree.
|
|
57
|
-
const generated = {
|
|
58
|
-
...own,
|
|
59
|
-
files: { ...files, includes: [...previousIncludes, ...includes.filter((pattern) => pattern !== "**"), "!.worktrees", "!.quality-biome-*"] },
|
|
60
|
-
overrides: [...previousOverrides, ...overrides],
|
|
61
|
-
};
|
|
62
|
-
const path = yield* relocateConfig(root, join(root, config), generated);
|
|
63
|
-
return yield* run([`--config-path=${path}`]);
|
|
64
|
-
});
|
|
@@ -1,8 +1,9 @@
|
|
|
1
1
|
import { resolve } from "node:path";
|
|
2
2
|
import ts from "typescript";
|
|
3
|
+
import { syntaxOf } from "#adapters/biome/syntaxOf.ts";
|
|
3
4
|
import { nativeEffectCall } from "./nativeEffectCall.ts";
|
|
4
5
|
import type { Diagnostic } from "./report.ts";
|
|
5
|
-
import { nodeAt, offsetOf, type Syntax
|
|
6
|
+
import { nodeAt, offsetOf, type Syntax } from "./syntax.ts";
|
|
6
7
|
|
|
7
8
|
const RECOGNIZED: ReadonlySet<string> = new Set(["lint/correctness/noComponentHookFactories", "lint/style/noDoneCallback"]);
|
|
8
9
|
|
package/src/biome/syntax.ts
CHANGED
|
@@ -1,4 +1,3 @@
|
|
|
1
|
-
import { readFileSync } from "node:fs";
|
|
2
1
|
import ts from "typescript";
|
|
3
2
|
|
|
4
3
|
export interface Syntax {
|
|
@@ -6,15 +5,6 @@ export interface Syntax {
|
|
|
6
5
|
readonly source: ts.SourceFile;
|
|
7
6
|
}
|
|
8
7
|
|
|
9
|
-
export function syntaxOf(path: string): Syntax {
|
|
10
|
-
const source = ts.createSourceFile(path, readFileSync(path, "utf8"), ts.ScriptTarget.Latest, true);
|
|
11
|
-
const options: ts.CompilerOptions = { allowJs: true, noLib: true, noResolve: true };
|
|
12
|
-
const host = ts.createCompilerHost(options);
|
|
13
|
-
host.getSourceFile = (file) => (file === path ? source : undefined);
|
|
14
|
-
const program = ts.createProgram([path], options, host);
|
|
15
|
-
return { checker: program.getTypeChecker(), source };
|
|
16
|
-
}
|
|
17
|
-
|
|
18
8
|
export function offsetOf(source: ts.SourceFile, position: { readonly line: number; readonly column?: number }): number | undefined {
|
|
19
9
|
const start = source.getLineStarts()[position.line - 1];
|
|
20
10
|
if (start === undefined || position.column === undefined || position.column < 1) {
|