@selesai/code 0.9.6 → 0.9.8

package/dist/extensions/pi-intercom/broker/framing.test.ts

@@ -1,114 +1,114 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { createMessageReader, writeMessage } from "./framing.ts";
-
-function framePayload(payload: Buffer): Buffer {
-  const header = Buffer.alloc(4);
-  header.writeUInt32BE(payload.length, 0);
-  return Buffer.concat([header, payload]);
-}
-
-test("createMessageReader handles normal fragmented frames", () => {
-  const messages: unknown[] = [];
-  const errors: Error[] = [];
-  const reader = createMessageReader(
-    (message) => messages.push(message),
-    (error) => errors.push(error),
-    64,
-  );
-  const frameA = framePayload(Buffer.from(JSON.stringify({ type: "one" }), "utf-8"));
-  const frameB = framePayload(Buffer.from(JSON.stringify({ type: "two" }), "utf-8"));
-  const combined = Buffer.concat([frameA, frameB]);
-
-  reader(combined.subarray(0, 2));
-  reader(combined.subarray(2, 7));
-  reader(combined.subarray(7));
-
-  assert.deepEqual(messages, [{ type: "one" }, { type: "two" }]);
-  assert.deepEqual(errors, []);
-});
-
-test("createMessageReader reassembles a fragmented frame after a header-boundary fast-path frame", () => {
-  const messages: unknown[] = [];
-  const errors: Error[] = [];
-  const reader = createMessageReader(
-    (message) => messages.push(message),
-    (error) => errors.push(error),
-    64,
-  );
-  const frameA = framePayload(Buffer.from(JSON.stringify({ a: 1 }), "utf-8"));
-  const frameB = framePayload(Buffer.from(JSON.stringify({ bb: "1234567890" }), "utf-8"));
-
-  reader(frameA.subarray(0, 4)); // chunk ends exactly at the end of frame A's header
-  reader(frameA.subarray(4)); // frame A's payload arrives whole (zero-copy fast path)
-  reader(frameB.subarray(0, 6)); // frame B header + partial payload (buffered path)
-  reader(frameB.subarray(6));
-
-  assert.deepEqual(messages, [{ a: 1 }, { bb: "1234567890" }]);
-  assert.deepEqual(errors, []);
-});
-
-test("createMessageReader rejects an oversized declared frame", () => {
-  const messages: unknown[] = [];
-  const errors: Error[] = [];
-  const reader = createMessageReader(
-    (message) => messages.push(message),
-    (error) => errors.push(error),
-    8,
-  );
-  const oversizedFrame = framePayload(Buffer.from(JSON.stringify({ text: "too large" }), "utf-8"));
-
-  reader(oversizedFrame);
-
-  assert.deepEqual(messages, []);
-  assert.equal(errors.length, 1);
-  assert.match(errors[0].message, /Intercom frame length \d+ exceeds maximum 8 bytes/);
-});
-
-test("createMessageReader rejects an oversized frame before retaining same-chunk payload bytes", () => {
-  const messages: unknown[] = [];
-  const errors: Error[] = [];
-  const reader = createMessageReader(
-    (message) => messages.push(message),
-    (error) => errors.push(error),
-    8,
-  );
-  const header = Buffer.alloc(4);
-  header.writeUInt32BE(9, 0);
-
-  reader(Buffer.concat([header, Buffer.alloc(1024 * 1024)]));
-
-  assert.deepEqual(messages, []);
-  assert.equal(errors.length, 1);
-  assert.equal(errors[0].message, "Intercom frame length 9 exceeds maximum 8 bytes");
-});
-
-test("createMessageReader rejects a partial oversized frame before buffering the payload", () => {
-  const messages: unknown[] = [];
-  const errors: Error[] = [];
-  const reader = createMessageReader(
-    (message) => messages.push(message),
-    (error) => errors.push(error),
-    8,
-  );
-  const header = Buffer.alloc(4);
-  header.writeUInt32BE(9, 0);
-
-  reader(header);
-
-  assert.deepEqual(messages, []);
-  assert.equal(errors.length, 1);
-  assert.equal(errors[0].message, "Intercom frame length 9 exceeds maximum 8 bytes");
-});
-
-test("writeMessage emits frames accepted by createMessageReader", () => {
-  const chunks: Buffer[] = [];
-  const socket = { write: (chunk: Buffer) => chunks.push(chunk) };
-  const messages: unknown[] = [];
-  const reader = createMessageReader((message) => messages.push(message), assert.fail, 64);
-
-  writeMessage(socket as never, { ok: true });
-  reader(Buffer.concat(chunks));
-
-  assert.deepEqual(messages, [{ ok: true }]);
-});
+import test from "node:test";
+import assert from "node:assert/strict";
+import { createMessageReader, writeMessage } from "./framing.ts";
+
+function framePayload(payload: Buffer): Buffer {
+  const header = Buffer.alloc(4);
+  header.writeUInt32BE(payload.length, 0);
+  return Buffer.concat([header, payload]);
+}
+
+test("createMessageReader handles normal fragmented frames", () => {
+  const messages: unknown[] = [];
+  const errors: Error[] = [];
+  const reader = createMessageReader(
+    (message) => messages.push(message),
+    (error) => errors.push(error),
+    64,
+  );
+  const frameA = framePayload(Buffer.from(JSON.stringify({ type: "one" }), "utf-8"));
+  const frameB = framePayload(Buffer.from(JSON.stringify({ type: "two" }), "utf-8"));
+  const combined = Buffer.concat([frameA, frameB]);
+
+  reader(combined.subarray(0, 2));
+  reader(combined.subarray(2, 7));
+  reader(combined.subarray(7));
+
+  assert.deepEqual(messages, [{ type: "one" }, { type: "two" }]);
+  assert.deepEqual(errors, []);
+});
+
+test("createMessageReader reassembles a fragmented frame after a header-boundary fast-path frame", () => {
+  const messages: unknown[] = [];
+  const errors: Error[] = [];
+  const reader = createMessageReader(
+    (message) => messages.push(message),
+    (error) => errors.push(error),
+    64,
+  );
+  const frameA = framePayload(Buffer.from(JSON.stringify({ a: 1 }), "utf-8"));
+  const frameB = framePayload(Buffer.from(JSON.stringify({ bb: "1234567890" }), "utf-8"));
+
+  reader(frameA.subarray(0, 4)); // chunk ends exactly at the end of frame A's header
+  reader(frameA.subarray(4)); // frame A's payload arrives whole (zero-copy fast path)
+  reader(frameB.subarray(0, 6)); // frame B header + partial payload (buffered path)
+  reader(frameB.subarray(6));
+
+  assert.deepEqual(messages, [{ a: 1 }, { bb: "1234567890" }]);
+  assert.deepEqual(errors, []);
+});
+
+test("createMessageReader rejects an oversized declared frame", () => {
+  const messages: unknown[] = [];
+  const errors: Error[] = [];
+  const reader = createMessageReader(
+    (message) => messages.push(message),
+    (error) => errors.push(error),
+    8,
+  );
+  const oversizedFrame = framePayload(Buffer.from(JSON.stringify({ text: "too large" }), "utf-8"));
+
+  reader(oversizedFrame);
+
+  assert.deepEqual(messages, []);
+  assert.equal(errors.length, 1);
+  assert.match(errors[0].message, /Intercom frame length \d+ exceeds maximum 8 bytes/);
+});
+
+test("createMessageReader rejects an oversized frame before retaining same-chunk payload bytes", () => {
+  const messages: unknown[] = [];
+  const errors: Error[] = [];
+  const reader = createMessageReader(
+    (message) => messages.push(message),
+    (error) => errors.push(error),
+    8,
+  );
+  const header = Buffer.alloc(4);
+  header.writeUInt32BE(9, 0);
+
+  reader(Buffer.concat([header, Buffer.alloc(1024 * 1024)]));
+
+  assert.deepEqual(messages, []);
+  assert.equal(errors.length, 1);
+  assert.equal(errors[0].message, "Intercom frame length 9 exceeds maximum 8 bytes");
+});
+
+test("createMessageReader rejects a partial oversized frame before buffering the payload", () => {
+  const messages: unknown[] = [];
+  const errors: Error[] = [];
+  const reader = createMessageReader(
+    (message) => messages.push(message),
+    (error) => errors.push(error),
+    8,
+  );
+  const header = Buffer.alloc(4);
+  header.writeUInt32BE(9, 0);
+
+  reader(header);
+
+  assert.deepEqual(messages, []);
+  assert.equal(errors.length, 1);
+  assert.equal(errors[0].message, "Intercom frame length 9 exceeds maximum 8 bytes");
+});
+
+test("writeMessage emits frames accepted by createMessageReader", () => {
+  const chunks: Buffer[] = [];
+  const socket = { write: (chunk: Buffer) => chunks.push(chunk) };
+  const messages: unknown[] = [];
+  const reader = createMessageReader((message) => messages.push(message), assert.fail, 64);
+
+  writeMessage(socket as never, { ok: true });
+  reader(Buffer.concat(chunks));
+
+  assert.deepEqual(messages, [{ ok: true }]);
+});

package/dist/extensions/pi-intercom/broker/paths.test.ts

@@ -1,153 +1,153 @@
-import test from "node:test";
-import assert from "node:assert/strict";
-import { chmodSync, mkdtempSync, rmSync, statSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { getAgentDir } from "@selesai/code";
-import {
-  ensureIntercomRuntimeDir,
-  getAgentDirPath,
-  getBrokerConnectTarget,
-  getBrokerListenTarget,
-  getBrokerPortFilePath,
-  getBrokerSocketPath,
-  getIntercomDirPath,
-  INTERCOM_DIR_MODE,
-  INTERCOM_RUNTIME_FILE_MODE,
-  INTERCOM_TCP_HOST,
-  restrictIntercomRuntimeFile,
-  shouldUseWindowsTcpTransport,
-} from "./paths.ts";
-
-test("getAgentDirPath defaults to Selesai's configured agent directory", () => {
-  assert.equal(getAgentDirPath({}), getAgentDir());
-});
-
-test("getAgentDirPath honors SELESAI_CODING_AGENT_DIR", () => {
-  assert.equal(getAgentDirPath({ SELESAI_CODING_AGENT_DIR: "/tmp/selesai-agent" }), "/tmp/selesai-agent");
-});
-
-test("getAgentDirPath resolves relative SELESAI_CODING_AGENT_DIR values from the caller cwd", () => {
-  const cwd = join(tmpdir(), "workspace", "project");
-  assert.equal(
-    getAgentDirPath({ SELESAI_CODING_AGENT_DIR: "relative-agent" }, cwd),
-    join(cwd, "relative-agent"),
-  );
-});
-
-test("getIntercomDirPath points at the intercom runtime directory under the agent dir", () => {
-  assert.equal(getIntercomDirPath("/tmp/selesai-agent"), join("/tmp/selesai-agent", "intercom"));
-});
-
-test("getBrokerSocketPath uses named pipe on Windows", () => {
-  const pipePath = getBrokerSocketPath("win32", "C:/Users/rcroh/.selesai/agent");
-  assert.match(pipePath, /^\\\\\.\\pipe\\pi-intercom-/);
-  assert.doesNotMatch(pipePath, /broker\.sock$/);
-});
-
-test("getBrokerSocketPath uses broker.sock under SELESAI_CODING_AGENT_DIR on non-Windows", () => {
-  const socketPath = getBrokerSocketPath("linux", "/tmp/selesai-agent");
-  assert.equal(socketPath, join("/tmp/selesai-agent", "intercom", "broker.sock"));
-});
-
-test("Windows TCP transport is opt-in", () => {
-  assert.equal(shouldUseWindowsTcpTransport("win32", {}), false);
-  assert.equal(shouldUseWindowsTcpTransport("win32", { PI_INTERCOM_TRANSPORT: "tcp" }), true);
-  assert.equal(shouldUseWindowsTcpTransport("win32", { PI_INTERCOM_TCP: "1" }), true);
-  assert.equal(shouldUseWindowsTcpTransport("linux", { PI_INTERCOM_TRANSPORT: "tcp" }), false);
-});
-
-test("getBrokerListenTarget uses dynamic localhost TCP only when opted in on Windows", () => {
-  assert.deepEqual(getBrokerListenTarget("win32", { PI_INTERCOM_TRANSPORT: "tcp" }), {
-    transport: "tcp",
-    host: INTERCOM_TCP_HOST,
-    port: 0,
-  });
-  assert.equal(getBrokerListenTarget("win32", {}), getBrokerSocketPath("win32", getAgentDirPath({})));
-});
-
-test("getBrokerConnectTarget reads opt-in Windows TCP endpoint from intercom state", () => {
-  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
-  const intercomDir = join(root, "intercom");
-
-  try {
-    ensureIntercomRuntimeDir(intercomDir, "win32");
-    writeFileSync(getBrokerPortFilePath(intercomDir), JSON.stringify({
-      transport: "tcp",
-      host: "127.0.0.1",
-      port: 41234,
-      stateId: "state-1",
-    }));
-    assert.deepEqual(getBrokerConnectTarget("win32", { PI_INTERCOM_TRANSPORT: "tcp" }, intercomDir), {
-      transport: "tcp",
-      host: "127.0.0.1",
-      port: 41234,
-      stateId: "state-1",
-    });
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("getBrokerConnectTarget rejects non-local TCP endpoint hosts", () => {
-  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
-  const intercomDir = join(root, "intercom");
-
-  try {
-    ensureIntercomRuntimeDir(intercomDir, "win32");
-    writeFileSync(getBrokerPortFilePath(intercomDir), JSON.stringify({
-      transport: "tcp",
-      host: "10.0.0.5",
-      port: 41234,
-      stateId: "state-1",
-    }));
-    assert.throws(
-      () => getBrokerConnectTarget("win32", { PI_INTERCOM_TRANSPORT: "tcp" }, intercomDir),
-      /Invalid intercom TCP endpoint/,
-    );
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("ensureIntercomRuntimeDir creates and repairs restrictive Unix directory permissions", { skip: process.platform === "win32" }, () => {
-  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
-  const intercomDir = join(root, "intercom");
-
-  try {
-    ensureIntercomRuntimeDir(intercomDir, "linux");
-    assert.equal(statSync(intercomDir).mode & 0o777, INTERCOM_DIR_MODE);
-
-    chmodSync(intercomDir, 0o755);
-    ensureIntercomRuntimeDir(intercomDir, "linux");
-    assert.equal(statSync(intercomDir).mode & 0o777, INTERCOM_DIR_MODE);
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("restrictIntercomRuntimeFile applies restrictive Unix file permissions", { skip: process.platform === "win32" }, () => {
-  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
-  const filePath = join(root, "broker.pid");
-
-  try {
-    writeFileSync(filePath, "123", { mode: 0o644 });
-    restrictIntercomRuntimeFile(filePath, "linux");
-    assert.equal(statSync(filePath).mode & 0o777, INTERCOM_RUNTIME_FILE_MODE);
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
-
-test("runtime permission helpers skip chmod on Windows paths", () => {
-  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
-  const filePath = join(root, "broker.pid");
-
-  try {
-    ensureIntercomRuntimeDir(root, "win32");
-    writeFileSync(filePath, "123");
-    assert.doesNotThrow(() => restrictIntercomRuntimeFile(filePath, "win32"));
-  } finally {
-    rmSync(root, { recursive: true, force: true });
-  }
-});
+import test from "node:test";
+import assert from "node:assert/strict";
+import { chmodSync, mkdtempSync, rmSync, statSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { getAgentDir } from "@selesai/code";
+import {
+  ensureIntercomRuntimeDir,
+  getAgentDirPath,
+  getBrokerConnectTarget,
+  getBrokerListenTarget,
+  getBrokerPortFilePath,
+  getBrokerSocketPath,
+  getIntercomDirPath,
+  INTERCOM_DIR_MODE,
+  INTERCOM_RUNTIME_FILE_MODE,
+  INTERCOM_TCP_HOST,
+  restrictIntercomRuntimeFile,
+  shouldUseWindowsTcpTransport,
+} from "./paths.ts";
+
+test("getAgentDirPath defaults to Selesai's configured agent directory", () => {
+  assert.equal(getAgentDirPath({}), getAgentDir());
+});
+
+test("getAgentDirPath honors SELESAI_CODING_AGENT_DIR", () => {
+  assert.equal(getAgentDirPath({ SELESAI_CODING_AGENT_DIR: "/tmp/selesai-agent" }), "/tmp/selesai-agent");
+});
+
+test("getAgentDirPath resolves relative SELESAI_CODING_AGENT_DIR values from the caller cwd", () => {
+  const cwd = join(tmpdir(), "workspace", "project");
+  assert.equal(
+    getAgentDirPath({ SELESAI_CODING_AGENT_DIR: "relative-agent" }, cwd),
+    join(cwd, "relative-agent"),
+  );
+});
+
+test("getIntercomDirPath points at the intercom runtime directory under the agent dir", () => {
+  assert.equal(getIntercomDirPath("/tmp/selesai-agent"), join("/tmp/selesai-agent", "intercom"));
+});
+
+test("getBrokerSocketPath uses named pipe on Windows", () => {
+  const pipePath = getBrokerSocketPath("win32", "C:/Users/rcroh/.selesai/agent");
+  assert.match(pipePath, /^\\\\\.\\pipe\\pi-intercom-/);
+  assert.doesNotMatch(pipePath, /broker\.sock$/);
+});
+
+test("getBrokerSocketPath uses broker.sock under SELESAI_CODING_AGENT_DIR on non-Windows", () => {
+  const socketPath = getBrokerSocketPath("linux", "/tmp/selesai-agent");
+  assert.equal(socketPath, join("/tmp/selesai-agent", "intercom", "broker.sock"));
+});
+
+test("Windows TCP transport is opt-in", () => {
+  assert.equal(shouldUseWindowsTcpTransport("win32", {}), false);
+  assert.equal(shouldUseWindowsTcpTransport("win32", { PI_INTERCOM_TRANSPORT: "tcp" }), true);
+  assert.equal(shouldUseWindowsTcpTransport("win32", { PI_INTERCOM_TCP: "1" }), true);
+  assert.equal(shouldUseWindowsTcpTransport("linux", { PI_INTERCOM_TRANSPORT: "tcp" }), false);
+});
+
+test("getBrokerListenTarget uses dynamic localhost TCP only when opted in on Windows", () => {
+  assert.deepEqual(getBrokerListenTarget("win32", { PI_INTERCOM_TRANSPORT: "tcp" }), {
+    transport: "tcp",
+    host: INTERCOM_TCP_HOST,
+    port: 0,
+  });
+  assert.equal(getBrokerListenTarget("win32", {}), getBrokerSocketPath("win32", getAgentDirPath({})));
+});
+
+test("getBrokerConnectTarget reads opt-in Windows TCP endpoint from intercom state", () => {
+  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
+  const intercomDir = join(root, "intercom");
+
+  try {
+    ensureIntercomRuntimeDir(intercomDir, "win32");
+    writeFileSync(getBrokerPortFilePath(intercomDir), JSON.stringify({
+      transport: "tcp",
+      host: "127.0.0.1",
+      port: 41234,
+      stateId: "state-1",
+    }));
+    assert.deepEqual(getBrokerConnectTarget("win32", { PI_INTERCOM_TRANSPORT: "tcp" }, intercomDir), {
+      transport: "tcp",
+      host: "127.0.0.1",
+      port: 41234,
+      stateId: "state-1",
+    });
+  } finally {
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test("getBrokerConnectTarget rejects non-local TCP endpoint hosts", () => {
+  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
+  const intercomDir = join(root, "intercom");
+
+  try {
+    ensureIntercomRuntimeDir(intercomDir, "win32");
+    writeFileSync(getBrokerPortFilePath(intercomDir), JSON.stringify({
+      transport: "tcp",
+      host: "10.0.0.5",
+      port: 41234,
+      stateId: "state-1",
+    }));
+    assert.throws(
+      () => getBrokerConnectTarget("win32", { PI_INTERCOM_TRANSPORT: "tcp" }, intercomDir),
+      /Invalid intercom TCP endpoint/,
+    );
+  } finally {
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test("ensureIntercomRuntimeDir creates and repairs restrictive Unix directory permissions", { skip: process.platform === "win32" }, () => {
+  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
+  const intercomDir = join(root, "intercom");
+
+  try {
+    ensureIntercomRuntimeDir(intercomDir, "linux");
+    assert.equal(statSync(intercomDir).mode & 0o777, INTERCOM_DIR_MODE);
+
+    chmodSync(intercomDir, 0o755);
+    ensureIntercomRuntimeDir(intercomDir, "linux");
+    assert.equal(statSync(intercomDir).mode & 0o777, INTERCOM_DIR_MODE);
+  } finally {
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test("restrictIntercomRuntimeFile applies restrictive Unix file permissions", { skip: process.platform === "win32" }, () => {
+  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
+  const filePath = join(root, "broker.pid");
+
+  try {
+    writeFileSync(filePath, "123", { mode: 0o644 });
+    restrictIntercomRuntimeFile(filePath, "linux");
+    assert.equal(statSync(filePath).mode & 0o777, INTERCOM_RUNTIME_FILE_MODE);
+  } finally {
+    rmSync(root, { recursive: true, force: true });
+  }
+});
+
+test("runtime permission helpers skip chmod on Windows paths", () => {
+  const root = mkdtempSync(join(tmpdir(), "pi-intercom-paths-"));
+  const filePath = join(root, "broker.pid");
+
+  try {
+    ensureIntercomRuntimeDir(root, "win32");
+    writeFileSync(filePath, "123");
+    assert.doesNotThrow(() => restrictIntercomRuntimeFile(filePath, "win32"));
+  } finally {
+    rmSync(root, { recursive: true, force: true });
+  }
+});