@selesai/code 0.8.3 → 0.8.4

package/dist/extensions/pi-subagents/test/unit/async-interrupt-action.test.ts

@@ -3,8 +3,11 @@ import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
 import { describe, it } from "node:test";
-import { consumeSteerRequests } from "../../src/runs/background/control-channel.ts";
+import { consumeSteerRequests, consumeSteerRequestsFromDir, stepSteerInboxDir, writeSteerAck } from "../../src/runs/background/control-channel.ts";
+import { listAsyncRuns } from "../../src/runs/background/async-status.ts";
+import { inspectSubagentStatus } from "../../src/runs/background/run-status.ts";
 import { createSubagentExecutor } from "../../src/runs/foreground/subagent-executor.ts";
+import { steerWorkflowForegroundTarget, workflowForegroundSteeringDir } from "../../src/runs/foreground/workflow-foreground-steering.ts";
 import { ASYNC_DIR, RESULTS_DIR, type SubagentState } from "../../src/shared/types.ts";
 
 function createState(): SubagentState {
@@ -31,19 +34,19 @@ function writeJson(filePath: string, value: object): void {
 	fs.writeFileSync(filePath, JSON.stringify(value, null, 2), "utf-8");
 }
 
-function createRunningAsync(state: SubagentState, runId: string, options: { track?: boolean; sessionId?: string; state?: "queued" | "running"; pid?: number } = {}): string {
+function createRunningAsync(state: SubagentState, runId: string, options: { track?: boolean; sessionId?: string; state?: "queued" | "running"; pid?: number; mode?: "single" | "workflow" } = {}): string {
 	const asyncDir = path.join(ASYNC_DIR, runId);
 	const runState = options.state ?? "running";
 	writeJson(path.join(asyncDir, "status.json"), {
 		runId,
-		mode: "single",
+		mode: options.mode ?? "single",
 		state: runState,
 		sessionId: options.sessionId ?? "session",
 		...(options.pid !== undefined ? { pid: options.pid } : runState === "running" ? { pid: 12345 } : {}),
 		cwd: os.tmpdir(),
 		startedAt: 100,
 		lastUpdate: Date.now(),
-		steps: [{ agent: "builder", status: "running", startedAt: 100 }],
+		steps: [{ agent: "worker", status: "running", startedAt: 100 }],
 	});
 	if (options.track !== false) {
 		state.asyncJobs.set(runId, {
@@ -51,7 +54,7 @@ function createRunningAsync(state: SubagentState, runId: string, options: { trac
 			asyncDir,
 			status: "running",
 			pid: 12345,
-			agents: ["builder"],
+			agents: ["worker"],
 			updatedAt: 100,
 		});
 	}
@@ -63,7 +66,37 @@ function cleanup(runId: string, asyncDir: string): void {
 	fs.rmSync(path.join(RESULTS_DIR, `${runId}.json`), { force: true });
 }
 
-function executorWithKill(state: SubagentState, kill: (pid: number, signal?: NodeJS.Signals | 0) => boolean) {
+function createWorkflowForegroundControl(state: SubagentState, workflowRunId: string, childRunId: string): string {
+	const routeDir = workflowForegroundSteeringDir(ASYNC_DIR, workflowRunId, childRunId);
+	state.workflowControllers ??= new Map();
+	state.workflowControllers.set(workflowRunId, new AbortController());
+	state.foregroundControls.set(childRunId, {
+		runId: childRunId,
+		parentWorkflowRunId: workflowRunId,
+		workflowKey: childRunId,
+		workflowSteeringDir: routeDir,
+		sessionId: "session",
+		mode: "single",
+		startedAt: 100,
+		updatedAt: 100,
+		activeChildren: new Map([[0, { index: 0, agent: "worker", startedAt: 100, updatedAt: 100 }]]),
+		schedulingOwners: 1,
+	});
+	fs.mkdirSync(stepSteerInboxDir(routeDir, 0), { recursive: true });
+	return routeDir;
+}
+
+async function waitUntil<T>(read: () => T | undefined, timeoutMs = 5_000): Promise<T> {
+	const deadline = Date.now() + timeoutMs;
+	while (Date.now() <= deadline) {
+		const value = read();
+		if (value !== undefined) return value;
+		await new Promise((resolve) => setTimeout(resolve, 5));
+	}
+	throw new Error("Timed out waiting for async control test condition.");
+}
+
+function executorWithKill(state: SubagentState, kill: (pid: number, signal?: NodeJS.Signals | 0) => boolean, options: { allowMutatingManagementActions?: boolean } = {}) {
 	return createSubagentExecutor({
 		pi: { events: { emit() {}, on() { return () => {}; } }, getSessionName() { return "parent"; } } as any,
 		state,
@@ -74,6 +107,7 @@ function executorWithKill(state: SubagentState, kill: (pid: number, signal?: Nod
 		expandTilde: (value) => value,
 		discoverAgents: () => ({ agents: [] }),
 		kill,
+		...options,
 	});
 }
 
@@ -86,11 +120,177 @@ function ctx() {
 	} as any;
 }
 
-function text(result: Awaited<ReturnType<ReturnType<typeof executorWithKill>["execute"]>>): string {
-	return result.content[0]?.type === "text" ? result.content[0].text : "";
+function text(result: { content: Array<{ type: string; text?: string }> }): string {
+	return result.content[0]?.type === "text" ? result.content[0].text ?? "" : "";
 }
 
 describe("async interrupt action", () => {
+	it("steers a live workflow-owned foreground child by child id", async () => {
+		const state = createState();
+		const workflowRunId = `workflow-child-${Date.now().toString(36)}`;
+		const childRunId = `${workflowRunId}-child`;
+		const asyncDir = createRunningAsync(state, workflowRunId, { track: false, mode: "workflow" });
+		const routeDir = createWorkflowForegroundControl(state, workflowRunId, childRunId);
+		try {
+			const action = executorWithKill(state, () => true)
+				.execute("steer", { action: "steer", id: childRunId, message: "Focus on the failing test." }, new AbortController().signal, undefined, ctx());
+			const request = await waitUntil(() => {
+				const inbox = stepSteerInboxDir(routeDir, 0);
+				const entry = fs.existsSync(inbox) ? fs.readdirSync(inbox).find((name) => name.endsWith(".json")) : undefined;
+				return entry ? JSON.parse(fs.readFileSync(path.join(inbox, entry), "utf-8")) as { id: string; message: string } : undefined;
+			});
+			writeSteerAck(routeDir, { requestId: request.id, index: 0, ts: Date.now(), state: "delivered", message: "accepted" });
+			const result = await action;
+
+			assert.equal(result.isError, undefined);
+			assert.equal(result.details.steering?.state, "delivered");
+			assert.equal(result.details.steering?.sourceRunId, childRunId);
+			assert.equal(request.message, "Focus on the failing test.");
+		} finally {
+			cleanup(workflowRunId, asyncDir);
+		}
+	});
+
+	it("rejects a steer request when its workflow foreground route is already removed", async () => {
+		const state = createState();
+		const workflowRunId = `workflow-missing-route-${Date.now().toString(36)}`;
+		const childRunId = `${workflowRunId}-child`;
+		const asyncDir = createRunningAsync(state, workflowRunId, { track: false, mode: "workflow" });
+		const routeDir = createWorkflowForegroundControl(state, workflowRunId, childRunId);
+		try {
+			const control = state.foregroundControls.get(childRunId)!;
+			fs.rmSync(routeDir, { recursive: true, force: true });
+			const result = await steerWorkflowForegroundTarget({
+				target: { control, workflowRunId, sourceRunId: childRunId },
+				message: "Focus on the failing test.",
+				ackTimeoutMs: 40,
+			});
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /no live workflow steering route/);
+			assert.equal(result.details.steering, undefined);
+			assert.equal(fs.existsSync(routeDir), false);
+		} finally {
+			cleanup(workflowRunId, asyncDir);
+		}
+	});
+
+	it("rejects a steer request when its workflow foreground child inbox is missing", async () => {
+		const state = createState();
+		const workflowRunId = `workflow-missing-inbox-${Date.now().toString(36)}`;
+		const childRunId = `${workflowRunId}-child`;
+		const asyncDir = createRunningAsync(state, workflowRunId, { track: false, mode: "workflow" });
+		const routeDir = createWorkflowForegroundControl(state, workflowRunId, childRunId);
+		try {
+			const control = state.foregroundControls.get(childRunId)!;
+			fs.rmSync(stepSteerInboxDir(routeDir, 0), { recursive: true, force: true });
+			const result = await steerWorkflowForegroundTarget({
+				target: { control, workflowRunId, sourceRunId: childRunId },
+				message: "Focus on the failing test.",
+				ackTimeoutMs: 40,
+			});
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /no live workflow steering route/);
+			assert.equal(result.details.steering, undefined);
+			assert.equal(fs.existsSync(stepSteerInboxDir(routeDir, 0)), false);
+		} finally {
+			cleanup(workflowRunId, asyncDir);
+		}
+	});
+
+	it("rejects a steer request when its workflow foreground route is removed during the final acknowledgment wait", async () => {
+		const state = createState();
+		const workflowRunId = `workflow-removed-route-${Date.now().toString(36)}`;
+		const childRunId = `${workflowRunId}-child`;
+		const asyncDir = createRunningAsync(state, workflowRunId, { track: false, mode: "workflow" });
+		const routeDir = createWorkflowForegroundControl(state, workflowRunId, childRunId);
+		try {
+			const control = state.foregroundControls.get(childRunId)!;
+			const action = steerWorkflowForegroundTarget({
+				target: { control, workflowRunId, sourceRunId: childRunId },
+				message: "Focus on the failing test.",
+				ackTimeoutMs: 40,
+			});
+			await waitUntil(() => fs.existsSync(stepSteerInboxDir(routeDir, 0)) ? true : undefined);
+			fs.rmSync(routeDir, { recursive: true, force: true });
+			const result = await action;
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /no live child session/);
+			assert.equal(result.details.steering, undefined);
+		} finally {
+			cleanup(workflowRunId, asyncDir);
+		}
+	});
+
+	it("steers the unique live foreground child by workflow id and directory", async () => {
+		for (const target of ["id", "dir"] as const) {
+			const state = createState();
+			const workflowRunId = `workflow-${target}-${Date.now().toString(36)}`;
+			const childRunId = `${workflowRunId}-child`;
+			const asyncDir = createRunningAsync(state, workflowRunId, { track: false, mode: "workflow" });
+			const routeDir = createWorkflowForegroundControl(state, workflowRunId, childRunId);
+			try {
+				const controller = new AbortController();
+				setTimeout(() => controller.abort(), 10);
+				const params = target === "id"
+					? { action: "steer", id: workflowRunId, message: "Review the contract." }
+					: { action: "steer", dir: asyncDir, message: "Review the contract." };
+				const result = await executorWithKill(state, () => true)
+					.execute("steer", params, controller.signal, undefined, ctx());
+
+				assert.equal(result.isError, undefined);
+				assert.equal(result.details.steering?.sourceRunId, workflowRunId);
+				assert.equal(consumeSteerRequestsFromDir(stepSteerInboxDir(routeDir, 0))[0]?.message, "Review the contract.");
+			} finally {
+				cleanup(workflowRunId, asyncDir);
+			}
+		}
+	});
+
+	it("rejects ambiguous workflow steering without choosing a foreground child", async () => {
+		const state = createState();
+		const workflowRunId = `workflow-ambiguous-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, workflowRunId, { track: false, mode: "workflow" });
+		const firstRoute = createWorkflowForegroundControl(state, workflowRunId, `${workflowRunId}-one`);
+		const secondRoute = createWorkflowForegroundControl(state, workflowRunId, `${workflowRunId}-two`);
+		try {
+			const result = await executorWithKill(state, () => true)
+				.execute("steer", { action: "steer", id: workflowRunId, message: "Do not guess." }, new AbortController().signal, undefined, ctx());
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /2 live foreground children/);
+			assert.equal(consumeSteerRequestsFromDir(stepSteerInboxDir(firstRoute, 0)).length, 0);
+			assert.equal(consumeSteerRequestsFromDir(stepSteerInboxDir(secondRoute, 0)).length, 0);
+		} finally {
+			cleanup(workflowRunId, asyncDir);
+		}
+	});
+
+	it("rejects a terminal workflow instead of queuing to its outer inbox", async () => {
+		const state = createState();
+		const workflowRunId = `workflow-terminal-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, workflowRunId, { track: false, mode: "workflow" });
+		createWorkflowForegroundControl(state, workflowRunId, `${workflowRunId}-child`);
+		const statusPath = path.join(asyncDir, "status.json");
+		const status = JSON.parse(fs.readFileSync(statusPath, "utf-8"));
+		status.state = "complete";
+		status.endedAt = Date.now();
+		fs.writeFileSync(statusPath, JSON.stringify(status), "utf-8");
+		state.workflowControllers?.delete(workflowRunId);
+		try {
+			const result = await executorWithKill(state, () => true)
+				.execute("steer", { action: "steer", dir: asyncDir, message: "Too late." }, new AbortController().signal, undefined, ctx());
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /no live foreground child/);
+			assert.equal(fs.existsSync(path.join(asyncDir, "control", "steer-requests")), false);
+		} finally {
+			cleanup(workflowRunId, asyncDir);
+		}
+	});
+
 	it("queues steering for a running async child", async () => {
 		const state = createState();
 		const runId = `steer-disk-${Date.now().toString(36)}`;
@@ -180,7 +380,7 @@ describe("async interrupt action", () => {
 		}
 	});
 
-	it("interrupts a running async run resolved from disk after in-memory tracking is gone", async () => {
+	it("requests an interrupt without signaling a running async runner", async () => {
 		const state = createState();
 		const runId = `interrupt-disk-${Date.now().toString(36)}`;
 		const asyncDir = createRunningAsync(state, runId, { track: false });
@@ -194,7 +394,27 @@ describe("async interrupt action", () => {
 			assert.equal(result.isError, undefined);
 			assert.match(text(result), new RegExp(`Interrupt requested for async run ${runId}`));
 			assert.equal(fs.existsSync(path.join(asyncDir, "control", "interrupt.json")), true);
-			assert.deepEqual(kills, [{ pid: 12345, signal: 0 }, { pid: 12345, signal: process.platform === "win32" ? "SIGBREAK" : "SIGUSR2" }]);
+			assert.deepEqual(kills, [{ pid: 12345, signal: 0 }]);
+		} finally {
+			cleanup(runId, asyncDir);
+		}
+	});
+
+	it("rejects workflow interrupt instead of signaling a shared host pid", async () => {
+		const state = createState();
+		const runId = `interrupt-workflow-host-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, runId, { track: false, mode: "workflow", pid: process.pid });
+		try {
+			const kills: Array<{ pid: number; signal?: NodeJS.Signals | 0 }> = [];
+			const result = await executorWithKill(state, (pid, signal) => {
+				kills.push({ pid, signal });
+				return true;
+			}).execute("interrupt", { action: "interrupt", id: runId }, new AbortController().signal, undefined, ctx());
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), new RegExp(`Interrupt is unsupported for async workflow ${runId}; use stop instead\\.`));
+			assert.equal(fs.existsSync(path.join(asyncDir, "control", "interrupt.json")), false);
+			assert.deepEqual(kills, [{ pid: process.pid, signal: 0 }]);
 		} finally {
 			cleanup(runId, asyncDir);
 		}
@@ -222,26 +442,6 @@ describe("async interrupt action", () => {
 		}
 	});
 
-	it("reports success and writes the portable request when the signal is unavailable", async () => {
-		const state = createState();
-		const runId = `interrupt-enosys-${Date.now().toString(36)}`;
-		const asyncDir = createRunningAsync(state, runId);
-		try {
-			const result = await executorWithKill(state, (_pid, signal) => {
-				if (signal === 0) return true;
-				const error = new Error("kill ENOSYS") as NodeJS.ErrnoException;
-				error.code = "ENOSYS";
-				throw error;
-			}).execute("interrupt", { action: "interrupt", id: runId }, new AbortController().signal, undefined, ctx());
-
-			assert.equal(result.isError, undefined);
-			assert.match(text(result), new RegExp(`Interrupt requested for async run ${runId}`));
-			assert.equal(fs.existsSync(path.join(asyncDir, "control", "interrupt.json")), true);
-		} finally {
-			cleanup(runId, asyncDir);
-		}
-	});
-
 	it("stops a running async run resolved from disk", async () => {
 		const state = createState();
 		state.currentSessionId = "session";
@@ -263,6 +463,163 @@ describe("async interrupt action", () => {
 		}
 	});
 
+	it("dismisses only a reload-recovered running workflow without terminating work", async () => {
+		const state = createState();
+		state.currentSessionId = "session";
+		const runId = `dismiss-workflow-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, runId, { track: false, sessionId: "session", mode: "workflow" });
+		try {
+			const result = await executorWithKill(state, () => {
+				throw new Error("dismiss must not inspect or signal the workflow pid");
+			}).execute("dismiss", { action: "dismiss", id: runId }, new AbortController().signal, undefined, ctx());
+
+			assert.equal(result.isError, undefined);
+			assert.match(text(result), /Dismissed recovered workflow/);
+			assert.match(text(result), /No running work was terminated/);
+			const dismissed = JSON.parse(fs.readFileSync(path.join(asyncDir, "status.json"), "utf-8"));
+			assert.equal(dismissed.state, "running");
+			assert.equal(typeof dismissed.displayDismissedAt, "number");
+			assert.equal(listAsyncRuns(ASYNC_DIR, { states: ["running"], sessionId: "session", kill: () => {
+				throw new Error("dismissed workflow listing must not inspect the pid");
+			} }).some((run) => run.id === runId), false);
+			const statusResult = inspectSubagentStatus({ action: "status", id: runId }, { state, kill: () => {
+				throw new Error("dismissed workflow status must not inspect the pid");
+			} });
+			const statusText = text(statusResult);
+			assert.match(statusText, /State: display-dismissed/);
+			assert.match(statusText, /No running work was terminated/);
+			assert.doesNotMatch(statusText, /Steer/);
+			const transcriptResult = inspectSubagentStatus({ action: "status", id: runId, view: "transcript" }, { state, kill: () => {
+				throw new Error("dismissed workflow transcript must not inspect the pid");
+			} });
+			assert.doesNotMatch(text(transcriptResult), /Status file not found/);
+			const stopResult = await executorWithKill(state, () => {
+				throw new Error("dismissed workflow stop must not inspect or signal the pid");
+			}).execute("stop-dismissed", { action: "stop", id: runId }, new AbortController().signal, undefined, ctx());
+			assert.equal(stopResult.isError, true);
+			assert.doesNotMatch(text(stopResult), /Stop requested/);
+			assert.equal(fs.existsSync(path.join(asyncDir, "control", "stop.json")), false);
+			const stopDirResult = await executorWithKill(state, () => {
+				throw new Error("dismissed workflow stop by dir must not inspect or signal the pid");
+			}).execute("stop-dismissed-dir", { action: "stop", dir: asyncDir }, new AbortController().signal, undefined, ctx());
+			assert.equal(stopDirResult.isError, true);
+			assert.doesNotMatch(text(stopDirResult), /Stop requested/);
+			assert.equal(fs.existsSync(path.join(asyncDir, "control", "stop.json")), false);
+		} finally {
+			cleanup(runId, asyncDir);
+		}
+	});
+
+	it("rejects transcript view for display-dismissed workflows from another session", async () => {
+		const state = createState();
+		state.currentSessionId = "session";
+		const runId = `dismiss-other-session-transcript-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, runId, { track: false, sessionId: "other-session", mode: "workflow" });
+		try {
+			const statusPath = path.join(asyncDir, "status.json");
+			writeJson(statusPath, { ...JSON.parse(fs.readFileSync(statusPath, "utf-8")), displayDismissedAt: Date.now() });
+			fs.writeFileSync(path.join(asyncDir, "output-0.log"), "SECRET_OTHER_SESSION_OUTPUT", "utf-8");
+
+			const result = inspectSubagentStatus({ action: "status", id: runId, view: "transcript", index: 0 }, { state, kill: () => true });
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /owned by the current session/);
+			assert.doesNotMatch(text(result), /SECRET_OTHER_SESSION_OUTPUT/);
+		} finally {
+			cleanup(runId, asyncDir);
+		}
+	});
+
+	it("shows terminal status when a result appears after display dismissal", async () => {
+		const state = createState();
+		state.currentSessionId = "session";
+		const runId = `dismiss-then-complete-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, runId, { track: false, sessionId: "session", mode: "workflow" });
+		try {
+			const dismissResult = await executorWithKill(state, () => true).execute("dismiss", { action: "dismiss", id: runId }, new AbortController().signal, undefined, ctx());
+			assert.equal(dismissResult.isError, undefined);
+			writeJson(path.join(RESULTS_DIR, `${runId}.json`), { runId, mode: "workflow", success: true, results: [] });
+
+			const statusResult = inspectSubagentStatus({ action: "status", id: runId }, { state, kill: () => true });
+			const statusText = text(statusResult);
+			assert.match(statusText, /State: complete/);
+			assert.doesNotMatch(statusText, /State: display-dismissed/);
+			const status = JSON.parse(fs.readFileSync(path.join(asyncDir, "status.json"), "utf-8"));
+			assert.equal(status.state, "complete");
+			assert.equal(status.displayDismissedAt, undefined);
+		} finally {
+			cleanup(runId, asyncDir);
+		}
+	});
+
+	it("rejects dismiss when a stale running workflow has a terminal result", async () => {
+		const state = createState();
+		state.currentSessionId = "session";
+		const runId = `dismiss-terminal-result-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, runId, { track: false, sessionId: "session", mode: "workflow" });
+		writeJson(path.join(RESULTS_DIR, `${runId}.json`), { runId, mode: "workflow", success: true, results: [] });
+		try {
+			const result = await executorWithKill(state, () => {
+				throw new Error("terminal workflow dismiss must not inspect or signal the pid");
+			}).execute("dismiss-terminal-result", { action: "dismiss", id: runId }, new AbortController().signal, undefined, ctx());
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /complete, not running/);
+			const status = JSON.parse(fs.readFileSync(path.join(asyncDir, "status.json"), "utf-8"));
+			assert.equal(status.state, "complete");
+			assert.equal(status.displayDismissedAt, undefined);
+		} finally {
+			cleanup(runId, asyncDir);
+		}
+	});
+
+	it("rejects dismiss from child-safe fanout mode", async () => {
+		const state = createState();
+		state.currentSessionId = "session";
+		const runId = `dismiss-child-safe-${Date.now().toString(36)}`;
+		const asyncDir = createRunningAsync(state, runId, { track: false, sessionId: "session", mode: "workflow" });
+		try {
+			const result = await executorWithKill(state, () => true, { allowMutatingManagementActions: false })
+				.execute("dismiss-child-safe", { action: "dismiss", id: runId }, new AbortController().signal, undefined, ctx());
+
+			assert.equal(result.isError, true);
+			assert.match(text(result), /child-safe subagent fanout mode/);
+			assert.equal(JSON.parse(fs.readFileSync(path.join(asyncDir, "status.json"), "utf-8")).displayDismissedAt, undefined);
+		} finally {
+			cleanup(runId, asyncDir);
+		}
+	});
+
+	it("rejects dismiss for live-controller, non-workflow, terminal, and other-session runs", async () => {
+		const cases = [
+			{ name: "live", mode: "workflow" as const, sessionId: "session", state: "running" as const, controller: true, pattern: /live controller/ },
+			{ name: "non-workflow", mode: "single" as const, sessionId: "session", state: "running" as const, pattern: /not a recovered workflow/ },
+			{ name: "terminal", mode: "workflow" as const, sessionId: "session", state: "running" as const, terminal: true, pattern: /complete, not running/ },
+			{ name: "other-session", mode: "workflow" as const, sessionId: "other", state: "running" as const, pattern: /active session/ },
+		];
+		for (const candidate of cases) {
+			const state = createState();
+			state.currentSessionId = "session";
+			const runId = `dismiss-${candidate.name}-${Date.now().toString(36)}`;
+			const asyncDir = createRunningAsync(state, runId, { track: false, sessionId: candidate.sessionId, mode: candidate.mode });
+			if (candidate.controller) state.workflowControllers = new Map([[runId, new AbortController()]]);
+			if (candidate.terminal) {
+				const statusPath = path.join(asyncDir, "status.json");
+				writeJson(statusPath, { ...JSON.parse(fs.readFileSync(statusPath, "utf-8")), state: "complete" });
+			}
+			try {
+				const result = await executorWithKill(state, () => {
+					throw new Error("dismiss rejection must not inspect or signal pids");
+				}).execute("dismiss", { action: "dismiss", id: runId }, new AbortController().signal, undefined, ctx());
+				assert.equal(result.isError, true, candidate.name);
+				assert.match(text(result), candidate.pattern, candidate.name);
+				assert.equal(JSON.parse(fs.readFileSync(path.join(asyncDir, "status.json"), "utf-8")).displayDismissedAt, undefined, candidate.name);
+			} finally {
+				cleanup(runId, asyncDir);
+			}
+		}
+	});
+
 	it("does not stop a different async run when the requested id is missing", async () => {
 		const state = createState();
 		state.currentSessionId = "session";

package/dist/extensions/pi-subagents/test/unit/async-permission-session.test.ts

@@ -21,8 +21,8 @@ describe("async permission forwarding session identity", () => {
 	it("uses the parent session id for permission forwarding instead of the async status identity", () => {
 		const currentSessionId = path.join("/tmp", "parent-session.jsonl");
 		const built = buildAsyncRunnerSteps("run-abc", {
-			chain: [{ agent: "builder", task: "Do work" }],
-			agents: [makeAgent("builder")],
+			chain: [{ agent: "worker", task: "Do work" }],
+			agents: [makeAgent("worker")],
 			ctx: {
 				pi: {} as never,
 				cwd: "/tmp/project",
@@ -47,18 +47,18 @@ describe("async permission forwarding session identity", () => {
 				{ agent: "source", task: "produce targets", as: "targets" },
 				{
 					expand: { from: { output: "targets", path: "/items" }, maxItems: 2 },
-					parallel: { agent: "commentator", task: "Review {item.path}" },
+					parallel: { agent: "reviewer", task: "Review {item.path}" },
 					collect: { as: "reviews" },
 				},
-				{ agent: "builder", task: "Use reviews" },
+				{ agent: "worker", task: "Use reviews" },
 			],
-			agents: [makeAgent("source"), makeAgent("commentator"), { ...makeAgent("builder"), model: "anthropic/claude-sonnet-4-5:high", thinking: "high" }],
+			agents: [makeAgent("source"), makeAgent("reviewer"), { ...makeAgent("worker"), model: "anthropic/claude-sonnet-4-5:high", thinking: "high" }],
 			ctx: {
 				pi: {} as never,
 				cwd: "/tmp/project",
 				currentSessionId: "/tmp/parent-session.jsonl",
 			},
-			sessionFilesByFlatIndex: [undefined, "/tmp/dynamic-0.jsonl", "/tmp/dynamic-1.jsonl", "/tmp/static-builder.jsonl"],
+			sessionFilesByFlatIndex: [undefined, "/tmp/dynamic-0.jsonl", "/tmp/dynamic-1.jsonl", "/tmp/static-worker.jsonl"],
 			thinkingOverridesByFlatIndex: [undefined, "off", "off", "off"],
 			maxSubagentDepth: 1,
 			asyncDir: "/tmp/async-run",
@@ -71,15 +71,15 @@ describe("async permission forwarding session identity", () => {
 		assert.deepEqual(dynamic.thinkingOverrides, ["off", "off"]);
 		const staticWorker = built.steps[2];
 		assert.ok(staticWorker && !("parallel" in staticWorker));
-		assert.equal(staticWorker.sessionFile, "/tmp/static-builder.jsonl");
+		assert.equal(staticWorker.sessionFile, "/tmp/static-worker.jsonl");
 		assert.equal(staticWorker.model, "anthropic/claude-sonnet-4-5:off");
 		assert.equal(staticWorker.thinking, "off");
 	});
 
 	it("applies thinking overrides to async fallback candidates", () => {
 		const built = buildAsyncRunnerSteps("run-abc", {
-			chain: [{ agent: "builder", task: "Do work" }],
-			agents: [{ ...makeAgent("builder"), model: "openai/gpt-5-mini:high", fallbackModels: ["anthropic/claude-sonnet-4:low"], thinking: "high" }],
+			chain: [{ agent: "worker", task: "Do work" }],
+			agents: [{ ...makeAgent("worker"), model: "openai/gpt-5-mini:high", fallbackModels: ["anthropic/claude-sonnet-4:low"], thinking: "high" }],
 			ctx: {
 				pi: {} as never,
 				cwd: "/tmp/project",

package/dist/extensions/pi-subagents/test/unit/async-recovery-descriptor.test.ts

@@ -14,7 +14,7 @@ describe("async recovery descriptor", () => {
 				version: 1,
 				launchContractDigest: digest,
 				sourceRunId: "run-digest",
-				agent: "builder",
+				agent: "worker",
 				cwd: root,
 				systemPromptMode: "replace",
 				inheritProjectContext: false,
@@ -39,7 +39,7 @@ describe("async recovery descriptor", () => {
 				version: 1,
 				launchContractDigest: {},
 				sourceRunId: "run-digest",
-				agent: "builder",
+				agent: "worker",
 				cwd: root,
 				systemPromptMode: "replace",
 				inheritProjectContext: false,