@selesai/code 0.8.3 → 0.8.4

package/dist/extensions/pi-subagents/test/unit/agent-selection.test.ts

@@ -52,15 +52,15 @@ describe("mergeAgentsForScope", () => {
 	});
 
 	it("includes builtin agents when no user or project override exists", () => {
-		const builtinAgents = [makeAgent("explorer", "builtin", "builtin prompt")];
+		const builtinAgents = [makeAgent("scout", "builtin", "builtin prompt")];
 		const result = mergeAgentsForScope("both", [], [], builtinAgents);
 		assert.equal(result.length, 1);
 		assert.equal(result[0]?.source, "builtin");
 	});
 
 	it("user agents override builtins with the same name", () => {
-		const builtinAgents = [makeAgent("explorer", "builtin", "builtin prompt")];
-		const userAgents = [makeAgent("explorer", "user", "custom prompt")];
+		const builtinAgents = [makeAgent("scout", "builtin", "builtin prompt")];
+		const userAgents = [makeAgent("scout", "user", "custom prompt")];
 		const result = mergeAgentsForScope("both", userAgents, [], builtinAgents);
 		assert.equal(result.length, 1);
 		assert.equal(result[0]?.source, "user");
@@ -68,10 +68,10 @@ describe("mergeAgentsForScope", () => {
 	});
 
 	it("package agents override builtins but not user or project agents", () => {
-		const builtinAgents = [makeAgent("explorer", "builtin", "builtin prompt")];
-		const packageAgents = [makeAgent("explorer", "package", "package prompt")];
-		const userAgents = [makeAgent("explorer", "user", "user prompt")];
-		const projectAgents = [makeAgent("explorer", "project", "project prompt")];
+		const builtinAgents = [makeAgent("scout", "builtin", "builtin prompt")];
+		const packageAgents = [makeAgent("scout", "package", "package prompt")];
+		const userAgents = [makeAgent("scout", "user", "user prompt")];
+		const projectAgents = [makeAgent("scout", "project", "project prompt")];
 
 		assert.equal(mergeAgentsForScope("both", [], [], builtinAgents, packageAgents)[0]?.source, "package");
 		assert.equal(mergeAgentsForScope("user", userAgents, [], builtinAgents, packageAgents)[0]?.source, "user");
@@ -79,8 +79,8 @@ describe("mergeAgentsForScope", () => {
 	});
 
 	it("project agents override builtins with the same name", () => {
-		const builtinAgents = [makeAgent("explorer", "builtin", "builtin prompt")];
-		const projectAgents = [makeAgent("explorer", "project", "project prompt")];
+		const builtinAgents = [makeAgent("scout", "builtin", "builtin prompt")];
+		const projectAgents = [makeAgent("scout", "project", "project prompt")];
 		const result = mergeAgentsForScope("both", [], projectAgents, builtinAgents);
 		assert.equal(result.length, 1);
 		assert.equal(result[0]?.source, "project");

package/dist/extensions/pi-subagents/test/unit/artifacts.test.ts

@@ -1,8 +1,11 @@
 import assert from "node:assert/strict";
+import * as fs from "node:fs";
+import * as os from "node:os";
 import * as path from "node:path";
-import { describe, it } from "node:test";
+import { afterEach, describe, it } from "node:test";
 import {
 	getArtifactsDir,
+	getProjectArtifactPackagingWarning,
 	getChainRunsDir,
 	getProjectArtifactsDir,
 	getProjectChainRunsDir,
@@ -11,6 +14,45 @@ import {
 import { CHAIN_RUNS_DIR } from "../../src/shared/types.ts";
 
 describe("project-local artifact paths", () => {
+	const tempDirs: string[] = [];
+
+	afterEach(() => {
+		for (const dir of tempDirs.splice(0)) fs.rmSync(dir, { recursive: true, force: true });
+	});
+
+	function packageDir(packageJson: object, ignore?: { name: ".npmignore" | ".gitignore"; content: string }): string {
+		const dir = fs.mkdtempSync(path.join(os.tmpdir(), "pi-subagents-artifacts-"));
+		tempDirs.push(dir);
+		fs.writeFileSync(path.join(dir, "package.json"), JSON.stringify(packageJson), "utf-8");
+		if (ignore) fs.writeFileSync(path.join(dir, ignore.name), ignore.content, "utf-8");
+		return dir;
+	}
+
+	it("warns only when package settings can include project artifacts", () => {
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "unsafe" })) ?? "", /\.npmignore/);
+		assert.equal(getProjectArtifactPackagingWarning(packageDir({ name: "gitignored" }, { name: ".gitignore", content: ".pi-subagents/\n" })), undefined);
+		assert.equal(getProjectArtifactPackagingWarning(packageDir({ name: "globignored" }, { name: ".npmignore", content: "**/.pi-subagents/**\n" })), undefined);
+		assert.equal(getProjectArtifactPackagingWarning(packageDir({ name: "classignored" }, { name: ".npmignore", content: "[.]pi-subagents/**\n" })), undefined);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "explicit-files-over-ignore", files: [".pi-subagents/**"] }, { name: ".npmignore", content: ".pi-subagents/\n" })) ?? "", /artifactDir/);
+		assert.equal(getProjectArtifactPackagingWarning(packageDir({ name: "restricted", files: ["src/**"] })), undefined);
+		assert.equal(getProjectArtifactPackagingWarning(packageDir({ name: "malformed-pattern", files: ["[z-a]"] })), undefined);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "broad", files: ["**/*"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "root-wildcard", files: ["*"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "included", files: [".pi-subagents/**"] })) ?? "", /artifactDir/);
+		assert.equal(getProjectArtifactPackagingWarning(packageDir({ name: "excluded-after-include", files: [".pi-subagents/**", "!.pi-subagents/**"] })), undefined);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "artifacts-included", files: [".pi-subagents/artifacts/**"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "artifacts-directory-included", files: [".pi-subagents/artifacts"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "dynamic-input-included", files: [".pi-subagents/artifacts/*_input.md"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "dynamic-output-included", files: [".pi-subagents/artifacts/*_output.md"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "dynamic-jsonl-included", files: [".pi-subagents/artifacts/*.jsonl"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "dynamic-meta-included", files: [".pi-subagents/artifacts/*_meta.json"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "progress-included", files: [".pi-subagents/artifacts/progress/**"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "outputs-included", files: [".pi-subagents/artifacts/outputs/**"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "nested-output-included", files: [".pi-subagents/artifacts/outputs/*/*.md"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "chain-runs-included", files: [".pi-subagents/chain-runs/**"] })) ?? "", /artifactDir/);
+		assert.match(getProjectArtifactPackagingWarning(packageDir({ name: "chain-runs-directory-included", files: [".pi-subagents/chain-runs"] })) ?? "", /artifactDir/);
+	});
+
 	it("places generated subagent files under .pi-subagents for a project cwd", () => {
 		const cwd = path.join("tmp", "repo");
 		assert.equal(getProjectSubagentsDir(cwd), path.join(cwd, ".pi-subagents"));

package/dist/extensions/pi-subagents/test/unit/async-execution.test.ts

@@ -1,7 +1,7 @@
 import assert from "node:assert/strict";
 import * as path from "node:path";
 import { describe, it } from "node:test";
-import { buildAsyncRunnerSteps, formatAsyncStartedMessage, resolveAsyncRunnerLogPaths } from "../../src/runs/background/async-execution.ts";
+import { buildAsyncRunnerSteps, DEFAULT_ASYNC_TIMEOUT_MS, formatAsyncStartedMessage, resolveAsyncRunnerLogPaths } from "../../src/runs/background/async-execution.ts";
 import type { AgentConfig } from "../../src/agents/agents.ts";
 
 const agent = (name: string, toolBudget?: AgentConfig["toolBudget"]): AgentConfig => ({
@@ -26,14 +26,16 @@ const ctx = {
 
 describe("async runner execution", () => {
 	it("formats interactive yield and headless auto-drain guidance separately", () => {
-		const interactive = formatAsyncStartedMessage("Async: builder [interactive]", true);
+		const interactive = formatAsyncStartedMessage("Async: worker [interactive]", true);
 		assert.match(interactive, /interactive session[\s\S]*return control/i);
 		assert.match(interactive, /do not call subagent_wait\(\) merely to wait/i);
+		assert.match(interactive, /nonBlocking: true/);
 		assert.doesNotMatch(interactive, /auto-drains current-session background work/i);
 
-		const headless = formatAsyncStartedMessage("Async: builder [headless]", false);
+		const headless = formatAsyncStartedMessage("Async: worker [headless]", false);
 		assert.match(headless, /non-interactive run.*auto-drains current-session background work at agent_end/i);
 		assert.match(headless, /call subagent_wait\(\).*results before it ends/i);
+		assert.doesNotMatch(headless, /nonBlocking: true/);
 		assert.doesNotMatch(headless, /By default, return control to the user/i);
 	});
 
@@ -52,10 +54,10 @@ describe("async runner execution", () => {
 	it("resolves async step tool budgets with step over run over agent over config precedence", () => {
 		const result = buildAsyncRunnerSteps("run-1", {
 			chain: [
-				{ agent: "builder", task: "agent beats config" },
-				{ agent: "builder", task: "step beats run", toolBudget: { hard: 2, block: ["grep"] } },
+				{ agent: "worker", task: "agent beats config" },
+				{ agent: "worker", task: "step beats run", toolBudget: { hard: 2, block: ["grep"] } },
 			],
-			agents: [agent("builder", { hard: 4, block: ["read"] })],
+			agents: [agent("worker", { hard: 4, block: ["read"] })],
 			ctx,
 			asyncDir: path.join(process.cwd(), ".tmp-async-test"),
 			maxSubagentDepth: 2,
@@ -70,10 +72,34 @@ describe("async runner execution", () => {
 		assert.deepEqual(result.steps[1]?.toolBudget, { hard: 2, block: ["grep"] });
 	});
 
+	it("assigns default and agent-level deadlines to async serial and parallel children", () => {
+		const result = buildAsyncRunnerSteps("timeout-run", {
+			chain: [
+				{ agent: "default-worker", task: "default serial timeout" },
+				{
+					parallel: [
+						{ agent: "default-worker", task: "default parallel timeout" },
+						{ agent: "custom-worker", task: "custom parallel timeout" },
+					],
+				},
+			],
+			agents: [agent("default-worker"), { ...agent("custom-worker"), defaultTimeoutMs: 7_000 }],
+			ctx,
+			asyncDir: path.join(process.cwd(), ".tmp-async-timeout-test"),
+			maxSubagentDepth: 2,
+		});
+
+		assert.ok("steps" in result, "expected successful step build");
+		assert.equal(result.steps[0]?.timeoutMs, DEFAULT_ASYNC_TIMEOUT_MS);
+		const parallel = result.steps[1];
+		assert.ok(parallel && "parallel" in parallel && Array.isArray(parallel.parallel));
+		assert.deepEqual(parallel.parallel.map((step) => step.timeoutMs), [DEFAULT_ASYNC_TIMEOUT_MS, 7_000]);
+	});
+
 	it("uses agent tool budget before config default when no run override exists", () => {
 		const result = buildAsyncRunnerSteps("run-2", {
-			chain: [{ agent: "builder", task: "agent beats config" }],
-			agents: [agent("builder", { hard: 4, block: ["read"] })],
+			chain: [{ agent: "worker", task: "agent beats config" }],
+			agents: [agent("worker", { hard: 4, block: ["read"] })],
 			ctx,
 			asyncDir: path.join(process.cwd(), ".tmp-async-test"),
 			maxSubagentDepth: 2,
@@ -110,8 +136,8 @@ describe("async runner execution", () => {
 
 	it("uses config default when no step, run, or agent budget exists", () => {
 		const result = buildAsyncRunnerSteps("run-3", {
-			chain: [{ agent: "builder", task: "config default" }],
-			agents: [agent("builder")],
+			chain: [{ agent: "worker", task: "config default" }],
+			agents: [agent("worker")],
 			ctx,
 			asyncDir: path.join(process.cwd(), ".tmp-async-test"),
 			maxSubagentDepth: 2,