@selesai/code 0.6.3 → 0.8.0

package/dist/extensions/pi-subagents/test/unit/pi-args.test.ts

@@ -9,6 +9,7 @@ import { WAIT_TOOL_ENABLED_ENV } from "../../src/runs/background/wait-config.ts"
 import { SELESAI_CODING_AGENT_PACKAGE_ROOT_ENV } from "../../src/shared/utils.ts";
 import { CHILD_TOOL_DIAGNOSTIC_PATH_ENV, MCP_DIRECT_CHILD_TOOLS_ENV, REQUIRED_CHILD_TOOLS_ENV } from "../../src/runs/shared/tool-availability.ts";
 import { CHILD_WATCHDOG_CONFIG_ENV } from "../../src/watchdog/child-status.ts";
+import { PERMISSION_AUDIT_PATH_ENV, PERMISSION_POLICY_ENV } from "../../src/runs/shared/permissions.ts";
 import {
 	SUBAGENT_FANOUT_CHILD_ENV,
 	SUBAGENT_PARENT_CHILD_INDEX_ENV,
@@ -255,7 +256,7 @@ describe("buildPiArgs session wiring", () => {
 			childWatchdog: {
 				enabled: true,
 				runId: "run-1",
-				agent: "worker",
+				agent: "builder",
 				childIndex: 2,
 				watchdogTailTimeoutMs: 1234,
 				agentEndTimeoutMs: 500,
@@ -271,7 +272,7 @@ describe("buildPiArgs session wiring", () => {
 		assert.deepEqual(JSON.parse(encoded ?? "{}"), {
 			enabled: true,
 			runId: "run-1",
-			agent: "worker",
+			agent: "builder",
 			childIndex: 2,
 			watchdogTailTimeoutMs: 1234,
 			agentEndTimeoutMs: 500,
@@ -411,7 +412,7 @@ describe("buildPiArgs system prompt mode wiring", () => {
 			baseArgs: ["-p"],
 			task: "hello",
 			sessionEnabled: false,
-			systemPrompt: "You are a worker",
+			systemPrompt: "You are a builder",
 			inheritProjectContext: false,
 			inheritSkills: false,
 		});
@@ -425,7 +426,7 @@ describe("buildPiArgs system prompt mode wiring", () => {
 			baseArgs: ["-p"],
 			task: "hello",
 			sessionEnabled: false,
-			systemPrompt: "You are a worker",
+			systemPrompt: "You are a builder",
 			systemPromptMode: "replace",
 			inheritProjectContext: false,
 			inheritSkills: false,
@@ -527,21 +528,21 @@ describe("buildPiArgs system prompt mode wiring", () => {
 			sessionEnabled: false,
 			inheritProjectContext: true,
 			inheritSkills: true,
-			intercomSessionName: "subagent-worker-78f659a3",
+			intercomSessionName: "subagent-builder-78f659a3",
 			orchestratorIntercomTarget: "subagent-chat-parent",
 			parentSessionId: "session-parent-123",
 			runId: "78f659a3",
-			childAgentName: "worker",
+			childAgentName: "builder",
 			childIndex: 2,
 		});
 
-		assert.equal(env.SELESAI_SUBAGENT_INTERCOM_SESSION_NAME, "subagent-worker-78f659a3");
-		assert.equal(env[PI_INTERCOM_STABLE_ID_ENV], "subagent-worker-78f659a3");
+		assert.equal(env.SELESAI_SUBAGENT_INTERCOM_SESSION_NAME, "subagent-builder-78f659a3");
+		assert.equal(env[PI_INTERCOM_STABLE_ID_ENV], "subagent-builder-78f659a3");
 		assert.equal(env[PI_INTERCOM_SESSION_ID_ENV], undefined);
 		assert.equal(env.SELESAI_SUBAGENT_ORCHESTRATOR_TARGET, "subagent-chat-parent");
 		assert.equal(env[SUBAGENT_ORCHESTRATOR_SESSION_ID_ENV], "session-parent-123");
 		assert.equal(env.SELESAI_SUBAGENT_RUN_ID, "78f659a3");
-		assert.equal(env.SELESAI_SUBAGENT_CHILD_AGENT, "worker");
+		assert.equal(env.SELESAI_SUBAGENT_CHILD_AGENT, "builder");
 		assert.equal(env.SELESAI_SUBAGENT_CHILD_INDEX, "2");
 		assert.equal(typeof env[SUBAGENT_SUPERVISOR_CHANNEL_DIR_ENV], "string");
 		assert.match(env[SUBAGENT_SUPERVISOR_CHANNEL_DIR_ENV] ?? "", /supervisor-channels/);
@@ -562,6 +563,26 @@ describe("buildPiArgs system prompt mode wiring", () => {
 		assert.equal(env[PI_INTERCOM_SESSION_ID_ENV], undefined);
 	});
 
+	it("creates a private permission audit path without enabling the supervisor channel", () => {
+		const { env, tempDir } = buildPiArgs({
+			baseArgs: ["-p"],
+			task: "hello",
+			sessionEnabled: false,
+			inheritProjectContext: true,
+			inheritSkills: true,
+			parentSessionId: "session-parent-123",
+			runId: "permission-run",
+			childAgentName: "builder",
+			childIndex: 3,
+			permissionRules: { write: "ask" },
+		});
+
+		assert.equal(env.SELESAI_SUBAGENT_ORCHESTRATOR_TARGET, undefined);
+		assert.equal(env[PERMISSION_POLICY_ENV], JSON.stringify({ write: "ask" }));
+		assert.equal(env[SUBAGENT_SUPERVISOR_CHANNEL_DIR_ENV], undefined);
+		assert.equal(env[PERMISSION_AUDIT_PATH_ENV], path.join(tempDir!, "permission-audit.jsonl"));
+	});
+
 	it("does not create a supervisor channel without an exact parent session id", () => {
 		const { env } = buildPiArgs({
 			baseArgs: ["-p"],
@@ -571,7 +592,7 @@ describe("buildPiArgs system prompt mode wiring", () => {
 			inheritSkills: true,
 			orchestratorIntercomTarget: "subagent-chat-parent",
 			runId: "78f659a3",
-			childAgentName: "worker",
+			childAgentName: "builder",
 			childIndex: 2,
 		});
 

package/dist/extensions/pi-subagents/test/unit/pi-spawn.test.ts

@@ -73,12 +73,32 @@ describe("getPiSpawnCommand", () => {
 		assert.deepEqual(result, { command: "selesai", args });
 	});
 
-	it("accepts the legacy PI_SUBAGENT_PI_BINARY alias", () => {
-		const args = ["--mode", "json", "Task: check output"];
-		assert.deepEqual(getPiSpawnCommand(args, {
-			env: { PI_SUBAGENT_PI_BINARY: "/usr/local/bin/legacy-wrapper" },
-		}), { command: "/usr/local/bin/legacy-wrapper", args });
-	});
+	for (const [platform, execPath] of [
+		["darwin", "/opt/pi/pi"],
+		["linux", "/opt/pi/pi"],
+		["win32", "C:\\Program Files\\Pi\\pi.exe"],
+	] as const) {
+		it(`uses the standalone Pi executable directly on ${platform}`, () => {
+			const packageJsonPath = "/opt/pi-package/package.json";
+			const cliPath = path.resolve(
+				path.dirname(packageJsonPath),
+				"dist/cli.js",
+			);
+			const deps = makeDeps({
+				platform,
+				execPath,
+				argv1: "/missing/host.js",
+				packageJsonPath,
+				packageJsonContent: JSON.stringify({ bin: { selesai: "dist/cli.js" } }),
+				existing: [packageJsonPath, cliPath],
+			});
+			const args = ["--mode", "json", "-p", "Task: review diff"];
+			assert.deepEqual(getPiSpawnCommand(args, deps), {
+				command: execPath,
+				args,
+			});
+		});
+	}
 
 	for (const platform of ["darwin", "linux", "win32"] as const) {
 		it(`uses node + argv1 on ${platform} when argv1 belongs to the Pi package`, () => {
@@ -121,7 +141,7 @@ describe("getPiSpawnCommand", () => {
 			execPath: "/usr/local/bin/node",
 			argv1: "/opt/pi/subagent-runner.ts",
 			packageJsonPath,
-			packageJsonContent: JSON.stringify({ bin: { pi: "dist/cli/index.js" } }),
+			packageJsonContent: JSON.stringify({ bin: { selesai: "dist/cli/index.js" } }),
 			existing: [packageJsonPath, cliPath],
 		});
 		const args = ["-p", "Task: hello"];
@@ -157,8 +177,8 @@ describe("getPiSpawnCommand", () => {
 			const piRoot = path.join(
 				tempDir,
 				"node_modules",
-				"@earendil-works",
-				"pi-coding-agent",
+				"@selesai",
+				"code",
 			);
 			const piCli = path.join(piRoot, "dist", "cli.js");
 			fs.mkdirSync(path.dirname(hostEntry), { recursive: true });
@@ -173,7 +193,7 @@ describe("getPiSpawnCommand", () => {
 				path.join(piRoot, "package.json"),
 				JSON.stringify({
 					name: "@selesai/code",
-					bin: { pi: "dist/cli.js" },
+					bin: { selesai: "dist/cli.js" },
 				}),
 			);
 
@@ -217,7 +237,7 @@ describe("getPiSpawnCommand", () => {
 		try {
 			const hostRoot = path.join(tempDir, "embedded-host");
 			const hostEntry = path.join(hostRoot, "dist", "server.js");
-			const piRoot = path.join(tempDir, "node_modules", "@earendil-works", "pi-coding-agent");
+			const piRoot = path.join(tempDir, "node_modules", "@selesai", "code");
 			const disguisedEntry = path.join(piRoot, "dist", "cli.js");
 			const piCli = path.join(piRoot, "dist", "real-cli.js");
 			fs.mkdirSync(path.dirname(hostEntry), { recursive: true });
@@ -227,7 +247,7 @@ describe("getPiSpawnCommand", () => {
 			fs.writeFileSync(piCli, "#!/usr/bin/env node\n");
 			fs.writeFileSync(path.join(piRoot, "package.json"), JSON.stringify({
 				name: "@selesai/code",
-				bin: { pi: "dist/real-cli.js" },
+				bin: { selesai: "dist/real-cli.js" },
 			}));
 
 			const result = getPiSpawnCommand(["-p", "Task: hello"], {
@@ -261,7 +281,7 @@ describe("getPiSpawnCommand", () => {
 			execPath: "/usr/local/bin/node",
 			argv1: "/opt/pi/subagent-runner.ts",
 			packageJsonPath,
-			packageJsonContent: JSON.stringify({ bin: { pi: "dist/cli/index.js" } }),
+			packageJsonContent: JSON.stringify({ bin: { selesai: "dist/cli/index.js" } }),
 			existing: [packageJsonPath, cliPath],
 		});
 		const result = getPiSpawnCommand(["-p", "Task: hello"], deps);
@@ -285,7 +305,12 @@ describe("getPiSpawnCommand", () => {
 			path.join(os.tmpdir(), "pi-spawn-package-root-"),
 		);
 		try {
-			const packageRoot = path.join(tempDir, "node_modules", "@selesai", "code");
+			const packageRoot = path.join(
+				tempDir,
+				"node_modules",
+				"@selesai",
+				"code",
+			);
 			const entry = path.join(packageRoot, "dist", "index.js");
 			const cliPath = path.join(packageRoot, "dist", "cli", "index.js");
 			fs.mkdirSync(path.dirname(entry), { recursive: true });
@@ -303,7 +328,6 @@ describe("getPiSpawnCommand", () => {
 				platform: "win32",
 				execPath: "/usr/local/bin/node",
 				argv1: "/opt/pi/subagent-runner.ts",
-				piPackageRoot: packageRoot,
 				resolvePackageEntry: () => entry,
 				env: {},
 			});
@@ -327,7 +351,7 @@ describe("getPiSpawnCommand with piPackageRoot", () => {
 			execPath: "/usr/local/bin/node",
 			argv1: "/opt/pi/subagent-runner.ts",
 			packageJsonPath,
-			packageJsonContent: JSON.stringify({ bin: { pi: "dist/cli/index.js" } }),
+			packageJsonContent: JSON.stringify({ bin: { selesai: "dist/cli/index.js" } }),
 			existing: [packageJsonPath, cliPath],
 		});
 		deps.piPackageRoot = "/opt/pi";

package/dist/extensions/pi-subagents/test/unit/preflight.test.ts

@@ -107,7 +107,6 @@ Project prompt.
 					{ provider: "test", id: "fallback", fullId: "test/fallback" },
 				],
 				capabilityCeiling: ceiling,
-				artifacts: true,
 			});
 
 			assert.equal(result.ok, true);
@@ -144,7 +143,6 @@ Project prompt.
 					{ provider: "test", id: "fallback", fullId: "test/fallback" },
 				],
 				capabilityCeiling: ceiling,
-				artifacts: true,
 			});
 			assert.equal(repeated.ok, true);
 			assert.equal(repeated.contract.digest, result.contract.digest);
@@ -158,72 +156,72 @@ Project prompt.
 	it("resolves agent aliases to the canonical launch contract agent", async () => {
 		const cwd = path.join(tempDir, "repo-alias");
 		fs.mkdirSync(cwd, { recursive: true });
-		writeAgent(path.join(cwd, ".selesai", "agents", "worker.md"), `---
-name: worker
-description: Project worker
-aliases: shipper, worker-alias
+		writeAgent(path.join(cwd, ".selesai", "agents", "builder.md"), `---
+name: builder
+description: Project builder
+aliases: developer, coder
 ---
 Project prompt.
 `);
 
 		const result = await resolveSubagentLaunchContract({
-			agent: "shipper",
+			agent: "developer",
 			cwd,
 			task: "Implement the change",
 		});
 
 		assert.equal(result.ok, true);
-		assert.equal(result.contract.agent.name, "worker");
+		assert.equal(result.contract.agent.name, "builder");
 	});
 
 	it("reports alias collisions as ambiguous agents", async () => {
 		const cwd = path.join(tempDir, "repo-alias-collision");
 		fs.mkdirSync(cwd, { recursive: true });
-		writeAgent(path.join(cwd, ".selesai", "agents", "worker.md"), `---
-name: worker
-description: Project worker
-aliases: shared-alias
+		writeAgent(path.join(cwd, ".selesai", "agents", "builder.md"), `---
+name: builder
+description: Project builder
+aliases: coder
 ---
 Project prompt.
 `);
-		writeAgent(path.join(cwd, ".selesai", "agents", "reviewer.md"), `---
-name: reviewer
-description: Project reviewer
-aliases: shared-alias
+		writeAgent(path.join(cwd, ".selesai", "agents", "commentator.md"), `---
+name: commentator
+description: Project commentator
+aliases: coder
 ---
 Review prompt.
 `);
 
-		const result = await resolveSubagentLaunchContract({ agent: "shared-alias", cwd });
+		const result = await resolveSubagentLaunchContract({ agent: "coder", cwd });
 
 		assert.equal(result.ok, false);
 		assert.equal(result.code, "ambiguous_agent");
-		assert.match(result.message, /Ambiguous agent alias 'shared-alias': reviewer, worker|Ambiguous agent alias 'shared-alias': worker, reviewer/);
+		assert.match(result.message, /Ambiguous agent alias 'coder': commentator, builder|Ambiguous agent alias 'coder': builder, commentator/);
 	});
 
 	it("changes definition and launch digests when selected agent content changes", async () => {
 		const cwd = path.join(tempDir, "repo");
 		fs.mkdirSync(cwd, { recursive: true });
-		const agentPath = path.join(cwd, ".selesai", "agents", "worker.md");
+		const agentPath = path.join(cwd, ".selesai", "agents", "builder.md");
 		writeAgent(agentPath, `---
-name: digest-worker
-description: Digest worker
+name: digest-builder
+description: Digest builder
 tools:
   - read
 ---
 First prompt.
 `);
-		const before = await resolveSubagentLaunchContract({ agent: "digest-worker", cwd, runId: "digest-test" });
+		const before = await resolveSubagentLaunchContract({ agent: "digest-builder", cwd, runId: "digest-test" });
 		assert.equal(before.ok, true);
 		writeAgent(agentPath, `---
-name: digest-worker
-description: Digest worker
+name: digest-builder
+description: Digest builder
 tools:
   - read
 ---
 Changed prompt.
 `);
-		const after = await resolveSubagentLaunchContract({ agent: "digest-worker", cwd, runId: "digest-test" });
+		const after = await resolveSubagentLaunchContract({ agent: "digest-builder", cwd, runId: "digest-test" });
 		assert.equal(after.ok, true);
 		assert.notEqual(after.contract.agent.definitionDigest, before.contract.agent.definitionDigest);
 		assert.notEqual(after.contract.launchContractDigest, before.contract.launchContractDigest);
@@ -234,9 +232,9 @@ Changed prompt.
 		const cwd = path.join(tempDir, "repo");
 		fs.mkdirSync(cwd, { recursive: true });
 		writeSkill(cwd, "digest-skill");
-		writeAgent(path.join(cwd, ".selesai", "agents", "worker.md"), `---
-name: worker
-description: Project worker
+		writeAgent(path.join(cwd, ".selesai", "agents", "builder.md"), `---
+name: builder
+description: Project builder
 tools:
   - read
 skills:
@@ -244,12 +242,12 @@ skills:
 ---
 Project prompt.
 `);
-		const before = await resolveSubagentLaunchContract({ agent: "worker", cwd, runId: "skill-digest-test" });
+		const before = await resolveSubagentLaunchContract({ agent: "builder", cwd, runId: "skill-digest-test" });
 		assert.equal(before.ok, true);
 		fs.writeFileSync(path.join(cwd, ".selesai", "skills", "digest-skill", "SKILL.md"), "---\ndescription: updated digest-skill\n---\n\nUse digest-skill.\n", "utf-8");
 		clearSkillCache();
 
-		const after = await resolveSubagentLaunchContract({ agent: "worker", cwd, runId: "skill-digest-test" });
+		const after = await resolveSubagentLaunchContract({ agent: "builder", cwd, runId: "skill-digest-test" });
 		assert.equal(after.ok, true);
 		assert.equal(after.contract.agent.definitionDigest, before.contract.agent.definitionDigest);
 		assert.notEqual(after.contract.launchContractDigest, before.contract.launchContractDigest);
@@ -259,9 +257,9 @@ Project prompt.
 	it("returns closed failures for missing agents and missing skills", async () => {
 		const cwd = path.join(tempDir, "repo");
 		fs.mkdirSync(cwd, { recursive: true });
-		writeAgent(path.join(cwd, ".selesai", "agents", "worker.md"), `---
-name: worker
-description: Project worker
+		writeAgent(path.join(cwd, ".selesai", "agents", "builder.md"), `---
+name: builder
+description: Project builder
 skills:
   - missing-skill
 ---
@@ -271,7 +269,7 @@ Project prompt.
 		const missingAgent = await resolveSubagentLaunchContract({ agent: "missing", cwd });
 		assert.deepEqual(missingAgent, { ok: false, code: "missing_agent", message: "Unknown agent: missing", diagnostics: [] });
 
-		const missingSkill = await resolveSubagentLaunchContract({ agent: "worker", cwd });
+		const missingSkill = await resolveSubagentLaunchContract({ agent: "builder", cwd });
 		assert.equal(missingSkill.ok, false);
 		assert.equal(missingSkill.code, "missing_skill");
 		assert.match(missingSkill.message, /missing-skill/);
@@ -280,22 +278,22 @@ Project prompt.
 	it("fails closed for invalid runtime inputs", async () => {
 		const cwd = path.join(tempDir, "repo");
 		fs.mkdirSync(cwd, { recursive: true });
-		writeAgent(path.join(cwd, ".selesai", "agents", "worker.md"), `---
-name: worker
-description: Project worker
+		writeAgent(path.join(cwd, ".selesai", "agents", "builder.md"), `---
+name: builder
+description: Project builder
 ---
 Project prompt.
 `);
 
-		const invalidCwd = await resolveSubagentLaunchContract({ agent: "worker", cwd: path.join(tempDir, "missing") });
+		const invalidCwd = await resolveSubagentLaunchContract({ agent: "builder", cwd: path.join(tempDir, "missing") });
 		assert.equal(invalidCwd.ok, false);
 		assert.equal(invalidCwd.code, "invalid_cwd");
 
-		const unsupportedMode = await resolveSubagentLaunchContract({ agent: "worker", cwd, context: "bogus" as never });
+		const unsupportedMode = await resolveSubagentLaunchContract({ agent: "builder", cwd, context: "bogus" as never });
 		assert.equal(unsupportedMode.ok, false);
 		assert.equal(unsupportedMode.code, "unsupported_mode");
 
-		const invalidArtifactDir = await resolveSubagentLaunchContract({ agent: "worker", cwd, artifactDir: "bogus" as never });
+		const invalidArtifactDir = await resolveSubagentLaunchContract({ agent: "builder", cwd, artifactDir: "bogus" as never });
 		assert.equal(invalidArtifactDir.ok, false);
 		assert.equal(invalidArtifactDir.code, "invalid_artifact_dir");
 	});
@@ -347,9 +345,9 @@ Project prompt.
 		const cwd = path.join(tempDir, "repo");
 		fs.mkdirSync(cwd, { recursive: true });
 		writeSkill(cwd, "project-skill");
-		writeAgent(path.join(cwd, ".selesai", "agents", "worker.md"), `---
-name: worker
-description: Project worker
+		writeAgent(path.join(cwd, ".selesai", "agents", "builder.md"), `---
+name: builder
+description: Project builder
 tools:
   - read
 skills:
@@ -359,7 +357,7 @@ Project prompt.
 `);
 
 		const result = await resolveSubagentLaunchContract({
-			agent: "worker",
+			agent: "builder",
 			cwd,
 			capabilityCeiling: { version: 1, allowedTools: [], denyExtensions: false, sources: ["test"] },
 		});

package/dist/extensions/pi-subagents/test/unit/proactive-skills.test.ts

@@ -29,7 +29,7 @@ function chain(name: string, skills: string[]): ChainConfig {
 		description: `${name} chain`,
 		source: "project",
 		filePath: `/tmp/${name}.chain.md`,
-		steps: [{ agent: "worker", skills }],
+		steps: [{ agent: "builder", skills }],
 	};
 }
 
@@ -37,9 +37,9 @@ describe("proactive skill subagent recommendations", () => {
 	it("recommends available skills referenced by multiple enabled configs", () => {
 		const recommendations = recommendProactiveSkillSubagents({
 			agents: [
-				agent("reviewer"),
-				agent("ui-reviewer", ["accessibility"]),
-				agent("disabled-reviewer", ["accessibility"], true),
+				agent("commentator"),
+				agent("ui-commentator", ["accessibility"]),
+				agent("disabled-commentator", ["accessibility"], true),
 			],
 			chains: [chain("ui-check", ["accessibility"]), chain("cleanup", ["deslop"])],
 			availableSkills: [
@@ -50,31 +50,31 @@ describe("proactive skill subagent recommendations", () => {
 
 		assert.equal(recommendations.length, 1);
 		assert.equal(recommendations[0]?.skill, "accessibility");
-		assert.equal(recommendations[0]?.agent, "reviewer");
+		assert.equal(recommendations[0]?.agent, "commentator");
 		assert.equal(recommendations[0]?.references, 2);
-		assert.deepEqual(recommendations[0]?.sources, ["agent:ui-reviewer", "chain:ui-check"]);
+		assert.deepEqual(recommendations[0]?.sources, ["agent:ui-commentator", "chain:ui-check"]);
 	});
 
 	it("filters unavailable orchestration skills and honors config bounds", () => {
 		const recommendations = recommendProactiveSkillSubagents({
 			agents: [
-				agent("delegate", ["pi-subagents", "alpha", "beta"]),
+				agent("explorer", ["pi-subagents", "alpha", "beta"]),
 				agent("one", ["alpha", "beta"]),
 				agent("two", ["gamma"]),
 				agent("three", ["gamma"]),
 			],
 			availableSkills: [{ name: "alpha" }, { name: "beta" }, { name: "gamma" }],
-			config: { preferredAgent: "delegate", maxRecommendations: 2 },
+			config: { preferredAgent: "explorer", maxRecommendations: 2 },
 		});
 
 		assert.deepEqual(recommendations.map((entry) => entry.skill), ["alpha", "beta"]);
-		assert.ok(recommendations.every((entry) => entry.agent === "delegate"));
+		assert.ok(recommendations.every((entry) => entry.agent === "explorer"));
 	});
 
 	it("can be disabled and formats guardrails for visible suggestions", () => {
 		assert.equal(resolveProactiveSkillSubagentsConfig(false).enabled, false);
 		assert.deepEqual(recommendProactiveSkillSubagents({
-			agents: [agent("reviewer", ["deslop"]), agent("cleanup", ["deslop"])],
+			agents: [agent("commentator", ["deslop"]), agent("cleanup", ["deslop"])],
 			availableSkills: [{ name: "deslop" }],
 			config: false,
 		}), []);
@@ -82,7 +82,7 @@ describe("proactive skill subagent recommendations", () => {
 		const lines = formatProactiveSkillSubagentRecommendations([
 			{
 				skill: "deslop",
-				agent: "reviewer",
+				agent: "commentator",
 				references: 2,
 				sources: ["agent:a", "chain:b"],
 				reason: "referenced by 2 configured agents/chains",
@@ -95,7 +95,7 @@ describe("proactive skill subagent recommendations", () => {
 	it("does not discover skills when disabled and treats discovery failures as no suggestions", () => {
 		let discoveryCalls = 0;
 		const disabledLines = buildProactiveSkillSubagentRecommendationLines({
-			agents: [agent("reviewer", ["deslop"]), agent("cleanup", ["deslop"])],
+			agents: [agent("commentator", ["deslop"]), agent("cleanup", ["deslop"])],
 			config: false,
 			discoverAvailableSkills: () => {
 				discoveryCalls++;
@@ -106,7 +106,7 @@ describe("proactive skill subagent recommendations", () => {
 		assert.equal(discoveryCalls, 0);
 
 		const failedDiscoveryLines = buildProactiveSkillSubagentRecommendationLines({
-			agents: [agent("reviewer", ["deslop"]), agent("cleanup", ["deslop"])],
+			agents: [agent("commentator", ["deslop"]), agent("cleanup", ["deslop"])],
 			discoverAvailableSkills: () => {
 				discoveryCalls++;
 				throw new Error("skill scan failed");

package/dist/extensions/pi-subagents/test/unit/process-terminal.test.ts

@@ -30,7 +30,7 @@ test("process-terminal proof requires the matching runner instance and writer cl
 				}],
 			},
 		});
-		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "run-1", state: "complete", lifecycleArtifactVersion: 3, steps: [{ agent: "worker", status: "complete" }] }));
+		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "run-1", state: "complete", lifecycleArtifactVersion: 3, steps: [{ agent: "builder", status: "complete" }] }));
 		fs.writeFileSync(path.join(asyncDir, "events.jsonl"), "");
 
 		const mismatch = finalizeProcessTerminal(asyncDir, "run-1", {
@@ -67,7 +67,7 @@ test("process-terminal rejects missing writer close evidence", () => {
 			expectedWriters: { "0": 1 },
 			writers: { "0": [] },
 		});
-		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "run-missing-writer", state: "complete", lifecycleArtifactVersion: 3, steps: [{ agent: "worker", status: "complete" }] }));
+		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "run-missing-writer", state: "complete", lifecycleArtifactVersion: 3, steps: [{ agent: "builder", status: "complete" }] }));
 		fs.writeFileSync(path.join(asyncDir, "events.jsonl"), "");
 		const proof = finalizeProcessTerminal(asyncDir, "run-missing-writer", {
 			processInstanceId: "runner-missing-writer",
@@ -117,7 +117,7 @@ test("process-terminal preserves stopped non-resumability and requires lease rel
 			revivalLeaseToken: "lease-token",
 			revivalLeaseReleaseAcknowledged: false,
 		});
-		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "stopped-run", state: "stopped", lifecycleArtifactVersion: 3, steps: [{ agent: "worker", status: "stopped" }] }));
+		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "stopped-run", state: "stopped", lifecycleArtifactVersion: 3, steps: [{ agent: "builder", status: "stopped" }] }));
 		fs.writeFileSync(path.join(asyncDir, "events.jsonl"), "");
 		const unverified = finalizeProcessTerminal(asyncDir, "stopped-run", { processInstanceId: "stopped-runner", closeObservedAt: 20, exitCode: 0, signal: null });
 		assert.equal(unverified.state, "unknown");
@@ -164,7 +164,7 @@ test("process-terminal rejects cross-run observed sidecars and inconsistent expe
 				"0": [{ processInstanceId: "unexpected-writer", kind: "pi-writer", attempt: 0, closeObservedAt: 10, exitCode: 0, signal: null }],
 			},
 		});
-		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "actual-run", state: "complete", lifecycleArtifactVersion: 3, steps: [{ agent: "worker", status: "complete" }] }));
+		fs.writeFileSync(path.join(asyncDir, "status.json"), JSON.stringify({ runId: "actual-run", state: "complete", lifecycleArtifactVersion: 3, steps: [{ agent: "builder", status: "complete" }] }));
 		fs.writeFileSync(path.join(asyncDir, "events.jsonl"), "");
 		const inconsistent = finalizeProcessTerminal(asyncDir, "actual-run", { processInstanceId: "runner-1", closeObservedAt: 30, exitCode: 0, signal: null });
 		assert.equal(inconsistent.state, "unknown");