@selesai/code 0.6.3 → 0.8.0

package/dist/extensions/pi-subagents/test/unit/nested-events.test.ts

@@ -64,8 +64,8 @@ function child(id: string, state: "queued" | "running" | "complete" | "failed" |
 		path: [{ runId: parentRunId, stepIndex: 1 }],
 		mode: "single" as const,
 		state,
-		agent: "reviewer",
-		agents: ["reviewer"],
+		agent: "commentator",
+		agents: ["commentator"],
 		startedAt: 10,
 		lastUpdate: ts,
 		steps: [{ agent: "leaf", status: state === "running" ? "running" as const : "complete" as const }],
@@ -150,7 +150,7 @@ describe("nested event parsing and projection", () => {
 			ts: 100,
 			parentRunId: "root-run",
 			parentStepIndex: 1,
-			child: child("nested-a", "running", 100),
+			child: { ...child("nested-a", "running", 100), model: "provider/gpt-5.6-luna:medium", thinking: "medium", steps: [{ agent: "leaf", status: "running", model: "provider/leaf", thinking: "low" }], children: [child("nested-grandchild", "running", 100, "nested-a")] },
 		});
 		writeNestedEvent(route, {
 			type: "subagent.nested.updated",
@@ -176,6 +176,11 @@ describe("nested event parsing and projection", () => {
 		assert.equal(registry.children[0]?.id, "nested-a");
 		assert.equal(registry.children[0]?.state, "complete");
 		assert.equal(registry.children[0]?.steps?.[0]?.agent, "leaf");
+		assert.equal(registry.children[0]?.model, "provider/gpt-5.6-luna:medium");
+		assert.equal(registry.children[0]?.thinking, "medium");
+		assert.equal(registry.children[0]?.steps?.[0]?.model, "provider/leaf");
+		assert.equal(registry.children[0]?.steps?.[0]?.thinking, "low");
+		assert.equal(registry.children[0]?.children?.[0]?.id, "nested-grandchild");
 		assert.deepEqual(registry.children[0]?.runtimeAcknowledgedExtensions, {
 			version: 1,
 			source: "child-runtime",
@@ -339,6 +344,43 @@ describe("nested event parsing and projection", () => {
 	});
 
 
+	it("sanitizes nested model bounds and thinking levels", () => {
+		const route = trackRoute();
+		writeNestedEvent(route, {
+			type: "subagent.nested.updated",
+			ts: 100,
+			parentRunId: "root-run",
+			parentStepIndex: 1,
+			child: {
+				...child("nested-model-bounds", "running", 100),
+				model: "m".repeat(600),
+				thinking: "turbo",
+				steps: [{ agent: "leaf", status: "running", model: "builder", thinking: "xhigh" }],
+			},
+		});
+		const summary = projectNestedEvents(route).children[0]!;
+		assert.equal(summary.model?.length, 512);
+		assert.equal(summary.thinking, undefined);
+		assert.equal(summary.steps?.[0]?.thinking, "xhigh");
+	});
+
+	it("projects effective model and thinking from async status, including a single-step run", () => {
+		const summary = nestedSummaryFromAsyncStatus({
+			runId: "child-run",
+			mode: "single",
+			state: "running",
+			startedAt: 1,
+			steps: [
+				{ agent: "builder", status: "running", model: "provider/builder", thinking: "high" },
+			],
+		}, "/tmp/child-run", { id: "child-run", parentRunId: "parent-run", depth: 1, mode: "single", ts: 2 });
+
+		assert.equal(summary.model, "provider/builder");
+		assert.equal(summary.thinking, "high");
+		assert.equal(summary.steps?.[0]?.model, "provider/builder");
+		assert.equal(summary.steps?.[0]?.thinking, "high");
+	});
+
 	it("sanitizes malformed process-terminal proofs in nested status summaries", () => {
 		const summary = nestedSummaryFromAsyncStatus({
 			runId: "child-run",
@@ -347,7 +389,7 @@ describe("nested event parsing and projection", () => {
 			startedAt: 1,
 			processTerminal: { version: 1, state: "bogus", runId: "child-run", runnerProcessInstanceId: "runner-1" } as never,
 			steps: [{
-				agent: "worker",
+				agent: "builder",
 				status: "complete",
 				processTerminal: { version: 1, state: "observed", runId: "wrong-run", runnerProcessInstanceId: "runner-1" } as never,
 			}],
@@ -367,7 +409,7 @@ describe("nested event parsing and projection", () => {
 			startedAt: 1,
 			runtimeAcknowledgedExtensions: { version: 1, source: "child-runtime", ids: ["/Users/alice/.secret-extension", "ok-ext", "x".repeat(5000)], omitted: 0 } as never,
 			steps: [{
-				agent: "worker",
+				agent: "builder",
 				status: "complete",
 				runtimeAcknowledgedExtensions: { version: 1, source: "child-runtime", ids: ["C:/Users/alice/secret"], omitted: 0 } as never,
 			}],

package/dist/extensions/pi-subagents/test/unit/notify.test.ts

@@ -99,7 +99,7 @@ function createFakeClock() {
 function completionResult(overrides: Record<string, unknown> = {}) {
 	return {
 		id: `notify-${Math.random().toString(36).slice(2)}`,
-		agent: "worker",
+		agent: "builder",
 		success: true,
 		summary: "Done",
 		exitCode: 0,
@@ -110,12 +110,12 @@ function completionResult(overrides: Record<string, unknown> = {}) {
 }
 
 describe("registerSubagentNotify", () => {
-	it("uses a fallback summary when a background completion is empty", () => {
+	it("keeps a successful background completion hidden while waking the originating session", () => {
 		const { events, sent } = createPi();
 
 		events.emit(SUBAGENT_ASYNC_COMPLETE_EVENT, {
 			id: "notify-empty-1",
-			agent: "worker",
+			agent: "builder",
 			success: true,
 			summary: "",
 			exitCode: 0,
@@ -127,8 +127,8 @@ describe("registerSubagentNotify", () => {
 		assert.deepEqual(sent[0], {
 			message: {
 				customType: "subagent-notify",
-				content: "Background task completed: **worker**\n\n(no output)",
-				display: true,
+				content: "Background task completed: **builder**\n\n(no output)",
+				display: false,
 			},
 			options: { triggerTurn: true },
 		});
@@ -140,6 +140,12 @@ describe("registerSubagentNotify", () => {
 		assert.equal(sent.length, 1);
 	});
 
+	it("does not wake the session when background delivery explicitly disables triggerTurn", async () => {
+		const { notifier, sent } = createPi("session-a");
+		assert.equal(await notifier.deliver(completionResult({ id: "direct-silent", triggerTurn: false })), true);
+		assert.deepEqual(sent[0]!.options, { triggerTurn: false });
+	});
+
 	it("suppresses local delivery after an acknowledged grouped intercom relay", async () => {
 		const { notifier, sent } = createPi("session-a");
 		assert.equal(await notifier.deliver(completionResult({ id: "intercom-delivered", intercomDelivered: true })), true);
@@ -163,7 +169,7 @@ describe("registerSubagentNotify", () => {
 			id: "foreground-run:0",
 			runId: "foreground-run",
 			source: "foreground",
-			agent: "reviewer",
+			agent: "commentator",
 			success: true,
 			summary: "Recovered final review",
 			exitCode: 0,
@@ -175,7 +181,7 @@ describe("registerSubagentNotify", () => {
 		assert.deepEqual(sent[0], {
 			message: {
 				customType: "subagent-notify",
-				content: "Detached foreground task completed: **reviewer**\n\nRecovered final review",
+				content: "Detached foreground task completed: **commentator**\n\nRecovered final review",
 				display: true,
 			},
 			options: { triggerTurn: true },
@@ -187,7 +193,7 @@ describe("registerSubagentNotify", () => {
 		events.emit(SUBAGENT_FOREGROUND_COMPLETE_EVENT, {
 			id: "foreground-run:0",
 			source: "foreground",
-			agent: "reviewer",
+			agent: "commentator",
 			success: true,
 			summary: "Recovered final review",
 			timestamp: 123,
@@ -202,7 +208,7 @@ describe("registerSubagentNotify", () => {
 
 		events.emit(SUBAGENT_ASYNC_COMPLETE_EVENT, {
 			id: "notify-summary-1",
-			agent: "worker",
+			agent: "builder",
 			success: true,
 			summary,
 			exitCode: 0,
@@ -216,8 +222,8 @@ describe("registerSubagentNotify", () => {
 		assert.deepEqual(sent[0], {
 			message: {
 				customType: "subagent-notify",
-				content: `Background task completed: **worker** (2/3)\n\n${summary}`,
-				display: true,
+				content: `Background task completed: **builder** (2/3)\n\n${summary}`,
+				display: false,
 			},
 			options: { triggerTurn: true },
 		});
@@ -228,7 +234,7 @@ describe("registerSubagentNotify", () => {
 
 		events.emit(SUBAGENT_ASYNC_COMPLETE_EVENT, {
 			id: "notify-path-1",
-			agent: "worker",
+			agent: "builder",
 			success: true,
 			summary: "Done",
 			exitCode: 0,
@@ -240,8 +246,8 @@ describe("registerSubagentNotify", () => {
 		assert.deepEqual(sent, [{
 			message: {
 				customType: "subagent-notify",
-				content: "Background task completed: **worker**\n\nDone\n\nSession file: /tmp/session.jsonl",
-				display: true,
+				content: "Background task completed: **builder**\n\nDone\n\nSession file: /tmp/session.jsonl",
+				display: false,
 			},
 			options: { triggerTurn: true },
 		}]);
@@ -252,7 +258,7 @@ describe("registerSubagentNotify", () => {
 
 		events.emit(SUBAGENT_ASYNC_COMPLETE_EVENT, {
 			id: "notify-paused-1",
-			agent: "worker",
+			agent: "builder",
 			success: false,
 			state: "paused",
 			summary: "Paused after interrupt. Waiting for explicit next action.",
@@ -264,7 +270,7 @@ describe("registerSubagentNotify", () => {
 		assert.deepEqual(sent[0], {
 			message: {
 				customType: "subagent-notify",
-				content: "Background task paused: **worker**\n\nPaused after interrupt. Waiting for explicit next action.",
+				content: "Background task paused: **builder**\n\nPaused after interrupt. Waiting for explicit next action.",
 				display: true,
 			},
 			options: { triggerTurn: true },
@@ -276,7 +282,7 @@ describe("registerSubagentNotify", () => {
 
 		events.emit(SUBAGENT_ASYNC_COMPLETE_EVENT, {
 			id: "notify-other-session",
-			agent: "worker",
+			agent: "builder",
 			success: true,
 			summary: "Other done",
 			timestamp: 100,
@@ -284,7 +290,7 @@ describe("registerSubagentNotify", () => {
 		});
 		events.emit(SUBAGENT_ASYNC_COMPLETE_EVENT, {
 			id: "notify-sessionless",
-			agent: "worker",
+			agent: "builder",
 			success: true,
 			summary: "Legacy cwd-scoped done",
 			timestamp: 101,
@@ -327,6 +333,11 @@ describe("registerSubagentNotify", () => {
 		assert.match(content, /^Background tasks completed \(3\): \*\*alpha\*\*, \*\*beta\*\*, \*\*gamma\*\*/);
 		assert.match(content, /1\. alpha\nalpha done/);
 		assert.match(content, /3\. gamma\ngamma done/);
+		assert.deepEqual(sent[0]!.message, {
+			customType: "subagent-notify",
+			content,
+			display: false,
+		});
 		assert.deepEqual(sent[0]!.options, { triggerTurn: true });
 	});
 
@@ -396,16 +407,16 @@ describe("registerSubagentNotify", () => {
 describe("completion formatting helpers", () => {
 	it("formats and parses a parallel handoff without folding it into the result preview", () => {
 		const content = formatSingleCompletion({
-			agent: "worker",
+			agent: "builder",
 			status: "completed",
 			resultPreview: "Done",
 			handoffPath: "/tmp/run/handoff.json",
 			sessionLabel: "Session file",
 			sessionValue: "/tmp/session.jsonl",
 		});
-		assert.equal(content, "Background task completed: **worker**\n\nDone\n\nParallel handoff: /tmp/run/handoff.json\n\nSession file: /tmp/session.jsonl");
+		assert.equal(content, "Background task completed: **builder**\n\nDone\n\nParallel handoff: /tmp/run/handoff.json\n\nSession file: /tmp/session.jsonl");
 		assert.deepEqual(parseSubagentNotifyContent(content), {
-			agent: "worker",
+			agent: "builder",
 			status: "completed",
 			resultPreview: "Done",
 			handoffPath: "/tmp/run/handoff.json",
@@ -414,7 +425,7 @@ describe("completion formatting helpers", () => {
 		});
 		assert.equal(buildCompletionDetails({
 			id: "run",
-			agent: "worker",
+			agent: "builder",
 			success: true,
 			summary: "Done",
 			parallelHandoff: { path: "/tmp/run/handoff.json" },
@@ -423,32 +434,32 @@ describe("completion formatting helpers", () => {
 
 	it("formatSingleCompletion mirrors the in-handler single message shape", () => {
 		const content = formatSingleCompletion({
-			agent: "worker",
+			agent: "builder",
 			status: "completed",
 			taskInfo: " (2/3)",
 			resultPreview: "Done",
 			sessionLabel: "Session file",
 			sessionValue: "/tmp/session.jsonl",
 		});
-		assert.equal(content, "Background task completed: **worker** (2/3)\n\nDone\n\nSession file: /tmp/session.jsonl");
+		assert.equal(content, "Background task completed: **builder** (2/3)\n\nDone\n\nSession file: /tmp/session.jsonl");
 	});
 
 	it("parses detached foreground notification content for the custom renderer", () => {
 		const content = formatSingleCompletion({
-			agent: "reviewer",
+			agent: "commentator",
 			status: "failed",
 			source: "foreground",
 			resultPreview: "Acceptance rejected",
 			sessionLabel: "Session file",
-			sessionValue: "/tmp/reviewer.jsonl",
+			sessionValue: "/tmp/commentator.jsonl",
 		});
 		assert.deepEqual(parseSubagentNotifyContent(content), {
-			agent: "reviewer",
+			agent: "commentator",
 			status: "failed",
 			source: "foreground",
 			resultPreview: "Acceptance rejected",
 			sessionLabel: "session file",
-			sessionValue: "/tmp/reviewer.jsonl",
+			sessionValue: "/tmp/commentator.jsonl",
 		});
 	});
 
@@ -480,38 +491,21 @@ describe("completion formatting helpers", () => {
 		assert.equal(buildCompletionDetails({ id: "x", agent: "w", success: true, summary: "ok", exitCode: 0, processSignal: "SIGTERM", timestamp: 1 }).status, "completed");
 	});
 
-	it("buildCompletionDetails falls back to the unknown agent label", () => {
-		const details: SubagentNotifyDetails = buildCompletionDetails({ id: "x", agent: null, success: true, summary: "ok", timestamp: 1 });
-		assert.equal(details.agent, "unknown");
-		assert.equal(details.status, "completed");
-	});
-
-	it("buildCompletionDetails prefers compact child summaries over the run summary", () => {
+	it("labels workflow completion and preserves its return/emit/trace preview", () => {
 		const details = buildCompletionDetails({
-			id: "x",
-			agent: "worker",
+			id: "workflow-run",
+			agent: "workflow",
 			success: true,
-			summary: "alpha:\nfull child prose that must not leak",
+			summary: "Workflow completed with 1 child run(s). Return: { answer: 42 } Emitted: ready Trace: 2 event(s).",
 			timestamp: 1,
-			results: [
-				{ agent: "alpha", status: "completed", summary: "Output saved to: /tmp/alpha.md (12 B, 1 line). Read this file if needed." },
-				{ agent: "beta", status: "failed", summary: "boom\n\nOutput saved to: /tmp/beta.md (5 B, 1 line). Read this file if needed." },
-			],
 		});
-		assert.match(details.resultPreview, /1\. alpha\nOutput saved to: \/tmp\/alpha\.md/);
-		assert.match(details.resultPreview, /2\. beta\nboom\n\nOutput saved to: \/tmp\/beta\.md/);
-		assert.doesNotMatch(details.resultPreview, /full child prose that must not leak/);
+		assert.equal(details.agent, "workflow");
+		assert.match(details.resultPreview, /Return: \{ answer: 42 \}.*Emitted: ready.*Trace: 2 event/);
 	});
 
-	it("buildCompletionDetails uses the single child summary without an index prefix", () => {
-		const details = buildCompletionDetails({
-			id: "x",
-			agent: "worker",
-			success: true,
-			summary: "ignored run summary",
-			timestamp: 1,
-			results: [{ agent: "worker", status: "completed", summary: "Output saved to: /tmp/out.md (8 B, 1 line). Read this file if needed." }],
-		});
-		assert.equal(details.resultPreview, "Output saved to: /tmp/out.md (8 B, 1 line). Read this file if needed.");
+	it("buildCompletionDetails falls back to the unknown agent label", () => {
+		const details: SubagentNotifyDetails = buildCompletionDetails({ id: "x", agent: null, success: true, summary: "ok", timestamp: 1 });
+		assert.equal(details.agent, "unknown");
+		assert.equal(details.status, "completed");
 	});
 });

package/dist/extensions/pi-subagents/test/unit/package-manifest.test.ts

@@ -26,7 +26,7 @@ const expectedHostPeerRanges = {
 const expectedHostDevVersions = {
 	"@earendil-works/pi-agent-core": "0.81.0",
 	"@earendil-works/pi-ai": "0.81.0",
-	"@selesai/code": "0.81.0",
+	"@selesai/code": "0.8.0",
 	"@earendil-works/pi-tui": "0.81.0",
 } satisfies Record<(typeof hostPeerPackages)[number], string>;
 
@@ -56,23 +56,40 @@ test("published extension APIs use supported package entrypoints", async () => {
 	assert.deepEqual(packageJson.exports, {
 		".": "./index.ts",
 		"./background-work": "./src/api/background-work.ts",
+		"./external-runs": "./src/api/external-runs.ts",
 		"./capability-ceiling": "./src/api/capability-ceiling.ts",
 		"./delegation": "./src/api/delegation.ts",
 		"./preflight": "./src/api/preflight.ts",
+		"./control-channel": "./src/api/control-channel.ts",
+		"./intercom-bridge": "./src/api/intercom-bridge.ts",
+		"./pi-args": "./src/api/pi-args.ts",
+		"./shared-types": "./src/api/shared-types.ts",
 	});
 	const backgroundWork = await import("pi-subagents/background-work");
 	assert.equal(backgroundWork.BACKGROUND_WORK_PROTOCOL_VERSION, 1);
 	assert.equal(backgroundWork.BACKGROUND_WORK_REGISTRY_KEY, "pi-subagents.background-work.v1");
+	const externalRuns = await import("pi-subagents/external-runs");
+	assert.equal(externalRuns.EXTERNAL_RUN_REGISTRY_VERSION, 1);
+	assert.equal(typeof externalRuns.registerExternalRunProvider, "function");
 	const capability = await import("pi-subagents/capability-ceiling");
 	assert.equal(capability.SUBAGENT_CAPABILITY_CEILING_VERSION, 1);
 	assert.equal(capability.SUBAGENT_CAPABILITY_CEILING_REGISTRY_KEY, "pi-subagents.capability-ceiling.v1");
 	const delegation = await import("pi-subagents/delegation");
-	assert.equal(delegation.SUBAGENT_DELEGATION_PROTOCOL_VERSION, 1);
-	assert.equal(delegation.SUBAGENT_DELEGATION_V2_PROTOCOL_VERSION, 2);
 	assert.equal(delegation.SUBAGENT_DELEGATION_REQUEST_EVENT, "prompt-template:subagent:request");
 	const preflight = await import("pi-subagents/preflight");
 	assert.equal(preflight.SUBAGENT_LAUNCH_CONTRACT_VERSION, 2);
 	assert.equal(typeof preflight.resolveSubagentLaunchContract, "function");
+	const controlChannel = await import("pi-subagents/control-channel");
+	assert.equal(typeof controlChannel.requestAsyncStop, "function");
+	const intercomBridge = await import("pi-subagents/intercom-bridge");
+	assert.equal(typeof intercomBridge.resolveIntercomSessionTarget, "function");
+	const piArgs = await import("pi-subagents/pi-args");
+	assert.equal(typeof piArgs.resolvePiLaunchToolPlan, "function");
+	assert.equal("buildPiArgs" in piArgs, false);
+	const sharedTypes = await import("pi-subagents/shared-types");
+	assert.equal(typeof sharedTypes.wrapForkTask, "function");
+	assert.equal(typeof sharedTypes.DEFAULT_FORK_PREAMBLE, "string");
+	assert.equal("TEMP_ROOT_DIR" in sharedTypes, false);
 });
 
 test("direct @earendil-works runtime imports are declared for CI installs", () => {

package/dist/extensions/pi-subagents/test/unit/parallel-handoff.test.ts

@@ -6,6 +6,7 @@ import { describe, it } from "node:test";
 import {
 	formatParallelHandoffReference,
 	writeParallelHandoffGroup,
+	writePendingParallelHandoff,
 } from "../../src/runs/shared/parallel-handoff.ts";
 import type { ParallelHandoffManifest } from "../../src/shared/types.ts";
 import type { WorktreeCleanupReport, WorktreeDiff, WorktreeSetup } from "../../src/runs/shared/worktree.ts";
@@ -46,6 +47,35 @@ function cleanup(state: "complete" | "partial" = "complete"): WorktreeCleanupRep
 }
 
 describe("parallel handoff", () => {
+	it("journals worktree ownership before child results exist", () => {
+		const dir = fs.mkdtempSync(path.join(os.tmpdir(), "pi-parallel-handoff-pending-"));
+		try {
+			const manifestPath = path.join(dir, "handoff.json");
+			const reference = writePendingParallelHandoff({
+				manifestPath,
+				runId: "run-pending",
+				mode: "parallel",
+				source: "foreground",
+				cwd: "/repo",
+				stepIndex: 0,
+				flatStartIndex: 0,
+				setup: {
+					...setup("/repo", "base-1"),
+					worktrees: [{ path: "/tmp/worktree-0", agentCwd: "/tmp/worktree-0", branch: "branch-0", index: 0, nodeModulesLinked: false, syntheticPaths: [] }],
+				},
+			});
+
+			assert.equal(reference.childCount, 0);
+			assert.equal(reference.cleanupState, "partial");
+			const manifest = JSON.parse(fs.readFileSync(manifestPath, "utf-8")) as ParallelHandoffManifest;
+			assert.equal(manifest.groups[0]?.cleanup.tasks[0]?.path, "/tmp/worktree-0");
+			assert.equal(manifest.groups[0]?.cleanup.tasks[0]?.preserved, true);
+			assert.match(manifest.groups[0]?.cleanup.tasks[0]?.reason ?? "", /cleanup pending/);
+		} finally {
+			fs.rmSync(dir, { recursive: true, force: true });
+		}
+	});
+
 	it("writes and aggregates versioned worktree handoff groups", () => {
 		const dir = fs.mkdtempSync(path.join(os.tmpdir(), "pi-parallel-handoff-"));
 		try {
@@ -59,16 +89,16 @@ describe("parallel handoff", () => {
 				stepIndex: 2,
 				flatStartIndex: 3,
 				setup: setup("/repo", "base-1"),
-				diffs: [diff(dir, 0, "worker", true)],
+				diffs: [diff(dir, 0, "builder", true)],
 				cleanup: cleanup(),
 				results: [{
-					agent: "worker",
+					agent: "builder",
 					status: "completed",
 					summary: "implemented",
 					outputPath: "/artifacts/output.md",
 					structuredOutput: { ok: true },
 					structuredOutputPath: "/artifacts/structured.json",
-					sessionPath: "/sessions/worker.jsonl",
+					sessionPath: "/sessions/builder.jsonl",
 				}],
 				now: 100,
 			});
@@ -90,9 +120,9 @@ describe("parallel handoff", () => {
 				stepIndex: 1,
 				flatStartIndex: 1,
 				setup: setup("/repo", "base-1"),
-				diffs: [diff(dir, 1, "reviewer", false)],
+				diffs: [diff(dir, 1, "commentator", false)],
 				cleanup: cleanup("partial"),
-				results: [{ agent: "reviewer", status: "failed", summary: "blocked" }],
+				results: [{ agent: "commentator", status: "failed", summary: "blocked" }],
 				now: 200,
 			});
 			assert.equal(second.groupCount, 2);
@@ -159,9 +189,9 @@ describe("parallel handoff", () => {
 				stepIndex: 0,
 				flatStartIndex: 0,
 				setup: setup("/repo", "base-1"),
-				diffs: [diff(dir, 0, "worker", false)],
+				diffs: [diff(dir, 0, "builder", false)],
 				cleanup: cleanup(),
-				results: [{ agent: "worker", status: "completed" as const, summary: "done" }],
+				results: [{ agent: "builder", status: "completed" as const, summary: "done" }],
 			};
 			writeParallelHandoffGroup({ ...common, runId: "run-1" });
 			assert.throws(

package/dist/extensions/pi-subagents/test/unit/parallel-utils.test.ts

@@ -49,11 +49,11 @@ describe("flattenSteps", () => {
 
 	it("expands parallel groups into individual steps", () => {
 		const steps: RunnerStep[] = [
-			{ agent: "scout", task: "find info" },
+			{ agent: "explorer", task: "find info" },
 			{
 				parallel: [
-					{ agent: "reviewer-a", task: "review part 1" },
-					{ agent: "reviewer-b", task: "review part 2" },
+					{ agent: "commentator-a", task: "review part 1" },
+					{ agent: "commentator-b", task: "review part 2" },
 				],
 			},
 			{ agent: "summarizer", task: "combine" },
@@ -62,7 +62,7 @@ describe("flattenSteps", () => {
 		assert.equal(flat.length, 4);
 		assert.deepEqual(
 			flat.map((s) => s.agent),
-			["scout", "reviewer-a", "reviewer-b", "summarizer"],
+			["explorer", "commentator-a", "commentator-b", "summarizer"],
 		);
 	});
 
@@ -149,8 +149,8 @@ describe("mapConcurrent", () => {
 		// All workers should start nearly simultaneously
 		const d1 = startTimes[1]! - startTimes[0]!;
 		const d2 = startTimes[2]! - startTimes[0]!;
-		assert.ok(d1 < 20, `worker 1 should start immediately, got ${d1}ms delay`);
-		assert.ok(d2 < 20, `worker 2 should start immediately, got ${d2}ms delay`);
+		assert.ok(d1 < 20, `builder 1 should start immediately, got ${d1}ms delay`);
+		assert.ok(d2 < 20, `builder 2 should start immediately, got ${d2}ms delay`);
 	});
 
 	it("notifies scheduling settlement only after workers outliving an early rejection stop", async () => {
@@ -222,12 +222,12 @@ describe("DEFAULT_GLOBAL_CONCURRENCY_LIMIT", () => {
 describe("aggregateParallelOutputs", () => {
 	it("aggregates successful outputs with headers", () => {
 		const result = aggregateParallelOutputs([
-			{ agent: "reviewer-a", output: "Looks good", exitCode: 0 },
-			{ agent: "reviewer-b", output: "Needs fixes", exitCode: 0 },
+			{ agent: "commentator-a", output: "Looks good", exitCode: 0 },
+			{ agent: "commentator-b", output: "Needs fixes", exitCode: 0 },
 		]);
-		assert.ok(result.includes("=== Parallel Task 1 (reviewer-a) ==="));
+		assert.ok(result.includes("=== Parallel Task 1 (commentator-a) ==="));
 		assert.ok(result.includes("Looks good"));
-		assert.ok(result.includes("=== Parallel Task 2 (reviewer-b) ==="));
+		assert.ok(result.includes("=== Parallel Task 2 (commentator-b) ==="));
 		assert.ok(result.includes("Needs fixes"));
 	});
 

package/dist/extensions/pi-subagents/test/unit/path-handling.test.ts

@@ -96,7 +96,7 @@ describe("path.join vs template string concatenation", () => {
 
 	it("parallel subdir naming should use path.join", () => {
 		// settings.ts:302,306 pattern: `${subdir}/${task.output}`
-		const subdir = "parallel-0/0-_code-reviewer";
+		const subdir = "parallel-0/0-_code-commentator";
 		const output = "review.md";
 
 		const templateResult = `${subdir}/${output}`;
@@ -104,10 +104,10 @@ describe("path.join vs template string concatenation", () => {
 
 		// Both produce forward slashes here (subdir itself uses /).
 		// But if subdir comes from path.join on Windows, it would have backslashes.
-		const windowsSubdir = path.join("parallel-0", "0-_code-reviewer");
+		const windowsSubdir = path.join("parallel-0", "0-_code-commentator");
 		const windowsJoin = path.join(windowsSubdir, output);
 		// Consistent: all native separators
-		assert.equal(windowsJoin, path.join("parallel-0", "0-_code-reviewer", output));
+		assert.equal(windowsJoin, path.join("parallel-0", "0-_code-commentator", output));
 	});
 });
 

package/dist/extensions/pi-subagents/test/unit/permissions.test.ts

@@ -0,0 +1,46 @@
+import assert from "node:assert/strict";
+import { describe, it } from "node:test";
+import {
+	decodePermissionRules,
+	encodePermissionRules,
+	permissionArgsPreview,
+	permissionDecision,
+	resolvePermissionRules,
+	validatePermissionConfig,
+	validatePermissionRules,
+} from "../../src/runs/shared/permissions.ts";
+
+describe("native child permissions", () => {
+	it("defaults every unconfigured tool and bash to pass-through", () => {
+		assert.equal(permissionDecision(undefined, "write"), "allow");
+		assert.equal(permissionDecision({ write: "deny" }, "unknown_tool"), "allow");
+		assert.equal(permissionDecision({ write: "deny" }, "bash"), "allow");
+		assert.equal(resolvePermissionRules(), undefined);
+	});
+
+	it("merges explicit global and agent rules while removing explicit allow rules", () => {
+		assert.deepEqual(resolvePermissionRules(
+			{ rules: { write: "ask", edit: "deny" } },
+			{ write: "allow", read: "deny" },
+		), { edit: "deny", read: "deny" });
+	});
+
+	it("rejects bash and coordination-tool rules", () => {
+		assert.throws(() => validatePermissionRules({ bash: "ask" }, "permissions"), /pi-guard/);
+		assert.throws(() => validatePermissionRules({ contact_supervisor: "deny" }, "permissions"), /reserved for child coordination/);
+		assert.throws(() => validatePermissionConfig({ rules: { write: "sometimes" } }), /allow, ask, or deny/);
+	});
+
+	it("round-trips only explicit non-allow rules and redacts bounded previews", () => {
+		const encoded = encodePermissionRules({ write: "ask" });
+		assert.deepEqual(decodePermissionRules(encoded), { write: "ask" });
+		const preview = permissionArgsPreview({ token: "secret-value", content: `Bearer abcdefghijklmnop ${"x".repeat(3000)}` });
+		assert.doesNotMatch(preview, /secret-value|abcdefghijklmnop/);
+		assert.ok(Buffer.byteLength(preview) <= 2048);
+
+		const multibytePreview = permissionArgsPreview({ content: Array.from({ length: 10 }, () => "😀".repeat(300)) });
+		assert.ok(Buffer.byteLength(multibytePreview, "utf-8") <= 2048);
+		assert.doesNotMatch(multibytePreview, /�/);
+		assert.match(multibytePreview, /…$/);
+	});
+});