@scriptc/compiler 0.4.8 → 0.4.9

package/dist/frontend/lowering/lower-modules.js

@@ -33,7 +33,7 @@ import { collectJsonRequires, isJsonRequireDecl } from "./json-require.js";
 import { invalidJsonModuleDiag, unsupportedPackageImportDiag, } from "../../diagnostics/diagnostic.js";
 import { BOOL, CAUGHT, DYN, F64, RUNTIME_ERROR_CLASSES, STRING, VOID, arrayOf, canBoxFuncIntoDyn, canConvertToDyn, isUnitType, } from "../../ir/ir.js";
 import { ENTRY_NAME, PoisonError, boundIdentifiersOf, dynFallbackType, newFnCtx, staticImportNamespaceType, } from "./lowerer.js";
-import { isNativeFfiRequire, builtinMemberRequireDecl, builtinNamespaceDestructureModuleOf, createRequireBindingDecl, createRequireNamespaceDecl, createRequireProgramModuleDecl, } from "./builtins/module-bindings.js";
+import { isNativeFfiRequire, builtinMemberRequireDecl, builtinNamespaceDestructureModuleOf, createRequireBindingDecl, createRequireFactoryDecl, createRequireNamespaceDecl, createRequireProgramModuleDecl, } from "./builtins/module-bindings.js";
 import { isPromisifyCall, registerBuiltinCallableAlias } from "./builtins/callable-aliases.js";
 import { customInspectRegistrations } from "./lower-inspect.js";
 import { registerBuiltinClassAlias } from "./builtins/class-values.js";
@@ -48,7 +48,7 @@ import { streamClassAliasDecl } from "./lower-stream.js";
 import { isAssertClassNew } from "./assert-instances.js";
 import { stdlibGlobalAliasDecl, stdlibGlobalAliasNameOf, stdlibGlobalNameOf } from "./surfaces.js";
 import { isNativeBuiltinValueInitializer } from "./lower-builtin-values.js";
-import { isPromisePrototypeRead } from "./expressions/property-access.js";
+import { isDataViewPrototypeRead, isPromisePrototypeRead } from "./expressions/property-access.js";
 import { collectNamespaceStmt, nsMemberIdentOf, nsPathPrefix, trapDeclRootOf, } from "./lower-namespaces.js";
 import { collectExpandoMembers } from "./lower-expando.js";
 import { recordTextCodecClass } from "../../ir/ir.js";
@@ -91,11 +91,17 @@ function appendedEdgesOf(program, graph) {
     };
 }
 /** Lazy inline requires run after their module's top level: their modules
- * join the order afterwards, as in preflight's walk. */
-function visitLazyEdges(sf, edgesOf, state, visit) {
+ * join the order afterwards, as in preflight's walk. `lazyBases` records the
+ * stack depth of each enclosing subtree being entered here; a back edge into
+ * a module below it is a cache hit at run time (preflight's walk admits the
+ * same edges). */
+function visitLazyEdges(sf, edgesOf, state, visit, lazyBases, stackDepth) {
     for (const e of edgesOf(sf))
-        if (e.lazy === true && state.get(e.dep) === undefined)
+        if (e.lazy === true && state.get(e.dep) === undefined) {
+            lazyBases.push(stackDepth);
             visit(e.dep);
+            lazyBases.pop();
+        }
 }
 /** Program modules selected by statically resolved child_process.fork()
  * calls join the compiled graph without becoming startup dependencies of
@@ -117,6 +123,7 @@ function appendEntryModules(program, order, targets, paths, onCycle, graph) {
         state.set(sf, "done");
     const added = [];
     const stack = [];
+    const lazyBases = [];
     const staticEdgesOf = appendedEdgesOf(program, graph);
     const cycleAdmissionReason = makeCycleAdmission(program, (sf) => staticEdgesOf(sf).filter((e) => e.call === undefined));
     const visit = (sf) => {
@@ -136,6 +143,11 @@ function appendEntryModules(program, order, targets, paths, onCycle, graph) {
                     graph?.inlineCycleCalls?.add(edge.call);
                     continue;
                 }
+                // A back edge below the enclosing lazily-loaded subtree is a cache
+                // hit at run time; preflight's walk admits the same edges.
+                const lazyBase = lazyBases[lazyBases.length - 1];
+                if (lazyBase !== undefined && stack.indexOf(edge.dep.fileName) < lazyBase)
+                    continue;
                 const reason = cycleAdmissionReason(sf, edge);
                 if (reason !== null) {
                     const cycleStart = stack.indexOf(edge.dep.fileName);
@@ -148,7 +160,7 @@ function appendEntryModules(program, order, targets, paths, onCycle, graph) {
         stack.pop();
         state.set(sf, "done");
         added.push(sf);
-        visitLazyEdges(sf, staticEdgesOf, state, visit);
+        visitLazyEdges(sf, staticEdgesOf, state, visit, lazyBases, stack.length);
     };
     const knownTargets = new Set(targets);
     for (const path of paths) {
@@ -260,6 +272,7 @@ export function appendDynamicImportModules(program, order, onCycle, graph) {
         state.set(sf, "done");
     const added = [];
     const stack = [];
+    const lazyBases = [];
     const staticEdgesOf = appendedEdgesOf(program, graph);
     const cycleAdmissionReason = makeCycleAdmission(program, (sf) => staticEdgesOf(sf).filter((e) => e.call === undefined));
     const visit = (sf) => {
@@ -278,6 +291,11 @@ export function appendDynamicImportModules(program, order, onCycle, graph) {
                     graph?.inlineCycleCalls?.add(e.call);
                     continue;
                 }
+                // A back edge below the enclosing lazily-loaded subtree is a cache
+                // hit at run time; preflight's walk admits the same edges.
+                const lazyBase = lazyBases[lazyBases.length - 1];
+                if (lazyBase !== undefined && stack.indexOf(e.dep.fileName) < lazyBase)
+                    continue;
                 // A back edge: Node answers it from the cache. Same admission
                 // question as preflight's static walk, same fence when refused.
                 const reason = cycleAdmissionReason(sf, e);
@@ -292,7 +310,7 @@ export function appendDynamicImportModules(program, order, onCycle, graph) {
         stack.pop();
         state.set(sf, "done");
         added.push(sf);
-        visitLazyEdges(sf, staticEdgesOf, state, visit);
+        visitLazyEdges(sf, staticEdgesOf, state, visit, lazyBases, stack.length);
     };
     const scanned = new Set();
     for (;;) {
@@ -866,9 +884,12 @@ export function moduleArtifacts(lowerer, functions) {
                 case "unionKeyGet":
                 case "unionIsTag":
                 case "unionEq":
-                case "fieldAbsent":
                     visitUnion(node.unionId);
                     break;
+                case "fieldAbsent":
+                    if (node.unionId !== undefined)
+                        visitUnion(node.unionId);
+                    break;
                 case "unionRetype":
                     visitUnion(node.fromId);
                     visitUnion(node.unionId);
@@ -1248,7 +1269,7 @@ function withoutRejectedClassMembers(lowerer, expression, type) {
     if (!shape.fields.some((f) => rejected(f.type)))
         return type;
     const kept = shape.fields.filter((f) => !rejected(f.type));
-    const shapeId = lowerer.shapes.intern(kept.map((f) => ({ name: f.name, type: f.type })), false, shape.indexValue);
+    const shapeId = lowerer.shapes.intern(kept.map((f) => ({ ...f })), false, shape.indexValue);
     return { kind: "record", shapeId };
 }
 export function collectGlobals(lowerer, sf, topStmts) {
@@ -1935,6 +1956,10 @@ export function collectGlobals(lowerer, sf, topStmts) {
             // lowering skips it by the same test.
             if (createRequireBindingDecl(lowerer, decl.name, decl.initializer))
                 continue;
+            // `const { createRequire: cr } = require("node:module")` at file
+            // scope: the factory binding is the same compile-time plumbing.
+            if (createRequireFactoryDecl(lowerer, decl.name, decl.initializer))
+                continue;
             // `const fs = require("node:fs")` through that binding at file
             // scope — a namespace import in const clothing, same story.
             if (isConst && createRequireNamespaceDecl(lowerer, decl.name, decl.initializer))
@@ -2033,7 +2058,8 @@ export function collectGlobals(lowerer, sf, topStmts) {
                     const initializer = decl.initializer ? stripTypeCasts(decl.initializer) : undefined;
                     if ((nameNode === decl.name &&
                         !decl.type &&
-                        isPromisePrototypeRead(lowerer, decl.initializer)) ||
+                        (isPromisePrototypeRead(lowerer, decl.initializer) ||
+                            isDataViewPrototypeRead(lowerer, decl.initializer))) ||
                         (isJsSourceFile(sf) &&
                             nameNode === decl.name &&
                             initializer &&