@scriptc/compiler 0.4.8 → 0.4.9

package/dist/ir/validate.js

@@ -414,6 +414,22 @@ export function validateModule(mod) {
                 });
             }
         }
+        for (const accessor of cls.viewAccessors ?? []) {
+            const helper = functionsByName.get(accessor.helper);
+            const receiver = helper?.params[0]?.type;
+            if (!helper ||
+                helper.params.length !== 1 ||
+                receiver?.kind !== "object" ||
+                receiver.className !== cls.name ||
+                helper.returnType.kind !== "dyn" ||
+                helper.captures !== undefined ||
+                helper.classCaptures !== undefined) {
+                errors.push({
+                    message: `class ${cls.name}: view accessor helper for ${accessor.member} must be a noncapturing (instance) => dyn function`,
+                    loc: cls.loc,
+                });
+            }
+        }
         for (const symbol of cls.symbolFields ?? []) {
             const global = "globalId" in symbol ? mod.globals?.find((global) => global.id === symbol.globalId) : null;
             if (("globalId" in symbol ? global?.type.kind !== "symbol" : symbol.wellKnown === "") ||
@@ -1468,6 +1484,10 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
                 // choose ARRAY_VALUE versus ARRAY_UNDEFINED before the final result
                 // is evaluated. Delegation also needs a local loop. Nested control
                 // flow is checked recursively; jumps still cannot leave the region.
+                // A value-position `delete` of an index-signature key lowers to its
+                // recordKeyDelete (frozen-guarded into a block when the record can
+                // freeze), and a value-position `delete` of an optional field to the
+                // recordSet that writes its absent state.
                 const allowed = new Set([
                     "varDecl",
                     "assign",
@@ -1475,6 +1495,7 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
                     "fieldSet",
                     "recordSet",
                     "recordKeySet",
+                    "recordKeyDelete",
                     "arraySet",
                     "arraySetLength",
                     "arraySetUndefined",
@@ -3018,13 +3039,20 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
                 break;
             }
             case "fieldAbsent": {
-                const def = unions.get(e.unionId);
-                if (!def)
-                    err(`fieldAbsent of undeclared union "${e.unionId}"`, e.loc);
-                else if (!def.arms.some((arm) => arm.kind === "undefinedT"))
-                    err(`fieldAbsent of ${e.unionId}: the union has no undefined arm`, e.loc);
-                if (e.type.kind !== "union" || e.type.unionId !== e.unionId)
-                    err("fieldAbsent must have its union type", e.loc);
+                if (e.unionId === undefined) {
+                    // The optional checked-dynamic slot's ABSENT marker.
+                    if (e.type.kind !== "dyn")
+                        err("fieldAbsent without a union must be dyn", e.loc);
+                }
+                else {
+                    const def = unions.get(e.unionId);
+                    if (!def)
+                        err(`fieldAbsent of undeclared union "${e.unionId}"`, e.loc);
+                    else if (!def.arms.some((arm) => arm.kind === "undefinedT"))
+                        err(`fieldAbsent of ${e.unionId}: the union has no undefined arm`, e.loc);
+                    if (e.type.kind !== "union" || e.type.unionId !== e.unionId)
+                        err("fieldAbsent must have its union type", e.loc);
+                }
                 if (!fieldSlotValues.has(e))
                     err("fieldAbsent outside a record field write", e.loc);
                 break;
@@ -4291,7 +4319,8 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
             e.fn === "https.requestAgentCb" ||
             e.fn === "https.requestUrlCb" ||
             e.fn === "http.requestDynCb" ||
-            e.fn === "https.requestDynCb") {
+            e.fn === "https.requestDynCb" ||
+            e.fn === "https.requestFnDynCb") {
             // The response listener: void, no params or exactly (res: httpReq).
             const cbT = e.args[e.fn === "http.requestCb"
                 ? 7
@@ -4301,11 +4330,13 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
                         ? 3
                         : e.fn === "http.requestDynCb" || e.fn === "https.requestDynCb"
                             ? 2
-                            : e.fn === "http.requestAgentCb"
-                                ? 8
-                                : e.fn === "https.requestAgentCb"
-                                    ? 10
-                                    : 1]?.type;
+                            : e.fn === "https.requestFnDynCb"
+                                ? 3
+                                : e.fn === "http.requestAgentCb"
+                                    ? 8
+                                    : e.fn === "https.requestAgentCb"
+                                        ? 10
+                                        : 1]?.type;
             let ok = cbT?.kind === "func" && cbT.ret.kind === "void" && cbT.params.length <= 1;
             if (ok && cbT?.kind === "func" && cbT.params.length === 1) {
                 ok = cbT.params[0].kind === "httpReq";
@@ -5816,6 +5847,7 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
                 e.fn === "emitter.emitErrorValue" ||
                 e.fn === "emitter.emitMixed" ||
                 e.fn === "emitter.hasTyped" ||
+                e.fn === "emitter.hasDyn" ||
                 e.fn === "emitter.listenersDyn" ||
                 e.fn === "emitter.count" ||
                 e.fn === "emitter.getMax" ||
@@ -6126,14 +6158,14 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
                     break;
                 }
                 if (exec.params.length === 2) {
-                    // The reject closure's one shape: (reason: %Error) => void.
+                    // The reject closure's shapes: (reason: %Error) => void, and the
+                    // checked-dynamic promise's (reason: dyn) => void.
                     const rj = exec.params[1];
-                    if (rj.kind !== "func" ||
-                        rj.ret.kind !== "void" ||
-                        rj.params.length !== 1 ||
-                        rj.params[0].kind !== "object" ||
-                        rj.params[0].className !== "%Error") {
-                        err("newPromise reject param must be (%Error) => void", e.loc);
+                    const param = rj.kind === "func" && rj.params.length === 1 ? rj.params[0] : null;
+                    const errorPin = param !== null && param.kind === "object" && param.className === "%Error";
+                    const dynPin = param !== null && param.kind === "dyn" && inner.kind === "dyn";
+                    if (rj.kind !== "func" || rj.ret.kind !== "void" || (!errorPin && !dynPin)) {
+                        err("newPromise reject param must be (%Error) => void or (dyn) => void", e.loc);
                     }
                 }
                 if (exec.params.length >= 1) {
@@ -6157,7 +6189,8 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
             }
             case "promiseWithResolvers": {
                 // The record shape: promise: Promise<T>, resolve: (T) => void
-                // (() => void when T is void), reject: (%Error) => void.
+                // (() => void when T is void), reject: (%Error) => void — or, for a
+                // promise whose settled value is unknown, (dyn) => void.
                 if (e.type.kind !== "record") {
                     err("promiseWithResolvers must have record type", e.loc);
                     break;
@@ -6184,12 +6217,16 @@ function validateFunction(fn, functions, ffiByName, classes, records, recordVali
                     : resolve.params.length !== 1 || !typeEquals(resolve.params[0], inner)) {
                     err(`promiseWithResolvers resolve param must match the promise's inner type`, e.loc);
                 }
+                const rejectParam = reject.kind === "func" ? reject.params[0] : undefined;
+                const rejectErrorPin = rejectParam !== undefined &&
+                    rejectParam.kind === "object" &&
+                    rejectParam.className === "%Error";
+                const rejectDynPin = rejectParam !== undefined && rejectParam.kind === "dyn";
                 if (reject.kind !== "func" ||
                     reject.ret.kind !== "void" ||
                     reject.params.length !== 1 ||
-                    reject.params[0].kind !== "object" ||
-                    reject.params[0].className !== "%Error") {
-                    err("promiseWithResolvers reject must be (%Error) => void", e.loc);
+                    (!rejectErrorPin && !(rejectDynPin && inner.kind === "dyn"))) {
+                    err("promiseWithResolvers reject must be (%Error) => void or (dyn) => void", e.loc);
                 }
                 break;
             }