@sapui5/sap.ushell 1.136.3 → 1.138.1

package/src/main/js/sap/ushell/services/CommonDataModel/PersonalizationProcessor.js

@@ -7,15 +7,14 @@ sap.ui.define([
     "sap/base/util/isEmptyObject",
     "sap/base/util/ObjectPath",
     "sap/ui/thirdparty/jquery"
-], function (
+], (
     Log,
     deepClone,
     extend,
     isEmptyObject,
     ObjectPath,
     jQuery
-) {
-
+) => {
     "use strict";
 
     /**
@@ -45,7 +44,7 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._getItemIndex = function (aItemArray, sItemId) {
-        var iResult;
+        let iResult;
 
         for (iResult = 0; iResult < aItemArray.length; iResult++) {
             if (aItemArray[iResult].id === sItemId) {
@@ -74,8 +73,8 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._applyRenameGroup = function (sGroupId, sNewTitle, oOriginalSite) {
-        var oGroup,
-            bGroupHasBeenRenamed = false;
+        let oGroup;
+        let bGroupHasBeenRenamed = false;
 
         if (!sNewTitle) {
             return false;
@@ -109,7 +108,7 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._applyGroupVisibility = function (sGroupId, bGroupVisibility, oOriginalSite) {
-        var bGroupVisibilityHasBeenChanged = false;
+        let bGroupVisibilityHasBeenChanged = false;
 
         if (bGroupVisibility === undefined) {
             return false;
@@ -137,8 +136,8 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype.mixinPersonalization = function (oOriginalSite, oPersonalizationDelta) {
-        var oDeferred = new jQuery.Deferred(),
-            that = this;
+        const oDeferred = new jQuery.Deferred();
+        const that = this;
 
         // in case there is no personalization delta available, resolve the site
         if (!oPersonalizationDelta || isEmptyObject(oPersonalizationDelta)) {
@@ -152,8 +151,8 @@ sap.ui.define([
         // PLUS decouple that code (remove item handling code):
         if (oPersonalizationDelta.groups) {
             // iterate over groups in personalization delta which have changes (NOT new groups!):
-            Object.keys(oPersonalizationDelta.groups).forEach(function (sGroupId) {
-                var oGroup = oPersonalizationDelta.groups[sGroupId];
+            Object.keys(oPersonalizationDelta.groups).forEach((sGroupId) => {
+                const oGroup = oPersonalizationDelta.groups[sGroupId];
 
                 if (oOriginalSite.groups[sGroupId]) {
                     // check for changes in the identification part of the respective group
@@ -181,7 +180,7 @@ sap.ui.define([
 
         // Removed groups to apply?:
         if (oPersonalizationDelta.removedGroups && Array.isArray(oPersonalizationDelta.removedGroups)) {
-            oPersonalizationDelta.removedGroups.forEach(function (sGroupIdent) {
+            oPersonalizationDelta.removedGroups.forEach((sGroupIdent) => {
                 that._applyRemoveGroup(oOriginalSite, sGroupIdent);
             });
         }
@@ -213,7 +212,7 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._applyAddGroups = function (oOriginalSite, oPersonalizationDelta) {
-        var aNewGroupsByAdmin = [];
+        const aNewGroupsByAdmin = [];
 
         oOriginalSite.site = oOriginalSite.site || {};
         oOriginalSite.site.payload = oOriginalSite.site.payload || {};
@@ -221,7 +220,7 @@ sap.ui.define([
         oOriginalSite.groups = oOriginalSite.groups || {};
 
         if (Array.isArray(oPersonalizationDelta.groupOrder)) {
-            oOriginalSite.site.payload.groupsOrder.forEach(function (sGroupId) {
+            oOriginalSite.site.payload.groupsOrder.forEach((sGroupId) => {
                 // Extract groups which got newly assigned
                 if (oPersonalizationDelta.groupOrder.indexOf(sGroupId) === -1) {
                     if ((oPersonalizationDelta.removedGroups && oPersonalizationDelta.removedGroups.indexOf(sGroupId) === -1)
@@ -239,7 +238,7 @@ sap.ui.define([
             && oPersonalizationDelta.addedGroups
             && Object.keys(oPersonalizationDelta.addedGroups).length > 0
         ) {
-            Object.keys(oPersonalizationDelta.addedGroups).forEach(function (sGroupId) {
+            Object.keys(oPersonalizationDelta.addedGroups).forEach((sGroupId) => {
                 // clone the added groups to prevent the personalization delta from being changed
                 // when the tiles are added to this group later on
                 oOriginalSite.groups[sGroupId] = deepClone(oPersonalizationDelta.addedGroups[sGroupId], 20);
@@ -252,7 +251,7 @@ sap.ui.define([
             oOriginalSite.site.payload.groupsOrder = oPersonalizationDelta.groupOrder;
         }
 
-        aNewGroupsByAdmin.forEach(function (sNewlyAddedGroupId) {
+        aNewGroupsByAdmin.forEach((sNewlyAddedGroupId) => {
             oOriginalSite.site.payload.groupsOrder.push(sNewlyAddedGroupId);
         });
     };
@@ -304,32 +303,30 @@ sap.ui.define([
      * @param {object} oPersonalizationDelta The personalization delta to be applied.
      */
     PersonalizationProcessor.prototype._applyTileSettings = function (oSite, oPersonalizationDelta) {
-        var aGroups, aModifiedTiles;
-
         if (!oPersonalizationDelta.modifiedTiles) {
             return;
         }
 
-        aGroups = Object.keys(oSite.groups)
+        const aGroups = Object.keys(oSite.groups)
             .map(function (key) {
                 return this[key];
             }, oSite.groups);
 
-        aModifiedTiles = Object.keys(oPersonalizationDelta.modifiedTiles)
+        const aModifiedTiles = Object.keys(oPersonalizationDelta.modifiedTiles)
             .map(function (key) {
                 return this[key];
             }, oPersonalizationDelta.modifiedTiles);
 
-        aGroups.some(function (oGroup) {
-            ["tiles", "links"].forEach(function (sTileType) {
+        aGroups.some((oGroup) => {
+            ["tiles", "links"].forEach((sTileType) => {
                 if (oGroup.payload[sTileType]) {
-                    oGroup.payload[sTileType].some(function (oTile) {
+                    oGroup.payload[sTileType].some((oTile) => {
                         // If oTile was modified, and the modification was applied
                         // we should remove that modification (identified by its index)
                         // in the list of ones waiting to be applied.
-                        var iProcessedIndex;
+                        let iProcessedIndex;
 
-                        aModifiedTiles.some(function (oUserTile, iIndex) {
+                        aModifiedTiles.some((oUserTile, iIndex) => {
                             if (oUserTile.id === oTile.id) {
                                 if (oUserTile.title !== undefined) {
                                     oTile.title = oUserTile.title;
@@ -431,9 +428,9 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._addGroupToPersonalizationDelta = function (oPersonalizedSite, oPersonalizationDelta, sGroupId) {
-        var bSuccess = false,
-            aGroupsOrder,
-            oNewPersonalizedGroup;
+        let bSuccess = false;
+        let aGroupsOrder;
+        let oNewPersonalizedGroup;
 
         if (oPersonalizedSite && oPersonalizedSite.site && oPersonalizedSite.site.payload
             && oPersonalizedSite.site.payload.groupsOrder
@@ -449,7 +446,7 @@ sap.ui.define([
             oPersonalizationDelta.addedGroups = oPersonalizationDelta.addedGroups || {};
             oPersonalizationDelta.addedGroups[sGroupId] = {};
             oPersonalizationDelta.addedGroups[sGroupId].identification = extend({}, oNewPersonalizedGroup.identification);
-            // TODO: assumtion is: this is not needed...
+            // TODO: assumption is: this is not needed...
             oPersonalizationDelta.addedGroups[sGroupId].payload = extend({}, oNewPersonalizedGroup.payload);
             oPersonalizationDelta.addedGroups[sGroupId].payload.tiles = [];
             oPersonalizationDelta.addedGroups[sGroupId].payload.links = [];
@@ -461,7 +458,7 @@ sap.ui.define([
         return bSuccess;
     };
 
-    /**s
+    /** s
      * Extracts the personalization data from the given personalized site.
      * Therefore it creates a semantic diff out of the personalized site and the original site.
      *
@@ -473,12 +470,12 @@ sap.ui.define([
      * @returns {jQuery.Promise} Resolves the personalization delta.
      */
     PersonalizationProcessor.prototype.extractPersonalization = function (oPersonalizedSite, oOriginalSite) {
-        var oDeferred = new jQuery.Deferred(),
-            oPersonalizedSiteGroups,
-            oPersonalizationDelta = {},
-            oOriginalSiteGroups,
-            oExtractHelper,
-            that = this;
+        const oDeferred = new jQuery.Deferred();
+        let oPersonalizedSiteGroups;
+        const oPersonalizationDelta = {};
+        let oOriginalSiteGroups;
+        let oExtractHelper;
+        const that = this;
 
         if (oPersonalizedSite && oPersonalizedSite.groups && oOriginalSite && oOriginalSite.groups) {
             oPersonalizedSiteGroups = oPersonalizedSite.groups;
@@ -489,7 +486,7 @@ sap.ui.define([
             oExtractHelper = this._getExtractHelperObject(oOriginalSite, oPersonalizedSite, oPersonalizationDelta);
 
             // Iterate over original CDM site object to detect removed groups and items (tiles or links):
-            Object.keys(oOriginalSiteGroups).forEach(function (sGroupId) {
+            Object.keys(oOriginalSiteGroups).forEach((sGroupId) => {
                 that._checkRemoveGroup(oPersonalizedSite, oPersonalizationDelta, sGroupId);
                 // Check for (re-)moved(-) tiles: TODO: Add a line for checking links, too:
                 that._extractFromOriginalSiteOneGroup(oOriginalSite, oExtractHelper, sGroupId, "tiles");
@@ -497,7 +494,7 @@ sap.ui.define([
             });
 
             // Renamed and added groups: Iterate over groups of the personalized site (without handling payload like tiles or links):
-            Object.keys(oPersonalizedSiteGroups).forEach(function (sGroupId) {
+            Object.keys(oPersonalizedSiteGroups).forEach((sGroupId) => {
                 if (oOriginalSiteGroups[sGroupId]) {
                     that._checkRenameGroup(sGroupId, oPersonalizedSiteGroups, oOriginalSiteGroups, oPersonalizationDelta);
                     that._checkGroupVisibility(sGroupId, oPersonalizedSiteGroups, oOriginalSiteGroups, oPersonalizationDelta);
@@ -552,7 +549,7 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._checkRemoveGroup = function (oPersonalizedSite, oPersonalizationDelta, sOriginalGroupId) {
-        var bSuccess = false;
+        let bSuccess = false;
 
         if (oPersonalizedSite && oPersonalizedSite.groups && oPersonalizationDelta && sOriginalGroupId) {
             if (!oPersonalizedSite.groups[sOriginalGroupId]) {
@@ -591,9 +588,9 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._applyRemoveGroup = function (oOriginalSite, sGroupId) {
-        var oOriginalGroups,
-            aGroupsOrder,
-            iGroupPos;
+        let oOriginalGroups;
+        let aGroupsOrder;
+        let iGroupPos;
 
         if (oOriginalSite && oOriginalSite.groups && oOriginalSite.site
             && oOriginalSite.site.payload && oOriginalSite.site.payload.groupsOrder
@@ -635,10 +632,10 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._checkMoveGroup = function (oPersonalizedSite, oOriginalSite, oPersonalizationDelta) {
-        var aPersonalizedGroupsOrder,
-            aOriginalGroupsOrder,
-            bOrderArraysDiffer = false,
-            bSuccess = false;
+        let aPersonalizedGroupsOrder;
+        let aOriginalGroupsOrder;
+        let bOrderArraysDiffer = false;
+        let bSuccess = false;
 
         if (oPersonalizedSite.site
             && oPersonalizedSite.site.payload
@@ -653,8 +650,8 @@ sap.ui.define([
             // Try all to avoid inner loop to compare the arrays element wise:
             if (aPersonalizedGroupsOrder.length === aOriginalGroupsOrder.length) {
                 bOrderArraysDiffer = (function () {
-                    var bState = false,
-                        iIndex;
+                    let bState = false;
+                    let iIndex;
                     for (iIndex = 0; iIndex < aOriginalGroupsOrder.length; iIndex++) {
                         if (aOriginalGroupsOrder[iIndex] !== aPersonalizedGroupsOrder[iIndex]) {
                             bState = true;
@@ -686,7 +683,7 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._applyMoveGroup = function (oOriginalSite, oPersonalizationDelta) {
-        var bSuccess = false;
+        let bSuccess = false;
 
         if (Array.isArray(oPersonalizationDelta.groupOrder)) {
             oOriginalSite.site = oOriginalSite.site || {};
@@ -734,7 +731,7 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._getHashedItemsFromSite = function (oSiteObject) {
-        var oResult = null;
+        let oResult = null;
 
         // TODO: Generalize "Tiles" into "Items"... but without an extra parameter.
 
@@ -743,19 +740,19 @@ sap.ui.define([
         if (oSiteObject && oSiteObject.groups) {
             if (Object.keys(oSiteObject.groups).length > 0) {
                 oResult = {};
-                Object.keys(oSiteObject.groups).forEach(function (sGroupId) {
-                    var oGroup = oSiteObject.groups[sGroupId],
-                        aGroupTiles;
+                Object.keys(oSiteObject.groups).forEach((sGroupId) => {
+                    const oGroup = oSiteObject.groups[sGroupId];
+                    let aGroupTiles;
 
                     oResult[sGroupId] = {};
                     // TODO: For generalizing to tiles: Externalize code as new method:
                     if (oGroup.payload) {
-                        ["tiles", "links"].forEach(function (sTileType) {
+                        ["tiles", "links"].forEach((sTileType) => {
                             oResult[sGroupId][sTileType] = {};
                             if (Array.isArray(oGroup.payload[sTileType])) {
                                 aGroupTiles = oGroup.payload[sTileType];
-                                aGroupTiles.forEach(function (oItem, iIndex) {
-                                    var sItemId;
+                                aGroupTiles.forEach((oItem, iIndex) => {
+                                    let sItemId;
 
                                     if (oItem && oItem.id) {
                                         sItemId = oItem.id;
@@ -802,7 +799,7 @@ sap.ui.define([
      * @see _getHashedItemsFromSite
      */
     PersonalizationProcessor.prototype._getExtractHelperObject = function (oOriginalSite, oPersonalizedSite, oPersonalizationDelta) {
-        var oResult = null;
+        let oResult = null;
 
         oResult = {};
         oResult.oHashedItemsOriginal = this._getHashedItemsFromSite(oOriginalSite) || {}; // empty original site is ok
@@ -818,13 +815,13 @@ sap.ui.define([
      * Iterates over all items (tiles or links) on the given group in <b>original site</b>.
      * thereby checking for moved or removed items.
      *
-     * @param oOriginalSite
+     * @param {object} oOriginalSite
      *   Original site object (admin site) with no personalization.
-     * @param oExtractHelper
+     * @param {object} oExtractHelper
      *   Our temporary data structure for computing differences regarding tiles.
-     * @param sGroupId
+     * @param {string} sGroupId
      *   ID of the group handled currently.
-     * @param sItemType
+     * @param {string} sItemType
      *   Type of item. Currently with two possible values: "tiles" (default) and "links".
      *
      * @returns {boolean}
@@ -834,11 +831,10 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._extractFromOriginalSiteOneGroup = function (oOriginalSite, oExtractHelper, sGroupId, sItemType) {
-        var bSuccess = false,
-            aOriginalItems,
-            oMovedTiles,
-            fMarkAsReMoved,
-            sPersonalizedDeltaType = "movedTiles";
+        let bSuccess = false;
+        let aOriginalItems;
+        let oMovedTiles;
+        let sPersonalizedDeltaType = "movedTiles";
 
         sItemType = sItemType || "tiles"; // Define default
 
@@ -847,11 +843,11 @@ sap.ui.define([
         }
 
         // Define inner helper method for creating a "removed entry" in oExtractHelper.oPersonalizationDelta.movedTiles / moveLinks:
-        fMarkAsReMoved = function (sOriginalItemId, sFromGroupId) {
+        function fMarkAsReMoved (sOriginalItemId, sFromGroupId) {
             oMovedTiles[sOriginalItemId] = oMovedTiles[sOriginalItemId] ? oMovedTiles[sOriginalItemId] : {};
             oMovedTiles[sOriginalItemId].fromGroup = sFromGroupId;
             oMovedTiles[sOriginalItemId].toGroup = null;
-        };
+        }
 
         if (oExtractHelper
             // Not needed here: && oExtractHelper.oHashedItemsOriginal
@@ -869,7 +865,7 @@ sap.ui.define([
             oMovedTiles = oExtractHelper.oPersonalizationDelta[sPersonalizedDeltaType];
             if (oExtractHelper.oHashedItemsPersonalized[sGroupId]) {
                 // Check for occurrence of item inside of the personalized object:
-                aOriginalItems.forEach(function (oItem) {
+                aOriginalItems.forEach((oItem) => {
                     if (!oExtractHelper.oHashedItemsPersonalized[sGroupId][sItemType][oItem.id]) {
                         // Item not found in personalization part => mark as (re)moved:
                         fMarkAsReMoved(oItem.id, sGroupId);
@@ -879,7 +875,7 @@ sap.ui.define([
             } else {
                 // Group not in personalized site object (because it was removed):
                 //  =>Mark *ALL* tiles of this group as (re)moved:
-                aOriginalItems.forEach(function (oItem) {
+                aOriginalItems.forEach((oItem) => {
                     fMarkAsReMoved(oItem.id, sGroupId);
                 });
                 bSuccess = true;
@@ -909,13 +905,13 @@ sap.ui.define([
      */
     PersonalizationProcessor.prototype._extractPersonalizationDeltaForTile = function (oPersonalizedItem, oExtractHelper, sGroupId, sItemType) {
         // Get original tile
-        var oOriginalItem = ObjectPath.get(["oHashedItemsOriginal", sGroupId, sItemType, oPersonalizedItem.id, "sItemId"], oExtractHelper);
+        const oOriginalItem = ObjectPath.get(["oHashedItemsOriginal", sGroupId, sItemType, oPersonalizedItem.id, "sItemId"], oExtractHelper);
         if (!oOriginalItem) {
             return false;
         }
 
         // Calculate personalization delta
-        var oModifiedTile = {};
+        const oModifiedTile = {};
 
         if (oPersonalizedItem.title !== oOriginalItem.title) {
             oModifiedTile.title = oPersonalizedItem.title;
@@ -940,7 +936,7 @@ sap.ui.define([
         if (!oExtractHelper.oPersonalizationDelta.modifiedTiles) {
             oExtractHelper.oPersonalizationDelta.modifiedTiles = {};
         }
-        var oModifiedTiles = oExtractHelper.oPersonalizationDelta.modifiedTiles;
+        const oModifiedTiles = oExtractHelper.oPersonalizationDelta.modifiedTiles;
         oModifiedTile.id = oPersonalizedItem.id;
         oModifiedTiles[oPersonalizedItem.id] = oModifiedTile;
 
@@ -971,13 +967,13 @@ sap.ui.define([
      */
     // TODO: Generalize "tileOrder" into "sItemOrder" (tileOrder || linkOrder).
     PersonalizationProcessor.prototype._extractFromPersonalizedSiteOneGroup = function (oPersonalizedSite, oExtractHelper, sGroupId, sItemType) {
-        var bSuccess = false,
-            oMovedTiles,
-            aTileOrder,
-            bTileOrderChanged = false,
-            aPersonalizedItems,
-            that = this,
-            sPersonalizedDeltaType = "movedTiles";
+        let bSuccess = false;
+        let oMovedTiles;
+        let aTileOrder;
+        let bTileOrderChanged = false;
+        let aPersonalizedItems;
+        const that = this;
+        let sPersonalizedDeltaType = "movedTiles";
 
         sItemType = sItemType || "tiles"; // Define default
         if ((sItemType !== "tiles") && (sItemType !== "links")) {
@@ -1003,7 +999,7 @@ sap.ui.define([
             oMovedTiles = oExtractHelper.oPersonalizationDelta[sPersonalizedDeltaType];
             aTileOrder = [];
 
-            aPersonalizedItems.forEach(function (oItem, iIndex) {
+            aPersonalizedItems.forEach((oItem, iIndex) => {
                 if (!oItem) {
                     return; // oItem is invalid => skip
                 }
@@ -1017,7 +1013,7 @@ sap.ui.define([
                     if (oMovedTiles[oItem.id]) {
                         Log.error(
                             "Extract personalization failed",
-                            "The Tile ID " + oItem.id + " is not unique in the site",
+                            `The Tile ID ${oItem.id} is not unique in the site`,
                             "PersonalizationProcessor"
                         );
                         delete (oMovedTiles[oItem.id]);
@@ -1085,8 +1081,8 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._cleanupRemovedGroups = function (oOriginalSite, oPersonalizationDelta) {
-        var aItems,
-            oMoveTileEntry;
+        let aItems;
+        let oMoveTileEntry;
 
         // TODO: Extend to handle "links", too.
 
@@ -1095,16 +1091,16 @@ sap.ui.define([
             && Array.isArray(oPersonalizationDelta.removedGroups)
             && (oPersonalizationDelta.removedGroups.length > 0)
         ) {
-            oPersonalizationDelta.removedGroups.forEach(function (sGroupId) {
+            oPersonalizationDelta.removedGroups.forEach((sGroupId) => {
                 if (oOriginalSite
                     && oOriginalSite.groups
                     && oOriginalSite.groups[sGroupId]
                     && oOriginalSite.groups[sGroupId].payload
                 ) {
-                    [{ sType: "tiles", sPersonalizationDeltaType: "movedTiles" }, { sType: "links", sPersonalizationDeltaType: "movedLinks" }].forEach(function (oTileType) {
+                    [{ sType: "tiles", sPersonalizationDeltaType: "movedTiles" }, { sType: "links", sPersonalizationDeltaType: "movedLinks" }].forEach((oTileType) => {
                         if (Array.isArray(oOriginalSite.groups[sGroupId].payload[oTileType.sType])) {
                             aItems = oOriginalSite.groups[sGroupId].payload[oTileType.sType];
-                            aItems.forEach(function (oItem) {
+                            aItems.forEach((oItem) => {
                                 if (oPersonalizationDelta[oTileType.sPersonalizationDeltaType]) {
                                     oMoveTileEntry = oPersonalizationDelta[oTileType.sPersonalizationDeltaType][oItem.id];
                                     if (oMoveTileEntry
@@ -1137,20 +1133,19 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._setItemOrderOnSiteCollection = function (aOriginalSiteItems, aItemOrder) {
-        var bSuccess = true,
-            iSiteItemsOrigLength = aOriginalSiteItems.length,
-            aSavedOriginal,
-            oSpareCollection = {},
-            iIndex,
-            oCurrentOriginalItem,
-            sCurrentItemId,
-            bFound;
+        let bSuccess = true;
+        const iSiteItemsOrigLength = aOriginalSiteItems.length;
+        const oSpareCollection = {};
+        let iIndex;
+        let oCurrentOriginalItem;
+        let sCurrentItemId;
+        let bFound;
 
         if (!Array.isArray(aOriginalSiteItems) || !Array.isArray(aOriginalSiteItems) || (aOriginalSiteItems.length !== aItemOrder.length)) {
             return false;
         }
 
-        aSavedOriginal = aOriginalSiteItems.splice(0, aOriginalSiteItems.length);
+        const aSavedOriginal = aOriginalSiteItems.splice(0, aOriginalSiteItems.length);
         for (iIndex = 0; iIndex < aItemOrder.length; iIndex++) {
             sCurrentItemId = aItemOrder[iIndex];
             oCurrentOriginalItem = aSavedOriginal.shift();
@@ -1206,9 +1201,9 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._setItemOrderOnSiteGroupForItemType = function (oOriginalGroup, oDeltaGroup, sItemType) {
-        var bSuccess = true,
-            bTempSuccess,
-            sItemOrder;
+        let bSuccess = true;
+        let bTempSuccess;
+        let sItemOrder;
 
         if ((sItemType === "tiles") || (sItemType === "links")) {
             sItemOrder = (sItemType === "tiles") ? "tileOrder" : "linkOrder";
@@ -1252,12 +1247,12 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._setItemOrderOnSite = function (oOriginalSite, oPersonalizationDelta) {
-        var bSuccess = true,
-            bTempSuccess,
-            that = this;
+        let bSuccess = true;
+        let bTempSuccess;
+        const that = this;
 
         if (oOriginalSite.groups && oPersonalizationDelta.groups) {
-            Object.keys(oPersonalizationDelta.groups).forEach(function (sGroupId) {
+            Object.keys(oPersonalizationDelta.groups).forEach((sGroupId) => {
                 if (oPersonalizationDelta.groups[sGroupId] && oOriginalSite.groups[sGroupId]) {
                     bTempSuccess = that._setItemOrderOnSiteGroupForItemType(oOriginalSite.groups[sGroupId], oPersonalizationDelta.groups[sGroupId], "tiles");
                     if (!bTempSuccess) { bSuccess = false; }
@@ -1277,10 +1272,12 @@ sap.ui.define([
      * That's true even for adding items or moving items across groups:
      * This method adds such "new" items to end of items array.
      *
-     * @param oOriginalSite
+     * @param {object} oOriginalSite
      *   Site without personalization. Have to be a valid CDM site object.
-     * @param oPersonalizationDelta
+     * @param {object} oPersonalizationDelta
      *   Personalization Delta. May be prefilled with some data or being an empty object. Must NOT be undefined.
+     * @param {string} sItemType
+     *   the type of the item.
      *
      * @returns {boolean}
      *   Returns TRUE if successfully and FALSE in case of at least on error.
@@ -1289,22 +1286,22 @@ sap.ui.define([
      * @see _setItemOrderOnSite
      */
     PersonalizationProcessor.prototype._applyMoveItemsWithoutOrder = function (oOriginalSite, oPersonalizationDelta, sItemType) {
-        var bSuccess = true,
-            bTempSuccess,
-            sTypeKey,
-            sItemOrder = "tileOrder",
-            oDeltaItem,
-            iItemIndex,
-            oTempItem,
-            aOriginalItems = [],
-            that = this;
+        let bSuccess = true;
+        let bTempSuccess;
+        let sTypeKey;
+        let sItemOrder = "tileOrder";
+        let oDeltaItem;
+        let iItemIndex;
+        let oTempItem;
+        let aOriginalItems = [];
+        const that = this;
 
         // Private inner function: Adds given item (tile or link) at end of corresponding array of specified group.
         // Note: Ordering will be done later in another method.
         // Uses outer variables "oPersonalizationDelta", "oOriginalSite", "sItemType" and "sItemOrder".
         // Returns TRUE if successfully and FALSE in case of at least on error.
         function fInsertItem (oCDMSiteItem, sGroupId) {
-            var bSuccess = true;
+            let bSuccess = true;
             if (oOriginalSite.groups[sGroupId]
                 && oOriginalSite.groups[sGroupId].payload
                 && oPersonalizationDelta.groups
@@ -1343,7 +1340,7 @@ sap.ui.define([
         }
 
         if (oPersonalizationDelta[sTypeKey]) {
-            Object.keys(oPersonalizationDelta[sTypeKey]).forEach(function (sItemId) {
+            Object.keys(oPersonalizationDelta[sTypeKey]).forEach((sItemId) => {
                 oDeltaItem = oPersonalizationDelta[sTypeKey][sItemId];
                 if (oDeltaItem.fromGroup) {
                     if (oDeltaItem.toGroup) {
@@ -1425,8 +1422,8 @@ sap.ui.define([
      * @private
      */
     PersonalizationProcessor.prototype._applyItemChanges = function (oOriginalSite, oPersonalizationDelta) {
-        var bSuccess = true, // Input data probably valid; We will set it to FALSE again later in case of an error...
-            bSuccessInner;
+        let bSuccess = true; // Input data probably valid; We will set it to FALSE again later in case of an error...
+        let bSuccessInner;
 
         bSuccessInner = this._applyMoveItemsWithoutOrder(oOriginalSite, oPersonalizationDelta, "tiles");
         if (!bSuccessInner) { bSuccess = false; }