@sapui5/sap.ushell 1.136.3 → 1.138.1

package/src/main/js/sap/ushell/components/contentFinderStandalone/controller/ContentFinderStandalone.controller.js

@@ -2,7 +2,7 @@
 
 /**
  * @file Controller for ContentFinderDialog standalone root view
- * @version 1.136.3
+ * @version 1.138.1
  */
 sap.ui.define([
     "sap/ui/core/mvc/Controller",
@@ -15,8 +15,7 @@ sap.ui.define([
     "sap/base/Log",
     "sap/ushell/services/MessageInternal",
     "sap/m/library"
-], function (
-    /** @type { typeof import("sap/ui/core/mvc/Controller").default} */
+], (
     Controller,
     WorkPageService,
     AppLifeCycleAI,
@@ -26,9 +25,8 @@ sap.ui.define([
     ushellResources,
     Log,
     Message,
-    /** @type {typeof import("sap/m/library")} */
-    Library
-) {
+    mobileLibrary
+) => {
     "use strict";
 
     /**
@@ -43,233 +41,235 @@ sap.ui.define([
      *
      * @since 1.123.0
      * @private
-     */
-    return Controller.extend("sap.ushell.components.contentFinderStandalone.controller.ContentFinderStandalone",
-        /** @lends sap.ushell.components.contentFinderStandalone.controller.ContentFinderStandalone.prototype */{
+     */ // eslint-disable-next-line max-len
+    return Controller.extend("sap.ushell.components.contentFinderStandalone.controller.ContentFinderStandalone", /** @lends sap.ushell.components.contentFinderStandalone.controller.ContentFinderStandalone.prototype */{
 
-            /**
-             * The init function called after the view was initialized.
-             *
-             * @since 1.123.0
-             * @private
-             */
-            onInit: function () {
-                this.oWorkPageService = new WorkPageService();
-                this.oCatalogService = new CatalogService();
-                this.oResourceBundle = this.getOwnerComponent().getModel("i18n").getResourceBundle();
+        /**
+         * The init function called after the view was initialized.
+         *
+         * @since 1.123.0
+         * @private
+         */
+        onInit: function () {
+            this.oWorkPageService = new WorkPageService();
+            this.oCatalogService = new CatalogService();
 
-                // Routing for 'AppFinder'
-                // todo: [FLPCOREANDUX-10024] remove this dependency
-                this.oShellUIService = AppLifeCycleAI.getShellUIService();
-                this.oRouter = Container.getRendererInternal().getRouter();
-                this.oRouter.getRoute("appfinder").attachMatched(this._handleContentFinderNavigation.bind(this));
-            },
+            // Routing for 'AppFinder'
+            // todo: [FLPCOREANDUX-10024] remove this dependency
+            this.oShellUIService = AppLifeCycleAI.getShellUIService();
+            this.oRouter = Container.getRendererInternal().getRouter();
+            this.oRouter.getRoute("appfinder").attachMatched(this._handleContentFinderNavigation.bind(this));
+        },
 
-            /**
-             * Handles the navigation to the content finder.
-             * Updates shell header title.
-             *
-             * @since 1.128.0
-             * @private
-             */
-            _handleContentFinderNavigation: function () {
-                this.oShellUIService.setTitle(ushellResources.i18n.getText("appFinderTitle"));
-            },
+        getResourceBundle: function () {
+            return this.getOwnerComponent().getResourceBundle();
+        },
 
-            /**
-             * Called when the appSearch component was created.
-             *
-             * Attaches the required event handling.
-             *
-             * @param {sap.ui.base.Event} oEvent The 'componentCreated' event.
-             *
-             * @since 1.123.0
-             * @private
-             */
-            appSearchComponentCreated: async function (oEvent) {
-                this.oComponent = oEvent.getParameter("component");
+        /**
+         * Handles the navigation to the content finder.
+         * Updates shell header title.
+         *
+         * @since 1.128.0
+         * @private
+         */
+        _handleContentFinderNavigation: function () {
+            this.oShellUIService.setTitle(ushellResources.i18n.getText("appFinderTitle"));
+        },
 
-                // Required to load the core-ext bundles to enable menubar, usersettings, search, ...
-                EventHub.emit("CenterViewPointContentRendered");
+        /**
+         * Called when the appSearch component was created.
+         *
+         * Attaches the required event handling.
+         *
+         * @param {sap.ui.base.Event} oEvent The 'componentCreated' event.
+         *
+         * @since 1.123.0
+         * @private
+         */
+        appSearchComponentCreated: async function (oEvent) {
+            this.oComponent = oEvent.getParameter("component");
 
-                this.oComponent.attachVisualizationFilterApplied(null, this._onVisualizationFilterApplied, this);
+            // Required to load the core-ext bundles to enable menubar, usersettings, search, ...
+            EventHub.emit("CenterViewPointContentRendered");
 
-                // Getting transformed initial filter parameters if available
-                const aInitialAvailableFilterTypes = this.oComponent.getSelectedVisualizationFilter();
-                const oFilterParams = this._transformFilterParams(aInitialAvailableFilterTypes);
+            this.oComponent.attachVisualizationFilterApplied(null, this._onVisualizationFilterApplied, this);
 
-                //we don't want to await this promise here but rather start both calls to loadVisualizations and getCatalogs in parallel and then await them after
-                const loadVizPromise = this.oWorkPageService.loadVisualizations(oFilterParams).then((oVisualizationData) => {
-                    this.oComponent.setVisualizationData(oVisualizationData);
-                }).catch((e) => {
-                    Log.error("ContentFinderStandalone: Visualization data loading failed: " + JSON.stringify(e));
-                    this.oComponent.setVisualizationData(undefined, undefined, this._getErrorOnLoadingMessage());
-                });
-                const loadCategoryPromise = this.setCategoryTree();
+            // Getting transformed initial filter parameters if available
+            const aInitialAvailableFilterTypes = this.oComponent.getSelectedVisualizationFilter();
+            const oFilterParams = this._transformFilterParams(aInitialAvailableFilterTypes);
 
-                // Temporary fallback to the classic AppFinder in case the Content Finder causes issues or does not show all required data.
-                const oUrl = new URL(location.href);
-                oUrl.searchParams.append("sap-ushell-xx-overwrite-config", "/core/workPages/contentFinderStandalone:false");
-                this.oComponent.getUiModel().setProperty("/linkToAppFinder", oUrl.toString());
-                await loadVizPromise;
-                await loadCategoryPromise;
-            },
+            //we don't want to await this promise here but rather start both calls to loadVisualizations and getCatalogs in parallel and then await them after
+            const loadVizPromise = this.oWorkPageService.loadVisualizations(oFilterParams).then((oVisualizationData) => {
+                this.oComponent.setVisualizationData(oVisualizationData);
+            }).catch((e) => {
+                Log.error(`ContentFinderStandalone: Visualization data loading failed: ${JSON.stringify(e)}`);
+                this.oComponent.setVisualizationData(undefined, undefined, this._getErrorOnLoadingMessage());
+            });
+            const loadCategoryPromise = this.setCategoryTree();
 
+            // Temporary fallback to the classic AppFinder in case the Content Finder causes issues or does not show all required data.
+            const oUrl = new URL(location.href);
+            oUrl.searchParams.append("sap-ushell-xx-overwrite-config", "/core/workPages/contentFinderStandalone:false");
+            this.oComponent.getUiModel().setProperty("/linkToAppFinder", oUrl.toString());
+            await loadVizPromise;
+            await loadCategoryPromise;
+        },
 
-            /**
-             * Sets the category tree for the ContentFinder.
-             *
-             * @returns {Promise<undefined>} Resolves with <code>undefined</code>.
-             */
-            setCategoryTree: async function () {
-                // fetch category data: catalogs
-                let oCatalogsResponse;
-                try {
-                    oCatalogsResponse = await this.oCatalogService.getCatalogs();
-                } catch (error) {
-                    Log.error("Catalog fetching failed with:" + JSON.stringify(error));
-                    return;
-                }
-
-                let aCategories = [];
-                if (oCatalogsResponse?.catalogs?.length > 0) {
-                    // prepare category tree with static categories
-                    aCategories = [
-                        {
-                            id: undefined,
-                            title: this.oResourceBundle.getText("ContentFinderStandalone.CategoryTree.Category.AllTiles"),
-                            filterIsTitle: true,
-                            inactive: false,
-                            allowedFilters: ["tiles"]
-                        },
-                        {
-                            id: "$$catalogs",
-                            title: this.oResourceBundle.getText("ContentFinderStandalone.CategoryTree.Category.Catalogs"),
-                            inactive: true,
-                            filterIsTitle: false,
-                            nodes: oCatalogsResponse?.catalogs,
-                            $count: oCatalogsResponse?.totalCount,
-                            allowedFilters: ["tiles"]
-                        }
-                    ];
-                }
 
-                this.oComponent.setCategoryTree(aCategories);
-            },
+        /**
+         * Sets the category tree for the ContentFinder.
+         *
+         * @returns {Promise<undefined>} Resolves with <code>undefined</code>.
+         */
+        setCategoryTree: async function () {
+            // fetch category data: catalogs
+            let oCatalogsResponse;
+            try {
+                oCatalogsResponse = await this.oCatalogService.getCatalogs();
+            } catch (error) {
+                Log.error(`Catalog fetching failed with:${JSON.stringify(error)}`);
+                return;
+            }
 
-            /**
-             * Called when a filter action was performed in the Content Finder, e.g. search, filter by type, catalog, etc.
-             *
-             * @param {sap.ui.base.Event} oEvent The 'visualizationFilterApplied' event
-             *
-             * @since 1.123.0
-             * @private
-             */
-            _onVisualizationFilterApplied: async function (oEvent) {
-                const oFilterParams = this._transformFilterParams(oEvent.getParameters());
-                let oVisualizationData;
-                let oErrorOnLoadVisualizations;
-                const categoryId = oEvent.getParameter("categoryId");
-                try {
-                    // the following are the same graph query with only difference CatalogService's one accepting the categoryId as a parameter
-                    if (categoryId) {
-                        oVisualizationData = await this.oCatalogService.loadVisualizations(categoryId, oFilterParams);
-                    } else {
-                        oVisualizationData = await this.oWorkPageService.loadVisualizations(oFilterParams);
+            let aCategories = [];
+            if (oCatalogsResponse?.catalogs?.length > 0) {
+                // prepare category tree with static categories
+                aCategories = [
+                    {
+                        id: undefined,
+                        title: this.getResourceBundle().getText("ContentFinderStandalone.CategoryTree.Category.AllTiles"),
+                        filterIsTitle: true,
+                        inactive: false,
+                        allowedFilters: ["tiles"]
+                    },
+                    {
+                        id: "$$catalogs",
+                        title: this.getResourceBundle().getText("ContentFinderStandalone.CategoryTree.Category.Catalogs"),
+                        inactive: true,
+                        filterIsTitle: false,
+                        nodes: oCatalogsResponse?.catalogs,
+                        $count: oCatalogsResponse?.totalCount,
+                        allowedFilters: ["tiles"]
                     }
-                } catch (e) {
-                    Log.error("ContentFinderStandalone: Visualization data loading failed: " + JSON.stringify(e));
+                ];
+            }
 
-                    const bIsPagination = Number(oFilterParams.skip) > 0;
-                    if (!bIsPagination) {
-                        // when the first page of visualizations cannot be loaded, the error message is shown
-                        oErrorOnLoadVisualizations = this._getErrorOnLoadingMessage();
-                    } else {
-                        // we're on a page > 1, so we show an error message
-                        new Message().error(this.getOwnerComponent().getModel("i18n").getResourceBundle().getText("ContentFinderStandalone.AppSearch.NextPage.Error.Title"));
-                    }
+            this.oComponent.setCategoryTree(aCategories);
+        },
+
+        /**
+         * Called when a filter action was performed in the Content Finder, e.g. search, filter by type, catalog, etc.
+         *
+         * @param {sap.ui.base.Event} oEvent The 'visualizationFilterApplied' event
+         *
+         * @since 1.123.0
+         * @private
+         */
+        _onVisualizationFilterApplied: async function (oEvent) {
+            const oFilterParams = this._transformFilterParams(oEvent.getParameters());
+            let oVisualizationData;
+            let oErrorOnLoadVisualizations;
+            const categoryId = oEvent.getParameter("categoryId");
+            try {
+                // the following are the same graph query with only difference CatalogService's one accepting the categoryId as a parameter
+                if (categoryId) {
+                    oVisualizationData = await this.oCatalogService.loadVisualizations(categoryId, oFilterParams);
+                } else {
+                    oVisualizationData = await this.oWorkPageService.loadVisualizations(oFilterParams);
                 }
+            } catch (e) {
+                Log.error(`ContentFinderStandalone: Visualization data loading failed: ${JSON.stringify(e)}`);
 
-                this.oComponent.setVisualizationData(oVisualizationData, undefined, oErrorOnLoadVisualizations);
-            },
+                const bIsPagination = Number(oFilterParams.skip) > 0;
+                if (!bIsPagination) {
+                    // when the first page of visualizations cannot be loaded, the error message is shown
+                    oErrorOnLoadVisualizations = this._getErrorOnLoadingMessage();
+                } else {
+                    // we're on a page > 1, so we show an error message
+                    new Message().error(this.getResourceBundle().getText("ContentFinderStandalone.AppSearch.NextPage.Error.Title"));
+                }
+            }
 
-            /**
-             * Transforms the filter parameters received by the ContentFinder to a format required by the graphql API.
-             *
-             * @param {object} oParams The ContentFinder filter parameters.
-             * @returns {{top: int, skip: ?int, filter: object[]}} The filter parameters in graphql API format.
-             *
-             * @since 1.123.0
-             * @private
-             */
-            _transformFilterParams: function (oParams) {
-                const iTop = oParams?.pagination?.top;
-                const iSkip = oParams?.pagination?.skip;
-                const sSearchTerm = oParams?.search;
-                const aTypes = oParams?.types || [];
-                const aExpandedTypes = aTypes.length > 0 ? [{ in: aTypes }] : [];
-                const oSearchFilter = sSearchTerm
-                    ? {
-                        type: aExpandedTypes,
-                        descriptor: [
-                            {
-                                conditions: [
-                                    {
-                                        propertyPath: "/sap.app/title",
-                                        stringFilter: [{ containsIgnoreCase: sSearchTerm }]
-                                    }
-                                ]
-                            },
-                            {
-                                conditions: [
-                                    {
-                                        propertyPath: "/sap.app/subTitle",
-                                        stringFilter: [{ containsIgnoreCase: sSearchTerm }]
-                                    }
-                                ]
-                            },
-                            {
-                                conditions: [
-                                    {
-                                        propertyPath: "/sap.app/info",
-                                        stringFilter: [{ containsIgnoreCase: sSearchTerm }]
-                                    }
-                                ]
-                            },
-                            {
-                                conditions: [
-                                    {
-                                        propertyPath: "/sap.fiori/registrationIds",
-                                        anyFilter: [
-                                            {
-                                                conditions: [
-                                                    {
-                                                        stringFilter: [{ containsIgnoreCase: sSearchTerm }]
-                                                    }
-                                                ]
-                                            }
-                                        ]
-                                    }
-                                ]
-                            }
-                        ]
-                    }
-                    : { type: aExpandedTypes };
+            this.oComponent.setVisualizationData(oVisualizationData, undefined, oErrorOnLoadVisualizations);
+        },
+
+        /**
+         * Transforms the filter parameters received by the ContentFinder to a format required by the graphql API.
+         *
+         * @param {object} oParams The ContentFinder filter parameters.
+         * @returns {{top: int, skip: ?int, filter: object[]}} The filter parameters in graphql API format.
+         *
+         * @since 1.123.0
+         * @private
+         */
+        _transformFilterParams: function (oParams) {
+            const iTop = oParams?.pagination?.top;
+            const iSkip = oParams?.pagination?.skip;
+            const sSearchTerm = oParams?.search;
+            const aTypes = oParams?.types || [];
+            const aExpandedTypes = aTypes.length > 0 ? [{ in: aTypes }] : [];
+            const oSearchFilter = sSearchTerm
+                ? {
+                    type: aExpandedTypes,
+                    descriptor: [
+                        {
+                            conditions: [
+                                {
+                                    propertyPath: "/sap.app/title",
+                                    stringFilter: [{ containsIgnoreCase: sSearchTerm }]
+                                }
+                            ]
+                        },
+                        {
+                            conditions: [
+                                {
+                                    propertyPath: "/sap.app/subTitle",
+                                    stringFilter: [{ containsIgnoreCase: sSearchTerm }]
+                                }
+                            ]
+                        },
+                        {
+                            conditions: [
+                                {
+                                    propertyPath: "/sap.app/info",
+                                    stringFilter: [{ containsIgnoreCase: sSearchTerm }]
+                                }
+                            ]
+                        },
+                        {
+                            conditions: [
+                                {
+                                    propertyPath: "/sap.fiori/registrationIds",
+                                    anyFilter: [
+                                        {
+                                            conditions: [
+                                                {
+                                                    stringFilter: [{ containsIgnoreCase: sSearchTerm }]
+                                                }
+                                            ]
+                                        }
+                                    ]
+                                }
+                            ]
+                        }
+                    ]
+                }
+                : { type: aExpandedTypes };
 
-                return { top: iTop, skip: iSkip, filter: [oSearchFilter] };
-            },
+            return { top: iTop, skip: iSkip, filter: [oSearchFilter] };
+        },
 
-            /**
-             * Error message to show when loading (initially or on filter/search) the visualization data fails.
-             * @returns {object} The error message to be shown when the visualization data cannot be loaded.
-             */
-            _getErrorOnLoadingMessage: function () {
+        /**
+         * Error message to show when loading (initially or on filter/search) the visualization data fails.
+         * @returns {object} The error message to be shown when the visualization data cannot be loaded.
+         */
+        _getErrorOnLoadingMessage: function () {
 
-                return {
-                    type: Library.IllustratedMessageType.UnableToLoad,
-                    title: this.oResourceBundle.getText("ContentFinderStandalone.AppSearch.Error.LoadingApps.Title"),
-                    description: this.oResourceBundle.getText("ContentFinderStandalone.AppSearch.Error.LoadingApps.Details")
-                };
-            }
-        });
+            return {
+                type: mobileLibrary.IllustratedMessageType.UnableToLoad,
+                title: this.getResourceBundle().getText("ContentFinderStandalone.AppSearch.Error.LoadingApps.Title"),
+                description: this.getResourceBundle().getText("ContentFinderStandalone.AppSearch.Error.LoadingApps.Details")
+            };
+        }
+    });
 });

package/src/main/js/sap/ushell/components/contentFinderStandalone/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.contentFinderStandalone",
         "applicationVersion": {
-            "version": "1.136.3"
+            "version": "1.138.1"
         },
         "i18n": "./resources/resources.properties",
         "ach": "CA-FLP-FE-UI",
@@ -71,7 +71,10 @@
         "models": {
             "i18n": {
                 "type": "sap.ui.model.resource.ResourceModel",
-                "uri": "resources/resources.properties"
+                "settings": {
+                    "bundleName": "sap.ushell.components.contentFinderStandalone.resources.resources",
+                    "async": true
+                }
             }
         },
         "routing": {
@@ -84,12 +87,6 @@
         "contentDensities": {
             "compact": true,
             "cozy": true
-        },
-        "rootView": {
-            "viewName": "sap.ushell.components.contentFinderStandalone.view.ContentFinderStandalone",
-            "id": "contentFinderAppSearchView",
-            "type": "XML",
-            "async": true
         }
     }
-}
+}

package/src/main/js/sap/ushell/components/factsheet/Component.js

@@ -17,7 +17,7 @@ sap.ui.define([
 
         // use inline declaration instead of component.json to save 1 round trip
         metadata: {
-            version: "1.136.3",
+            version: "1.138.1",
             library: "sap.ushell",
             dependencies: {
                 libs: ["sap.m", "sap.ui.vbm", "sap.suite.ui.commons", "sap.ui.layout", "sap.viz"],

package/src/main/js/sap/ushell/components/factsheet/controls/PictureViewer.js

@@ -64,13 +64,13 @@ sap.ui.define([
         this.setEditable(false);
 
         if (sap.ui.getCore().isMobile()) {
-            jQuery(window).bind("tap", this._reset.bind(this));
+            jQuery(window).on("tap", this._reset.bind(this));
             var oStaticArea = sap.ui.getCore().getStaticAreaRef();
             this.$blocker = jQuery("<div class='sapCaPVBly sapUiBLy'></div>").css("visibility", "hidden");
             jQuery(oStaticArea).append(this.$blocker);
         }
         if (!sap.ui.getCore().isMobile()) {
-            jQuery(window).bind("resize", this._resize.bind(this));
+            jQuery(window).on("resize", this._resize.bind(this));
         }
 
         this.addStyleClass("sapCaPW");
@@ -102,13 +102,13 @@ sap.ui.define([
         this.$blocker.remove();
 
         if (!sap.ui.getCore().isMobile()) {
-            jQuery(window).unbind("resize", this._resize.bind(this));
+            jQuery(window).off("resize", this._resize.bind(this));
         }
 
         TileContainer.prototype.exit.apply(this);
 
         if (!Device.system.desktop) {
-            jQuery(window).unbind("tap", this._reset.bind(this));
+            jQuery(window).off("tap", this._reset.bind(this));
         }
     };
 
@@ -174,7 +174,7 @@ sap.ui.define([
     };
 
     PictureViewer.prototype.insertTile = function (oTile/*, iIndex*/) {
-        oTile.attachPictureDelete(jQuery.proxy(this._deletePictureRequestHandler, this));
+        oTile.attachPictureDelete(this._deletePictureRequestHandler.bind(this));
         TileContainer.prototype.insertTile.apply(this, arguments);
     };
 
@@ -207,7 +207,7 @@ sap.ui.define([
 
         if (pictureTileIndexToDelete > -1) {
             pictureTileToDelete = this.getTiles()[pictureTileIndexToDelete];
-            pictureTileToDelete.detachPictureDelete(jQuery.proxy(this._deletePictureRequestHandler, this));
+            pictureTileToDelete.detachPictureDelete(this._deletePictureRequestHandler.bind(this));
             this.deleteTile(pictureTileToDelete);
             this.removeAggregation("items", pictureTileIndexToDelete, true);
         } else {

package/src/main/js/sap/ushell/components/factsheet/factory/ThingInspector.js

@@ -249,7 +249,7 @@ sap.ui.define([
             oUrl = oUrl.replace(sPropertyName, sPropertyValue);
         }
         sNewValue = newModelValue(oUrl);
-        if ($.isNumeric(sNewValue)) {
+        if (typeof sNewValue === "number" && !isNaN(sNewValue)) {
             sValueFormat = this.mBindingInfos.value.parts.filter(function (obj) {
                 return (obj.path === sProperty);
             });
@@ -1833,7 +1833,7 @@ sap.ui.define([
             }
             if (oBinding.String) {
                 // Live KPIs detected
-                if ($.isNumeric(oBinding.String)) {
+                if (typeof oBinding.String === "number" && !isNaN(oBinding.String)) {
                     bIsNumeric = true;
                     oTile.setValue(kpiValueFormatter(oBinding.String, fractionDigits));
                 } else {
@@ -2327,7 +2327,7 @@ sap.ui.define([
                     var submitListener = function (oEvent) {
                         var oEventJSON, sSpot, oPopupJSON, popUpHeight, popUpWidth;
                         // Get the Spot on which was clicked
-                        oEventJSON = $.parseJSON(oEvent.getParameters().data);
+                        oEventJSON = JSON.parse(oEvent.getParameters().data);
                         if (oEventJSON.Action.name === "DETAIL_REQUEST" && oEventJSON.Action.instance) {
                             sSpot = oEventJSON.Action.instance;
                             // Parse index of clicked Spot
@@ -2493,7 +2493,7 @@ sap.ui.define([
                             var oGeoJSON, oGeoContentDetail, oTG, sJSON, i;
                             sJSON = data.ProjectJSON;
                             sJSON = sJSON.indexOf("{") ? sJSON.substr(sJSON.indexOf("{")) : sJSON; // Workaround: to get rid of a BOM character at the first position
-                            oGeoJSON = $.parseJSON(sJSON);
+                            oGeoJSON = JSON.parse(sJSON);
                             oGeoJSON.SAPVB.Scenes.Set.SceneGeo.initialStartPosition = sPos;
                             oGeoJSON.SAPVB.Scenes.Set.SceneGeo.initialZoom = 12;
                             // Register click/touch event on map

package/src/main/js/sap/ushell/components/homepage/ActionMode.js

@@ -20,7 +20,7 @@
  *  - Deactivation handler
  *  - Rendering tile action menu
  *
- * @version 1.136.3
+ * @version 1.138.1
  *
  * @deprecated since 1.112
  */

package/src/main/js/sap/ushell/components/homepage/Component.js

@@ -41,7 +41,7 @@ sap.ui.define([
             // This needs to be called _after_ the model is created
             UIComponent.prototype.init.apply(this, arguments);
 
-            return this.rootControlLoaded().then(function (oView) {
+            this.rootControlLoaded().then(function (oView) {
                 this.oDashboardView = oView;
 
                 // TODO: Please remove all 'NewHomepageManager' references after complete alignment!