@sapui5/sap.ushell 1.136.3 → 1.138.0

package/src/main/js/sap/ushell/services/CommonDataModel/SiteConverter.js

@@ -3,16 +3,16 @@
 /**
  * @fileOverview Because the personalization processor only works with a CDM 3.0 site, this converter is used to transform a dedicated
  * CDM 3.1 site object into a CDM 3.0 site and backwards.
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log"
-], function (
+], (
     Log
-) {
+) => {
     "use strict";
 
-    var SiteConverter = function () { };
+    function SiteConverter () { }
 
     /**
      * Forwarding of the convert requests to the corresponding function.
@@ -49,7 +49,7 @@ sap.ui.define([
      * @private
      */
     SiteConverter.prototype._convertPageToSite = function (page) {
-        var oConvertedSite = {
+        const oConvertedSite = {
             groups: {},
             _version: "3.0.0",
             site: {
@@ -60,10 +60,10 @@ sap.ui.define([
             }
         };
 
-        var oSections = page.payload.sections;
-        for (var i = 0; i < Object.keys(oSections).length; i++) {
-            var sSectionId = Object.keys(oSections)[i];
-            var oSection = page.payload.sections[sSectionId];
+        const oSections = page.payload.sections;
+        for (let i = 0; i < Object.keys(oSections).length; i++) {
+            const sSectionId = Object.keys(oSections)[i];
+            const oSection = page.payload.sections[sSectionId];
             oConvertedSite.groups[sSectionId] = {
                 identification: {
                     id: oSection.id,
@@ -102,7 +102,7 @@ sap.ui.define([
      * @private
      */
     SiteConverter.prototype._convertSiteToPage = function (site) {
-        var oConvertedPage = {
+        const oConvertedPage = {
             identification: site.site.identification,
             payload: {
                 layout: {
@@ -112,12 +112,12 @@ sap.ui.define([
             }
         };
 
-        var oGroups = site.groups;
-        var sGroupId;
-        var oGroup;
-        var oVizPayload;
+        const oGroups = site.groups;
+        let sGroupId;
+        let oGroup;
+        let oVizPayload;
 
-        for (var i = 0; i < Object.keys(oGroups).length; i++) {
+        for (let i = 0; i < Object.keys(oGroups).length; i++) {
             sGroupId = Object.keys(oGroups)[i];
             oGroup = site.groups[sGroupId];
             oVizPayload = this._createVizPayloadObject(oGroup.payload.tiles);
@@ -129,7 +129,7 @@ sap.ui.define([
                 viz: oVizPayload.viz
             };
 
-            var oSection = oConvertedPage.payload.sections[sGroupId];
+            const oSection = oConvertedPage.payload.sections[sGroupId];
             if ("isVisible" in oGroup.identification) {
                 oSection.visible = oGroup.identification.isVisible;
             }
@@ -158,10 +158,10 @@ sap.ui.define([
      * @private
      */
     SiteConverter.prototype._createVizPayloadObject = function (aTiles) {
-        var aVizOrder = [];
-        var oPayload = {};
+        const aVizOrder = [];
+        const oPayload = {};
 
-        var oViz = aTiles.reduce(function (oReturn, oTile) {
+        const oViz = aTiles.reduce((oReturn, oTile) => {
             aVizOrder.push(oTile.id);
             oReturn[oTile.id] = oTile;
             return oReturn;
@@ -183,7 +183,7 @@ sap.ui.define([
      * @private
      */
     SiteConverter.prototype._convertVizPayloadObjectToArray = function (oSection) {
-        return oSection.layout.vizOrder.reduce(function (aTiles, sVizId) {
+        return oSection.layout.vizOrder.reduce((aTiles, sVizId) => {
             aTiles.push(oSection.viz[sVizId]);
             return aTiles;
         }, []);

package/src/main/js/sap/ushell/services/CommonDataModel/vizTypeDefaults/VizTypeDefaults.js

@@ -2,7 +2,7 @@
 
 /**
  * @file Utility for loading the default visualization types for the CDM runtime.
- * @version 1.136.3
+ * @version 1.138.0
  */
 
 sap.ui.define([
@@ -12,15 +12,14 @@ sap.ui.define([
     "sap/base/util/extend",
     "sap/base/util/isEmptyObject",
     "sap/base/util/ObjectPath"
-], function (
+], (
     Log,
     Manifest,
     deepClone,
     extend,
     isEmptyObject,
     ObjectPath
-) {
-
+) => {
     "use strict";
 
     const O_STANDARD_VIZ_TYPES = {
@@ -30,7 +29,6 @@ sap.ui.define([
     };
 
     class VizTypeDefaults {
-
         static #instance = null;
         #oVizTypes = null;
 

package/src/main/js/sap/ushell/services/CommonDataModel.js

@@ -2,7 +2,7 @@
 
 /**
  * @file Exposes a CommonDataModel-based site document in a platform-neutral format to it's clients
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/services/CommonDataModel/PersonalizationProcessor",
@@ -1435,7 +1435,7 @@ sap.ui.define([
         }
 
         const oStandardVizTypes = await VizTypeDefaults.getAll();
-        Object.keys(oStandardVizTypes).map((sKey) => {
+        Object.keys(oStandardVizTypes).forEach((sKey) => {
             oSite.vizTypes[sKey] = oSite.vizTypes[sKey] || oStandardVizTypes[sKey];
         });
     };

package/src/main/js/sap/ushell/services/Configuration.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's Configuration service enables Components of any kind to consume parts of Configuration
  * provided by the shell. It allows to attach on updates and receive the current values
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/Config",

package/src/main/js/sap/ushell/services/ConfigurationDefaults.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's Configuration Defaults service exposes default configurations set in the code base.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/services/ContentExtensionAdapterFactory.js

@@ -4,7 +4,7 @@
  * @fileOverview Creates an adapter factory for data not handled by the default adapter.
  * Once instantiated, returns a map of adapters to be used by the LaunchPage Service
  *
- * @version 1.136.3
+ * @version 1.138.0
  * @deprecated since 1.120
  */
 sap.ui.define([

package/src/main/js/sap/ushell/services/CrossApplicationNavigation.js

@@ -6,7 +6,7 @@
  * It exposes interfaces to perform a hash change and/or trigger an external navigation.
  *
  * @deprecated since 1.120. Please use {@link sap.ushell.services.Navigation} instead.
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/services/AppConfiguration",

package/src/main/js/sap/ushell/services/DarkModeSupport.js

@@ -26,7 +26,7 @@
  * disables dark mode automatic, the currently active theme remains selected. In the settings dialog,
  * the selected entry switches, for example, from ABC set to the (current) ABC High Contrast Light.
  *
- * @version 1.136.3
+ * @version 1.138.0
  * @private
  */
 sap.ui.define([

package/src/main/js/sap/ushell/services/Extension/Item.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview Defines a generic interface for extension items in ShellAreas.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -150,7 +150,7 @@ sap.ui.define([
         }
 
         /**
-         * Shows the item for all applications.
+         * Hides the item for all applications.
          * Does not change the visibility of the item for the launchpad "home".
          * @returns {this} Reference to <code>this</code> for method chaining.
          *

package/src/main/js/sap/ushell/services/Extension.js

@@ -5,7 +5,7 @@
  * This files exposes an API to extend the launchpad with new elements.
  * It is exposed publicly and meant to be used by apps and plugins.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ui/core/Element",

package/src/main/js/sap/ushell/services/FlpLaunchPage.js

@@ -4,7 +4,7 @@
  * @file The Unified Shell's page builder service providing the data for the Fiori launchpad's classic Homepage.
  * This is the privately used subset of the previously deprecated public LaunchPage service API
  * @private
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -725,7 +725,7 @@ sap.ui.define([
              * For backwards compatibility we check if the adapter has return a promise object,
              * if not we create one resolve it with the tile view and return the promise
              */
-            if (!jQuery.isFunction(oDfd.promise)) {
+            if (typeof oDfd.promise !== "function") {
                 oDfd = new jQuery.Deferred().resolve(oDfd).promise();
             }
 

package/src/main/js/sap/ushell/services/FrameBoundExtension/FloatingContainer.js

@@ -5,7 +5,7 @@
  *
  * This interface does NOT work when called from within a iframe.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ui/base/ManagedObject",

package/src/main/js/sap/ushell/services/FrameBoundExtension/Footer.js

@@ -5,7 +5,7 @@
  *
  * This interface does NOT work when called from within a iframe.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/Container"

package/src/main/js/sap/ushell/services/FrameBoundExtension/Item.js

@@ -5,7 +5,7 @@
  *
  * This interface does NOT work when called from within a iframe.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -166,7 +166,7 @@ sap.ui.define([
         }
 
         /**
-         * Shows the item for all applications.
+         * Hides the item for all applications.
          * Does not change the visibility of the item for the launchpad "home".
          * @returns {this} Reference to <code>this</code> for method chaining.
          *

package/src/main/js/sap/ushell/services/FrameBoundExtension/SidePane.js

@@ -5,7 +5,7 @@
  *
  * This interface does NOT work when called from within a iframe.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ui/core/Element",
@@ -134,7 +134,7 @@ sap.ui.define([
         }
 
         /**
-         * Shows the side pane for all applications.
+         * Hides the side pane for all applications.
          * Does not change the visibility of the side pane for the launchpad "home".
          * @returns {this} Reference to <code>this</code> for method chaining.
          *
@@ -160,8 +160,8 @@ sap.ui.define([
         }
 
         /**
-         * Hides the area for launchpad "home".
-         * Does not change the visibility of the area within applications.
+         * Hides the side pane for launchpad "home".
+         * Does not change the visibility of the side pane within applications.
          * @returns {this} Reference to <code>this</code> for method chaining.
          *
          * @since 1.124.0

package/src/main/js/sap/ushell/services/FrameBoundExtension/ToolArea.js

@@ -5,7 +5,7 @@
  *
  * This interface does NOT work when called from within a iframe.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ui/core/Element",
@@ -133,7 +133,7 @@ sap.ui.define([
         }
 
         /**
-         * Shows the tool area for all applications.
+         * Hides the tool area for all applications.
          * Does not change the visibility of the tool area for the launchpad "home".
          * @returns {this} Reference to <code>this</code> for method chaining.
          *

package/src/main/js/sap/ushell/services/FrameBoundExtension/UserSettingsEntry.js

@@ -5,7 +5,7 @@
  *
  * This interface does NOT work when called from within a iframe.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/EventHub"

package/src/main/js/sap/ushell/services/FrameBoundExtension.js

@@ -8,7 +8,7 @@
  * This service can only be called from the outer shell and is not available
  * in the inner shell or via post message API.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ui/core/Element",

package/src/main/js/sap/ushell/services/LaunchPage.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileoverview The Unified Shell's page builder service providing the data for the Fiori launchpad's classic Homepage.
- * @version 1.136.3
+ * @version 1.138.0
  * @deprecated since 1.120
  */
 sap.ui.define([

package/src/main/js/sap/ushell/services/Menu.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The menu service provides the entries for the menu bar
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/Config",
@@ -540,10 +540,13 @@ sap.ui.define([
                     type: "separator",
                     pinned: true
                 };
+                let bShowSeparator = true;
                 if (aMenuEntries[0] && aMenuEntries[0].isHomeEntry) {
                     aMenuEntries.splice(1, 0, oSeparator);
-                } else {
+                } else if (Config.last("/core/menu/personalization/showNavigationBarMenuButton")) {
                     aMenuEntries.splice(0, 0, oSeparator);
+                } else {
+                    bShowSeparator = false;
                 }
 
                 if (!oMenuPersonalization) {
@@ -571,12 +574,14 @@ sap.ui.define([
                         return oMenuEntry;
                     });
 
-                    // Set the MyHome entry and the separator to be pinned.
-                    aMenuEntries[0].pinned = true;
-                    aMenuEntries[0].pinnedSortOrder = 0;
-                    if (aMenuEntries[0].isHomeEntry) {
-                        aMenuEntries[1].pinned = true;
-                        aMenuEntries[1].pinnedSortOrder = 1;
+                    if (bShowSeparator) {
+                        // Set the MyHome entry and the separator to be pinned.
+                        aMenuEntries[0].pinned = true;
+                        aMenuEntries[0].pinnedSortOrder = 0;
+                        if (aMenuEntries[0].isHomeEntry) {
+                            aMenuEntries[1].pinned = true;
+                            aMenuEntries[1].pinnedSortOrder = 1;
+                        }
                     }
                 }
                 return aPersonalizedMenuEntries;

package/src/main/js/sap/ushell/services/Message.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The Unified Shell's message service.
- * @version 1.136.3
+ * @version 1.138.0
  * @deprecated since 1.120
  */
 sap.ui.define([

package/src/main/js/sap/ushell/services/MessageBroker/MessageBrokerEngine.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module contains the implementation of the message broker
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/services/MessageBroker.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module exposes API endpoints for Generic Communication
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/services/MessageBroker/MessageBrokerEngine",

package/src/main/js/sap/ushell/services/MessageInternal.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's message service.
  * This is a private service replacing the depercated Message service, as the functionality is used thoughout the ushell.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/services/Navigation/compatibility.js

@@ -4,7 +4,7 @@
  * compatible with the CrossApplicationNavigation service.
  * This shall only be used for the AppRuntime to enable 1.x inner shell running in 2.x host.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/services/Navigation/utils.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview Navigation utility functions
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 
 

package/src/main/js/sap/ushell/services/Navigation.js

@@ -5,7 +5,7 @@
  * This file exposes an API to perform (invoke) Navigation for applications.
  * It exposes interfaces to perform a hash change and trigger a navigation.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/services/NavigationDataProvider.js

@@ -8,7 +8,7 @@
  *
  * Configured with the ClientSideTargetResolutionAdapter.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/resources",

package/src/main/js/sap/ushell/services/NotificationsV2.js

@@ -411,20 +411,7 @@ sap.ui.define([
         };
 
         /**
-         * Set the number of unseen notifications<br>
-         * e.g. Notifications that the user hasn't seen yet.
-         *
-         * @param {int} number The number of unseen notifications to set
-         * @returns {Promise} Promise resolves when the unseen notifications count is set
-         *
-         * @public
-         */
-        this.setUnseenNotificationsCount = function (number) {
-            return Promise.resolve(oModel.setProperty("/UnseenCount", number));
-        };
-
-        /**
-         * Returns the number of notifications<br>
+         * Returns the number of  notifications<br>
          * e.g. Notifications for user.
          *
          * @returns {int} Returns the number of notifications of the user

package/src/main/js/sap/ushell/services/PageBuilding.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's page building service.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ui/thirdparty/jquery"

package/src/main/js/sap/ushell/services/PagePersistence.js

@@ -6,7 +6,7 @@
  * It provides the layout and tile data of pages in the pages runtime.
  * Only used on the ABAP platform and on local for testing.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([], function () {
     "use strict";

package/src/main/js/sap/ushell/services/PageReferencing.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module deals with page related referencing and dereferencing.
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/services/_PageReferencing/PageReferencer"

package/src/main/js/sap/ushell/services/Pages.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module exposes a model containing the pages hierarchy to its clients.
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -1237,7 +1237,7 @@ sap.ui.define([
         const oCSTRService = await this._oCSTRServicePromise;
         const bEnableHiddenGroup = Config.last("/core/catalog/enableHideGroups");
 
-        await Promise.all(page.payload.layout.sectionOrder.map(async (sSectionId) => {
+        for (const sSectionId of page.payload.layout.sectionOrder) {
             const oCDMPageSection = page.payload.sections[sSectionId];
             const oSection = {
                 id: oCDMPageSection.id || "",
@@ -1250,25 +1250,21 @@ sap.ui.define([
             };
             oPage.sections.push(oSection);
 
-            await Promise.all(oCDMPageSection.layout.vizOrder.map(async (id) => {
-                const oVisualizationReference = oCDMPageSection.viz[id];
+            for (const sVizRefId of oCDMPageSection.layout.vizOrder) {
+                const oVisualizationReference = oCDMPageSection.viz[sVizRefId];
                 const sVizId = oVisualizationReference.vizId;
                 const oSystemContext = await oCSTRService.getSystemContext(oVisualizationReference.contentProviderId);
                 const oVizData = await this._getVisualizationData(page.identification.id, sVizId, visualizations, oVisualizationReference, applications, vizTypes, oSystemContext);
-                // In order to keep the order of the visualizations we have to add them first and remove them later asynchronously
-                oSection.visualizations.push(oVizData);
 
                 const bIntentIsSupported = await this._isIntentSupported(oVizData, oCSTRService);
                 if (!bIntentIsSupported) {
-                    const iIndex = oSection.visualizations.findIndex(function (oViz) {
-                        return oViz.id === oVizData.id;
-                    });
-                    oSection.visualizations.splice(iIndex, 1);
                     Log.warning(`The visualization with title '${oVizData.title}' and ID '${oVizData.vizId}' is filtered out, because intent '${oVizData.targetURL}' is not supported.`,
                         null, this.COMPONENT_NAME);
+                } else {
+                    oSection.visualizations.push(oVizData);
                 }
-            }));
-        }));
+            }
+        }
 
         ushellUtils.setPerformanceMark(["FLP-Pages-Service-getModelForPage-end[", oPage.id, "]"].join(""));
         return oPage;

package/src/main/js/sap/ushell/services/Personalization.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's personalization service, which provides generic read and write access to the currently logged on user's
  * personalization settings for the app currently executed in the shell.
  *
- * @version 1.136.3
+ * @version 1.138.0
  * @deprecated since 1.120. Please use {@link sap.ushell.services.PersonalizationV2} instead.
  */
 sap.ui.define([

package/src/main/js/sap/ushell/services/PersonalizationV2.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's personalization service, which provides generic read and write access to the currently logged on user's
  * personalization settings for the app currently executed in the shell.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/services/PluginManager/Extensions.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview The extensions which plugins can use to customise the launchpad
  *
- * @version 1.136.3
+ * @version 1.138.0
  * @private
  */
 sap.ui.define([

package/src/main/js/sap/ushell/services/PluginManager/HeaderExtensions.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The extensions for the ShellHeader
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/ushell/EventHub"

package/src/main/js/sap/ushell/services/PluginManager/MenuExtensions.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The extensions for the MenuBar, an interface to let plugins request menu entry providers.
  *
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define(["sap/ushell/Container"], function (Container) {
     "use strict";