@sapui5/sap.ushell 1.136.3 → 1.138.0

package/src/main/js/sap/ushell/api/SAPBusinessClient.js

@@ -5,20 +5,18 @@
  */
 sap.ui.define([
     "sap/base/util/deepExtend",
-    "sap/ui/core/theming/Parameters",
-    "sap/ushell/Config",
     "sap/ushell/Container",
+    "sap/ushell/services/NavTargetResolutionInternal",
+    "sap/ushell/state/ShellModel",
     "sap/ushell/utils",
-    "sap/ushell/utils/UrlParsing",
-    "sap/ushell/services/NavTargetResolutionInternal"
+    "sap/ushell/utils/UrlParsing"
 ], (
     deepExtend,
-    ThemingParameters,
-    Config,
     Container,
+    NavTargetResolutionInternal, // here to async preload the module
+    ShellModel,
     ushellUtils,
     UrlParsing
-    /* NavTargetResolutionInternal - here to async preload the module */
 ) => {
     "use strict";
 
@@ -32,7 +30,6 @@ sap.ui.define([
      * @ui5-restricted SAPBusiness Client / NWBC
      */
     class SAPBusinessClient {
-
         /**
          * Gets the user's current theme.
          * @returns {string} The current user theme including the URL to the theme's repository.
@@ -88,11 +85,6 @@ sap.ui.define([
 
         /**
          * Get the current logo URL.
-         * Logo priority:
-         *  1) Custom Company logo URL (might be a base64 encoded string)
-         *  2) theme logo
-         *  3) SAP logo
-         *  4) empty string
          *
          * @returns {string} Logo URL. It is possibly a base64 encoded string. If no logo exists, even an SAP Logo, an empty string is returned.
          * @since 1.134.0
@@ -100,29 +92,7 @@ sap.ui.define([
          * @ui5-restricted SAP Business Client / NWBC
          */
         getLogo () {
-            const sCustomCompanyLogoUrl = Config.last("/core/companyLogo/url");
-
-            if (sCustomCompanyLogoUrl !== "") {
-                return sCustomCompanyLogoUrl;
-            }
-
-            const sThemeLogo = ThemingParameters.get({
-                name: "sapUiGlobalLogo",
-                callback: () => { }
-            });
-
-            if (sThemeLogo) {
-                // check given logo URL: Is it valid?
-                const aMatch = /url[\s]*\('?"?([^'")]*)'?"?\)/.exec(sThemeLogo);
-                if (aMatch) {
-                    return aMatch[1];
-                }
-            }
-            if (sThemeLogo === "none") {
-                return sap.ui.require.toUrl("sap/ushell/themes/base/img/SAPLogo.svg");
-            }
-
-            return "";
+            return ShellModel.getModel().getProperty("/header/logo/src");
         }
     }
     return new SAPBusinessClient();

package/src/main/js/sap/ushell/api/common/ComponentInstantiation.js

@@ -11,7 +11,7 @@ sap.ui.define([
     "sap/ushell/UI5ComponentType",
     "sap/ushell/utils",
     "sap/ushell/utils/UrlParsing"
-], function (
+], (
     Log,
     deepExtend,
     ApplicationType,
@@ -19,7 +19,7 @@ sap.ui.define([
     UI5ComponentType,
     ushellUtils,
     UrlParsing
-) {
+) => {
     "use strict";
 
     /**
@@ -32,7 +32,6 @@ sap.ui.define([
      * @private
      */
     class ComponentInstantiation {
-
         /**
          * Resolves a given navigation intent (if valid) and returns the respective component instance for further processing.
          *
@@ -117,7 +116,7 @@ sap.ui.define([
             }
 
             const NavTargetResolutionInternal = await Container.getServiceAsync("NavTargetResolutionInternal");
-            const oResolvedHashFragment = await NavTargetResolutionInternal.resolveHashFragment("#" + sCanonicalIntent);
+            const oResolvedHashFragment = await NavTargetResolutionInternal.resolveHashFragment(`#${sCanonicalIntent}`);
 
             // If the app is running in cFLP inside an iframe, we have to call the app index
             // to get the app info, so that the component can be created and embedded inside the app.
@@ -125,7 +124,6 @@ sap.ui.define([
                 oResolvedHashFragment.appCapabilities &&
                 oResolvedHashFragment.appCapabilities.appFrameworkId === "UI5" &&
                 Container.inAppRuntime()) {
-
                 // This module is only required in this case to avoid adding dependencies for non-cFLP scenarios.
                 const [AppLifeCycleAgent] = await ushellUtils.requireAsync(["sap/ushell/appRuntime/ui5/services/AppLifeCycleAgent"]);
 
@@ -146,7 +144,7 @@ sap.ui.define([
                 }
                 oAppInfo = this.#finalizeHashFragment(oAppInfo, oInstantiationData);
                 if (oAppInfo.url && sIntent.indexOf("?") > 0) {
-                    oAppInfo.url += "?" + sIntent.split("?")[1];
+                    oAppInfo.url += `?${sIntent.split("?")[1]}`;
                 }
 
                 return this.#createInstantiationData({
@@ -180,7 +178,7 @@ sap.ui.define([
                 const Ui5ComponentLoader = await Container.getServiceAsync("Ui5ComponentLoader");
                 return Ui5ComponentLoader.createComponentData(oResolvedHashFragment);
             } catch (oError) {
-                Log.error("Cannot get UI5 component data: " + oError, oError.stack, "sap.ushell.api.common.ComponentInstantiation");
+                Log.error(`Cannot get UI5 component data: ${oError}`, oError.stack, "sap.ushell.api.common.ComponentInstantiation");
                 return Promise.reject(oError);
             }
         }
@@ -208,7 +206,6 @@ sap.ui.define([
 
             return oResolvedHashFragment;
         }
-
     }
 
     return new ComponentInstantiation();

package/src/main/js/sap/ushell/api/workpage/Designtime.js

@@ -5,10 +5,10 @@
 sap.ui.define([
     "sap/ushell/utils/workpage/WorkPageVizInstantiation",
     "sap/base/util/extend"
-], function (
+], (
     WorkPageVizInstantiation,
     extend
-) {
+) => {
     "use strict";
 
     /**
@@ -26,7 +26,6 @@ sap.ui.define([
      * @ui5-restricted dws-packages
      */
     class Designtime {
-
         static #instance;
 
         _oWorkPageVizInstantiation;

package/src/main/js/sap/ushell/api/workpage/Runtime.js

@@ -8,16 +8,15 @@ sap.ui.define([
     "sap/ushell/utils/workpage/WorkPageService",
     "sap/ushell/utils/workpage/WorkPageHost",
     "sap/ushell/EventHub"
-], function (
+], (
     Designtime,
     WorkPageVizInstantiation,
     WorkPageService,
     WorkPageHost,
     EventHub
-) {
+) => {
     "use strict";
 
-
     /**
      * @alias sap.ushell.api.workpage.Runtime
      * @class
@@ -34,7 +33,6 @@ sap.ui.define([
      * @ui5-restricted dws-packages
      */
     class Runtime extends Designtime {
-
         static #instance;
 
         _oWorkPageService;

package/src/main/js/sap/ushell/appIntegration/AppLifeCycle/KeepAliveMode.js

@@ -1,8 +1,8 @@
 // Copyright (c) 2009-2025 SAP SE, All Rights Reserved
 
 sap.ui.define([
-], function (
-) {
+], (
+) => {
     "use strict";
 
     /**

package/src/main/js/sap/ushell/appIntegration/AppLifeCycle.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview handle all the resources for the different applications.
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/util/deepEqual",
@@ -11,9 +11,10 @@ sap.ui.define([
     "sap/ui/core/Element",
     "sap/ui/core/EventBus",
     "sap/ushell/appIntegration/KeepAliveApps",
-    "sap/ushell/state/BackNavigation",
-    "sap/ushell/state/ContentDensity",
-    "sap/ushell/state/Favicon",
+    "sap/ushell/state/modules/BackNavigation",
+    "sap/ushell/state/modules/ContentDensity",
+    "sap/ushell/state/modules/Favicon",
+    "sap/ushell/state/modules/HeaderLogo",
     "sap/ushell/appIntegration/contracts/EmbeddedUI5Handler",
     "sap/ushell/appIntegration/contracts/StatefulContainerV1Handler",
     "sap/ushell/appIntegration/contracts/StatefulContainerV2Handler",
@@ -60,6 +61,7 @@ sap.ui.define([
     BackNavigation,
     ContentDensity,
     Favicon,
+    HeaderLogo,
     EmbeddedUI5Handler,
     StatefulContainerV1Handler,
     StatefulContainerV2Handler,
@@ -120,7 +122,7 @@ sap.ui.define([
     const iValidIframeTimeout = 3500;
 
     function AppLifeCycle () {
-        //Dangling controls is a queue of requests to change shell elements attributes, requested by the application in the process of createContent before the actual application state was apply.
+        // Dangling controls is a queue of requests to change shell elements attributes, requested by the application in the process of createContent before the actual application state was apply.
         this._bDisableHomeAppCache = false;
         this._bUseLegacyRestoreFlowForNextApp = false; // required for direct app start
         this._oCurrentApplication = {};
@@ -134,7 +136,7 @@ sap.ui.define([
         this._oStorageAppIdNextIndex = {};
         this._aDoables = [];
 
-        //connect FLP to the message broker
+        // connect FLP to the message broker
         if (window.QUnit === undefined) {
             MessageBrokerEngine.connect("FLP");
         }
@@ -144,8 +146,10 @@ sap.ui.define([
     AppLifeCycle.prototype.KeepAliveMode = KeepAliveMode;
 
     /**
-     * @param {object} oInNavContainer
-     * @param {boolean} bInDisableHomeAppCache
+     * @param {object} oInNavContainer the navigation container.
+     * @param {boolean} bInDisableHomeAppCache whether the home app cache is disabled.
+     *
+     * @returns {Promise} after all initializations are done.
      */
     AppLifeCycle.prototype.init = function (oInNavContainer, bInDisableHomeAppCache) {
         const aInitPromises = [];
@@ -180,13 +184,14 @@ sap.ui.define([
         this._oNavContainer = oInNavContainer;
         this._bDisableHomeAppCache = bInDisableHomeAppCache;
 
-        //TODO add unsubscribe
+        // TODO add unsubscribe
         EventBus.getInstance().subscribe("sap.ushell", "getAppLifeCycle", this._onGetAppLifeCycle, this);
 
         this._addEvents();
 
         aInitPromises.push(ContentDensity.init());
         Favicon.init();
+        HeaderLogo.init();
         ApplicationHandle.init(this, this._oNavContainer);
 
         this._oNavContainer.attachAfterNavigate(this.onAfterNavigate.bind(this));
@@ -198,9 +203,9 @@ sap.ui.define([
     };
 
     /**
-     * @param {object} oEvent
-     * @param {string} sChannel
-     * @param {object} oData
+     * @param {object} oEvent the UI5 event object.
+     * @param {string} sChannel the eventbus channel.
+     * @param {object} oData the send data.
      */
     AppLifeCycle.prototype._onGetAppLifeCycle = function (oEvent, sChannel, oData) {
         Log.error("the EventBus channel 'sap.ushell.getAppLifeCycle' is private and was discontinued.");
@@ -298,7 +303,7 @@ sap.ui.define([
     };
 
     /**
-     * @param {object} oShellNavigationInternal
+     * @param {object} oShellNavigationInternal the shell navigation object.
      */
     AppLifeCycle.prototype.registerHandleHashChange = function (oShellNavigationInternal) {
         oShellNavigationInternal.hashChanger.attachEvent("hashChanged", (oHashChangeEvent) => {
@@ -356,37 +361,13 @@ sap.ui.define([
         }
     };
 
-    /**
-     * Updates the current application to use the legacy restore flow.
-     * Instead of continuing the router is restarted when the application is restored.
-     *
-     * If no application is set yet the next application started will use the legacy restore flow.
-     *
-     * @since 1.138.0
-     * @private
-     */
-    AppLifeCycle.prototype._useLegacyRestoreFlowForCurrentApplication = function () {
-        // for direct app start the app creation and this call might be faster than the app life cycle flow
-        if (!this.getCurrentApplication()?.appId) {
-            this._bUseLegacyRestoreFlowForNextApp = true;
-            return;
-        }
-
-        const sStorageAppId = this.getCurrentApplication().appId;
-
-        const oStorageEntry = KeepAliveApps.get(sStorageAppId);
-        if (oStorageEntry) {
-            oStorageEntry.useLegacyRestoreFlow = true;
-        }
-    };
-
     /**
      * @param {boolean} bIsFull whether the application should use the full width.
      */
     AppLifeCycle.prototype._setApplicationFullWidth = function (bIsFull) {
         const oCurrent = this.getCurrentApplication();
 
-        //validate that we have a valid applicationContainer
+        // validate that we have a valid applicationContainer
         if (oCurrent.container) {
             oCurrent.container.toggleStyleClass("sapUShellApplicationContainerLimitedWidth", !bIsFull);
         }
@@ -421,7 +402,7 @@ sap.ui.define([
     };
 
     /**
-     * @param {object} oEvent
+     * @param {object} oEvent the UI5 event object.
      */
     AppLifeCycle.prototype.onBeforeNavigate = function (oEvent) {
         const sFromId = oEvent.getParameter("fromId") || "";
@@ -446,13 +427,12 @@ sap.ui.define([
                 oApplicationContainer.sendRequest("sap.ushell.sessionHandler.beforeApplicationHide", {}, false);
             }
         }
-
     };
 
     /**
-     * @param {object} oEvent
+     * @param {object} oEvent the UI5 event object.
      */
-    AppLifeCycle.prototype.onAfterNavigate = async function (oEvent) { //call lifecycle interface "setInitialConfiguration"
+    AppLifeCycle.prototype.onAfterNavigate = async function (oEvent) { // call lifecycle interface "setInitialConfiguration"
         const sFromId = oEvent.getParameter("fromId") || "";
         const oFrom = oEvent.getParameter("from");
         const sToId = oEvent.getParameter("toId") || "";
@@ -540,7 +520,7 @@ sap.ui.define([
     };
 
     /**
-     * @param {string} sStorageAppId
+     * @param {string} sStorageAppId the storage app id.
      */
     AppLifeCycle.prototype._storeApplication = async function (sStorageAppId) {
         const oStorageEntry = KeepAliveApps.get(sStorageAppId);
@@ -573,7 +553,6 @@ sap.ui.define([
                 }
 
                 await oApplicationContainer.sendRequest("sap.ushell.appRuntime.keepAliveAppHide", {}, false);
-
             } else if (oApplicationContainer.isA("sap.ushell.appIntegration.UI5ApplicationContainer")) {
                 await EmbeddedUI5Handler.storeApp(oApplicationContainer, oStorageEntry);
             }
@@ -588,9 +567,9 @@ sap.ui.define([
 
     /**
      * Should remove their foot print and prepare for possible reuse.
-     * @param {string} sStorageAppId
-     * @param {object} oApplicationContainer
-     * @param {boolean} [bHardDestroy=false]
+     * @param {string} sStorageAppId the storage app id.
+     * @param {sap.ushell.appIntegration.ApplicationContainer} oApplicationContainer the application container.
+     * @param {boolean} [bHardDestroy=false] whether the application should be hard destroyed.
      * @returns {Promise} Resolves when the app is destroyed.
      */
     AppLifeCycle.prototype._destroyApplication = async function (sStorageAppId, oApplicationContainer, bHardDestroy) {
@@ -630,7 +609,6 @@ sap.ui.define([
             // Second close the app
             if (oApplicationContainer.getStatefulType() === StatefulType.ContractV2) {
                 await StatefulContainerV2Handler.destroyApp(oApplicationContainer, sStorageAppId);
-
             } else if (oApplicationContainer.getStatefulType() === StatefulType.ContractV1) {
                 await StatefulContainerV1Handler.destroyApp(oApplicationContainer, sStorageAppId);
             }
@@ -645,7 +623,6 @@ sap.ui.define([
         // try to close the iframe gracefully
         if (oApplicationContainer.getStatefulType() === StatefulType.ContractV2) {
             await StatefulContainerV2Handler.destroyApp(oApplicationContainer, sStorageAppId);
-
         } else if (oApplicationContainer.getStatefulType() === StatefulType.ContractV1) {
             await StatefulContainerV1Handler.destroyApp(oApplicationContainer, sStorageAppId);
         }
@@ -696,7 +673,7 @@ sap.ui.define([
     };
 
     /**
-     * @param {string} sStorageAppId
+     * @param {string} sStorageAppId the storage id.
      */
     AppLifeCycle.prototype._restoreApplication = async function (sStorageAppId) {
         const oStorageEntry = KeepAliveApps.get(sStorageAppId);
@@ -712,7 +689,6 @@ sap.ui.define([
             const oApplicationContainer = oStorageEntry.container;
             if (oApplicationContainer.isA("sap.ushell.appIntegration.IframeApplicationContainer")) {
                 await oApplicationContainer.sendRequest("sap.ushell.appRuntime.keepAliveAppShow", {}, false);
-
             } else if (oApplicationContainer.isA("sap.ushell.appIntegration.UI5ApplicationContainer")) {
                 await EmbeddedUI5Handler.restoreAppAfterNavigate(oApplicationContainer, oStorageEntry);
             }
@@ -720,8 +696,8 @@ sap.ui.define([
     };
 
     /**
-     * @param {object} oOldApplicationContainer
-     * @param {boolean} bNavigationToFlpComponent
+     * @param {sap.ushell.appIntegration.ApplicationContainer} oOldApplicationContainer the old application container.
+     * @param {boolean} bNavigationToFlpComponent whether the navigation target is a FLP component.
      * @returns {Promise} Resolves when the app is closed.
      */
     AppLifeCycle.prototype._handleExitApplication = async function (oOldApplicationContainer, bNavigationToFlpComponent) {
@@ -753,7 +729,7 @@ sap.ui.define([
 
     /**
      * @param {function(): boolean} fnFilterApps The filter function
-     * @param {boolean} [bHardDestroy=false]
+     * @param {boolean} [bHardDestroy=false] whether the application should be hard destroyed.
      * @returns {Promise} Resolves when all keep alive apps are closed.
      */
     AppLifeCycle.prototype._destroyKeepAliveApps = async function (fnFilterApps, bHardDestroy) {
@@ -776,11 +752,11 @@ sap.ui.define([
     };
 
     /**
-     * @param {string} sStorageAppId
-     * @param {object} oApplicationContainer
-     * @param {object} oResolvedHashFragment
-     * @param {string} oParsedShellHash
-     * @param {string} sKeepAliveMode
+     * @param {string} sStorageAppId the storage app id.
+     * @param {sap.ushell.appIntegration.ApplicationContainer} oApplicationContainer the application container.
+     * @param {object} oResolvedHashFragment the resolved hash fragment object.
+     * @param {string} oParsedShellHash the parsed shell hash.
+     * @param {string} sKeepAliveMode the keep alive mode.
      * @returns {object} Returns the storage entry.
      */
     AppLifeCycle.prototype._addStorageEntry = function (sStorageAppId, oApplicationContainer, oResolvedHashFragment, oParsedShellHash, sKeepAliveMode) {
@@ -843,9 +819,9 @@ sap.ui.define([
     };
 
     /**
-     * @param {string} sStorageAppId
-     * @param {object} oResolvedHashFragment
-     * @param {object} oParsedShellHash
+     * @param {string} sStorageAppId the storage app id.
+     * @param {object} oResolvedHashFragment the resolved hash fragment object.
+     * @param {object} oParsedShellHash the parsed shell hash object.
      * @returns {string} Returns the keep alive mode.
      */
     AppLifeCycle.prototype._calculateKeepAliveMode = function (sStorageAppId, oResolvedHashFragment, oParsedShellHash) {
@@ -891,7 +867,7 @@ sap.ui.define([
     };
 
     /**
-     * @param {object} oResolvedHashFragment
+     * @param {object} oResolvedHashFragment the resolved hash fragment object.
      * @returns {string} Returns the application type.
      */
     AppLifeCycle.prototype._calculateAppType = function (oResolvedHashFragment) {
@@ -902,7 +878,8 @@ sap.ui.define([
     };
 
     /**
-     * @param {object} oData
+     * @param {object} oData the application container data.
+     * @param {string} oData.sAppContainerId the application container id.
      * @returns {Promise} Resolves when the app is reloaded.
      */
     AppLifeCycle.prototype._reloadCurrentApp = async function (oData) {
@@ -926,6 +903,8 @@ sap.ui.define([
      * @param {string} sBaseAppId the base application id.
      * @param {object} oResolvedHashFragment the resolved hash fragment.
      * @param {object} bShouldBeCached Wether it should be cached.
+     *
+     * @returns {object} the application container.
      */
     AppLifeCycle.prototype._createOrReuseApplicationContainer = function (sStorageAppId, sBaseAppId, oResolvedHashFragment, bShouldBeCached) {
         let oApplicationContainer;
@@ -993,7 +972,7 @@ sap.ui.define([
     };
 
     /**
-     * @param {string} sId
+     * @param {sap.ushell.appIntegration.ApplicationContainer} oApplicationContainer the application container.
      */
     AppLifeCycle.prototype._removeApplicationContainerFromNavContainer = function (oApplicationContainer) {
         this._oNavContainer.removePage(oApplicationContainer.getId(), true);
@@ -1038,12 +1017,12 @@ sap.ui.define([
     };
 
     /**
-     * @param {*} sStorageAppId
-     * @param {*} oApplicationContainer
-     * @param {*} oResolvedHashFragment
-     * @param {*} oParsedShellHash
-     * @param {*} bWasKeptAlive
-     * @returns
+     * @param {string} sStorageAppId the storage app id.
+     * @param {sap.ushell.appIntegration.ApplicationContainer} oApplicationContainer the application container.
+     * @param {object} oResolvedHashFragment the resolved hash fragment.
+     * @param {object} oParsedShellHash the parsed shell hash.
+     * @param {boolean} bWasKeptAlive whether the app should be kept alive.
+     * @returns {Promise} after the application was opened.
      */
     AppLifeCycle.prototype._openApp = async function (sStorageAppId, oApplicationContainer, oResolvedHashFragment, oParsedShellHash, bWasKeptAlive) {
         const bWasFetchedFromCache = oApplicationContainer.getIsFetchedFromCache();
@@ -1145,10 +1124,10 @@ sap.ui.define([
     };
 
     /**
-     * @param {object} oResolvedHashFragment
+     * @param {object} oResolvedHashFragment the resolved hash fragment object.
      */
     AppLifeCycle.prototype._announceAppOpening = function (oResolvedHashFragment) {
-        //Screen reader: "Loading Complete"
+        // Screen reader: "Loading Complete"
         window.setTimeout(() => {
             const oAccessibilityHelperLoadingComplete = document.getElementById("sapUshellLoadingAccessibilityHelper-loadingComplete");
 
@@ -1180,7 +1159,7 @@ sap.ui.define([
         // restrict hte public api to the minimal set of precise documented properties which can be retained under
         // under future evolutions
         const oPublicEventData = this._publicEventDataFromResolutionResult(oResolvedHashFragment);
-        //publish the event externally
+        // publish the event externally
         // Event is emitted internally (EventHub) _and_ externally (for compatibility reasons)
         EventHub.emit("AppRendered", oPublicEventData, true);
         RendererUtils.publishExternalEvent("appOpened", oPublicEventData);
@@ -1195,7 +1174,7 @@ sap.ui.define([
         // restrict hte public api to the minimal set of precise documented properties which can be retained under
         // under future evolutions
         const oPublicEventData = this._publicEventDataFromResolutionResult(oResolvedHashFragment);
-        //publish the event externally
+        // publish the event externally
         RendererUtils.publishExternalEvent("appClosed", oPublicEventData);
     };
 
@@ -1218,8 +1197,11 @@ sap.ui.define([
     };
 
     /**
-     * @param {*} oResolvedHashFragment
-     * @returns
+     * Calculates whether the application should use the full width.
+     *
+     * @param {object} oResolvedHashFragment the resolved hash fragment.
+     * @param {object} oMetadata the metadata of the application.
+     * @returns {boolean} Whether the application should use the width.
      */
     AppLifeCycle.prototype._isFullWidth = function (oResolvedHashFragment, oMetadata) {
         let bFullWidth;
@@ -1227,9 +1209,9 @@ sap.ui.define([
         const bDefaultFullWidth = ApplicationType.getDefaultFullWidthSetting(sAppType);
 
         const bFullWidthCapability = oResolvedHashFragment.appCapabilities?.fullWidth;
-        //Here there's a double check for the fullwidth - once as a type of boolean and one as a string.
-        //This is because we found that developers configured this variable in the manifest also as a string,
-        //so the checks of the oMetadata and the oResolvedHashFragment are to avoid regression with the use of this field.
+        // Here there's a double check for the fullwidth - once as a type of boolean and one as a string.
+        // This is because we found that developers configured this variable in the manifest also as a string,
+        // so the checks of the oMetadata and the oResolvedHashFragment are to avoid regression with the use of this field.
         if (bDefaultFullWidth) {
             if (oResolvedHashFragment.fullWidth === false || oResolvedHashFragment.fullWidth === "false" ||
                 oMetadata.fullWidth === false || oMetadata.fullWidth === "false" || bFullWidthCapability === false) {
@@ -1279,7 +1261,7 @@ sap.ui.define([
     };
 
     /**
-     * @returns {Promise<sap.base.util.Deferred>}
+     * @returns {Promise<sap.base.util.Deferred>} after the last application was started.
      */
     AppLifeCycle.prototype._awaitLastApplicationStart = async function () {
         const oDeferred = new Deferred();
@@ -1449,10 +1431,10 @@ sap.ui.define([
 
     /**
      * New app was created and we now have to switch the state
-     * @param {string} sLaunchpadState
-     * @param {string} sToStorageAppId
-     * @param {string} sAppType
-     * @param {boolean} bExplicitNavMode
+     * @param {string} sLaunchpadState the launchpad state.
+     * @param {string} sToStorageAppId the application id that is taken from storage.
+     * @param {string} sAppType the app type.
+     * @param {boolean} bExplicitNavMode whether there is an explicit navigation mode.
      */
     AppLifeCycle.prototype.switchViewState = function (sLaunchpadState, sToStorageAppId, sAppType, bExplicitNavMode) {
         // Store state before creating a new one
@@ -1484,7 +1466,7 @@ sap.ui.define([
             KeepAlive.flush();
         }
 
-        //Process Dangling UI elements and continue.
+        // Process Dangling UI elements and continue.
         StateManager.applyStalledChanges();
     };
 
@@ -1654,7 +1636,6 @@ sap.ui.define([
             if (oPotentialApplicationContainer.getIsInvalidIframe()) {
                 bIframeInvalid = true;
                 sReason = "iframe is in invalid state";
-
             } else if (StatefulContainerV2Handler.isIframeIsValidSupported(oPotentialApplicationContainer)) {
                 const iLastValidTimeDelta = new Date().getTime() - oPotentialApplicationContainer.getIsIframeValidTime().time;
                 bIframeInvalid = iLastValidTimeDelta >= iValidIframeTimeout;
@@ -1675,7 +1656,7 @@ sap.ui.define([
     };
     /**
      * Only for testing
-     * @param {sap.ui.core.Control} oNewNavContainer
+     * @param {sap.ui.core.Control} oNewNavContainer the new navigation container.
      *
      * @private
      */

package/src/main/js/sap/ushell/appIntegration/ApplicationContainer.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The UI integration's SAPUI5 control which supports application embedding.
- * @version 1.136.3
+ * @version 1.138.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -171,14 +171,13 @@ sap.ui.define([
      * Initialization of <code>ApplicationContainer</code> instance.
      */
     ApplicationContainer.prototype.init = function () {
-
         // set object default values again to prevent them from being "synced"
         this.setProperty("capabilities", {}, true);
     };
 
     ApplicationContainer.prototype.invalidate = function () {
         if (this.getRenderComplete()) {
-            //always prevent re-rendering of application container once it's rendered
+            // always prevent re-rendering of application container once it's rendered
             return this;
         }
 
@@ -368,7 +367,6 @@ sap.ui.define([
         // needs to be implemented by sub classes
     };
 
-
     ApplicationContainer.prototype.getPostMessageTargetOrigin = function () {
         // needs to be implemented by sub classes
         return "";