@sapui5/sap.ushell 1.124.1 → 1.125.0

package/src/main/js/sap/ushell/services/AppConfiguration.js

@@ -14,6 +14,7 @@ sap.ui.define([
     "sap/ushell/resources",
     "sap/ushell/utils/UrlParsing",
     "sap/ushell/utils",
+    "sap/ushell/Container",
     "sap/ushell/Config"
 ], function (
     Localization,
@@ -26,9 +27,10 @@ sap.ui.define([
     jQuery,
     Mobile,
     EventHub,
-    resources,
+    ushellResources,
     UrlParsing,
-    utils,
+    ushellUtils,
+    Container,
     Config
 ) {
     "use strict";
@@ -45,22 +47,19 @@ sap.ui.define([
      * @public
      */
     function AppConfiguration () {
-        var oMetadata = {},
-            bApplicationInInitMode = true,
-            oCurrentApplication = null,
-            aIdsOfAddedButtons = [],
-            aAppRequestsQueue = [];
+        const oMetadata = {};
+        let bApplicationInInitMode = true;
+        let oCurrentApplication = null;
+        let aIdsOfAddedButtons = [];
+        const aAppRequestsQueue = [];
 
         /**
-         * Due to performance changes on component (app) loading, it is possible that an application would be initialized before
-         * the shell state was changed, therefore we listen to the appRendered event and keep a reference to the opened app metadata
-         * object, to verify that the addApplicationSettingsButtons APIs is called only after the application is actually opened.
+         * Handles the appRendered event.
          *
          * @private
+         * @alias sap.ushell.services.AppConfiguration#_applicationOpenedHandler
          */
-        EventHub.on("AppRendered").do(applicationOpenedHandler.bind(this));
-
-        function applicationOpenedHandler (/*sChannelId, sEventId, oData*/) {
+        this._applicationOpenedHandler = function (/*sChannelId, sEventId, oData*/) {
             // update the opened application object
             bApplicationInInitMode = false;
 
@@ -68,7 +67,16 @@ sap.ui.define([
             while (aAppRequestsQueue.length > 0) {
                 aAppRequestsQueue.shift()();
             }
-        }
+        };
+
+        /**
+         * Due to performance changes on component (app) loading, it is possible that an application would be initialized before
+         * the shell state was changed, therefore we listen to the appRendered event and keep a reference to the opened app metadata
+         * object, to verify that the addApplicationSettingsButtons APIs is called only after the application is actually opened.
+         *
+         * @private
+         */
+        EventHub.on("AppRendered").do(this._applicationOpenedHandler.bind(this));
 
         /**
          * Adds an entry to user recent activity list.
@@ -102,27 +110,38 @@ sap.ui.define([
          * </pre>
          * @returns {jQuery.Promise} Resolves the updated list of user recents.
          *
-         * @private
+         * @public
+         * @deprecated since 1.120 without replacement.
          * @alias sap.ushell.services.AppConfiguration#addActivity
          */
         this.addActivity = function (oRecentActivity) {
-            var oDeferred = new jQuery.Deferred();
+            const oDeferred = new jQuery.Deferred();
 
-            sap.ushell.Container.getServiceAsync("UserRecents")
-                .then(function (UserRecentsService) {
-                    UserRecentsService.addActivity(oRecentActivity)
-                        .then(oDeferred.resolve)
-                        .catch(oDeferred.reject);
+            Container.getServiceAsync("UserRecents")
+                .then((UserRecentsService) => {
+                    return UserRecentsService.addActivity(oRecentActivity);
                 })
+                .then(oDeferred.resolve)
                 .catch(oDeferred.reject);
 
             return oDeferred.promise();
         };
 
+        /**
+         * @private
+         * @alias sap.ushell.services.AppConfiguration#setApplicationInInitMode
+         */
         this.setApplicationInInitMode = function () {
             bApplicationInInitMode = true;
         };
 
+        /**
+         * Returns the application request queue.
+         * @returns {function[]} The application request queue
+         *
+         * @private
+         * @alias sap.ushell.services.AppConfiguration#getApplicationRequestQueue
+         */
         this.getApplicationRequestQueue = function () {
             return aAppRequestsQueue;
         };
@@ -132,13 +151,25 @@ sap.ui.define([
          *
          * @returns {object} A copy of the metadata object related to the application, or null if no application is currently opened
          *   (e.g., when home or app finder are opened).
+         *
          * @private
          * @alias sap.ushell.services.AppConfiguration#getCurrentApplication
          */
         this.getCurrentApplication = function () {
             return oCurrentApplication;
         };
-        this.getCurrentAppliction = this.getCurrentApplication; // Fixes typo error in the naming of "this.getCurrentAppliction"
+
+        /**
+         * Returns the current application, excluding the home page and the appfinder (which are FLP Core components).
+         *
+         * @returns {object} A copy of the metadata object related to the application, or null if no application is currently opened
+         *   (e.g., when home or app finder are opened).
+         *
+         * @private
+         * @deprecated since 1.120.0. Use {@link sap.ushell.services.AppConfiguration#getCurrentApplication} instead.
+         * @alias sap.ushell.services.AppConfiguration#getCurrentAppliction
+         */
+        this.getCurrentAppliction = this.getCurrentApplication;
 
 
         /**
@@ -168,8 +199,8 @@ sap.ui.define([
             }
 
             if (oApplication) {
-                var sHash = hasher && hasher.getHash ? hasher.getHash() : "";
-                var sKey = this._getMemoizationKey(sHash);
+                const sHash = hasher?.getHash ? hasher.getHash() : "";
+                const sKey = this._getMemoizationKey(sHash);
 
                 return this._getMetadata(oApplication, sKey);
             }
@@ -178,57 +209,57 @@ sap.ui.define([
         };
 
         /**
-         * @alias sap.ushell.services.AppConfiguration#_getMemoizationKey
          * @param {string} sCompleteHash The complete hash
          * @returns {sap.ui.core.URI} The intent
+         *
          * @private
+         * @alias sap.ushell.services.AppConfiguration#_getMemoizationKey
          */
         this._getMemoizationKey = function (sCompleteHash) {
-            var aHashParts = sCompleteHash.split("?");
-            var sIntent = aHashParts[0];
-            var sParams = aHashParts[1];
+            const [ sIntent, sParams ] = sCompleteHash.split("?");
 
-            sParams = this._processParams(sParams);
-            if (sParams) {
-                return sIntent + sParams;
+            const sProcessedParams = this._processParams(sParams);
+            if (sProcessedParams) {
+                return sIntent + sProcessedParams;
             }
 
-            var oParsedShellHash = UrlParsing.parseShellHash(sCompleteHash);
-            sIntent = oParsedShellHash ? oParsedShellHash.semanticObject + "-" + oParsedShellHash.action : "";
-
-            return sIntent;
+            const oParsedShellHash = UrlParsing.parseShellHash(sCompleteHash);
+            if (oParsedShellHash) {
+                const { semanticObject, action } = oParsedShellHash;
+                return `${semanticObject}-${action}`;
+            }
+            return "";
         };
 
         /**
-         * @param {string} sParams The params
+         * @param {string} [sParams] The params
          * @returns {string} The process params
          *
          * @private
          * @alias sap.ushell.services.AppConfiguration#_getMemoizationKey
          */
         this._processParams = function (sParams) {
-            if (sParams) {
-                var sPrefix = "";
-                var oParams = {};
+            if (!sParams) {
+                return "";
+            }
 
-                sParams.split("&").forEach(function (item) {
-                    var aCurrentParam = item.split("=");
+            const oParams = {};
 
-                    oParams[aCurrentParam[0]] = aCurrentParam[1];
-                });
+            sParams.split("&").forEach((item) => {
+                const [sName, sValue] = item.split("=");
 
-                var aSortedParamKeys = Object.keys(oParams).sort();
-                var sProcessedParams = "";
+                oParams[sName] = sValue;
+            });
 
-                aSortedParamKeys.forEach(function (sKey, iIndex) {
-                    sPrefix = iIndex ? "&" : "?";
-                    sProcessedParams += sPrefix + sKey + "=" + oParams[sKey];
-                });
+            const aSortedParamKeys = Object.keys(oParams).sort();
 
-                return sProcessedParams;
-            }
+            const sProcessedParams = aSortedParamKeys.reduce((sResult, sKey, iIndex) => {
+                const sParam = `${sKey}=${oParams[sKey]}`;
 
-            return "";
+                return `${sResult}${iIndex > 0 ? "&" : "?"}${sParam}`;
+            }, "");
+
+            return sProcessedParams;
         };
 
         /**
@@ -253,7 +284,7 @@ sap.ui.define([
             // If title doesn't exist in the metadata - try to get it from the result of navTargetResolution,
             // or use the default application title
             if (!oMetadata[sKey].title) {
-                oMetadata[sKey].title = oApplication.text || resources.i18n.getText("default_app_title");
+                oMetadata[sKey].title = oApplication.text || ushellResources.i18n.getText("default_app_title");
             }
             return oMetadata[sKey];
         };
@@ -274,8 +305,9 @@ sap.ui.define([
 
         /**
          * Sets the hiding of the shell header.
-         * @deprecated since 1.56
+         *
          * @private
+         * @deprecated since 1.56 without replacement. The header hiding is not supported anymore.
          * @alias sap.ushell.services.AppConfiguration#setHeaderHiding
          */
         this.setHeaderHiding = function () {
@@ -288,7 +320,9 @@ sap.ui.define([
          * It is meant to be used by applications that want to add their own settings button to the shell header.
          *
          * @param {sap.m.Button[]} aButtons List of sap.m.Button controls
-         * @private
+         *
+         * @public
+         * @deprecated since 1.120. Use {@link sap.ushell.services.Extension#addUserAction} instead.
          * @alias sap.ushell.services.AppConfiguration#addApplicationSettingsButtons
          */
         this.addApplicationSettingsButtons = function (aButtons) {
@@ -308,30 +342,37 @@ sap.ui.define([
              * See ticket #1670473374
              */
             if (bApplicationInInitMode) {
-                aAppRequestsQueue.push(function () {
-                    addApplicationSettingsButtons(aButtons);
+                aAppRequestsQueue.push(() => {
+                    this._addApplicationSettingsButtons(aButtons);
                 });
             } else {
-                addApplicationSettingsButtons(aButtons);
+                this._addApplicationSettingsButtons(aButtons);
             }
         };
 
-        function addApplicationSettingsButtons (aButtons) {
-            var i,
-                aIds = [],
-                oRenderer = sap.ushell.Container.getRendererInternal("fiori2");
+        /**
+         * Adds buttons to the action sheet in the shell header.
+         * @param {sap.m.Button[]} aButtons List of sap.m.Button controls
+         *
+         * @private
+         * @deprecated since 1.120. Use {@link sap.ushell.services.Extension#addUserAction} instead.
+         * @alias sap.ushell.services.AppConfiguration#_addApplicationSettingsButtons
+         */
+        this._addApplicationSettingsButtons = function (aButtons) {
+            const oRenderer = Container.getRendererInternal("fiori2");
+            const aIds = [];
 
-            for (i = 0; i < aButtons.length; i++) {
-                var oCurrentButton = aButtons[i];
+            for (let i = 0; i < aButtons.length; i++) {
+                const oCurrentButton = aButtons[i];
                 aIds.push(oCurrentButton.getId());
                 oCurrentButton.setIcon(oCurrentButton.getIcon() || IconPool.getIconURI("customize"));
                 // in case the button has the text "Settings" we change it to "App Setting" in order prevent name collision
-                if (resources.i18n.getText("userSettings") === oCurrentButton.getProperty("text")) {
-                    oCurrentButton.setProperty("text", resources.i18n.getText("userAppSettings"));
+                if (ushellResources.i18n.getText("userSettings") === oCurrentButton.getProperty("text")) {
+                    oCurrentButton.setProperty("text", ushellResources.i18n.getText("userAppSettings"));
                 }
                 oCurrentButton.setType(ButtonType.Unstyled);
             }
-            if (sap.ushell.Container && oRenderer) {
+            if (oRenderer) {
                 if (aIdsOfAddedButtons.length) {
                     // remove buttons that were added earlier
                     oRenderer.hideActionButton(aIdsOfAddedButtons, true);
@@ -339,7 +380,7 @@ sap.ui.define([
                 aIdsOfAddedButtons = aIds;
                 oRenderer.showActionButton(aIds, true, undefined, true);
             }
-        }
+        };
 
         /**
          * Sets the title of the browser tabSets the title of the browser tab.
@@ -350,12 +391,12 @@ sap.ui.define([
          * @alias sap.ushell.services.AppConfiguration#setWindowTitle
          */
         this.setWindowTitle = function (sTitle) {
-            var sWindowTitleExtension = resources.getTranslationFromJSON(Config.last("/core/shell/windowTitleExtension"));
+            const sWindowTitleExtension = ushellResources.getTranslationFromJSON(Config.last("/core/shell/windowTitleExtension"));
             if (sWindowTitleExtension) {
-                if (resources.getRTL()) {
-                    sTitle = sWindowTitleExtension + " - " + sTitle;
+                if (ushellResources.getRTL()) {
+                    sTitle = `${sWindowTitleExtension} - ${sTitle}`;
                 } else {
-                    sTitle = sTitle + " - " + sWindowTitleExtension;
+                    sTitle = `${sTitle} - ${sWindowTitleExtension}`;
                 }
             }
             window.document.title = sTitle;
@@ -366,7 +407,8 @@ sap.ui.define([
          *
          * @param {object} oIconsProperties Icon properties, an object holding icon URLs
          *
-         * @private
+         * @public
+         * @deprecated since 1.120.0. Use {@link sap.ui.util.Mobile#setIcons} instead.
          * @alias sap.ushell.services.AppConfiguration#setIcons
          */
         this.setIcons = function (oIconsProperties) {
@@ -409,12 +451,11 @@ sap.ui.define([
          * @alias sap.ushell.services.AppConfiguration#getApplicationName
          */
         this.getApplicationName = function (oApplication) {
-            var aMatches,
-                sAdditionalInformation = (oApplication && oApplication.additionalInformation) || null;
+            const sAdditionalInformation = oApplication?.additionalInformation;
 
             if (sAdditionalInformation) {
                 // SAPUI5.Component=<fully-qualified-component-name>
-                aMatches = /^SAPUI5\.Component=(.+)$/i.exec(sAdditionalInformation);
+                const aMatches = /^SAPUI5\.Component=(.+)$/i.exec(sAdditionalInformation);
                 if (aMatches) {
                     // determine namespace, view name, and view type
                     return aMatches[1];
@@ -431,16 +472,15 @@ sap.ui.define([
          * @alias sap.ushell.services.AppConfiguration#getApplicationUrl
          */
         this.getApplicationUrl = function (oApplication) {
-            var sUrl = (oApplication && oApplication.url) || null,
-                sSegmentToDetermineWebGUITransaction = "P_TCODE",
-                iIndexOfQuestionMark;
+            let sUrl = oApplication?.url;
+            const sSegmentToDetermineWebGUITransaction = "P_TCODE";
 
             if (sUrl) {
                 if (oApplication.applicationType === "NWBC" && sUrl.indexOf(sSegmentToDetermineWebGUITransaction)) {
                     // in case it is a WebGUI transaction then return the whole URL of the application
                     return sUrl;
                 }
-                iIndexOfQuestionMark = sUrl.indexOf("?");
+                const iIndexOfQuestionMark = sUrl.indexOf("?");
                 if (iIndexOfQuestionMark >= 0) {
                     // pass GET parameters of URL via component data as member startupParameters
                     // (to allow blending with other oComponentData usage, e.g. extensibility use case)
@@ -460,41 +500,43 @@ sap.ui.define([
          * whose key is composed of the original key + the string "Resource".
          * e.g. For translating the value of the property "title" - there's another configuration property: "titleResource": "TITLE_KEY".
          * The value (e.g. "TITLE_KEY") is the translation key in the resource bundle
-         * @alias sap.ushell.services.AppConfiguration#getPropertyValueFromConfig
          * @param {object} oConfig The configuration
          * @param {string} sPropertyKey The property key
          * @param {sap.base.i18n.ResourceBundle} oResourceBundle The resource bundle
          * @returns {string|undefined} The value of the property, or undefined if the property is not found
+         *
          * @private
+         * @alias sap.ushell.services.AppConfiguration#_getPropertyValueFromConfig
          */
-        this.getPropertyValueFromConfig = function (oConfig, sPropertyKey, oResourceBundle) {
-            var oValue;
+        this._getPropertyValueFromConfig = function (oConfig, sPropertyKey, oResourceBundle) {
+            const sKey = `${sPropertyKey}Resource`;
 
-            if (oResourceBundle && oConfig.hasOwnProperty(sPropertyKey + "Resource")) {
-                oValue = oResourceBundle.getText(oConfig[sPropertyKey + "Resource"]);
-            } else if (oConfig.hasOwnProperty(sPropertyKey)) {
-                oValue = oConfig[sPropertyKey];
+            if (oResourceBundle && oConfig.hasOwnProperty(sKey)) {
+                return oResourceBundle.getText(oConfig[sKey]);
             }
 
-            return oValue;
+            if (oConfig.hasOwnProperty(sPropertyKey)) {
+                return oConfig[sPropertyKey];
+            }
         };
 
         /**
          * Reads a property value from the manifest
          *
-         * @alias sap.ushell.services.AppConfiguration#getPropertyValueFromManifest
          * @param {object} oLocalMetadataComponent The metadata component
          * @param {object} oProperties The properties
          * @param {string} sPropertyKey The property key
-         * @returns {string|Object"""} The value of the property, or undefined if the property is not found
+         * @returns {string|object} The value of the property, or undefined if the property is not found
+         *
          * @private
+         * @alias sap.ushell.services.AppConfiguration#_getPropertyValueFromManifest
          */
-        this.getPropertyValueFromManifest = function (oLocalMetadataComponent, oProperties, sPropertyKey) {
-            var sManifestEntryKey = oProperties[sPropertyKey].manifestEntryKey,
-                sManifestPropertyPath = oProperties[sPropertyKey].path,
-                oManifestEntry = oLocalMetadataComponent.getManifestEntry(sManifestEntryKey);
+        this._getPropertyValueFromManifest = function (oLocalMetadataComponent, oProperties, sPropertyKey) {
+            const sManifestEntryKey = oProperties[sPropertyKey].manifestEntryKey;
+            const sManifestPropertyPath = oProperties[sPropertyKey].path || "";
+            const oManifestEntry = oLocalMetadataComponent.getManifestEntry(sManifestEntryKey);
 
-            return ObjectPath.get(sManifestPropertyPath || "", oManifestEntry);
+            return ObjectPath.get(sManifestPropertyPath, oManifestEntry);
         };
 
         /**
@@ -511,196 +553,205 @@ sap.ui.define([
          */
         this.addMetadata = function (oApplication, sKey) {
             try {
-                var sComponentName = this.getApplicationName(oApplication),
-                    sUrl = this.getApplicationUrl(oApplication),
-                    oLocalMetadataComponent,
-                    oConfig,
-                    // Hash object that maps application metadata property (i.e. property name) to its corresponding entry and path
-                    // in the application descriptor (i.e. manifest file), if exists
-                    oProperties = {
-                        fullWidth:
-                            { manifestEntryKey: "sap.ui", path: "fullWidth" },
-                        hideLightBackground:
-                            { manifestEntryKey: "sap.ui", path: "hideLightBackground" },
-                        title:
-                            { manifestEntryKey: "sap.app", path: "title" },
-                        icon:
-                            { manifestEntryKey: "sap.ui", path: "icons.icon" },
-                        favIcon:
-                            { manifestEntryKey: "sap.ui", path: "icons.favIcon" },
-                        homeScreenIconPhone:
-                            { manifestEntryKey: "sap.ui", path: "icons.phone" },
-                        "homeScreenIconPhone@2":
-                            { manifestEntryKey: "sap.ui", path: "icons.phone@2" },
-                        homeScreenIconTablet:
-                            { manifestEntryKey: "sap.ui", path: "icons.tablet" },
-                        "homeScreenIconTablet@2":
-                            { manifestEntryKey: "sap.ui", path: "icons.tablet@2" },
-                        startupImage320x460:
-                            { manifestEntryKey: "sap.ui", path: "icons.startupImage640x920" },
-                        startupImage640x920:
-                            { manifestEntryKey: "sap.ui", path: "icons.startupImage640x920" },
-                        startupImage640x1096:
-                            { manifestEntryKey: "sap.ui", path: "icons.startupImage640x1096" },
-                        startupImage768x1004:
-                            { manifestEntryKey: "sap.ui", path: "icons.startupImage768x1004" },
-                        startupImage748x1024:
-                            { manifestEntryKey: "sap.ui", path: "icons.startupImage748x1024" },
-                        startupImage1536x2008:
-                            { manifestEntryKey: "sap.ui", path: "icons.startupImage1536x2008" },
-                        startupImage1496x2048:
-                            { manifestEntryKey: "sap.ui", path: "icons.startupImage1496x2048" },
-                        compactContentDensity:
-                            { manifestEntryKey: "sap.ui5", path: "contentDensities.compact" },
-                        cozyContentDensity:
-                            { manifestEntryKey: "sap.ui5", path: "contentDensities.cozy" }
-                    },
-                    potentiallyRelativeUrls,
-                    sComponentUrl,
-                    isUrlRelative,
-                    bManifestExists,
-                    sPropertyKey,
-                    sConfigResourceBundleUrl,
-                    oResourceBundle,
-                    oComponentHandle = oApplication && oApplication.componentHandle;
-
-                if (sKey) {
-                    if (!(oMetadata.hasOwnProperty(sKey))) {
-                        // independent from application type - create an object for metadata; initialize the complete flag with false!
-                        oMetadata[sKey] = { complete: false };
+                const sComponentName = this.getApplicationName(oApplication);
+                const sUrl = this.getApplicationUrl(oApplication);
+                // Hash object that maps application metadata property (i.e. property name) to its corresponding entry and path
+                // in the application descriptor (i.e. manifest file), if exists
+                const oProperties = {
+                    fullWidth:
+                        { manifestEntryKey: "sap.ui", path: "fullWidth" },
+                    hideLightBackground:
+                        { manifestEntryKey: "sap.ui", path: "hideLightBackground" },
+                    title:
+                        { manifestEntryKey: "sap.app", path: "title" },
+                    icon:
+                        { manifestEntryKey: "sap.ui", path: "icons.icon" },
+                    favIcon:
+                        { manifestEntryKey: "sap.ui", path: "icons.favIcon" },
+                    homeScreenIconPhone:
+                        { manifestEntryKey: "sap.ui", path: "icons.phone" },
+                    "homeScreenIconPhone@2":
+                        { manifestEntryKey: "sap.ui", path: "icons.phone@2" },
+                    homeScreenIconTablet:
+                        { manifestEntryKey: "sap.ui", path: "icons.tablet" },
+                    "homeScreenIconTablet@2":
+                        { manifestEntryKey: "sap.ui", path: "icons.tablet@2" },
+                    startupImage320x460:
+                        { manifestEntryKey: "sap.ui", path: "icons.startupImage640x920" },
+                    startupImage640x920:
+                        { manifestEntryKey: "sap.ui", path: "icons.startupImage640x920" },
+                    startupImage640x1096:
+                        { manifestEntryKey: "sap.ui", path: "icons.startupImage640x1096" },
+                    startupImage768x1004:
+                        { manifestEntryKey: "sap.ui", path: "icons.startupImage768x1004" },
+                    startupImage748x1024:
+                        { manifestEntryKey: "sap.ui", path: "icons.startupImage748x1024" },
+                    startupImage1536x2008:
+                        { manifestEntryKey: "sap.ui", path: "icons.startupImage1536x2008" },
+                    startupImage1496x2048:
+                        { manifestEntryKey: "sap.ui", path: "icons.startupImage1496x2048" },
+                    compactContentDensity:
+                        { manifestEntryKey: "sap.ui5", path: "contentDensities.compact" },
+                    cozyContentDensity:
+                        { manifestEntryKey: "sap.ui5", path: "contentDensities.cozy" }
+                };
+                const oComponentHandle = oApplication?.componentHandle;
+
+                if (!sKey) {
+                    return;
+                }
+
+                if (!(oMetadata.hasOwnProperty(sKey))) {
+                    // independent from application type - create an object for metadata; initialize the complete flag with false!
+                    oMetadata[sKey] = { complete: false };
+                }
+
+                if (!oMetadata[sKey].complete) {
+                    let oLocalMetadataComponent;
+
+                    if (oComponentHandle) {
+                        oLocalMetadataComponent = oComponentHandle.getMetadata();
+                    } else if (sComponentName) {
+                        Log.warning(`No component handle available for '${sComponentName}'; SAPUI5 component metadata is incomplete`, null, "sap.ushell.services.AppConfiguration");
+                        return;
                     }
 
-                    if (!oMetadata[sKey].complete) {
-                        if (oComponentHandle) {
-                            oLocalMetadataComponent = oComponentHandle.getMetadata();
-                        } else if (sComponentName) {
-                            Log.warning("No component handle available for '" + sComponentName + "'; SAPUI5 component metadata is incomplete",
-                                null, "sap.ushell.services.AppConfiguration");
-                            return;
+                    if (oLocalMetadataComponent) {
+                        let oResourceBundle;
+                        const oConfig = oLocalMetadataComponent.getConfig();
+                        oMetadata[sKey].complete = true;
+
+                        // If configuration exists and no resource bundle was created from the manifest
+                        if (oConfig) {
+                            let sConfigResourceBundleUrl = oConfig.resourceBundle;
+                            if (sConfigResourceBundleUrl) {
+                                if (sConfigResourceBundleUrl.slice(0, 1) !== "/") {
+                                    sConfigResourceBundleUrl = sUrl + sConfigResourceBundleUrl;
+                                }
+                                oResourceBundle = ResourceBundle.create({
+                                    url: sConfigResourceBundleUrl,
+                                    locale: Localization.getLanguage()
+                                });
+                            }
                         }
 
-                        if (oLocalMetadataComponent) {
-                            oConfig = oLocalMetadataComponent.getConfig();
-                            bManifestExists = (oLocalMetadataComponent.getManifest() !== undefined);
-                            oMetadata[sKey].complete = true;
-                            // If configuration exists and no resource bundle was created from the manifest
-                            if (oConfig) {
-                                sConfigResourceBundleUrl = oConfig.resourceBundle || "";
-                                if (sConfigResourceBundleUrl) {
-                                    if (sConfigResourceBundleUrl.slice(0, 1) !== "/") {
-                                        sConfigResourceBundleUrl = sUrl + sConfigResourceBundleUrl;
-                                    }
-                                    oResourceBundle = ResourceBundle.create({
-                                        url: sConfigResourceBundleUrl,
-                                        locale: Localization.getLanguage()
-                                    });
+                        const bManifestExists = !!oLocalMetadataComponent.getManifest();
+
+                        // Loop over all property names, and for each one get the value from the manifest or from the application configuration
+                        for (const sPropertyKey in oProperties) {
+                            if (oProperties.hasOwnProperty(sPropertyKey)) {
+                                if (bManifestExists) {
+                                    // Get property value from the manifest
+                                    oMetadata[sKey][sPropertyKey] = this._getPropertyValueFromManifest(oLocalMetadataComponent, oProperties, sPropertyKey);
                                 }
-                            }
 
-                            // Loop over all property names, and for each one get the value from the manifest or from the application configuration
-                            for (sPropertyKey in oProperties) {
-                                if (oProperties.hasOwnProperty(sPropertyKey)) {
-                                    if (bManifestExists) {
-                                        // Get property value from the manifest
-                                        oMetadata[sKey][sPropertyKey] = this.getPropertyValueFromManifest(oLocalMetadataComponent, oProperties, sPropertyKey);
-                                    }
-
-                                    // If application configuration exists and the property value was not found in the manifest -
-                                    // look for it in the configuration
-                                    if (oConfig && oMetadata[sKey][sPropertyKey] === undefined) {
-                                        // Get property value from the configuration
-                                        oMetadata[sKey][sPropertyKey] = this.getPropertyValueFromConfig(oConfig, sPropertyKey, oResourceBundle);
-                                    }
+                                // If application configuration exists and the property value was not found in the manifest -
+                                // look for it in the configuration
+                                if (oConfig && oMetadata[sKey][sPropertyKey] === undefined) {
+                                    // Get property value from the configuration
+                                    oMetadata[sKey][sPropertyKey] = this._getPropertyValueFromConfig(oConfig, sPropertyKey, oResourceBundle);
                                 }
                             }
-                            oMetadata[sKey].version = oLocalMetadataComponent.getVersion();
-                            oMetadata[sKey].technicalName = oLocalMetadataComponent.getComponentName();
-                            this._setTitleFromNavResult(oMetadata[sKey], oApplication);
-                        } else if (utils.isApplicationTypeEmbeddedInIframe(oApplication.applicationType)) {
-                            var sWdaApplicationUrlString = "/~canvas;window=app/wda/",
-                                iIndexOfWdaApplicationUrlString = oApplication.url.indexOf(sWdaApplicationUrlString),
-                                sWdaApplicationOtherUrlString = "/sap/bc/webdynpro/sap/",
-                                sWebGUIApplicationUrlString = "/bc/gui/sap/its/webgui",
-                                iIndexOfWebGUIApplicationUrlString = oApplication.url.indexOf(sWebGUIApplicationUrlString);
-
-                            if (iIndexOfWdaApplicationUrlString >= 0) {
-                                // WebDynproABAPApplication
-                                // /ui2/nwbc/~canvas;window=app/wda/S_EPM_FPM_PD/?sap-wd-configId=s_epm_fpm_pd
-                                oMetadata[sKey].technicalName = oApplication.url.substring(
-                                    (iIndexOfWdaApplicationUrlString + sWdaApplicationUrlString.length),
-                                    oApplication.url.indexOf("/", (iIndexOfWdaApplicationUrlString + sWdaApplicationUrlString.length))
-                                );
-                            }
-                            if (oApplication.url.indexOf(sWdaApplicationOtherUrlString) >= 0) {
-                                // other WebDynproABAPApplication
-                                // /sap/bc/webdynpro/sap/S_EPM_FPM_PO?sap-client=120&sap-language=EN&sap-ui-tech-hint=WDA&
-                                oMetadata[sKey].technicalName = new RegExp(sWdaApplicationOtherUrlString + "(.*)[?]").exec(oApplication.url)[1];
-                            }
-                            oMetadata[sKey].complete = true;
-                            if (iIndexOfWebGUIApplicationUrlString >= 0) {
-                                // WebGUITransaction
-                                // /sap/bc/gui/sap/its/webgui;~sysid=XXX;~service=3255?%7etransaction=SU01&%7enosplash=1
-                                var sETransactionString = "etransaction=",
-                                    iETransactionStart = oApplication.url.indexOf(sETransactionString, iIndexOfWebGUIApplicationUrlString + sWebGUIApplicationUrlString.length),
-                                    iETransactionEndDetermination = oApplication.url.indexOf("&", iETransactionStart),
-                                    iETransactionEnd = (iETransactionEndDetermination >= 0) ? iETransactionEndDetermination : oApplication.url.length;
-                                oMetadata[sKey].technicalName = decodeURIComponent(oApplication.url.substring(
-                                    iETransactionStart + sETransactionString.length,
-                                    iETransactionEnd
-                                )) + " (TCODE)";
-                            }
-                        } else {
-                            Log.warning("No technical information for the given application could be determined", null, "sap.ushell.services.AppConfiguration");
                         }
-                    }
 
-                    /*
-                     * Special behavior for relative URLs:
-                     * Relative URLs are considered relative to the folder containing the Component.js, which requires adjustments here.
-                     * Otherwise the browser would interpret them as relative to the location of the HTML file,
-                     * which might be different and also hard to guess for app developers.
-                     */
-                    potentiallyRelativeUrls = [
-                        "favIcon",
-                        "homeScreenIconPhone",
-                        "homeScreenIconPhone@2",
-                        "homeScreenIconTablet",
-                        "homeScreenIconTablet@2",
-                        "startupImage320x460",
-                        "startupImage640x920",
-                        "startupImage640x1096",
-                        "startupImage768x1004",
-                        "startupImage748x1024",
-                        "startupImage1536x2008",
-                        "startupImage1496x2048"
-                    ];
-
-                    sComponentUrl = (sUrl && sUrl[sUrl.length - 1] === "/") ?
-                        sUrl.substring(0, sUrl.length - 1) : sUrl;
-
-                    isUrlRelative = function (sUrl) {
-                        if (sUrl.match(/^https?:\/\/.*/)) {
-                            return false;
+                        oMetadata[sKey].version = oLocalMetadataComponent.getVersion();
+                        oMetadata[sKey].technicalName = oLocalMetadataComponent.getComponentName();
+
+                        this._setTitleFromNavResult(oMetadata[sKey], oApplication);
+
+                    } else if (ushellUtils.isApplicationTypeEmbeddedInIframe(oApplication.applicationType)) {
+                        const sWdaApplicationUrlString = "/~canvas;window=app/wda/";
+                        const iIndexOfWdaApplicationUrlString = oApplication.url.indexOf(sWdaApplicationUrlString);
+                        const sWdaApplicationOtherUrlString = "/sap/bc/webdynpro/sap/";
+                        const sWebGUIApplicationUrlString = "/bc/gui/sap/its/webgui";
+                        const iIndexOfWebGUIApplicationUrlString = oApplication.url.indexOf(sWebGUIApplicationUrlString);
+
+                        if (iIndexOfWdaApplicationUrlString >= 0) {
+                            // WebDynproABAPApplication
+                            // /ui2/nwbc/~canvas;window=app/wda/S_EPM_FPM_PD/?sap-wd-configId=s_epm_fpm_pd
+                            oMetadata[sKey].technicalName = oApplication.url.substring(
+                                (iIndexOfWdaApplicationUrlString + sWdaApplicationUrlString.length),
+                                oApplication.url.indexOf("/", (iIndexOfWdaApplicationUrlString + sWdaApplicationUrlString.length))
+                            );
                         }
-                        return sUrl && sUrl[0] !== "/";
-                    };
-
-                    potentiallyRelativeUrls.forEach(function (sPropName) {
-                        var sOrigValue = oMetadata[sKey][sPropName],
-                            sFinalValue = null;
-                        // Some URL properties might not be defined.
-                        if (sOrigValue) {
-                            sFinalValue = isUrlRelative(sOrigValue) ?
-                                sComponentUrl + "/" + sOrigValue : sOrigValue;
+                        if (oApplication.url.indexOf(sWdaApplicationOtherUrlString) >= 0) {
+                            // other WebDynproABAPApplication
+                            // /sap/bc/webdynpro/sap/S_EPM_FPM_PO?sap-client=120&sap-language=EN&sap-ui-tech-hint=WDA&
+                            oMetadata[sKey].technicalName = new RegExp(sWdaApplicationOtherUrlString + "(.*)[?]").exec(oApplication.url)[1];
                         }
-                        oMetadata[sKey][sPropName] = sFinalValue;
-                    });
+                        oMetadata[sKey].complete = true;
+                        if (iIndexOfWebGUIApplicationUrlString >= 0) {
+                            // WebGUITransaction
+                            // /sap/bc/gui/sap/its/webgui;~sysid=XXX;~service=3255?%7etransaction=SU01&%7enosplash=1
+                            const sETransactionString = "etransaction=";
+                            const iETransactionStart = oApplication.url.indexOf(sETransactionString, iIndexOfWebGUIApplicationUrlString + sWebGUIApplicationUrlString.length);
+                            const iETransactionEndDetermination = oApplication.url.indexOf("&", iETransactionStart);
+                            const iETransactionEnd = (iETransactionEndDetermination >= 0) ? iETransactionEndDetermination : oApplication.url.length;
+                            oMetadata[sKey].technicalName = decodeURIComponent(oApplication.url.substring(
+                                iETransactionStart + sETransactionString.length,
+                                iETransactionEnd
+                            )) + " (TCODE)";
+                        }
+                    } else {
+                        Log.warning("No technical information for the given application could be determined", null, "sap.ushell.services.AppConfiguration");
+                    }
                 }
+
+                /*
+                 * Special behavior for relative URLs:
+                 * Relative URLs are considered relative to the folder containing the Component.js, which requires adjustments here.
+                 * Otherwise the browser would interpret them as relative to the location of the HTML file,
+                 * which might be different and also hard to guess for app developers.
+                 */
+                const potentiallyRelativeUrls = [
+                    "favIcon",
+                    "homeScreenIconPhone",
+                    "homeScreenIconPhone@2",
+                    "homeScreenIconTablet",
+                    "homeScreenIconTablet@2",
+                    "startupImage320x460",
+                    "startupImage640x920",
+                    "startupImage640x1096",
+                    "startupImage768x1004",
+                    "startupImage748x1024",
+                    "startupImage1536x2008",
+                    "startupImage1496x2048"
+                ];
+
+                const sComponentUrl = (sUrl?.[sUrl.length - 1] === "/") ? sUrl.substring(0, sUrl.length - 1) : sUrl;
+
+                potentiallyRelativeUrls.forEach((sPropName) => {
+                    const sOrigValue = oMetadata[sKey][sPropName];
+                    let sFinalValue = null;
+                    // Some URL properties might not be defined.
+                    if (sOrigValue) {
+                        sFinalValue = this._isUrlRelative(sOrigValue) ? `${sComponentUrl}/${sOrigValue}` : sOrigValue;
+                    }
+                    oMetadata[sKey][sPropName] = sFinalValue;
+                });
             } catch (err) {
                 Log.warning("Application configuration could not be parsed");
             }
         };
 
+        /**
+         * Checks if the given URL is relative.
+         * @param {sap.ui.core.URI} sUrl The URL to check
+         * @returns {boolean} true if the URL is relative, false otherwise
+         *
+         * @private
+         * @alias sap.ushell.services.AppConfiguration#_isUrlRelative
+         */
+        this._isUrlRelative = function (sUrl) {
+            if (!sUrl) {
+                return false;
+            }
+            if (sUrl.match(/^https?:\/\/.*/)) {
+                return false;
+            }
+            return sUrl[0] !== "/";
+        };
+
         /**
          * Helper function to override the title of the manifest
          * with the title from the navigation result (target mapping).
@@ -708,21 +759,20 @@ sap.ui.define([
          * in the FLP content with a specific title.
          *
          * @param {object} oMetadataEntry - the metadata for a specific app
-         * @param {object} oApplication - the application data retrieved from the
-         *  navigation target resolution
+         * @param {object} oApplication - the application data retrieved from the navigation target resolution
          *
          * @private
          * @alias sap.ushell.services.AppConfiguration#_setTitleFromNavResult
          */
         this._setTitleFromNavResult = function (oMetadataEntry, oApplication) {
-            var sNavTargetResolutionTitle = oApplication && oApplication.text;
-            var sUi5ComponentName = oMetadataEntry.technicalName;
-            var aUseAppTitleFromNavTargetResolutionConfig = Config.last("/core/shell/useAppTitleFromNavTargetResolution") || [];
+            const sNavTargetResolutionTitle = oApplication?.text;
+            const sUi5ComponentName = oMetadataEntry.technicalName;
+            const aUseAppTitleFromNavTargetResolutionConfig = Config.last("/core/shell/useAppTitleFromNavTargetResolution") || [];
             if (sNavTargetResolutionTitle && aUseAppTitleFromNavTargetResolutionConfig.includes(sUi5ComponentName)) {
                 oMetadataEntry.title = sNavTargetResolutionTitle;
             }
         };
-    } // Metadata
+    }
 
     return new AppConfiguration();
 }, true /* bExport */);