@sapui5/sap.suite.ui.generic.template 1.131.1 → 1.133.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sapui5/sap.suite.ui.generic.template",
-  "version": "1.131.1",
+  "version": "1.133.0",
   "description": "SAPUI5 Library sap.suite.ui.generic.template",
   "keywords": [
     "sapui5",

package/src/sap/suite/ui/generic/template/.library

@@ -7,7 +7,7 @@
 
 		(c) Copyright 2009-2015 SAP SE. All rights reserved
 	</copyright>
-	<version>1.131.1</version>
+	<version>1.133.0</version>
 
 	<documentation>Library with generic Suite UI templates.</documentation>
 

package/src/sap/suite/ui/generic/template/AnalyticalListPage/Component.js

@@ -302,10 +302,6 @@ sap.ui.define(["sap/ui/core/mvc/OverrideExecution",
 							if (oAlpSettings.isResponsiveTable === undefined){
 								oAlpSettings.isResponsiveTable = oVariants[sKey].tableSettings.type === "ResponsiveTable";
 							}
-							var oVariantEntityType = oMetaModel.getODataEntityType(oEntitySet.entityType);
-							if (oVariantEntityType && oVariantEntityType.property && oVariants[sKey].tableSettings && oVariants[sKey].tableSettings.createWithParameterDialog) {
-								oAlpSettings.quickVariantSelectionX.variants[sKey].tableSettings.createWithParameterDialog.id = StableIdHelper.getStableId({type: 'ALPAction', subType: 'CreateWithDialog', sQuickVariantKey: oVariants[sKey].key});
-							}
 							setTargetEntity(oEntitySet);
 							// tableSettings in case of Multitable, it may contain chart or table settings.
 							oVariants[sKey].tableSettings = deepExtend(oVariants[sKey].tableSettings, fnCustomActions(oVariants[sKey].key, sKey).tableSettings, fnGetAnnotatedActionsCommandDetails(sKey).tableSettings);

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/SmartFilterBarExt.js

@@ -13,7 +13,9 @@ sap.ui.define([
 				switchToVisualFilter: {}
 			}
 		},
-		renderer: {}
+		renderer: {
+			apiVersion: 2
+		}
 	});
 
 	SmartFilterBarExt.prototype.getSuppressValueListsAssociation = function () {

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/SmartKpiTag.js

@@ -17,14 +17,38 @@ sap.ui.define([
 	"sap/m/MessageStrip",
 	"sap/ui/core/format/NumberFormat",
 	"sap/m/library",
-	"sap/ui/core/library",
 	"sap/suite/ui/generic/template/genericUtilities/FeLogger",
 	"sap/m/GenericTag",
 	"sap/m/ObjectNumber",
-	"sap/ui/events/KeyCodes"
-], function (Control, KpiTagController, KpiUtil, KpiAnnotationHelper, FilterUtil, V4Terms,
-	ODataModelUtil, KpiProvider, ListUtils, Device, SelectionVariant, Filter, JSONModel, Locale, ResponsivePopover, MessageStrip,
-	NumberFormat, SapMLibrary, SapCoreLibrary, FeLogger, GenericTag, ObjectNumber, KeyCodes) {
+	"sap/ui/events/KeyCodes",
+	"sap/ui/core/Element",
+	"sap/ui/core/message/MessageType"
+], function (
+	Control,
+	KpiTagController,
+	KpiUtil,
+	KpiAnnotationHelper,
+	FilterUtil,
+	V4Terms,
+	ODataModelUtil,
+	KpiProvider,
+	ListUtils,
+	Device,
+	SelectionVariant,
+	Filter,
+	JSONModel,
+	Locale,
+	ResponsivePopover,
+	MessageStrip,
+	NumberFormat,
+	SapMLibrary,
+	FeLogger,
+	GenericTag,
+	ObjectNumber,
+	KeyCodes,
+	Element,
+	MessageType
+) {
 	"use strict";
 	var oFeLogger = new FeLogger("AnalyticalListPage.control.SmartKpiTag");
 	var oLogger = oFeLogger.getLogger();
@@ -78,8 +102,8 @@ sap.ui.define([
 					bindable: false
 				},
 				errorType: {
-					type : "sap.ui.core.MessageType",
-					defaultValue : SapCoreLibrary.MessageType.Error
+					type : "sap.ui.core.message.MessageType",
+					defaultValue : MessageType.Error
 				},
 				errorMessage: {
 					type: "string",
@@ -105,7 +129,9 @@ sap.ui.define([
 				beforeRebindFilterableKPI: {}
 			}
 		},
-		renderer: {},
+		renderer: {
+			apiVersion: 2
+		},
 		_isPercent: false,
 		_unScaledValue: "",
 		_sUnitofMeasure: "",
@@ -654,7 +680,7 @@ sap.ui.define([
 				}
 			} catch (oError) {
 				//Check no data / incorrect format scenario, display warning for such cases
-				this.setProperty("errorType", SapCoreLibrary.MessageType.Warning);
+				this.setProperty("errorType", MessageType.Warning);
 				var oRb = this.getModel("i18n").getResourceBundle();
 				this.setProperty('errorMessage', oRb.getText("KPI_NO_DATA"));
 				oLogger.warning("KPI error details: " + oRb.getText("KPI_NO_DATA"));
@@ -744,7 +770,7 @@ sap.ui.define([
 				oLogger.error("KPI error details: " + oRb.getText("REQUIRED_VH_FIELDS_OVERLAY_MESSAGE"));
 				this.setStatus("Error");
 			} else if (bIsReqFilterbarData) {
-				this.setProperty("errorType", SapCoreLibrary.MessageType.Information);
+				this.setProperty("errorType", MessageType.Information);
 				/*var oRb = this.getModel("i18n").getResourceBundle();*/
 				this.setProperty('errorMessage', oRb.getText("KPI_INFO_FOR_MISSING_MANDATE_FILTPAR"));
 				oLogger.info("KPI error details: " + oRb.getText("KPI_INFO_FOR_MISSING_MANDATE_FILTPAR"), " ", this);
@@ -972,7 +998,7 @@ sap.ui.define([
 			var oResultControl, oView;
 			if (sId) {
 				// Try to get SmartFilter from Id
-				oResultControl = sap.ui.getCore().byId(sId);
+				oResultControl = Element.getElementById(sId);
 
 				// Try to get SmartFilter from parent View!
 				if (!oResultControl) {

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/visualfilterbar/FilterItem.js

@@ -41,7 +41,9 @@ sap.ui.define(["sap/ui/core/Control", "sap/ui/model/Filter"],
 				titleChange: {}
 			}
 		},
-		renderer: {}
+		renderer: {
+			apiVersion: 2
+		}
 	});
 
 	return FilterItem;

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/visualfilterbar/FilterItemMicroBar.js

@@ -19,7 +19,9 @@ sap.ui.define(["sap/suite/ui/microchart/InteractiveBarChart",
 				control: {type: "sap.suite.ui.microchart.InteractiveBarChart", multiple: false}
 			}
 		},
-		renderer:{}
+		renderer: {
+			apiVersion: 2
+		}
 	});
 
 	FilterItemMicroBar.prototype.init = function() {

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/visualfilterbar/FilterItemMicroChart.js

@@ -10,8 +10,23 @@ sap.ui.define([
 	"sap/suite/ui/generic/template/AnalyticalListPage/util/CriticalityUtil",
 	"sap/suite/ui/generic/template/listTemplates/listUtils",
 	"sap/base/util/extend",
-	"sap/base/util/deepExtend"
-], function(Control, Sorter, oData4Analytics, FilterUtil, NumberFormat, v4Terms, DateFormat, FeLogger, CriticalityUtil, ListUtils, extend, deepExtend) {
+	"sap/base/util/deepExtend",
+	"sap/ui/core/Element"
+], function(
+	Control,
+	Sorter,
+	oData4Analytics,
+	FilterUtil,
+	NumberFormat,
+	v4Terms,
+	DateFormat,
+	FeLogger,
+	CriticalityUtil,
+	ListUtils,
+	extend,
+	deepExtend,
+	Element
+) {
 	"use strict";
 
 	var oLogger = new FeLogger("AnalyticalListPage.control.visualfilterbar.FilterItemMicroChart").getLogger();
@@ -32,7 +47,7 @@ sap.ui.define([
 				dimensionFieldIsDateTimeOffset: { type: "boolean", group: "Misc", defaultValue: false },
 				dimensionFieldDisplay: { type: "string", group: "Misc", defaultValue: null },
 				dimensionFilter: { type: "any", group: "Misc", defaultValue: null },
-				dimensionFilterExternal: { type: "sap.ui.model.Filter", group: "Misc", defaultValue: null },
+				dimensionFilterExternal: { type: "any", group: "Misc", defaultValue: null },
 				measureField: { type: "string", group: "Misc", defaultValue: null },
 				unitField: { type: "string", group: "Misc", defaultValue: null },
 				isCurrency: { type: "boolean", group: "Misc", defaultValue: false },
@@ -158,7 +173,7 @@ sap.ui.define([
 	FilterItemChart.prototype._getEntityParameters = function(oModel, entitySet) {
 		var allParams = {};
 		if (this.getSmartFilterId()) { //if it has referance to smart filter bar
-			var oSmartFilterBar = sap.ui.getCore().byId(this.getSmartFilterId());
+			var oSmartFilterBar = Element.getElementById(this.getSmartFilterId());
 			var aSVParameters =  ListUtils.getSelectionVariantParameterNamesWithoutNavigation(this.getSelectFilters() && this.getSelectFilters().Parameters);
 			var oSFBParams = oSmartFilterBar.getEntitySet() === entitySet ? oSmartFilterBar.getAnalyticalParameters() : [];
 			var aSVSelectOptions = this.getSelectFilters() && this.getSelectFilters().SelectOptions;
@@ -826,7 +841,8 @@ sap.ui.define([
 	};
 
 	FilterItemChart.prototype._onDataReceived = function(data) {
-		if (!data) {
+		// Setting custom data when the element is being destroyed will throw error and the custom data changes won't be applied.
+		if (!data || this.isDestroyStarted()) {
 			return;
 		}
 		this.data("sOverlay", "none"); //for visual filter bar aria handled by onTitleChange() only
@@ -1323,7 +1339,7 @@ sap.ui.define([
 	};
 
 	FilterItemChart.prototype._getChartAggregationSettings =  function(bIsChartType) {
-		var sfb = sap.ui.getCore().byId(this.getSmartFilterId());
+		var sfb = Element.getElementById(this.getSmartFilterId());
 		var sDimField = ( bIsChartType === CHART_TYPE_DONUT ) ? 'dimensionValue' : this.getDimensionField(),
 			sDimFieldDisplay = this.getDimensionFieldDisplay(),
 			sMeasureField = this.getMeasureField(),
@@ -1397,6 +1413,10 @@ sap.ui.define([
 	 * @return {void}
 	**/
 	FilterItemChart.prototype.applyOverlay = function(sI18n, sLabel) {
+		// Setting custom data when the element is being destroyed will throw error and the custom data changes won't be applied.
+		if (this.isDestroyStarted()) {
+			return;
+		}
 		if (sI18n) {
 			this._chart.setShowError(true);
 			this._chart.setErrorMessageTitle(this._getI18nText("M_VISUAL_FILTERS_ERROR_MESSAGE_TITLE"));

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/visualfilterbar/FilterItemMicroDonut.js

@@ -21,7 +21,9 @@ sap.ui.define(["sap/suite/ui/microchart/InteractiveDonutChart",
 				control: {type: "sap.suite.ui.microchart.InteractiveDonutChart", multiple: false}
 			}
 		},
-		renderer:{}
+		renderer: {
+			apiVersion: 2
+		}
 	});
 
 	FilterItemMicroDonut.prototype.init = function() {

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/visualfilterbar/FilterItemMicroLine.js

@@ -19,7 +19,9 @@ sap.ui.define(["sap/suite/ui/microchart/InteractiveLineChart",
 				control: {type: "sap.suite.ui.microchart.InteractiveLineChart", multiple : false}
 			}
 		},
-		renderer:{}
+		renderer: {
+			apiVersion: 2
+		}
 	});
 
 	FilterItemMicroLine.prototype.init = function() {

package/src/sap/suite/ui/generic/template/AnalyticalListPage/control/visualfilterbar/SmartVisualFilterBar.js

@@ -8,7 +8,6 @@ sap.ui.define([
 	"sap/ui/model/Filter",
 	"sap/m/OverflowToolbar",
 	"sap/m/ToolbarSpacer",
-	"sap/ui/comp/odata/MetadataAnalyser",
 	"sap/suite/ui/generic/template/AnalyticalListPage/util/FilterUtil",
 	"sap/suite/ui/generic/template/AnalyticalListPage/util/V4Terms",
 	"sap/m/VBox",
@@ -21,7 +20,6 @@ sap.ui.define([
 	"sap/suite/ui/generic/template/AnalyticalListPage/control/visualfilterbar/FilterItemMicroDonut",
 	"sap/ui/model/json/JSONModel",
 	"sap/ui/core/CustomData",
-	"sap/m/Text",
 	"sap/m/OverflowToolbarLayoutData",
 	"sap/ui/model/FilterOperator",
 	"sap/ui/Device",
@@ -33,15 +31,46 @@ sap.ui.define([
 	"sap/ui/core/InvisibleText",
 	"sap/suite/ui/generic/template/js/StableIdHelper",
 	"sap/base/util/deepExtend",
-	"sap/m/DynamicDateRange"
-], function(HeaderContainer, VisualFilterDialogController,
-		ODataModelUtil,
-		VisualFilterProvider,
-		PersonalizableInfo, SmartVariantManagement,
-		Filter,
-		OverflowToolbar, ToolbarSpacer, MetadataAnalyser, FilterUtil, V4Terms, VBox, Button, Title,
-		DropDownController, DynamicDateRangeController, FilterItemMicroBar, FilterItemMicroLine, FilterItemMicroDonut, JSONModel,
-		CustomData, Text, OverflowToolbarLayoutData, FilterOperator, Device, SimpleType, SapCoreLibrary, SapMLibrary, DatePicker, FeLogger, InvisibleText, StableIdHelper, deepExtend, DynamicDateRange) {
+	"sap/m/DynamicDateRange",
+	"sap/ui/core/Control",
+	"sap/ui/core/Element"
+], function(
+	HeaderContainer, 
+	VisualFilterDialogController,
+	ODataModelUtil,
+	VisualFilterProvider,
+	PersonalizableInfo, 
+	SmartVariantManagement,
+	Filter,
+	OverflowToolbar, 
+	ToolbarSpacer, 
+	FilterUtil,
+	V4Terms,
+	VBox,
+	Button,
+	Title,
+	DropDownController,
+	DynamicDateRangeController,
+	FilterItemMicroBar,
+	FilterItemMicroLine,
+	FilterItemMicroDonut,
+	JSONModel,
+	CustomData,
+	OverflowToolbarLayoutData,
+	FilterOperator,
+	Device,
+	SimpleType,
+	SapCoreLibrary,
+	SapMLibrary,
+	DatePicker,
+	FeLogger,
+	InvisibleText,
+	StableIdHelper,
+	deepExtend,
+	DynamicDateRange,
+	Control,
+	Element
+) {
 	"use strict";
 	var oLogger = new FeLogger("AnalyticalListPage.visualfilterbar.SmartVisualFilterBar").getLogger();
 
@@ -87,7 +116,9 @@ sap.ui.define([
 				onFilterItemAdded: {}
 			}
 		},
-		renderer: {}
+		renderer: {
+			apiVersion: 2
+		}
 	});
 
 	SmartVisualFilterBar.prototype.init = function() {
@@ -1196,7 +1227,7 @@ sap.ui.define([
 
 		var itemIndex = 0;
 		//var itemList = this.getContent();
-		var itemList = sap.ui.getCore().byFieldGroupId("headerBar");
+		var itemList = Control.getControlsByFieldGroupId("headerBar");
 		for (var i = 0; i < config.filterCompList.length; i++) {
 			var compConfig = config.filterCompList[i];
 			if (bIsVariantConfig) {
@@ -1270,7 +1301,7 @@ sap.ui.define([
 	SmartVisualFilterBar.prototype._getVariantManagementControl = function(oSmartVariantId) {
 		var oSmartVariantControl = null;
 		if (oSmartVariantId) {
-			oSmartVariantControl = typeof oSmartVariantId == "string" ? sap.ui.getCore().byId(oSmartVariantId) : oSmartVariantId;
+			oSmartVariantControl = typeof oSmartVariantId == "string" ? Element.getElementById(oSmartVariantId) : oSmartVariantId;
 
 			if (oSmartVariantControl && !(oSmartVariantControl instanceof SmartVariantManagement)) {
 				oLogger.error("Control with the id=" + oSmartVariantId.getId ? oSmartVariantId.getId() : oSmartVariantId + " not of expected type");
@@ -1366,7 +1397,7 @@ sap.ui.define([
 				}
 			}
 		} else {//update chart bindings in the filterbar
-			var itemList = sap.ui.getCore().byFieldGroupId("headerBar");
+			var itemList = Control.getControlsByFieldGroupId("headerBar");
 			for (var i = 0; i < itemList.length; i++) {
 				if (itemList[i]._chart) {
 					itemList[i]._updateBinding();

package/src/sap/suite/ui/generic/template/AnalyticalListPage/controller/DropDownController.js

@@ -1,19 +1,44 @@
 sap.ui.define([
-		'sap/ui/core/mvc/Controller',
-		'sap/ui/model/Filter',
-		"sap/m/Button",
-		"sap/m/StandardListItem",
-		"sap/m/List",
-		"sap/m/ToolbarSpacer",
-		"sap/suite/ui/generic/template/AnalyticalListPage/util/FilterUtil",
-		"sap/m/ResponsivePopover",
-		"sap/m/Label", "sap/m/ToggleButton", "sap/m/SearchField", "sap/m/Toolbar",
-		"sap/ui/core/Icon", "sap/ui/model/Sorter",
-		"sap/ui/model/FilterOperator", "sap/m/library",
-		"sap/base/util/extend",
-		"sap/base/util/deepExtend"
-	], function(Controller, Filter, Button, StandardListItem, List, ToolbarSpacer, FilterUtil, ResponsivePopover, Label, ToggleButton,
-		SearchField, Toolbar, Icon, Sorter, FilterOperator, SapMLibrary, extend, deepExtend) {
+	"sap/ui/core/mvc/Controller",
+	"sap/ui/model/Filter",
+	"sap/m/Button",
+	"sap/m/StandardListItem",
+	"sap/m/List",
+	"sap/m/ToolbarSpacer",
+	"sap/suite/ui/generic/template/AnalyticalListPage/util/FilterUtil",
+	"sap/m/ResponsivePopover",
+	"sap/m/Label",
+	"sap/m/ToggleButton",
+	"sap/m/SearchField",
+	"sap/m/Toolbar",
+	"sap/ui/core/Icon",
+	"sap/ui/model/Sorter",
+	"sap/ui/model/FilterOperator",
+	"sap/m/library",
+	"sap/base/util/extend",
+	"sap/base/util/deepExtend",
+	"sap/ui/core/Element"
+], function (
+	Controller,
+	Filter,
+	Button,
+	StandardListItem,
+	List,
+	ToolbarSpacer,
+	FilterUtil,
+	ResponsivePopover,
+	Label,
+	ToggleButton,
+	SearchField,
+	Toolbar,
+	Icon,
+	Sorter,
+	FilterOperator,
+	SapMLibrary,
+	extend,
+	deepExtend,
+	Element
+) {
 	"use strict";
 
 	var bShowOnlySelected = false, oToolbar = {}, oInfoLabel = {}, oUpdatedDimensionFilter = "",
@@ -34,7 +59,7 @@ sap.ui.define([
 	sap.suite.ui.generic.template.AnalyticalListPage.controller.DropDownController.createDropdown = function(oControl, oChart, oModel, title, property, bIsEntitySearchable) {
 		oUpdatedDimensionFilter = (property.filterRestriction == 'multiple') ? deepExtend({items: [], ranges: [], value: null}, oChart.getDimensionFilter()) : oChart.getDimensionFilter();
 		var i18n = oControl.getModel('i18n'),
-		oSmartFilterBar = sap.ui.getCore().byId(oChart.getSmartFilterId()),
+		oSmartFilterBar = Element.getElementById(oChart.getSmartFilterId()),
 		filterBy = {"descriptionAndId":property.dimensionFieldDisplay, "descriptionOnly":property.dimensionFieldDisplay, "idAndDescription":property.dimensionField, "idOnly":property.dimensionField},
 		filterBy = (Object.keys(filterBy).indexOf(property.textArrangement) !== -1) ? filterBy[property.textArrangement] : property.dimensionFieldDisplay,
 		oToolbarMenuButton = new ToggleButton({
@@ -199,7 +224,7 @@ sap.ui.define([
 			});
 
 		if (oChart.getSmartFilterId()) {
-			var oSmartFilterBar = sap.ui.getCore().byId(oChart.getSmartFilterId());
+			var oSmartFilterBar = Element.getElementById(oChart.getSmartFilterId());
 			if (oSmartFilterBar && oSmartFilterBar.getEntitySet() === property.entitySet) {
 				sBindingPath = oChart.considerAnalyticBinding(sBindingPath,oSmartFilterBar);
 			}

package/src/sap/suite/ui/generic/template/AnalyticalListPage/controller/KpiTagController.js

@@ -1,16 +1,25 @@
 sap.ui.define([
 	"sap/suite/ui/generic/template/AnalyticalListPage/controller/KpiCard.controller",
 	"sap/ui/model/json/JSONModel",
-	"sap/ui/core/library",
+	"sap/ui/core/mvc/ViewType",
 	"sap/ui/Device",
 	"sap/m/ResponsivePopover",
 	"sap/suite/ui/generic/template/genericUtilities/FeLogger",
-	"sap/ui/core/mvc/View"
-], function (KpiCardController, JSONModel, coreLibrary, Device, ResponsivePopover, FeLogger, View) {
+	"sap/ui/core/mvc/View",
+	"sap/ui/core/Element"
+], function (
+	KpiCardController,
+	JSONModel,
+	ViewType,
+	Device,
+	ResponsivePopover,
+	FeLogger,
+	View,
+	Element
+) {
 	"use strict";
 	var oLogger = new FeLogger("AnalyticalListPage.controller.KpiTagController").getLogger();
-	var OVPLoaded, ViewType;
-	ViewType = coreLibrary.mvc.ViewType;
+	var OVPLoaded;
 
 	var KpiTagController = {
 		_kpiCards: [],
@@ -40,7 +49,7 @@ sap.ui.define([
 			var me = this;
 			var oSource;
 			if (typeof oEvent.currentTarget != "undefined") {
-				oSource = sap.ui.getCore().byId(oEvent.currentTarget.id);
+				oSource = Element.getElementById(oEvent.currentTarget.id);
 			} else {
 				oSource = oEvent.getSource();
 			}

package/src/sap/suite/ui/generic/template/AnalyticalListPage/extensionAPI/ExtensionAPI.js

@@ -208,8 +208,8 @@ sap.ui.define(["sap/ui/base/Object",
 			 * Provide an option for showing an own message in the message bar above the ALP table
 			 * @param {object} [oMessage] custom message along with type to set on table. If this parameter is faulty an existing message will be removed.
 			 * @param {string} oMessage.message message string to display
-			 * @param {string} oMessage.type indicates type of message (sap.ui.core.MessageType)
-			 *  whether it's sap.ui.core.MessageType.Success, sap.ui.core.MessageType.Warning, sap.ui.core.MessageType.Error or sap.ui.core.MessageType.Information.
+			 * @param {string} oMessage.type indicates type of message (sap/ui/core/message/MessageType)
+			 *  whether it's MessageType.Success, MessageType.Warning, MessageType.Error or MessageType.Information.
 			 * @param {array |string} [vTabKey]  If switching between different table views is enabled, this parameter can be used to identify the views which
 			 * are affected by this call. Faulty values indicate that all views should be affected. Otherwise the value should either be one string or an array of strings
 			 * identifying the affected variant items.