@sapui5/sap.fe.templates 1.103.0 → 1.106.0

package/src/sap/fe/templates/ObjectPage/ObjectPageController.controller.ts

@@ -1,6 +1,7 @@
 import type ResourceBundle from "sap/base/i18n/ResourceBundle";
 import Log from "sap/base/Log";
 import merge from "sap/base/util/merge";
+import ActionRuntime from "sap/fe/core/ActionRuntime";
 import CommonUtils from "sap/fe/core/CommonUtils";
 import BusyLocker from "sap/fe/core/controllerextensions/BusyLocker";
 import { connect } from "sap/fe/core/controllerextensions/collaboration/ActivitySync";
@@ -39,17 +40,17 @@ import type Popover from "sap/m/Popover";
 import Core from "sap/ui/core/Core";
 import OverrideExecution from "sap/ui/core/mvc/OverrideExecution";
 import type Binding from "sap/ui/model/Binding";
-import JSONModel from "sap/ui/model/json/JSONModel";
+import type JSONModel from "sap/ui/model/json/JSONModel";
 import type Context from "sap/ui/model/odata/v4/Context";
 import ODataListBinding from "sap/ui/model/odata/v4/ODataListBinding";
 import type ODataMetaModel from "sap/ui/model/odata/v4/ODataMetaModel";
 import type ODataModel from "sap/ui/model/odata/v4/ODataModel";
 import type ResourceModel from "sap/ui/model/resource/ResourceModel";
+import type BreadCrumbs from "sap/uxap/BreadCrumbs";
 import type ObjectPageDynamicHeaderTitle from "sap/uxap/ObjectPageDynamicHeaderTitle";
 import type ObjectPageLayout from "sap/uxap/ObjectPageLayout";
 import type ObjectPageSection from "sap/uxap/ObjectPageSection";
 import type ObjectPageSubSection from "sap/uxap/ObjectPageSubSection";
-import DraftHandler from "./handler/DraftHandler";
 import IntentBasedNavigationOverride from "./overrides/IntentBasedNavigation";
 import InternalRoutingOverride from "./overrides/InternalRouting";
 import MessageHandlerOverride from "./overrides/MessageHandler";
@@ -257,18 +258,26 @@ class ObjectPageController extends PageController {
 				if (oBinding.isA("sap.ui.model.odata.v4.ODataListBinding")) {
 					this.paginator.initialize(oBinding, oContext);
 				} else {
-					//if the binding type is not ODataListBinding because of a deeplink navigation or a refresh of the page
+					// if the binding type is not ODataListBinding because of a deeplink navigation or a refresh of the page
 					// we need to create it
-					const sContextPath = oBinding.getPath().replace(/\([^\)]*\)*$/, ""); //removing the last tuple
-					oBinding = new (ODataListBinding as any)(oBinding.oModel, "", oBinding.oModel.createBindingContext(sContextPath));
-					const _setListBindingAsync = () => {
-						if (oBinding.getContexts().length > 0) {
-							this.paginator.initialize(oBinding, oContext);
-							oBinding.detachEvent("change", _setListBindingAsync);
-						}
-					};
-					oBinding.getContexts(0);
-					oBinding.attachEvent("change", _setListBindingAsync);
+					const sBindingPath = oBinding.getPath();
+					if (/\([^\)]*\)$/.test(sBindingPath)) {
+						// The current binding path ends with (xxx), so we create the listBinding by removing (xxx)
+						const sListBindingPath = sBindingPath.replace(/\([^\)]*\)$/, "");
+						oBinding = new (ODataListBinding as any)(oBinding.oModel, sListBindingPath);
+						const _setListBindingAsync = () => {
+							if (oBinding.getContexts().length > 0) {
+								this.paginator.initialize(oBinding, oContext);
+								oBinding.detachEvent("change", _setListBindingAsync);
+							}
+						};
+
+						oBinding.getContexts(0);
+						oBinding.attachEvent("change", _setListBindingAsync);
+					} else {
+						// The current binding doesn't end with (xxx) --> the last segment is a 1-1 navigation, so we don't display the paginator
+						this.paginator.initialize(undefined);
+					}
 				}
 			}
 		}
@@ -392,6 +401,7 @@ class ObjectPageController extends PageController {
 	}
 
 	_onBackNavigationInDraft(oContext: any) {
+		this.messageHandler.removeTransitionMessages();
 		if (this.getAppComponent().getRouterProxy().checkIfBackHasSameContext()) {
 			// Back nav will keep the same context --> no need to display the dialog
 			history.back();
@@ -459,7 +469,9 @@ class ObjectPageController extends PageController {
 				),
 				aSelectedContexts = oTable.getSelectedContexts();
 
-			CommonUtils.setActionEnablement(oInternalModelContext, oActionOperationAvailableMap, aSelectedContexts);
+			ActionRuntime.setActionEnablement(oInternalModelContext, oActionOperationAvailableMap, aSelectedContexts, "table");
+			// Clear the selection in the table, need to be fixed and review with BLI: FIORITECHP1-24318
+			oTable.clearSelection();
 		});
 		CommonUtils.getSemanticTargetsFromPageModel(this, "_pageModel");
 		//Retrieve Object Page header actions from Object Page title control
@@ -477,40 +489,35 @@ class ObjectPageController extends PageController {
 		 * @param oTable
 		 * @param oListBinding
 		 */
-		function enableFastCreationRow(oTable: any, oListBinding: any) {
+		async function enableFastCreationRow(oTable: any, oListBinding: any) {
 			const oFastCreationRow = oTable.getCreationRow();
 			let oFastCreationListBinding, oFastCreationContext;
 
 			if (oFastCreationRow) {
-				oFinalUIState
-					.then(function () {
-						if (oFastCreationRow.getModel("ui").getProperty("/isEditable")) {
-							oFastCreationListBinding = oModel.bindList(oListBinding.getPath(), oListBinding.getContext(), [], [], {
-								$$updateGroupId: "doNotSubmit",
-								$$groupId: "doNotSubmit"
-							});
-							// Workaround suggested by OData model v4 colleagues
-							oFastCreationListBinding.refreshInternal = function () {
-								/* do nothing */
-							};
-							/*
-    															oFastCreationListBinding.hasPendingChanges = function() {
-    								return false;
-    							};
-    															*/
-
-							oFastCreationContext = oFastCreationListBinding.create();
-							oFastCreationRow.setBindingContext(oFastCreationContext);
-
-							// this is needed to avoid console error
-							oFastCreationContext.created().catch(function () {
-								Log.trace("transient fast creation context deleted");
-							});
+				try {
+					await oFinalUIState;
+					if (oFastCreationRow.getModel("ui").getProperty("/isEditable")) {
+						oFastCreationListBinding = oModel.bindList(oListBinding.getPath(), oListBinding.getContext(), [], [], {
+							$$updateGroupId: "doNotSubmit",
+							$$groupId: "doNotSubmit"
+						});
+						// Workaround suggested by OData model v4 colleagues
+						oFastCreationListBinding.refreshInternal = function () {
+							/* do nothing */
+						};
+						oFastCreationContext = oFastCreationListBinding.create();
+						oFastCreationRow.setBindingContext(oFastCreationContext);
+
+						// this is needed to avoid console error
+						try {
+							await oFastCreationContext.created();
+						} catch (e) {
+							Log.trace("transient fast creation context deleted");
 						}
-					})
-					.catch(function (oError: any) {
-						Log.error("Error while computing the final UI state", oError);
-					});
+					}
+				} catch (oError: any) {
+					Log.error("Error while computing the final UI state", oError);
+				}
 			}
 		}
 
@@ -739,7 +746,11 @@ class ObjectPageController extends PageController {
 		if (err) {
 			Log.error(err);
 		}
-		if (!(this.getAppComponent().getRootContainer() as any).getCurrentPage().isA("sap.m.MessagePage")) {
+		const rootViewController = this.getAppComponent().getRootViewController() as any;
+		const currentPageView = rootViewController.isFclEnabled()
+			? rootViewController.getRightmostView()
+			: (this.getAppComponent().getRootContainer() as any).getCurrentPage();
+		if (!currentPageView.isA("sap.m.MessagePage")) {
 			const oMessageButton = this.getView().byId("fe::FooterBar::MessageButton") as any,
 				oMessagePopover = oMessageButton.oMessagePopover,
 				oItemBinding = oMessagePopover.getBinding("items");
@@ -763,7 +774,7 @@ class ObjectPageController extends PageController {
 		});
 	}
 
-	_saveDocument(oContext: any) {
+	async _saveDocument(oContext: any) {
 		const oModel = this.getView().getModel("ui"),
 			aWaitCreateDocuments: any[] = [];
 		// indicates if we are creating a new row in the OP
@@ -792,31 +803,33 @@ class ObjectPageController extends PageController {
 				);
 			}
 		});
-		return Promise.all(aWaitCreateDocuments)
-			.then((aBindings: any[]) => {
-				const mParameters = {
-					bExecuteSideEffectsOnError: bExecuteSideEffectsOnError,
-					bindings: aBindings
-				};
-				// We need to either reject or resolve a promise here and return it since this save
-				// function is not only called when pressing the save button in the footer, but also
-				// when the user selects create or save in a dataloss popup.
-				// The logic of the dataloss popup needs to detect if the save had errors or not in order
-				// to decide if the subsequent action - like a back navigation - has to be executed or not.
-				return this.editFlow.saveDocument(oContext, mParameters).catch((...args) => {
-					// If the saveDocument in editFlow returns errors we need
-					// to show the message popover here and ensure that the
-					// dataloss logic does not perform the follow up function
-					// like e.g. a back navigation hence we return a promise and reject it
-					this._showMessagePopover(...args);
-					return Promise.reject(...args);
-				});
-			})
-			.finally(function () {
-				if (BusyLocker.isLocked(oModel)) {
-					BusyLocker.unlock(oModel);
-				}
-			});
+
+		try {
+			const aBindings = await Promise.all(aWaitCreateDocuments);
+			const mParameters = {
+				bExecuteSideEffectsOnError: bExecuteSideEffectsOnError,
+				bindings: aBindings
+			};
+			// We need to either reject or resolve a promise here and return it since this save
+			// function is not only called when pressing the save button in the footer, but also
+			// when the user selects create or save in a dataloss popup.
+			// The logic of the dataloss popup needs to detect if the save had errors or not in order
+			// to decide if the subsequent action - like a back navigation - has to be executed or not.
+			try {
+				await this.editFlow.saveDocument(oContext, mParameters);
+			} catch (error: any) {
+				// If the saveDocument in editFlow returns errors we need
+				// to show the message popover here and ensure that the
+				// dataloss logic does not perform the follow up function
+				// like e.g. a back navigation hence we return a promise and reject it
+				this._showMessagePopover(error);
+				throw error;
+			}
+		} finally {
+			if (BusyLocker.isLocked(oModel)) {
+				BusyLocker.unlock(oModel);
+			}
+		}
 	}
 
 	_manageCollaboration() {
@@ -836,9 +849,6 @@ class ObjectPageController extends PageController {
 		return this.editFlow.applyDocument(oContext).catch(() => this._showMessagePopover());
 	}
 
-	_showSwitchDraftAndActivePopover = DraftHandler.showSwitchDraftAndActivePopover;
-	_switchDraftAndActivePopoverListSelect = DraftHandler.switchDraftAndActivePopoverListSelect;
-
 	_updateRelatedApps() {
 		const oObjectPage = this._getObjectPageLayoutControl();
 		if (CommonUtils.resolveStringtoBoolean(oObjectPage.data("showRelatedApps"))) {
@@ -856,7 +866,7 @@ class ObjectPageController extends PageController {
 					oElement = oElement[0];
 				}
 			}
-			if (oElement && oElement.isA && oElement.isA("sap.fe.macros.TableAPI")) {
+			if (oElement && oElement.isA && oElement.isA("sap.fe.macros.table.TableAPI")) {
 				oElement = oElement.getContent instanceof Function && oElement.getContent();
 				if (oElement && oElement.length > 0) {
 					oElement = oElement[0];
@@ -1053,32 +1063,32 @@ class ObjectPageController extends PageController {
 	 * @ui5-restricted
 	 * @experimental
 	 */
-	async _setBreadcrumbLinks(oSource: any) {
+	async _setBreadcrumbLinks(oSource: BreadCrumbs) {
 		const oContext = oSource.getBindingContext(),
 			oAppComponent = this.getAppComponent(),
 			aPromises: Promise<void>[] = [],
 			aSkipParameterized: any[] = [],
-			sNewPath = oContext && oContext.getPath(),
-			aPathParts = sNewPath && sNewPath.split("/"),
+			sNewPath = oContext?.getPath(),
+			aPathParts = sNewPath?.split("/") ?? [],
 			oMetaModel = oAppComponent && oAppComponent.getMetaModel();
 		let sPath = "";
-		aPathParts.shift();
-		aPathParts.splice(-1, 1);
-		aPathParts.forEach(function (sPathPart: any) {
-			sPath += `/${sPathPart}`;
-			const oRootViewController = oAppComponent.getRootViewController() as RootContainerBaseController;
-			const sParameterPath = oMetaModel.getMetaPath(sPath);
-			const bResultContext = oMetaModel.getObject(`${sParameterPath}/@com.sap.vocabularies.Common.v1.ResultContext`);
-			if (bResultContext) {
-				// We dont need to create a breadcrumb for Parameter path
-				aSkipParameterized.push(1);
-				return;
-			} else {
-				aSkipParameterized.push(0);
-			}
-			aPromises.push(oRootViewController.getTitleInfoFromPath(sPath));
-		});
 		try {
+			aPathParts.shift();
+			aPathParts.splice(-1, 1);
+			aPathParts.forEach(function (sPathPart: any) {
+				sPath += `/${sPathPart}`;
+				const oRootViewController = oAppComponent.getRootViewController() as RootContainerBaseController;
+				const sParameterPath = oMetaModel.getMetaPath(sPath);
+				const bResultContext = oMetaModel.getObject(`${sParameterPath}/@com.sap.vocabularies.Common.v1.ResultContext`);
+				if (bResultContext) {
+					// We dont need to create a breadcrumb for Parameter path
+					aSkipParameterized.push(1);
+					return;
+				} else {
+					aSkipParameterized.push(0);
+				}
+				aPromises.push(oRootViewController.getTitleInfoFromPath(sPath));
+			});
 			const titleHierarchyInfos: any[] = await Promise.all(aPromises);
 			let idx, hierarchyPosition, oLink;
 			for (const titleHierarchyInfo of titleHierarchyInfos) {