@sapui5/sap.fe.core 1.103.0 → 1.106.0

package/src/sap/fe/core/controllerextensions/InternalIntentBasedNavigation.ts

@@ -111,7 +111,7 @@ class InternalIntentBasedNavigation extends ControllerExtension {
 
 			if (sSemanticObject && sAction) {
 				let aSemanticAttributes: any[] = [],
-					oSelectionVariant = new SelectionVariant();
+					oSelectionVariant: any = new SelectionVariant();
 				// 1. get SemanticAttributes for navigation
 				if (aNavigationContexts && aNavigationContexts.length) {
 					aNavigationContexts.forEach((oNavigationContext: any) => {
@@ -192,15 +192,15 @@ class InternalIntentBasedNavigation extends ControllerExtension {
 				const onError = function () {
 					sap.ui.require(["sap/m/MessageBox"], function (MessageBox: any) {
 						const oResourceBundle = (Core as CoreEx).getLibraryResourceBundle("sap.fe.core");
-						MessageBox.show(oResourceBundle.getText("C_COMMON_HELPER_NAVIGATION_ERROR_MESSAGE"), {
-							title: oResourceBundle.getText("C_COMMON_NAVIGATION_ERROR_TITLE")
+						MessageBox.error(oResourceBundle.getText("C_COMMON_HELPER_NAVIGATION_ERROR_MESSAGE"), {
+							title: oResourceBundle.getText("C_COMMON_SAPFE_ERROR")
 						});
 					});
 				};
 				this._oNavigationService.navigate(
 					sSemanticObject,
 					sAction,
-					(oSelectionVariant as any).toJSONString(),
+					oSelectionVariant.toJSONString(),
 					undefined,
 					onError,
 					undefined,
@@ -566,10 +566,10 @@ class InternalIntentBasedNavigation extends ControllerExtension {
 		return (this._oView.getViewData() as any).entitySet;
 	}
 	/**
-	 * Removes sensitive data from the semantic attribute with respect to entitySet.
+	 * Removes sensitive data from the semantic attribute with respect to the entitySet.
 	 *
 	 * @param oAttributes Context data
-	 * @param sMetaPath Meta path to reach the entityset in the MetaModel
+	 * @param sMetaPath Meta path to reach the entitySet in the MetaModel
 	 * @returns Array of semantic Attributes
 	 * @private
 	 */
@@ -577,30 +577,35 @@ class InternalIntentBasedNavigation extends ControllerExtension {
 	@publicExtension()
 	@finalExtension()
 	removeSensitiveData(oAttributes: any, sMetaPath: string) {
-		const aProperties = Object.keys(oAttributes);
-		if (aProperties.length) {
-			delete oAttributes["@odata.context"];
-			delete oAttributes["@odata.metadataEtag"];
-			delete oAttributes["SAP__Messages"];
-			for (let j = 0; j < aProperties.length; j++) {
-				if (oAttributes[aProperties[j]] && typeof oAttributes[aProperties[j]] === "object") {
-					this.removeSensitiveData(oAttributes[aProperties[j]], `${sMetaPath}/${aProperties[j]}`);
-				}
-				const sProp = aProperties[j],
-					aPropertyAnnotations = this._oMetaModel.getObject(`${sMetaPath}/${sProp}@`);
-				if (aPropertyAnnotations) {
-					if (
-						aPropertyAnnotations["@com.sap.vocabularies.PersonalData.v1.IsPotentiallySensitive"] ||
-						aPropertyAnnotations["@com.sap.vocabularies.UI.v1.ExcludeFromNavigationContext"] ||
-						aPropertyAnnotations["@com.sap.vocabularies.Analytics.v1.Measure"]
-					) {
-						delete oAttributes[sProp];
-					} else if (aPropertyAnnotations["@com.sap.vocabularies.Common.v1.FieldControl"]) {
-						const oFieldControl = aPropertyAnnotations["@com.sap.vocabularies.Common.v1.FieldControl"];
-						if (oFieldControl["$EnumMember"] && oFieldControl["$EnumMember"].split("/")[1] === "Inapplicable") {
-							delete oAttributes[sProp];
-						} else if (oFieldControl["$Path"] && this._isFieldControlPathInapplicable(oFieldControl["$Path"], oAttributes)) {
+		if (oAttributes) {
+			const aProperties = Object.keys(oAttributes);
+			if (aProperties.length) {
+				delete oAttributes["@odata.context"];
+				delete oAttributes["@odata.metadataEtag"];
+				delete oAttributes["SAP__Messages"];
+				for (let j = 0; j < aProperties.length; j++) {
+					if (oAttributes[aProperties[j]] && typeof oAttributes[aProperties[j]] === "object") {
+						this.removeSensitiveData(oAttributes[aProperties[j]], `${sMetaPath}/${aProperties[j]}`);
+					}
+					const sProp = aProperties[j],
+						aPropertyAnnotations = this._oMetaModel.getObject(`${sMetaPath}/${sProp}@`);
+					if (aPropertyAnnotations) {
+						if (
+							aPropertyAnnotations["@com.sap.vocabularies.PersonalData.v1.IsPotentiallySensitive"] ||
+							aPropertyAnnotations["@com.sap.vocabularies.UI.v1.ExcludeFromNavigationContext"] ||
+							aPropertyAnnotations["@com.sap.vocabularies.Analytics.v1.Measure"]
+						) {
 							delete oAttributes[sProp];
+						} else if (aPropertyAnnotations["@com.sap.vocabularies.Common.v1.FieldControl"]) {
+							const oFieldControl = aPropertyAnnotations["@com.sap.vocabularies.Common.v1.FieldControl"];
+							if (oFieldControl["$EnumMember"] && oFieldControl["$EnumMember"].split("/")[1] === "Inapplicable") {
+								delete oAttributes[sProp];
+							} else if (
+								oFieldControl["$Path"] &&
+								this._isFieldControlPathInapplicable(oFieldControl["$Path"], oAttributes)
+							) {
+								delete oAttributes[sProp];
+							}
 						}
 					}
 				}
@@ -610,7 +615,7 @@ class InternalIntentBasedNavigation extends ControllerExtension {
 	}
 
 	/**
-	 * Check if Path based FieldControl Evaluates to inapplicable.
+	 * Check if path-based FieldControl evaluates to inapplicable.
 	 *
 	 * @param sFieldControlPath Field control path
 	 * @param oAttribute SemanticAttributes