@saptools/service-flow 0.1.24 → 0.1.26

package/dist/cli.js

@@ -12,7 +12,7 @@ import {
   parsePackageJson,
   parseServiceBindings,
   trace
-} from "./chunk-RXJNPONU.js";
+} from "./chunk-Q3J2QDNX.js";
 
 // src/cli.ts
 import { Command } from "commander";
@@ -188,7 +188,7 @@ function migrate(db) {
 // package.json
 var package_default = {
   name: "@saptools/service-flow",
-  version: "0.1.24",
+  version: "0.1.26",
   description: "Trace SAP CAP service-to-service flows across multi-repository workspaces with runtime-aware graph resolution",
   type: "module",
   publishConfig: {
@@ -704,6 +704,40 @@ function isObjectFunction(node) {
 var commonTerminalMembers = /* @__PURE__ */ new Set(["push", "includes", "find", "findIndex", "map", "filter", "reduce", "forEach", "some", "every", "toUpperCase", "toLowerCase", "trim", "split", "join", "get", "set", "has"]);
 var loggerMembers = /* @__PURE__ */ new Set(["trace", "debug", "info", "warn", "error", "fatal", "log"]);
 var globalObjects = /* @__PURE__ */ new Set(["JSON", "Object", "Array", "String", "Number", "Boolean", "Math", "Date", "Promise", "Reflect"]);
+var builtInConstructors = /* @__PURE__ */ new Set([
+  "Set",
+  "Map",
+  "WeakSet",
+  "WeakMap",
+  "Date",
+  "RegExp",
+  "URL",
+  "URLSearchParams",
+  "Error",
+  "EvalError",
+  "RangeError",
+  "ReferenceError",
+  "SyntaxError",
+  "TypeError",
+  "URIError",
+  "AggregateError",
+  "ArrayBuffer",
+  "SharedArrayBuffer",
+  "DataView",
+  "Int8Array",
+  "Uint8Array",
+  "Uint8ClampedArray",
+  "Int16Array",
+  "Uint16Array",
+  "Int32Array",
+  "Uint32Array",
+  "Float32Array",
+  "Float64Array",
+  "BigInt64Array",
+  "BigUint64Array",
+  "Promise",
+  "AbortController"
+]);
 var capDslRoots = /* @__PURE__ */ new Set(["SELECT", "INSERT", "UPSERT", "UPDATE", "DELETE"]);
 var requestHelpers = /* @__PURE__ */ new Set(["reject", "error", "info", "warn", "notify"]);
 var transportMembers = /* @__PURE__ */ new Set(["emit", "publish", "send", "on"]);
@@ -750,6 +784,25 @@ function argumentEvidence(args, source) {
     return { kind: "unsupported", expression: arg.getText(source) };
   });
 }
+function bindingLocalName(name, initializer) {
+  if (ts.isIdentifier(name)) return name.text;
+  if (initializer && ts.isIdentifier(initializer)) return initializer.text;
+  return void 0;
+}
+function parameterBindings(params) {
+  return params.flatMap((param, index) => {
+    if (ts.isIdentifier(param.name)) return [{ index, kind: "identifier", name: param.name.text }];
+    if (!ts.isObjectBindingPattern(param.name)) return [];
+    const properties = param.name.elements.flatMap((element) => {
+      if (element.dotDotDotToken || ts.isObjectBindingPattern(element.name) || ts.isArrayBindingPattern(element.name)) return [];
+      const property = element.propertyName ? nameOf(element.propertyName) : nameOf(element.name);
+      if (!property) return [];
+      const local = bindingLocalName(element.name, element.initializer);
+      return local ? [{ property, local }] : [];
+    });
+    return properties.length > 0 ? [{ index, kind: "object_pattern", properties }] : [];
+  });
+}
 async function parseExecutableSymbols(repoPath, filePath) {
   const text = await fs4.readFile(path4.join(repoPath, filePath), "utf8");
   const source = ts.createSourceFile(filePath, text, ts.ScriptTarget.Latest, true, filePath.endsWith(".ts") ? ts.ScriptKind.TS : ts.ScriptKind.JS);
@@ -760,6 +813,7 @@ async function parseExecutableSymbols(repoPath, filePath) {
   const exportNames = exportDeclarations(source);
   const objectExports = /* @__PURE__ */ new Set();
   const exportedClasses = /* @__PURE__ */ new Set();
+  const declaredClasses = /* @__PURE__ */ new Set();
   const proxyVariables = /* @__PURE__ */ new Map();
   const classInstances = /* @__PURE__ */ new Map();
   const addSymbol = (kind, localName, node, parentName, exportedName, evidence) => {
@@ -769,9 +823,11 @@ async function parseExecutableSymbols(repoPath, filePath) {
     const objectExported = parentName ? objectExports.has(parentRoot) : false;
     const classMemberExported = kind === "method" && parentName ? exportedClasses.has(parentRoot) && ts.isMethodDeclaration(node) && (ts.getCombinedModifierFlags(node) & ts.ModifierFlags.Static) !== 0 && isPublicClassMethod(node) : false;
     const effectiveExportedName = classMemberExported || objectExported ? qualifiedName : declaredExportName;
-    const params = isFunctionLike(node) ? node.parameters.map((param) => nameOf(param.name)).filter((name) => Boolean(name)) : void 0;
+    const bindings = isFunctionLike(node) ? parameterBindings(node.parameters) : void 0;
+    const params = bindings?.flatMap((binding) => binding.kind === "identifier" ? [binding.name] : []);
     const sourceEvidence = evidence ?? (classMemberExported ? { source: "exported_class_member", exportedClass: parentRoot, memberKind: (ts.getCombinedModifierFlags(node) & ts.ModifierFlags.Static) !== 0 ? "static_method" : "class_method", parameters: params } : declaredExportName ? { exportedName: declaredExportName, source: "export_declaration" } : objectExported ? { exportedName: qualifiedName, source: "exported_object_literal" } : void 0);
-    symbols.push({ kind, localName: kind === "object_method" ? qualifiedName : localName, exportedName: effectiveExportedName, qualifiedName, sourceFile, startLine: lineOf(source, node.getStart(source)), endLine: lineOf(source, node.getEnd()), startOffset: node.getStart(source), endOffset: node.getEnd(), exported: exported(node) || Boolean(effectiveExportedName), importExportEvidence: params && sourceEvidence ? { ...sourceEvidence, parameters: params } : sourceEvidence });
+    const parameterEvidence = bindings && bindings.length > 0 ? { parameters: params, parameterBindings: bindings } : {};
+    symbols.push({ kind, localName: kind === "object_method" ? qualifiedName : localName, exportedName: effectiveExportedName, qualifiedName, sourceFile, startLine: lineOf(source, node.getStart(source)), endLine: lineOf(source, node.getEnd()), startOffset: node.getStart(source), endOffset: node.getEnd(), exported: exported(node) || Boolean(effectiveExportedName), importExportEvidence: sourceEvidence ? { ...sourceEvidence, ...parameterEvidence } : bindings && bindings.length > 0 ? parameterEvidence : void 0 });
   };
   const addAliasSymbol = (objectName, propertyName, node, targetImportSource) => {
     symbols.push({ kind: "object_alias", localName: propertyName, exportedName: propertyName, qualifiedName: `${objectName}.${propertyName}`, sourceFile, startLine: lineOf(source, node.getStart(source)), endLine: lineOf(source, node.getEnd()), startOffset: node.getStart(source), endOffset: node.getEnd(), exported: true, importExportEvidence: { source: "exported_object_shorthand", objectName, propertyName, targetImportSource } });
@@ -799,6 +855,7 @@ async function parseExecutableSymbols(repoPath, filePath) {
   visitImports(source);
   const visitSymbols = (node, parentClass) => {
     if (ts.isClassDeclaration(node) && node.name) {
+      declaredClasses.add(node.name.text);
       if (exported(node) || exportNames.has(node.name.text)) exportedClasses.add(node.name.text);
       for (const member of node.members) visitSymbols(member, node.name.text);
       return;
@@ -872,11 +929,17 @@ async function parseExecutableSymbols(repoPath, filePath) {
     ts.forEachChild(node, visitProxyVariables);
   };
   visitProxyVariables(source);
+  const rememberClassInstance = (variableName, className, propertyName) => {
+    const importSource = imports.get(className);
+    if (!builtInConstructors.has(className) && (importSource && isRelativeImport(importSource) || declaredClasses.has(className))) classInstances.set(variableName, { className, importSource, propertyName });
+  };
   const visitClassInstances = (node) => {
     if (ts.isVariableDeclaration(node) && ts.isIdentifier(node.name) && node.initializer && ts.isNewExpression(node.initializer) && ts.isIdentifier(node.initializer.expression)) {
-      const className = node.initializer.expression.text;
-      const importSource = imports.get(className);
-      if (!importSource || isRelativeImport(importSource)) classInstances.set(node.name.text, { className, importSource });
+      rememberClassInstance(node.name.text, node.initializer.expression.text);
+    }
+    if (ts.isPropertyDeclaration(node) && node.initializer && ts.isNewExpression(node.initializer) && ts.isIdentifier(node.initializer.expression)) {
+      const propertyName = nameOf(node.name);
+      if (propertyName) rememberClassInstance(`this.${propertyName}`, node.initializer.expression.text, propertyName);
     }
     ts.forEachChild(node, visitClassInstances);
   };
@@ -889,11 +952,12 @@ async function parseExecutableSymbols(repoPath, filePath) {
       if (caller) {
         const callee = callName(node.expression);
         const proxy = callee.local ? proxyVariables.get(callee.local) : void 0;
-        const instance = callee.local ? classInstances.get(callee.local) : void 0;
+        const instance = (callee.local ? classInstances.get(callee.local) : void 0) ?? (callee.receiver ? classInstances.get(callee.receiver) : void 0);
         const importSource = instance?.importSource ?? proxy?.importSource ?? (callee.local ? imports.get(callee.local) : void 0) ?? (callee.member && callee.local ? imports.get(callee.local) : void 0);
-        const targetName = instance && callee.member ? `${instance.className}.${callee.member}` : proxy && callee.member ? callee.member : callee.expression.startsWith("this.") ? callee.member : callee.member && callee.local ? `${callee.local}.${callee.member}` : callee.local;
+        const directThisMethod = callee.receiver === "this";
+        const targetName = instance && callee.member ? `${instance.className}.${callee.member}` : proxy && callee.member ? callee.member : directThisMethod ? callee.member : callee.member && callee.local ? `${callee.local}.${callee.member}` : callee.local;
         const className = caller.qualifiedName.includes(".") ? caller.qualifiedName.split(".")[0] : void 0;
-        const thisTarget = className && callee.member ? `${className}.${callee.member}` : void 0;
+        const thisTarget = directThisMethod && className && callee.member ? `${className}.${callee.member}` : void 0;
         const loggerLike = callee.receiver?.endsWith(".logger") || callee.local === "logger" || (callee.expression.startsWith("this.logger.") && callee.member ? loggerMembers.has(callee.member) : false);
         const terminalMember = callee.member ? commonTerminalMembers.has(callee.member) || loggerMembers.has(callee.member) : false;
         const provenLocal = Boolean(targetName) && localCallables.has(String(targetName));
@@ -904,7 +968,7 @@ async function parseExecutableSymbols(repoPath, filePath) {
         const ignored = loggerLike || terminalMember || importedFromPackage || ignoredFrameworkCall(callee);
         const resolvedTarget = provenThisMethod ? thisTarget : targetName;
         const keep = Boolean(resolvedTarget) && !ignored && (provenLocal || provenThisMethod || provenRelativeImport || provenClassInstance);
-        if (keep) calls.push({ callerQualifiedName: caller.qualifiedName, calleeExpression: callee.expression, calleeLocalName: resolvedTarget, receiverLocalName: callee.member ? callee.local : void 0, importSource, sourceFile, sourceLine: line, evidence: { relation: instance ? "class_instance_method" : proxy ? "relative_import_proxy_member" : importSource ? "relative_import" : provenThisMethod ? "indexed_this_method" : "indexed_local_symbol", caller: caller.qualifiedName, targetName: resolvedTarget, instanceVariable: instance ? callee.local : void 0, className: instance?.className, methodName: instance ? callee.member : void 0, classImportSource: instance?.importSource, callArguments: argumentEvidence(node.arguments, source), proxyVariableName: proxy?.variableName, factory: proxy?.factory, factoryExpression: proxy?.factory, factoryImportSource: proxy?.importSource, candidateStrategy: instance ? instance.importSource ? "relative_import_class_instance_method" : "same_file_class_instance_method" : proxy ? "proxy_member_exact_export_or_unique_member" : void 0 } });
+        if (keep) calls.push({ callerQualifiedName: caller.qualifiedName, calleeExpression: callee.expression, calleeLocalName: resolvedTarget, receiverLocalName: callee.member ? callee.local ?? callee.receiver : void 0, importSource, sourceFile, sourceLine: line, evidence: { relation: instance ? "class_instance_method" : proxy ? "relative_import_proxy_member" : importSource ? "relative_import" : provenThisMethod ? "indexed_this_method" : "indexed_local_symbol", caller: caller.qualifiedName, targetName: resolvedTarget, instanceVariable: instance ? instance.propertyName ?? callee.local : void 0, className: instance?.className, methodName: instance ? callee.member : void 0, classImportSource: instance?.importSource, callArguments: argumentEvidence(node.arguments, source), proxyVariableName: proxy?.variableName, factory: proxy?.factory, factoryExpression: proxy?.factory, factoryImportSource: proxy?.importSource, candidateStrategy: instance ? instance.importSource ? "relative_import_class_instance_method" : "same_file_class_instance_method" : proxy ? "proxy_member_exact_export_or_unique_member" : void 0 } });
       }
     }
     ts.forEachChild(node, visitCalls);
@@ -1221,12 +1285,18 @@ function parserQualityDiagnostics(db, strict) {
   const aliasQuality = identityAliasBindingQuality(db);
   const noBindingQuality = remoteActionNoBindingQuality(db);
   const contextualQuality = contextualImplementationQuality(db);
+  const classInstanceQuality = classInstanceNoiseQuality(db);
+  const bindingPropagationQuality = contextualBindingPropagationQuality(db);
   const wrapperQuality = wrapperPathPropagationQuality(db);
+  const nestedThisQuality = nestedThisReceiverQuality(db);
   return [
     aliasQuality,
     noBindingQuality,
     contextualQuality,
+    classInstanceQuality,
+    bindingPropagationQuality,
     wrapperQuality,
+    nestedThisQuality,
     remoteQuery,
     invocation,
     remoteAction,
@@ -1253,7 +1323,16 @@ function remoteActionNoBindingQuality(db) {
     WHEN c.unresolved_reason='dynamic_operation_path_identifier' THEN 'dynamic_path_identifier'
     WHEN json_extract(c.evidence_json,'$.classifier')='higher_order_wrapper_literal_path' OR json_extract(c.evidence_json,'$.operationPathExpression') IS NOT NULL THEN 'likely_higher_order_wrapper_path_needed'
     WHEN json_extract(c.evidence_json,'$.receiver') LIKE '%.%' THEN 'likely_parameter_context_needed'
-    WHEN EXISTS (SELECT 1 FROM symbol_calls sc WHERE sc.status='resolved' AND json_extract(sc.evidence_json,'$.relation')='class_instance_method' AND sc.source_file=c.source_file) THEN 'likely_instance_method_context_needed'
+    WHEN EXISTS (
+      SELECT 1 FROM symbol_calls sc
+      JOIN symbols caller ON caller.id=sc.caller_symbol_id
+      JOIN symbols callee ON callee.id=sc.callee_symbol_id
+      WHERE sc.status='resolved'
+        AND sc.source_file=c.source_file
+        AND caller.id=c.source_symbol_id
+        AND json_extract(sc.evidence_json,'$.relation')='class_instance_method'
+        AND (callee.evidence_json IS NULL OR json_extract(callee.evidence_json,'$.parameterBindings') IS NULL)
+    ) THEN 'likely_instance_method_parameter_metadata_needed'
     WHEN EXISTS (SELECT 1 FROM service_bindings b WHERE b.repo_id=c.repo_id AND b.source_file=c.source_file AND ABS(b.source_line-c.source_line) < 50) THEN 'likely_missing_assignment_binding'
     WHEN e.status='unresolved' AND COALESCE(e.unresolved_reason,'') LIKE '%No indexed target operation%' THEN 'no_indexed_target_operation'
     WHEN c.operation_path_expr IS NOT NULL AND (c.operation_path_expr LIKE '/%' OR c.operation_path_expr NOT LIKE '%/%') THEN 'operation_path_only_no_static_service_signal'
@@ -1268,6 +1347,46 @@ function remoteActionNoBindingQuality(db) {
   const total = rows.reduce((sum, row) => sum + Number(row.count ?? 0), 0);
   return { severity: total > 0 ? "warning" : "info", code: "strict_remote_action_no_binding_quality", message: "Remote actions with operation paths but no service binding id", total, breakdown: rows, examples };
 }
+function classInstanceNoiseQuality(db) {
+  const builtIns = ["Set", "Map", "WeakSet", "WeakMap", "Date", "RegExp", "URL", "URLSearchParams", "Error", "EvalError", "RangeError", "ReferenceError", "SyntaxError", "TypeError", "URIError", "AggregateError", "ArrayBuffer", "SharedArrayBuffer", "DataView", "Int8Array", "Uint8Array", "Uint8ClampedArray", "Int16Array", "Uint16Array", "Int32Array", "Uint32Array", "Float32Array", "Float64Array", "BigInt64Array", "BigUint64Array", "Promise", "AbortController"];
+  const placeholders = builtIns.map(() => "?").join(",");
+  const aggregate = db.prepare(`SELECT COUNT(*) total,
+      SUM(CASE WHEN status='unresolved' THEN 1 ELSE 0 END) unresolved,
+      SUM(CASE WHEN status='unresolved' AND json_extract(evidence_json,'$.className') IN (${placeholders}) THEN 1 ELSE 0 END) unresolvedBuiltIn
+    FROM symbol_calls WHERE json_extract(evidence_json,'$.relation')='class_instance_method'`).get(...builtIns);
+  const byConstructor = db.prepare(`SELECT json_extract(evidence_json,'$.className') constructorName,COUNT(*) unresolvedCount
+    FROM symbol_calls WHERE status='unresolved' AND json_extract(evidence_json,'$.relation')='class_instance_method'
+    GROUP BY constructorName ORDER BY unresolvedCount DESC,constructorName LIMIT 10`).all();
+  return { severity: Number(aggregate.unresolvedBuiltIn ?? 0) > 0 ? "warning" : "info", code: "strict_class_instance_noise_quality", message: "Class-instance symbol-call aggregate with built-in constructor guard", totalClassInstanceCalls: Number(aggregate.total ?? 0), unresolvedClassInstanceCalls: Number(aggregate.unresolved ?? 0), unresolvedBuiltInClassInstanceCalls: Number(aggregate.unresolvedBuiltIn ?? 0), unresolvedByConstructor: byConstructor };
+}
+function contextualBindingPropagationQuality(db) {
+  const serviceClientCalls = db.prepare(`SELECT COUNT(*) count FROM symbol_calls sc
+    WHERE json_extract(sc.evidence_json,'$.callArguments[0].kind') IN ('identifier','object_literal')`).get();
+  const missingMetadata = db.prepare(`SELECT COUNT(*) count FROM symbol_calls sc JOIN symbols s ON s.id=sc.callee_symbol_id
+    WHERE sc.status='resolved' AND json_extract(sc.evidence_json,'$.callArguments[0].kind') IN ('identifier','object_literal')
+      AND (s.evidence_json IS NULL OR json_extract(s.evidence_json,'$.parameterBindings') IS NULL)`).get();
+  const destructuredUnmapped = db.prepare(`SELECT COUNT(*) count FROM symbol_calls sc JOIN symbols s ON s.id=sc.callee_symbol_id
+    WHERE json_extract(sc.evidence_json,'$.callArguments[0].kind')='object_literal'
+      AND json_extract(s.evidence_json,'$.parameterBindings[0].kind')='object_pattern'
+      AND json_array_length(json_extract(sc.evidence_json,'$.callArguments[0].properties')) > json_array_length(json_extract(s.evidence_json,'$.parameterBindings[0].properties'))`).get();
+  const opportunities = db.prepare(`SELECT c.source_file sourceFile,c.source_line sourceLine,json_extract(c.evidence_json,'$.receiver') receiverName,c.operation_path_expr operationPath,'trace_time_contextual_binding_candidate' opportunity
+    FROM outbound_calls c LEFT JOIN graph_edges e ON e.from_kind='call' AND e.from_id=CAST(c.id AS TEXT)
+    WHERE c.call_type='remote_action' AND c.service_binding_id IS NULL AND json_extract(c.evidence_json,'$.receiver') IS NOT NULL
+      AND (e.status IS NULL OR e.status!='resolved')
+      AND EXISTS (SELECT 1 FROM symbol_calls sc WHERE sc.status='resolved' AND sc.source_file=c.source_file)
+    ORDER BY c.source_file,c.source_line LIMIT 8`).all();
+  return { severity: Number(missingMetadata.count ?? 0) + Number(destructuredUnmapped.count ?? 0) + opportunities.length > 0 ? "warning" : "info", code: "strict_contextual_binding_propagation_quality", message: "Contextual service-client propagation opportunities for trace-time helper resolution", localSymbolCallsWithServiceClientArguments: Number(serviceClientCalls.count ?? 0), calleeSymbolsMissingParameterMetadata: Number(missingMetadata.count ?? 0), destructuredObjectParametersPossiblyUnmapped: Number(destructuredUnmapped.count ?? 0), traceTimeContextualOpportunities: opportunities.length, examples: opportunities };
+}
+function nestedThisReceiverQuality(db) {
+  const aggregate = db.prepare(`SELECT COUNT(*) total,
+      SUM(CASE WHEN json_extract(evidence_json,'$.relation')='indexed_this_method' THEN 1 ELSE 0 END) resolvedToCurrentClass,
+      SUM(CASE WHEN json_extract(evidence_json,'$.relation')='class_instance_method' THEN 1 ELSE 0 END) withExplicitHelperInstanceEvidence
+    FROM symbol_calls WHERE callee_expression LIKE 'this.%.%'`).get();
+  const examples = db.prepare(`SELECT source_file sourceFile,source_line sourceLine,callee_expression calleeExpression,json_extract(evidence_json,'$.relation') relation,json_extract(evidence_json,'$.targetName') targetName
+    FROM symbol_calls WHERE callee_expression LIKE 'this.%.%' AND json_extract(evidence_json,'$.relation')='indexed_this_method'
+    ORDER BY source_file,source_line LIMIT 8`).all();
+  return { severity: Number(aggregate.resolvedToCurrentClass ?? 0) > 0 ? "warning" : "info", code: "strict_nested_this_receiver_quality", message: "Nested this receiver symbol-call aggregate", nestedThisReceiverCallsConsidered: Number(aggregate.total ?? 0), nestedThisResolvedToCurrentClass: Number(aggregate.resolvedToCurrentClass ?? 0), nestedThisWithExplicitHelperInstanceEvidence: Number(aggregate.withExplicitHelperInstanceEvidence ?? 0), warningExamples: examples };
+}
 function contextualImplementationQuality(db) {
   const rows = db.prepare(`SELECT status,COALESCE(unresolved_reason,status) reason,COUNT(*) count
     FROM graph_edges WHERE edge_type='OPERATION_IMPLEMENTED_BY_HANDLER' AND status IN ('ambiguous','unresolved') GROUP BY status,reason ORDER BY status,count DESC,reason`).all();