@saptools/service-flow 0.1.24 → 0.1.26

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 0.1.26
+
+- Resolve helper-internal remote sends contextually in trace output when service clients are passed through positional arguments or one-level destructured object parameters.
+- Add auditable contextual binding evidence for propagated helper client receivers, including caller argument, caller object property, callee parameter, callee receiver, and propagation source.
+- Keep nested `this.<property>.<method>()` symbol-call resolution conservative unless explicit same-file or relative-import helper instance evidence exists.
+- Update strict doctor diagnostics for trace-time contextual propagation opportunities and nested `this` receiver quality signals.
+
+## 0.1.25
+
+- Make class-instance symbol-call indexing conservative so only same-file and relatively imported helper classes are traced, while built-in collection, date, URL, error, typed-array, promise, and abort-controller instances are ignored.
+- Persist identifier and one-level destructured object parameter metadata for executable symbols, including class methods, so contextual service-client binding propagation can map helper arguments to callee receiver names.
+- Propagate contextual service bindings through positional helper arguments and destructured object helper parameters with auditable caller and callee evidence.
+- Refine unresolved operation diagnostics when indexed candidates exist but service context is absent or the resolution score is below threshold.
+
 ## 0.1.24
 
 - Add conservative class instance method symbol-call resolution for same-file and relatively imported helper classes, with auditable class-instance evidence.

package/dist/{chunk-RXJNPONU.js → chunk-Q3J2QDNX.js}

@@ -1767,13 +1767,21 @@ function insertCallEdge(db, workspaceId, call, vars, generation) {
   }
   const edgeType = callType === "local_db_query" ? "HANDLER_RUNS_DB_QUERY" : callType === "external_http" ? "HANDLER_CALLS_EXTERNAL_HTTP" : callType === "async_emit" ? "HANDLER_EMITS_EVENT" : callType === "async_subscribe" ? "EVENT_CONSUMED_BY_HANDLER" : resolution.status === "dynamic" ? "DYNAMIC_EDGE_CANDIDATE" : "UNRESOLVED_EDGE";
   const status = edgeType === "DYNAMIC_EDGE_CANDIDATE" ? "dynamic" : resolution.status === "ambiguous" ? "ambiguous" : edgeType === "UNRESOLVED_EDGE" ? "unresolved" : "terminal";
-  const unresolvedReason = status === "terminal" ? null : String(call.unresolved_reason ?? (resolution.status === "ambiguous" ? "Ambiguous operation candidates require a strong service signal" : resolution.status === "dynamic" ? `Dynamic target requires runtime variable overrides: ${(resolution.reasons.length ? resolution.reasons : ["missing runtime variables"]).join(", ")}` : "No indexed target operation matched"));
+  const unresolvedReason = status === "terminal" ? null : String(call.unresolved_reason ?? unresolvedOperationReason(resolution));
   const targetKind = callType === "local_db_query" ? "db_entity" : callType.startsWith("async_") ? "event" : "external";
   const targetId = callType === "local_db_query" ? String(call.query_entity ?? "unknown") : callType === "remote_action" ? op ? `Remote action: ${op}` : call.unresolved_reason === "dynamic_operation_path_identifier" ? "Remote action: dynamic path" : "Remote action: unknown path" : String(call.event_name_expr ?? op ?? call.id);
   const graphLevelDynamic = edgeType === "DYNAMIC_EDGE_CANDIDATE" && resolution.status === "dynamic";
   db.prepare("INSERT INTO graph_edges(workspace_id,edge_type,status,from_kind,from_id,to_kind,to_id,confidence,evidence_json,is_dynamic,unresolved_reason,generation) VALUES(?,?,?,?,?,?,?,?,?,?,?,?)").run(workspaceId, edgeType, status, "call", String(call.id), targetKind, targetId, Number(call.confidence ?? 0.2), JSON.stringify(evidence), graphLevelDynamic ? 1 : 0, unresolvedReason, generation);
   return { status, callType };
 }
+function unresolvedOperationReason(resolution) {
+  if (resolution.status === "dynamic") return `Dynamic target requires runtime variable overrides: ${(resolution.reasons.length ? resolution.reasons : ["missing runtime variables"]).join(", ")}`;
+  if (resolution.candidates.length === 0) return "No indexed target operation matched";
+  if (resolution.reasons.includes("operation_path_only_has_no_strong_target_signal")) return "Operation candidates found but no strong service signal is available";
+  if (resolution.reasons.includes("candidate_score_below_resolution_threshold")) return "Operation candidates found but resolution score is below threshold";
+  if (resolution.status === "ambiguous") return "Ambiguous operation candidates require a strong service signal";
+  return "Operation candidates found but resolution could not select a target";
+}
 function parseJson(value) {
   if (!value) return void 0;
   try {
@@ -2269,6 +2277,21 @@ function knownBindingsForCalls(db, calls) {
   }
   return map;
 }
+function knownBindingsForScope(db, repoId, symbolIds, files) {
+  const map = /* @__PURE__ */ new Map();
+  if (repoId === void 0) return map;
+  const rows2 = db.prepare("SELECT id,variable_name variableName,alias,alias_expr aliasExpr,destination_expr destinationExpr,service_path_expr servicePathExpr,source_file sourceFile,source_line sourceLine FROM service_bindings WHERE repo_id=?").all(repoId);
+  for (const row of rows2) {
+    if (!row.variableName) continue;
+    if (files && !files.has(String(row.sourceFile))) continue;
+    if (symbolIds && symbolIds.size > 0) {
+      const owner = db.prepare("SELECT id FROM symbols WHERE id IN (" + [...symbolIds].map(() => "?").join(",") + ") AND source_file=? AND start_line<=? AND end_line>=? LIMIT 1").get(...symbolIds, row.sourceFile, row.sourceLine, row.sourceLine);
+      if (!owner) continue;
+    }
+    map.set(row.variableName, { ...row, bindingId: Number(row.id), source: "local_service_binding", calleeReceiver: row.variableName });
+  }
+  return map;
+}
 function contextForSymbolCall(db, symbolCall, callerBindings) {
   const next = /* @__PURE__ */ new Map();
   if (callerBindings.size === 0) return next;
@@ -2276,19 +2299,23 @@ function contextForSymbolCall(db, symbolCall, callerBindings) {
   const callee = db.prepare("SELECT evidence_json evidenceJson FROM symbols WHERE id=?").get(symbolCall.callee_symbol_id);
   const calleeEvidence = parseEvidence(callee?.evidenceJson);
   const params = Array.isArray(calleeEvidence.parameters) ? calleeEvidence.parameters.filter((item) => typeof item === "string") : [];
+  const parameterBindings = Array.isArray(calleeEvidence.parameterBindings) ? calleeEvidence.parameterBindings.filter((item) => Boolean(item && typeof item === "object" && !Array.isArray(item))) : [];
   const args = Array.isArray(callEvidence2.callArguments) ? callEvidence2.callArguments : [];
   args.forEach((arg, index) => {
-    const param = params[index];
-    if (!param) return;
+    const paramBinding = parameterBindings.find((binding) => binding.index === index);
+    const param = paramBinding?.kind === "identifier" && typeof paramBinding.name === "string" ? paramBinding.name : params[index];
     if (arg.kind === "identifier" && typeof arg.name === "string") {
       const binding = callerBindings.get(arg.name);
-      if (binding) next.set(param, { ...binding, source: "local_symbol_argument", callerArgument: arg.name, calleeParameter: param, calleeReceiver: param });
+      if (binding && param) next.set(param, { ...binding, source: "local_symbol_argument", callerArgument: arg.name, calleeParameter: param, calleeReceiver: param });
     }
     if (arg.kind === "object_literal" && Array.isArray(arg.properties)) {
       for (const prop of arg.properties) {
         if (typeof prop.property !== "string" || typeof prop.argument !== "string") continue;
         const binding = callerBindings.get(prop.argument);
-        if (binding) next.set(`${param}.${prop.property}`, { ...binding, source: "local_symbol_object_argument", callerProperty: prop.property, callerArgument: prop.argument, calleeParameter: param, calleeReceiver: `${param}.${prop.property}` });
+        if (!binding) continue;
+        const destructured = paramBinding?.kind === "object_pattern" && Array.isArray(paramBinding.properties) ? paramBinding.properties.find((item) => item.property === prop.property && typeof item.local === "string") : void 0;
+        if (destructured && typeof destructured.local === "string") next.set(destructured.local, { ...binding, source: "local_symbol_destructured_object_argument", callerProperty: prop.property, callerArgument: prop.argument, calleeParameter: String(index), calleeReceiver: destructured.local });
+        else if (param) next.set(`${param}.${prop.property}`, { ...binding, source: "local_symbol_object_argument", callerProperty: prop.property, callerArgument: prop.argument, calleeParameter: param, calleeReceiver: `${param}.${prop.property}` });
       }
     }
   });
@@ -2361,7 +2388,8 @@ function trace(db, start, options) {
   while (queue.length > 0) {
     const current = queue.shift();
     if (!current || current.depth > maxDepth) continue;
-    const key = `${current.repoId ?? "*"}:${[...current.symbolIds ?? /* @__PURE__ */ new Set(["*"])].sort().join(",")}:${[...current.files ?? /* @__PURE__ */ new Set(["*"])].sort().join(",")}`;
+    const contextKey = [...(current.context ?? /* @__PURE__ */ new Map()).keys()].sort().join(",");
+    const key = `${current.repoId ?? "*"}:${[...current.symbolIds ?? /* @__PURE__ */ new Set(["*"])].sort().join(",")}:${[...current.files ?? /* @__PURE__ */ new Set(["*"])].sort().join(",")}:${contextKey}`;
     if (seenScopes.has(key)) continue;
     seenScopes.add(key);
     const calls = db.prepare(
@@ -2370,7 +2398,7 @@ function trace(db, start, options) {
     const filtered = calls.filter(
       (c) => (!current.symbolIds || current.symbolIds.has(Number(c.source_symbol_id))) && (!current.files || current.files.has(String(c.source_file))) && includeCall(String(c.call_type), options)
     );
-    const callerBindings = new Map([...current.context ?? /* @__PURE__ */ new Map(), ...knownBindingsForCalls(db, filtered)]);
+    const callerBindings = new Map([...current.context ?? /* @__PURE__ */ new Map(), ...knownBindingsForScope(db, current.repoId, current.symbolIds, current.files), ...knownBindingsForCalls(db, filtered)]);
     if (current.symbolIds && current.symbolIds.size > 0 && current.depth < maxDepth) {
       const symbolRows = db.prepare(`SELECT sc.*,s.repo_id calleeRepoId,s.source_file calleeFile FROM symbol_calls sc LEFT JOIN symbols s ON s.id=sc.callee_symbol_id WHERE sc.caller_symbol_id IN (${[...current.symbolIds].map(() => "?").join(",")}) ORDER BY sc.source_file,sc.source_line`).all(...current.symbolIds);
       for (const symbolCall of symbolRows) {
@@ -2401,7 +2429,7 @@ function trace(db, start, options) {
         line: call.source_line,
         callType: call.call_type
       });
-      const contextual = contextualRuntimeResolution(db, call, (current.context ?? /* @__PURE__ */ new Map()).get(receiverFromEvidence(call.evidence_json) ?? ""), workspaceIdForCall(db, String(call.id)));
+      const contextual = contextualRuntimeResolution(db, call, callerBindings.get(receiverFromEvidence(call.evidence_json) ?? ""), workspaceIdForCall(db, String(call.id)));
       const graphRows = contextual.row ? [contextual.row] : graph.get(Number(call.id)) ?? [];
       for (const row of graphRows) {
         if (seenEdges.has(Number(row.id))) continue;
@@ -2503,4 +2531,4 @@ export {
   linkWorkspace,
   trace
 };
-//# sourceMappingURL=chunk-RXJNPONU.js.map
+//# sourceMappingURL=chunk-Q3J2QDNX.js.map