@sap/open.fe 1.99.0 → 1.100.0

package/packages/sap.fe.core/test/sap/fe/core/jest/converters/Table.spec.ts

@@ -8,7 +8,8 @@ import {
 	isFilteringCaseSensitive,
 	AnnotationTableColumn,
 	getP13nMode,
-	getTableAnnotationConfiguration
+	getTableAnnotationConfiguration,
+	getRowStatusVisibility
 } from "sap/fe/core/converters/controls/Common/Table";
 
 import { TableHelper } from "sap/fe/macros/table";
@@ -23,7 +24,8 @@ import {
 	TableManifestConfiguration,
 	ChartManifestConfiguration,
 	TableManifestSettingsConfiguration,
-	TemplateType
+	TemplateType,
+	Importance
 } from "sap/fe/core/converters/ManifestSettings";
 import { ConverterOutput, LineItem, UIAnnotationTerms } from "@sap-ux/vocabularies-types";
 import { bindingExpression, Expression, constant } from "sap/fe/core/helpers/BindingExpression";
@@ -1970,22 +1972,31 @@ describe("Table Converter - #getTableColumns", function() {
 			converterContext,
 			{}
 		);
-		expect(columns.length).toBe(8);
+		expect(columns.length).toBe(12);
 		expect(columns[0].key).toBe("DataField::IsActiveEntity");
 		expect(columns[3].key).toBe("DataField::DraftAdministrativeData_DraftUUID");
 		expect(columns[4].key).toBe("DataField::ID");
 		expect(columns[4].width).toBe(undefined);
-		expect(columns[5].key).toBe("DataField::name");
-		expect(columns[7].key).toBe("Property::name");
+		expect(columns[5].key).toBe("DataField::ID2");
+		expect(columns[6].key).toBe("DataField::name");
+		expect(columns[7].key).toBe("DataFieldForAnnotation::FieldGroup::fieldGroupWithSemanticKey");
+		expect(columns[8].key).toBe("DataFieldForAnnotation::FieldGroup::fieldGroupWithoutSemanticKey");
+		expect(columns[9].key).toBe("Property::ID");
+		expect(columns[10].key).toBe("Property::ID2");
+		expect(columns[11].key).toBe("Property::name");
 	});
 	it(
-		"can also merge column with the ones defined in the manifest",
+		"can merge columns and overwrite the width property",
 		{
 			"references": [
 				{
 					"type": "BCP",
 					"ID": "2180071284"
 				},
+				{
+					"type": "BCP",
+					"ID": "2180405180"
+				},
 				{
 					"type": "JIRA",
 					"ID": "FIORITECHP1-16808"
@@ -2045,13 +2056,31 @@ describe("Table Converter - #getTableColumns", function() {
 					}
 				}
 			});
+			converterContext.getAnnotationsByTerm = jest.fn(() => [
+				[
+					{
+						"type": "PropertyPath",
+						"value": "ID",
+						"fullyQualifiedName": "TestEntity@com.sap.vocabularies.Common.v1.SemanticKey/0",
+						"$target": {
+							"_type": "Property",
+							"name": "ID",
+							"fullyQualifiedName": "TestEntity/ID",
+							"type": "Edm.Guid",
+							"nullable": false,
+							"isKey": true,
+							"annotations": {}
+						}
+					}
+				]
+			]);
 			const columns = getTableColumns(
 				(converterContext.getEntityType().annotations?.UI as any)["LineItem"] as LineItem,
 				"@" + UIAnnotationTerms.LineItem,
 				converterContext,
 				{}
 			);
-			expect(columns.length).toBe(12);
+			expect(columns.length).toBe(16);
 			expect(columns[0].key).toBe("DataField::IsActiveEntity");
 			expect(columns[3].key).toBe("DataField::DraftAdministrativeData_DraftUUID");
 			expect(columns[4].key).toBe("DataField::ID");
@@ -2060,7 +2089,115 @@ describe("Table Converter - #getTableColumns", function() {
 			expect(columns[6].key).toBe("CustomColumnButton");
 			expect(columns[7].key).toBe("CustomColumnSoldToParty");
 			expect(columns[8].key).toBe("CustomColumnFixedText");
-			expect(columns[11].key).toBe("Property::name");
+			expect(columns[15].key).toBe("Property::name");
+			expect(columns[4].formatOptions).toStrictEqual({
+				textLinesEdit: 4,
+				hasDraftIndicator: true,
+				semantickeys: ["ID"],
+				objectStatusTextVisibility:
+					"{parts: [{value: 'getErrorStatusTextVisibilityFormatter'}, {path: 'internal>semanticKeyHasDraftIndicator', targetType: 'any'}, {path: 'internal>filteredMessages', targetType: 'any'}], formatter: 'sap.fe.core.formatters.TableFormatter'}"
+			});
+		}
+	);
+
+	it(
+		"can get the importance property correctly from annotations",
+		{
+			"references": [
+				{
+					"type": "JIRA",
+					"ID": "FIORITECHP1-22806"
+				}
+			]
+		},
+		function() {
+			const converterContext = getConverterContextForTest(convertedTypes, {
+				converterType: TemplateType.ObjectPage,
+				entitySet: "TestEntity"
+			});
+			const columns = getTableColumns(
+				(converterContext.getEntityType().annotations?.UI as any)["LineItem"] as LineItem,
+				"@" + UIAnnotationTerms.LineItem,
+				converterContext,
+				{}
+			);
+
+			expect(columns[4].key).toBe("DataField::ID");
+			expect(columns[4].importance).toBe("High");
+
+			expect(columns[5].key).toBe("DataField::ID2");
+			expect(columns[5].importance).toBe("Medium");
+
+			expect(columns[6].key).toBe("DataField::name");
+			expect(columns[6].importance).toBe("None");
+
+			expect(columns[7].key).toBe("DataFieldForAnnotation::FieldGroup::fieldGroupWithSemanticKey");
+			expect(columns[7].importance).toBe("High");
+
+			expect(columns[8].key).toBe("DataFieldForAnnotation::FieldGroup::fieldGroupWithoutSemanticKey");
+			expect(columns[8].importance).toBe("None");
+		}
+	);
+
+	it(
+		"can merge columns and overwrite the importance property",
+		{
+			"references": [
+				{
+					"type": "JIRA",
+					"ID": "FIORITECHP1-22806"
+				}
+			]
+		},
+		function() {
+			const converterContext = getConverterContextForTest(convertedTypes, {
+				converterType: TemplateType.ObjectPage,
+				entitySet: "TestEntity",
+				controlConfiguration: {
+					"@com.sap.vocabularies.UI.v1.LineItem": {
+						columns: {
+							"CustomColumnRating": {
+								"header": "Custom Rating",
+								"importance": Importance.Low,
+								"template": "SalesOrder.custom.CustomColumnRating"
+							},
+							"DataField::ID2": {
+								"importance": Importance.Low
+							},
+							"DataField::name": {
+								"importance": Importance.Low
+							},
+							"DataFieldForAnnotation::FieldGroup::fieldGroupWithoutSemanticKey": {
+								"importance": Importance.Low
+							}
+						}
+					}
+				}
+			});
+			const columns = getTableColumns(
+				(converterContext.getEntityType().annotations?.UI as any)["LineItem"] as LineItem,
+				"@" + UIAnnotationTerms.LineItem,
+				converterContext,
+				{}
+			);
+
+			expect(columns[4].key).toBe("DataField::ID");
+			expect(columns[4].importance).toBe("High");
+
+			expect(columns[5].key).toBe("DataField::ID2");
+			expect(columns[5].importance).toBe("Low");
+
+			expect(columns[6].key).toBe("DataField::name");
+			expect(columns[6].importance).toBe("Low");
+
+			expect(columns[7].key).toBe("DataFieldForAnnotation::FieldGroup::fieldGroupWithSemanticKey");
+			expect(columns[7].importance).toBe("High");
+
+			expect(columns[8].key).toBe("DataFieldForAnnotation::FieldGroup::fieldGroupWithoutSemanticKey");
+			expect(columns[8].importance).toBe("Low");
+
+			expect(columns[12].key).toBe("CustomColumnRating");
+			expect(columns[12].importance).toBe("Low");
 		}
 	);
 
@@ -2141,3 +2278,29 @@ describe("Table Converter - #isFilteringCaseSensitive", function() {
 		expect(isFilteringCaseSensitive(converterContext)).toEqual(false);
 	});
 });
+describe("Table Annotation Configuration - rowStatusTextVisibility", function() {
+	it("Check for the Object returned by getRowStatusVisibility", function() {
+		const oRowStatusVisibilityObj = getRowStatusVisibility(),
+			oExpectedResultObj = {
+				"_type": "Formatter",
+				"fn": "sap.fe.core.formatters.TableFormatter",
+				"parameters": [
+					{
+						"_type": "Constant",
+						"value": "getErrorStatusTextVisibilityFormatter"
+					},
+					{
+						"_type": "Binding",
+						"modelName": "internal",
+						"path": "semanticKeyHasDraftIndicator"
+					},
+					{
+						"_type": "Binding",
+						"modelName": "internal",
+						"path": "filteredMessages"
+					}
+				]
+			};
+		expect(oRowStatusVisibilityObj).toEqual(oExpectedResultObj);
+	});
+});