@saltcorn/server 0.9.0-beta.1 → 0.9.0-beta.11

package/package.json

@@ -1,18 +1,18 @@
 {
   "name": "@saltcorn/server",
-  "version": "0.9.0-beta.1",
+  "version": "0.9.0-beta.11",
   "description": "Server app for Saltcorn, open-source no-code platform",
   "homepage": "https://saltcorn.com",
   "main": "index.js",
   "license": "MIT",
   "dependencies": {
-    "@saltcorn/base-plugin": "0.9.0-beta.1",
-    "@saltcorn/builder": "0.9.0-beta.1",
-    "@saltcorn/data": "0.9.0-beta.1",
-    "@saltcorn/admin-models": "0.9.0-beta.1",
-    "@saltcorn/filemanager": "0.9.0-beta.1",
-    "@saltcorn/markup": "0.9.0-beta.1",
-    "@saltcorn/sbadmin2": "0.9.0-beta.1",
+    "@saltcorn/base-plugin": "0.9.0-beta.11",
+    "@saltcorn/builder": "0.9.0-beta.11",
+    "@saltcorn/data": "0.9.0-beta.11",
+    "@saltcorn/admin-models": "0.9.0-beta.11",
+    "@saltcorn/filemanager": "0.9.0-beta.11",
+    "@saltcorn/markup": "0.9.0-beta.11",
+    "@saltcorn/sbadmin2": "0.9.0-beta.11",
     "@socket.io/cluster-adapter": "^0.2.1",
     "@socket.io/sticky": "^1.0.1",
     "adm-zip": "0.5.10",
@@ -45,6 +45,7 @@
     "node-fetch": "2.6.9",
     "node-watch": "^0.7.2",
     "notp": "2.0.3",
+    "npm-registry-fetch": "16.0.0",
     "passport": "^0.6.0",
     "passport-custom": "^1.1.1",
     "passport-http-bearer": "^1.0.1",
@@ -55,7 +56,7 @@
     "qrcode": "1.5.1",
     "resize-with-sharp-or-jimp": "0.1.6",
     "socket.io": "4.6.0",
-    "systeminformation": "^5.11.12",
+    "systeminformation": "^5.21.7",
     "thirty-two": "1.0.2",
     "tmp-promise": "^3.0.2",
     "uuid": "^8.2.0",

package/public/saltcorn-builder.css

@@ -446,3 +446,7 @@ Copyright (c) 2017 Taha Paksu
   padding: 5px 9px;
   z-index: 1;
 }
+
+div.builder-config-field {
+  margin-top: 0.5rem;
+}

package/public/saltcorn-common.js

@@ -51,6 +51,7 @@ const nubBy = (prop, xs) => {
   });
 };
 function apply_showif() {
+  const isNode = typeof parent?.saltcorn?.data?.state === "undefined";
   $("[data-show-if]").each(function (ix, element) {
     var e = $(element);
     try {
@@ -78,6 +79,15 @@ function apply_showif() {
       console.error(e);
     }
   });
+  $("[data-dyn-href]").each(function (ix, element) {
+    const e = $(element);
+    const rec = get_form_record(e);
+    const href = new Function(
+      `{${Object.keys(rec).join(",")}}`,
+      "return " + e.attr("data-dyn-href")
+    )(rec);
+    e.attr("href", href);
+  });
   $("[data-calc-options]").each(function (ix, element) {
     var e = $(element);
     var data = JSON.parse(decodeURIComponent(e.attr("data-calc-options")));
@@ -118,10 +128,13 @@ function apply_showif() {
     const dynwhere = JSON.parse(
       decodeURIComponent(e.attr("data-fetch-options"))
     );
-    //console.log("dynwhere", dynwhere);
-    const qss = Object.entries(dynwhere.whereParsed).map(
-      ([k, v]) => `${k}=${v[0] === "$" ? rec[v.substring(1)] : v}`
-    );
+    if (window._sc_loglevel > 4) console.log("dynwhere", dynwhere);
+    const kvToQs = ([k, v]) => {
+      return k === "or" && Array.isArray(v)
+        ? v.map((v1) => Object.entries(v1).map(kvToQs).join("&")).join("&")
+        : `${k}=${v[0] === "$" ? rec[v.substring(1)] : v}`;
+    };
+    const qss = Object.entries(dynwhere.whereParsed).map(kvToQs);
     if (dynwhere.dereference) {
       if (Array.isArray(dynwhere.dereference))
         qss.push(...dynwhere.dereference.map((d) => `dereference=${d}`));
@@ -195,6 +208,9 @@ function apply_showif() {
       });
       $.ajax(`/api/${dynwhere.table}?${qs}`).then((resp) => {
         if (resp.success) {
+          if (window._sc_loglevel > 4)
+            console.log("dynwhere fetch", qs, resp.success);
+
           activate(resp.success, qs);
           const cacheNow = e.prop("data-fetch-options-cache") || {};
           e.prop("data-fetch-options-cache", {
@@ -263,10 +279,12 @@ function apply_showif() {
 
     if (typeof cache[recS] !== "undefined") {
       e.html(cache[recS]);
+      e.prop("data-source-url-current", recS);
       activate_onchange_coldef();
       return;
     }
-    ajax_post_json(e.attr("data-source-url"), rec, {
+
+    const cb = {
       success: (data) => {
         e.html(data);
         const cacheNow = e.prop("data-source-url-cache") || {};
@@ -286,7 +304,11 @@ function apply_showif() {
         });
         e.html("");
       },
-    });
+    };
+    if (isNode) ajax_post_json(e.attr("data-source-url"), rec, cb);
+    else {
+      local_post_json(e.attr("data-source-url"), rec, cb);
+    }
   });
   const locale =
     navigator.userLanguage ||
@@ -509,6 +531,11 @@ function initialize_page() {
   });
 
   $("form").change(apply_showif);
+  // also change if we select same
+  $("form select").on("blur", (e) => {
+    if (!e || !e.target) return;
+    $(e.target).closest("form").trigger("change");
+  });
   apply_showif();
   apply_showif();
   $("[data-inline-edit-dest-url]").each(function () {
@@ -530,6 +557,7 @@ function initialize_page() {
     var ajax = !!$(this).attr("data-inline-edit-ajax");
     var type = $(this).attr("data-inline-edit-type");
     var schema = $(this).attr("data-inline-edit-schema");
+    var decimalPlaces = $(this).attr("data-inline-edit-decimal-places");
     if (schema) {
       schema = JSON.parse(decodeURIComponent(schema));
     }
@@ -552,6 +580,7 @@ function initialize_page() {
         type,
         is_key,
         schema,
+        ...(decimalPlaces ? { decimalPlaces } : {}),
       })
     );
     const doAjaxOptionsFetch = (tblName, target) => {
@@ -604,7 +633,17 @@ function initialize_page() {
         }
         <input type="${
           type === "Integer" || type === "Float" ? "number" : "text"
-        }" name="${key}" value="${escapeHtml(current)}">
+        }" ${
+          type === "Float"
+            ? `step="${
+                decimalPlaces
+                  ? Math.round(
+                      Math.pow(10, -decimalPlaces) * Math.pow(10, decimalPlaces)
+                    ) / Math.pow(10, decimalPlaces)
+                  : "any"
+              }"`
+            : ""
+        } name="${key}" value="${escapeHtml(current)}">
       <button type="submit" class="btn btn-sm btn-primary">OK</button>
       <button onclick="cancel_inline_edit(event, '${opts}')" type="button" class="btn btn-sm btn-danger"><i class="fas fa-times"></i></button>
       </form>`
@@ -657,10 +696,13 @@ function initialize_page() {
       setTimeout(() => {
         codes.forEach((el) => {
           //console.log($(el).attr("mode"), el);
+          if ($(el).hasClass("codemirror-enabled")) return;
+
           const cm = CodeMirror.fromTextArea(el, {
             lineNumbers: true,
             mode: $(el).attr("mode"),
           });
+          $(el).addClass("codemirror-enabled");
           cm.on(
             "change",
             $.debounce(() => {
@@ -771,6 +813,11 @@ function inline_submit_success(e, form, opts) {
       : ""
   }
   ${opts.current_label ? `data-inline-edit-current-label="${val}"` : ""}
+  ${
+    opts.decimalPlaces
+      ? `data-inline-edit-decimal-places="${opts.decimalPlaces}"`
+      : ""
+  }
   data-inline-edit-dest-url="${opts.url}">
     <span class="current">${val}</span>
     <i class="editicon ${!isNode ? "visible" : ""} fas fa-edit ms-1"></i>
@@ -948,14 +995,25 @@ function emptyAlerts() {
   $("#toasts-area").html("");
 }
 
-function press_store_button(clicked) {
+function press_store_button(clicked, keepOld) {
   let btn = clicked;
   if ($(clicked).is("form")) btn = $(clicked).find("button[type=submit]");
-
+  if (keepOld) {
+    const oldText = $(btn).html();
+    $(btn).data("old-text", oldText);
+  }
   const width = $(btn).width();
   $(btn).html('<i class="fas fa-spinner fa-spin"></i>').width(width);
 }
 
+function restore_old_button(btnId) {
+  const btn = $(`#${btnId}`);
+  const oldText = $(btn).data("old-text");
+  btn.html(oldText);
+  btn.css({ width: "" });
+  btn.removeData("old-text");
+}
+
 function common_done(res, viewname, isWeb = true) {
   const handle = (element, fn) => {
     if (Array.isArray(element)) for (const current of element) fn(current);
@@ -994,6 +1052,7 @@ function common_done(res, viewname, isWeb = true) {
       if (input.attr("type") === "checkbox")
         input.prop("checked", res.set_fields[k]);
       else input.val(res.set_fields[k]);
+      input.trigger("set_form_field");
     });
   }
   if (res.goto && !isWeb)
@@ -1011,6 +1070,7 @@ function common_done(res, viewname, isWeb = true) {
       if (
         prev.origin === next.origin &&
         prev.pathname === next.pathname &&
+        prev.searchParams.toString() === next.searchParams.toString() &&
         next.hash !== prev.hash
       )
         location.reload();

package/public/saltcorn.js

@@ -340,6 +340,28 @@ function ajax_modal(url, opts = {}) {
         $("body").css("overflow", "");
       });
     },
+    ...(opts.onError
+      ? {
+          error: opts.onError,
+        }
+      : {}),
+  });
+}
+
+function selectVersionError(res, btnId) {
+  notifyAlert({
+    type: "danger",
+    text: res.responseJSON?.error || "unknown error",
+  });
+  restore_old_button(btnId);
+}
+
+function submitWithAjax(e) {
+  saveAndContinue(e, (res) => {
+    if (res && res.responseJSON && res.responseJSON.url_when_done)
+      window.location.href = res.responseJSON.url_when_done;
+    if (res && res.responseJSON && res.responseJSON.error)
+      notifyAlert({ type: "danger", text: res.responseJSON.error });
   });
 }
 
@@ -368,6 +390,9 @@ function saveAndContinue(e, k) {
       if (res.notify) {
         notifyAlert(res.notify);
       }
+      if (res.reload_page) {
+        location.reload(); //TODO notify to cookie if reload or goto
+      }
     },
     error: function (request) {
       var ct = request.getResponseHeader("content-type") || "";
@@ -388,8 +413,8 @@ function saveAndContinue(e, k) {
       }
       ajax_indicate_error(e, request);
     },
-    complete: function () {
-      if (k) k();
+    complete: function (res) {
+      if (k) k(res);
     },
   });
 
@@ -410,7 +435,8 @@ function updateMatchingRows(e, viewname) {
   }
 }
 
-function applyViewConfig(e, url, k) {
+function applyViewConfig(e, url, k, event) {
+  if (event && event.target && event.target.id === "myEditor_icon") return;
   var form = $(e).closest("form");
   var form_data = form.serializeArray();
   const cfg = {};

package/routes/actions.js

@@ -174,8 +174,9 @@ const triggerForm = async (req, trigger) => {
         attributes: {
           explainers: {
             Often: req.__("Every 5 minutes"),
-            Never:
-              req.__("Not scheduled but can be run as an action from a button click"),
+            Never: req.__(
+              "Not scheduled but can be run as an action from a button click"
+            ),
           },
         },
       },
@@ -201,6 +202,7 @@ const triggerForm = async (req, trigger) => {
         label: req.__("Action"),
         type: "String",
         required: true,
+        help: { topic: "Actions" },
         attributes: {
           calcOptions: ["when_trigger", action_options],
         },
@@ -388,6 +390,16 @@ router.get(
       return;
     }
     const action = getState().actions[trigger.action];
+    // get table related to trigger
+    const table = trigger.table_id
+      ? Table.findOne({ id: trigger.table_id })
+      : null;
+
+    const subtitle = span(
+      { class: "ms-3" },
+      trigger.action,
+      table ? ` on ` + a({ href: `/table/${table.name}` }, table.name) : ""
+    );
     if (!action) {
       req.flash("warning", req.__("Action not found"));
       res.redirect(`/actions/`);
@@ -402,7 +414,7 @@ router.get(
       form.values = trigger.configuration;
       const events = Trigger.when_options;
       const actions = Trigger.find({
-        when_trigger: {or: ["API call", "Never"]},
+        when_trigger: { or: ["API call", "Never"] },
       });
       const tables = (await Table.find({})).map((t) => ({
         name: t.name,
@@ -418,6 +430,7 @@ router.get(
           type: "card",
           titleAjaxIndicator: true,
           title: req.__("Configure trigger %s", trigger.name),
+          subtitle,
           contents: {
             widths: [8, 4],
             besides: [
@@ -463,10 +476,6 @@ router.get(
       req.flash("warning", req.__("Action not configurable"));
       res.redirect(`/actions/`);
     } else {
-      // get table related to trigger
-      const table = trigger.table_id
-        ? Table.findOne({ id: trigger.table_id })
-        : null;
       // get configuration fields
       const cfgFields = await getActionConfigFields(action, table);
       // create form
@@ -489,6 +498,7 @@ router.get(
           type: "card",
           titleAjaxIndicator: true,
           title: req.__("Configure trigger %s", trigger.name),
+          subtitle,
           contents: renderForm(form, req.csrfToken()),
         },
       });

package/routes/admin.js

@@ -285,6 +285,9 @@ router.get(
     backupForm.values.auto_backup_expire_days = getState().getConfig(
       "auto_backup_expire_days"
     );
+    backupForm.values.backup_with_event_log = getState().getConfig(
+      "backup_with_event_log"
+    );
     //
     const aSnapshotForm = snapshotForm(req);
     aSnapshotForm.values.snapshots_enabled =
@@ -721,6 +724,15 @@ const autoBackupForm = (req) =>
           auto_backup_destination: "Local directory",
         },
       },
+      {
+        type: "Bool",
+        label: req.__("Include Event Logs"),
+        sublabel: req.__("Backup with event logs"),
+        name: "backup_with_event_log",
+        showIf: {
+          auto_backup_frequency: ["Daily", "Weekly"],
+        },
+      },
     ],
   });
 
@@ -1545,7 +1557,7 @@ router.get(
                 input({
                   type: "hidden",
                   name: "entryPointType",
-                  value: "view",
+                  value: builderSettings.entryPointType || "view",
                   id: "entryPointTypeID",
                 }),
                 div(
@@ -1578,7 +1590,8 @@ router.get(
                           div(
                             {
                               class: `nav-link ${
-                                !builderSettings.entryPointType || builderSettings.entryPointType === "view"
+                                !builderSettings.entryPointType ||
+                                builderSettings.entryPointType === "view"
                                   ? "active"
                                   : ""
                               }`,
@@ -1613,7 +1626,8 @@ router.get(
                               ? "d-none"
                               : ""
                           }`,
-                          ...(!builderSettings.entryPointType || builderSettings.entryPointType === "view"
+                          ...(!builderSettings.entryPointType ||
+                          builderSettings.entryPointType === "view"
                             ? { name: "entryPoint" }
                             : {}),
                           id: "viewInputID",
@@ -1636,7 +1650,8 @@ router.get(
                       select(
                         {
                           class: `form-select ${
-                            !builderSettings.entryPointType || builderSettings.entryPointType === "view"
+                            !builderSettings.entryPointType ||
+                            builderSettings.entryPointType === "view"
                               ? "d-none"
                               : ""
                           }`,

package/routes/fields.js

@@ -409,7 +409,7 @@ const fieldFlow = (req) =>
             instance_options[model.name].push(...instances.map((i) => i.name));
 
             const outputs = await applyAsync(
-              model.templateObj.prediction_outputs || [],
+              model.templateObj?.prediction_outputs || [], // unit tests can have templateObj undefined
               { table, configuration: model.configuration }
             );
             output_options[model.name] = outputs.map((o) => o.name);
@@ -840,6 +840,11 @@ router.post(
     const table = Table.findOne({ name: tableName });
     const role = req.user && req.user.id ? req.user.role_id : 100;
 
+    getState().log(
+      5,
+      `Route /fields/show-calculated/${tableName}/${fieldName}/${fieldview} user=${req.user?.id}`
+    );
+
     const fields = table.getFields();
     let row = { ...req.body };
     if (row && Object.keys(row).length > 0) readState(row, fields);
@@ -1018,6 +1023,13 @@ router.post(
     const { tableName, fieldName, fieldview } = req.params;
     const table = Table.findOne({ name: tableName });
     const fields = table.getFields();
+    const state = getState();
+
+    state.log(
+      5,
+      `Route /fields/preview/${tableName}/${fieldName}/${fieldview} user=${req.user?.id}`
+    );
+
     let field, row, value;
     if (fieldName.includes(".")) {
       const [refNm, targetNm] = fieldName.split(".");
@@ -1048,9 +1060,9 @@ router.post(
     }
     const fieldviews =
       field.type === "Key"
-        ? getState().keyFieldviews
+        ? state.keyFieldviews
         : field.type === "File"
-        ? getState().fileviews
+        ? state.fileviews
         : field.type.fieldviews;
     if (!field.type || !fieldviews) {
       res.send("");

package/routes/menu.js

@@ -44,7 +44,7 @@ const menuForm = async (req) => {
   const views = await View.find({}, { orderBy: "name", nocase: true });
   const pages = await Page.find({}, { orderBy: "name", nocase: true });
   const roles = await User.get_roles();
-  const tables = await Table.find({});
+  const tables = await Table.find_with_external({});
   const dynTableOptions = tables.map((t) => t.name);
   const dynOrderFieldOptions = {},
     dynSectionFieldOptions = {};