@saber-usa/node-common 1.7.16 → 1.7.17

package/src/OrbitUtils.js

@@ -1,13 +1,12 @@
 import {MU} from "./constants.js";
-import {cross, norm} from "mathjs";
+import {cross, dot, norm} from "mathjs";
 import {wrapHalfRevUnsigned, wrapOneRevUnsigned} from "./utils.js";
 
 const EARTH_MU_KM = MU / 1e9;
+const cross3 = (a, b) => cross(a, b);
+const dot3 = (a, b) => dot(a, b);
 
 class OrbitUtils {
-    constructor() {
-        // Prevent instantiation
-    }
     /**
      * Get inclination based on azimuth and latitude.
      * @param {number} azimuthRad - Azimuth in radians
@@ -176,12 +175,12 @@ class OrbitUtils {
                 r1 = (c - a) * (fb - fc);
                 q = (c - b) * (fa - fc);
                 p = (c - b) * q - (c - a) * r1;
-                q = 2.0 * (q - r1);
-                if (q > 0.0) {p = -p;}
+                q = 2 * (q - r1);
+                if (q > 0) {p = -p;}
                 q = Math.abs(q);
-                min1 = 3.0 * q * Math.abs(xm);
+                min1 = 3 * q * Math.abs(xm);
                 min2 = Math.abs(e * q);
-                if (2.0 * p < (min1 < min2 ? min1 : min2)) {
+                if (2 * p < Math.min(min1, min2)) {
                     e = d;
                     d = p / q;
                 } else {
@@ -285,21 +284,8 @@ class OrbitUtils {
             throw new Error("Mu must be greater than 1e-30.");
         }
 
-        // Helper functions
-        function cross(a, b) {
-            return [
-                a[1] * b[2] - a[2] * b[1],
-                a[2] * b[0] - a[0] * b[2],
-                a[0] * b[1] - a[1] * b[0],
-            ];
-        }
-
-        function dot(a, b) {
-            return a[0] * b[0] + a[1] * b[1] + a[2] * b[2];
-        }
-
         function norm(v) {
-            return Math.sqrt(v[0] * v[0] + v[1] * v[1] + v[2] * v[2]);
+            return Math.hypot(v[0], v[1], v[2]);
         }
 
         function clamp(value, min, max) {
@@ -307,8 +293,8 @@ class OrbitUtils {
         }
 
         // Calculate basic vectors
-        const h = cross(r, v);
-        const n = cross([0, 0, 1], h);
+        const h = cross3(r, v);
+        const n = cross3([0, 0, 1], h);
 
         const rLength = norm(r);
         const vLength = norm(v);
@@ -319,7 +305,7 @@ class OrbitUtils {
         // Eccentricity vector calculation (corrected formula)
         const vLengthSq = vLength * vLength;
         const muOverR = mu / rLength;
-        const rvDot = dot(r, v);
+        const rvDot = dot3(r, v);
 
         const e = [
             (1 / mu) * ((vLengthSq - muOverR) * r[0] - rvDot * v[0]),
@@ -332,7 +318,7 @@ class OrbitUtils {
         if (zeta === 0) {throw new Error("Zeta cannot be zero.");}
 
         const eLength = norm(e);
-        if (Math.abs(1.0 - eLength) <= tol) {
+        if (Math.abs(1 - eLength) <= tol) {
             throw new Error("Parabolic orbit conversion is not supported.");
         }
 
@@ -363,7 +349,7 @@ class OrbitUtils {
 
         // CASE 1: Non-circular, Inclined Orbit
         if (eLength >= 1e-11 && i >= 1e-11 && i <= Math.PI - 1e-11) {
-            if (nLength === 0.0) {
+            if (nLength === 0) {
                 throw new Error("Cannot convert from Cartesian to Keplerian "
                     + "- line-of-nodes vector is a zero vector.");
             }
@@ -371,47 +357,42 @@ class OrbitUtils {
             raan = Math.acos(n[0] / nLength);
             if (n[1] < 0) {raan = 2 * Math.PI - raan;}
 
-            w = Math.acos(dot(n, e) / (nLength * eLength));
+            w = Math.acos(dot3(n, e) / (nLength * eLength));
             if (e[2] < 0) {w = 2 * Math.PI - w;}
 
-            f = Math.acos(clamp(dot(e, r) / (eLength * rLength), -1, 1));
+            f = Math.acos(clamp(dot3(e, r) / (eLength * rLength), -1, 1));
             if (rvDot < 0) {f = 2 * Math.PI - f;}
         } else if (eLength >= 1e-11 && (i < 1e-11 || i > Math.PI - 1e-11)) { // CASE 2: Non-circular, Equatorial Orbit
-            if (eLength === 0.0) {
+            if (eLength === 0) {
                 throw new Error(`Cannot convert from Cartesian to Keplerian 
                     - eccentricity is zero.`);
             }
-            raan = 0;
             w = Math.acos(e[0] / eLength);
             if (e[1] < 0) {w = 2 * Math.PI - w;}
 
             // For GMT-4446 fix (LOJ: 2014.03.21)
-            if (i > Math.PI - 1e-11) {w *= -1.0;}
-            if (w < 0.0) {w += 2 * Math.PI;}
+            if (i > Math.PI - 1e-11) {w *= -1;}
+            if (w < 0) {w += 2 * Math.PI;}
 
-            f = Math.acos(clamp(dot(e, r) / (eLength * rLength), -1, 1));
+            f = Math.acos(clamp(dot3(e, r) / (eLength * rLength), -1, 1));
             if (rvDot < 0) {f = 2 * Math.PI - f;}
         } else if (eLength < 1e-11 && i >= 1e-11 && i <= Math.PI - 1e-11) { // CASE 3: Circular, Inclined Orbit
-            if (nLength === 0.0) {
+            if (nLength === 0) {
                 throw new Error("Cannot convert from Cartesian to Keplerian "
                    + "- line-of-nodes vector is a zero vector.");
             }
             raan = Math.acos(n[0] / nLength);
             if (n[1] < 0) {raan = 2 * Math.PI - raan;}
 
-            w = 0;
-
-            f = Math.acos(clamp(dot(n, r) / (nLength * rLength), -1, 1));
+            f = Math.acos(clamp(dot3(n, r) / (nLength * rLength), -1, 1));
             if (r[2] < 0) {f = 2 * Math.PI - f;}
         } else if (eLength < 1e-11 && (i < 1e-11 || i > Math.PI - 1e-11)) { // CASE 4: Circular, Equatorial Orbit
-            raan = 0;
-            w = 0;
             f = Math.acos(clamp(r[0] / rLength, -1, 1));
             if (r[1] < 0) {f = 2 * Math.PI - f;}
 
             // For GMT-4446 fix (LOJ: 2014.03.21)
-            if (i > Math.PI - 1e-11) {f *= -1.0;}
-            if (f < 0.0) {f += 2 * Math.PI;}
+            if (i > Math.PI - 1e-11) {f *= -1;}
+            if (f < 0) {f += 2 * Math.PI;}
         }
 
         // Calculate additional orbital parameters

package/src/ShadowGEOCalculator.js

@@ -140,7 +140,7 @@ class ShadowGEOCalculator {
 
             // Project shadow center onto the GEO belt
             const shadowAxisEq = [shadowAxis[0], shadowAxis[1], 0];
-            const shadowAxisNorm = Math.sqrt(shadowAxisEq[0]**2 + shadowAxisEq[1]**2);
+            const shadowAxisNorm = Math.hypot(shadowAxisEq[0], shadowAxisEq[1]);
             shadowAxisEq[0] /= shadowAxisNorm;
             shadowAxisEq[1] /= shadowAxisNorm;
 
@@ -168,7 +168,7 @@ class ShadowGEOCalculator {
 
             // Project shadow center onto the GEO belt
             const shadowAxisEq = [shadowAxis[0], shadowAxis[1], 0];
-            const shadowAxisNorm = Math.sqrt(shadowAxisEq[0]**2 + shadowAxisEq[1]**2);
+            const shadowAxisNorm = Math.hypot(shadowAxisEq[0], shadowAxisEq[1]);
             shadowAxisEq[0] /= shadowAxisNorm;
             shadowAxisEq[1] /= shadowAxisNorm;
 

package/src/TimeConverter.js

@@ -62,7 +62,7 @@ class TimeConverter {
     }
 
     get JulianUTC() {
-        return this._julian !== null ? this._julian : TimeConverter.dateTimeToJulian(this.UTC);
+        return this._julian === null ? TimeConverter.dateTimeToJulian(this.UTC) : this._julian;
     }
 
     get JulianUT1() {
@@ -242,12 +242,12 @@ class TimeConverter {
     static getGMST(jdut1, wrap360 = true) {
         const tut1 = TimeConverter.julianToCenturiesTxxx(jdut1);
         let gmst = -6.2e-6 * tut1 * tut1 * tut1 + 0.093104 * tut1 * tut1
-                  + (876600.0 * 3600 + 8640184.812866) * tut1 + 67310.54841; // seconds
-        gmst = gmst * (Math.PI / 180) / 240.0 % (2.0 * Math.PI); // 360/86400 = 1/240, to deg, to rad
+                  + (876600 * 3600 + 8640184.812866) * tut1 + 67310.54841; // seconds
+        gmst = gmst * (Math.PI / 180) / 240 % (2 * Math.PI); // 360/86400 = 1/240, to deg, to rad
 
         // Check quadrants
-        if (gmst < 0.0 && wrap360) {
-            gmst += 2.0 * Math.PI;
+        if (gmst < 0 && wrap360) {
+            gmst += 2 * Math.PI;
         }
 
         return {
@@ -269,9 +269,9 @@ class TimeConverter {
         let lst = lonDeg * Math.PI / 180 + gmst;
 
         // Check quadrants
-        lst %= 2.0 * Math.PI;
-        if (lst < 0.0 && wrap360) {
-            lst += 2.0 * Math.PI;
+        lst %= 2 * Math.PI;
+        if (lst < 0 && wrap360) {
+            lst += 2 * Math.PI;
         }
 
         return {
@@ -286,7 +286,7 @@ class TimeConverter {
      * @return {number} Centuries since J2000
      */
     static julianToCenturiesTxxx(julian) {
-        return (julian - 2451545.0) / 36525.0;
+        return (julian - 2451545) / 36525;
     }
 }
 
@@ -304,6 +304,8 @@ class RaDec {
             Radians: decDeg * Math.PI / 180,
         };
     }
+
 }
 
 export {TimeConverter, RaDec};
+