@saber-usa/node-common 1.7.16 → 1.7.17

package/README.md

@@ -10,4 +10,25 @@ AGPLv3
 1. Increment the version in `package.json`
 2. Check you are logged in to npm using `npm whoami`
 3. You may need to login using `npm login` note your npm user must have 2FA enabled (in your profile)
-4. Run `npm install` `npm login` then `npm publish`
+4. Run `npm install` `npm login` then `npm publish`
+
+## Run SonarQube Scan
+To run SonarQube locally:
+
+`docker run -d --name sonarqube -p 9000:9000 sonarqube:latest`
+
+Go to `http://localhost:9000` (default credentials: `admin` / `admin`).
+
+Create a local project (NPM) and generate a token.
+
+Run a scan on this project:
+
+```
+sonar -Dsonar.host.url=http://localhost:9000 -Dsonar.token=<your_sonarqube_token> -Dsonar.projectKey=node-common
+```
+
+MCP setup options:
+- Cursor: set token/url in `.cursor/sonarqube.env` (used by `.cursor/mcp.json`).
+- Claude Code: set token/url in `.mcp.json` (or copy from `.mcp.json.example`).
+
+Note: for Dockerized MCP, use `http://host.docker.internal:9000` as `SONARQUBE_URL`.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@saber-usa/node-common",
-  "version": "1.7.16",
+  "version": "1.7.17",
   "description": "Common node functions for Saber",
   "main": "src/index.js",
   "type": "module",
@@ -12,7 +12,7 @@
     "lint:fix": "eslint . --fix",
     "test": "jest --no-coverage --silent",
     "test:unit": "jest --coverage --runInBand --no-watch",
-    "sonar": "node --experimental-vm-modules sonar-project.js"
+    "sonar": "sonar -Dsonar.host.url=http://localhost:9000"
   },
   "files": [
     "src/**/*"
@@ -20,7 +20,7 @@
   "author": "Saber USA",
   "license": "ISC",
   "dependencies": {
-    "@aws-sdk/client-s3": "^3.1024.0",
+    "@aws-sdk/client-s3": "^3.1034.0",
     "date-fns": "^4.1.0",
     "lodash": "4.18.1",
     "mathjs": "^15.2.0",
@@ -28,20 +28,20 @@
     "plotly": "^1.0.6",
     "satellite.js": "^7.0.0",
     "solar-calculator": "^0.3.0",
-    "three": "^0.183.2",
+    "three": "^0.184",
     "winston": "3.19.0"
   },
   "devDependencies": {
     "@babel/preset-env": "^7.29.2",
     "@eslint/js": "^10.0.1",
     "@jest/globals": "^30.3.0",
-    "eslint": "^10.1.0",
-    "eslint-plugin-jest": "^29.15.1",
-    "globals": "^16.5.0",
+    "@sonar/scan": "^4.3.6",
+    "eslint": "^10.2.1",
+    "eslint-plugin-jest": "^29.15.2",
+    "globals": "^17.5.0",
     "jest": "^30.3.0",
     "jest-diff": "^30.3.0",
-    "nodemon": "3.1.4",
-    "sonarqube-scanner": "3.0.1"
+    "nodemon": "3.1.14"
   },
   "overrides": {
     "braces": "3.0.3",

package/src/FrameConverter.js

@@ -580,9 +580,9 @@ class FrameConverter {
         // https://github.com/skyfielders/python-skyfield/blob/master/skyfield/framelib.py
         // 'xi0', 'eta0', and 'da0' are ICRS frame biases in arcseconds taken
         // from IERS (2003) Conventions, Chapter 5.
-        const xi0 = -0.0166170 * Constants.ArcsecToRad;
+        const xi0 = -0.016617 * Constants.ArcsecToRad;
         const eta0 = -0.0068192 * Constants.ArcsecToRad;
-        const da0 = -0.01460 * Constants.ArcsecToRad;
+        const da0 = -0.0146 * Constants.ArcsecToRad;
 
         // Compute elements of rotation matrix.
         const yx = -da0;
@@ -723,7 +723,6 @@ class FrameConverter {
         let eqeg;
 
         const prec = this.precessionFk5(ttt);
-        // const { nut } = this.nutationFk5(ttt);
         const nut = this.nutationFk5(ttt);
 
         // Rotate teme through just geometric terms
@@ -738,7 +737,6 @@ class FrameConverter {
         const temp = this.multiplyMatrices(nut.nut, eqep);
         const returnMat = this.multiplyMatrices(prec, temp);
         return returnMat;
-        // return prec.multiply(temp);
     }
 
     /**
@@ -760,17 +758,17 @@ class FrameConverter {
      */
     static nutationFk5(ttt) {
         // Compute the mean obliquity of the ecliptic
-        let me1980 = ((0.001813 * ttt - 0.00059) * ttt - 46.8150) * ttt + 84381.448;
+        let me1980 = ((0.001813 * ttt - 0.00059) * ttt - 46.815) * ttt + 84381.448;
         me1980 = me1980 / 3600 % 360;
         me1980 *= Constants.DegToRad;
 
         // Evaluate the Delaunay parameters associated with the Moon and the Sun in the interval [0,2π]°
         const oo3600 = 1 / 3600;
-        let Mm = ((0.064 * ttt + 31.310) * ttt + 1717915922.6330) * ttt * oo3600 + 134.96298139;
-        let Ms = (((-0.012) * ttt - 0.577) * ttt + 129596581.2240) * ttt * oo3600 + 357.52772333;
-        let uMm = ((0.011 * ttt - 13.257) * ttt + 1739527263.1370) * ttt * oo3600 + 93.27191028;
-        let Ds = ((0.019 * ttt - 6.891) * ttt + 1602961601.3280) * ttt * oo3600 + 297.85036306;
-        let Omegam = ((0.008 * ttt + 7.455) * ttt - 6962890.5390) * ttt * oo3600 + 125.04452222;
+        let Mm = ((0.064 * ttt + 31.31) * ttt + 1717915922.633) * ttt * oo3600 + 134.96298139;
+        let Ms = (((-0.012) * ttt - 0.577) * ttt + 129596581.224) * ttt * oo3600 + 357.52772333;
+        let uMm = ((0.011 * ttt - 13.257) * ttt + 1739527263.137) * ttt * oo3600 + 93.27191028;
+        let Ds = ((0.019 * ttt - 6.891) * ttt + 1602961601.328) * ttt * oo3600 + 297.85036306;
+        let Omegam = ((0.008 * ttt + 7.455) * ttt - 6962890.539) * ttt * oo3600 + 125.04452222;
 
         Mm = Mm % 360 * Constants.DegToRad;
         Ms = Ms % 360 * Constants.DegToRad;
@@ -806,11 +804,6 @@ class FrameConverter {
         const costrueeps = Math.cos(trueObliq);
         const sintrueeps = Math.sin(trueObliq);
 
-        // const nut = new Matrix3D(
-        //     cospsi, costrueeps * sinpsi, sintrueeps * sinpsi,
-        //     -coseps * sinpsi, costrueeps * coseps * cospsi + sintrueeps * sineps, sintrueeps * coseps * cospsi - sineps * costrueeps,
-        //     -sineps * sinpsi, costrueeps * sineps * cospsi - sintrueeps * coseps, sintrueeps * sineps * cospsi + costrueeps * coseps
-        // );
 
         const nut = new Matrix3D(
             new Vector3D(cospsi, costrueeps * sinpsi, sintrueeps * sinpsi),
@@ -856,11 +849,6 @@ class FrameConverter {
         const sinz = Math.sin(z);
 
         // // Form matrix mod to gcrf
-        // return new Matrix3D(
-        //     coszeta * costheta * cosz - sinzeta * sinz, coszeta * costheta * sinz + sinzeta * cosz, coszeta * sintheta,
-        //     -sinzeta * costheta * cosz - coszeta * sinz, -sinzeta * costheta * sinz + coszeta * cosz, -sinzeta * sintheta,
-        //     -sintheta * cosz, -sintheta * sinz, costheta
-        // );
 
         return new Matrix3D(
             new Vector3D(coszeta * costheta * cosz - sinzeta * sinz,
@@ -892,16 +880,11 @@ class FrameConverter {
                     + 0.000063 * Constants.SecondToRad * Math.sin(2 * raan)
             : gmst + deltapsi * Math.cos(meaneps);
 
-        ast %= 2.0 * Math.PI;
+        ast %= 2 * Math.PI;
 
         const sinast = Math.sin(ast);
         const cosast = Math.cos(ast);
 
-        // return new Matrix3D(
-        //     cosast, -sinast, 0,
-        //     sinast, cosast, 0,
-        //     0, 0, 1
-        // );
 
         return new Matrix3D(
             new Vector3D(cosast, -sinast, 0), new Vector3D(sinast, cosast, 0),
@@ -924,12 +907,6 @@ class FrameConverter {
         const cosyp = Math.cos(yp);
         const sinyp = Math.sin(yp);
 
-        // // FK5 approach
-        // return new Matrix3D(
-        //     cosxp, 0, -sinxp,
-        //     sinxp * sinyp, cosyp, cosxp * sinyp,
-        //     sinxp * cosyp, -sinyp, cosxp * cosyp
-        // );
 
         return new Matrix3D(
             new Vector3D(cosxp, 0, -sinxp),
@@ -945,7 +922,7 @@ class FrameConverter {
      * @return {boolean} True if the frame is inertial, false otherwise
      */
     static CheckIfInertial(frame, throwError = false) {
-        if (frame === ReferenceFrame.ITRF) {
+        if (typeof frame === "string" && frame === ReferenceFrame.ITRF) {
             if (throwError) {
                 throw new Error(
                     "Cannot use a non-inertial frame for this method."
@@ -1007,112 +984,112 @@ class FrameConverter {
 
     // 1980 IAU Theory of Nutation Coefficients
     static NUT_COEFF = [
-        [0, 0, 0, 0, 1, -171996.0, -174.2, 92025.0, 8.9],
-        [0, 0, 2, -2, 2, -13187.0, -1.6, 5736.0, -3.1],
-        [0, 0, 2, 0, 2, -2274.0, -0.2, 977.0, -0.5],
-        [0, 0, 0, 0, 2, 2062.0, 0.2, -895.0, 0.5],
-        [0, 1, 0, 0, 0, 1426.0, -3.4, 54.0, -0.1],
-        [1, 0, 0, 0, 0, 712.0, 0.1, -7.0, 0.0],
-        [0, 1, 2, -2, 2, -517.0, 1.2, 224.0, -0.6],
-        [0, 0, 2, 0, 1, -386.0, -0.4, 200.0, 0.0],
-        [1, 0, 2, 0, 2, -301.0, 0.0, 129.0, -0.1],
-        [0, -1, 2, -2, 2, 217.0, -0.5, -95.0, 0.3],
-        [1, 0, 0, -2, 0, -158.0, 0.0, -1.0, 0.0],
-        [0, 0, 2, -2, 1, 129.0, 0.1, -70.0, 0.0],
-        [-1, 0, 2, 0, 2, 123.0, 0.0, -53.0, 0.0],
-        [1, 0, 0, 0, 1, 63.0, 0.1, -33.0, 0.0],
-        [0, 0, 0, 2, 0, 63.0, 0.0, -2.0, 0.0],
-        [-1, 0, 2, 2, 2, -59.0, 0.0, 26.0, 0.0],
-        [-1, 0, 0, 0, 1, -58.0, -0.1, 32.0, 0.0],
-        [1, 0, 2, 0, 1, -51.0, 0.0, 27.0, 0.0],
-        [2, 0, 0, -2, 0, 48.0, 0.0, 1.0, 0.0],
-        [-2, 0, 2, 0, 1, 46.0, 0.0, -24.0, 0.0],
-        [0, 0, 2, 2, 2, -38.0, 0.0, 16.0, 0.0],
-        [2, 0, 2, 0, 2, -31.0, 0.0, 13.0, 0.0],
-        [2, 0, 0, 0, 0, 29.0, 0.0, -1.0, 0.0],
-        [1, 0, 2, -2, 2, 29.0, 0.0, -12.0, 0.0],
-        [0, 0, 2, 0, 0, 26.0, 0.0, -1.0, 0.0],
-        [0, 0, 2, -2, 0, -22.0, 0.0, 0.0, 0.0],
-        [-1, 0, 2, 0, 1, 21.0, 0.0, -10.0, 0.0],
-        [0, 2, 0, 0, 0, 17.0, -0.1, 0.0, 0.0],
-        [0, 2, 2, -2, 2, -16.0, 0.1, 7.0, 0.0],
-        [-1, 0, 0, 2, 1, 16.0, 0.0, -8.0, 0.0],
-        [0, 1, 0, 0, 1, -15.0, 0.0, 9.0, 0.0],
-        [1, 0, 0, -2, 1, -13.0, 0.0, 7.0, 0.0],
-        [0, -1, 0, 0, 1, -12.0, 0.0, 6.0, 0.0],
-        [2, 0, -2, 0, 0, 11.0, 0.0, 0.0, 0.0],
-        [-1, 0, 2, 2, 1, -10.0, 0.0, 5.0, 0.0],
-        [1, 0, 2, 2, 2, -8.0, 0.0, 3.0, 0.0],
-        [0, -1, 2, 0, 2, -7.0, 0.0, 3.0, 0.0],
-        [0, 0, 2, 2, 1, -7.0, 0.0, 3.0, 0.0],
-        [1, 1, 0, -2, 0, -7.0, 0.0, 0.0, 0.0],
-        [0, 1, 2, 0, 2, 7.0, 0.0, -3.0, 0.0],
-        [-2, 0, 0, 2, 1, -6.0, 0.0, 3.0, 0.0],
-        [0, 0, 0, 2, 1, -6.0, 0.0, 3.0, 0.0],
-        [2, 0, 2, -2, 2, 6.0, 0.0, -3.0, 0.0],
-        [1, 0, 0, 2, 0, 6.0, 0.0, 0.0, 0.0],
-        [1, 0, 2, -2, 1, 6.0, 0.0, -3.0, 0.0],
-        [0, 0, 0, -2, 1, -5.0, 0.0, 3.0, 0.0],
-        [0, -1, 2, -2, 1, -5.0, 0.0, 3.0, 0.0],
-        [2, 0, 2, 0, 1, -5.0, 0.0, 3.0, 0.0],
-        [1, -1, 0, 0, 0, 5.0, 0.0, 0.0, 0.0],
-        [1, 0, 0, -1, 0, -4.0, 0.0, 0.0, 0.0],
-        [0, 0, 0, 1, 0, -4.0, 0.0, 0.0, 0.0],
-        [0, 1, 0, -2, 0, -4.0, 0.0, 0.0, 0.0],
-        [1, 0, -2, 0, 0, 4.0, 0.0, 0.0, 0.0],
-        [2, 0, 0, -2, 1, 4.0, 0.0, -2.0, 0.0],
-        [0, 1, 2, -2, 1, 4.0, 0.0, -2.0, 0.0],
-        [1, 1, 0, 0, 0, -3.0, 0.0, 0.0, 0.0],
-        [1, -1, 0, -1, 0, -3.0, 0.0, 0.0, 0.0],
-        [-1, -1, 2, 2, 2, -3.0, 0.0, 1.0, 0.0],
-        [0, -1, 2, 2, 2, -3.0, 0.0, 1.0, 0.0],
-        [1, -1, 2, 0, 2, -3.0, 0.0, 1.0, 0.0],
-        [3, 0, 2, 0, 2, -3.0, 0.0, 1.0, 0.0],
-        [-2, 0, 2, 0, 2, -3.0, 0.0, 1.0, 0.0],
-        [1, 0, 2, 0, 0, 3.0, 0.0, 0.0, 0.0],
-        [-1, 0, 2, 4, 2, -2.0, 0.0, 1.0, 0.0],
-        [1, 0, 0, 0, 2, -2.0, 0.0, 1.0, 0.0],
-        [-1, 0, 2, -2, 1, -2.0, 0.0, 1.0, 0.0],
-        [0, -2, 2, -2, 1, -2.0, 0.0, 1.0, 0.0],
-        [-2, 0, 0, 0, 1, -2.0, 0.0, 1.0, 0.0],
-        [2, 0, 0, 0, 1, 2.0, 0.0, -1.0, 0.0],
-        [3, 0, 0, 0, 0, 2.0, 0.0, 0.0, 0.0],
-        [1, 1, 2, 0, 2, 2.0, 0.0, -1.0, 0.0],
-        [0, 0, 2, 1, 2, 2.0, 0.0, -1.0, 0.0],
-        [1, 0, 0, 2, 1, -1.0, 0.0, 0.0, 0.0],
-        [1, 0, 2, 2, 1, -1.0, 0.0, 1.0, 0.0],
-        [1, 1, 0, -2, 1, -1.0, 0.0, 0.0, 0.0],
-        [0, 1, 0, 2, 0, -1.0, 0.0, 0.0, 0.0],
-        [0, 1, 2, -2, 0, -1.0, 0.0, 0.0, 0.0],
-        [0, 1, -2, 2, 0, -1.0, 0.0, 0.0, 0.0],
-        [1, 0, -2, 2, 0, -1.0, 0.0, 0.0, 0.0],
-        [1, 0, -2, -2, 0, -1.0, 0.0, 0.0, 0.0],
-        [1, 0, 2, -2, 0, -1.0, 0.0, 0.0, 0.0],
-        [1, 0, 0, -4, 0, -1.0, 0.0, 0.0, 0.0],
-        [2, 0, 0, -4, 0, -1.0, 0.0, 0.0, 0.0],
-        [0, 0, 2, 4, 2, -1.0, 0.0, 0.0, 0.0],
-        [0, 0, 2, -1, 2, -1.0, 0.0, 0.0, 0.0],
-        [-2, 0, 2, 4, 2, -1.0, 0.0, 1.0, 0.0],
-        [2, 0, 2, 2, 2, -1.0, 0.0, 0.0, 0.0],
-        [0, -1, 2, 0, 1, -1.0, 0.0, 0.0, 0.0],
-        [0, 0, -2, 0, 1, -1.0, 0.0, 0.0, 0.0],
-        [0, 0, 4, -2, 2, 1.0, 0.0, 0.0, 0.0],
-        [0, 1, 0, 0, 2, 1.0, 0.0, 0.0, 0.0],
-        [1, 1, 2, -2, 2, 1.0, 0.0, -1.0, 0.0],
-        [3, 0, 2, -2, 2, 1.0, 0.0, 0.0, 0.0],
-        [-2, 0, 2, 2, 2, 1.0, 0.0, -1.0, 0.0],
-        [-1, 0, 0, 0, 2, 1.0, 0.0, -1.0, 0.0],
-        [0, 0, -2, 2, 1, 1.0, 0.0, 0.0, 0.0],
-        [0, 1, 2, 0, 1, 1.0, 0.0, 0.0, 0.0],
-        [-1, 0, 4, 0, 2, 1.0, 0.0, 0.0, 0.0],
-        [2, 1, 0, -2, 0, 1.0, 0.0, 0.0, 0.0],
-        [2, 0, 0, 2, 0, 1.0, 0.0, 0.0, 0.0],
-        [2, 0, 2, -2, 1, 1.0, 0.0, -1.0, 0.0],
-        [2, 0, -2, 0, 1, 1.0, 0.0, 0.0, 0.0],
-        [1, -1, 0, -2, 0, 1.0, 0.0, 0.0, 0.0],
-        [-1, 0, 0, 1, 1, 1.0, 0.0, 0.0, 0.0],
-        [-1, -1, 0, 2, 1, 1.0, 0.0, 0.0, 0.0],
-        [0, 1, 0, 1, 0, 1.0, 0.0, 0.0, 0.0],
+        [0, 0, 0, 0, 1, -171996, -174.2, 92025, 8.9],
+        [0, 0, 2, -2, 2, -13187, -1.6, 5736, -3.1],
+        [0, 0, 2, 0, 2, -2274, -0.2, 977, -0.5],
+        [0, 0, 0, 0, 2, 2062, 0.2, -895, 0.5],
+        [0, 1, 0, 0, 0, 1426, -3.4, 54, -0.1],
+        [1, 0, 0, 0, 0, 712, 0.1, -7, 0],
+        [0, 1, 2, -2, 2, -517, 1.2, 224, -0.6],
+        [0, 0, 2, 0, 1, -386, -0.4, 200, 0],
+        [1, 0, 2, 0, 2, -301, 0, 129, -0.1],
+        [0, -1, 2, -2, 2, 217, -0.5, -95, 0.3],
+        [1, 0, 0, -2, 0, -158, 0, -1, 0],
+        [0, 0, 2, -2, 1, 129, 0.1, -70, 0],
+        [-1, 0, 2, 0, 2, 123, 0, -53, 0],
+        [1, 0, 0, 0, 1, 63, 0.1, -33, 0],
+        [0, 0, 0, 2, 0, 63, 0, -2, 0],
+        [-1, 0, 2, 2, 2, -59, 0, 26, 0],
+        [-1, 0, 0, 0, 1, -58, -0.1, 32, 0],
+        [1, 0, 2, 0, 1, -51, 0, 27, 0],
+        [2, 0, 0, -2, 0, 48, 0, 1, 0],
+        [-2, 0, 2, 0, 1, 46, 0, -24, 0],
+        [0, 0, 2, 2, 2, -38, 0, 16, 0],
+        [2, 0, 2, 0, 2, -31, 0, 13, 0],
+        [2, 0, 0, 0, 0, 29, 0, -1, 0],
+        [1, 0, 2, -2, 2, 29, 0, -12, 0],
+        [0, 0, 2, 0, 0, 26, 0, -1, 0],
+        [0, 0, 2, -2, 0, -22, 0, 0, 0],
+        [-1, 0, 2, 0, 1, 21, 0, -10, 0],
+        [0, 2, 0, 0, 0, 17, -0.1, 0, 0],
+        [0, 2, 2, -2, 2, -16, 0.1, 7, 0],
+        [-1, 0, 0, 2, 1, 16, 0, -8, 0],
+        [0, 1, 0, 0, 1, -15, 0, 9, 0],
+        [1, 0, 0, -2, 1, -13, 0, 7, 0],
+        [0, -1, 0, 0, 1, -12, 0, 6, 0],
+        [2, 0, -2, 0, 0, 11, 0, 0, 0],
+        [-1, 0, 2, 2, 1, -10, 0, 5, 0],
+        [1, 0, 2, 2, 2, -8, 0, 3, 0],
+        [0, -1, 2, 0, 2, -7, 0, 3, 0],
+        [0, 0, 2, 2, 1, -7, 0, 3, 0],
+        [1, 1, 0, -2, 0, -7, 0, 0, 0],
+        [0, 1, 2, 0, 2, 7, 0, -3, 0],
+        [-2, 0, 0, 2, 1, -6, 0, 3, 0],
+        [0, 0, 0, 2, 1, -6, 0, 3, 0],
+        [2, 0, 2, -2, 2, 6, 0, -3, 0],
+        [1, 0, 0, 2, 0, 6, 0, 0, 0],
+        [1, 0, 2, -2, 1, 6, 0, -3, 0],
+        [0, 0, 0, -2, 1, -5, 0, 3, 0],
+        [0, -1, 2, -2, 1, -5, 0, 3, 0],
+        [2, 0, 2, 0, 1, -5, 0, 3, 0],
+        [1, -1, 0, 0, 0, 5, 0, 0, 0],
+        [1, 0, 0, -1, 0, -4, 0, 0, 0],
+        [0, 0, 0, 1, 0, -4, 0, 0, 0],
+        [0, 1, 0, -2, 0, -4, 0, 0, 0],
+        [1, 0, -2, 0, 0, 4, 0, 0, 0],
+        [2, 0, 0, -2, 1, 4, 0, -2, 0],
+        [0, 1, 2, -2, 1, 4, 0, -2, 0],
+        [1, 1, 0, 0, 0, -3, 0, 0, 0],
+        [1, -1, 0, -1, 0, -3, 0, 0, 0],
+        [-1, -1, 2, 2, 2, -3, 0, 1, 0],
+        [0, -1, 2, 2, 2, -3, 0, 1, 0],
+        [1, -1, 2, 0, 2, -3, 0, 1, 0],
+        [3, 0, 2, 0, 2, -3, 0, 1, 0],
+        [-2, 0, 2, 0, 2, -3, 0, 1, 0],
+        [1, 0, 2, 0, 0, 3, 0, 0, 0],
+        [-1, 0, 2, 4, 2, -2, 0, 1, 0],
+        [1, 0, 0, 0, 2, -2, 0, 1, 0],
+        [-1, 0, 2, -2, 1, -2, 0, 1, 0],
+        [0, -2, 2, -2, 1, -2, 0, 1, 0],
+        [-2, 0, 0, 0, 1, -2, 0, 1, 0],
+        [2, 0, 0, 0, 1, 2, 0, -1, 0],
+        [3, 0, 0, 0, 0, 2, 0, 0, 0],
+        [1, 1, 2, 0, 2, 2, 0, -1, 0],
+        [0, 0, 2, 1, 2, 2, 0, -1, 0],
+        [1, 0, 0, 2, 1, -1, 0, 0, 0],
+        [1, 0, 2, 2, 1, -1, 0, 1, 0],
+        [1, 1, 0, -2, 1, -1, 0, 0, 0],
+        [0, 1, 0, 2, 0, -1, 0, 0, 0],
+        [0, 1, 2, -2, 0, -1, 0, 0, 0],
+        [0, 1, -2, 2, 0, -1, 0, 0, 0],
+        [1, 0, -2, 2, 0, -1, 0, 0, 0],
+        [1, 0, -2, -2, 0, -1, 0, 0, 0],
+        [1, 0, 2, -2, 0, -1, 0, 0, 0],
+        [1, 0, 0, -4, 0, -1, 0, 0, 0],
+        [2, 0, 0, -4, 0, -1, 0, 0, 0],
+        [0, 0, 2, 4, 2, -1, 0, 0, 0],
+        [0, 0, 2, -1, 2, -1, 0, 0, 0],
+        [-2, 0, 2, 4, 2, -1, 0, 1, 0],
+        [2, 0, 2, 2, 2, -1, 0, 0, 0],
+        [0, -1, 2, 0, 1, -1, 0, 0, 0],
+        [0, 0, -2, 0, 1, -1, 0, 0, 0],
+        [0, 0, 4, -2, 2, 1, 0, 0, 0],
+        [0, 1, 0, 0, 2, 1, 0, 0, 0],
+        [1, 1, 2, -2, 2, 1, 0, -1, 0],
+        [3, 0, 2, -2, 2, 1, 0, 0, 0],
+        [-2, 0, 2, 2, 2, 1, 0, -1, 0],
+        [-1, 0, 0, 0, 2, 1, 0, -1, 0],
+        [0, 0, -2, 2, 1, 1, 0, 0, 0],
+        [0, 1, 2, 0, 1, 1, 0, 0, 0],
+        [-1, 0, 4, 0, 2, 1, 0, 0, 0],
+        [2, 1, 0, -2, 0, 1, 0, 0, 0],
+        [2, 0, 0, 2, 0, 1, 0, 0, 0],
+        [2, 0, 2, -2, 1, 1, 0, -1, 0],
+        [2, 0, -2, 0, 1, 1, 0, 0, 0],
+        [1, -1, 0, -2, 0, 1, 0, 0, 0],
+        [-1, 0, 0, 1, 1, 1, 0, 0, 0],
+        [-1, -1, 0, 2, 1, 1, 0, 0, 0],
+        [0, 1, 0, 1, 0, 1, 0, 0, 0],
     ];
 }
 

package/src/LLA.js

@@ -18,7 +18,7 @@ class LLA {
         if (
             latitudeDeg instanceof Angle || (latitudeDeg
                 && typeof latitudeDeg === "object"
-                && Object.prototype.hasOwnProperty.call(latitudeDeg, "Degrees"))
+                && Object.hasOwn(latitudeDeg, "Degrees"))
         ) {
             this._initFromAngles(latitudeDeg, longitudeDeg, altitudeKm);
         } else {

package/src/LaunchNominalClass.js

@@ -54,7 +54,6 @@ class LaunchNominalClass {
         let bearingRad = degreesToRadians(bearingDeg);
         bearingRad = wrapOneRevUnsigned(bearingRad);
 
-        // const latRad = degreesToRadians(this.groundSiteLat);
         const latRad = llaVals.Latitude.Radians;
         const targetInclination = OrbitUtils.getInclination(bearingRad, latRad);
 
@@ -77,19 +76,6 @@ class LaunchNominalClass {
         );
         // Trying something here
 
-        // const transformMatrix = FrameConverter.j2000ToTEME(orbitInsertionTime);
-        // const initialTemeState = {
-        //     position: this.transformVector(
-        //         new Vector3D(initialStateVector.position[0],
-        //             initialStateVector.position[1], initialStateVector.position[2]),
-        //         transformMatrix
-        //     ),
-        //     velocity: this.transformVector(
-        //         new Vector3D(initialStateVector.velocity[0],
-        //             initialStateVector.velocity[1], initialStateVector.velocity[2]),
-        //         transformMatrix
-        //     ),
-        // };
 
         // End of something
         const initialJ2000State = new J2000(
@@ -352,7 +338,7 @@ class LaunchNominalClass {
      */
     static generateStateOverGroundsite(
         orbitInsertionTime, azimuthDeg, orbitAltitudeKm, frame = ReferenceFrame.J2000, llaVals) {
-        const minAltitudeKm = 1.0; // minimum launch altitude. Lowest recoded is about 440m.
+        const minAltitudeKm = 1; // minimum launch altitude. Lowest recoded is about 440m.
         if (orbitAltitudeKm < minAltitudeKm) {
             throw new Error(`Altitude cannot be less than ${minAltitudeKm} km.`);
         }
@@ -392,7 +378,7 @@ class LaunchNominalClass {
         const r = siteJ2000.scale(scaleFactor);
 
         // North vector rotated by azimuth along nadir vector scaled by the velocity of a circular orbit
-        const rLength = Math.sqrt(r.x * r.x + r.y * r.y + r.z * r.z);
+        const rLength = Math.hypot(r.x, r.y, r.z);
         const velocityMagnitude = Math.sqrt(mu / rLength);
         const velocityDirection = FrameConverter.rotateVector(northJ2000, nadirJ2000, azimuthRad);
         const v = velocityDirection.scale(velocityMagnitude);
@@ -424,10 +410,10 @@ class LaunchNominalClass {
         const v0 = [stateAtM1.velocity.x, stateAtM1.velocity.y, stateAtM1.velocity.z];
         const r0mag = norm(r0);
         const v0mag = norm(v0);
-        const r1 = r0.map((component) => component * -1.0 * targetSMA / r0mag);
+        const r1 = r0.map((component) => component * -1 * targetSMA / r0mag);
         const r1mag = norm(r1);
         const v1mag = Math.sqrt(mu / targetSMA);
-        const v1 = v0.map((component) => component * -1.0 * v1mag / v0mag);
+        const v1 = v0.map((component) => component * -1 * v1mag / v0mag);
 
         // v0 and v1  unit vectors
         const v0unit = v0.map((component) => component / v0mag);
@@ -493,9 +479,9 @@ class LaunchNominalClass {
 
         if (burnAtNodes % 2 === 0) {
             if (argLat >= 0 && argLat <= 180) {
-                argLat -= 180.0;
+                argLat -= 180;
             } else {
-                argLat += 180.0;
+                argLat += 180;
             }
         }
 
@@ -538,7 +524,7 @@ class LaunchNominalClass {
 
     static #getNextNodeCrossingGeoOrbit(sv) {
         const geoElements = {
-            semiMajorAxis: 35786.0 + EARTH_RADIUS_KM,
+            semiMajorAxis: 35786 + EARTH_RADIUS_KM,
             eccentricity: 0,
             inclination: 0,
             raan: 0,
@@ -556,7 +542,7 @@ class LaunchNominalClass {
     static #findMutualNodeTimes(sv1, sv2, muEarth = MU / 1e9) {
         // Implementation for finding mutual node times between two state vectors
 
-        if (!(sv1.epochUtc === sv2.epochUtc)) {
+        if (sv1.epochUtc !== sv2.epochUtc) {
             return "lol what on earth";
         }
 
@@ -650,8 +636,8 @@ class LaunchNominalClass {
             second = new Date(sv1.epochUtc.getTime() + dt1 * 1000);
         }
 
-        const next = first < second ? first : second;
-        const previous = first < second ? second : first;
+        const next = new Date(Math.min(first.getTime(), second.getTime()));
+        const previous = new Date(Math.max(first.getTime(), second.getTime()));
 
         if (ascendingFirst) {
             return {

package/src/NodeVector3D.js

@@ -36,14 +36,14 @@ class NodeVector3D {
     }
 
     magnitude() {
-        return Math.sqrt(this.x ** 2 + this.y ** 2 + this.z ** 2);
+        return Math.hypot(this.x, this.y, this.z);
     }
 
     distance(vector) {
         const dx = this.x - vector.x;
         const dy = this.y - vector.y;
         const dz = this.z - vector.z;
-        return Math.sqrt(dx ** 2 + dy ** 2 + dz ** 2);
+        return Math.hypot(dx, dy, dz);
     }
 
     toString() {