@renfeng/kiro-code-review 1.9.0

package/dist/services/__tests__/review-utils.service.test.js

@@ -0,0 +1,306 @@
+/**
+ * Tests for ReviewService anchor resolution.
+ *
+ * These tests mock GitToolsService.runGit to supply synthetic diffs,
+ * then verify that resolveAnchors correctly maps anchors to line numbers.
+ */
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { writeFileSync, readFileSync, mkdtempSync, rmSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+import { GeneralService } from '../general.service.js';
+import { GitToolsService } from '../git-tools.service.js';
+import { Logger, LogLevel } from '../../logging/logger.service.js';
+describe('ReviewService.resolveAnchors', () => {
+    let service;
+    let gitTools;
+    let logger;
+    let tmpDir;
+    beforeEach(() => {
+        logger = new Logger('test', LogLevel.ERROR);
+        gitTools = new GitToolsService(logger);
+        service = new GeneralService(logger, gitTools);
+        tmpDir = mkdtempSync(join(tmpdir(), 'resolve-anchors-'));
+    });
+    afterEach(() => {
+        rmSync(tmpDir, { recursive: true, force: true });
+        vi.restoreAllMocks();
+    });
+    function writeFindingsFile(findings) {
+        const path = join(tmpDir, 'findings.json');
+        writeFileSync(path, JSON.stringify(findings, null, 2));
+        return path;
+    }
+    function readFindingsFile(path) {
+        return JSON.parse(readFileSync(path, 'utf-8'));
+    }
+    it('resolves a simple added-line anchor', async () => {
+        const diff = [
+            'diff --git a/file.ts b/file.ts',
+            'index abc1234..def5678 100644',
+            '--- a/file.ts',
+            '+++ b/file.ts',
+            '@@ -1,3 +1,4 @@',
+            ' line one',
+            '+const added = true;',
+            ' line two',
+            ' line three',
+        ].join('\n');
+        vi.spyOn(gitTools, 'runGit').mockResolvedValue(diff);
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: 'file.ts',
+                    hunk: null,
+                    anchor: 'const added = true;',
+                    blocking: true,
+                    note: 'test finding',
+                }],
+            summary: 'test',
+            verdict: 'comment_only',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.resolved).toBe(1);
+        expect(result.fallbackToGeneral).toBe(0);
+        const findings = readFindingsFile(findingsPath);
+        expect(findings.comments[0].changed).toBe('new');
+        expect(findings.comments[0].line).toBe(2);
+    });
+    it('resolves anchor with trailing backslash (line continuation)', async () => {
+        // Reproduces the bug from MR !19 on ai-code-review-kirospace:
+        // The anchor omits the trailing " \" but the actual diff line has it.
+        const diff = [
+            'diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml',
+            'index 0000000..1111111 100644',
+            '--- /dev/null',
+            '+++ b/.gitlab-ci.yml',
+            '@@ -0,0 +1,10 @@',
+            '+    - |',
+            '+      echo "Looking for build artifact..."',
+            '+      PIPELINES=$(curl -sf --header "JOB-TOKEN: ${CI_JOB_TOKEN}" \\',
+            '+        "${CI_API_V4_URL}/projects/${CI_PROJECT_ID}/pipelines")',
+            '+      BUILD_JOB_ID=""',
+        ].join('\n');
+        vi.spyOn(gitTools, 'runGit').mockResolvedValue(diff);
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: '.gitlab-ci.yml',
+                    hunk: null,
+                    anchor: 'PIPELINES=$(curl -sf --header "JOB-TOKEN: ${CI_JOB_TOKEN}"',
+                    blocking: true,
+                    note: 'Silent curl failure',
+                }],
+            summary: 'test',
+            verdict: 'request_changes',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.resolved).toBe(1);
+        expect(result.fallbackToGeneral).toBe(0);
+        const findings = readFindingsFile(findingsPath);
+        expect(findings.comments[0].changed).toBe('new');
+        expect(findings.comments[0].line).toBe(3);
+    });
+    it('resolves anchor on a deleted line with OLD: prefix', async () => {
+        const diff = [
+            'diff --git a/config.ts b/config.ts',
+            'index abc1234..def5678 100644',
+            '--- a/config.ts',
+            '+++ b/config.ts',
+            '@@ -5,4 +5,3 @@',
+            ' keep this',
+            '-const removed = "old";',
+            ' keep that',
+        ].join('\n');
+        vi.spyOn(gitTools, 'runGit').mockResolvedValue(diff);
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: 'config.ts',
+                    hunk: null,
+                    anchor: 'OLD:const removed = "old";',
+                    blocking: false,
+                    note: 'deleted line',
+                }],
+            summary: 'test',
+            verdict: 'comment_only',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.resolved).toBe(1);
+        const findings = readFindingsFile(findingsPath);
+        expect(findings.comments[0].changed).toBe('old');
+        expect(findings.comments[0].old_line).toBe(6);
+    });
+    it('falls back to general when file has no diff', async () => {
+        vi.spyOn(gitTools, 'runGit').mockRejectedValue(new Error('no diff'));
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: 'missing.ts',
+                    hunk: null,
+                    anchor: 'some content',
+                    blocking: true,
+                    note: 'no diff available',
+                }],
+            summary: 'test',
+            verdict: 'comment_only',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.fallbackToGeneral).toBe(1);
+        const findings = readFindingsFile(findingsPath);
+        expect(findings.comments[0].changed).toBe('general');
+    });
+    it('skips comments already marked as general', async () => {
+        vi.spyOn(gitTools, 'runGit');
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: 'file.ts',
+                    hunk: null,
+                    anchor: 'something',
+                    changed: 'general',
+                    blocking: true,
+                    note: 'already general',
+                }],
+            summary: 'test',
+            verdict: 'comment_only',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.resolved).toBe(0);
+        expect(result.fallbackToGeneral).toBe(0);
+        expect(gitTools.runGit).not.toHaveBeenCalled();
+    });
+    it('resolves anchor using hunk header when provided', async () => {
+        const diff = [
+            'diff --git a/app.ts b/app.ts',
+            'index abc..def 100644',
+            '--- a/app.ts',
+            '+++ b/app.ts',
+            '@@ -1,3 +1,4 @@',
+            ' first section',
+            '+const x = 1;',
+            ' end first',
+            '@@ -10,3 +11,4 @@',
+            ' second section',
+            '+const x = 1;',
+            ' end second',
+        ].join('\n');
+        vi.spyOn(gitTools, 'runGit').mockResolvedValue(diff);
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: 'app.ts',
+                    hunk: '@@ -10,3 +11,4 @@',
+                    anchor: 'const x = 1;',
+                    blocking: true,
+                    note: 'targets second hunk',
+                }],
+            summary: 'test',
+            verdict: 'comment_only',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.resolved).toBe(1);
+        const findings = readFindingsFile(findingsPath);
+        expect(findings.comments[0].line).toBe(12);
+    });
+    it('falls back to all hunks when anchor is in a different hunk than specified', async () => {
+        // Reproduces the bug from MR !25863 on my-project:
+        // The LLM associated the anchor with hunk @@ -1,4 +1,7 @@ but the anchor
+        // line was actually in hunk @@ -10,5 +13,13 @@. The old code restricted
+        // search to the matched hunk and fell back to general when not found.
+        const diff = [
+            'diff --git a/app.routes.ts b/app.routes.ts',
+            'index abc..def 100644',
+            '--- a/app.routes.ts',
+            '+++ b/app.routes.ts',
+            '@@ -1,4 +1,7 @@',
+            '+import { inject } from \'@angular/core\';',
+            ' import { Route } from \'@angular/router\';',
+            '+import { SmeTransferFormService } from \'./services/sme-transfer-form.service\';',
+            '+import { SmeTransferFormRouteEnum } from \'./enum/sme-transfer-form-page.enum\';',
+            ' import { ContractSelectionComponent } from \'./contract-selection/contract-selection.component\';',
+            '@@ -10,5 +13,13 @@',
+            '     loadComponent: () =>',
+            '       import(\'./customer-information-form/customer-information-form.component\').then((m) => m.CustomerInformationFormComponent),',
+            '+    canActivate: [() => inject(SmeTransferFormService).canActivate()],',
+            '+  },',
+            '+  {',
+            '+    path: SmeTransferFormRouteEnum.NO_ACCESS,',
+        ].join('\n');
+        vi.spyOn(gitTools, 'runGit').mockResolvedValue(diff);
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: 'app.routes.ts',
+                    hunk: '@@ -1,4 +1,7 @@', // Wrong hunk — anchor is in the second hunk
+                    anchor: 'canActivate: [() => inject(SmeTransferFormService).canActivate()],',
+                    blocking: true,
+                    note: 'guard only protects one route',
+                }],
+            summary: 'test',
+            verdict: 'request_changes',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.resolved).toBe(1);
+        expect(result.fallbackToGeneral).toBe(0);
+        const findings = readFindingsFile(findingsPath);
+        expect(findings.comments[0].changed).toBe('new');
+        expect(findings.comments[0].line).toBe(15);
+    });
+    it('resolves context line anchor (unchanged line)', async () => {
+        const diff = [
+            'diff --git a/file.ts b/file.ts',
+            'index abc..def 100644',
+            '--- a/file.ts',
+            '+++ b/file.ts',
+            '@@ -5,4 +5,5 @@',
+            ' const existing = true;',
+            '+const added = false;',
+            ' const another = 42;',
+        ].join('\n');
+        vi.spyOn(gitTools, 'runGit').mockResolvedValue(diff);
+        const findingsPath = writeFindingsFile({
+            comments: [{
+                    file: 'file.ts',
+                    hunk: null,
+                    anchor: 'const existing = true;',
+                    blocking: false,
+                    note: 'context line',
+                }],
+            summary: 'test',
+            verdict: 'comment_only',
+        });
+        const result = await service.resolveAnchors({
+            repoDir: '/fake/repo',
+            mergeBase: 'abc123',
+            findingsPath,
+        });
+        expect(result.resolved).toBe(1);
+        const findings = readFindingsFile(findingsPath);
+        expect(findings.comments[0].changed).toBe('context');
+        expect(findings.comments[0].line).toBe(5);
+        expect(findings.comments[0].old_line).toBe(5);
+    });
+});
+//# sourceMappingURL=review-utils.service.test.js.map

package/dist/services/__tests__/review-utils.service.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-utils.service.test.js","sourceRoot":"","sources":["../../../src/services/__tests__/review-utils.service.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,aAAa,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,IAAI,CAAC;AACtE,OAAO,EAAE,IAAI,EAAE,MAAM,MAAM,CAAC;AAC5B,OAAO,EAAE,MAAM,EAAE,MAAM,IAAI,CAAC;AAC5B,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AACvD,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAC1D,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,iCAAiC,CAAC;AAGnE,QAAQ,CAAC,8BAA8B,EAAE,GAAG,EAAE;IAC5C,IAAI,OAAuB,CAAC;IAC5B,IAAI,QAAyB,CAAC;IAC9B,IAAI,MAAc,CAAC;IACnB,IAAI,MAAc,CAAC;IAEnB,UAAU,CAAC,GAAG,EAAE;QACd,MAAM,GAAG,IAAI,MAAM,CAAC,MAAM,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC;QAC5C,QAAQ,GAAG,IAAI,eAAe,CAAC,MAAM,CAAC,CAAC;QACvC,OAAO,GAAG,IAAI,cAAc,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC;QAC/C,MAAM,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,kBAAkB,CAAC,CAAC,CAAC;IAC3D,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,MAAM,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QACjD,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,SAAS,iBAAiB,CAAC,QAAsB;QAC/C,MAAM,IAAI,GAAG,IAAI,CAAC,MAAM,EAAE,eAAe,CAAC,CAAC;QAC3C,aAAa,CAAC,IAAI,EAAE,IAAI,CAAC,SAAS,CAAC,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;QACvD,OAAO,IAAI,CAAC;IACd,CAAC;IAED,SAAS,gBAAgB,CAAC,IAAY;QACpC,OAAO,IAAI,CAAC,KAAK,CAAC,YAAY,CAAC,IAAI,EAAE,OAAO,CAAC,CAAC,CAAC;IACjD,CAAC;IAED,EAAE,CAAC,qCAAqC,EAAE,KAAK,IAAI,EAAE;QACnD,MAAM,IAAI,GAAG;YACX,gCAAgC;YAChC,+BAA+B;YAC/B,eAAe;YACf,eAAe;YACf,iBAAiB;YACjB,WAAW;YACX,sBAAsB;YACtB,WAAW;YACX,aAAa;SACd,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAErD,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,SAAS;oBACf,IAAI,EAAE,IAAI;oBACV,MAAM,EAAE,qBAAqB;oBAC7B,QAAQ,EAAE,IAAI;oBACd,IAAI,EAAE,cAAc;iBACrB,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,cAAc;SACxB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAEzC,MAAM,QAAQ,GAAG,gBAAgB,CAAC,YAAY,CAAC,CAAC;QAChD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;QAC3E,8DAA8D;QAC9D,sEAAsE;QACtE,MAAM,IAAI,GAAG;YACX,8CAA8C;YAC9C,+BAA+B;YAC/B,eAAe;YACf,sBAAsB;YACtB,kBAAkB;YAClB,UAAU;YACV,6CAA6C;YAC7C,sEAAsE;YACtE,kEAAkE;YAClE,wBAAwB;SACzB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAErD,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,gBAAgB;oBACtB,IAAI,EAAE,IAAI;oBACV,MAAM,EAAE,4DAA4D;oBACpE,QAAQ,EAAE,IAAI;oBACd,IAAI,EAAE,qBAAqB;iBAC5B,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,iBAAiB;SAC3B,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAEzC,MAAM,QAAQ,GAAG,gBAAgB,CAAC,YAAY,CAAC,CAAC;QAChD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAClE,MAAM,IAAI,GAAG;YACX,oCAAoC;YACpC,+BAA+B;YAC/B,iBAAiB;YACjB,iBAAiB;YACjB,iBAAiB;YACjB,YAAY;YACZ,yBAAyB;YACzB,YAAY;SACb,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAErD,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,WAAW;oBACjB,IAAI,EAAE,IAAI;oBACV,MAAM,EAAE,4BAA4B;oBACpC,QAAQ,EAAE,KAAK;oBACf,IAAI,EAAE,cAAc;iBACrB,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,cAAc;SACxB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,QAAQ,GAAG,gBAAgB,CAAC,YAAY,CAAC,CAAC;QAChD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAChD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6CAA6C,EAAE,KAAK,IAAI,EAAE;QAC3D,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,IAAI,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC;QAErE,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,YAAY;oBAClB,IAAI,EAAE,IAAI;oBACV,MAAM,EAAE,cAAc;oBACtB,QAAQ,EAAE,IAAI;oBACd,IAAI,EAAE,mBAAmB;iBAC1B,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,cAAc;SACxB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACzC,MAAM,QAAQ,GAAG,gBAAgB,CAAC,YAAY,CAAC,CAAC;QAChD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;IACvD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0CAA0C,EAAE,KAAK,IAAI,EAAE;QACxD,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC;QAE7B,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,SAAS;oBACf,IAAI,EAAE,IAAI;oBACV,MAAM,EAAE,WAAW;oBACnB,OAAO,EAAE,SAAS;oBAClB,QAAQ,EAAE,IAAI;oBACd,IAAI,EAAE,iBAAiB;iBACxB,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,cAAc;SACxB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACzC,MAAM,CAAC,QAAQ,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,IAAI,GAAG;YACX,8BAA8B;YAC9B,uBAAuB;YACvB,cAAc;YACd,cAAc;YACd,iBAAiB;YACjB,gBAAgB;YAChB,eAAe;YACf,YAAY;YACZ,mBAAmB;YACnB,iBAAiB;YACjB,eAAe;YACf,aAAa;SACd,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAErD,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,QAAQ;oBACd,IAAI,EAAE,mBAAmB;oBACzB,MAAM,EAAE,cAAc;oBACtB,QAAQ,EAAE,IAAI;oBACd,IAAI,EAAE,qBAAqB;iBAC5B,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,cAAc;SACxB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,QAAQ,GAAG,gBAAgB,CAAC,YAAY,CAAC,CAAC;QAChD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,KAAK,IAAI,EAAE;QACzF,mDAAmD;QACnD,yEAAyE;QACzE,wEAAwE;QACxE,sEAAsE;QACtE,MAAM,IAAI,GAAG;YACX,4CAA4C;YAC5C,uBAAuB;YACvB,qBAAqB;YACrB,qBAAqB;YACrB,iBAAiB;YACjB,4CAA4C;YAC5C,6CAA6C;YAC7C,mFAAmF;YACnF,mFAAmF;YACnF,oGAAoG;YACpG,oBAAoB;YACpB,2BAA2B;YAC3B,qIAAqI;YACrI,yEAAyE;YACzE,OAAO;YACP,MAAM;YACN,gDAAgD;SACjD,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAErD,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,eAAe;oBACrB,IAAI,EAAE,iBAAiB,EAAG,4CAA4C;oBACtE,MAAM,EAAE,oEAAoE;oBAC5E,QAAQ,EAAE,IAAI;oBACd,IAAI,EAAE,+BAA+B;iBACtC,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,iBAAiB;SAC3B,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,MAAM,CAAC,iBAAiB,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAEzC,MAAM,QAAQ,GAAG,gBAAgB,CAAC,YAAY,CAAC,CAAC;QAChD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACjD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,MAAM,IAAI,GAAG;YACX,gCAAgC;YAChC,uBAAuB;YACvB,eAAe;YACf,eAAe;YACf,iBAAiB;YACjB,yBAAyB;YACzB,uBAAuB;YACvB,sBAAsB;SACvB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAEb,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,IAAI,CAAC,CAAC;QAErD,MAAM,YAAY,GAAG,iBAAiB,CAAC;YACrC,QAAQ,EAAE,CAAC;oBACT,IAAI,EAAE,SAAS;oBACf,IAAI,EAAE,IAAI;oBACV,MAAM,EAAE,wBAAwB;oBAChC,QAAQ,EAAE,KAAK;oBACf,IAAI,EAAE,cAAc;iBACrB,CAAC;YACF,OAAO,EAAE,MAAM;YACf,OAAO,EAAE,cAAc;SACxB,CAAC,CAAC;QAEH,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,SAAS,EAAE,QAAQ;YACnB,YAAY;SACb,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,QAAQ,GAAG,gBAAgB,CAAC,YAAY,CAAC,CAAC;QAChD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACrD,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAC1C,MAAM,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAChD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/services/anchor-resolver.d.ts

@@ -0,0 +1,29 @@
+/**
+ * Anchor Resolver
+ *
+ * Shared anchor resolution logic extracted from GeneralService.
+ * Maps LLM-produced text anchors to diff line numbers.
+ * Used by both GeneralService.resolveAnchors (file-based pipeline)
+ * and ReviewToolsService.postDraftNotes (inline resolution).
+ */
+import type { AnchorFinding } from '../types.js';
+export interface ParsedHunk {
+    header: string;
+    oldStart: number;
+    newStart: number;
+    lines: string[];
+}
+export interface AnchorResult {
+    changed: 'new' | 'old' | 'context';
+    line?: number | null;
+    old_line?: number | null;
+}
+/**
+ * Resolve an anchor to a line number within a raw diff string.
+ * Returns null if the anchor cannot be matched.
+ */
+export declare function resolveAnchorInDiff(diff: string, comment: AnchorFinding): AnchorResult | null;
+export declare function parseHunks(diff: string): ParsedHunk[];
+export declare function findMatchingHunk(hunks: ParsedHunk[], hunkHeader: string): ParsedHunk | null;
+export declare function findAnchorInHunk(hunk: ParsedHunk, anchorText: string, isOldAnchor: boolean): AnchorResult | null;
+//# sourceMappingURL=anchor-resolver.d.ts.map

package/dist/services/anchor-resolver.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"anchor-resolver.d.ts","sourceRoot":"","sources":["../../src/services/anchor-resolver.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAEH,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAEjD,MAAM,WAAW,UAAU;IACzB,MAAM,EAAE,MAAM,CAAC;IACf,QAAQ,EAAE,MAAM,CAAC;IACjB,QAAQ,EAAE,MAAM,CAAC;IACjB,KAAK,EAAE,MAAM,EAAE,CAAC;CACjB;AAED,MAAM,WAAW,YAAY;IAC3B,OAAO,EAAE,KAAK,GAAG,KAAK,GAAG,SAAS,CAAC;IACnC,IAAI,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;IACrB,QAAQ,CAAC,EAAE,MAAM,GAAG,IAAI,CAAC;CAC1B;AAED;;;GAGG;AACH,wBAAgB,mBAAmB,CACjC,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,aAAa,GACnC,YAAY,GAAG,IAAI,CAqBrB;AAED,wBAAgB,UAAU,CAAC,IAAI,EAAE,MAAM,GAAG,UAAU,EAAE,CAsBrD;AAED,wBAAgB,gBAAgB,CAAC,KAAK,EAAE,UAAU,EAAE,EAAE,UAAU,EAAE,MAAM,GAAG,UAAU,GAAG,IAAI,CAM3F;AAED,wBAAgB,gBAAgB,CAC9B,IAAI,EAAE,UAAU,EAAE,UAAU,EAAE,MAAM,EAAE,WAAW,EAAE,OAAO,GACzD,YAAY,GAAG,IAAI,CAyBrB"}

package/dist/services/anchor-resolver.js

@@ -0,0 +1,97 @@
+/**
+ * Anchor Resolver
+ *
+ * Shared anchor resolution logic extracted from GeneralService.
+ * Maps LLM-produced text anchors to diff line numbers.
+ * Used by both GeneralService.resolveAnchors (file-based pipeline)
+ * and ReviewToolsService.postDraftNotes (inline resolution).
+ */
+/**
+ * Resolve an anchor to a line number within a raw diff string.
+ * Returns null if the anchor cannot be matched.
+ */
+export function resolveAnchorInDiff(diff, comment) {
+    const rawAnchor = comment.anchor;
+    const isOldAnchor = rawAnchor.startsWith('OLD:');
+    const anchorText = (isOldAnchor ? rawAnchor.slice(4) : rawAnchor).trim().replace(/\s*\\$/, '');
+    const hunks = parseHunks(diff);
+    const targetHunk = comment.hunk ? findMatchingHunk(hunks, comment.hunk) : null;
+    // Try the matched hunk first, then fall back to all hunks.
+    // The LLM sometimes associates the correct anchor with the wrong hunk header.
+    if (targetHunk) {
+        const result = findAnchorInHunk(targetHunk, anchorText, isOldAnchor);
+        if (result)
+            return result;
+    }
+    for (const hunk of hunks) {
+        if (hunk === targetHunk)
+            continue;
+        const result = findAnchorInHunk(hunk, anchorText, isOldAnchor);
+        if (result)
+            return result;
+    }
+    return null;
+}
+export function parseHunks(diff) {
+    const lines = diff.split('\n');
+    const hunks = [];
+    let current = null;
+    for (const line of lines) {
+        const hunkMatch = line.match(/^@@\s+-(\d+)(?:,\d+)?\s+\+(\d+)(?:,\d+)?\s+@@/);
+        if (hunkMatch) {
+            current = {
+                header: line,
+                oldStart: parseInt(hunkMatch[1], 10),
+                newStart: parseInt(hunkMatch[2], 10),
+                lines: [],
+            };
+            hunks.push(current);
+            continue;
+        }
+        if (current && (line.startsWith('+') || line.startsWith('-') || line.startsWith(' '))) {
+            current.lines.push(line);
+        }
+    }
+    return hunks;
+}
+export function findMatchingHunk(hunks, hunkHeader) {
+    const m = hunkHeader.match(/^@@\s+-(\d+)(?:,\d+)?\s+\+(\d+)(?:,\d+)?\s+@@/);
+    if (!m)
+        return null;
+    const targetOld = parseInt(m[1], 10);
+    const targetNew = parseInt(m[2], 10);
+    return hunks.find(h => h.oldStart === targetOld && h.newStart === targetNew) || null;
+}
+export function findAnchorInHunk(hunk, anchorText, isOldAnchor) {
+    const passes = isOldAnchor
+        ? [{ prefixes: ['-'] }]
+        : [{ prefixes: ['+'] }, { prefixes: [' '] }];
+    for (const pass of passes) {
+        let oldLine = hunk.oldStart;
+        let newLine = hunk.newStart;
+        for (const line of hunk.lines) {
+            const prefix = line[0];
+            const content = line.slice(1).trim().replace(/\s*\\$/, '');
+            if (pass.prefixes.includes(prefix) && content === anchorText) {
+                if (prefix === '+')
+                    return { changed: 'new', line: newLine };
+                if (prefix === '-')
+                    return { changed: 'old', old_line: oldLine };
+                if (prefix === ' ')
+                    return { changed: 'context', line: newLine, old_line: oldLine };
+            }
+            if (prefix === '+') {
+                newLine++;
+            }
+            else if (prefix === '-') {
+                oldLine++;
+            }
+            else {
+                oldLine++;
+                newLine++;
+            }
+        }
+    }
+    return null;
+}
+//# sourceMappingURL=anchor-resolver.js.map

package/dist/services/anchor-resolver.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"anchor-resolver.js","sourceRoot":"","sources":["../../src/services/anchor-resolver.ts"],"names":[],"mappings":"AAAA;;;;;;;GAOG;AAiBH;;;GAGG;AACH,MAAM,UAAU,mBAAmB,CACjC,IAAY,EAAE,OAAsB;IAEpC,MAAM,SAAS,GAAG,OAAO,CAAC,MAAO,CAAC;IAClC,MAAM,WAAW,GAAG,SAAS,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC;IACjD,MAAM,UAAU,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,IAAI,EAAE,CAAC,OAAO,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC;IAE/F,MAAM,KAAK,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC;IAC/B,MAAM,UAAU,GAAG,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,gBAAgB,CAAC,KAAK,EAAE,OAAO,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;IAE/E,2DAA2D;IAC3D,8EAA8E;IAC9E,IAAI,UAAU,EAAE,CAAC;QACf,MAAM,MAAM,GAAG,gBAAgB,CAAC,UAAU,EAAE,UAAU,EAAE,WAAW,CAAC,CAAC;QACrE,IAAI,MAAM;YAAE,OAAO,MAAM,CAAC;IAC5B,CAAC;IAED,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,IAAI,IAAI,KAAK,UAAU;YAAE,SAAS;QAClC,MAAM,MAAM,GAAG,gBAAgB,CAAC,IAAI,EAAE,UAAU,EAAE,WAAW,CAAC,CAAC;QAC/D,IAAI,MAAM;YAAE,OAAO,MAAM,CAAC;IAC5B,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC;AAED,MAAM,UAAU,UAAU,CAAC,IAAY;IACrC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAC/B,MAAM,KAAK,GAAiB,EAAE,CAAC;IAC/B,IAAI,OAAO,GAAsB,IAAI,CAAC;IAEtC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,MAAM,SAAS,GAAG,IAAI,CAAC,KAAK,CAAC,+CAA+C,CAAC,CAAC;QAC9E,IAAI,SAAS,EAAE,CAAC;YACd,OAAO,GAAG;gBACR,MAAM,EAAE,IAAI;gBACZ,QAAQ,EAAE,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;gBACpC,QAAQ,EAAE,QAAQ,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC;gBACpC,KAAK,EAAE,EAAE;aACV,CAAC;YACF,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;YACpB,SAAS;QACX,CAAC;QACD,IAAI,OAAO,IAAI,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC;YACtF,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3B,CAAC;IACH,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,MAAM,UAAU,gBAAgB,CAAC,KAAmB,EAAE,UAAkB;IACtE,MAAM,CAAC,GAAG,UAAU,CAAC,KAAK,CAAC,+CAA+C,CAAC,CAAC;IAC5E,IAAI,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IACpB,MAAM,SAAS,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IACrC,MAAM,SAAS,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IACrC,OAAO,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,IAAI,CAAC,CAAC,QAAQ,KAAK,SAAS,CAAC,IAAI,IAAI,CAAC;AACvF,CAAC;AAED,MAAM,UAAU,gBAAgB,CAC9B,IAAgB,EAAE,UAAkB,EAAE,WAAoB;IAE1D,MAAM,MAAM,GAAkC,WAAW;QACvD,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,CAAC,GAAG,CAAC,EAAE,CAAC;QACvB,CAAC,CAAC,CAAC,EAAE,QAAQ,EAAE,CAAC,GAAG,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC;IAE/C,KAAK,MAAM,IAAI,IAAI,MAAM,EAAE,CAAC;QAC1B,IAAI,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC;QAC5B,IAAI,OAAO,GAAG,IAAI,CAAC,QAAQ,CAAC;QAE5B,KAAK,MAAM,IAAI,IAAI,IAAI,CAAC,KAAK,EAAE,CAAC;YAC9B,MAAM,MAAM,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACvB,MAAM,OAAO,GAAG,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,OAAO,CAAC,QAAQ,EAAE,EAAE,CAAC,CAAC;YAE3D,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,OAAO,KAAK,UAAU,EAAE,CAAC;gBAC7D,IAAI,MAAM,KAAK,GAAG;oBAAE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,OAAO,EAAE,CAAC;gBAC7D,IAAI,MAAM,KAAK,GAAG;oBAAE,OAAO,EAAE,OAAO,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,CAAC;gBACjE,IAAI,MAAM,KAAK,GAAG;oBAAE,OAAO,EAAE,OAAO,EAAE,SAAS,EAAE,IAAI,EAAE,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAE,CAAC;YACtF,CAAC;YAED,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;gBAAC,OAAO,EAAE,CAAC;YAAC,CAAC;iBAC7B,IAAI,MAAM,KAAK,GAAG,EAAE,CAAC;gBAAC,OAAO,EAAE,CAAC;YAAC,CAAC;iBAClC,CAAC;gBAAC,OAAO,EAAE,CAAC;gBAAC,OAAO,EAAE,CAAC;YAAC,CAAC;QAChC,CAAC;IACH,CAAC;IACD,OAAO,IAAI,CAAC;AACd,CAAC"}

package/dist/services/general.service.d.ts

@@ -0,0 +1,42 @@
+/**
+ * Review Service
+ *
+ * Platform-neutral review utilities — findings normalization, anchor resolution,
+ * and draft staleness checks.
+ * Uses git CLI (via GitToolsService) for diff/show operations. No GitLab API.
+ */
+import { Logger } from '../logging/logger.service.js';
+import type { ResolveAnchorsParams, CheckDraftStalenessParams, DraftStalenessResult, WriteFindingsParams, SavePerFileDiffsParams } from '../types.js';
+import { GitToolsService } from './git-tools.service.js';
+export declare class GeneralService {
+    private logger;
+    private gitTools;
+    constructor(logger: Logger, gitTools: GitToolsService);
+    private normalizeFindingsNotes;
+    writeFindings(params: WriteFindingsParams): Promise<{
+        path: string;
+        commentCount: number;
+        normalized: number;
+    }>;
+    resolveAnchors(params: ResolveAnchorsParams): Promise<{
+        resolved: number;
+        fallbackToGeneral: number;
+        total: number;
+    }>;
+    checkDraftStaleness(params: CheckDraftStalenessParams): Promise<{
+        results: DraftStalenessResult[];
+        staleCount: number;
+        freshCount: number;
+    }>;
+    savePerFileDiffs(params: SavePerFileDiffsParams): Promise<{
+        files: string[];
+        totalFiles: number;
+        errors: Array<{
+            file: string;
+            error: string;
+        }>;
+    }>;
+    private getFileDiff;
+    private getFileLines;
+}
+//# sourceMappingURL=general.service.d.ts.map

package/dist/services/general.service.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"general.service.d.ts","sourceRoot":"","sources":["../../src/services/general.service.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAIH,OAAO,EAAE,MAAM,EAAE,MAAM,8BAA8B,CAAC;AACtD,OAAO,KAAK,EACV,oBAAoB,EACpB,yBAAyB,EAEzB,oBAAoB,EACpB,mBAAmB,EACnB,sBAAsB,EACvB,MAAM,aAAa,CAAC;AACrB,OAAO,EAAE,eAAe,EAAE,MAAM,wBAAwB,CAAC;AAGzD,qBAAa,cAAc;IACzB,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,QAAQ,CAAkB;gBAEtB,MAAM,EAAE,MAAM,EAAE,QAAQ,EAAE,eAAe;IAKrD,OAAO,CAAC,sBAAsB;IAaxB,aAAa,CAAC,MAAM,EAAE,mBAAmB,GAAG,OAAO,CAAC;QACxD,IAAI,EAAE,MAAM,CAAC;QACb,YAAY,EAAE,MAAM,CAAC;QACrB,UAAU,EAAE,MAAM,CAAC;KACpB,CAAC;IAWI,cAAc,CAAC,MAAM,EAAE,oBAAoB,GAAG,OAAO,CAAC;QAC1D,QAAQ,EAAE,MAAM,CAAC;QACjB,iBAAiB,EAAE,MAAM,CAAC;QAC1B,KAAK,EAAE,MAAM,CAAC;KACf,CAAC;IAwCI,mBAAmB,CAAC,MAAM,EAAE,yBAAyB,GAAG,OAAO,CAAC;QACpE,OAAO,EAAE,oBAAoB,EAAE,CAAC;QAChC,UAAU,EAAE,MAAM,CAAC;QACnB,UAAU,EAAE,MAAM,CAAC;KACpB,CAAC;IAiCI,gBAAgB,CAAC,MAAM,EAAE,sBAAsB,GAAG,OAAO,CAAC;QAC9D,KAAK,EAAE,MAAM,EAAE,CAAC;QAChB,UAAU,EAAE,MAAM,CAAC;QACnB,MAAM,EAAE,KAAK,CAAC;YAAE,IAAI,EAAE,MAAM,CAAC;YAAC,KAAK,EAAE,MAAM,CAAA;SAAE,CAAC,CAAC;KAChD,CAAC;YAkCY,WAAW;YAaX,YAAY;CAc3B"}

package/dist/services/general.service.js

@@ -0,0 +1,157 @@
+/**
+ * Review Service
+ *
+ * Platform-neutral review utilities — findings normalization, anchor resolution,
+ * and draft staleness checks.
+ * Uses git CLI (via GitToolsService) for diff/show operations. No GitLab API.
+ */
+import { readFileSync, writeFileSync, mkdirSync } from 'fs';
+import { join, dirname } from 'path';
+import { resolveAnchorInDiff } from './anchor-resolver.js';
+export class GeneralService {
+    logger;
+    gitTools;
+    constructor(logger, gitTools) {
+        this.logger = logger;
+        this.gitTools = gitTools;
+    }
+    normalizeFindingsNotes(findings) {
+        let normalized = 0;
+        for (const c of findings.comments) {
+            const raw = c;
+            if (!c.note && raw['comment']) {
+                c.note = raw['comment'];
+                normalized++;
+            }
+            delete raw['comment'];
+        }
+        return normalized;
+    }
+    async writeFindings(params) {
+        this.logger.info('Writing findings', { findingsPath: params.findingsPath });
+        const findings = params.findings;
+        const normalized = this.normalizeFindingsNotes(findings);
+        writeFileSync(params.findingsPath, JSON.stringify(findings, null, 2));
+        this.logger.info('Findings written', {
+            path: params.findingsPath, commentCount: findings.comments.length, normalized,
+        });
+        return { path: params.findingsPath, commentCount: findings.comments.length, normalized };
+    }
+    async resolveAnchors(params) {
+        this.logger.info('Resolving anchors', {
+            repoDir: params.repoDir, mergeBase: params.mergeBase, findingsPath: params.findingsPath,
+        });
+        const raw = readFileSync(params.findingsPath, 'utf-8');
+        const findings = JSON.parse(raw);
+        this.normalizeFindingsNotes(findings);
+        const diffCache = new Map();
+        let resolved = 0;
+        let fallbackToGeneral = 0;
+        for (const comment of findings.comments) {
+            if (!comment.file || !comment.anchor || comment.changed === 'general')
+                continue;
+            const fileDiff = await this.getFileDiff(params.repoDir, params.mergeBase, comment.file, diffCache);
+            if (!fileDiff) {
+                comment.changed = 'general';
+                fallbackToGeneral++;
+                continue;
+            }
+            const result = resolveAnchorInDiff(fileDiff, comment);
+            if (result) {
+                comment.changed = result.changed;
+                comment.line = result.line;
+                comment.old_line = result.old_line;
+                resolved++;
+            }
+            else {
+                comment.changed = 'general';
+                fallbackToGeneral++;
+            }
+        }
+        writeFileSync(params.findingsPath, JSON.stringify(findings, null, 2));
+        this.logger.info('Anchor resolution complete', { resolved, fallbackToGeneral, total: findings.comments.length });
+        return { resolved, fallbackToGeneral, total: findings.comments.length };
+    }
+    async checkDraftStaleness(params) {
+        this.logger.info('Checking draft staleness', { repoDir: params.repoDir, draftCount: params.drafts.length });
+        const results = [];
+        const fileCache = new Map();
+        for (const draft of params.drafts) {
+            if (!draft.file || draft.line == null) {
+                results.push({ id: draft.id, stale: false, reason: 'general comment (no file/line)' });
+                continue;
+            }
+            const lines = await this.getFileLines(params.repoDir, draft.file, fileCache);
+            if (!lines) {
+                results.push({ id: draft.id, stale: true, reason: `file no longer exists: ${draft.file}` });
+                continue;
+            }
+            const lineIdx = draft.line - 1;
+            if (lineIdx < 0 || lineIdx >= lines.length) {
+                results.push({ id: draft.id, stale: true, reason: `line ${draft.line} out of range (file has ${lines.length} lines)` });
+                continue;
+            }
+            results.push({ id: draft.id, stale: false, reason: 'line exists in current file' });
+        }
+        const staleCount = results.filter(r => r.stale).length;
+        const freshCount = results.filter(r => !r.stale).length;
+        this.logger.info('Draft staleness check complete', { staleCount, freshCount });
+        return { results, staleCount, freshCount };
+    }
+    async savePerFileDiffs(params) {
+        this.logger.info('Saving per-file diffs', {
+            repoDir: params.repoDir, mergeBase: params.mergeBase, outputDir: params.outputDir,
+        });
+        const { diff: nameOnly } = await this.gitTools.diff({
+            repoDir: params.repoDir, base: params.mergeBase, head: 'HEAD', mode: 'name-only',
+        });
+        const files = nameOnly.trim().split('\n').filter(f => f.length > 0);
+        const saved = [];
+        const errors = [];
+        for (const file of files) {
+            try {
+                const { diff } = await this.gitTools.diff({
+                    repoDir: params.repoDir, base: params.mergeBase, head: 'HEAD', mode: 'full', files: [file],
+                });
+                const outputPath = join(params.outputDir, `${file}.diff`);
+                mkdirSync(dirname(outputPath), { recursive: true });
+                writeFileSync(outputPath, diff);
+                saved.push(file);
+            }
+            catch (err) {
+                const message = err instanceof Error ? err.message : String(err);
+                this.logger.warn('Failed to save diff for file', { file, error: message });
+                errors.push({ file, error: message });
+            }
+        }
+        this.logger.info('Per-file diffs saved', { saved: saved.length, errors: errors.length, outputDir: params.outputDir });
+        return { files: saved, totalFiles: saved.length, errors };
+    }
+    // --- Private helpers for git operations ---
+    async getFileDiff(repoDir, mergeBase, filePath, cache) {
+        if (cache.has(filePath))
+            return cache.get(filePath);
+        try {
+            const result = await this.gitTools.runGit(repoDir, ['diff', mergeBase, 'HEAD', '--', filePath]);
+            cache.set(filePath, result);
+            return result;
+        }
+        catch {
+            return null;
+        }
+    }
+    async getFileLines(repoDir, filePath, cache) {
+        if (cache.has(filePath))
+            return cache.get(filePath);
+        try {
+            const content = await this.gitTools.runGit(repoDir, ['show', `HEAD:${filePath}`]);
+            const lines = content.split('\n');
+            cache.set(filePath, lines);
+            return lines;
+        }
+        catch {
+            return null;
+        }
+    }
+}
+//# sourceMappingURL=general.service.js.map