@renfeng/kiro-code-review 1.9.0

package/dist/services/__tests__/general-save-diffs.test.js

@@ -0,0 +1,99 @@
+/**
+ * Tests for GeneralService.savePerFileDiffs and GitToolsService.diff with files param.
+ */
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { readFileSync, mkdtempSync, rmSync, existsSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+import { GeneralService } from '../general.service.js';
+import { GitToolsService } from '../git-tools.service.js';
+import { Logger, LogLevel } from '../../logging/logger.service.js';
+describe('GeneralService.savePerFileDiffs', () => {
+    let service;
+    let gitTools;
+    let logger;
+    let tmpDir;
+    beforeEach(() => {
+        logger = new Logger('test', LogLevel.ERROR);
+        gitTools = new GitToolsService(logger);
+        service = new GeneralService(logger, gitTools);
+        tmpDir = mkdtempSync(join(tmpdir(), 'save-diffs-'));
+    });
+    afterEach(() => {
+        rmSync(tmpDir, { recursive: true, force: true });
+        vi.restoreAllMocks();
+    });
+    it('saves per-file diffs to disk', async () => {
+        const diffSpy = vi.spyOn(gitTools, 'diff');
+        // First call: name-only
+        diffSpy.mockResolvedValueOnce({ diff: 'src/a.ts\nsrc/b.ts\n' });
+        // Per-file diffs
+        diffSpy.mockResolvedValueOnce({ diff: 'diff --git a/src/a.ts b/src/a.ts\n+added line\n' });
+        diffSpy.mockResolvedValueOnce({ diff: 'diff --git a/src/b.ts b/src/b.ts\n-removed line\n' });
+        const outputDir = join(tmpDir, 'diffs');
+        const result = await service.savePerFileDiffs({
+            repoDir: '/fake/repo', mergeBase: 'abc123', outputDir,
+        });
+        expect(result.files).toEqual(['src/a.ts', 'src/b.ts']);
+        expect(result.totalFiles).toBe(2);
+        expect(result.errors).toEqual([]);
+        // Verify files on disk
+        expect(readFileSync(join(outputDir, 'src/a.ts.diff'), 'utf-8')).toContain('+added line');
+        expect(readFileSync(join(outputDir, 'src/b.ts.diff'), 'utf-8')).toContain('-removed line');
+        // Verify diff() was called with correct params
+        expect(diffSpy).toHaveBeenCalledWith({
+            repoDir: '/fake/repo', base: 'abc123', head: 'HEAD', mode: 'name-only',
+        });
+        expect(diffSpy).toHaveBeenCalledWith({
+            repoDir: '/fake/repo', base: 'abc123', head: 'HEAD', mode: 'full', files: ['src/a.ts'],
+        });
+        expect(diffSpy).toHaveBeenCalledWith({
+            repoDir: '/fake/repo', base: 'abc123', head: 'HEAD', mode: 'full', files: ['src/b.ts'],
+        });
+    });
+    it('handles empty diff (no changed files)', async () => {
+        vi.spyOn(gitTools, 'diff').mockResolvedValueOnce({ diff: '\n' });
+        const result = await service.savePerFileDiffs({
+            repoDir: '/fake/repo', mergeBase: 'abc123', outputDir: join(tmpDir, 'diffs'),
+        });
+        expect(result.files).toEqual([]);
+        expect(result.totalFiles).toBe(0);
+        expect(result.errors).toEqual([]);
+    });
+    it('continues on per-file error and reports failures', async () => {
+        const diffSpy = vi.spyOn(gitTools, 'diff');
+        // name-only returns 3 files
+        diffSpy.mockResolvedValueOnce({ diff: 'good.ts\nbad.bin\nalso-good.ts\n' });
+        // good.ts succeeds
+        diffSpy.mockResolvedValueOnce({ diff: 'diff for good.ts' });
+        // bad.bin fails
+        diffSpy.mockRejectedValueOnce(new Error('binary file'));
+        // also-good.ts succeeds
+        diffSpy.mockResolvedValueOnce({ diff: 'diff for also-good.ts' });
+        const outputDir = join(tmpDir, 'diffs');
+        const result = await service.savePerFileDiffs({
+            repoDir: '/fake/repo', mergeBase: 'abc123', outputDir,
+        });
+        expect(result.files).toEqual(['good.ts', 'also-good.ts']);
+        expect(result.totalFiles).toBe(2);
+        expect(result.errors).toEqual([{ file: 'bad.bin', error: 'binary file' }]);
+        // good files saved, bad file not
+        expect(existsSync(join(outputDir, 'good.ts.diff'))).toBe(true);
+        expect(existsSync(join(outputDir, 'bad.bin.diff'))).toBe(false);
+        expect(existsSync(join(outputDir, 'also-good.ts.diff'))).toBe(true);
+    });
+    it('creates nested directories for deep file paths', async () => {
+        const diffSpy = vi.spyOn(gitTools, 'diff');
+        diffSpy.mockResolvedValueOnce({ diff: 'libs/orders/store/src/effects.ts\n' });
+        diffSpy.mockResolvedValueOnce({ diff: 'deep nested diff content' });
+        const outputDir = join(tmpDir, 'diffs');
+        const result = await service.savePerFileDiffs({
+            repoDir: '/fake/repo', mergeBase: 'abc123', outputDir,
+        });
+        expect(result.files).toEqual(['libs/orders/store/src/effects.ts']);
+        const savedPath = join(outputDir, 'libs/orders/store/src/effects.ts.diff');
+        expect(existsSync(savedPath)).toBe(true);
+        expect(readFileSync(savedPath, 'utf-8')).toBe('deep nested diff content');
+    });
+});
+//# sourceMappingURL=general-save-diffs.test.js.map

package/dist/services/__tests__/general-save-diffs.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"general-save-diffs.test.js","sourceRoot":"","sources":["../../../src/services/__tests__/general-save-diffs.test.ts"],"names":[],"mappings":"AAAA;;GAEG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,YAAY,EAAE,WAAW,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,IAAI,CAAC;AACnE,OAAO,EAAE,IAAI,EAAE,MAAM,MAAM,CAAC;AAC5B,OAAO,EAAE,MAAM,EAAE,MAAM,IAAI,CAAC;AAC5B,OAAO,EAAE,cAAc,EAAE,MAAM,uBAAuB,CAAC;AACvD,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAC1D,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,iCAAiC,CAAC;AAEnE,QAAQ,CAAC,iCAAiC,EAAE,GAAG,EAAE;IAC/C,IAAI,OAAuB,CAAC;IAC5B,IAAI,QAAyB,CAAC;IAC9B,IAAI,MAAc,CAAC;IACnB,IAAI,MAAc,CAAC;IAEnB,UAAU,CAAC,GAAG,EAAE;QACd,MAAM,GAAG,IAAI,MAAM,CAAC,MAAM,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC;QAC5C,QAAQ,GAAG,IAAI,eAAe,CAAC,MAAM,CAAC,CAAC;QACvC,OAAO,GAAG,IAAI,cAAc,CAAC,MAAM,EAAE,QAAQ,CAAC,CAAC;QAC/C,MAAM,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,aAAa,CAAC,CAAC,CAAC;IACtD,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,MAAM,CAAC,MAAM,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QACjD,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8BAA8B,EAAE,KAAK,IAAI,EAAE;QAC5C,MAAM,OAAO,GAAG,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAE3C,wBAAwB;QACxB,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,sBAAsB,EAAE,CAAC,CAAC;QAChE,iBAAiB;QACjB,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,iDAAiD,EAAE,CAAC,CAAC;QAC3F,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,mDAAmD,EAAE,CAAC,CAAC;QAE7F,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,gBAAgB,CAAC;YAC5C,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS;SACtD,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,CAAC,UAAU,EAAE,UAAU,CAAC,CAAC,CAAC;QACvD,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QAElC,uBAAuB;QACvB,MAAM,CAAC,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,eAAe,CAAC,EAAE,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,aAAa,CAAC,CAAC;QACzF,MAAM,CAAC,YAAY,CAAC,IAAI,CAAC,SAAS,EAAE,eAAe,CAAC,EAAE,OAAO,CAAC,CAAC,CAAC,SAAS,CAAC,eAAe,CAAC,CAAC;QAE3F,+CAA+C;QAC/C,MAAM,CAAC,OAAO,CAAC,CAAC,oBAAoB,CAAC;YACnC,OAAO,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,WAAW;SACvE,CAAC,CAAC;QACH,MAAM,CAAC,OAAO,CAAC,CAAC,oBAAoB,CAAC;YACnC,OAAO,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC;SACvF,CAAC,CAAC;QACH,MAAM,CAAC,OAAO,CAAC,CAAC,oBAAoB,CAAC;YACnC,OAAO,EAAE,YAAY,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC;SACvF,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,KAAK,IAAI,EAAE;QACrD,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;QAEjE,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,gBAAgB,CAAC;YAC5C,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS,EAAE,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC;SAC7E,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;QACjC,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IACpC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kDAAkD,EAAE,KAAK,IAAI,EAAE;QAChE,MAAM,OAAO,GAAG,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAE3C,4BAA4B;QAC5B,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,kCAAkC,EAAE,CAAC,CAAC;QAC5E,mBAAmB;QACnB,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,kBAAkB,EAAE,CAAC,CAAC;QAC5D,gBAAgB;QAChB,OAAO,CAAC,qBAAqB,CAAC,IAAI,KAAK,CAAC,aAAa,CAAC,CAAC,CAAC;QACxD,wBAAwB;QACxB,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,uBAAuB,EAAE,CAAC,CAAC;QAEjE,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,gBAAgB,CAAC;YAC5C,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS;SACtD,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,CAAC,SAAS,EAAE,cAAc,CAAC,CAAC,CAAC;QAC1D,MAAM,CAAC,MAAM,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAClC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,CAAC,CAAC;QAE3E,iCAAiC;QACjC,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,EAAE,cAAc,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC/D,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,EAAE,cAAc,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChE,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,SAAS,EAAE,mBAAmB,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACtE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;QAC9D,MAAM,OAAO,GAAG,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,MAAM,CAAC,CAAC;QAE3C,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,oCAAoC,EAAE,CAAC,CAAC;QAC9E,OAAO,CAAC,qBAAqB,CAAC,EAAE,IAAI,EAAE,0BAA0B,EAAE,CAAC,CAAC;QAEpE,MAAM,SAAS,GAAG,IAAI,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;QACxC,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,gBAAgB,CAAC;YAC5C,OAAO,EAAE,YAAY,EAAE,SAAS,EAAE,QAAQ,EAAE,SAAS;SACtD,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,CAAC,kCAAkC,CAAC,CAAC,CAAC;QACnE,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,EAAE,uCAAuC,CAAC,CAAC;QAC3E,MAAM,CAAC,UAAU,CAAC,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACzC,MAAM,CAAC,YAAY,CAAC,SAAS,EAAE,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,0BAA0B,CAAC,CAAC;IAC5E,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/services/__tests__/git-diff-files.test.d.ts

@@ -0,0 +1,8 @@
+/**
+ * Tests for GitToolsService.diff with the files parameter.
+ *
+ * Uses a real temp directory for repoDir (to pass path validation),
+ * then mocks runGit to verify correct argument construction.
+ */
+export {};
+//# sourceMappingURL=git-diff-files.test.d.ts.map

package/dist/services/__tests__/git-diff-files.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"git-diff-files.test.d.ts","sourceRoot":"","sources":["../../../src/services/__tests__/git-diff-files.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG"}

package/dist/services/__tests__/git-diff-files.test.js

@@ -0,0 +1,64 @@
+/**
+ * Tests for GitToolsService.diff with the files parameter.
+ *
+ * Uses a real temp directory for repoDir (to pass path validation),
+ * then mocks runGit to verify correct argument construction.
+ */
+import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
+import { mkdtempSync, rmSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+import { GitToolsService } from '../git-tools.service.js';
+import { Logger, LogLevel } from '../../logging/logger.service.js';
+describe('GitToolsService.diff files parameter', () => {
+    let gitTools;
+    let runGitSpy;
+    let repoDir;
+    beforeEach(() => {
+        const logger = new Logger('test', LogLevel.ERROR);
+        gitTools = new GitToolsService(logger);
+        repoDir = mkdtempSync(join(tmpdir(), 'git-diff-test-'));
+        runGitSpy = vi.spyOn(gitTools, 'runGit').mockResolvedValue('mock diff output');
+    });
+    afterEach(() => {
+        rmSync(repoDir, { recursive: true, force: true });
+        vi.restoreAllMocks();
+    });
+    it('appends -- and file paths when files param is provided', async () => {
+        await gitTools.diff({
+            repoDir, base: 'abc123', head: 'HEAD', mode: 'full', files: ['src/a.ts'],
+        });
+        expect(runGitSpy).toHaveBeenCalledWith(repoDir, ['diff', 'abc123', 'HEAD', '--', 'src/a.ts']);
+    });
+    it('appends multiple file paths', async () => {
+        await gitTools.diff({
+            repoDir, base: 'abc123', head: 'HEAD', mode: 'full', files: ['src/a.ts', 'src/b.ts'],
+        });
+        expect(runGitSpy).toHaveBeenCalledWith(repoDir, ['diff', 'abc123', 'HEAD', '--', 'src/a.ts', 'src/b.ts']);
+    });
+    it('does not append -- when files is empty', async () => {
+        await gitTools.diff({
+            repoDir, base: 'abc123', head: 'HEAD', mode: 'full', files: [],
+        });
+        expect(runGitSpy).toHaveBeenCalledWith(repoDir, ['diff', 'abc123', 'HEAD']);
+    });
+    it('does not append -- when files is undefined', async () => {
+        await gitTools.diff({
+            repoDir, base: 'abc123', head: 'HEAD', mode: 'full',
+        });
+        expect(runGitSpy).toHaveBeenCalledWith(repoDir, ['diff', 'abc123', 'HEAD']);
+    });
+    it('combines files with stat mode', async () => {
+        await gitTools.diff({
+            repoDir, base: 'abc123', mode: 'stat', files: ['src/a.ts'],
+        });
+        expect(runGitSpy).toHaveBeenCalledWith(repoDir, ['diff', 'abc123', '--stat', '--', 'src/a.ts']);
+    });
+    it('combines files with name-only mode', async () => {
+        await gitTools.diff({
+            repoDir, base: 'abc123', mode: 'name-only', files: ['src/a.ts'],
+        });
+        expect(runGitSpy).toHaveBeenCalledWith(repoDir, ['diff', 'abc123', '--name-only', '--', 'src/a.ts']);
+    });
+});
+//# sourceMappingURL=git-diff-files.test.js.map

package/dist/services/__tests__/git-diff-files.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"git-diff-files.test.js","sourceRoot":"","sources":["../../../src/services/__tests__/git-diff-files.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AACzE,OAAO,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,IAAI,CAAC;AACzC,OAAO,EAAE,IAAI,EAAE,MAAM,MAAM,CAAC;AAC5B,OAAO,EAAE,MAAM,EAAE,MAAM,IAAI,CAAC;AAC5B,OAAO,EAAE,eAAe,EAAE,MAAM,yBAAyB,CAAC;AAC1D,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,iCAAiC,CAAC;AAEnE,QAAQ,CAAC,sCAAsC,EAAE,GAAG,EAAE;IACpD,IAAI,QAAyB,CAAC;IAC9B,IAAI,SAAsC,CAAC;IAC3C,IAAI,OAAe,CAAC;IAEpB,UAAU,CAAC,GAAG,EAAE;QACd,MAAM,MAAM,GAAG,IAAI,MAAM,CAAC,MAAM,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC;QAClD,QAAQ,GAAG,IAAI,eAAe,CAAC,MAAM,CAAC,CAAC;QACvC,OAAO,GAAG,WAAW,CAAC,IAAI,CAAC,MAAM,EAAE,EAAE,gBAAgB,CAAC,CAAC,CAAC;QACxD,SAAS,GAAG,EAAE,CAAC,KAAK,CAAC,QAAQ,EAAE,QAAQ,CAAC,CAAC,iBAAiB,CAAC,kBAAkB,CAAC,CAAC;IACjF,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,MAAM,CAAC,OAAO,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAClD,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QACtE,MAAM,QAAQ,CAAC,IAAI,CAAC;YAClB,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC;SACzE,CAAC,CAAC;QAEH,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC;IAChG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6BAA6B,EAAE,KAAK,IAAI,EAAE;QAC3C,MAAM,QAAQ,CAAC,IAAI,CAAC;YAClB,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,UAAU,EAAE,UAAU,CAAC;SACrF,CAAC,CAAC;QAEH,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,MAAM,EAAE,QAAQ,EAAE,MAAM,EAAE,IAAI,EAAE,UAAU,EAAE,UAAU,CAAC,CAAC,CAAC;IAC5G,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wCAAwC,EAAE,KAAK,IAAI,EAAE;QACtD,MAAM,QAAQ,CAAC,IAAI,CAAC;YAClB,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,EAAE;SAC/D,CAAC,CAAC;QAEH,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,MAAM,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4CAA4C,EAAE,KAAK,IAAI,EAAE;QAC1D,MAAM,QAAQ,CAAC,IAAI,CAAC;YAClB,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,IAAI,EAAE,MAAM;SACpD,CAAC,CAAC;QAEH,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,MAAM,EAAE,QAAQ,EAAE,MAAM,CAAC,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+BAA+B,EAAE,KAAK,IAAI,EAAE;QAC7C,MAAM,QAAQ,CAAC,IAAI,CAAC;YAClB,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC;SAC3D,CAAC,CAAC;QAEH,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,MAAM,EAAE,QAAQ,EAAE,QAAQ,EAAE,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC;IAClG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,KAAK,IAAI,EAAE;QAClD,MAAM,QAAQ,CAAC,IAAI,CAAC;YAClB,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,WAAW,EAAE,KAAK,EAAE,CAAC,UAAU,CAAC;SAChE,CAAC,CAAC;QAEH,MAAM,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,OAAO,EAAE,CAAC,MAAM,EAAE,QAAQ,EAAE,aAAa,EAAE,IAAI,EAAE,UAAU,CAAC,CAAC,CAAC;IACvG,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/services/__tests__/review-tools.service.test.d.ts

@@ -0,0 +1,8 @@
+/**
+ * Tests for ReviewToolsService.postDraftNotes inline anchor resolution.
+ *
+ * Verifies that when repoDir and mergeBase are provided, anchor-based
+ * findings are resolved to line numbers before posting to GitLab.
+ */
+export {};
+//# sourceMappingURL=review-tools.service.test.d.ts.map

package/dist/services/__tests__/review-tools.service.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-tools.service.test.d.ts","sourceRoot":"","sources":["../../../src/services/__tests__/review-tools.service.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG"}

package/dist/services/__tests__/review-tools.service.test.js

@@ -0,0 +1,169 @@
+/**
+ * Tests for ReviewToolsService.postDraftNotes inline anchor resolution.
+ *
+ * Verifies that when repoDir and mergeBase are provided, anchor-based
+ * findings are resolved to line numbers before posting to GitLab.
+ */
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { ReviewToolsService } from '../review-tools.service.js';
+import { Logger, LogLevel } from '../../logging/logger.service.js';
+// Mock GitLabAPI to capture posted draft notes
+const mockPostDraftNote = vi.fn().mockResolvedValue({ id: 1, line_code: 'abc' });
+const mockDeleteDraftNote = vi.fn().mockResolvedValue({});
+vi.mock('../../api/gitlab-api.js', () => ({
+    GitLabAPI: class MockGitLabAPI {
+        postDraftNote = mockPostDraftNote;
+        deleteDraftNote = mockDeleteDraftNote;
+        constructor() { }
+    },
+}));
+// Mock GitToolsService.runGit to supply synthetic diffs
+vi.mock('../git-tools.service.js', () => ({
+    GitToolsService: class MockGitToolsService {
+        constructor() { }
+        runGit(_repoDir, args) {
+            const filePath = args[args.length - 1];
+            if (filePath === 'file.ts') {
+                return Promise.resolve([
+                    'diff --git a/file.ts b/file.ts',
+                    'index abc..def 100644',
+                    '--- a/file.ts',
+                    '+++ b/file.ts',
+                    '@@ -10,4 +10,5 @@',
+                    ' const existing = true;',
+                    '+const added = false;',
+                    '-const removed = "old";',
+                    ' const kept = 42;',
+                ].join('\n'));
+            }
+            return Promise.reject(new Error('no diff'));
+        }
+    },
+}));
+describe('ReviewToolsService.postDraftNotes anchor resolution', () => {
+    let service;
+    beforeEach(() => {
+        vi.clearAllMocks();
+        const logger = new Logger('test', LogLevel.ERROR);
+        service = new ReviewToolsService(logger);
+    });
+    const baseParams = {
+        project: 'group/repo',
+        mergeRequestIid: 1,
+        headSha: 'head123',
+        baseSha: 'base123',
+        startSha: 'start123',
+        repoDir: '/fake/repo',
+        mergeBase: 'merge-base-sha',
+    };
+    it('resolves anchor-based finding to line number before posting', async () => {
+        const result = await service.postDraftNotes({
+            ...baseParams,
+            findings: {
+                comments: [{
+                        file: 'file.ts',
+                        anchor: 'const added = false;',
+                        blocking: true,
+                        note: 'Review this addition',
+                    }],
+                summary: 'test',
+                verdict: 'request_changes',
+            },
+        }, 'https://gitlab.example.com', 'fake-token');
+        expect(result.posted).toBe(1);
+        expect(result.errors).toHaveLength(0);
+        // Verify the draft was posted with resolved position
+        const postedBody = mockPostDraftNote.mock.calls[0][2];
+        expect(postedBody.position).toBeDefined();
+        expect(postedBody.position.new_line).toBe(11);
+        expect(postedBody.position.old_line).toBeNull();
+    });
+    it('resolves OLD: anchor to old_line', async () => {
+        const result = await service.postDraftNotes({
+            ...baseParams,
+            findings: {
+                comments: [{
+                        file: 'file.ts',
+                        anchor: 'OLD:const removed = "old";',
+                        blocking: true,
+                        note: 'This was removed',
+                    }],
+                summary: 'test',
+                verdict: 'request_changes',
+            },
+        }, 'https://gitlab.example.com', 'fake-token');
+        expect(result.posted).toBe(1);
+        const postedBody = mockPostDraftNote.mock.calls[0][2];
+        expect(postedBody.position).toBeDefined();
+        expect(postedBody.position.old_line).toBe(11);
+        expect(postedBody.position.new_line).toBeNull();
+    });
+    it('falls back to general when anchor cannot be resolved', async () => {
+        const result = await service.postDraftNotes({
+            ...baseParams,
+            findings: {
+                comments: [{
+                        file: 'missing.ts',
+                        anchor: 'nonexistent line',
+                        blocking: true,
+                        note: 'Cannot find this',
+                    }],
+                summary: 'test',
+                verdict: 'request_changes',
+            },
+        }, 'https://gitlab.example.com', 'fake-token');
+        expect(result.posted).toBe(1);
+        // Should be posted as general (no position)
+        const postedBody = mockPostDraftNote.mock.calls[0][2];
+        expect(postedBody.position).toBeUndefined();
+        expect(postedBody.note).toBe('**`missing.ts`** ([link](https://gitlab.example.com/group/repo/-/blob/head123/missing.ts))\n\nCannot find this');
+    });
+    it('skips resolution for findings that already have line numbers', async () => {
+        const result = await service.postDraftNotes({
+            ...baseParams,
+            findings: {
+                comments: [{
+                        file: 'file.ts',
+                        anchor: 'const added = false;',
+                        line: 99,
+                        changed: 'new',
+                        blocking: true,
+                        note: 'Already resolved',
+                    }],
+                summary: 'test',
+                verdict: 'request_changes',
+            },
+        }, 'https://gitlab.example.com', 'fake-token');
+        expect(result.posted).toBe(1);
+        // Should use the pre-existing line number, not re-resolve
+        const postedBody = mockPostDraftNote.mock.calls[0][2];
+        expect(postedBody.position.new_line).toBe(99);
+    });
+    it('does not resolve anchors when repoDir is not provided', async () => {
+        const result = await service.postDraftNotes({
+            project: 'group/repo',
+            mergeRequestIid: 1,
+            headSha: 'head123',
+            baseSha: 'base123',
+            startSha: 'start123',
+            // No repoDir or mergeBase
+            findings: {
+                comments: [{
+                        file: 'file.ts',
+                        anchor: 'const added = false;',
+                        blocking: true,
+                        note: 'No resolution',
+                    }],
+                summary: 'test',
+                verdict: 'request_changes',
+            },
+        }, 'https://gitlab.example.com', 'fake-token');
+        expect(result.posted).toBe(1);
+        // Without repoDir, anchor is ignored — no line/old_line means general comment
+        const postedBody = mockPostDraftNote.mock.calls[0][2];
+        expect(postedBody.position).toBeUndefined();
+        // File-link fallback should prepend file context to the note body
+        expect(postedBody.note).toBe('**`file.ts`** ([link](https://gitlab.example.com/group/repo/-/blob/head123/file.ts))\n\nNo resolution');
+    });
+});
+//# sourceMappingURL=review-tools.service.test.js.map

package/dist/services/__tests__/review-tools.service.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-tools.service.test.js","sourceRoot":"","sources":["../../../src/services/__tests__/review-tools.service.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,kBAAkB,EAAE,MAAM,4BAA4B,CAAC;AAChE,OAAO,EAAE,MAAM,EAAE,QAAQ,EAAE,MAAM,iCAAiC,CAAC;AAGnE,+CAA+C;AAC/C,MAAM,iBAAiB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,SAAS,EAAE,KAAK,EAAE,CAAC,CAAC;AACjF,MAAM,mBAAmB,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC,CAAC;AAE1D,EAAE,CAAC,IAAI,CAAC,yBAAyB,EAAE,GAAG,EAAE,CAAC,CAAC;IACxC,SAAS,EAAE,MAAM,aAAa;QAC5B,aAAa,GAAG,iBAAiB,CAAC;QAClC,eAAe,GAAG,mBAAmB,CAAC;QACtC,gBAAe,CAAC;KACjB;CACF,CAAC,CAAC,CAAC;AAEJ,wDAAwD;AACxD,EAAE,CAAC,IAAI,CAAC,yBAAyB,EAAE,GAAG,EAAE,CAAC,CAAC;IACxC,eAAe,EAAE,MAAM,mBAAmB;QACxC,gBAAe,CAAC;QAChB,MAAM,CAAC,QAAgB,EAAE,IAAc;YACrC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;YACvC,IAAI,QAAQ,KAAK,SAAS,EAAE,CAAC;gBAC3B,OAAO,OAAO,CAAC,OAAO,CAAC;oBACrB,gCAAgC;oBAChC,uBAAuB;oBACvB,eAAe;oBACf,eAAe;oBACf,mBAAmB;oBACnB,yBAAyB;oBACzB,uBAAuB;oBACvB,yBAAyB;oBACzB,mBAAmB;iBACpB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC;YAChB,CAAC;YACD,OAAO,OAAO,CAAC,MAAM,CAAC,IAAI,KAAK,CAAC,SAAS,CAAC,CAAC,CAAC;QAC9C,CAAC;KACF;CACF,CAAC,CAAC,CAAC;AAEJ,QAAQ,CAAC,qDAAqD,EAAE,GAAG,EAAE;IACnE,IAAI,OAA2B,CAAC;IAEhC,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;QACnB,MAAM,MAAM,GAAG,IAAI,MAAM,CAAC,MAAM,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC;QAClD,OAAO,GAAG,IAAI,kBAAkB,CAAC,MAAM,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;IAEH,MAAM,UAAU,GAA2C;QACzD,OAAO,EAAE,YAAY;QACrB,eAAe,EAAE,CAAC;QAClB,OAAO,EAAE,SAAS;QAClB,OAAO,EAAE,SAAS;QAClB,QAAQ,EAAE,UAAU;QACpB,OAAO,EAAE,YAAY;QACrB,SAAS,EAAE,gBAAgB;KAC5B,CAAC;IAEF,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;QAC3E,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,GAAG,UAAU;YACb,QAAQ,EAAE;gBACR,QAAQ,EAAE,CAAC;wBACT,IAAI,EAAE,SAAS;wBACf,MAAM,EAAE,sBAAsB;wBAC9B,QAAQ,EAAE,IAAI;wBACd,IAAI,EAAE,sBAAsB;qBAC7B,CAAC;gBACF,OAAO,EAAE,MAAM;gBACf,OAAO,EAAE,iBAAiB;aAC3B;SACF,EAAE,4BAA4B,EAAE,YAAY,CAAC,CAAC;QAE/C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAC9B,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAEtC,qDAAqD;QACrD,MAAM,UAAU,GAAG,iBAAiB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACtD,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC,WAAW,EAAE,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QAC9C,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,QAAQ,EAAE,CAAC;IAClD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kCAAkC,EAAE,KAAK,IAAI,EAAE;QAChD,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,GAAG,UAAU;YACb,QAAQ,EAAE;gBACR,QAAQ,EAAE,CAAC;wBACT,IAAI,EAAE,SAAS;wBACf,MAAM,EAAE,4BAA4B;wBACpC,QAAQ,EAAE,IAAI;wBACd,IAAI,EAAE,kBAAkB;qBACzB,CAAC;gBACF,OAAO,EAAE,MAAM;gBACf,OAAO,EAAE,iBAAiB;aAC3B;SACF,EAAE,4BAA4B,EAAE,YAAY,CAAC,CAAC;QAE/C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAE9B,MAAM,UAAU,GAAG,iBAAiB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACtD,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC,WAAW,EAAE,CAAC;QAC1C,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QAC9C,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,QAAQ,EAAE,CAAC;IAClD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,GAAG,UAAU;YACb,QAAQ,EAAE;gBACR,QAAQ,EAAE,CAAC;wBACT,IAAI,EAAE,YAAY;wBAClB,MAAM,EAAE,kBAAkB;wBAC1B,QAAQ,EAAE,IAAI;wBACd,IAAI,EAAE,kBAAkB;qBACzB,CAAC;gBACF,OAAO,EAAE,MAAM;gBACf,OAAO,EAAE,iBAAiB;aAC3B;SACF,EAAE,4BAA4B,EAAE,YAAY,CAAC,CAAC;QAE/C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAE9B,4CAA4C;QAC5C,MAAM,UAAU,GAAG,iBAAiB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACtD,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC,aAAa,EAAE,CAAC;QAC5C,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,gHAAgH,CAAC,CAAC;IACjJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8DAA8D,EAAE,KAAK,IAAI,EAAE;QAC5E,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,GAAG,UAAU;YACb,QAAQ,EAAE;gBACR,QAAQ,EAAE,CAAC;wBACT,IAAI,EAAE,SAAS;wBACf,MAAM,EAAE,sBAAsB;wBAC9B,IAAI,EAAE,EAAE;wBACR,OAAO,EAAE,KAAK;wBACd,QAAQ,EAAE,IAAI;wBACd,IAAI,EAAE,kBAAkB;qBACzB,CAAC;gBACF,OAAO,EAAE,MAAM;gBACf,OAAO,EAAE,iBAAiB;aAC3B;SACF,EAAE,4BAA4B,EAAE,YAAY,CAAC,CAAC;QAE/C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAE9B,0DAA0D;QAC1D,MAAM,UAAU,GAAG,iBAAiB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACtD,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAChD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,KAAK,IAAI,EAAE;QACrE,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,cAAc,CAAC;YAC1C,OAAO,EAAE,YAAY;YACrB,eAAe,EAAE,CAAC;YAClB,OAAO,EAAE,SAAS;YAClB,OAAO,EAAE,SAAS;YAClB,QAAQ,EAAE,UAAU;YACpB,0BAA0B;YAC1B,QAAQ,EAAE;gBACR,QAAQ,EAAE,CAAC;wBACT,IAAI,EAAE,SAAS;wBACf,MAAM,EAAE,sBAAsB;wBAC9B,QAAQ,EAAE,IAAI;wBACd,IAAI,EAAE,eAAe;qBACtB,CAAC;gBACF,OAAO,EAAE,MAAM;gBACf,OAAO,EAAE,iBAAiB;aAC3B;SACF,EAAE,4BAA4B,EAAE,YAAY,CAAC,CAAC;QAE/C,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAE9B,8EAA8E;QAC9E,MAAM,UAAU,GAAG,iBAAiB,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACtD,MAAM,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC,aAAa,EAAE,CAAC;QAC5C,kEAAkE;QAClE,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,uGAAuG,CAAC,CAAC;IACxI,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/services/__tests__/review-utils.service.test.d.ts

@@ -0,0 +1,8 @@
+/**
+ * Tests for ReviewService anchor resolution.
+ *
+ * These tests mock GitToolsService.runGit to supply synthetic diffs,
+ * then verify that resolveAnchors correctly maps anchors to line numbers.
+ */
+export {};
+//# sourceMappingURL=review-utils.service.test.d.ts.map

package/dist/services/__tests__/review-utils.service.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-utils.service.test.d.ts","sourceRoot":"","sources":["../../../src/services/__tests__/review-utils.service.test.ts"],"names":[],"mappings":"AAAA;;;;;GAKG"}