@rebasepro/server-postgres 0.17.3-canary.gdd23447 → 0.18.0

package/src/schema/ensure-collection-policies.ts

@@ -1,198 +0,0 @@
-/**
- * Applying a bundle's RLS policies to a database at boot, idempotently.
- *
- * ## Why this exists
- *
- * {@link ensureCollectionTables} creates the collection *tables* a managed
- * runtime boots against, but a table with row-level security disabled and no
- * policies is not servable: authenticated requests run as the restricted
- * `rebase_user` role, so a read with no `SELECT` policy returns nothing (a
- * public collection answered 401) and a write with no `INSERT`/`UPDATE` policy
- * is denied. The policies live in the collections' `securityRules`; nothing at
- * boot applied them. `rebase db push` does — but it drives Atlas against a
- * local `DATABASE_URL`, and a managed tenant's database is reachable only from
- * inside the cluster, by the runtime that is already connected to it. So the
- * runtime is the only thing that *can* apply them, and this is where it does.
- *
- * ## Why this is safe to run on every boot
- *
- * Every statement is idempotent: `ENABLE ROW LEVEL SECURITY` is a no-op once
- * enabled, and each policy is a `DROP POLICY IF EXISTS` immediately followed by
- * a `CREATE POLICY`, so re-applying asserts exactly the declared state. It adds
- * and replaces; it never drops data. (It does not *reconcile* — a policy a
- * previous push left behind under an old name is not removed here; that stays a
- * `db push` / `db migrate` concern, alongside destructive schema changes.)
- *
- * Unlike table creation, a failure here is not fatal: RLS stays enabled, so a
- * table whose policies could not be applied fails **closed** (denies) rather
- * than leaking rows. One collection's policy failing (e.g. a rule that
- * references a table a real migration has not created yet) must not crash-loop
- * the whole deployment and take the other collections' working routes down with
- * it. Failures are reported loudly and per-table so the operator can see
- * exactly which collection is not yet servable and why.
- */
-import { type CollectionConfig } from "@rebasepro/types";
-import { planCollectionPolicies, type CollectionPolicyPlan } from "./generate-postgres-ddl-logic";
-import { isGeneratedPolicyName } from "../security/policy-drift";
-import { readExistingSchema, type Queryable } from "./ensure-collection-tables";
-import { REBASE_USER_ROLE } from "../security/rls-enforcement";
-
-export interface PolicyEnsureResult {
-    /** `CREATE POLICY` statements that ran successfully. */
-    policiesApplied: number;
-    /** Tables that had RLS enabled. */
-    tablesSecured: number;
-    /** Declared tables absent from the database — left to a real migration. */
-    skipped: { table: string; reason: string }[];
-    /**
-     * Tables that have RLS on but did not get every policy. They deny — RLS
-     * with no matching policy is deny-all — so they are safe but not servable.
-     */
-    failures: { table: string; error: string }[];
-    /**
-     * Tables RLS could not be enabled on, whose DML grant was withdrawn instead.
-     *
-     * This state had no name, and that was the bug: `ENABLE ROW LEVEL SECURITY`
-     * failing was recorded as a `failure` and reported with the same "it stays
-     * locked (denies)" wording as a failed policy — but the two are opposites.
-     * A policy statement failing leaves RLS on and the table denying. `enableRls`
-     * failing leaves RLS *off*, and the schema-wide grant to the user role has
-     * already been made by `ensureRlsEnforcement`, so the table is readable and
-     * writable by every authenticated request with no row filtering at all.
-     */
-    unsecured: { table: string; error: string; grantWithdrawn: boolean }[];
-    /**
-     * Generated policies removed because no current rule produces them.
-     *
-     * A policy's name embeds a hash of the rule's semantics, so editing a rule
-     * does not update a policy — it creates a new one and abandons the old.
-     * Postgres ORs permissive policies, so the abandoned one keeps granting:
-     * a `USING (true)` tightened to an owner check went on admitting everyone,
-     * forever, while the deploy logged success.
-     *
-     * `db push` reconciles this, and cannot reach a managed tenant's in-cluster
-     * database — which is the reason this module exists. So boot has to do it.
-     */
-    orphansDropped: number;
-}
-
-const isCreatePolicy = (statement: string): boolean => /^\s*CREATE POLICY/i.test(statement);
-
-/**
- * Bring the declared collections' RLS policies up to date. Returns what it did.
- *
- * Only tables that already exist are touched: the boot-time table creator runs
- * first, so anything still missing is a table this additive path is not allowed
- * to create (a junction, or a relation left to a migration). Enabling RLS on a
- * non-existent table would error, so those are recorded as skipped, not failed.
- */
-
-/**
- * Remove generated policies on this table that the current plan does not
- * produce.
- *
- * Scoped hard, because dropping a policy is destructive: only this one table,
- * only names matching the generated `<table>_<op>_<sha1>` shape, and only names
- * absent from the statements just applied. A hand-written policy, or one
- * belonging to another table, is never touched — `isGeneratedPolicyName` is the
- * same predicate `db push` uses to draw that line.
- */
-async function dropOrphanedPoliciesOn(client: Queryable, plan: CollectionPolicyPlan): Promise<number> {
-    const expected = new Set<string>();
-    for (const statement of plan.policyStatements) {
-        const match = /^\s*CREATE POLICY\s+"([^"]+)"/i.exec(statement);
-        if (match) expected.add(match[1]);
-    }
-
-    const existing = await client.query<{ policyname: string }>(
-        `SELECT policyname FROM pg_policies WHERE schemaname = '${plan.schema.replace(/'/g, "''")}' ` +
-        `AND tablename = '${plan.table.replace(/'/g, "''")}'`
-    );
-
-    let dropped = 0;
-    for (const row of existing.rows) {
-        const name = row.policyname;
-        if (expected.has(name)) continue;
-        if (!isGeneratedPolicyName(name, plan.table)) continue;
-        await client.query(`DROP POLICY IF EXISTS "${name}" ON "${plan.schema}"."${plan.table}"`);
-        dropped++;
-    }
-    return dropped;
-}
-
-export async function ensureCollectionPolicies(
-    client: Queryable,
-    collections: CollectionConfig[],
-    log?: (message: string) => void
-): Promise<PolicyEnsureResult> {
-    const result: PolicyEnsureResult = { policiesApplied: 0, tablesSecured: 0, skipped: [], failures: [], unsecured: [], orphansDropped: 0 };
-
-    const plans = planCollectionPolicies(collections);
-    if (plans.length === 0) return result;
-
-    const schemas = Array.from(new Set(plans.map(p => p.schema)));
-    const existing = await readExistingSchema(client, schemas);
-
-    for (const plan of plans) {
-        if (!existing.tables.has(plan.qualified)) {
-            result.skipped.push({
-                table: plan.qualified,
-                reason: "table is not present in the database; create it with `rebase db push` / `rebase db migrate`"
-            });
-            continue;
-        }
-
-        // Enabling RLS is its own step, because its failure is the opposite of
-        // every other failure here. Once RLS is on, anything that goes wrong
-        // afterwards leaves the table denying; while it is off, the grant made
-        // earlier in boot leaves the table wide open. Sharing one `try` meant
-        // the dangerous case was reported in the safe case's words.
-        try {
-            await client.query(plan.enableRls);
-            result.tablesSecured++;
-        } catch (err) {
-            const error = err instanceof Error ? err.message : String(err);
-            // Take the privilege back rather than serve an unprotected table.
-            // This is the fail-closed step the old code assumed it already had:
-            // per-table, so one collection cannot take the rest of the
-            // deployment down, but leaving nothing readable without RLS.
-            let grantWithdrawn = false;
-            try {
-                await client.query(`REVOKE ALL PRIVILEGES ON ${plan.qualified} FROM ${REBASE_USER_ROLE}`);
-                grantWithdrawn = true;
-            } catch {
-                // Fall through: reported below with `grantWithdrawn: false`,
-                // which the caller escalates. There is nothing else this
-                // function can do to make the table safe.
-            }
-            result.unsecured.push({ table: plan.qualified,
-error,
-grantWithdrawn });
-            continue;
-        }
-
-        try {
-            let created = 0;
-            for (const statement of plan.policyStatements) {
-                await client.query(statement);
-                if (isCreatePolicy(statement)) {
-                    result.policiesApplied++;
-                    created++;
-                }
-            }
-
-            const orphans = await dropOrphanedPoliciesOn(client, plan);
-            result.orphansDropped += orphans;
-
-            log?.(`${plan.qualified}: RLS enabled, ${created} policy(ies) applied` +
-                (orphans > 0 ? `, ${orphans} orphan(s) dropped` : ""));
-        } catch (err) {
-            result.failures.push({
-                table: plan.qualified,
-                error: err instanceof Error ? err.message : String(err)
-            });
-        }
-    }
-
-    return result;
-}