@react-native/gradle-plugin 0.74.85 → 0.74.87

package/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/OsTest.kt

@@ -0,0 +1,86 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.utils
+
+import com.facebook.react.tests.OS
+import com.facebook.react.tests.OsRule
+import com.facebook.react.tests.WithOs
+import com.facebook.react.utils.Os.cliPath
+import com.facebook.react.utils.Os.unixifyPath
+import org.junit.Assert.*
+import org.junit.Rule
+import org.junit.Test
+import org.junit.rules.TemporaryFolder
+
+class OsTest {
+
+  @get:Rule val osRule = OsRule()
+  @get:Rule val tempFolder = TemporaryFolder()
+
+  @Test
+  @WithOs(OS.LINUX, "amd64")
+  fun onLinuxAmd64_checksOsCorrectly() {
+    assertFalse(Os.isWindows())
+    assertFalse(Os.isMac())
+    assertTrue(Os.isLinuxAmd64())
+  }
+
+  @Test
+  @WithOs(OS.MAC)
+  fun onMac_checksOsCorrectly() {
+    assertFalse(Os.isWindows())
+    assertTrue(Os.isMac())
+    assertFalse(Os.isLinuxAmd64())
+  }
+
+  @Test
+  @WithOs(OS.WIN)
+  fun isWindows_onWindows_returnsTrue() {
+    assertTrue(Os.isWindows())
+    assertFalse(Os.isMac())
+    assertFalse(Os.isLinuxAmd64())
+  }
+
+  @Test
+  fun unixifyPath_withAUnixPath_doesNothing() {
+    val aUnixPath = "/just/a/unix/path.sh"
+
+    assertEquals(aUnixPath, aUnixPath.unixifyPath())
+  }
+
+  @Test
+  fun unixifyPath_withAWindowsPath_convertsItCorrectly() {
+    val aWindowsPath = "D:\\just\\a\\windows\\path\\"
+
+    assertEquals("/D/just/a/windows/path/", aWindowsPath.unixifyPath())
+  }
+
+  @Test
+  @WithOs(OS.WIN)
+  fun cliPath_onWindows_returnsRelativePath() {
+    val tempFile = tempFolder.newFile("test.txt").apply { createNewFile() }
+
+    assertEquals(tempFile.relativeTo(tempFolder.root).path, tempFile.cliPath(tempFolder.root))
+  }
+
+  @Test
+  @WithOs(OS.LINUX)
+  fun cliPath_onLinux_returnsAbsolutePath() {
+    val tempFile = tempFolder.newFile("test.txt").apply { createNewFile() }
+
+    assertEquals(tempFile.absolutePath, tempFile.cliPath(tempFolder.root))
+  }
+
+  @Test
+  @WithOs(OS.MAC)
+  fun cliPath_onMac_returnsAbsolutePath() {
+    val tempFile = tempFolder.newFile("test.txt").apply { createNewFile() }
+
+    assertEquals(tempFile.absolutePath, tempFile.cliPath(tempFolder.root))
+  }
+}

package/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/utils/PathUtilsTest.kt

@@ -0,0 +1,325 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.utils
+
+import com.facebook.react.ReactExtension
+import com.facebook.react.TestReactExtension
+import com.facebook.react.tests.OS
+import com.facebook.react.tests.OsRule
+import com.facebook.react.tests.WithOs
+import java.io.File
+import org.gradle.testfixtures.ProjectBuilder
+import org.junit.Assert.*
+import org.junit.Assume.assumeTrue
+import org.junit.Rule
+import org.junit.Test
+import org.junit.rules.TemporaryFolder
+
+class PathUtilsTest {
+
+  @get:Rule val tempFolder = TemporaryFolder()
+  @get:Rule val osRule = OsRule()
+
+  @Test
+  fun detectedEntryFile_withProvidedVariable() {
+    val extension = TestReactExtension(ProjectBuilder.builder().build())
+    val expected = tempFolder.newFile("fake.index.js")
+    extension.entryFile.set(expected)
+
+    val actual = detectedEntryFile(extension)
+
+    assertEquals(expected, actual)
+  }
+
+  @Test
+  fun detectedEntryFile_withAndroidEntryPoint() {
+    val extension = TestReactExtension(ProjectBuilder.builder().build())
+    extension.root.set(tempFolder.root)
+    tempFolder.newFile("index.android.js")
+
+    val actual = detectedEntryFile(extension)
+
+    assertEquals(File(tempFolder.root, "index.android.js"), actual)
+  }
+
+  @Test
+  fun detectedEntryFile_withDefaultEntryPoint() {
+    val extension = TestReactExtension(ProjectBuilder.builder().build())
+    extension.root.set(tempFolder.root)
+
+    val actual = detectedEntryFile(extension)
+
+    assertEquals(File(tempFolder.root, "index.js"), actual)
+  }
+
+  @Test
+  fun detectedEntryFile_withEnvironmentVariable() {
+    val extension = TestReactExtension(ProjectBuilder.builder().build())
+    val expected = tempFolder.newFile("./fromenv.index.js")
+    // As we can't override env variable for tests, we're going to emulate them here.
+    val envVariable = "./fromenv.index.js"
+
+    extension.root.set(tempFolder.root)
+
+    val actual = detectedEntryFile(extension, envVariable)
+
+    assertEquals(expected, actual)
+  }
+
+  @Test
+  fun detectedCliPath_withCliPathFromExtensionAndFileExists_returnsIt() {
+    val project = ProjectBuilder.builder().build()
+    val cliFile = tempFolder.newFile("cli.js").apply { createNewFile() }
+    val extension = TestReactExtension(project)
+    extension.cliFile.set(cliFile)
+
+    val actual = detectedCliFile(extension)
+
+    assertEquals(cliFile, actual)
+  }
+
+  @Test
+  fun detectedCliPath_withCliFromNodeModules() {
+    val project = ProjectBuilder.builder().build()
+    val extension = TestReactExtension(project)
+    File(tempFolder.root, "node_modules/react-native/cli.js").apply {
+      parentFile.mkdirs()
+      writeText("<!-- nothing to see here -->")
+    }
+    val locationToResolveFrom = File(tempFolder.root, "a-subdirectory").apply { mkdirs() }
+    extension.root.set(locationToResolveFrom)
+
+    val actual = detectedCliFile(extension)
+
+    assertEquals("<!-- nothing to see here -->", actual.readText())
+  }
+
+  @Test(expected = IllegalStateException::class)
+  fun detectedCliPath_failsIfNotFound() {
+    val project = ProjectBuilder.builder().build()
+    val extension = TestReactExtension(project)
+
+    // Because react-native is now a package, it is always
+    // accessible from <root>/node_modules/react-native
+    // We need to provide location where cli.js file won't be resolved
+    extension.root.set(tempFolder.root)
+
+    detectedCliFile(extension)
+  }
+
+  @Test
+  fun projectPathToLibraryName_withSimplePath() {
+    assertEquals("SampleSpec", projectPathToLibraryName(":sample"))
+  }
+
+  @Test
+  fun projectPathToLibraryName_withComplexPath() {
+    assertEquals("SampleAndroidAppSpec", projectPathToLibraryName(":sample:android:app"))
+  }
+
+  @Test
+  fun projectPathToLibraryName_withKebabCase() {
+    assertEquals("SampleAndroidAppSpec", projectPathToLibraryName("sample-android-app"))
+  }
+
+  @Test
+  fun projectPathToLibraryName_withDotsAndUnderscores() {
+    assertEquals("SampleAndroidAppSpec", projectPathToLibraryName("sample_android.app"))
+  }
+
+  @Test
+  fun detectOSAwareHermesCommand_withProvidedCommand() {
+    assertEquals(
+        "./my-home/hermes", detectOSAwareHermesCommand(tempFolder.root, "./my-home/hermes"))
+  }
+
+  @Test
+  fun detectOSAwareHermesCommand_withHermescBuiltLocally() {
+    // As we can't mock env variables, we skip this test if an override of the Hermes
+    // path has been provided.
+    assumeTrue(System.getenv("REACT_NATIVE_OVERRIDE_HERMES_DIR") == null)
+
+    tempFolder.newFolder("node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/bin/")
+    val expected =
+        tempFolder.newFile(
+            "node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/bin/hermesc")
+
+    assertEquals(expected.toString(), detectOSAwareHermesCommand(tempFolder.root, ""))
+  }
+
+  @Test
+  @WithOs(OS.MAC)
+  fun detectOSAwareHermesCommand_withBundledHermescInsideRN() {
+    tempFolder.newFolder("node_modules/react-native/sdks/hermesc/osx-bin/")
+    val expected = tempFolder.newFile("node_modules/react-native/sdks/hermesc/osx-bin/hermesc")
+
+    assertEquals(expected.toString(), detectOSAwareHermesCommand(tempFolder.root, ""))
+  }
+
+  @Test(expected = IllegalStateException::class)
+  @WithOs(OS.MAC)
+  fun detectOSAwareHermesCommand_failsIfNotFound() {
+    detectOSAwareHermesCommand(tempFolder.root, "")
+  }
+
+  @Test
+  @WithOs(OS.MAC)
+  fun detectOSAwareHermesCommand_withProvidedCommand_takesPrecedence() {
+    tempFolder.newFolder("node_modules/react-native/sdks/hermes/build/bin/")
+    tempFolder.newFile("node_modules/react-native/sdks/hermes/build/bin/hermesc")
+    tempFolder.newFolder("node_modules/react-native/sdks/hermesc/osx-bin/")
+    tempFolder.newFile("node_modules/react-native/sdks/hermesc/osx-bin/hermesc")
+
+    assertEquals(
+        "./my-home/hermes", detectOSAwareHermesCommand(tempFolder.root, "./my-home/hermes"))
+  }
+
+  @Test
+  @WithOs(OS.MAC)
+  fun detectOSAwareHermesCommand_withoutProvidedCommand_builtHermescTakesPrecedence() {
+    // As we can't mock env variables, we skip this test if an override of the Hermes
+    // path has been provided.
+    assumeTrue(System.getenv("REACT_NATIVE_OVERRIDE_HERMES_DIR") == null)
+
+    tempFolder.newFolder("node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/bin/")
+    val expected =
+        tempFolder.newFile(
+            "node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/bin/hermesc")
+    tempFolder.newFolder("node_modules/react-native/sdks/hermesc/osx-bin/")
+    tempFolder.newFile("node_modules/react-native/sdks/hermesc/osx-bin/hermesc")
+
+    assertEquals(expected.toString(), detectOSAwareHermesCommand(tempFolder.root, ""))
+  }
+
+  @Test
+  fun getBuiltHermescFile_withoutOverride() {
+    assertEquals(
+        File(
+            tempFolder.root,
+            "node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/bin/hermesc"),
+        getBuiltHermescFile(tempFolder.root, ""))
+  }
+
+  @Test
+  @WithOs(OS.WIN)
+  fun getBuiltHermescFile_onWindows_withoutOverride() {
+    assertEquals(
+        File(
+            tempFolder.root,
+            "node_modules/react-native/ReactAndroid/hermes-engine/build/hermes/bin/hermesc.exe"),
+        getBuiltHermescFile(tempFolder.root, ""))
+  }
+
+  @Test
+  fun getBuiltHermescFile_withOverride() {
+    assertEquals(
+        File("/home/circleci/hermes/build/bin/hermesc"),
+        getBuiltHermescFile(tempFolder.root, "/home/circleci/hermes"))
+  }
+
+  @Test
+  @WithOs(OS.WIN)
+  fun getHermesCBin_onWindows_returnsHermescExe() {
+    assertEquals("hermesc.exe", getHermesCBin())
+  }
+
+  @Test
+  @WithOs(OS.LINUX)
+  fun getHermesCBin_onLinux_returnsHermesc() {
+    assertEquals("hermesc", getHermesCBin())
+  }
+
+  @Test
+  @WithOs(OS.MAC)
+  fun getHermesCBin_onMac_returnsHermesc() {
+    assertEquals("hermesc", getHermesCBin())
+  }
+
+  @Test
+  fun findPackageJsonFile_withFileInParentFolder_picksItUp() {
+    tempFolder.newFile("package.json")
+    val moduleFolder = tempFolder.newFolder("awesome-module")
+
+    val project = ProjectBuilder.builder().withProjectDir(moduleFolder).build()
+    project.plugins.apply("com.android.library")
+    project.plugins.apply("com.facebook.react")
+    val extension = project.extensions.getByType(ReactExtension::class.java)
+
+    assertEquals(project.file("../package.json"), findPackageJsonFile(project, extension.root))
+  }
+
+  @Test
+  fun findPackageJsonFile_withFileConfiguredInExtension_picksItUp() {
+    val moduleFolder = tempFolder.newFolder("awesome-module")
+    val localFile = File(moduleFolder, "package.json").apply { writeText("{}") }
+
+    val project = ProjectBuilder.builder().withProjectDir(moduleFolder).build()
+    project.plugins.apply("com.android.library")
+    project.plugins.apply("com.facebook.react")
+    val extension =
+        project.extensions.getByType(ReactExtension::class.java).apply { root.set(moduleFolder) }
+
+    assertEquals(localFile, findPackageJsonFile(project, extension.root))
+  }
+
+  @Test
+  fun readPackageJsonFile_withMissingFile_returnsNull() {
+    val moduleFolder = tempFolder.newFolder("awesome-module")
+    val project = ProjectBuilder.builder().withProjectDir(moduleFolder).build()
+    project.plugins.apply("com.android.library")
+    project.plugins.apply("com.facebook.react")
+    val extension =
+        project.extensions.getByType(ReactExtension::class.java).apply { root.set(moduleFolder) }
+
+    val actual = readPackageJsonFile(project, extension.root)
+
+    assertNull(actual)
+  }
+
+  @Test
+  fun readPackageJsonFile_withFileConfiguredInExtension_andMissingCodegenConfig_returnsNullCodegenConfig() {
+    val moduleFolder = tempFolder.newFolder("awesome-module")
+    File(moduleFolder, "package.json").apply { writeText("{}") }
+    val project = ProjectBuilder.builder().withProjectDir(moduleFolder).build()
+    project.plugins.apply("com.android.library")
+    project.plugins.apply("com.facebook.react")
+    val extension =
+        project.extensions.getByType(ReactExtension::class.java).apply { root.set(moduleFolder) }
+
+    val actual = readPackageJsonFile(project, extension.root)
+
+    assertNotNull(actual)
+    assertNull(actual!!.codegenConfig)
+  }
+
+  @Test
+  fun readPackageJsonFile_withFileConfiguredInExtension_andHavingCodegenConfig_returnsValidCodegenConfig() {
+    val moduleFolder = tempFolder.newFolder("awesome-module")
+    File(moduleFolder, "package.json").apply {
+      writeText(
+          // language=json
+          """
+      {
+        "name": "a-library",
+        "codegenConfig": {}
+      }
+      """
+              .trimIndent())
+    }
+    val project = ProjectBuilder.builder().withProjectDir(moduleFolder).build()
+    project.plugins.apply("com.android.library")
+    project.plugins.apply("com.facebook.react")
+    val extension =
+        project.extensions.getByType(ReactExtension::class.java).apply { root.set(moduleFolder) }
+
+    val actual = readPackageJsonFile(project, extension.root)
+
+    assertNotNull(actual)
+    assertNotNull(actual!!.codegenConfig)
+  }
+}