@react-native/gradle-plugin 0.74.85 → 0.74.87

package/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenArtifactsTaskTest.kt

@@ -0,0 +1,212 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.tasks
+
+import com.facebook.react.tests.*
+import com.facebook.react.tests.createProject
+import com.facebook.react.tests.createTestTask
+import java.io.File
+import org.junit.Assert.assertEquals
+import org.junit.Assert.assertTrue
+import org.junit.Rule
+import org.junit.Test
+import org.junit.rules.TemporaryFolder
+
+class GenerateCodegenArtifactsTaskTest {
+
+  @get:Rule val tempFolder = TemporaryFolder()
+
+  @get:Rule val osRule = OsRule()
+
+  @Test
+  fun generateCodegenSchema_inputFiles_areSetCorrectly() {
+    val outputDir = tempFolder.newFolder("output")
+
+    val task = createTestTask<GenerateCodegenArtifactsTask> { it.generatedSrcDir.set(outputDir) }
+
+    assertEquals(File(outputDir, "schema.json"), task.generatedSchemaFile.get().asFile)
+  }
+
+  @Test
+  fun generateCodegenSchema_outputFile_isSetCorrectly() {
+    val outputDir = tempFolder.newFolder("output")
+
+    val task = createTestTask<GenerateCodegenArtifactsTask> { it.generatedSrcDir.set(outputDir) }
+
+    assertEquals(File(outputDir, "java"), task.generatedJavaFiles.get().asFile)
+    assertEquals(File(outputDir, "jni"), task.generatedJniFiles.get().asFile)
+  }
+
+  @Test
+  fun generateCodegenSchema_simpleProperties_areInsideInput() {
+    val packageJsonFile = tempFolder.newFile("package.json")
+
+    val task =
+        createTestTask<GenerateCodegenArtifactsTask> {
+          it.nodeExecutableAndArgs.set(listOf("npm", "help"))
+          it.codegenJavaPackageName.set("com.example.test")
+          it.libraryName.set("example-test")
+          it.packageJsonFile.set(packageJsonFile)
+        }
+
+    assertEquals(listOf("npm", "help"), task.nodeExecutableAndArgs.get())
+    assertEquals("com.example.test", task.codegenJavaPackageName.get())
+    assertEquals("example-test", task.libraryName.get())
+    assertTrue(task.inputs.properties.containsKey("nodeExecutableAndArgs"))
+    assertTrue(task.inputs.properties.containsKey("codegenJavaPackageName"))
+    assertTrue(task.inputs.properties.containsKey("libraryName"))
+  }
+
+  @Test
+  @WithOs(OS.LINUX)
+  fun setupCommandLine_willSetupCorrectly() {
+    val reactNativeDir = tempFolder.newFolder("node_modules/react-native/")
+    val outputDir = tempFolder.newFolder("output")
+
+    val task =
+        createTestTask<GenerateCodegenArtifactsTask> {
+          it.reactNativeDir.set(reactNativeDir)
+          it.generatedSrcDir.set(outputDir)
+          it.nodeExecutableAndArgs.set(listOf("--verbose"))
+        }
+
+    task.setupCommandLine("example-test", "com.example.test")
+
+    assertEquals(
+        listOf(
+            "--verbose",
+            File(reactNativeDir, "scripts/generate-specs-cli.js").toString(),
+            "--platform",
+            "android",
+            "--schemaPath",
+            File(outputDir, "schema.json").toString(),
+            "--outputDir",
+            outputDir.toString(),
+            "--libraryName",
+            "example-test",
+            "--javaPackageName",
+            "com.example.test",
+        ),
+        task.commandLine.toMutableList())
+  }
+
+  @Test
+  @WithOs(OS.WIN)
+  fun setupCommandLine_onWindows_willSetupCorrectly() {
+    val reactNativeDir = tempFolder.newFolder("node_modules/react-native/")
+    val outputDir = tempFolder.newFolder("output")
+
+    val project = createProject()
+    val task =
+        createTestTask<GenerateCodegenArtifactsTask>(project) {
+          it.reactNativeDir.set(reactNativeDir)
+          it.generatedSrcDir.set(outputDir)
+          it.nodeExecutableAndArgs.set(listOf("--verbose"))
+        }
+
+    task.setupCommandLine("example-test", "com.example.test")
+
+    assertEquals(
+        listOf(
+            "cmd",
+            "/c",
+            "--verbose",
+            File(reactNativeDir, "scripts/generate-specs-cli.js")
+                .relativeTo(project.projectDir)
+                .path,
+            "--platform",
+            "android",
+            "--schemaPath",
+            File(outputDir, "schema.json").relativeTo(project.projectDir).path,
+            "--outputDir",
+            outputDir.relativeTo(project.projectDir).path,
+            "--libraryName",
+            "example-test",
+            "--javaPackageName",
+            "com.example.test",
+        ),
+        task.commandLine.toMutableList())
+  }
+
+  @Test
+  fun resolveTaskParameters_withConfigInPackageJson_usesIt() {
+    val packageJsonFile =
+        tempFolder.newFile("package.json").apply {
+          // language=JSON
+          writeText(
+              """
+        {
+            "name": "@a/library",
+            "codegenConfig": {
+                "name": "an-awesome-library",
+                "android": {
+                  "javaPackageName": "com.awesome.package"
+                }
+            }
+        }
+        """
+                  .trimIndent())
+        }
+
+    val task =
+        createTestTask<GenerateCodegenArtifactsTask> {
+          it.packageJsonFile.set(packageJsonFile)
+          it.codegenJavaPackageName.set("com.example.ignored")
+          it.libraryName.set("a-library-name-that-is-ignored")
+        }
+
+    val (libraryName, javaPackageName) = task.resolveTaskParameters()
+
+    assertEquals("an-awesome-library", libraryName)
+    assertEquals("com.awesome.package", javaPackageName)
+  }
+
+  @Test
+  fun resolveTaskParameters_withConfigMissingInPackageJson_usesGradleOne() {
+    val packageJsonFile =
+        tempFolder.newFile("package.json").apply {
+          // language=JSON
+          writeText(
+              """
+        {
+            "name": "@a/library",
+            "codegenConfig": {
+            }
+        }
+        """
+                  .trimIndent())
+        }
+
+    val task =
+        createTestTask<GenerateCodegenArtifactsTask> {
+          it.packageJsonFile.set(packageJsonFile)
+          it.codegenJavaPackageName.set("com.example.test")
+          it.libraryName.set("a-library-name-from-gradle")
+        }
+
+    val (libraryName, javaPackageName) = task.resolveTaskParameters()
+
+    assertEquals("a-library-name-from-gradle", libraryName)
+    assertEquals("com.example.test", javaPackageName)
+  }
+
+  @Test
+  fun resolveTaskParameters_withMissingPackageJson_usesGradleOne() {
+    val task =
+        createTestTask<GenerateCodegenArtifactsTask> {
+          it.packageJsonFile.set(File(tempFolder.root, "package.json"))
+          it.codegenJavaPackageName.set("com.example.test")
+          it.libraryName.set("a-library-name-from-gradle")
+        }
+
+    val (libraryName, javaPackageName) = task.resolveTaskParameters()
+
+    assertEquals("a-library-name-from-gradle", libraryName)
+    assertEquals("com.example.test", javaPackageName)
+  }
+}

package/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/GenerateCodegenSchemaTaskTest.kt

@@ -0,0 +1,192 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.tasks
+
+import com.facebook.react.tests.*
+import com.facebook.react.tests.createProject
+import com.facebook.react.tests.createTestTask
+import java.io.File
+import org.junit.Assert.*
+import org.junit.Rule
+import org.junit.Test
+import org.junit.rules.TemporaryFolder
+
+class GenerateCodegenSchemaTaskTest {
+
+  @get:Rule val tempFolder = TemporaryFolder()
+
+  @get:Rule val osRule = OsRule()
+
+  @Test
+  fun generateCodegenSchema_inputFiles_areSetCorrectly() {
+    val jsRootDir =
+        tempFolder.newFolder("js").apply {
+          File(this, "file.js").createNewFile()
+          File(this, "file.ts").createNewFile()
+          File(this, "ignore.txt").createNewFile()
+        }
+
+    val task = createTestTask<GenerateCodegenSchemaTask> { it.jsRootDir.set(jsRootDir) }
+
+    assertEquals(jsRootDir, task.jsInputFiles.dir)
+    assertEquals(setOf("**/*.js", "**/*.ts"), task.jsInputFiles.includes)
+    assertEquals(2, task.jsInputFiles.files.size)
+    assertEquals(
+        setOf(File(jsRootDir, "file.js"), File(jsRootDir, "file.ts")), task.jsInputFiles.files)
+  }
+
+  @Test
+  fun generateCodegenSchema_inputFilesInExcludedPath_areExcluded() {
+    fun File.createFileAndPath() {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+
+    val jsRootDir =
+        tempFolder.newFolder("js").apply {
+          File(this, "afolder/includedfile.js").createFileAndPath()
+          // Those files should be excluded due to their filepath
+          File(this, "afolder/build/generated/source/codegen/anotherfolder/excludedfile.js")
+              .createFileAndPath()
+          File(this, "afolder/build/generated/assets/react/anotherfolder/excludedfile.js")
+              .createFileAndPath()
+          File(this, "afolder/build/generated/res/react/anotherfolder/excludedfile.js")
+              .createFileAndPath()
+          File(this, "afolder/build/generated/sourcemaps/react/anotherfolder/excludedfile.js")
+              .createFileAndPath()
+          File(this, "afolder/build/intermediates/sourcemaps/react/anotherfolder/excludedfile.js")
+              .createFileAndPath()
+        }
+
+    val task = createTestTask<GenerateCodegenSchemaTask> { it.jsRootDir.set(jsRootDir) }
+
+    assertEquals(jsRootDir, task.jsInputFiles.dir)
+    assertEquals(
+        setOf(
+            "**/build/**/*",
+        ),
+        task.jsInputFiles.excludes)
+    assertEquals(1, task.jsInputFiles.files.size)
+    assertEquals(setOf(File(jsRootDir, "afolder/includedfile.js")), task.jsInputFiles.files)
+  }
+
+  @Test
+  fun generateCodegenSchema_outputFile_isSetCorrectly() {
+    val outputDir = tempFolder.newFolder("output")
+
+    val task = createTestTask<GenerateCodegenSchemaTask> { it.generatedSrcDir.set(outputDir) }
+
+    assertEquals(File(outputDir, "schema.json"), task.generatedSchemaFile.get().asFile)
+  }
+
+  @Test
+  fun generateCodegenSchema_nodeExecutablesArgs_areInsideInput() {
+    val task =
+        createTestTask<GenerateCodegenSchemaTask> {
+          it.nodeExecutableAndArgs.set(listOf("npm", "help"))
+        }
+
+    assertEquals(listOf("npm", "help"), task.nodeExecutableAndArgs.get())
+    assertTrue(task.inputs.properties.containsKey("nodeExecutableAndArgs"))
+  }
+
+  @Test
+  fun wipeOutputDir_willCreateOutputDir() {
+    val task =
+        createTestTask<GenerateCodegenSchemaTask> {
+          it.generatedSrcDir.set(File(tempFolder.root, "output"))
+        }
+
+    task.wipeOutputDir()
+
+    assertTrue(File(tempFolder.root, "output").exists())
+    assertEquals(0, File(tempFolder.root, "output").listFiles()?.size)
+  }
+
+  @Test
+  fun wipeOutputDir_willWipeOutputDir() {
+    val outputDir =
+        tempFolder.newFolder("output").apply { File(this, "some-generated-file").createNewFile() }
+
+    val task = createTestTask<GenerateCodegenSchemaTask> { it.generatedSrcDir.set(outputDir) }
+
+    task.wipeOutputDir()
+
+    assertTrue(outputDir.exists())
+    assertEquals(0, outputDir.listFiles()?.size)
+  }
+
+  @Test
+  @WithOs(OS.LINUX)
+  fun setupCommandLine_willSetupCorrectly() {
+    val codegenDir = tempFolder.newFolder("codegen")
+    val jsRootDir = tempFolder.newFolder("js")
+    val outputDir = tempFolder.newFolder("output")
+
+    val task =
+        createTestTask<GenerateCodegenSchemaTask> {
+          it.codegenDir.set(codegenDir)
+          it.jsRootDir.set(jsRootDir)
+          it.generatedSrcDir.set(outputDir)
+          it.nodeExecutableAndArgs.set(listOf("node", "--verbose"))
+        }
+
+    task.setupCommandLine()
+
+    assertEquals(
+        listOf(
+            "node",
+            "--verbose",
+            File(codegenDir, "lib/cli/combine/combine-js-to-schema-cli.js").toString(),
+            "--platform",
+            "android",
+            "--exclude",
+            "NativeSampleTurboModule",
+            File(outputDir, "schema.json").toString(),
+            jsRootDir.toString(),
+        ),
+        task.commandLine.toMutableList())
+  }
+
+  @Test
+  @WithOs(OS.WIN)
+  fun setupCommandLine_onWindows_willSetupCorrectly() {
+    val codegenDir = tempFolder.newFolder("codegen")
+    val jsRootDir = tempFolder.newFolder("js")
+    val outputDir = tempFolder.newFolder("output")
+
+    val project = createProject()
+    val task =
+        createTestTask<GenerateCodegenSchemaTask>(project) {
+          it.codegenDir.set(codegenDir)
+          it.jsRootDir.set(jsRootDir)
+          it.generatedSrcDir.set(outputDir)
+          it.nodeExecutableAndArgs.set(listOf("node", "--verbose"))
+        }
+
+    task.setupCommandLine()
+
+    assertEquals(
+        listOf(
+            "cmd",
+            "/c",
+            "node",
+            "--verbose",
+            File(codegenDir, "lib/cli/combine/combine-js-to-schema-cli.js")
+                .relativeTo(project.projectDir)
+                .path,
+            "--platform",
+            "android",
+            "--exclude",
+            "NativeSampleTurboModule",
+            File(outputDir, "schema.json").relativeTo(project.projectDir).path,
+            jsRootDir.relativeTo(project.projectDir).path,
+        ),
+        task.commandLine.toMutableList())
+  }
+}

package/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/internal/BuildCodegenCLITaskTest.kt

@@ -0,0 +1,27 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.tasks.internal
+
+import com.facebook.react.tests.createTestTask
+import org.junit.Assert.assertEquals
+import org.junit.Rule
+import org.junit.Test
+import org.junit.rules.TemporaryFolder
+
+class BuildCodegenCLITaskTest {
+
+  @get:Rule val tempFolder = TemporaryFolder()
+
+  @Test
+  fun buildCodegenCli_bashWindowsHome_isSetCorrectly() {
+    val bashPath = tempFolder.newFile("bash").absolutePath
+    val task = createTestTask<BuildCodegenCLITask> { it.bashWindowsHome.set(bashPath) }
+
+    assertEquals(bashPath, task.bashWindowsHome.get())
+  }
+}

package/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/internal/PrepareBoostTaskTest.kt

@@ -0,0 +1,105 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.tasks.internal
+
+import com.facebook.react.tests.createProject
+import com.facebook.react.tests.createTestTask
+import java.io.*
+import org.junit.Assert.*
+import org.junit.Rule
+import org.junit.Test
+import org.junit.rules.TemporaryFolder
+
+class PrepareBoostTaskTest {
+
+  @get:Rule val tempFolder = TemporaryFolder()
+
+  @Test(expected = IllegalStateException::class)
+  fun prepareBoostTask_withMissingConfiguration_fails() {
+    val task = createTestTask<PrepareBoostTask>()
+
+    task.taskAction()
+  }
+
+  @Test
+  fun prepareBoostTask_copiesCMakefile() {
+    val boostpath = tempFolder.newFolder("boostpath")
+    val output = tempFolder.newFolder("output")
+    val project = createProject()
+    val task =
+        createTestTask<PrepareBoostTask>(project = project) {
+          it.boostPath.setFrom(boostpath)
+          it.boostVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(project.projectDir, "src/main/jni/third-party/boost/CMakeLists.txt").apply {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+    task.taskAction()
+
+    assertTrue(output.listFiles()!!.any { it.name == "CMakeLists.txt" })
+  }
+
+  @Test
+  fun prepareBoostTask_copiesAsmFiles() {
+    val boostpath = tempFolder.newFolder("boostpath")
+    val output = tempFolder.newFolder("output")
+    val task =
+        createTestTask<PrepareBoostTask>() {
+          it.boostPath.setFrom(boostpath)
+          it.boostVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(boostpath, "asm/asm.S").apply {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+    task.taskAction()
+
+    assertTrue(File(output, "asm/asm.S").exists())
+  }
+
+  @Test
+  fun prepareBoostTask_copiesBoostSourceFiles() {
+    val boostpath = tempFolder.newFolder("boostpath")
+    val output = tempFolder.newFolder("output")
+    val task =
+        createTestTask<PrepareBoostTask> {
+          it.boostPath.setFrom(boostpath)
+          it.boostVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(boostpath, "boost_1.0.0/boost/config.hpp").apply {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+    task.taskAction()
+
+    assertTrue(File(output, "boost_1.0.0/boost/config.hpp").exists())
+  }
+
+  @Test
+  fun prepareBoostTask_copiesVersionlessBoostSourceFiles() {
+    val boostpath = tempFolder.newFolder("boostpath")
+    val output = tempFolder.newFolder("output")
+    val task =
+        createTestTask<PrepareBoostTask> {
+          it.boostPath.setFrom(boostpath)
+          it.boostVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(boostpath, "boost/boost/config.hpp").apply {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+    task.taskAction()
+
+    assertTrue(File(output, "boost_1.0.0/boost/config.hpp").exists())
+  }
+}

package/react-native-gradle-plugin/src/test/kotlin/com/facebook/react/tasks/internal/PrepareGlogTaskTest.kt

@@ -0,0 +1,130 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+package com.facebook.react.tasks.internal
+
+import com.facebook.react.tests.createProject
+import com.facebook.react.tests.createTestTask
+import java.io.*
+import org.junit.Assert.*
+import org.junit.Rule
+import org.junit.Test
+import org.junit.rules.TemporaryFolder
+
+class PrepareGlogTaskTest {
+
+  @get:Rule val tempFolder = TemporaryFolder()
+
+  @Test(expected = IllegalStateException::class)
+  fun prepareGlogTask_withMissingConfiguration_fails() {
+    val task = createTestTask<PrepareGlogTask>()
+
+    task.taskAction()
+  }
+
+  @Test
+  fun prepareGlogTask_copiesCMakefile() {
+    val glogpath = tempFolder.newFolder("glogpath")
+    val output = tempFolder.newFolder("output")
+    val project = createProject()
+    val task =
+        createTestTask<PrepareGlogTask>(project = project) {
+          it.glogPath.setFrom(glogpath)
+          it.glogVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(project.projectDir, "src/main/jni/third-party/glog/CMakeLists.txt").apply {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+    task.taskAction()
+
+    assertTrue(output.listFiles()!!.any { it.name == "CMakeLists.txt" })
+  }
+
+  @Test
+  fun prepareGlogTask_copiesConfigHeaderFile() {
+    val glogpath = tempFolder.newFolder("glogpath")
+    val output = tempFolder.newFolder("output")
+    val project = createProject()
+    val task =
+        createTestTask<PrepareGlogTask>(project = project) {
+          it.glogPath.setFrom(glogpath)
+          it.glogVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(project.projectDir, "src/main/jni/third-party/glog/config.h").apply {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+    task.taskAction()
+
+    assertTrue(output.listFiles()!!.any { it.name == "config.h" })
+  }
+
+  @Test
+  fun prepareGlogTask_copiesSourceCode() {
+    val glogpath = tempFolder.newFolder("glogpath")
+    val output = tempFolder.newFolder("output")
+    val task =
+        createTestTask<PrepareGlogTask> {
+          it.glogPath.setFrom(glogpath)
+          it.glogVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(glogpath, "glog-1.0.0/src/glog.cpp").apply {
+      parentFile.mkdirs()
+      createNewFile()
+    }
+
+    task.taskAction()
+
+    assertTrue(File(output, "glog-1.0.0/src/glog.cpp").exists())
+  }
+
+  @Test
+  fun prepareGlogTask_replacesTokenCorrectly() {
+    val glogpath = tempFolder.newFolder("glogpath")
+    val output = tempFolder.newFolder("output")
+    val task =
+        createTestTask<PrepareGlogTask> {
+          it.glogPath.setFrom(glogpath)
+          it.glogVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(glogpath, "glog-1.0.0/src/glog.h.in").apply {
+      parentFile.mkdirs()
+      writeText("ac_google_start_namespace")
+    }
+
+    task.taskAction()
+
+    val expectedFile = File(output, "glog.h")
+    assertTrue(expectedFile.exists())
+    assertEquals("ac_google_start_namespace", expectedFile.readText())
+  }
+
+  @Test
+  fun prepareGlogTask_exportsHeaderCorrectly() {
+    val glogpath = tempFolder.newFolder("glogpath")
+    val output = tempFolder.newFolder("output")
+    val task =
+        createTestTask<PrepareGlogTask> {
+          it.glogPath.setFrom(glogpath)
+          it.glogVersion.set("1.0.0")
+          it.outputDir.set(output)
+        }
+    File(glogpath, "glog-1.0.0/src/logging.h.in").apply {
+      parentFile.mkdirs()
+      writeText("ac_google_start_namespace")
+    }
+
+    task.taskAction()
+
+    assertTrue(File(output, "exported/glog/logging.h").exists())
+  }
+}