@react-native-harness/platform-android 1.4.0-rc.1 → 1.4.0

package/src/__tests__/instance.test.ts

@@ -12,9 +12,13 @@ import * as adb from '../adb.js';
 import * as avdConfig from '../avd-config.js';
 import * as sharedPrefs from '../shared-prefs.js';
 import { HarnessAppPathError, HarnessEmulatorConfigError } from '../errors.js';
+import * as emulatorStartup from '../emulator-startup.js';
+const { getEmulatorCpuCores } = emulatorStartup;
 
 const createLogcatProcess = (lines: string[] = []): Subprocess => {
-  const process = {
+  // Mirrors nano-spawn's real Subprocess, which is both a Promise and an
+  // async iterable, since app-session.ts relies on it being thenable.
+  const process = Object.assign(Promise.resolve(undefined), {
     nodeChildProcess: Promise.resolve({
       kill: vi.fn(),
     }),
@@ -23,7 +27,7 @@ const createLogcatProcess = (lines: string[] = []): Subprocess => {
         yield line;
       }
     },
-  };
+  });
 
   return process as unknown as Subprocess;
 };
@@ -46,15 +50,19 @@ describe('Android platform instance', () => {
     vi.useRealTimers();
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorAvailable',
+      'ensureAndroidEmulatorAvailable'
     ).mockResolvedValue('/tmp/android-sdk');
+    vi.spyOn(
+      emulatorStartup,
+      'warnIfEmulatorAccelerationUnavailable'
+    ).mockResolvedValue(undefined);
   });
 
   it('reuses a running emulator and does not shut it down on dispose', async () => {
     const ensureAndroidEmulatorEnvironment = vi
       .spyOn(
         await import('../environment.js'),
-        'ensureAndroidEmulatorEnvironment',
+        'ensureAndroidEmulatorEnvironment'
       )
       .mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue(['emulator-5554']);
@@ -64,14 +72,12 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     vi.spyOn(sharedPrefs, 'clearHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     vi.spyOn(adb, 'stopApp').mockResolvedValue(undefined);
     const stopEmulator = vi.spyOn(adb, 'stopEmulator').mockResolvedValue();
@@ -93,7 +99,7 @@ describe('Android platform instance', () => {
         activityName: '.MainActivity',
       },
       harnessConfig,
-      init,
+      init
     );
 
     await instance.dispose();
@@ -105,7 +111,7 @@ describe('Android platform instance', () => {
   it('creates and boots an emulator when missing and shuts it down on dispose', async () => {
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue([]);
     vi.spyOn(adb, 'hasAvd').mockResolvedValue(false);
@@ -118,14 +124,12 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     vi.spyOn(sharedPrefs, 'clearHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     vi.spyOn(adb, 'stopApp').mockResolvedValue(undefined);
     const stopEmulator = vi.spyOn(adb, 'stopEmulator').mockResolvedValue();
@@ -147,7 +151,7 @@ describe('Android platform instance', () => {
         activityName: '.MainActivity',
       },
       harnessConfig,
-      init,
+      init
     );
 
     expect(createAvd).toHaveBeenCalledWith({
@@ -168,7 +172,7 @@ describe('Android platform instance', () => {
     const ensureAndroidEmulatorEnvironment = vi
       .spyOn(
         await import('../environment.js'),
-        'ensureAndroidEmulatorEnvironment',
+        'ensureAndroidEmulatorEnvironment'
       )
       .mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue([]);
@@ -182,11 +186,9 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
 
     await expect(
@@ -207,8 +209,8 @@ describe('Android platform instance', () => {
           activityName: '.MainActivity',
         },
         harnessConfig,
-        init,
-      ),
+        init
+      )
     ).resolves.toBeDefined();
 
     expect(ensureAndroidEmulatorEnvironment).toHaveBeenCalledWith(35);
@@ -220,11 +222,11 @@ describe('Android platform instance', () => {
     vi.stubEnv('HARNESS_AVD_CACHING', 'true');
     vi.spyOn(
       await import('../environment.js'),
-      'getHostAndroidSystemImageArch',
+      'getHostAndroidSystemImageArch'
     ).mockReturnValue('arm64-v8a');
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue([]);
     vi.spyOn(adb, 'hasAvd').mockResolvedValue(true);
@@ -234,6 +236,7 @@ describe('Android platform instance', () => {
       hwDeviceName: 'pixel_8',
       diskDataPartitionSize: '1G',
       vmHeapSize: '1G',
+      hwCpuNcore: String(getEmulatorCpuCores()),
     });
     vi.spyOn(adb, 'startEmulator').mockResolvedValue(undefined);
     vi.spyOn(adb, 'waitForBoot').mockResolvedValue('emulator-5554');
@@ -241,11 +244,9 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
 
     await expect(
@@ -267,14 +268,14 @@ describe('Android platform instance', () => {
           activityName: '.MainActivity',
         },
         harnessConfig,
-        init,
-      ),
+        init
+      )
     ).resolves.toBeDefined();
 
     expect(adb.startEmulator).toHaveBeenCalledTimes(1);
     expect(adb.startEmulator).toHaveBeenCalledWith(
       'Pixel_8_API_35',
-      'snapshot-reuse',
+      'snapshot-reuse'
     );
   });
 
@@ -282,7 +283,7 @@ describe('Android platform instance', () => {
     vi.stubEnv('HARNESS_AVD_CACHING', 'true');
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue([]);
     vi.spyOn(adb, 'hasAvd').mockResolvedValue(true);
@@ -305,11 +306,9 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
 
     await expect(
@@ -331,8 +330,8 @@ describe('Android platform instance', () => {
           activityName: '.MainActivity',
         },
         harnessConfig,
-        init,
-      ),
+        init
+      )
     ).resolves.toBeDefined();
 
     expect(deleteAvd).toHaveBeenCalledWith('Pixel_8_API_35');
@@ -340,17 +339,17 @@ describe('Android platform instance', () => {
     expect(stopEmulator).toHaveBeenCalledWith('emulator-5554');
     expect(waitForEmulatorDisconnect).toHaveBeenCalledWith(
       'emulator-5554',
-      init.signal,
+      init.signal
     );
     expect(adb.startEmulator).toHaveBeenNthCalledWith(
       1,
       'Pixel_8_API_35',
-      'clean-snapshot-generation',
+      'clean-snapshot-generation'
     );
     expect(adb.startEmulator).toHaveBeenNthCalledWith(
       2,
       'Pixel_8_API_35',
-      'snapshot-reuse',
+      'snapshot-reuse'
     );
   });
 
@@ -358,7 +357,7 @@ describe('Android platform instance', () => {
     vi.stubEnv('HARNESS_AVD_CACHING', 'true');
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue([]);
     vi.spyOn(adb, 'hasAvd').mockResolvedValue(false);
@@ -375,11 +374,9 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
 
     await expect(
@@ -401,24 +398,24 @@ describe('Android platform instance', () => {
           activityName: '.MainActivity',
         },
         harnessConfig,
-        init,
-      ),
+        init
+      )
     ).resolves.toBeDefined();
 
     expect(startEmulator).toHaveBeenNthCalledWith(
       1,
       'Pixel_8_API_35',
-      'clean-snapshot-generation',
+      'clean-snapshot-generation'
     );
     expect(stopEmulator).toHaveBeenCalledWith('emulator-5554');
     expect(waitForEmulatorDisconnect).toHaveBeenCalledWith(
       'emulator-5554',
-      init.signal,
+      init.signal
     );
     expect(startEmulator).toHaveBeenNthCalledWith(
       2,
       'Pixel_8_API_35',
-      'snapshot-reuse',
+      'snapshot-reuse'
     );
   });
 
@@ -446,8 +443,8 @@ describe('Android platform instance', () => {
           activityName: '.MainActivity',
         },
         harnessConfig,
-        init,
-      ),
+        init
+      )
     ).rejects.toBeInstanceOf(HarnessAppPathError);
   });
 
@@ -476,8 +473,8 @@ describe('Android platform instance', () => {
           activityName: '.MainActivity',
         },
         harnessConfig,
-        init,
-      ),
+        init
+      )
     ).rejects.toBeInstanceOf(HarnessAppPathError);
   });
 
@@ -496,8 +493,8 @@ describe('Android platform instance', () => {
           activityName: '.MainActivity',
         },
         harnessConfig,
-        init,
-      ),
+        init
+      )
     ).rejects.toBeInstanceOf(HarnessEmulatorConfigError);
   });
 
@@ -505,7 +502,7 @@ describe('Android platform instance', () => {
     vi.useFakeTimers();
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue(['emulator-5554']);
     vi.spyOn(adb, 'getEmulatorName').mockResolvedValue('Pixel_8_API_35');
@@ -514,11 +511,9 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     const stopApp = vi.spyOn(adb, 'stopApp').mockResolvedValue(undefined);
     const startApp = vi.spyOn(adb, 'startApp').mockResolvedValue(undefined);
@@ -544,7 +539,7 @@ describe('Android platform instance', () => {
         activityName: '.MainActivity',
       },
       harnessConfigWithoutNativeCrashDetection,
-      init,
+      init
     );
 
     const listener = vi.fn();
@@ -552,18 +547,22 @@ describe('Android platform instance', () => {
     appSession.addListener(listener);
     await vi.advanceTimersByTimeAsync(0);
 
-    expect(startLogcat).toHaveBeenCalledWith('emulator-5554', [
-      'logcat',
-      '-v',
-      'threadtime',
-      '-b',
-      'crash',
-      '--uid=10234',
-      '-T',
-      '01-01 00:00:00.000',
-    ]);
+    expect(startLogcat).toHaveBeenCalledWith(
+      'emulator-5554',
+      [
+        'logcat',
+        '-v',
+        'threadtime',
+        '-b',
+        'crash',
+        '--uid=10234',
+        '-T',
+        '01-01 00:00:00.000',
+      ],
+      { signal: expect.any(AbortSignal) }
+    );
     expect(startLogcat.mock.invocationCallOrder[0]).toBeLessThan(
-      startApp.mock.invocationCallOrder[0],
+      startApp.mock.invocationCallOrder[0]
     );
     await expect(appSession.getState()).resolves.toEqual({
       status: 'running',
@@ -580,7 +579,7 @@ describe('Android platform instance', () => {
     vi.useFakeTimers();
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue(['emulator-5554']);
     vi.spyOn(adb, 'getEmulatorName').mockResolvedValue('Pixel_8_API_35');
@@ -589,11 +588,9 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     vi.spyOn(adb, 'stopApp').mockResolvedValue(undefined);
     vi.spyOn(adb, 'startApp').mockResolvedValue(undefined);
@@ -603,7 +600,7 @@ describe('Android platform instance', () => {
         '--------- beginning of crash',
         'Process: com.harnessplayground, PID: 7777',
         'FATAL EXCEPTION: main',
-      ]),
+      ])
     );
 
     const instance = await getAndroidEmulatorPlatformInstance(
@@ -623,7 +620,7 @@ describe('Android platform instance', () => {
         activityName: '.MainActivity',
       },
       harnessConfig,
-      init,
+      init
     );
 
     const listener = vi.fn();
@@ -658,11 +655,9 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'reversePort').mockResolvedValue(undefined);
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
-    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue(
-      '01-01 00:00:00.000',
-    );
+    vi.spyOn(adb, 'getLogcatTimestamp').mockResolvedValue('01-01 00:00:00.000');
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     vi.spyOn(adb, 'stopApp').mockResolvedValue(undefined);
     vi.spyOn(adb, 'startApp').mockResolvedValue(undefined);
@@ -682,7 +677,7 @@ describe('Android platform instance', () => {
         bundleId: 'com.harnessplayground',
         activityName: '.MainActivity',
       },
-      harnessConfigWithoutNativeCrashDetection,
+      harnessConfigWithoutNativeCrashDetection
     );
 
     const listener = vi.fn();
@@ -690,16 +685,20 @@ describe('Android platform instance', () => {
     appSession.addListener(listener);
     await vi.advanceTimersByTimeAsync(0);
 
-    expect(startLogcat).toHaveBeenCalledWith('012345', [
-      'logcat',
-      '-v',
-      'threadtime',
-      '-b',
-      'crash',
-      '--uid=10234',
-      '-T',
-      '01-01 00:00:00.000',
-    ]);
+    expect(startLogcat).toHaveBeenCalledWith(
+      '012345',
+      [
+        'logcat',
+        '-v',
+        'threadtime',
+        '-b',
+        'crash',
+        '--uid=10234',
+        '-T',
+        '01-01 00:00:00.000',
+      ],
+      { signal: expect.any(AbortSignal) }
+    );
     await expect(appSession.getState()).resolves.toEqual({
       status: 'running',
       pid: 8765,
@@ -712,7 +711,7 @@ describe('Android platform instance', () => {
   it('grants permissions when permissions are enabled for emulator', async () => {
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue(['emulator-5554']);
     vi.spyOn(adb, 'getEmulatorName').mockResolvedValue('Pixel_8_API_35');
@@ -722,7 +721,7 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     const grantPermissions = vi
       .spyOn(adb, 'grantPermissions')
@@ -750,19 +749,19 @@ describe('Android platform instance', () => {
         activityName: '.MainActivity',
       },
       harnessConfigWithPermissions,
-      init,
+      init
     );
 
     expect(grantPermissions).toHaveBeenCalledWith(
       'emulator-5554',
-      'com.harnessplayground',
+      'com.harnessplayground'
     );
   });
 
   it('does not grant permissions when permissions are disabled for emulator', async () => {
     vi.spyOn(
       await import('../environment.js'),
-      'ensureAndroidEmulatorEnvironment',
+      'ensureAndroidEmulatorEnvironment'
     ).mockResolvedValue('/tmp/android-sdk');
     vi.spyOn(adb, 'getDeviceIds').mockResolvedValue(['emulator-5554']);
     vi.spyOn(adb, 'getEmulatorName').mockResolvedValue('Pixel_8_API_35');
@@ -772,7 +771,7 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     const grantPermissions = vi
       .spyOn(adb, 'grantPermissions')
@@ -795,7 +794,7 @@ describe('Android platform instance', () => {
         activityName: '.MainActivity',
       },
       harnessConfig,
-      init,
+      init
     );
 
     expect(grantPermissions).not.toHaveBeenCalled();
@@ -812,7 +811,7 @@ describe('Android platform instance', () => {
     vi.spyOn(adb, 'setHideErrorDialogs').mockResolvedValue(undefined);
     vi.spyOn(adb, 'getAppUid').mockResolvedValue(10234);
     vi.spyOn(sharedPrefs, 'applyHarnessDebugHttpHost').mockResolvedValue(
-      undefined,
+      undefined
     );
     const grantPermissions = vi
       .spyOn(adb, 'grantPermissions')
@@ -834,12 +833,12 @@ describe('Android platform instance', () => {
         bundleId: 'com.harnessplayground',
         activityName: '.MainActivity',
       },
-      harnessConfigWithPermissions,
+      harnessConfigWithPermissions
     );
 
     expect(grantPermissions).toHaveBeenCalledWith(
       '012345',
-      'com.harnessplayground',
+      'com.harnessplayground'
     );
   });
 });