@react-native-harness/platform-android 1.4.0-rc.1 → 1.4.0

package/src/__tests__/avd-config.test.ts

@@ -6,6 +6,9 @@ import {
   resolveAvdCachingEnabled,
 } from '../avd-config.js';
 import { AndroidPlatformConfigSchema } from '../config.js';
+import { getEmulatorCpuCores } from '../emulator-startup.js';
+
+const emulatorCpuCores = getEmulatorCpuCores();
 
 describe('AVD config helpers', () => {
   it('parses snapshot config from Android schema', () => {
@@ -73,8 +76,11 @@ abi.type=x86_64
 hw.device.name=pixel_8
 disk.dataPartition.size=1G
 vm.heapSize=512M
+hw.cpu.ncore=${emulatorCpuCores}
 `);
 
+    expect(avdConfig.hwCpuNcore).toBe(String(emulatorCpuCores));
+
     expect(
       isAvdCompatible({
         emulator: {
@@ -93,6 +99,69 @@ vm.heapSize=512M
     ).toEqual({ compatible: true });
   });
 
+  it('rejects AVDs missing hw.cpu.ncore', () => {
+    const avdConfig = parseAvdConfig(`
+image.sysdir.1=system-images/android-35/default/x86_64/
+abi.type=x86_64
+hw.device.name=pixel_8
+disk.dataPartition.size=1G
+vm.heapSize=512M
+`);
+
+    expect(
+      isAvdCompatible({
+        emulator: {
+          type: 'emulator',
+          name: 'Pixel_8_API_35',
+          avd: {
+            apiLevel: 35,
+            profile: 'pixel_8',
+            diskSize: '1G',
+            heapSize: '512M',
+          },
+        },
+        avdConfig,
+        hostArch: 'x86_64',
+      })
+    ).toMatchObject({
+      compatible: false,
+      reason: `CPU core count mismatch: expected ${emulatorCpuCores}, got missing.`,
+    });
+  });
+
+  it('rejects AVDs with a different hw.cpu.ncore', () => {
+    const avdConfig = parseAvdConfig(`
+image.sysdir.1=system-images/android-35/default/x86_64/
+abi.type=x86_64
+hw.device.name=pixel_8
+disk.dataPartition.size=1G
+vm.heapSize=512M
+hw.cpu.ncore=${emulatorCpuCores === 4 ? 3 : 4}
+`);
+
+    expect(
+      isAvdCompatible({
+        emulator: {
+          type: 'emulator',
+          name: 'Pixel_8_API_35',
+          avd: {
+            apiLevel: 35,
+            profile: 'pixel_8',
+            diskSize: '1G',
+            heapSize: '512M',
+          },
+        },
+        avdConfig,
+        hostArch: 'x86_64',
+      })
+    ).toMatchObject({
+      compatible: false,
+      reason: `CPU core count mismatch: expected ${emulatorCpuCores}, got ${
+        emulatorCpuCores === 4 ? 3 : 4
+      }.`,
+    });
+  });
+
   it('accepts disk partition sizes rewritten to bytes', () => {
     const avdConfig = parseAvdConfig(`
 image.sysdir.1=system-images/android-35/default/x86_64/
@@ -100,6 +169,7 @@ abi.type=x86_64
 hw.device.name=pixel_8
 disk.dataPartition.size=6442450944
 vm.heapSize=512M
+hw.cpu.ncore=${emulatorCpuCores}
 `);
 
     expect(

package/src/__tests__/emulator-startup.test.ts

@@ -1,5 +1,19 @@
 import { describe, expect, it } from 'vitest';
-import { getEmulatorStartupArgs } from '../emulator-startup.js';
+import {
+  getEmulatorCpuCores,
+  getEmulatorStartupArgs,
+  isAccelerationUsable,
+} from '../emulator-startup.js';
+import { getDeviceCoreBudget } from '@react-native-harness/tools';
+import os from 'node:os';
+
+describe('getEmulatorCpuCores', () => {
+  it('uses the shared device-core budget for the current host', () => {
+    expect(getEmulatorCpuCores()).toBe(
+      getDeviceCoreBudget(os.availableParallelism())
+    );
+  });
+});
 
 describe('emulator startup modes', () => {
   it('builds default boot args', () => {
@@ -8,17 +22,24 @@ describe('emulator startup modes', () => {
         '@Pixel_8_API_35',
         '-no-snapshot-load',
         '-no-snapshot-save',
+        '-no-metrics',
       ])
     );
-    expect(getEmulatorStartupArgs('Pixel_8_API_35', 'default-boot')).not.toEqual(
-      expect.arrayContaining(['-camera-back', 'none'])
-    );
+    expect(
+      getEmulatorStartupArgs('Pixel_8_API_35', 'default-boot')
+    ).not.toEqual(expect.arrayContaining(['-camera-back', 'none']));
   });
 
   it('builds clean snapshot generation args', () => {
     expect(
       getEmulatorStartupArgs('Pixel_8_API_35', 'clean-snapshot-generation')
-    ).toEqual(expect.arrayContaining(['@Pixel_8_API_35', '-no-snapshot-load']));
+    ).toEqual(
+      expect.arrayContaining([
+        '@Pixel_8_API_35',
+        '-no-snapshot-load',
+        '-no-metrics',
+      ])
+    );
     expect(
       getEmulatorStartupArgs('Pixel_8_API_35', 'clean-snapshot-generation')
     ).not.toContain('-no-snapshot-save');
@@ -26,10 +47,36 @@ describe('emulator startup modes', () => {
 
   it('builds snapshot reuse args', () => {
     expect(getEmulatorStartupArgs('Pixel_8_API_35', 'snapshot-reuse')).toEqual(
-      expect.arrayContaining(['@Pixel_8_API_35', '-no-snapshot-save'])
+      expect.arrayContaining([
+        '@Pixel_8_API_35',
+        '-no-snapshot-save',
+        '-no-metrics',
+      ])
     );
     expect(
       getEmulatorStartupArgs('Pixel_8_API_35', 'snapshot-reuse')
     ).not.toContain('-no-snapshot-load');
   });
 });
+
+describe('isAccelerationUsable', () => {
+  it('returns true when the emulator reports acceleration is usable', () => {
+    expect(
+      isAccelerationUsable(
+        'accel:\n0\nKVM (version 12) is installed and usable.\naccel\n'
+      )
+    ).toBe(true);
+  });
+
+  it('returns false when acceleration is disabled', () => {
+    expect(
+      isAccelerationUsable(
+        'accel:\n0\nKVM is not installed on this machine.\naccel\n'
+      )
+    ).toBe(false);
+  });
+
+  it('returns false for empty output', () => {
+    expect(isAccelerationUsable('')).toBe(false);
+  });
+});