@quickchatai/quickreview 1.2.0 → 1.3.1

package/src/tui/index.ts

@@ -114,8 +114,8 @@ troubleshooting:
                      project): every read is docker exec into the daemon
                      container, no ssh. The board names an absent or stopped
                      container with the docker compose command that starts it
-  setup not finished the onboarding checklist is not complete: run qcr onboard
-                     (the board names the next step)
+  setup not finished the setup checklist is not complete: run qcr (the board
+                     names the next step)
   ▲ DATA STALE       ssh works but status.json stopped updating — the
                      container is down or the daemon hung (qcr-side:
                      ssh <host> sudo docker ps / docker logs)
@@ -454,11 +454,14 @@ export async function runTui(argv: string | string[] = [], deps: RunTuiDeps = {}
 
   const fileConfig = deps.config ?? loadConfig();
   // The route — which daemon the board reads, and how — from [tui] plus the
-  // facts this checkout holds locally (the compose project's .env, the
-  // onboarding checklist, the Docker socket's mode). Two small file reads and
-  // one access(2): no docker, network or walk, so it may precede the frame.
+  // facts the stack holds locally (the compose project's .env, the
+  // onboarding checklist, the Docker socket's mode). The stack is the one the
+  // home sets up (src/homes.ts `stackRoot`), so an app installed by a package
+  // manager reads it from its state home. Two small file reads and one
+  // access(2): no docker, network or walk, so it may precede the frame.
   const { readRouteFacts, resolveTuiRoute, pinnedVersion } = await import("./route.js");
-  const routeFacts = deps.routeFacts ?? readRouteFacts(sandboxRoot());
+  const { stackRoot } = await import("../homes.js");
+  const routeFacts = deps.routeFacts ?? readRouteFacts(stackRoot(process.env, sandboxRoot()));
   const route = resolveTuiRoute(fileConfig.tui, routeFacts);
   const loaded: Config = { ...fileConfig, tui: route.cfg };
   // In the containerised TUI the companion is a container the host wrapper

package/src/tui/memory.ts

@@ -52,7 +52,7 @@ import {
 import { countOutcome, emptyRequestCounter, type RequestCounter } from "../memory/health.js";
 import { OpenVikingStore } from "../openviking/store.js";
 import { readRetiredUrisFile, writeRetiredUris } from "../memory/ovsession.js";
-import { keysFilePath, MEMORY } from "./companion.js";
+import { keysFilePath } from "./companion.js";
 
 export { matchesQuery, normalizeTag, refOf } from "../memory/store.js";
 export type {
@@ -227,20 +227,8 @@ export function keysFileReader(
   };
 }
 
-/**
- * Where the TUI reaches OpenViking: the memory forward's loopback listener.
- *
- * `QCR_MEMORY_URL` overrides it wholesale; `QCR_MEMORY_PORT` matches the flag
- * the forward itself takes, so a non-default port only has to be spelled once.
- * `MEMORY.port` is the shared constant the forward and the companion already
- * agree on.
- */
-export function tuiMemoryBaseUrl(env: NodeJS.ProcessEnv = process.env): string {
-  const explicit = (env["QCR_MEMORY_URL"] ?? env["QCR_MEMORY_ENDPOINT"] ?? "").trim();
-  if (explicit !== "") return explicit.replace(/\/+$/, "");
-  const port = Number(env["QCR_MEMORY_PORT"] ?? MEMORY.port) || MEMORY.port;
-  return `http://127.0.0.1:${port}`;
-}
+import { tuiMemoryBaseUrl } from "./memoryurl.js";
+export { tuiMemoryBaseUrl };
 
 // ---- the store ---------------------------------------------------------------
 

package/src/tui/memoryurl.ts

@@ -0,0 +1,22 @@
+// Where this host reaches OpenViking: the memory forward's loopback
+// listener. A leaf module, so a reader of the URL (the wizard's memory step,
+// the home) never imports the TUI's memory store or the companion.
+
+/** The port the memory forward and the companion agree on, the server's own
+ * in the VM container (`[openviking] port`). */
+export const MEMORY_PORT = 1933;
+
+/**
+ * Where the TUI reaches OpenViking: the memory forward's loopback listener.
+ *
+ * `QCR_MEMORY_URL` overrides it wholesale; `QCR_MEMORY_PORT` matches the flag
+ * the forward itself takes, so a non-default port only has to be spelled once.
+ * `MEMORY_PORT` is the shared constant the forward and the companion already
+ * agree on.
+ */
+export function tuiMemoryBaseUrl(env: NodeJS.ProcessEnv = process.env): string {
+  const explicit = (env["QCR_MEMORY_URL"] ?? env["QCR_MEMORY_ENDPOINT"] ?? "").trim();
+  if (explicit !== "") return explicit.replace(/\/+$/, "");
+  const port = Number(env["QCR_MEMORY_PORT"] ?? MEMORY_PORT) || MEMORY_PORT;
+  return `http://127.0.0.1:${port}`;
+}

package/src/tui/remote.ts

@@ -341,7 +341,7 @@ export function killInFlightSsh(): number {
  * die on "Could not resolve hostname" and every surface would print an ssh
  * remedy with no host in it. */
 export const NO_SSH_HOST_STDERR =
-  '[tui] ssh_host is empty — run `qcr onboard`, or set [tui] target = "local"';
+  '[tui] ssh_host is empty — set it to the VM\'s ssh alias, or set [tui] target = "local"';
 
 export const realSshRunner: SshRunner = (host, argv, opts) =>
   host.trim() === ""

package/src/tui/route.ts

@@ -109,7 +109,7 @@ export function resolveTuiRoute(file: TuiConfig, facts: RouteFacts): TuiRoute {
       };
       notes.push(
         `[tui] target is "ssh" with no ssh_host — reading the local compose stack in ${facts.projectDir} instead ` +
-          '(run `qcr onboard`, or set [tui] target = "local", to make it explicit)',
+          '(set [tui] target = "local" to make it explicit)',
       );
     } else {
       return {
@@ -117,7 +117,7 @@ export function resolveTuiRoute(file: TuiConfig, facts: RouteFacts): TuiRoute {
         notes,
         unconfigured:
           topology === "vm"
-            ? "[tui] ssh_host is empty — the VM route's ssh alias is written by onboarding: run `qcr onboard`"
+            ? "[tui] ssh_host is empty — set it to the VM's ssh alias in config.toml"
             : EMPTY_SSH_HOST,
       };
     }

package/src/tui/setupstate.ts

@@ -1,25 +1,27 @@
-// Is onboarding finished? Read from the checklist file the wizard keeps
-// (src/onboard/engine.ts), so a TUI opened halfway through `qcr onboard` says
-// so on its first frame instead of troubleshooting a daemon nobody has started
-// yet.
+// Is setup finished? Read from the checklist file switch-on and Advanced keep
+// (src/onboard/engine.ts), so a TUI opened halfway through says so on its
+// first frame instead of troubleshooting a daemon nobody has started yet.
 //
 // Only a checklist that EXISTS and is not complete counts: an install that
-// never ran the wizard (a hand-written config, the VM operator's own setup)
-// has no checklist and gets no banner. The next step is the first enabled step,
-// in the wizard's own order, that the file does not record as done — the same
-// predicates the engine applies, so the TUI cannot name a step the wizard would
-// skip.
+// never switched auto-review on (a hand-written config, the VM operator's own
+// setup) has no checklist and gets no banner. Setup is finished in the home
+// (a bare `qcr`), so the steps judged are the home's: switch-on's and
+// Advanced's registry (src/home/advanced.ts), with the engine's own
+// predicates. The next step is the first enabled, required one the file does
+// not record as done; when there is none, nothing is left that the home could
+// finish, and there is no banner (the home never runs the wizard's finish, so
+// its checklist need not carry the wizard's completion marker).
 import { type ChecklistFile } from "../onboard/engine.js";
 
 export interface SetupState {
-  /** The title of the first pending step ("the final verification" when only
-   * finish is left), or undefined when it could not be computed. */
+  /** The title of the first pending step, or undefined when it could not be
+   * computed. */
   next: string | undefined;
 }
 
 /** The one sentence every surface uses. */
 export function setupLine(s: SetupState): string {
-  return `setup not finished — run \`qcr onboard\` to continue${s.next ? ` (next: ${s.next})` : ""}`;
+  return `setup not finished — run \`qcr\` to finish setting up${s.next ? ` (next: ${s.next})` : ""}`;
 }
 
 /** Complete now: finished once and not reopened since (engine.ts `completeNow`). */
@@ -27,22 +29,24 @@ function completeNow(file: ChecklistFile): boolean {
   return typeof file.completed_at === "string" && !file.reopened_at;
 }
 
-/** undefined = nothing to say (no checklist, or onboarding is complete). */
+/** undefined = nothing to say (no checklist, setup is complete, or the home
+ * has no step left to finish). */
 export async function setupStateOf(
   checklist: ChecklistFile | null,
 ): Promise<SetupState | undefined> {
   if (checklist === null || completeNow(checklist)) return undefined;
   let next: string | undefined;
   try {
-    const { defaultSteps } = await import("../onboard/steps/index.js");
-    const steps = [...defaultSteps()].sort((a, b) => a.order - b.order);
+    const { advancedRegistry } = await import("../home/advanced.js");
+    const steps = [...advancedRegistry().steps()].sort((a, b) => a.order - b.order);
     const pending = steps.find(
       (s) =>
         !s.optional &&
         (s.enabled ? s.enabled(checklist.choices) : true) &&
         checklist.steps[s.id]?.status !== "done",
     );
-    next = pending?.title ?? "the final verification";
+    if (pending === undefined) return undefined;
+    next = pending.title;
   } catch {
     // The step registry could not be loaded: the banner still says setup is
     // unfinished, without naming a step it could not compute.

package/src/tui/sshtriage.ts

@@ -584,7 +584,7 @@ export async function triageConnection(
     return {
       kind: "unconfigured",
       cause: deps.unconfigured ?? NO_SSH_HOST_STDERR,
-      remedy: "qcr onboard",
+      remedy: "set [tui] ssh_host in config.toml",
     };
   }
   const exists = deps.exists ?? existsSync;

package/src/wire.ts

@@ -30,7 +30,7 @@ import { Archiver } from "./archive/archiver.js";
 import { piGlobalSessionsDir } from "./archive/piglobal.js";
 import { runDirOf, toolUidSplit } from "./ipc/capability.js";
 import { PermitBroker } from "./ipc/permits.js";
-import { LoginRefreshSupervisor } from "./loginrefresh/supervisor.js";
+import { LoginRefreshSupervisor, loginDirOf } from "./loginrefresh/supervisor.js";
 import { pendingArchiveStatus } from "./archive/status.js";
 import { Learner, learnerKnobsOf } from "./learner/learner.js";
 import { renderNoPacketSection } from "./learner/packet.js";
@@ -770,6 +770,9 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
   // src/workerworld.ts. No config key picks the tmux route, and nothing births a
   // `pr-<n>` tmux session any more; `sessions` serves paths, worktrees and the replay harness.
   const agentDir = process.env["PI_CODING_AGENT_DIR"]?.trim() || join(homedir(), ".pi", "agent");
+  // The login itself: the agent dir, or the host's shared login on a single
+  // box (one login per box): the refresher owns it and every worker borrows it.
+  const loginDir = loginDirOf(process.env, agentDir);
   const workerWorld = buildWorkerWorld({
     cfg,
     root,
@@ -783,6 +786,7 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
     ...(parts.ovSessions ? { ovSessions: parts.ovSessions } : {}),
     permits: lensPermits,
     agentDir,
+    loginDir,
     pump: () => daemon.pump(),
     loginGate: {
       paused: () => loginRefresh?.paused() ?? false,
@@ -1627,7 +1631,7 @@ export function createProductionDaemon(parts: ProductionParts = buildParts()): D
       if (cfg.login_refresh.enabled) {
         loginRefresh = new LoginRefreshSupervisor({
           repoRoot: root,
-          agentDir,
+          agentDir: loginDir,
           marginMin: cfg.login_refresh.margin_min,
           log,
           // One anomaly per failure episode, through the one durable funnel.

package/src/workerworld.ts

@@ -27,6 +27,7 @@ import type { Config } from "./config.js";
 import { DebugRoundManager } from "./debuground.js";
 import type { FileOutcome } from "./improvements.js";
 import { identityVars } from "@quickchatai/pi-quickreview/src/include.js";
+import { reviewProviders } from "@quickchatai/pi-quickreview/src/modelroute.js";
 import {
   CapabilityStore,
   LaunchFiles,
@@ -89,8 +90,12 @@ export interface WorkerWorldOptions {
   sessions: PiSessionManager;
   ovSessions?: OvSessionLifecycle;
   permits: PermitBroker;
-  /** pi's agent dir: where the login lives (the refresher keeps it). */
+  /** pi's agent dir: models.json, settings and the built lens agents. */
   agentDir: string;
+  /** Where the login lives (the refresher keeps it): the agent dir, unless
+   * the single box's shared login is mounted elsewhere (supervisor.ts
+   * `loginDirOf`). */
+  loginDir?: string;
   /** Run the daemon's pump (a lease freed, a worker gone). Late-bound: the daemon is built
    * after this. */
   pump: () => Promise<void>;
@@ -206,6 +211,8 @@ export function buildWorkerWorld(o: WorkerWorldOptions): WorkerWorld {
       root,
       cwd: root,
       agent_dir: o.agentDir,
+      ...(o.loginDir !== undefined && o.loginDir !== o.agentDir ? { login_dir: o.loginDir } : {}),
+      providers: reviewProviders(cfg),
       session_dir: sessions.sessionDir(row.session),
       system_prompt_file: sessions.writeSystemPrompt(row.session, prompt),
       model: cfg.models.conversation,
@@ -255,6 +262,7 @@ export function buildWorkerWorld(o: WorkerWorldOptions): WorkerWorld {
       takeoverPlanFor({
         root,
         agentDir: o.agentDir,
+        ...(o.loginDir !== undefined ? { loginDir: o.loginDir } : {}),
         sessionsRoot: sessions.sessionsRoot(),
         model: cfg.models.conversation,
         pr,