@quickchatai/quickreview 1.2.0 → 1.3.1

package/src/config.ts

@@ -1158,6 +1158,43 @@ export interface Config extends CoreConfig {
   /** The bot login's single refresher (`src/loginrefresh/`). Optional
    * in the file; off unless the cutover's config turns it on. */
   login_refresh: LoginRefreshConfig;
+  /** The home, the app's own pi a bare `qcr` opens (src/home/launch.ts).
+   * Optional in the file and here, so hand-rolled configs keep compiling;
+   * the parser fills every key. */
+  home?: HomeConfig;
+}
+
+/** Which tools the home's model may call: `reviewer` is the plugin's tools,
+ * the home's own `home_*` tools and pi's read tools; `full` is all of pi's. */
+export type HomeToolSet = "reviewer" | "full";
+
+/** `[home]`: the home a bare `qcr` opens (src/home/launch.ts reads it). */
+export interface HomeConfig {
+  /** The chat's model, `provider/id`. The panel's login line counts only
+   * this model's provider as signed in. */
+  model: string;
+  tools: HomeToolSet;
+}
+
+export const HOME_DEFAULTS: Readonly<HomeConfig> = {
+  model: "openai-codex/gpt-6.1-sol",
+  tools: "reviewer",
+};
+
+/** `[home]`, every key defaulted; a value of the wrong kind is refused. */
+export function parseHomeSection(raw: unknown): HomeConfig {
+  const t = (raw ?? {}) as Record<string, unknown>;
+  const model = t["model"] ?? HOME_DEFAULTS.model;
+  if (typeof model !== "string" || !/^[^/\s]+\/\S+$/.test(model))
+    throw new Error(
+      `config.toml [home]: model must be "provider/id" (got ${JSON.stringify(model)})`,
+    );
+  const tools = t["tools"] ?? HOME_DEFAULTS.tools;
+  if (tools !== "reviewer" && tools !== "full")
+    throw new Error(
+      `config.toml [home]: tools must be "reviewer" or "full" (got ${JSON.stringify(tools)})`,
+    );
+  return { model, tools };
 }
 
 /**
@@ -1822,6 +1859,7 @@ export function parseConfig(toml: string): Config {
       (raw.login_refresh ?? {}) as Record<string, unknown>,
       Number((req(raw, "daemon") as { round_deadline_min?: number }).round_deadline_min ?? 75),
     ),
+    home: parseHomeSection(raw.home),
   };
   validateReviewSection(cfg);
   foldLegacyOwnerSlackId(raw, cfg.owner);

package/src/daemon.ts

@@ -832,6 +832,8 @@ export function createDaemon(deps: DaemonDeps = {}): Daemon {
 
   /** The open PRs the last listing reconcile pass saw (status.json `open_prs`). */
   let openPrs: OpenPrsSnapshot | undefined;
+  /** The last reconcile pass (status.json `poll`): null until one has ended. */
+  let lastPoll: { at: string; ok: boolean; error?: string } | null = null;
   let firstReconcileSeen = false;
   let firstHealthyReconcileAt: Date | null = null;
   // Deploy-window drain auto-lift: only the boot's first reconcile pass may
@@ -888,6 +890,7 @@ export function createDaemon(deps: DaemonDeps = {}): Daemon {
     const bootFirstPass = !firstReconcileSeen;
     firstReconcileSeen = true;
     let completed = false;
+    let thrown: unknown = undefined;
     await guard("reconcile", async () => {
       const report = await reconcileOnce({
         cfg,
@@ -914,7 +917,15 @@ export function createDaemon(deps: DaemonDeps = {}): Daemon {
         // sweep reads session transcripts and is not needed for that, so it
         // starts on the next pass to keep the boot pass short.
         receiptSweep: !bootFirstPass,
+      }).catch((err: unknown) => {
+        thrown = err;
+        throw err;
       });
+      lastPoll = {
+        at: report.ran_at,
+        ok: report.errors.length === 0,
+        ...(report.errors[0] !== undefined ? { error: report.errors[0] } : {}),
+      };
       // The board's "review a PR" list: kept from the last pass that listed.
       if (report.open_list) openPrs = { listed_at: report.ran_at, prs: report.open_list };
       log(
@@ -957,6 +968,15 @@ export function createDaemon(deps: DaemonDeps = {}): Daemon {
       }
       completed = true;
     });
+    if (thrown !== undefined)
+      lastPoll = {
+        at: (deps.now ? deps.now() : new Date()).toISOString(),
+        ok: false,
+        error: `the reconcile pass failed: ${thrown instanceof Error ? thrown.message : JSON.stringify(thrown)}`,
+      };
+    // The poll's outcome reaches status.json now, not at the next heartbeat:
+    // "working" is judged on it.
+    writeStatus();
     return completed;
   };
 
@@ -1122,6 +1142,12 @@ export function createDaemon(deps: DaemonDeps = {}): Daemon {
             };
         }
       if (openPrs) snapshot.open_prs = openPrs;
+      snapshot.poll = {
+        last_at: lastPoll?.at ?? null,
+        ok: lastPoll?.ok ?? null,
+        ...(lastPoll?.error !== undefined ? { error: lastPoll.error } : {}),
+        interval_s: cfg.daemon.poll_interval_s,
+      };
       if (deps.runHost) snapshot.run_host = deps.runHost;
       writeStatusJson(stateDir, snapshot);
     } catch (err) {

package/src/debuground.ts

@@ -123,6 +123,8 @@ export interface DebugRoundSpec {
   cwd: string;
   /** The login's owner dir: read-only, borrowed from. */
   agent_dir: string;
+  /** The login's dir when it is not `agent_dir` (the worker spec's). */
+  login_dir?: string;
   /** Where the pi's own agent dir (the blanked login copy) is made. */
   borrow_dir: string;
   /** The window the borrowed login must outlast. */
@@ -603,6 +605,7 @@ export class DebugRoundManager {
       root: spec.root,
       cwd: spec.cwd,
       agent_dir: spec.agent_dir,
+      ...(spec.login_dir !== undefined ? { login_dir: spec.login_dir } : {}),
       borrow_dir: borrow,
       idle_ms: this.idleMs,
       ...(file !== undefined ? { session_file: file } : {}),

package/src/debugroundpi.ts

@@ -83,6 +83,7 @@ export function readDebugSpec(file: string): DebugRoundSpec {
     raw.session !== debugSession(raw.pr) ||
     typeof raw.command_id !== "string" ||
     typeof raw.agent_dir !== "string" ||
+    (raw.login_dir !== undefined && typeof raw.login_dir !== "string") ||
     typeof raw.borrow_dir !== "string" ||
     typeof raw.session_dir !== "string" ||
     typeof raw.model !== "string" ||

package/src/engine/caserunner-sdk.ts

@@ -1,12 +1,6 @@
-// The scan's leaf runner on the SDK: SetupEngine's `CaseRunner` port
-// (src/setup/engine.ts) over the runtime port, the in-process twin of
-// `piCaseRunner` (src/setup/caserunner.ts). One case is one session on the
-// runtime, with the same pieces the child process gets: the agent file's model,
-// tools and body (appended to pi's own system prompt), bash-guard the one
-// extension, no skill and no context file, a cwd that is first-party ground and
-// never the reviewed checkout, and the allowlisted env. The outcome, the reads
-// and the kept transcript are read off the same event stream by the same
-// reader (`caseReadout`), so a case answers identically whichever host ran it.
+// The scan driver's SDK leaves: the leaf runner on the SDK (scanleaves.ts
+// `sdkCaseRunner`, the in-process twin of `piCaseRunner`) over a host this
+// module builds per case, on the owner's borrowed login.
 //
 // WHERE IT RUNS. Only in scancli's detached driver, a disposable one-scan
 // process (the scan sandbox or the host process `detachDriver` starts), whose
@@ -20,27 +14,10 @@
 // login (engineCredentials): a token the companion refreshed mid-scan is
 // picked up at the next case, a token the case would not outlive is refused
 // before it starts, and nothing is ever refreshed or written here.
+import { copyFileSync, existsSync, mkdirSync, rmSync } from "node:fs";
+import { homedir } from "node:os";
+import { isAbsolute, join } from "node:path";
 import {
-  appendFileSync,
-  copyFileSync,
-  existsSync,
-  mkdirSync,
-  mkdtempSync,
-  readFileSync,
-  rmSync,
-  writeFileSync,
-} from "node:fs";
-import { homedir, tmpdir } from "node:os";
-import { basename, dirname, isAbsolute, join } from "node:path";
-import type { ExtensionFactory } from "@earendil-works/pi-coding-agent";
-import {
-  bashGuardConfigFromEnv,
-  createBashGuard,
-} from "@quickchatai/pi-quickreview/extensions/bash-guard.js";
-import { CASE_STOP_GRACE_MS } from "@quickchatai/pi-quickreview/src/casebudget.js";
-import { splitModelSpec } from "../config.js";
-import {
-  AuthError,
   AuthExpiring,
   SCAN_AUTH_SRC_ENV,
   SCAN_CASE_AUTH_BUDGET_MS,
@@ -48,293 +25,30 @@ import {
   scanAuthExpiring,
   scanAuthMissing,
 } from "@quickchatai/pi-quickreview/src/engine/auth.js";
-import {
-  TRANSCRIPT_RUNS_KEPT,
-  caseReadout,
-  leafEnv,
-  parseAgentFile,
-  pruneTranscripts,
-  stderrExcerpt,
-  transcriptFile,
-  type AgentFile,
-} from "../setup/caserunner.js";
-import type { CaseOutcome, CaseRunner, CaseSpec } from "../setup/engine.js";
-import { LENS_SESSIONS_DIR } from "@quickchatai/pi-quickreview/src/engine/openable.js";
 import { PiHost } from "@quickchatai/pi-quickreview/src/engine/pisdk.js";
-import type {
-  Runtime,
-  SessionSpec,
-  TurnResult,
-} from "@quickchatai/pi-quickreview/src/engine/port.js";
-import {
-  sdkRuntime,
-  type SessionExtras,
-} from "@quickchatai/pi-quickreview/src/engine/sdkruntime.js";
+import { sdkRuntime } from "@quickchatai/pi-quickreview/src/engine/sdkruntime.js";
 import { BUDGET_EXIT_CODE } from "@quickchatai/pi-quickreview/src/engine/budget.js";
-
-/** A leaf turn's hard wall clock. The login's own case budget
- * (`SCAN_CASE_AUTH_BUDGET_MS`) is the usual bound and aborts first; this one
- * only backs it where no login budget applies, and is kept past it so the
- * budget's last-resort step (it ends the process) never races the abort. */
-export const LEAF_TURN_TIMEOUT_MS = SCAN_CASE_AUTH_BUDGET_MS + 15 * 60_000;
-
-/** What the model's bash may draw from the leaf env, beyond pi's defaults:
- * certificates, proxies, XDG dirs and the temp dirs. Never a provider key. */
-const LEAF_BASH_ENV_ALLOW: readonly string[] = [
-  "TMP",
-  "TEMP",
-  "XDG_*",
-  "SSL_CERT_FILE",
-  "SSL_CERT_DIR",
-  "NODE_EXTRA_CA_CERTS",
-  "HTTP_PROXY",
-  "HTTPS_PROXY",
-  "NO_PROXY",
-  "ALL_PROXY",
-  "http_proxy",
-  "https_proxy",
-  "no_proxy",
-  "all_proxy",
-];
-
-/** The per-session pieces the runner hands whoever builds the runtime: the
- * `extras` of `sdkRuntime` (packages/pi-plugin/src/engine/sdkruntime.ts). */
-export type LeafExtras = (spec: SessionSpec) => SessionExtras;
-
-export interface SdkCaseRunnerOptions {
-  /** The scan agent build: `<agent>.md` files. */
-  agentsDir: string;
-  /** The leaf's working directory: first-party ground, never the reviewed
-   * checkout (whose own pi config must not load). Also what a relative read is
-   * resolved against. */
-  cwd: string;
-  /** Where each case's event stream is kept; absent, none is. */
-  transcriptDir?: string;
-  /** The env the leaf's env is filtered from. Omitted: process.env. */
-  env?: NodeJS.ProcessEnv;
-  /** The model of an agent that names none. */
-  defaultModel?: string;
-  /** The runtime this case runs on, built with the case's `extras`. Called once
-   * per case: a route that must re-read its login per case builds its host
-   * here. */
-  runtime: (extras: LeafExtras) => Runtime | Promise<Runtime>;
-  /** The guard extension. Omitted: bash-guard over the leaf env. */
-  guard?: ExtensionFactory;
-  /** Wall clock for a case's turn. Omitted: `LEAF_TURN_TIMEOUT_MS`. */
-  timeoutMs?: number;
-}
-
-/** A transcript's path under `dir`, relative and absolute, with its run
- * directory made (and the old runs pruned when it is new); null when it cannot
- * be made. A transcript is evidence, never a reason to fail a case. */
-function openTranscript(dir: string, id: string): { rel: string; at: string } | null {
-  try {
-    const rel = transcriptFile(id);
-    const at = join(dir, rel);
-    const runDir = rel.includes("/") ? rel.slice(0, rel.indexOf("/")) : null;
-    const fresh = runDir !== null && !existsSync(join(dir, runDir));
-    mkdirSync(dirname(at), { recursive: true });
-    if (fresh) pruneTranscripts(dir, TRANSCRIPT_RUNS_KEPT, runDir);
-    writeFileSync(at, "", { mode: 0o600 });
-    return { rel, at };
-  } catch {
-    return null;
-  }
-}
-
-/** Where a case's session JSONL goes: `<run>/lens-sessions/<case>/` beside the
- * transcript `rel` names (`<run>/<case>.jsonl`). */
-export function caseSessionDir(transcriptDir: string, rel: string): string {
-  return join(transcriptDir, dirname(rel), LENS_SESSIONS_DIR, basename(rel, ".jsonl"));
-}
-
-/**
- * Runs a case as one SDK session, the way `piCaseRunner` runs it as one child:
- * the agent's model (its `:thinking` suffix as the session's thinking level),
- * its tools, its body appended to pi's system prompt, the task as the one
- * message. The answer is the last assistant message's text; the cost is pi's
- * own per-message accounting summed (null when it reported none); `reads` is the
- * `read`/`grep` calls that finished without an error, resolved against `cwd`.
- * With `transcriptDir` the session's whole event stream is kept at
- * `transcriptFile(spec.id)` under it, the format `pi --mode json` prints, and
- * its session JSONL beside it (`caseSessionDir`). An
- * abort stops the session (abort, then dispose after the stop grace). Every
- * outcome resolves — a runtime that cannot be built or a session that cannot
- * start is a failed case, never a rejection.
- */
-export function sdkCaseRunner(opts: SdkCaseRunnerOptions): CaseRunner {
-  return {
-    run: async (
-      spec: CaseSpec,
-      signal: AbortSignal,
-      onCost?: (spentSoFar: number) => void,
-    ): Promise<CaseOutcome> => {
-      if (!/^[a-z][a-z0-9-]*$/.test(spec.agent))
-        return {
-          ok: false,
-          reason: `not an agent name: ${JSON.stringify(spec.agent)}`,
-          cost_usd: 0,
-        };
-      let agent: AgentFile | null;
-      try {
-        agent = parseAgentFile(readFileSync(join(opts.agentsDir, `${spec.agent}.md`), "utf8"));
-      } catch {
-        return { ok: false, reason: `no agent ${spec.agent} in ${opts.agentsDir}`, cost_usd: 0 };
-      }
-      if (agent === null || agent.name !== spec.agent)
-        return { ok: false, reason: `${spec.agent}.md is not an agent file`, cost_usd: 0 };
-      const modelSpec = agent.model ?? opts.defaultModel;
-      if (!modelSpec)
-        return { ok: false, reason: `${spec.agent} names no model and none is set`, cost_usd: 0 };
-      if (signal.aborted) return { ok: false, reason: "stopped before it started", cost_usd: 0 };
-
-      let tmp: string;
-      try {
-        tmp = mkdtempSync(join(tmpdir(), "qcr-case-"));
-      } catch (err) {
-        return { ok: false, reason: `no temp directory for the case: ${String(err)}`, cost_usd: 0 };
-      }
-      let session: Awaited<ReturnType<Runtime["create"]>> | undefined;
-      try {
-        const env = leafEnv(opts.env);
-        const { model, thinking } = splitModelSpec(modelSpec);
-        const guard = opts.guard ?? createBashGuard(bashGuardConfigFromEnv(env, opts.cwd));
-        const extras: LeafExtras = () => ({
-          extensions: [guard],
-          appendSystemPrompt: [agent.systemPrompt],
-          bashEnv: { allow: LEAF_BASH_ENV_ALLOW },
-          ...(thinking !== null
-            ? { thinkingLevel: thinking as NonNullable<SessionExtras["thinkingLevel"]> }
-            : {}),
-        });
-        // The transcript: opened before the session, appended event by event,
-        // abandoned (and its name dropped from the outcome) at the first write
-        // that fails.
-        const opened =
-          opts.transcriptDir !== undefined ? openTranscript(opts.transcriptDir, spec.id) : null;
-        const sessionSpec: SessionSpec = {
-          cwd: opts.cwd,
-          env,
-          model,
-          ...(agent.tools.length > 0 ? { tools: agent.tools } : {}),
-          name: spec.id,
-          // The case's session JSONL beside its transcript, so the case
-          // opens in pi: `qcr open <run dir> --lens <case>`.
-          ...(opts.transcriptDir !== undefined && opened !== null
-            ? { sessionDir: caseSessionDir(opts.transcriptDir, opened.rel) }
-            : {}),
-          eventsFile: join(tmp, "events.jsonl"),
-          stderrFile: join(tmp, "stderr.txt"),
-          limits: { timeoutMs: opts.timeoutMs ?? LEAF_TURN_TIMEOUT_MS },
-        };
-
-        let transcript: string | undefined = opened?.rel;
-        let transcriptAt: string | null = opened?.at ?? null;
-        const keep = (event: unknown): void => {
-          if (transcriptAt === null) return;
-          try {
-            appendFileSync(transcriptAt, JSON.stringify(event) + "\n");
-          } catch {
-            transcriptAt = null;
-            transcript = undefined;
-          }
-        };
-        const readout = caseReadout(opts.cwd, onCost);
-        const finish = <T extends CaseOutcome>(o: T): T =>
-          transcript === undefined ? o : { ...o, transcript };
-
-        try {
-          const runtime = await opts.runtime(extras);
-          session = await runtime.create(sessionSpec);
-        } catch (err) {
-          const reason = err instanceof Error ? err.message : String(err);
-          // A refused login already says what to do; anything else is the host's.
-          return {
-            ok: false,
-            reason: err instanceof AuthError ? reason : `could not start the session: ${reason}`,
-            cost_usd: 0,
-          };
-        }
-        session.subscribe((event) => {
-          keep(event);
-          readout.feed(event);
-        });
-
-        let stopped = false;
-        let hardStop: ((o: CaseOutcome) => void) | undefined;
-        const gone = new Promise<CaseOutcome>((resolve) => {
-          hardStop = resolve;
-        });
-        const onAbort = (): void => {
-          stopped = true;
-          const live = session;
-          void live?.abort().catch(() => {});
-          // The stop grace, then the session is released; a turn still not
-          // settled a grace later is given up on, so the case resolves.
-          setTimeout(() => void live?.dispose().catch(() => {}), CASE_STOP_GRACE_MS).unref();
-          setTimeout(
-            () => hardStop?.({ ok: false, reason: "stopped", cost_usd: readout.spent() }),
-            2 * CASE_STOP_GRACE_MS,
-          ).unref();
-        };
-        signal.addEventListener("abort", onAbort, { once: true });
-        if (signal.aborted) {
-          onAbort();
-          // Cancelled while the session was being created: no turn starts.
-          return finish({ ok: false, reason: "stopped", cost_usd: 0 });
-        }
-
-        const turn = (async (): Promise<CaseOutcome> => {
-          let result: TurnResult;
-          try {
-            result = await session.prompt(`Task: ${spec.prompt}`);
-          } catch (err) {
-            return {
-              ok: false,
-              reason: `the session failed: ${err instanceof Error ? err.message : String(err)}`,
-              cost_usd: readout.spent(),
-            };
-          }
-          // What a case that ended without an answer had spent: a failure costs
-          // money too, and a caller holding a budget must count it.
-          const cost_usd = readout.spent();
-          if (stopped) return { ok: false, reason: "stopped", cost_usd };
-          if (result.timedOut)
-            return { ok: false, reason: "the case ran past its wall clock", cost_usd };
-          // The model's own reason leads: a provider error also ends the turn non-zero.
-          if (readout.failure !== null) return { ok: false, reason: readout.failure, cost_usd };
-          if (result.code !== 0) {
-            let tail = "";
-            try {
-              tail = stderrExcerpt(readFileSync(sessionSpec.stderrFile, "utf8"));
-            } catch {
-              // No stderr to quote.
-            }
-            return {
-              ok: false,
-              reason: `the session ended without a result${tail ? `: ${tail}` : ""}`,
-              cost_usd,
-            };
-          }
-          if (readout.final.trim() === "")
-            return { ok: false, reason: "the subagent gave no answer", cost_usd };
-          return { ok: true, output: readout.final, cost_usd, reads: readout.reads };
-        })();
-        try {
-          return finish(await Promise.race([turn, gone]));
-        } finally {
-          signal.removeEventListener("abort", onAbort);
-        }
-      } finally {
-        try {
-          await session?.dispose();
-        } catch {
-          // Already released.
-        }
-        rmSync(tmp, { recursive: true, force: true });
-      }
-    },
-  };
+import type { CaseRunner } from "@quickchatai/pi-quickreview/src/scan/scanports.js";
+import {
+  LEAF_TURN_TIMEOUT_MS,
+  sdkCaseRunner as sdkCaseRunnerOver,
+  type SdkCaseRunnerOptions,
+} from "@quickchatai/pi-quickreview/src/scan/scanleaves.js";
+
+export {
+  LEAF_TURN_TIMEOUT_MS,
+  caseSessionDir,
+  type LeafExtras,
+  type SdkCaseRunnerOptions,
+} from "@quickchatai/pi-quickreview/src/scan/scanleaves.js";
+
+/** `sdkCaseRunner` (scanleaves.ts) in this process: the leaf env filtered
+ * from this process's env and a read's `~` taken as this process's home,
+ * unless told otherwise. */
+export function sdkCaseRunner(
+  opts: Omit<SdkCaseRunnerOptions, "env" | "home"> & { env?: NodeJS.ProcessEnv; home?: string },
+): CaseRunner {
+  return sdkCaseRunnerOver({ ...opts, env: opts.env ?? process.env, home: opts.home ?? homedir() });
 }
 
 // ---- the scan driver's host ----------------------------------------------------
@@ -380,6 +94,7 @@ export function scanSdkCases(o: ScanSdkCasesOptions): CaseRunner {
     throw new Error(`the SDK host's agentDir must be absolute: ${o.agentDir}`);
   return sdkCaseRunner({
     agentsDir: o.agentsDir,
+    home: homedir(),
     cwd: o.cwd,
     ...(o.transcriptDir !== undefined ? { transcriptDir: o.transcriptDir } : {}),
     env: o.env,