@qooxdoo/framework 7.9.2 → 8.0.0-beta.2

package/source/class/qx/ui/window/IWindowManager.js

@@ -30,8 +30,10 @@ qx.Interface.define("qx.ui.window.IWindowManager", {
      * @param desktop {qx.ui.window.IDesktop|null} The connected desktop or null
      */
     setDesktop(desktop) {
-      if (desktop !== null) {
-        this.assertInterface(desktop, qx.ui.window.IDesktop);
+      if (qx.core.Environment.get("qx.debug")) {
+        if (desktop !== null) {
+          this.assertInterface(desktop, qx.ui.window.IDesktop);
+        }
       }
     },
 
@@ -54,7 +56,9 @@ qx.Interface.define("qx.ui.window.IWindowManager", {
      * @param win {qx.ui.window.Window} window to bring to front
      */
     bringToFront(win) {
-      this.assertInstance(win, qx.ui.window.Window);
+      if (qx.core.Environment.get("qx.debug")) {
+        this.assertInstance(win, qx.ui.window.Window);
+      }
     },
 
     /**
@@ -63,7 +67,9 @@ qx.Interface.define("qx.ui.window.IWindowManager", {
      * @param win {qx.ui.window.Window} window to sent to back
      */
     sendToBack(win) {
-      this.assertInstance(win, qx.ui.window.Window);
+      if (qx.core.Environment.get("qx.debug")) {
+        this.assertInstance(win, qx.ui.window.Window);
+      }
     }
   }
 });

package/source/class/qx/ui/window/MDesktop.js

@@ -38,7 +38,8 @@ qx.Mixin.define("qx.ui.window.MDesktop", {
       apply: "_applyActiveWindow",
       event: "changeActiveWindow",
       init: null,
-      nullable: true
+      nullable: true,
+      autoApply: false
     }
   },
 

package/source/class/qx/ui/window/Manager.js

@@ -81,7 +81,7 @@ qx.Class.define("qx.ui.window.Manager", {
      * {@link qx.ui.core.queue.Widget widget queue}.
      */
     syncWidget() {
-      if (this.isDisposed()){
+      if (this.isDisposed()) {
         return;
       }
       this.__desktop.forceUnblock();

package/source/class/qx/ui/window/Window.js

@@ -641,10 +641,12 @@ qx.Class.define("qx.ui.window.Window", {
         return;
       }
 
-      if (! this.fireNonBubblingEvent(
-              "beforeClose",
-              qx.event.type.Event,
-              [ false, true ])) {
+      if (
+        !this.fireNonBubblingEvent("beforeClose", qx.event.type.Event, [
+          false,
+          true
+        ])
+      ) {
         // preventDefault() was called
         return;
       }

package/source/class/qx/util/OOUtil.js

@@ -41,15 +41,14 @@ qx.Bootstrap.define("qx.util.OOUtil", {
      * @return {Map|null} whether the object support the given event.
      */
     getPropertyDefinition(clazz, name) {
-      while (clazz) {
-        if (clazz.$$properties && clazz.$$properties[name]) {
-          return clazz.$$properties[name];
-        }
-
-        clazz = clazz.superclass;
+      let property = clazz.prototype.$$allProperties?.[name];
+      if (!property) {
+        return null;
       }
-
-      return null;
+      while (property.getSuperClass()) {
+        property = qx.Class.getByProperty(property.getSuperClass(), name);
+      }
+      return property.getDefinition();
     },
 
     /**
@@ -72,7 +71,7 @@ qx.Bootstrap.define("qx.util.OOUtil", {
      * @return {String|null} Event type of the given event.
      */
     getEventType(clazz, name) {
-      var clazz = clazz.constructor;
+      clazz = clazz.constructor;
 
       while (clazz.superclass) {
         if (clazz.$$events && clazz.$$events[name] !== undefined) {

package/source/class/qx/util/PropertyUtil.js

@@ -21,185 +21,65 @@
  *
  * This class is rather to be used internally. For all regular usage of the
  * property system the default API should be sufficient.
+ *
+ * Prior to v8, this class included methods to get/set the user, theme, and init values
+ * of properties independently - this methods circumvented the normal operation of the
+ * property mechanism.  It could be argued that the `get` methods are alloweed, and
+ * in some cases can be replicated via the property system, but their meaning was different,
+ * ie even `getUserValue` would not return the value of the property, but the value set
+ * by a user and not overridden by a theme.  For this reason, the `get` methods are not
+ * truely compatible and anyone using those methods should think again about exactly what
+ * they are trying to achieve, and probably revise their process.
+ *
+ * As it stands, any use of this class needs to be reviewed from v8 onwards because the
+ * `getProperties`/`getAllProperties` methods return instances of `qx.core.property.Property`
+ * and not the old POJO.
  */
 qx.Class.define("qx.util.PropertyUtil", {
   statics: {
     /**
      * Get the property map of the given class
      *
-     * @param clazz {Class} a qooxdoo class
-     * @return {Map} A properties map as defined in {@link qx.Class#define}
+     * @param clazz {qx.Class|qx.core.Object} a qooxdoo class
+     * @return {Object<String,qx.core.property.Property>} A properties map as defined in {@link qx.Class#define}
      *   including the properties of included mixins and not including refined
      *   properties.
      */
     getProperties(clazz) {
-      return clazz.$$properties;
+      if (clazz instanceof qx.core.Object) {
+        clazz = clazz.constructor;
+      }
+      return clazz.prototype.$$properties;
     },
 
     /**
      * Get the property map of the given class including the properties of all
-     * superclasses!
+     * superclasses
      *
-     * @param clazz {Class} a qooxdoo class
-     * @return {Map} The properties map as defined in {@link qx.Class#define}
+     * @param clazz {qx.Class|qx.core.Object} a qooxdoo class
+     * @return {Object<String,qx.core.property.Property>} The properties map as defined in {@link qx.Class#define}
      *   including the properties of included mixins of the current class and
      *   all superclasses.
      */
     getAllProperties(clazz) {
-      var properties = {};
-      var superclass = clazz;
-      // go threw the class hierarchy
-      while (superclass != qx.core.Object) {
-        var currentProperties = this.getProperties(superclass);
-        for (var property in currentProperties) {
-          properties[property] = currentProperties[property];
-        }
-        superclass = superclass.superclass;
+      if (clazz instanceof qx.core.Object) {
+        clazz = clazz.constructor;
       }
-      return properties;
-    },
-
-    /*
-    -------------------------------------------------------------------------
-      USER VALUES
-    -------------------------------------------------------------------------
-    */
-
-    /**
-     * Returns the user value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     * @return {var} The user value
-     */
-    getUserValue(object, propertyName) {
-      return object["$$user_" + propertyName];
-    },
-
-    /**
-     * Sets the user value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     * @param value {var} The value to set
-     */
-    setUserValue(object, propertyName, value) {
-      object["$$user_" + propertyName] = value;
-    },
-
-    /**
-     * Deletes the user value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     */
-    deleteUserValue(object, propertyName) {
-      delete object["$$user_" + propertyName];
-    },
-
-    /*
-    -------------------------------------------------------------------------
-      INIT VALUES
-    -------------------------------------------------------------------------
-    */
-
-    /**
-     * Returns the init value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     * @return {var} The init value
-     */
-    getInitValue(object, propertyName) {
-      return object["$$init_" + propertyName];
-    },
-
-    /**
-     * Sets the init value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     * @param value {var} The value to set
-     */
-    setInitValue(object, propertyName, value) {
-      object["$$init_" + propertyName] = value;
-    },
-
-    /**
-     * Deletes the init value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     */
-    deleteInitValue(object, propertyName) {
-      delete object["$$init_" + propertyName];
+      return clazz.prototype.$$allProperties;
     },
 
-    /*
-    -------------------------------------------------------------------------
-      THEME VALUES
-    -------------------------------------------------------------------------
-    */
-
     /**
-     * Returns the theme value of the given property
+     * Returns the property object for a givemn property
      *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     * @return {var} The theme value
+     * @param {qx.Class|qx.core.Object} clazz
+     * @param {String} propertyName
+     * @returns {qx.core.property.Property}
      */
-    getThemeValue(object, propertyName) {
-      return object["$$theme_" + propertyName];
-    },
-
-    /**
-     * Sets the theme value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     * @param value {var} The value to set
-     */
-    setThemeValue(object, propertyName, value) {
-      object["$$theme_" + propertyName] = value;
-    },
-
-    /**
-     * Deletes the theme value of the given property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     */
-    deleteThemeValue(object, propertyName) {
-      delete object["$$theme_" + propertyName];
-    },
-
-    /*
-    -------------------------------------------------------------------------
-      THEMED PROPERTY
-    -------------------------------------------------------------------------
-    */
-
-    /**
-     * Sets a themed property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     * @param value {var} The value to set
-     */
-    setThemed(object, propertyName, value) {
-      var styler = qx.core.Property.$$method.setThemed;
-      object[styler[propertyName]](value);
-    },
-
-    /**
-     * Resets a themed property
-     *
-     * @param object {Object} The object to access
-     * @param propertyName {String} The name of the property
-     */
-    resetThemed(object, propertyName) {
-      var unstyler = qx.core.Property.$$method.resetThemed;
-      object[unstyler[propertyName]]();
+    getProperty(clazz, propertyName) {
+      if (clazz instanceof qx.core.Object) {
+        clazz = clazz.constructor;
+      }
+      return clazz.prototype.$$allProperties[propertyName] || null;
     }
   }
 });

package/source/class/qx/util/ResponseParser.js

@@ -24,6 +24,8 @@
  * @require(qx.util.ResponseParser#parse)
  */
 qx.Bootstrap.define("qx.util.ResponseParser", {
+  extend: qx.core.Object,
+
   /**
    * @param parser {String|Function} See {@link #setParser}.
    */

package/source/class/qx/util/Serializer.js

@@ -24,6 +24,14 @@
  */
 qx.Class.define("qx.util.Serializer", {
   statics: {
+    /**
+     * These properties are ignored when serializing qooxdoo objects
+     * because they are qooxdoo metadata.
+     */
+    __IGNORE_PROPERTIES: {
+      qxObjectId: true,
+      qxOwner: true
+    },
     /**
      * Serializes the properties of the given qooxdoo object. To get the
      * serialization working, every property needs to have a string
@@ -42,37 +50,27 @@ qx.Class.define("qx.util.Serializer", {
      */
     toUriParameter(object, qxSerializer, dateFormat) {
       var result = "";
-      var properties = qx.util.PropertyUtil.getAllProperties(
-        object.constructor
-      );
+      var properties = qx.util.PropertyUtil.getAllProperties(object.constructor);
 
       for (var name in properties) {
+        let property = properties[name];
+
         // ignore property groups
-        if (properties[name].group != undefined) {
+        if (property instanceof qx.core.property.GroupProperty || qx.util.Serializer.__IGNORE_PROPERTIES[name]) {
           continue;
         }
-        var value = object["get" + qx.lang.String.firstUp(name)]();
+        var value = object[name];
 
         // handle arrays
         if (qx.lang.Type.isArray(value)) {
-          var isdataArray =
-            qx.data &&
-            qx.data.IListData &&
-            qx.Class.hasInterface(
-              value && value.constructor,
-              qx.data.IListData
-            );
+          var isdataArray = qx.data && qx.data.IListData && qx.Class.hasInterface(value && value.constructor, qx.data.IListData);
 
           for (var i = 0; i < value.length; i++) {
             var valueAtI = isdataArray ? value.getItem(i) : value[i];
             result += this.__toUriParameter(name, valueAtI, qxSerializer);
           }
         } else if (qx.lang.Type.isDate(value) && dateFormat != null) {
-          result += this.__toUriParameter(
-            name,
-            dateFormat.format(value),
-            qxSerializer
-          );
+          result += this.__toUriParameter(name, dateFormat.format(value), qxSerializer);
         } else {
           result += this.__toUriParameter(name, value, qxSerializer);
         }
@@ -90,12 +88,9 @@ qx.Class.define("qx.util.Serializer", {
      * @return {String} The serialized name value pair.
      */
     __toUriParameter(name, value, qxSerializer) {
-      if (value && value.$$type == "Class") {
-        value = value.classname;
-      }
-
-      if (value && (value.$$type == "Interface" || value.$$type == "Mixin")) {
-        value = value.name;
+      const Serializer = qx.util.Serializer;
+      if (value && Serializer.__isClassy(value)) {
+        value = Serializer.__getNameOfClassy(value);
       }
 
       if (value instanceof qx.core.Object && qxSerializer != null) {
@@ -129,6 +124,7 @@ qx.Class.define("qx.util.Serializer", {
      *   type will vary.
      */
     toNativeObject(object, qxSerializer, dateFormat) {
+      const Serializer = qx.util.Serializer;
       var result;
 
       // null or undefined
@@ -137,20 +133,10 @@ qx.Class.define("qx.util.Serializer", {
       }
 
       // data array
-      if (
-        qx.data &&
-        qx.data.IListData &&
-        qx.Class.hasInterface(object.constructor, qx.data.IListData)
-      ) {
+      if (qx.data && qx.data.IListData && qx.Class.hasInterface(object.constructor, qx.data.IListData)) {
         result = [];
         for (var i = 0; i < object.getLength(); i++) {
-          result.push(
-            qx.util.Serializer.toNativeObject(
-              object.getItem(i),
-              qxSerializer,
-              dateFormat
-            )
-          );
+          result.push(qx.util.Serializer.toNativeObject(object.getItem(i), qxSerializer, dateFormat));
         }
 
         return result;
@@ -160,26 +146,14 @@ qx.Class.define("qx.util.Serializer", {
       if (qx.lang.Type.isArray(object)) {
         result = [];
         for (var i = 0; i < object.length; i++) {
-          result.push(
-            qx.util.Serializer.toNativeObject(
-              object[i],
-              qxSerializer,
-              dateFormat
-            )
-          );
+          result.push(qx.util.Serializer.toNativeObject(object[i], qxSerializer, dateFormat));
         }
 
         return result;
       }
 
-      // return names for qooxdoo classes
-      if (object.$$type == "Class") {
-        return object.classname;
-      }
-
-      // return names for qooxdoo interfaces and mixins
-      if (object.$$type == "Interface" || object.$$type == "Mixin") {
-        return object.name;
+      if (Serializer.__isClassy(object)) {
+        return Serializer.__getNameOfClassy(object);
       }
 
       // qooxdoo object
@@ -197,22 +171,16 @@ qx.Class.define("qx.util.Serializer", {
 
         result = {};
 
-        var properties = qx.util.PropertyUtil.getAllProperties(
-          object.constructor
-        );
+        var properties = qx.util.PropertyUtil.getAllProperties(object.constructor);
 
         for (var name in properties) {
           // ignore property groups
-          if (properties[name].group != undefined) {
+          if (properties[name] instanceof qx.core.property.GroupProperty || Serializer.__IGNORE_PROPERTIES[name]) {
             continue;
           }
 
-          var value = object["get" + qx.lang.String.firstUp(name)]();
-          result[name] = qx.util.Serializer.toNativeObject(
-            value,
-            qxSerializer,
-            dateFormat
-          );
+          var value = object[name];
+          result[name] = qx.util.Serializer.toNativeObject(value, qxSerializer, dateFormat);
         }
 
         return result;
@@ -224,11 +192,7 @@ qx.Class.define("qx.util.Serializer", {
       }
 
       // localized strings
-      if (
-        qx.locale &&
-        qx.locale.LocalizedString &&
-        object instanceof qx.locale.LocalizedString
-      ) {
+      if (qx.locale && qx.locale.LocalizedString && object instanceof qx.locale.LocalizedString) {
         return object.toString();
       }
 
@@ -237,11 +201,7 @@ qx.Class.define("qx.util.Serializer", {
         result = {};
 
         for (var key in object) {
-          result[key] = qx.util.Serializer.toNativeObject(
-            object[key],
-            qxSerializer,
-            dateFormat
-          );
+          result[key] = qx.util.Serializer.toNativeObject(object[key], qxSerializer, dateFormat);
         }
 
         return result;
@@ -265,6 +225,7 @@ qx.Class.define("qx.util.Serializer", {
      * @return {String} The serialized object.
      */
     toJson(object, qxSerializer, dateFormat) {
+      const Serializer = qx.util.Serializer;
       var result = "";
 
       // null or undefined
@@ -273,19 +234,10 @@ qx.Class.define("qx.util.Serializer", {
       }
 
       // data array
-      if (
-        qx.data &&
-        qx.data.IListData &&
-        qx.Class.hasInterface(object.constructor, qx.data.IListData)
-      ) {
+      if (qx.data && qx.data.IListData && qx.Class.hasInterface(object.constructor, qx.data.IListData)) {
         result += "[";
         for (var i = 0; i < object.getLength(); i++) {
-          result +=
-            qx.util.Serializer.toJson(
-              object.getItem(i),
-              qxSerializer,
-              dateFormat
-            ) + ",";
+          result += qx.util.Serializer.toJson(object.getItem(i), qxSerializer, dateFormat) + ",";
         }
         if (result != "[") {
           result = result.substring(0, result.length - 1);
@@ -297,9 +249,7 @@ qx.Class.define("qx.util.Serializer", {
       if (qx.lang.Type.isArray(object)) {
         result += "[";
         for (var i = 0; i < object.length; i++) {
-          result +=
-            qx.util.Serializer.toJson(object[i], qxSerializer, dateFormat) +
-            ",";
+          result += qx.util.Serializer.toJson(object[i], qxSerializer, dateFormat) + ",";
         }
         if (result != "[") {
           result = result.substring(0, result.length - 1);
@@ -307,14 +257,8 @@ qx.Class.define("qx.util.Serializer", {
         return result + "]";
       }
 
-      // return names for qooxdoo classes
-      if (object.$$type == "Class") {
-        return '"' + object.classname + '"';
-      }
-
-      // return names for qooxdoo interfaces and mixins
-      if (object.$$type == "Interface" || object.$$type == "Mixin") {
-        return '"' + object.name + '"';
+      if (Serializer.__isClassy(object)) {
+        return `"${Serializer.__getNameOfClassy(object)}"`;
       }
 
       // qooxdoo object
@@ -328,22 +272,15 @@ qx.Class.define("qx.util.Serializer", {
           // continue otherwise
         }
         result += "{";
-        var properties = qx.util.PropertyUtil.getAllProperties(
-          object.constructor
-        );
+        var properties = qx.util.PropertyUtil.getAllProperties(object.constructor);
 
         for (var name in properties) {
           // ignore property groups
-          if (properties[name].group != undefined) {
+          if (properties[name] instanceof qx.core.property.GroupProperty || Serializer.__IGNORE_PROPERTIES[name]) {
             continue;
           }
-          var value = object["get" + qx.lang.String.firstUp(name)]();
-          result +=
-            '"' +
-            name +
-            '":' +
-            qx.util.Serializer.toJson(value, qxSerializer, dateFormat) +
-            ",";
+          var value = object[name];
+          result += '"' + name + '":' + qx.util.Serializer.toJson(value, qxSerializer, dateFormat) + ",";
         }
         if (result != "{") {
           result = result.substring(0, result.length - 1);
@@ -352,11 +289,7 @@ qx.Class.define("qx.util.Serializer", {
       }
 
       // localized strings
-      if (
-        qx.locale &&
-        qx.locale.LocalizedString &&
-        object instanceof qx.locale.LocalizedString
-      ) {
+      if (qx.locale && qx.locale.LocalizedString && object instanceof qx.locale.LocalizedString) {
         object = object.toString();
         // no return here because we want to have the string checks as well!
       }
@@ -370,12 +303,7 @@ qx.Class.define("qx.util.Serializer", {
       if (qx.lang.Type.isObject(object)) {
         result += "{";
         for (var key in object) {
-          result +=
-            '"' +
-            key +
-            '":' +
-            qx.util.Serializer.toJson(object[key], qxSerializer, dateFormat) +
-            ",";
+          result += '"' + key + '":' + qx.util.Serializer.toJson(object[key], qxSerializer, dateFormat) + ",";
         }
         if (result != "{") {
           result = result.substring(0, result.length - 1);
@@ -404,6 +332,33 @@ qx.Class.define("qx.util.Serializer", {
 
       // all other stuff
       return object + "";
+    },
+
+    /**
+     * Checks whether object is classy i.e. a class, interface, or mixin.
+     * @param {Object} object Any object
+     * @returns {boolean}
+     */
+    __isClassy(object) {
+      return ["Class", "Interface", "Mixin"].includes(object.$$type);
+    },
+
+    /**
+     *
+     * @param {Object} object Qooxdoo classy object i.e. class or interface or mixin
+     * @returns {string} The name of the classy object, that was passed into the define call
+     */
+    __getNameOfClassy(object) {
+      switch (object.$$type) {
+        case "Class":
+          return object.classname;
+        case "Interface":
+          return object.name;
+        case "Mixin":
+          return object.mixinName;
+        default:
+          throw new Error("Unknown classy type: " + object.$$type);
+      }
     }
   }
 });

package/source/class/qx/util/format/DateFormat.js

@@ -476,8 +476,9 @@ qx.Class.define("qx.util.format.DateFormat", {
 
       var timezoneOffset = date.getTimezoneOffset();
       var timezoneSign = timezoneOffset > 0 ? 1 : -1;
-      var timezoneHours = Math.floor(Math.abs(timezoneOffset) / 60);
-      var timezoneMinutes = Math.abs(timezoneOffset) % 60;
+      var absTimezoneOffset = Math.abs(timezoneOffset);
+      var timezoneHours = Math.floor(absTimezoneOffset / 60);
+      var timezoneMinutes = Math.trunc(absTimezoneOffset) % 60;
 
       // Create the output
       this.__initFormatTree();

package/source/global.d.ts

@@ -0,0 +1,4 @@
+// the reference directive enables tooling to discover the generated type definitions
+/// <reference path="../qooxdoo.d.ts" />
+
+// add custom global declarations here