@qooxdoo/framework 7.9.2 → 8.0.0-beta.2

package/source/class/qx/test/ui/form/Form.js

@@ -442,6 +442,112 @@ qx.Class.define("qx.test.ui.form.Form", {
 
       item.dispose();
       form.dispose();
+    },
+
+    testGetItemWithCapitalizedName() {
+      // Test for issue #10808: getItem() should work with the name provided to add()
+      var form = new qx.ui.form.Form();
+      var item = new qx.ui.form.TextField();
+
+      // Add item with capitalized name
+      form.add(item, "Username Label", null, "Username");
+
+      // getItem() SHOULD work with the original name provided to add()
+      this.assertIdentical(
+        item,
+        form.getItem("Username"),
+        "getItem() should return item with original provided name"
+      );
+
+      // getItem() should NOT work with camelCase - that conversion only happens
+      // in the data controller for model properties
+      this.assertNull(
+        form.getItem("username"),
+        "getItem() should not work with camelCase - form stores original name only"
+      );
+
+      // Verify getItems() returns the item with the original key
+      var items = form.getItems();
+      this.assertIdentical(
+        item,
+        items["Username"],
+        "getItems() should have item under original name key"
+      );
+
+      item.dispose();
+      form.dispose();
+    },
+
+    testGetItemWithLabelGeneratedName() {
+      // Test for issue #10808: Verify label-based name generation preserves original behavior
+      var form = new qx.ui.form.Form();
+      var item1 = new qx.ui.form.TextField();
+      var item2 = new qx.ui.form.TextField();
+
+      // Add item without explicit name - name generated from label (with special chars removed)
+      form.add(item1, "Username");
+      form.add(item2, "Email Address");
+
+      // When no explicit name is provided, the label is used (with special chars stripped)
+      // and the camelCase conversion should NOT apply
+      this.assertIdentical(
+        item1,
+        form.getItem("Username"),
+        "getItem() should work with label-generated name (no conversion)"
+      );
+
+      this.assertIdentical(
+        item2,
+        form.getItem("EmailAddress"),
+        "getItem() should work with label-generated name (spaces removed, no conversion)"
+      );
+
+      // Verify getItems() returns correct keys
+      var items = form.getItems();
+      this.assertIdentical(
+        item1,
+        items["Username"],
+        "Item should be stored with label-generated key"
+      );
+      this.assertIdentical(
+        item2,
+        items["EmailAddress"],
+        "Item should be stored with label-generated key (spaces removed)"
+      );
+
+      item1.dispose();
+      item2.dispose();
+      form.dispose();
+    },
+
+    testExplicitVsLabelGeneratedNames() {
+      // Test to clarify difference between explicit names and label-generated names
+      var form = new qx.ui.form.Form();
+      var explicitItem = new qx.ui.form.TextField();
+      var labelItem = new qx.ui.form.TextField();
+
+      // Explicit name provided
+      form.add(explicitItem, "Some Label", null, "UserName");
+      // No explicit name: label used directly (after cleaning special chars)
+      form.add(labelItem, "EmailAddress");
+
+      // Explicit name: should work with original name
+      this.assertIdentical(
+        explicitItem,
+        form.getItem("UserName"),
+        "getItem() should work with original explicit name"
+      );
+
+      // Label-generated name: should work with the cleaned label
+      this.assertIdentical(
+        labelItem,
+        form.getItem("EmailAddress"),
+        "getItem() should work with label-generated name"
+      );
+
+      explicitItem.dispose();
+      labelItem.dispose();
+      form.dispose();
     }
   }
 });

package/source/class/qx/test/ui/form/FormManager.js

@@ -33,15 +33,16 @@ qx.Class.define("qx.test.ui.form.FormManager", {
       implement: qx.ui.form.renderer.IFormRenderer,
 
       construct(form) {
-        this.groups = [];
-        this.buttons = [];
-
         super(form);
       },
 
       properties: {
-        buttons: {},
-        groups: {}
+        buttons: {
+          initFunction: () => []
+        },
+        groups: {
+          initFunction: () => []
+        }
       },
 
       members: {

package/source/class/qx/test/ui/form/SplitButton.js

@@ -41,7 +41,7 @@ qx.Class.define("qx.test.ui.form.SplitButton", {
       this.assertTrue(arrow.isVisible(), "init arrow");
       this.assertTrue(icon.isVisible(), "init icon");
 
-      this._split.setShow("label");
+      this._split.setShowFeatures("label");
       this.flush();
 
       // check changed values

package/source/class/qx/test/ui/toolbar/OverflowHandling.js

@@ -65,15 +65,15 @@ qx.Class.define("qx.test.ui.toolbar.OverflowHandling", {
     testShow() {
       this.__addButtons();
 
-      this.__toolbar.setShow("label");
-      this.assertEquals(this.__toolbar.getShow(), this.__b1.getShow());
-      this.assertEquals(this.__toolbar.getShow(), this.__b2.getShow());
-      this.assertEquals(this.__toolbar.getShow(), this.__b3.getShow());
-
-      this.__toolbar.setShow("icon");
-      this.assertEquals(this.__toolbar.getShow(), this.__b1.getShow());
-      this.assertEquals(this.__toolbar.getShow(), this.__b2.getShow());
-      this.assertEquals(this.__toolbar.getShow(), this.__b3.getShow());
+      this.__toolbar.setShowFeatures("label");
+      this.assertEquals(this.__toolbar.getShowFeatures(), this.__b1.getShowFeatures());
+      this.assertEquals(this.__toolbar.getShowFeatures(), this.__b2.getShowFeatures());
+      this.assertEquals(this.__toolbar.getShowFeatures(), this.__b3.getShowFeatures());
+
+      this.__toolbar.setShowFeatures("icon");
+      this.assertEquals(this.__toolbar.getShowFeatures(), this.__b1.getShowFeatures());
+      this.assertEquals(this.__toolbar.getShowFeatures(), this.__b2.getShowFeatures());
+      this.assertEquals(this.__toolbar.getShowFeatures(), this.__b3.getShowFeatures());
     },
 
     testSpacing() {
@@ -124,7 +124,7 @@ qx.Class.define("qx.test.ui.toolbar.OverflowHandling", {
         this.__toolbar,
         "showItem",
         function () {
-          self.__container.setWidth(100);
+          self.__container.setWidth(140);
           self.flush();
         },
         function (e) {
@@ -280,16 +280,15 @@ qx.Class.define("qx.test.ui.toolbar.OverflowHandling", {
       var self = this;
       setTimeout(function () {
         self.resume(function () {
-          console.log("" + JSON.stringify(self.__container.getBounds()));
+          console.log("C:" + JSON.stringify(self.__container.getBounds()));
           console.log("1: " + JSON.stringify(self.__b1.getBounds()));
           console.log("2: " + JSON.stringify(self.__b2.getBounds()));
           console.log("3: " + JSON.stringify(self.__b3.getBounds()));
 
           var bounds = self.__b2.getBounds();
-          console.log(JSON.stringify(bounds));
-          self.__container.setWidth(bounds.left + 60);
+          self.__container.setWidth(bounds.left + 70);
           self.flush();
-          console.log("" + JSON.stringify(self.__container.getBounds()));
+          console.log("C:" + JSON.stringify(self.__container.getBounds()));
 
           this.assertEventFired(
             this.__toolbar,

package/source/class/qx/test/ui/toolbar/ToolBar.js

@@ -41,13 +41,13 @@ qx.Class.define("qx.test.ui.toolbar.ToolBar", {
       this.__toolbar.add(this.__b2);
 
       // set a value and check if the buttons get synced
-      this.__toolbar.setShow("label");
-      this.assertEquals("label", this.__b1.getShow());
-      this.assertEquals("label", this.__b2.getShow());
+      this.__toolbar.setShowFeatures("label");
+      this.assertEquals("label", this.__b1.getShowFeatures());
+      this.assertEquals("label", this.__b2.getShowFeatures());
 
       // add another button and check if the value has been applied
       this.__toolbar.add(this.__b3);
-      this.assertEquals("label", this.__b3.getShow());
+      this.assertEquals("label", this.__b3.getShowFeatures());
     },
 
     testPositionStates() {
@@ -118,27 +118,27 @@ qx.Class.define("qx.test.ui.toolbar.ToolBar", {
       this.__toolbar.add(this.__b2);
 
       // assert 'label' isn't default show val
-      this.assertNotEquals("label", this.__b1.getShow());
-      this.assertNotEquals("label", this.__b2.getShow());
+      this.assertNotEquals("label", this.__b1.getShowFeatures());
+      this.assertNotEquals("label", this.__b2.getShowFeatures());
 
       // initialize toolbar with 'label'
-      this.__toolbar.setShow("label");
-      this.assertEquals("label", this.__b1.getShow());
-      this.assertEquals("label", this.__b2.getShow());
+      this.__toolbar.setShowFeatures("label");
+      this.assertEquals("label", this.__b1.getShowFeatures());
+      this.assertEquals("label", this.__b2.getShowFeatures());
 
       // override it for button1
-      this.__b1.setShow("icon");
-      this.assertEquals("icon", this.__b1.getShow());
-      this.assertEquals("label", this.__b2.getShow());
+      this.__b1.setShowFeatures("icon");
+      this.assertEquals("icon", this.__b1.getShowFeatures());
+      this.assertEquals("label", this.__b2.getShowFeatures());
 
       // change it afterwards
-      this.__toolbar.setShow("both");
+      this.__toolbar.setShowFeatures("both");
       this.__toolbar.add(this.__b3);
 
       // assert all 'both'
-      this.assertEquals("both", this.__b1.getShow());
-      this.assertEquals("both", this.__b2.getShow());
-      this.assertEquals("both", this.__b3.getShow());
+      this.assertEquals("both", this.__b1.getShowFeatures());
+      this.assertEquals("both", this.__b2.getShowFeatures());
+      this.assertEquals("both", this.__b3.getShowFeatures());
     },
 
     testRemoveChildByIndex() {

package/source/class/qx/test/ui/tree/TreeFolder.js

@@ -252,19 +252,17 @@ qx.Class.define("qx.test.ui.tree.TreeFolder", {
     //
 
     __themeValueIcon(item) {
-      return qx.util.PropertyUtil.getThemeValue(item, "icon");
+      let property = qx.util.PropertyUtil.getProperty(item, "icon");
+      return property.getThemed(item); // Undocumented access to theme value
     },
 
     __themeValueIconOpened(item) {
-      return qx.util.PropertyUtil.getThemeValue(item, "iconOpened");
+      let property = qx.util.PropertyUtil.getProperty(item, "iconOpened");
+      return property.getThemed(item); // Undocumented access to theme value
     },
 
     __assertIcon(item, expected) {
-      this.assertEquals(
-        expected,
-        item.getChildControl("icon").getSource(),
-        "Unexpected source for icon child control"
-      );
+      this.assertEquals(expected, item.getChildControl("icon").getSource(), "Unexpected source for icon child control");
     },
 
     tearDown() {

package/source/class/qx/test/ui/tree/virtual/AbstractTreeTest.js

@@ -29,6 +29,7 @@ qx.Class.define("qx.test.ui.tree.virtual.AbstractTreeTest", {
   construct() {
     super();
 
+    qx.Class.undefine("qx.test.ui.tree.virtual.Leaf");
     qx.Class.define("qx.test.ui.tree.virtual.Leaf", {
       extend: qx.core.Object,
       include: qx.data.marshal.MEventBubbling,
@@ -59,6 +60,7 @@ qx.Class.define("qx.test.ui.tree.virtual.AbstractTreeTest", {
       }
     });
 
+    qx.Class.undefine("qx.test.ui.tree.virtual.Node");
     qx.Class.define("qx.test.ui.tree.virtual.Node", {
       extend: qx.test.ui.tree.virtual.Leaf,
 

package/source/class/qx/test/ui/tree/virtual/Tree.js

@@ -260,6 +260,42 @@ qx.Class.define("qx.test.ui.tree.virtual.Tree", {
       this.__testBuildLookupTable(expected);
     },
 
+    /**
+     * Test for issue #9390: VirtualTree doesn't render if hideRoot is true
+     * when adding nodes dynamically
+     */
+    testDynamicNodesWithHiddenRoot() {
+      // Create initial model
+      var root = this.createModelAndSetModel(1);
+
+      // Set hideRoot before adding nodes
+      this.tree.setHideRoot(true);
+
+      // Flush to ensure initial rendering
+      this.flush();
+
+      // Get initial visible items (should be root's children)
+      var expectedBefore = this.getVisibleItemsFrom(root, [root]);
+      this.__testBuildLookupTable(expectedBefore);
+
+      // Dynamically add a new branch to the root
+      var newBranch = new qx.test.ui.tree.virtual.Node("Dynamic Branch");
+      this._createNodes(newBranch, 1);
+      root.getChildren().push(newBranch);
+
+      // The tree should automatically update without calling refresh()
+      // Expected items should now include the new branch
+      var expectedAfter = this.getVisibleItemsFrom(root, [root]);
+      this.__testBuildLookupTable(expectedAfter);
+
+      // Verify the new branch is in the lookup table
+      var lookupTable = this.tree.getLookupTable();
+      this.assertTrue(
+        lookupTable.contains(newBranch),
+        "New dynamically added branch should be visible in tree with hidden root"
+      );
+    },
+
     testBuildLookupWithoutLeafs() {
       var root = this.createModelAndSetModel(2);
 

package/source/class/qx/test/util/DateFormat.js

@@ -969,7 +969,7 @@ qx.Class.define("qx.test.util.DateFormat", {
         var timezoneOffset = date.getTimezoneOffset();
         var timezoneSign = timezoneOffset > 0 ? 1 : -1;
         var timezoneHours = Math.floor(Math.abs(timezoneOffset) / 60);
-        var timezoneMinutes = Math.abs(timezoneOffset) % 60;
+        var timezoneMinutes = Math.trunc(Math.abs(timezoneOffset)) % 60;
 
         var localTimeZone =
           "GMT" +

package/source/class/qx/test/util/PropertyUtil.js

@@ -35,42 +35,6 @@ qx.Class.define("qx.test.util.PropertyUtil", {
       this.button.destroy();
     },
 
-    testGetUserValue() {
-      var Prop = qx.util.PropertyUtil;
-      this.assertUndefined(Prop.getUserValue(this.button, "label"));
-
-      this.button.setLabel("juhu");
-      this.assertEquals("juhu", Prop.getUserValue(this.button, "label"));
-
-      // center has a themed value
-      this.assertUndefined(Prop.getUserValue(this.button, "center"));
-    },
-
-    testGetThemeValue() {
-      var Prop = qx.util.PropertyUtil;
-      this.assertUndefined(Prop.getThemeValue(this.button, "content"));
-      this.assertEquals(true, Prop.getThemeValue(this.button, "center"));
-    },
-
-    testGetInitValue() {
-      var Prop = qx.util.PropertyUtil;
-      this.assertUndefined(Prop.getInitValue(this.button, "content"));
-      this.assertEquals(false, Prop.getInitValue(this.button, "rich"));
-    },
-
-    testSetThemed() {
-      var Prop = qx.util.PropertyUtil;
-      this.assertNull(this.button.getIcon());
-
-      Prop.setThemed(this.button, "icon", "right.png");
-      this.assertEquals("right.png", this.button.getIcon());
-      this.assertEquals("right.png", Prop.getThemeValue(this.button, "icon"));
-
-      Prop.resetThemed(this.button, "icon");
-      this.assertNull(this.button.getIcon());
-      this.assertUndefined(Prop.getThemeValue(this.button, "icon"));
-    },
-
     testGetProperties() {
       qx.Class.define("qx.test.propA", {
         extend: qx.core.Object,

package/source/class/qx/theme/classic/Appearance.js

@@ -1465,6 +1465,27 @@ qx.Theme.define("qx.theme.classic.Appearance", {
       }
     },
 
+    "selectbox-arrow-button": "widget",
+
+    /*
+    ---------------------------------------------------------------------------
+      CHECKED SELECT BOX
+    ---------------------------------------------------------------------------
+    */
+
+    "checked-selectbox": "selectbox",
+
+    "checked-selectbox/allNone": {
+      include: "button"
+    },
+
+    "checked-selectbox/tag": "tag",
+
+    tag: {
+      alias: "button",
+      include: "button"
+    },
+
     /*
     ---------------------------------------------------------------------------
       DATE CHOOSER
@@ -1508,7 +1529,7 @@ qx.Theme.define("qx.theme.classic.Appearance", {
       style(states) {
         var result = {
           width: 17,
-          show: "icon"
+          showFeatures: "icon"
         };
 
         if (states.lastYear) {

package/source/class/qx/theme/indigo/ColorDark.js

@@ -28,6 +28,8 @@ qx.Theme.define("qx.theme.indigo.ColorDark", {
     "highlight-shade": "#dddddd",
 
     // backgrounds
+	"datechooser-background-selected-dark": "#333",
+	"datechooser-background": "#666",
     "background-selected": "#666666",
     "background-selected-disabled": "#777777",
     "background-selected-dark": "#333333",

package/source/class/qx/theme/manager/Font.js

@@ -68,6 +68,7 @@ qx.Class.define("qx.theme.manager.Font", {
   */
 
   members: {
+    _dynamic: undefined,
     _manifestFonts: null,
 
     /**
@@ -207,7 +208,11 @@ qx.Class.define("qx.theme.manager.Font", {
           this.__resolveInclude(fontDefs, fontId);
         }
 
-        if (fontDef.fontName) {
+        if (
+          fontDef.fontName &&
+          this._manifestFonts &&
+          this._manifestFonts[fontDef.fontName]
+        ) {
           let preset = this._manifestFonts[fontDef.fontName];
           Object.keys(preset).forEach(presetKey => {
             if (fontDef[presetKey] === undefined) {

package/source/class/qx/theme/manager/Meta.js

@@ -37,7 +37,8 @@ qx.Class.define("qx.theme.manager.Meta", {
     theme: {
       check: "Theme",
       nullable: false,
-      apply: "_applyTheme"
+      apply: "_applyTheme",
+      event: null
     }
   },
 

package/source/class/qx/theme/modern/Appearance.js

@@ -1728,6 +1728,27 @@ qx.Theme.define("qx.theme.modern.Appearance", {
       }
     },
 
+    "selectbox-arrow-button": "widget",
+
+    /*
+    ---------------------------------------------------------------------------
+      CHECKED SELECT BOX
+    ---------------------------------------------------------------------------
+    */
+
+    "checked-selectbox": "selectbox",
+
+    "checked-selectbox/allNone": {
+      include: "button"
+    },
+
+    "checked-selectbox/tag": "tag",
+
+    tag: {
+      alias: "button",
+      include: "button"
+    },
+
     /*
     ---------------------------------------------------------------------------
       DATE CHOOSER