@qooxdoo/framework 7.9.1 → 8.0.0-beta.1

package/source/class/qx/ui/form/Button.js

@@ -85,13 +85,15 @@ qx.Class.define("qx.ui.form.Button", {
     // does not immediately focus it before triggering the tap event
     // this causes problem with change events for any input field that
     // previously held focus, as their change event will arrive AFTER
-    // the execute event on the button ... 
+    // the execute event on the button ...
     // we have to call focus on the dom element itself, to make
     // sure we are in time. Otherwhise the virtual dom in qooxdoo will
-    // delay the effect and the fix will only work when tapping 'slowly' ... 
-    this.addListenerOnce('appear',() => {
+    // delay the effect and the fix will only work when tapping 'slowly' ...
+    this.addListenerOnce("appear", () => {
       let el = this.getContentElement().getDomElement();
-      this.addListener('touchstart', () => { el.focus();  });
+      this.addListener("touchstart", () => {
+        el.focus();
+      });
     });
 
     this.addListener("tap", this._onTap);

package/source/class/qx/ui/form/CheckedSelectBox.js

@@ -60,16 +60,16 @@ qx.Class.define("qx.ui.form.CheckedSelectBox", {
   },
 
   events: {
-    /** Event for psuedo property selection */
+    /** Event for pseudo property selection */
     changeSelection: "qx.event.type.Data",
 
-    /** Event for psuedo property checked */
+    /** Event for pseudo property checked */
     changeChecked: "qx.event.type.Data",
 
-    /** Event for psuedo property value */
+    /** Event for pseudo property value */
     changeValue: "qx.event.type.Data",
 
-    /** Event for psuedo property modelSelection */
+    /** Event for pseudo property modelSelection */
     changeModelSelection: "qx.event.type.Data",
 
     /** Fired when a tag widget is added to the results; data is a map containing:
@@ -88,7 +88,7 @@ qx.Class.define("qx.ui.form.CheckedSelectBox", {
   },
 
   members: {
-    /** @type {qx.data.Array} the modelSelection psuedo property */
+    /** @type {qx.data.Array} the modelSelection pseudo property */
     __modelSelection: null,
 
     /** @type {qx.ui.basic.Atom[]} atoms used to show the selection */
@@ -186,7 +186,7 @@ qx.Class.define("qx.ui.form.CheckedSelectBox", {
     },
 
     /**
-     * Getter for psuedo property "checked"
+     * Getter for pseudo property "checked"
      *
      * @return {qx.ui.form.IListItem[]}
      */
@@ -195,7 +195,7 @@ qx.Class.define("qx.ui.form.CheckedSelectBox", {
     },
 
     /**
-     * Setter for psuedo property "checked"
+     * Setter for pseudo property "checked"
      *
      * @param checked {qx.ui.form.IListItem[]}
      */
@@ -204,7 +204,7 @@ qx.Class.define("qx.ui.form.CheckedSelectBox", {
     },
 
     /**
-     * Reset for psuedo property "checked"
+     * Reset for pseudo property "checked"
      */
     resetChecked() {
       this.getChildControl("list").resetChecked();

package/source/class/qx/ui/form/FileSelectorButton.js

@@ -99,7 +99,7 @@ qx.Class.define("qx.ui.form.FileSelectorButton", {
      * `user` indicates the user-facing camera.
      * `environment` indicates the camera facing away from the user.
      */
-    capture: {
+    captureCamera: {
       nullable: true,
       check: ["user", "environment"],
       apply: "_applyAttribute"

package/source/class/qx/ui/form/Form.js

@@ -88,6 +88,7 @@ qx.Class.define("qx.ui.form.Form", {
       this.__groups[this._groupCounter].items.push(item);
       this.__groups[this._groupCounter].labels.push(label);
       this.__groups[this._groupCounter].options.push(options);
+
       // if no name is given, use the label without not working character
       if (name == null) {
         name = label.replace(
@@ -95,6 +96,8 @@ qx.Class.define("qx.ui.form.Form", {
           ""
         );
       }
+      // Store the name as provided (no conversion here)
+      // The data controller will convert to camelCase when creating the model
       this.__groups[this._groupCounter].names.push(name);
 
       // add the item to the validation manager

package/source/class/qx/ui/form/IListItem.js

@@ -52,7 +52,9 @@ qx.Interface.define("qx.ui.form.IListItem", {
      * @return {Boolean|null}
      */
     setReadOnly(value) {
-      this.assertArgumentsCount(arguments, 1, 1);
+      if (qx.core.Environment.get("qx.debug")) {
+        this.assertArgumentsCount(arguments, 1, 1);
+      }
     },
 
     /**

package/source/class/qx/ui/form/IRadioItem.js

@@ -61,7 +61,9 @@ qx.Interface.define("qx.ui.form.IRadioItem", {
      *     manage the item.
      */
     setGroup(value) {
-      this.assertInstance(value, qx.ui.form.RadioGroup);
+      if (qx.core.Environment.get("qx.debug")) {
+        this.assertInstance(value, qx.ui.form.RadioGroup);
+      }
     },
 
     /**

package/source/class/qx/ui/form/MForm.js

@@ -75,7 +75,9 @@ qx.Mixin.define("qx.ui.form.MForm", {
   members: {
     // apply method
     _applyValid(value, old) {
-      value ? this.removeState("invalid") : this.addState("invalid");
+      if (typeof this.addState === "function") {
+        value ? this.removeState("invalid") : this.addState("invalid");
+      }
     },
 
     /**

package/source/class/qx/ui/form/Slider.js

@@ -150,8 +150,12 @@ qx.Class.define("qx.ui.form.Slider", {
      * on this, please use {@link #slideTo} instead.
      */
     value: {
-      check:
-        "typeof value==='number'&&value>=this.getMinimum()&&value<=this.getMaximum()",
+      check: function(value) {
+        return (
+          typeof value === 'number' &&
+            value >= this.getMinimum() &&
+            value <= this.getMaximum());
+      },
       init: 0,
       apply: "_applyValue",
       nullable: true

package/source/class/qx/ui/form/SplitButton.js

@@ -116,13 +116,13 @@ qx.Class.define("qx.ui.form.SplitButton", {
      * Configure the visibility of the sub elements/widgets.
      * Possible values: both, text, icon
      */
-    show: {
+    showFeatures: {
       init: "both",
       check: ["both", "label", "icon"],
       themeable: true,
       inheritable: true,
-      apply: "_applyShow",
-      event: "changeShow"
+      apply: "_applyShowFeatures",
+      event: "changeShowFeatures"
     },
 
     /** The menu instance to show when tapping on the button */
@@ -164,7 +164,7 @@ qx.Class.define("qx.ui.form.SplitButton", {
         case "arrow":
           control = new qx.ui.form.MenuButton();
           control.setFocusable(false);
-          control.setShow("both");
+          control.setShowFeatures("both");
           this._addAt(control, 1);
           break;
       }
@@ -230,7 +230,7 @@ qx.Class.define("qx.ui.form.SplitButton", {
     },
 
     // property apply
-    _applyShow(value, old) {
+    _applyShowFeatures(value, old) {
       // pass: is already inherited to the button
     },
 

package/source/class/qx/ui/form/TextField.js

@@ -56,8 +56,7 @@ qx.Class.define("qx.ui.form.TextField", {
     _renderContentElement(innerHeight, element) {
       if (
         qx.core.Environment.get("engine.name") == "mshtml" &&
-        (parseInt(qx.core.Environment.get("engine.version"), 10) < 9 ||
-          qx.core.Environment.get("browser.documentmode") < 9)
+        (parseInt(qx.core.Environment.get("engine.version"), 10) < 9 || qx.core.Environment.get("browser.documentmode") < 9)
       ) {
         element.setStyles({
           "line-height": innerHeight + "px"

package/source/class/qx/ui/form/validation/Manager.js

@@ -64,8 +64,12 @@ qx.Class.define("qx.ui.form.validation.Manager", {
      * @type {Function | AsyncValidator}
      */
     validator: {
-      check:
-        "value instanceof Function || qx.Class.isSubClassOf(value.constructor, qx.ui.form.validation.AsyncValidator)",
+      check: function(value) {
+        return (
+          value instanceof Function ||
+            qx.Class.isSubClassOf(
+              value.constructor, qx.ui.form.validation.AsyncValidator));
+      },
       init: null,
       nullable: true
     },

package/source/class/qx/ui/menubar/Button.js

@@ -35,7 +35,7 @@ qx.Class.define("qx.ui.menubar.Button", {
       init: "menubar-button"
     },
 
-    show: {
+    showFeatures: {
       refine: true,
       init: "inherit"
     }

package/source/class/qx/ui/mobile/basic/Atom.js

@@ -87,11 +87,11 @@ qx.Class.define("qx.ui.mobile.basic.Atom", {
      * Configure the visibility of the sub elements/widgets.
      * Possible values: both, text, icon
      */
-    show: {
+    showFeatures: {
       init: "both",
       check: ["both", "label", "icon"],
       inheritable: true,
-      apply: "_applyShow"
+      apply: "_applyShowFeatures"
     },
 
     /**
@@ -125,7 +125,7 @@ qx.Class.define("qx.ui.mobile.basic.Atom", {
     },
 
     // property apply
-    _applyShow(value, old) {
+    _applyShowFeatures(value, old) {
       if (this.__label) {
         if (value === "both" || value === "label") {
           this.__label.show();
@@ -294,10 +294,10 @@ qx.Class.define("qx.ui.mobile.basic.Atom", {
       }
 
       // Show/Hide Label/Icon
-      if (this.getShow() === "icon" && this.__label) {
+      if (this.getShowFeatures() === "icon" && this.__label) {
         this.__label.exclude();
       }
-      if (this.getShow() === "label" && this.__icon) {
+      if (this.getShowFeatures() === "label" && this.__icon) {
         this.__icon.exclude();
       }
 

package/source/class/qx/ui/mobile/dialog/Menu.js

@@ -45,6 +45,8 @@ qx.Class.define("qx.ui.mobile.dialog.Menu", {
    * @param anchor {qx.ui.mobile.core.Widget ?} The anchor widget for this item. If no anchor is available, the menu will be displayed modal and centered on screen.
    */
   construct(itemsModel, anchor) {
+    super((this.__menuContainer = new qx.ui.mobile.container.Composite()), anchor);
+
     // Create the list with a delegate that
     // configures the list item.
     this.__selectionList = this._createSelectionList();
@@ -53,15 +55,12 @@ qx.Class.define("qx.ui.mobile.dialog.Menu", {
       this.__selectionList.setModel(itemsModel);
     }
 
-    this.__menuContainer = new qx.ui.mobile.container.Composite();
     this.__clearButton = this._createClearButton();
     this.__listScroller = this._createListScroller(this.__selectionList);
 
     this.__menuContainer.add(this.__listScroller);
     this.__menuContainer.add(this.__clearButton);
 
-    super(this.__menuContainer, anchor);
-
     if (anchor) {
       this.setModal(false);
     } else {
@@ -175,9 +174,7 @@ qx.Class.define("qx.ui.mobile.dialog.Menu", {
      * @return {qx.ui.mobile.form.Button} the clearButton of this menu.
      */
     _createClearButton() {
-      var clearButton = new qx.ui.mobile.form.Button(
-        this.getClearButtonLabel()
-      );
+      var clearButton = new qx.ui.mobile.form.Button(this.getClearButtonLabel());
 
       clearButton.addListener("tap", this.__onClearButtonTap, this);
       clearButton.exclude();
@@ -217,19 +214,11 @@ qx.Class.define("qx.ui.mobile.dialog.Menu", {
       listScrollerHeight = parseInt(listScrollerHeight, 10);
 
       if (this.getVisibleListItems() !== null) {
-        var newListScrollerHeight =
-          this.__selectionList.getListItemHeight() * this.getVisibleListItems();
-        listScrollerHeight = Math.min(
-          newListScrollerHeight,
-          listScrollerHeight
-        );
+        var newListScrollerHeight = this.__selectionList.getListItemHeight() * this.getVisibleListItems();
+        listScrollerHeight = Math.min(newListScrollerHeight, listScrollerHeight);
       }
 
-      qx.bom.element.Style.set(
-        this.__listScroller.getContainerElement(),
-        "maxHeight",
-        listScrollerHeight + "px"
-      );
+      qx.bom.element.Style.set(this.__listScroller.getContainerElement(), "maxHeight", listScrollerHeight + "px");
 
       super._updatePosition();
     },
@@ -259,11 +248,7 @@ qx.Class.define("qx.ui.mobile.dialog.Menu", {
       });
 
       // Add an changeSelection event
-      selectionList.addListener(
-        "changeSelection",
-        this.__onListChangeSelection,
-        this
-      );
+      selectionList.addListener("changeSelection", this.__onListChangeSelection, this);
 
       selectionList.addListener("tap", this._onSelectionListTap, this);
       return selectionList;
@@ -353,9 +338,7 @@ qx.Class.define("qx.ui.mobile.dialog.Menu", {
      */
     scrollToItem(index) {
       if (index !== null && this.__selectionList.getModel() != null) {
-        var listItems = qxWeb(
-          "#" + this.__listScroller.getId() + " .list-item"
-        );
+        var listItems = qxWeb("#" + this.__listScroller.getId() + " .list-item");
 
         var targetListItemElement = listItems[index];
         this.__listScroller.scrollToElement(targetListItemElement);
@@ -365,11 +348,6 @@ qx.Class.define("qx.ui.mobile.dialog.Menu", {
 
   destruct() {
     this.__selectionList.removeListener("tap", this._onSelectionListTap, this);
-    this._disposeObjects(
-      "__selectionList",
-      "__clearButton",
-      "__listScroller",
-      "__menuContainer"
-    );
+    this._disposeObjects("__selectionList", "__clearButton", "__listScroller", "__menuContainer");
   }
 });

package/source/class/qx/ui/mobile/dialog/Popup.js

@@ -140,11 +140,16 @@ qx.Class.define("qx.ui.mobile.dialog.Popup", {
     __widget: null,
     __titleWidget: null,
     __lastPopupDimension: null,
+    /**
+     * Flag which ignores event domupdated caused by this widget and stopps infinite recursive `_updatePosition` calls
+     */
+    __updatePositionStarted: false,
 
     /**
      * Event handler. Called whenever the position of the popup should be updated.
      */
     _updatePosition() {
+      this.__updatePositionStarted = true;
       // Traverse single anchor classes for removal, for preventing 'domupdated' event if no CSS classes changed.
       var anchorClasses = ["top", "bottom", "left", "right", "anchor"];
       for (var i = 0; i < anchorClasses.length; i++) {
@@ -446,7 +451,14 @@ qx.Class.define("qx.ui.mobile.dialog.Popup", {
         flex: 1
       });
 
-      widget.addListener("domupdated", this._updatePosition, this);
+      widget.addListener("domupdated", () => {
+        if (!this.__updatePositionStarted){
+          this._updatePosition();
+        }
+        else {
+          this.__updatePositionStarted = false;
+        }
+      }, this);
 
       this.__widget = widget;
     },

package/source/class/qx/ui/table/pane/FocusIndicator.js

@@ -125,8 +125,11 @@ qx.Class.define("qx.ui.table.pane.FocusIndicator", {
             }
           }
           var userHeight = rowHeight + (wt + wb - 2);
-          var renderedRowHeight = this.__scroller.getTablePane().getRenderedRowHeight();
-          var userTop = Math.floor((row - firstRow) * renderedRowHeight) - (wt - 1);
+          var renderedRowHeight = this.__scroller
+            .getTablePane()
+            .getRenderedRowHeight();
+          var userTop =
+            Math.floor((row - firstRow) * renderedRowHeight) - (wt - 1);
           if (
             editing &&
             this.__scroller.getMinCellEditHeight() &&

package/source/class/qx/ui/table/pane/Scroller.js

@@ -1533,21 +1533,17 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
       // so we'll override this method with a null one, and do the menu
       // placement and display handling in our _onContextMenu method.
     },
-
     /**
      * Event handler. Called when the user double tapped a pointer button over the pane.
      *
      * @param e {Map} the event.
-     */
-    _onDbltapPane(e) {
+     */ _onDbltapPane(e) {
       var pageX = e.getDocumentLeft();
       var pageY = e.getDocumentTop();
       var col = this._getColumnForPageX(pageX);
-
       if (col !== null) {
         this._focusCellAtPagePos(pageX, pageY);
         this.startEditing();
-
         var row = this._getRowForPagePos(pageX, pageY);
         if (row != -1 && row != null) {
           this.fireEvent(
@@ -1559,44 +1555,33 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
         }
       }
     },
-
     /**
      * Event handler. Called when the pointer moved out.
      *
      * @param e {Map} the event.
-     */
-    _onPointerout(e) {
+     */ _onPointerout(e) {
       var table = this.getTable();
-
       if (!table.getEnabled()) {
         return;
-      }
-
-      // Reset the resize cursor when the pointer leaves the header
+      } // Reset the resize cursor when the pointer leaves the header
       // If currently a column is resized then do nothing
       // (the cursor will be reset on pointerup)
       if (this.__resizeColumn == null) {
         this.setCursor(null);
         this.getApplicationRoot().setGlobalCursor(null);
       }
-
-      this.__header.setPointerOverColumn(null);
-
-      // in case the focus follows the pointer, it should be remove on pointerout
+      this.__header.setPointerOverColumn(null); // in case the focus follows the pointer, it should be remove on pointerout
       if (this.getFocusCellOnPointerMove()) {
         this.__table.setFocusedCell();
       }
     },
-
     /**
      * Shows the resize line.
      *
      * @param x {Integer} the position where to show the line (in pixels, relative to
      *      the left side of the pane).
-     */
-    _showResizeLine(x) {
+     */ _showResizeLine(x) {
       var resizeLine = this._showChildControl("resize-line");
-
       var width = resizeLine.getWidth();
       var paneBounds = this._paneClipper.getBounds();
       resizeLine.setUserBounds(
@@ -1973,16 +1958,14 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
     _onFocusinCellEditorAddBlurListener(e) {
       this.debug("executed FOCUSIN event listener for hash: " + e.getTarget().$$hash);
       qx.event.Timer.once(function() {
-        this._cellEditor.addListenerOnce('blur', this._onBlurCellEditorStopEditing, this);
-        this.debug('added BLUR listener to hash: ' + this._cellEditor.$$hash);
+        this._cellEditor.addListener('focusout', this._onFocusoutCellEditorStopEditing, this);
+        this.debug('added FOCUSOUT listener to hash: ' + this._cellEditor.$$hash);
       }, this, 1);
     },
 
-    /**
-     * Stop editing whenever the cell editor blurs.
-     */
-    _onBlurCellEditorStopEditing(e) {
-      this.debug("executed BLUR listener for hash " + e.getTarget().$$hash);
+
+    _onFocusoutCellEditorStopEditing(e) {
+      this.debug("executed FOCUSOUT listener for hash " + e.getTarget().$$hash);
       if (this._cellEditor === e.getTarget()) {
         this.debug('hash: ' + this._cellEditor.$$hash);
         switch (this.getTable().getCellEditorBlurAction()) {
@@ -2408,4 +2391,4 @@ qx.Class.define("qx.ui.table.pane.Scroller", {
       "__clipperContainer"
     );
   }
-});
+});

package/source/class/qx/ui/table/selection/Model.js

@@ -113,6 +113,7 @@ qx.Class.define("qx.ui.table.selection.Model", {
   */
 
   members: {
+    hasBatchModeRefCount: 0,
     __hadChangeEventInBatchMode: null,
     __anchorSelectionIndex: null,
     __leadSelectionIndex: null,

package/source/class/qx/ui/toolbar/Button.js

@@ -36,7 +36,7 @@ qx.Class.define("qx.ui.toolbar.Button", {
       init: "toolbar-button"
     },
 
-    show: {
+    showFeatures: {
       refine: true,
       init: "inherit"
     }

package/source/class/qx/ui/toolbar/CheckBox.js

@@ -35,7 +35,7 @@ qx.Class.define("qx.ui.toolbar.CheckBox", {
       init: "toolbar-button"
     },
 
-    show: {
+    showFeatures: {
       refine: true,
       init: "inherit"
     }

package/source/class/qx/ui/toolbar/FileSelectorButton.js

@@ -33,8 +33,7 @@ qx.Class.define("qx.ui.toolbar.FileSelectorButton", {
       refine: true,
       init: "toolbar-button"
     },
-
-    show: {
+    showFeatures: {
       refine: true,
       init: "inherit"
     },

package/source/class/qx/ui/toolbar/Part.js

@@ -61,11 +61,11 @@ qx.Class.define("qx.ui.toolbar.Part", {
     },
 
     /** Whether icons, labels, both or none should be shown. */
-    show: {
+    showFeatures: {
       init: "both",
       check: ["both", "label", "icon"],
       inheritable: true,
-      event: "changeShow"
+      event: "changeShowFeatures"
     },
 
     /** The spacing between every child of the toolbar */

package/source/class/qx/ui/toolbar/PartContainer.js

@@ -43,11 +43,11 @@ qx.Class.define("qx.ui.toolbar.PartContainer", {
     },
 
     /** Whether icons, labels, both or none should be shown. */
-    show: {
+    showFeatures: {
       init: "both",
       check: ["both", "label", "icon"],
       inheritable: true,
-      event: "changeShow"
+      event: "changeShowFeatures"
     }
   },